- 28 Feb, 2020 40 commits
-
-
Colin Pacitti authored
This has already been implemented for its Windows counterpart. It is a simple change for mac to just pass the DMG file path to InstallFromDMG() function. Bug: 1051763 Change-Id: Ia0858532e9c756210a1b5288bd347bd7dcd055d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065309 Commit-Queue: Colin Pacitti <copacitt@microsoft.com> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#745648}
-
Hailey Wang authored
A trace is uploaded via "slow reports" when a long navigation to first contentful paint is detected (for opted-in clients). This trace event will make it easier to identify the location of the long delay when analyzing the trace. Bug: 1055890 Change-Id: I8e58ada28976fcea2bd2a799021e90ddd0231567 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076279Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Hailey Wang <haileywang@google.com> Cr-Commit-Position: refs/heads/master@{#745647}
-
Chris Mumford authored
xrSession_requestAnimationFrame_getViewerPose.https.html is flakey and fails approximately 20% of the time. Also, fixed bug number in prior line disabling oopif-storage.js. TBR=tguilbert@chromium.org Bug: 1056879 Change-Id: I18739671f245c98fed28a2bc0d2329ee08f9c0e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080555 Commit-Queue: Chris Mumford <cmumford@google.com> Reviewed-by:
Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#745646}
-
Jeremie Boulic authored
Before this change, when there's a single user on a device, the storage handler immediately returns '0 B' as the "Other users" size. This change hides the "Other users" row entirely on the storage page instead. Test: browser_tests --gtest_filter="*OSSettingsDevicePageTest.StorageTest" Bug: 1056491 Change-Id: Ibbc587ff702c5cc419eab35e7c0129674a9f9897 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076747Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#745645}
-
Dave Tapuska authored
In the effort to move the ownership of compositing over to blink add a method for testing that will ApplyViewportChanges. Currently this method just calls ApplyViewportChanges but that method will eventually be removed. Change-Id: Iba3bcb2570eefe3cd321973f2647c1c214e6f681 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080454Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#745644}
-
Scott Violet authored
A list implies a certain order. getTabs() does not return a particular order. This converts the return value to a Set to reinforce the order is not defined. This is an incomptible API change. The change is purely in the client library, so there is worry about compatibility with different implementation versions. This change was requested by Alihan, and they understand it is incomptible. BUG=none TEST=none Change-Id: I5c4777b6624ba501c0708eacc7d81217a17f253e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080478Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#745643}
-
Tom McKee authored
Change-Id: I496c377a48f560d3f7ed2cee5cd10376523c3db3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080694Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Tom McKee <tommckee@chromium.org> Cr-Commit-Position: refs/heads/master@{#745642}
-
Zhenyao Mo authored
There are multiple reasons the info collection GPU process may not launch. Make sure certain DevicePerfInfo fields are collected. Otherwise the histograms could be biased. BUG=1039792 TEST=manual R=magchen@chromium.org,sky@chromium.org Change-Id: I2c0fee99935e55b6d1a65982bdbf5da38f95eef7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079852 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#745641}
-
Felipe Erias authored
Export and adapt printing/page-rule-css-text.html to WPT, providing automated tests for the parsing of different uses and declarations of the CSS @page rule, including inside @media rules and for properties of HTML elements. R=rego@igalia.com Change-Id: I790370832d3a300f78da683481bb48ca5e53985b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074837Reviewed-by:
Manuel Rego <rego@igalia.com> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#745640}
-
Noel Gordon authored
Bug: 763885 Change-Id: Id02e0e5223d305f4d61f9054e28e309281154809 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079717Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#745639}
-
Collin Baker authored
Fixes the following: - Fractional part of drag updates was thrown away, causing the current height to lag behind the touch position. The error compounded the longer the drag was in progress. - Tab strip got stuck when dragged slowly to the fully open or closed position. Animations don't get run when they're at their target value, but I assumed otherwise. - Incorrect assumptions about ordering of ET_GESTURE_SCROLL_END, ET_GESTURE_SWIPE, and ET_GESTURE_END resulted in occasional DCHECKs. Changed to be more permissive. Bug: 1043374 Change-Id: Iedab85a33bf6c89b51f1a88e73864ba32e885781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076783Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#745638}
-
Collin Baker authored
The failure in init_simd() is benign and won't be fixed; see https://github.com/libjpeg-turbo/libjpeg-turbo/issues/87. Bug: 1056011 Change-Id: I2bc3827b4313371e00b46ba3362a9c98499f9450 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076278Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#745637}
-
Wan-Teh Chang authored
Update callers of VideoDecoder::Reset() to ensure they are using a OnceCallback or BindOnce. Change-Id: I3560af2fd75dafc1ea1e4cc471b00b1cef2d17e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079781 Commit-Queue: Wan-Teh Chang <wtc@google.com> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#745636}
-
Nathan Zabriskie authored
With crrev.com/c/1888951 the display compositor initializes textures to a known state at draw time so we don't need to manually save/ restore this state after the texture is used by Skia. These calls are also potential causes of slowdown when copying WebGL/Canvas as discussed on crbug.com/1048896. Removing this usage of ContextGL also helps prepare for Canvas' transition to OOP-Rasterization, crbug.com/1018894. Bug: 1023270, 1048896 Change-Id: I80e070ec8d1210312ff6bd430c30cfdab2c4f9b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078979 Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#745635}
-
Fredrik Söderquist authored
AddURLRectsForInlineChildrenRecursively() is currently called from within LineBoxListPainter::ShouldPaint(), which seems like an odd place since that's sounds like (and otherwise is) a predicate function. Hoist the call out of ShouldPaint() and into the callers. Since PaintBackplate() is only called in the kForcedColorsModeBackplate paint phase we can drop it in that case. Also drop the paint phase check in PaintBackplate() since it's caller already checks it. Change-Id: I4e28b126138f884dd411d0ef44ef949371173421 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080429 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#745634}
-
Evan Stade authored
Bug: 1036028 Change-Id: If402bda0f6532f1254a710223ff66bb77e0cf15f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079530Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#745633}
-
Eric Orth authored
This reverts commit ee60735b. Original commit f02f7639. Fix was just to rebase and made some minor compile fixes for the rebase. Bug: 1022059 Change-Id: I14181e1320cc3dd83392beb36213b91e76bc65af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079201 Commit-Queue: Eric Orth <ericorth@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Auto-Submit: Eric Orth <ericorth@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#745632}
-
Caleb Raitto authored
Add the initial benchmark, which measures double privacy budget UKM serialization performance. Bug: 973801 Change-Id: I90403af701246cf8575681c0789b2344622b1261 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075477 Commit-Queue: Caleb Raitto <caraitto@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#745631}
-
Mark Yacoub authored
This reverts commit b0806021. Reason for revert: Causes "this monitor is not getting along" notification using CableMatters DP2 dock with 1 display Original change's description: > Ozone: Implement Atomic Modeset > > If the device supports KMS Atomic APIs, Enable CRTC using Atomic Modeset > Commit instead of legacy SetCRTC. > > BUG=987274 > TEST=HardwareDisplayControllerTest.CheckModesettingSetsProps > HardwareDisplayPlaneManagerAtomicTest.CheckPropsAfterModeset > > Change-Id: I116a2caf8602aa6470c9cf17a65fa12c045f8d6b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039752 > Commit-Queue: Mark Yacoub <markyacoub@google.com> > Auto-Submit: Mark Yacoub <markyacoub@google.com> > Reviewed-by: Daniel Nicoara <dnicoara@chromium.org> > Cr-Commit-Position: refs/heads/master@{#740811} Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1056900 Change-Id: Ia9641a5089afac272e7bb1299072b5dbac4ec304 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080775 Auto-Submit: Mark Yacoub <markyacoub@google.com> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Commit-Queue: Mark Yacoub <markyacoub@google.com> Cr-Commit-Position: refs/heads/master@{#745630}
-
Lijin Shen authored
1. The language is not properly set as blocked. 2. Re-generate the list items after click actions to toggle the tick mark. Bug: 1057051 Change-Id: I860a3224b72f00badd1c5509086aa892a33cdf7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080447Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Lijin Shen <lazzzis@chromium.org> Cr-Commit-Position: refs/heads/master@{#745629}
-
John Williams authored
The previous code was written using the mistaken assumption that only mirroring sessions should have a tab ID. This had the effect of making it impossible to re-connect to a casting session after refreshing the tab. Bug: 1054491 Change-Id: Ic8ec2946af8ad28c8cea8c0698c1644c46ff5a63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078795Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: John Williams <jrw@chromium.org> Cr-Commit-Position: refs/heads/master@{#745628}
-
Ehsan Kia authored
Bug: 1055514 Change-Id: Icb49beb89520cf49e1676f0ef9a301a91a703332 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080672Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Commit-Queue: Ehsan Kia <ehsankia@google.com> Cr-Commit-Position: refs/heads/master@{#745627}
-
Caleb Raitto authored
This project was never finished, and we have no current plans to continue development. Bug: 973603,1055065 Change-Id: I929730aec39d84ea3c31e5d726d7b0af6d9f15cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079205Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: Caleb Raitto <caraitto@chromium.org> Cr-Commit-Position: refs/heads/master@{#745626}
-
dpapad authored
Previously every member of that typedef was marked as potentially undefined. This required a type-casting whenever a !settings.Route was expected, which was tedious without producing any type-coverage benefits. As a result of this change a lot of typecasts like the following /** @type {!settings.Route} */ (settings.routes.FONTS) are no longer necessary and are removed. Bug: 1026426 Change-Id: I0becc11cc8a5479c4390d4499e4956f73126c8ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078822 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#745625}
-
evliu authored
Bug: 1056809 Change-Id: Ib787b4495a05a78a3e49bc00e4770d81a23fafec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080088Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#745624}
-
rbpotter authored
Bug: 1026426 Change-Id: I3a53c0d008e6b97f1a9574bf68ddab06981d7623 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076087 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#745623}
-
Nnamdi Theodore Johnson-Kanu authored
This CL moves chromeOS strings for settings about page from settings_strings.grdp to os_settings_strings.grdp. It continues the process of moving all chromeOS specific strings. Bug: 967883 Change-Id: Ibb1306490bd1bce9165d618e2c52c8dc783ae8be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070378 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
-
Rahul Arakeri authored
This CL adds RTL web tests. Change-Id: I64d5afb101c08035b33e2648bc68e8b677066871 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063967 Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e43a2a568976..f447425f9f7f git log e43a2a568976..f447425f9f7f --date=short --first-parent --format='%ad %ae %s' 2020-02-28 chiur@google.com Merge "Fix crash when track event are mixed with atrace events" Created with: gclient setdep -r src/third_party/perfetto@f447425f9f7f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I04af7f3b7a6f13b5c04cf17ccdea5e8ce14518cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080584Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745620}
-
Forest Fraser authored
Bug: b/149108108 Test: None Change-Id: I680a9c7b0566d8534f1648406be0dd8ac479c037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079844 Auto-Submit: Forest Fraser <ffraser@google.com> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#745619}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e31f2d43. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" 98c33104 "[webauthn] WPT: Clean up virtual authenticators" f73c9cfb "COEP: Add CacheStorage+DedicatedWorker WPT tests." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I70b16e425593596bcfd7fe2108b65665ca83b8d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079637Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745618}
-
Klaus Weidner authored
This isn't technically needed since the DOM overlay element effectively acts as the root element while active, so the backdrop doesn't get drawn. See also https://github.com/immersive-web/dom-overlays/issues/15 Bug: 991747 Change-Id: I23862f2fbc8434813bb4248695ff37cb62cd48e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078803Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#745617}
-
Ryan Sturm authored
When a user is idle (i.e., has not navigated or foreground/background the tab for 5 minutes), we should stop attempting to preconnect to the foreground tab. Bug: 1055256 Change-Id: I76324c36508f0ee8720058db6f02235df482c693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076217Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#745616}
-
Nnamdi Theodore Johnson-Kanu authored
This CL moves chromeOS strings for settings people page strings from settings_strings.grdp to os_settings_strings.grdp. It continues the process of moving all chromeOS specific strings. Bug: 967883 Change-Id: I1129aa982124596f102d1586f2a183ab894d9b92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070411 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/817bf7ab..c6bde393 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I732188bb10eda8691a953f7dfcb3ae9f37a6b614 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079638Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745614}
-
Abigail Klein authored
Introduce the caption bubble inside of chrome/browser/accessibility and instantiate it from browser_view behind the kLiveCaption flag. Bug: 1055150 Change-Id: I316a52f22b7bf50627bf481192fb15006fc2efb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068727Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#745613}
-
Thomas Guilbert authored
This CL decreases the resolution of the presentationTime, expectedPresentationTime, elapsedProcessingTime and captureTime fields, to limit potential timing attacks. expectedPresentationTime should correspond to an animation frame timestamp and technically shouldn't need be clamped. However, this is not always the case in the WebRTC path, and we should keep it clamped for now. Bug: 1012063 Change-Id: Ie9247be8f3c91e2fef3d62cf939b1d8488f0a75a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071113Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#745612}
-
Daniel Clark authored
This change removes support for the following hotkeys in date/week/month/datetime-local popups: m/M: Advance to next/previous month y/Y: Advance to next/previous year d/D: Advance to next/previous decade t: Select the current day The refreshed control implementation inherited these from the old implementation, but their value is questionable. PageDown/PageUp is a more intuitive version of m/M for changing month. Selecting the current day by keyboard can be achieved by tabbing to the 'Today' button and pressing Enter. This is more keystrokes but this should be ok because it is not an action that the user would need to perform more than once once per popup. There is no equivalent to y/Y or d/D for advancing by year/decade, but these do not seem like common scenarios. If they were, we would want to provide a more visible mechanism for achieving this. All of these hotkeys are non-discoverable aside from trial and error. As such they may be as likely to cause user confusion when stumbled across accidentally as they are to help. Given the above considerations, this change removes them. Bug: 1052388 Change-Id: I2602250352df6569100df1ba512cd624c9bd2f64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079219Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Ionel Popescu <iopopesc@microsoft.com> Commit-Queue: Dan Clark <daniec@microsoft.com> Cr-Commit-Position: refs/heads/master@{#745611}
-
Nicolás Peña Moreno authored
This CL adds TBT to TTI's trace event by keeping track of the longtasks and using the list to compute TBT as soon as TTI is known. The computation is done inside the trace event to avoid running the code when tracing is disabled. An args param is added because there are no macros supporting more than 2 args, so two of them are merged into a single TracedValue param. Bug: 1055806 Change-Id: Ided9c2378aff6d98cbdf5e88e99d46735b92e284 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079616Reviewed-by:
Deep Roy <dproy@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#745610}
-
Chris Mumford authored
This reverts commit dfd901d6. Reason for revert: TabsSnapshotTest.Test is > 50% flakey. See https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel/8642 Original change's description: > User data downgrade: Test snapshot tabs state > > Bug: 958893 > Change-Id: If0cc3e0cd1e70a3b21c675b3979166f7aaba554d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076438 > Commit-Queue: Yann Dago <ydago@chromium.org> > Reviewed-by: Greg Thompson <grt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#745474} TBR=grt@chromium.org,ydago@chromium.org Change-Id: Idab515fc68a966222463a74341f46929464d97c8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 958893 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080811Reviewed-by:
-
