- 06 Aug, 2018 40 commits
-
-
Fady Samuel authored
OnSurfaceDiscarded cosists of two operations: 1. Drop tracking of dependencies of the discarded surface. 2. Unblock surfaces blocked ont he discarded surface. 1. is equivalent to listing all activation dependencies as 'removed_dependencies' and calling OnSurfaceDependenciesChanged. This CL does just that, reducing the number of lines of code in SurfaceDependencyTracker further. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I8191f1be81d04cce0c2181ac4fc341ebb8e3cf3f Bug: 672962 Reviewed-on: https://chromium-review.googlesource.com/1163632 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#581016}
-
Daniel Zhang authored
Fixing a bug that involves SearchResult tile text being cut off on the second line of text. Standardized text style between SearchResults and SearchResultTileItems. Bug: 869632 Change-Id: Ifbcc68c29c17b78a5d2323aa59dc98a759b81b34 Reviewed-on: https://chromium-review.googlesource.com/1162742Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Daniel Zhang <oxyflush@google.com> Cr-Commit-Position: refs/heads/master@{#581015}
-
David Roger authored
The order of the enum in enums.xml did not match the order from the code, resulting in wrong labels on the histograms. In the code, the type is TokenRevocationRequestProgress, defined in mutable_profile_oauth2_token_service_delegate.cc This CL fixes the label of the histogram. Bug: 834720 Change-Id: I30b039a8f5c9c2181bc1a77d807123eab53272fb Reviewed-on: https://chromium-review.googlesource.com/1163680Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#581014}
-
Scott Violet authored
BUG=842365 TEST=none Change-Id: I3f29c66f1d82c88eaff7da4c8b99ee6aed4902cc Reviewed-on: https://chromium-review.googlesource.com/1164075Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#581013}
-
Xiaoqian Dai authored
1) If the overview ends because a window (either from overview or not) just got snapped, we should not do animation when exiting overview. 2) If the overview ends because of releasing a dragged window, we also should not do animation when exiting overview. Bug: 823769 Test: SplitViewControllerTest.OverviewExitAnimationTest, SplitViewTabDraggingTest.OverviewExitAnimationTest Change-Id: I506120348f55ac7c86ec581ede08473c14f6e128 Reviewed-on: https://chromium-review.googlesource.com/1162587 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#581012}
-
Jared Saul authored
Bug: 868552 Change-Id: I6a796cdcc0d4aa27750caa8a93581f205d4e8409 Reviewed-on: https://chromium-review.googlesource.com/1161569Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#581011}
-
gogerald authored
Bug: 806868 Change-Id: I9290cc5830308134e14b23be0d87eb5b11dd0d6e Reviewed-on: https://chromium-review.googlesource.com/1156480 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#581010}
-
Clark DuVall authored
This reverts commit c9cbab07. Reason for revert: Breaking linux dbg bots: https://luci-milo.appspot.com/buildbot/chromium.linux/Linux%20Tests%20(dbg)(1)/73603 Original change's description: > Fix ExtensionWebRequestApiTest.WebRequestUnloadImmediately with network service > > The error event was not being sent when the client was reset. > > Bug: 721414 > Cq-Include-Trybots: luci.chromium.try:linux_mojo > Change-Id: I951422061022d50644d8453900af14be27bb9eaf > Reviewed-on: https://chromium-review.googlesource.com/1150403 > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580911} TBR=jam@chromium.org,cduvall@chromium.org Change-Id: I56a28f0f2ebd8f3ec57aa0af0a94e317d7cffcaa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 721414 Cq-Include-Trybots: luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1164208Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#581009}
-
Chris Harrelson authored
Previously we unconditionally invalidated both on any style change. Most of the changes in this patch are updates of code that looks like: SetNeedsPaintPropertyUpdate(); to: SetNeedsPaintPropertyUpdate(); if (Layer()) Layer()->SetNeedsCompositingInputsUpdate(); in cases where the LayoutObject in question might have a PaintLayer. The call to SetNeedsCompositingInputsUpdate() cannot be pushed down into SetNeedsPaintPropertyUpdate() because SetNeedsPaintPropertyUpdate() is called from SPv1 compositing code post-inputs, and it's illegal to set lifecycle bits for that phase after it has already completed. Bug: 814439 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I8c2aa3d451ad24e6feb0b14858bdba09d42f4ef5 Reviewed-on: https://chromium-review.googlesource.com/1157651 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#581008}
-
Yue Li authored
Also update icon for assistant server notifications. Bug: b/111936939 Test: Manual Test Change-Id: I91d013daba51174d9532b6806484f1ed42809f14 Reviewed-on: https://chromium-review.googlesource.com/1162976 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#581007}
-
Robbie McElrath authored
Currently NetworkConnectionTracker is in //content/public/browser, but it needs to be used by some //components that get used by ios, which can't depend on //content. Bug: 821009 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Id47eda058f5be58492f510771b3ed6e5bbbaffac Reviewed-on: https://chromium-review.googlesource.com/1162747 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#581006}
-
Jérôme Lebel authored
metrics::prefs::kMetricsReportingEnabled and prefs::kMetricsReportingWifiOnly are local prefs, and not user prefs. prefs: :kMetricsReportingWifiOnly is part of the local pref service. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I7a5bfc6d4b7c34e59d911996329b6515190c164c Reviewed-on: https://chromium-review.googlesource.com/1163714Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#581005}
-
Azeem Arshad authored
This CL exposes three additional methods: OnVersionActivated, OnVersionRedundant and OnNoControllees. These methods are required for ChromeOS integration for Android Web Messages. Bug: 850823 Change-Id: I2d38e46e28c1f4b2c76fb6410a57fb74c1a3b850 Reviewed-on: https://chromium-review.googlesource.com/1145621Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#581004}
-
Lukasz Anforowicz authored
WebNavigationApiTest.ServerRedirectSingleProcess from browser_tests has its expectations in serverRedirectSingleProcess/test_serverRedirectSingleProcess.js. The expectations include exact |processId| ("exact" meaning that one cannot use a wildcard - the verification is done via chrome.test.checkDeepEq). Inclusion of |processId| means that the expectation change in site-per-process mode. This CL flips the expectations to match the expected behavior in site-per-process mode and disables the test outside of site-per-process mode. The "disabling" can be removed in a follow-up CL, after we only run //chrome-layer tests in site-per-process mode. Bug: 671734 Change-Id: I984d67342008c3025b84406d99d4798ca46d77f6 Reviewed-on: https://chromium-review.googlesource.com/1162909Reviewed-by:Nasko Oskov <nasko@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#581003}
-
Manas Verma authored
[Autofill] Changes the margins around the sign-in button for the promo shown after a local card save. This change is to fix the UI requirements for the sign-in promo. Should match this mock: https://docs.google.com/presentation/d/1dLbeUlWKkSQzqbDlktot5ldlcVZu32jcjJvIT27vGb8/edit#slide=id.g35839571aa_0_4 (internal) Before: https://screenshot.googleplex.com/6yveL39ovpF After: https://screenshot.googleplex.com/5YhNTQYuHV1 bug: 855186 Change-Id: I8fef17b65091579a5fa6a1f473164c96ff4fd22e Reviewed-on: https://chromium-review.googlesource.com/1163746 Commit-Queue: Manas Verma <manasverma@google.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#581002}
-
Francois Doray authored
It is no longer necessary to invoke the DEFINE_WEB_CONTENTS_USER_DATA_KEY macro to define the global variable from which the key of a WebContentsUserData is derived. The key is now derived from a static local variable in WebContentsUserData::UserDataKey(). See https://chromium-review.googlesource.com/c/chromium/src/+/1093015 This CL was uploaded by git cl split. R=avi@chromium.org Bug: 589840 Change-Id: I7cf3b754fbf7452b316e19f25f849017726e3ef6 Reviewed-on: https://chromium-review.googlesource.com/1150284Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#581001}
-
Victor Costan authored
[NSScreen screensHaveSeparateSpaces] is available on MacOS 10.9 and above [1], so selector checking is no longer necessary. [1] https://developer.apple.com/documentation/appkit/nsscreen/1388365-screenshaveseparatespaces Change-Id: I713baf8c10cd0efb510002211aea66b6bb379f99 Reviewed-on: https://chromium-review.googlesource.com/1163214Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#581000}
-
Nicolas Ouellet-Payeur authored
This is the first step towards creating a policy to enforce printing with/without headers and footers. When it is set, the 'Headers and Footers' checkbox is disabled and greyed out. Right now, there is no easy way to set the pref (beyond just editing the Preferences JSON file). Screenshot: https://screenshot.googleplex.com/LWBrvFzkRZ5.png Bug: 785242 Change-Id: I4a8bb8a0ec5455fe8467931f27eb5e6fab43dd2e Reviewed-on: https://chromium-review.googlesource.com/1149994Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#580999}
-
rajendrant authored
This CL correctly deprecates the UserViewedSavingsPercent histogram for which the code was removed already, and undeprecate the DataReductionProxy.UserViewedSavingsSize histogram for which code still exists. Bug: 870886 Change-Id: I2fa8ab3dec5ad15b87b57afd9d6f9e1df8ba04b5 Reviewed-on: https://chromium-review.googlesource.com/1162822Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#580998}
-
Koji Ishii authored
This patch changes each debug message of js-test.js to produce a block box rather than an inline box. Before this patch, it can create a huge inline formatting context by appending <span>s, which LayoutNG is not very performant to handle at this point. LayoutNG should be able to handle incrementally expanding huge inline formatting context for textarea and some other use cases, but they should have own tests, and not every js-test.js should make this challenge. This change reduces 5 LayoutNG timeout failures. Bug: 636993 Change-Id: I5df429df64bf21dc051fe13600180511ca20ac22 Reviewed-on: https://chromium-review.googlesource.com/1163402Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#580997}
-
Matt Menke authored
When there's an error, the ProxyResolver would invoke a method on the ProxyResolverFactoryRequestClient pipe to pass along an error code and close both that pipe and the ProxyResolver pipe. The Job was listening for error on both pipes, so could see the ProxyResolver pipe close before getting a more useful error code on the ProxyResolverFactoryRequestClient pipe. This CL fixes that by just listening for the client pipe to close. Also, this CL closes the client pipe on completion, to protect against unexpected extra messages, if the Job isn't deleted immediately. Bug: 869551 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I2a1942d851e1d2cc4a33b0fb1278d914aac3593f Reviewed-on: https://chromium-review.googlesource.com/1159196Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#580996}
-
Jacob Dufault authored
All of the whitespace views will now shrink to width=0 in views-login, which means that login/lock will function better on extremely small displays. Bug: 839604 Change-Id: I86d67b718e339a7856f9a7c4d2527c8e1e742ee0 Reviewed-on: https://chromium-review.googlesource.com/1147510 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#580995}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/0047bce0a943..eb73a7bd16c7 git log 0047bce0a943..eb73a7bd16c7 --date=short --no-merges --format='%ad %ae %s' 2018-08-06 srte@webrtc.org Removes unnecessary webrtc_cc namespaces. 2018-08-06 srte@webrtc.org Adds feedback only mode to GoogCC. 2018-08-06 srte@webrtc.org Removes pause check from RoundRobinPacketQueue. 2018-08-06 nisse@webrtc.org Delete RtpReceiverImpl::CheckPayloadChanged. Created with: gclient setdep -r src/third_party/webrtc@eb73a7bd16c7 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia5a1c0fae4a6ff6711c30cb20ff970c823cc9fc2 Reviewed-on: https://chromium-review.googlesource.com/1163846Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580994}
-
Ryan Sleevi authored
Bug: 855690 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I9029b2c3fe66cfb56423ee3fc6e8590547401533 Reviewed-on: https://chromium-review.googlesource.com/1163926Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#580993}
-
Yuwei Huang authored
HostListService::state_ is uninitialized when the instance is created. For some reason it hasn't caused any flakiness in the current unit test set, but I can see it start failing when I try to add new tests. This CL initializes state_ to State::NOT_FETCHED. Bug: 871443 Change-Id: I7eb3d69483baeb8ae0918122b5ba61300705be87 Reviewed-on: https://chromium-review.googlesource.com/1164181Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#580992}
-
Artur Khachatryan authored
In case if something went wrong and no tests were run, we should return non zero. Change-Id: I5645ac78bba01ce2f88c3fb88d9a0155c176a79c Reviewed-on: https://chromium-review.googlesource.com/1164078Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Cr-Commit-Position: refs/heads/master@{#580991}
-
Mounir Lamouri authored
webkitEnterFullscreen() and webkitEnterFullScreen() are rarely used and could be removed. The exit counter parts are significantly more common. The UKM may help us identify the top sites using these methods and drive their usage down. Bug: 745944 Change-Id: Iec937c4f851049355b49bb59bb4d4e32ab8445f9 Reviewed-on: https://chromium-review.googlesource.com/1163835Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#580990}
-
Muyuan Li authored
Bug: b/111133529 Test: None Change-Id: I4ea3ae74c90eed999eaa6231d283438be0ec65c2 Reviewed-on: https://chromium-review.googlesource.com/1164073Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Muyuan Li <muyuanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#580989}
-
Lukasz Anforowicz authored
Verifications inside BrowserTest.OtherRedirectsDontForkProcess test were not applicable to site-per-process mode (e.g. they assumed that a cross-site pop-up, or a cross-site top-level navigation would always reuse the same process). This CL tweaks the test, so that it has different expectations with and without site-per-process mode. Bug: 824962 Change-Id: I1b5dfec0c45a8d578d64d4b259e28497d33b1ca9 Reviewed-on: https://chromium-review.googlesource.com/1162894 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#580988}
-
Fritz Koenig authored
This reverts commit 7a570fae. Re-enable underlays after fixing bugs BUG=854790, 789288 TEST=UnderlayTest Change-Id: I57b42832327924ff568b5dd3da3aadeb780424c2 Reviewed-on: https://chromium-review.googlesource.com/1161485 Commit-Queue: Fritz Koenig <frkoenig@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#580987}
-
Bence Béky authored
This is a lot of work just to avoid using CompletionCallback in HttpCache::PendingOp. Of course one could have used CompletionRepeatingCallback instead, but that is not idiomatic, since the callback is only meant to be called once. No functional change is intended. I wonder why PendingOps cannot be deleted in HttpCache destructor. I guess Backend or WorkItem must outlive HttpCache for whatever reason. I decided it is better not to introduce functional change here. Bug: 807724 Change-Id: Idd7e304702ff31de11073c0a77d041f678fb6ae4 Reviewed-on: https://chromium-review.googlesource.com/1161971 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#580986}
-
Tessa Nijssen authored
The SuggestedTextTouchBarController was renamed to TextSuggestionsTouchBarController. Any instances of SuggestedTextTouchBarController were updated to the new name. The following were also changed: - File names were modified as follows: */{suggested_text => text_suggestions}_* - BUILD files were updated to reflect the new file names - Tests of the TouchBarController were renamed - Flags relating to the TouchBarController were renamed Bug: 717553 Change-Id: Ie2749ed0942362c7e89fd924441b4eac9397ce53 Reviewed-on: https://chromium-review.googlesource.com/1162895Reviewed-by:Avi Drissman <avi@chromium.org> Commit-Queue: Tessa Nijssen <tnijssen@google.com> Cr-Commit-Position: refs/heads/master@{#580985}
-
Ben Smith authored
There are restrictions to sharing SharedArrayBuffer (and WebAssembly Modules) between execution contexts; for example, you cannot share a SharedArrayBuffer between a Window and the Service Worker it created. The rules are described here: https://html.spec.whatwg.org/multipage/webappapis.html#integration-with-the-javascript-agent-cluster-formalism This defines an "agent" which is similar to an execution context, and an "agent cluster" which is a collection of agents that can share between each other. This CL begins to model some of this behavior by using a `base::UnguessableToken` as an agent cluster ID that can be queried from an `ExecutionContext`. This CL also has the correct behavior when a message is sent to an agent that is not part of its agent cluster; in that case a "messageerror" event is sent instead of a "message" event. Bug: chromium:798572, chromium:714842 Change-Id: Ie70cce4cbd0ebd04d8d270d66f59690caf7f616a Reviewed-on: https://chromium-review.googlesource.com/1130505 Commit-Queue: Ben Smith <binji@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#580984}
-
bsheedy authored
Changes "Mac FYI Experimental Release (Intel)" from 10.13.5 to 10.13.6. Bug: 870875 Change-Id: Icb5507246b4e2398ac85eedd8c1e25051a963597 Reviewed-on: https://chromium-review.googlesource.com/1163807Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#580983}
-
Robert Liao authored
Setting #upcoming-ui-features previously locked you into Material Refresh. If you have a touchable device, you probably want Material Refresh Touchable. This change also allows users to choose between Material Refresh and Material Refresh Touchable if #upcoming-ui-features is set. BUG=870002 Change-Id: I8006fcaab8c6f8da299b77fafb9e3418f18bbfa5 Reviewed-on: https://chromium-review.googlesource.com/1159239Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#580982}
-
Sigurdur Asgeirsson authored
Also drop the relevant RC feature flags and UKM measurement code. Bug: 755840 Change-Id: I055e5e7fa7f316aaaa9d48defa3450148b912700 Reviewed-on: https://chromium-review.googlesource.com/1163729Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#580981}
-
Clark DuVall authored
These tests needed some extra synchronization due to the changes made in http://crrev.com/c/1139048. These were flaking in component builds. Bug: 871224 Change-Id: Ibe370f9b9c8ebb94ee1dd21ba204c06e91518057 Reviewed-on: https://chromium-review.googlesource.com/1163987 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#580980}
-
David Tseng authored
During touch exploration, we often hit test to unknown nodes. Change-Id: I1f627c59045500c98ad5a63f1524a91d66ad2357 Reviewed-on: https://chromium-review.googlesource.com/1162701 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#580979}
-
Johannes Henkel authored
InnerEnable does the actual work, but doesn't set the flag, that only happens when enabled() is called (the protocol method). It'd be ok to set it anyway, it doesn't cause traffic on the wire, but I think it's a bit clearer to protect against forgetting to set it with a DCHECK. So this fixes the bug you pointed out when reviewing https://chromium-review.googlesource.com/c/chromium/src/+/1162931 and keeps the change seperate. Bug: 851762 Change-Id: Ibd65a7e69539a760af6499be3f5ff96df6b3912b Reviewed-on: https://chromium-review.googlesource.com/1163808 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#580978}
-
Ken Buchanan authored
Currently all RenderFrameProxys instantiate ChildFrameCompositingHelper objects, even though they are only used for a minority of them -- in particular, only RenderFrameProxys that have RenderFrameImpl parents will ever have to add layers to the layer tree in that process. This CL avoids instantiating them in cases where a RenderFrameProxy is parented under another RenderFrameProxy. Change-Id: Ie789d0331d3aaab17ae531601e00770d786345d7 Reviewed-on: https://chromium-review.googlesource.com/1162694Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#580977}
-