GitLab

https://dawn.googlesource.com/dawn.git/+log/9d6265bc0725..6564890116fd

2020-11-04 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from de6938789ccb to 77f7bb5b005d (18 revisions)
2020-11-04 cwallez@chromium.org Reenable DepthBias tests on Swiftshader
2020-11-04 enga@chromium.org Support sampling depth and stencil of combined d/s formats

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: cwallez@google.com
Change-Id: Ibeba13c6ff83edefd16bfce4c5e10e5912a5c628
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519579Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#824117}

This CL replaces the following pieces of custom infrastructure with
standardized pieces.

1. A custom callback pump consisting of ScheduleNextTask(), PushNextTask(),
   and TestFinishedUnwound() is replaced by base::RunLoop and
   base::TaskRunner::PostTask().

2. A custom threading setup consisting of a base::test::TaskEnvironment,
   a base::Thread simulating the IO thread, a base::WaitableEvent, and
   TestFinished() is replaced by content::BrowserTaskEnvironment and
   base::RunLoop::QuitClosure().

This CL also moves the following shared methods from the test area to
the shared methods area.

* WriteOneBlock
* WriteOutBlocks
* ReadInBlocks
* ReadOneBlock
* VerifyOneBlock

Last, this CL moves OnReadInfoComplete() from the shared methods area to
the area of the only test that uses it.

The CL leaves the file's overall structure in place, to facilitate
review by offering anchoring points for the diffing algorithm.

The motivation for this refactoring is that the QuotaClient mojofication
benefits from having this test use a content::BrowserTaskEnvironment.

Bug: 1016065
Change-Id: I10945be179fa705b4048011dfda27be3e696d4d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518726Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824116}

This CL removes confirmation button on Bluetooth disabled screen to
reflect the spec change.

Screenshot: https://screenshot.googleplex.com/zYMuE9QXvJbEDkr.png

BUG=1145315,1106937

Change-Id: I95f6ea75c9ce0b381467d8515a69faabea42057d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518249Reviewed-by: Tim Song <tengs@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Meilin Wang <meilinw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824115}

This CL makes the cache key for an iframe document different from that
of a sub-resource with the same URL, to mitigate the following cache
attack that can happen due to cross site timing leak.

1) Top-level site a.com loads sub-resource a.com/img. The current cache
key for the resource is (a.com, a.com, a.com/img)
2) If an evil.com iframe on the page then iframes a.com/img, the key for
that iframe's navigation resource will also be (a.com, a.com, a.com/img) even though in step 1) a.com/img was a subresource and in step 2) it was an iframe document resource.

Adding a bit to differentiate the 2 cases will help mitigate the attack
so that evil.com cannot time a.com/img onload handler to see if it was
retrieved from the cache. Note that this attack is possible because the
subresource and it's frame are same-site.

Bug: 1135149
Change-Id: Ic1cabdda72657f5cbcc0109da557c538b2a8b143
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487704
Commit-Queue: Shivani Sharma <shivanisha@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824114}

The WebUI WebContentsObserver wants to report error messages from the
main frame but not subframes. Add the generating frame to
DidAddMessageToConsole and OnDidAddMessageToConsole to allow us to
determine which frame generated each message.

Bug: chromium:1121816

Change-Id: I7a4ab8f4043f6b7df562505a5fd475cb1e206fb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518792Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Kevin McNee <mcnee@chromium.org>
Auto-Submit: Ian Barkley-Yeung <iby@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824113}

Bug: 772945
Change-Id: I51af3cf1070b81f8458dec3a6e28cb1625944dc2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518711
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824112}

The onboarding screen has two separate flows that need to be logged
distinctively for metrics.

BUG=1144056,1106937

Change-Id: If36d91a2f734c1f89f49fe2eae500283151ed184
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519155Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Tim Song <tengs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824111}

WebGL2Compute was a prototype of a way to run GPU compute workloads on
the Web but is superseded by the WebGPU API being standardized in the
"GPU for the Web" W3C group. Since WebGPU has been available behind a
flag for a while now, we remove the Blink code for WebGL2Compute that's
essentially dead at this point.

This CL:

 - Removes the WebGL2Compute interfaces and canvas context type.
 - Updates some of the common WebGL code to remove WebGL2Compute
   specific code.
 - Removes the --enable-webgl2-compute-context flag.
 - Updates the WebExposed test with the API's removal.

Note that the CL doesn't remove GLES 3.1 support from
//gpu/command_buffer that's still useful for fuzzing ANGLE. In a
follow-up CL the ability to start a GLES 3.1 command buffer will be put
behind a build flag.

Bug: chromium:1131991
Change-Id: Ib43fbda4da7962a7261b8b8eae36c225b666d795
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505795
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824110}

Stop isolating prebuilt ash-chrome because builders have switched to
build ash-chrome from tot.

Bug: 1129223, 1145628
Change-Id: I3d6894e9359473b415ea40d5511541aed89c5b15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519833
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/master@{#824109}

The new oncall is sourced from the internal go/rotations tool.

Bug: 1145319
Change-Id: I39a00cfa579408d5a43bdd81c114fa1aaafa992c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517342
Auto-Submit: Joey Scarr <jsca@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824108}

This is a reland of 1c5d9e6d

This test was flaky due to crbug.com/1139541. The previous mitigation
was to skip the first event, but it turns out this was insufficient.
The flakes we were seeing happened at index 5 (i.e., we were failing
to scrape the last trace event from the browser process). In order to
cope with this, I've changed the deflaking logic to accept either
_COMPLETE or _BEGIN, making the test more robust to unclosed intervals.

Original change's description:
> Add activation-related trace events
>
> Adds trace events to HTMLPortalElement::activate,
> RFHI::OnPortalActivated and PortalHost::OnPortalActivate.
> In order to correlate the flow events, a trace id
> is plumbed through activation flow.
>
> Bug: 1137916
> Change-Id: I8841dff33bfeaf91adc58722311672db8aa59210
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439016
> Commit-Queue: Ian Vollick <vollick@chromium.org>
> Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
> Reviewed-by: Alexander Timin <altimin@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Adithya Srinivasan <adithyas@chromium.org>
> Reviewed-by: Lucas Gadani <lfg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#821749}

Bug: 1137916
Change-Id: Ibeb63993d58105a95ec1a1b724baf627bc867eb9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511715
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: Lucas Gadani <lfg@chromium.org>
Reviewed-by: Adithya Srinivasan <adithyas@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824107}

The OriginTrialPolicy is not setup on the browser process, on Android,
on tests derived from BrowserTestBase.

This is normally done from ContentMain(). This function is not called
here, but reproduced more or less accurately by BrowserTestBase.

To install an OriginTrialPolicy from the ContentClient, this requires
accessing the ContentClient. So this patch is essentially exposing it
through GetContentClientForTesting() and use it.

Fixed: 1123953,1119555
Bug: 1123953,1119555
Change-Id: I403a391a84e8504c80d8df57212f347381d25c30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505979Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824106}

Adds "Scanning for nearby devices..." in place of the share target
list on the discovery page when the list is empty. Needed because
the only other indication on the screen that something is happening
is the animation, which isn't accessible for screen readers.

Bug: b/163036847
Change-Id: I22cf34025727315bd2a02934fdec7ba179b6b169
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490661
Commit-Queue: Curt Clemens <cclem@google.com>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: James Vecore <vecore@google.com>
Cr-Commit-Position: refs/heads/master@{#824105}

This change adds links to additional resources on the last page of
the tutorial. A test to confirm correct behavior is also included.

Fixed: 1144857
AX-Relnotes: N/A
Change-Id: Ic7bd8bb1fbe62a69d7e3ad96d8d96675cdaa8ee5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512293Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Akihiro Ota <akihiroota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824104}

The returned object shouldn't be mutable (and cannot be mutated).

Change-Id: I2213472fe99fb64acc95bf8e3e45307bc895b0ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517727
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Auto-Submit: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824103}

https://skia.googlesource.com/skia.git/+log/a8f4c91114b5..3744b2a36638

2020-11-04 johnstiles@google.com Revert "Re-enable -Wdeprecated-copy-dtor."
2020-11-04 herb@google.com move subrun code to anonymous namespace
2020-11-04 kjlubick@google.com [canvaskit] Add option for readPixels to use pre-malloc'd data
2020-11-04 kjlubick@google.com [canvaskit] Add fast pass for saveLayerPaint
2020-11-04 kjlubick@google.com [canvaskit] Properly expose getLineMetrics
2020-11-04 johnstiles@google.com Re-enable -Wdeprecated-copy-dtor.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC bsalomon@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: bsalomon@google.com
Change-Id: Ia098e695f8ccae4ac7ee416fc553eca306ecab5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519660Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#824102}

Part 2 of enabling closure compiler for scanning browser tests. Focusing on enabling and making sure it compiles, without optimization to tests themselves.

Intentionally omits registration to the main target webui:closure_compile (to be enabled later).

chrome/test/data/webui:closure_compile

Bug: 1059779
Test: browser_tests --gtest_filter=Scanning* && autoninja -C ${out}
Change-Id: I48f06cfd6776ce6cf3583e7ba2005edce8be0d7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513688
Commit-Queue: Joon Ahn <joonbug@chromium.org>
Reviewed-by: Jesse Schettler <jschettler@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824101}

This feature is no longer used because it was removed in
crrev.com/a361ec8e part of the flash removal. These testing APIs
can be now removed.

BUG=1143755

Change-Id: I2b4189afb56a8bb16636be198ca258b6d7fc2024
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517379Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824100}

Change-Id: Ifa16441b5010f575bf85cc69b295a801356b4af9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518393
Auto-Submit: Jon Mann <jonmann@chromium.org>
Reviewed-by: Azeem Arshad <azeemarshad@chromium.org>
Commit-Queue: Azeem Arshad <azeemarshad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824099}

The polyfil was added 4 years ago at r403715. It is now supported by
iOS Safari for quite a few versions (10.3+), based on [1]

[1] https://caniuse.com/?search=KeyboardEvent.Key

Bug: None
Change-Id: I7e16c08b5f18f70342d69c270da4ec2f8a96aacd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509929Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Auto-Submit: dpapad <dpapad@chromium.org>
Commit-Queue: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824098}

Bug: 1136565
Bug: 1123673
Change-Id: I8804f8057b58464bb380366aa3d5baeb2a2ab160
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518300
Commit-Queue: Gary Tong <gatong@chromium.org>
Auto-Submit: Gary Tong <gatong@chromium.org>
Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824097}

This reverts commit 8e01fd97.

Reason for revert: crashing in WebView tests https://crbug.com/1145636

Original change's description:
> [cc/metrics] Introduce FrameSorter.
>
> The begin-frames do not always terminate in the same order as they
> start. For example, a frame that does not have any updates can terminate
> earlier than a previous frame that had an update and is awaiting
> presentation. This can make it tricky to measure dropped-frames in a
> sliding window. To make this easier, introduce a FrameSorter, that makes
> sure the sliding-window can process the frames in order, regardless of
> when they are terminated.
>
> BUG=1138552
>
> Change-Id: I2ae0e2413d64d0242aa3ba57f9d1b3d2c1f4354e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441202
> Reviewed-by: Jonathan Ross <jonross@chromium.org>
> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#822737}

TBR=sadrul@chromium.org,jonross@chromium.org,behdadb@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1138552
Bug: 1145636
Change-Id: I332b00355b258585f5447d0c2b4c0fea8b0a1e56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519717Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824096}

Temporarily using some untranslated English strings for this. When real
strings are nailed down and ready to be translated, will go back to the
{command_id, string_id} table this CL is replacing.

Bug: 1014639
Change-Id: I520ccd5f38f7a2d5d8877161093e92515b766b9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518911Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824095}

Implements more ReadingListModelObserver methods. When sync happens, we
need to sync the in-memory bookmark tree.

Bug: 1133504
Change-Id: I87f7c9ec0f52a73b436d3b44eb8bd3278cda78ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518774Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824094}

The synthethized clip layer should use the current transform instead of
the clip rect's transform.

Bug: 1144473
Change-Id: I6cd7457706d6b82b043a0b4bf20863a8a698d521
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515206
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824093}

This patch adds the infrastructure necessary to display a sign-in
notification following a Gaia cookie restoration event.

Bug: 1145592
Change-Id: Ibbc704a3043ffc8c896e604fd319281100e3149a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519457
Commit-Queue: Nohemi Fernandez <fernandex@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824092}

The tests were failing because on Chrome OS the desktop capture source
is named "Display", not "Entire screen".

Change-Id: I008f406557dd4bb6a55ab301b4bb1651e0726eca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517582Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824091}

This is in response to bsazonov@'s request on the prior review. This CL
also makes the version number public so that other users can reference
it if they want to do their own checks.

TBR: bsazonov
Bug: 1145211
Change-Id: Ia0c2d62593f792fee7000e670b8b100e34253544
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519099
Commit-Queue: Sam Maier <smaier@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824090}

TBR=benmason@chromium.org

Change-Id: Iea73037b57d034780b936de8aa51439fbcae834d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519539Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824089}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/62e571e6bb4c..46498235efc5

2020-11-04 tvanderlippe@chromium.org Typecheck timeline/TimelineEventOverview.js with TypeScript
2020-11-04 tvanderlippe@chromium.org Typecheck timeline/TimelinePanel.js with TypeScript
2020-11-04 tvanderlippe@chromium.org Revert "Add setting for record network log action"
2020-11-04 alcastano@google.com Fix double escaping in Markdown renderer
2020-11-04 sigurds@chromium.org Update browser_protocol.pdl
2020-11-04 andoli@chromium.org Fixes dragging of the first column of a data grid by resizing
2020-11-04 sigurds@chromium.org Don't show all columns in network panel
2020-11-04 szuend@chromium.org Update TypeScript to 4.1.1-rc

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1011811,chromium:1122580,chromium:1138302,chromium:1139899,chromium:1144720,chromium:1145150,chromium:1145510
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I8929d2de0dbc0433b0693d6ba735303a623de5ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519578Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#824088}

Part 1 of enabling closure compiler for scanning browser tests. Focusing on enabling and making sure it compiles, without optimization to tests themselves.

Intentionally omits registration to the main target webui:closure_compile (to be enabled later).

Bug: 1059779
Test: browser_tests --gtest_filter=Scanning* && autoninja -C ${out} chrome/test/data/webui:closure_compile
Change-Id: I2919208ffe58ff422dcc675a40dfd9a8fe573246
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511758
Commit-Queue: Joon Ahn <joonbug@chromium.org>
Reviewed-by: Jesse Schettler <jschettler@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824087}

This change guarantees that each browser has appropriate profile with
the same index in SyncTest.

Bug: None.
Change-Id: I5acbacf2b0c4e6b609ce6861f634e31709bcc076
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519451Reviewed-by: Maksim Moskvitin <mmoskvitin@google.com>
Commit-Queue: Rushan Suleymanov <rushans@google.com>
Cr-Commit-Position: refs/heads/master@{#824086}

This reverts commit bf110115.

Reason for revert: Looks like a9eaeb80 in the GN roll broke incremental rebuilds. crbug.com/gn/215.

Original change's description:
> Reland "Roll GN from e002e68a..f5f465b5"
>
> This reverts commit f89a9f12.
>
> Reason for revert: Whoops. I was wrong, and I think the src-internal roll *has* landed.
>
> Original change's description:
> > Revert "Roll GN from e002e68a..f5f465b5"
> >
> > This reverts commit 7ba203c1.
> >
> > Reason for revert: reverting since the src-internal roll hasn't landed yet.
> >
> > Original change's description:
> > > Roll GN from e002e68a..f5f465b5
> > >
> > > Generated by //tools/gn/roll_gn.py
> > >
> > > https://gn.googlesource.com/gn/+log/e002e68a..f5f465b5
> > >
> > >     f5f465b5 Fix runtime_deps for elided targets
> > >     3d165b90 Correct the `gn format --dump-tree=json ...` command to write to stdout instead of stderr.
> > >     ad0a7ada Remove support for set_sources_assignment_filter function
> > >     e1ac69b1 Add a command line to define/overwrite "root" in ".gn"
> > >     7b2a04d5 VS: Use most recently installed Windows 10 SDK.
> > >     132588e1 Revert "gn recipe: Link GN with rpmalloc to speed it up."
> > >     3281c669 Add "framework_dirs" and "frameworks" to syntax highlighting rules
> > >     4323e701 gn recipe: Link GN with rpmalloc to speed it up.
> > >     c808630c Move runtime_deps file for phony targets to /obj
> > >     8855c522 Update Clang and Xcode SDK to 12B5025f
> > >     76f9b6ad Use fetch instead of cherry-pick for Gerrit changes
> > >     a3d69e87 Don't return if package is up-to-date
> > >     36ff17cb Switch back to the older Clang version
> > >     7bcc0eb3 Revert "Update Xcode SDK to 12B5025f"
> > >     e5f1f587 Update Xcode SDK to 12B5025f
> > >     6453c5de Support cross-compiling GN for other targets
> > >     42d6de6e Don't classify Rust static libraries as final
> > >     a9eaeb80 Switch remaining stamp targets to phony targets
> > >     ff45cf2a Show config.visibility in `gn desc`
> > >     de5a8348 [rust project] removing obsolete std libraries
> > >     4c684398 Fix "gn outputs" for bundle data.
> > >     99f72f88 Switch source_set stamp targets to phony targets
> > >     5233fa13 Remove extra * in gn output docs
> > >
> > > As of 99f72f88 and a9eaeb80, GN's usage of stamp files for intermediate
> > > steps in the build graph have been replaced with phony aliases. As a
> > > result, this CL also updates the MB tool to look for ".runtime_deps"
> > > files instead of ".stamp.runtime_deps".
> > >
> > > This is a reland of 7f3e4855
> > >
> > > Change-Id: I5bf18f1529b0969b8c79d768e9b3f377b8dee8cb
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514460
> > > Reviewed-by: Dirk Pranke <dpranke@google.com>
> > > Commit-Queue: Dirk Pranke <dpranke@google.com>
> > > Cr-Commit-Position: refs/heads/master@{#823725}
> >
> > TBR=dpranke@google.com,rjascani@google.com
> >
> > Change-Id: Iebf4e78bd9e7550de3b025a997d4f792c3f80b1b
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518755
> > Reviewed-by: Dirk Pranke <dpranke@google.com>
> > Commit-Queue: Dirk Pranke <dpranke@google.com>
> > Cr-Commit-Position: refs/heads/master@{#823727}
>
> TBR=dpranke@google.com,rjascani@google.com
>
> # Not skipping CQ checks because this is a reland.
>
> Change-Id: I86d184461002eacaf42a96f1ea8901269ff7e856
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518093
> Reviewed-by: Dirk Pranke <dpranke@google.com>
> Commit-Queue: Dirk Pranke <dpranke@google.com>
> Cr-Commit-Position: refs/heads/master@{#823791}

TBR=dpranke@google.com,rjascani@google.com

Change-Id: Ib179abfd84e9cc7647f1e1fb8737038215af1652
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519838Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/master@{#824085}

This suite was useful when we were first spinning up tests on CrOS, as
it provides a smoke check of the browser.

Since then, we've also integrated Tast tests. And as more Tast tests
have been written, they've grown to provide coverage of everything that
the sanity test provided. (eg: tests like ui.ChromeLogin check the
browser's log in flow, arc.* tests cover ARC functionality.)

These days, you'll never see the sanity test fail without also seeing
at least one Tast test failing.

Bug: None
Change-Id: I2a7db54bec15eac7bf909970cdf21946a306817b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518661
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/master@{#824084}

Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202011040600_RC00.html

https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/_hGheFl2oO5agp6bFXl5GHcbq1dU78G_xuIV8hCSitQC

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll
Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: b/170172788,b/172180702
Tbr: media-app@grotations.appspotmail.com
Change-Id: I9fe8b4b7c1a1d6fe9b19f774cf07bb9cb07e5e4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519654Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#824083}

This CL removes the flag gating layer masking for ClientViews of
dialogs and bubbles.

With this change dialogs and bubbles can use layer masking to
apply the appropriate clip to their ClientViews. Bubbles can opt into
layer masking by calling SetPaintClientToLayer(true).

The kEnableMDRoundedCornersOnDialogs flag continues to gate the
increased corner radius of bubbles and dialogs used in Chrome.

Bug: None
Change-Id: I4559ced170fa56b6b8974f4d9b2bd689668cbac9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490666
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824082}

This patch adds one metrics to record the number of times
the task run for completing a capture.

It also replaces CaptureContentTime to CaptureContentTime2.

Bug: 1137463
Change-Id: I34199438353f14beffa20976ebafb3240fd6566f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515143
Commit-Queue: Michael Bai <michaelbai@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824081}

This CL cleans and removes EnablePersistentDownloads &
OpenDownloadsInFilesApp flag.

Bug: 1136795
Change-Id: Id07e40ae59f9caa2a60fcb2ce7835b7504eb85b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460897
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Auto-Submit: Ewann Pellé <ewannpv@chromium.org>
Reviewed-by: Weilun Shi <sweilun@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824080}

This CL makes sure that the message sent at the end of the restoration
is only added if a session restoration is in progress. It is also making
sure to remove the script once the restoration is complete.

Fixed: 1127521
Change-Id: Ie70be6a9233c540e6a4c6a05531eb1f5b1b1e206
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463824Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824079}

As part of the Flash/Plugins deprecation, the resource identifier
becomes obsolete. This CL removes resource_identifier from the
HostContentSettingsMap private methods only.

The rest methods API will be cleaned separately.

Bug: 1134547
Change-Id: Id74420f86abcd91b034af1eb040f09d1d95d456f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517587Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Illia Klimov <elklm@google.com>
Auto-Submit: Illia Klimov <elklm@google.com>
Cr-Commit-Position: refs/heads/master@{#824078}