- 13 Jan, 2021 40 commits
-
-
Illia Klimov authored
WebsiteSettings.Menu.PermissionChanged.SessionOnly Permissions.BatteryLevel.Accepted.LocationSettingsDialog Bug: 1165121, 1165203 Change-Id: Ib644a19f53bfe20df3ba087b79bdf5dbff5d715f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627274Reviewed-by:
Illia Klimov <elklm@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Illia Klimov <elklm@chromium.org> Cr-Commit-Position: refs/heads/master@{#843018}
-
Sadrul Habib Chowdhury authored
When starting a new vsync/frame, the previous frame should explicitly be marked as 'did not produce frame'. This assertion is failing on webview. So introduce a speculative fix for the crash to unblock the release, while we investigate the underlying issue. BUG=1144353 Change-Id: I436cc0a0115287967f9007a91e40ec41b3b69f84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626770Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#843017}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-win-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: Icf895d760c44ed8d49b6685c9433aa12a29f4742 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626021 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843016}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1610517435-0b7576a8f42d1cf58a978eb4b1fa934cc5ba313f.profdata to chrome-mac-master-1610538373-c4c83fd08459537f19e890c14c2288baf23d3675.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I104b2965d86e0578389f7a5b61e3b6e870eddf2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627551 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/95ab239e91ec..bcd6b5c3ff8a 2021-01-13 tvanderlippe@chromium.org Inline and remove isEnterKey 2021-01-13 tvanderlippe@chromium.org [module.json extensions] developer_resources 2021-01-13 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1050549,chromium:1134103 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4e01d89e6ceacd1f43244d4f59ef855e5de8252b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627056Reviewed-by:
-
Tibor Goldschwendt authored
Before, we only tracked NewTabPage.Modules.Loaded, which measures the duration between NTP navigation start and the module load end. This duration can be influenced by several factors other than actually loading the module. For instance, we delay loading the module until after more crucial UI has been rendered. To get a better understanding of how long a module loads for this CL adds NewTabPage.Modules.LoadDuration, which tracks exactly that duration. Bug: 1154008 Change-Id: I55f2cca71bbf6d9d4fee8885f09148e17fd7e975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623655 Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#843013}
-
sczs authored
Bug: 1165271, 1165034 Change-Id: Ie4e2419decac57a32c9ddebce5a7bd237c8c55ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625828 Auto-Submit: Sergio Collazos <sczs@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
-
Tim Volodine authored
AutofillAssistantBottomsheetTest#testHandleHeader and AutofillAssistantBottomsheetTest#testHandleHeaderCarousels are flaky on android-pie-x86-rel. BUG=1166168 TBR=hluca@google.com Change-Id: Iaa4f51ff18e08063f8058a886608400de3ef25a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627419 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#843011}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fe6147b4a04c..c9846ef0a828 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC kolos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: kolos@google.com Change-Id: I615868e6db01e31133cf27e663ecfcf6ae13708a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627552Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843010}
-
Josh Karlin authored
This is a reland of a2873758 Original change's description: > [CodeInclusion] Improve terminology in subresource_filter > > Removing all but one case of master/slave/whitelist/blacklist in > subresource_filter directories. The remaining case involves a change to > safe browsing. > > > Bug: 1160252 > Change-Id: I6aba50a767072ef4a9abb0bacf463712a27f7058 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597012 > Reviewed-by: Charlie Harrison <csharrison@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Commit-Queue: Josh Karlin <jkarlin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#842231} Bug: 1160252 Change-Id: I63877ddf44cab2605e04a9b6c7f1b5c0c894d9f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622337Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#843009}
-
Ali Juma authored
EarlGrey is not compatible with ASan, so in order to adapt CWTChromeDriver for fuzzing, all dependencies on EarlGrey need to be removed. CWTChromeDriver doesn't do any actual EarlGrey UI testing. Instead, it only used EarlGrey as a convenient way of setting up a test process and app process, with EDO communication between processes. This CL removes the EarlGrey dependencies, instead using XCUITest and EDO directly. Bug: 1158540 Change-Id: Iec0534d668413e0630010c7d470bac4e98db43bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622239Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#843008}
-
Nohemi Fernandez authored
Uses the current state of identity services to select the mode in which to display the sign-in promo. This prepares the configurator for a third syncing state to be added in a subsequent patch. Bug: 1151289 Change-Id: I9a73ef89c30782ed2e09cbda2f3e3e03e985c978 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578942 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#843007}
-
Lily Chen authored
This histogram was about to expire, and is no longer interesting as SameSite-by-default has launched which makes the samples almost entirely Lax. Bug: 1165039 Change-Id: I19bdb1ed423e198e7ffc22b2d24cfef81d6b9764 Fixed: 1165039 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623001Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#843006}
-
Ben Kelly authored
Previously ReadableStreamByteConsumer assumed that each UInt8Array data chunk was immutable. While its generally true a UInt8Array is immutable it can still be invalidated by transferring it via postMessage(). This will cause any references to the chunk to suddenly become length zero. If this happens to chunks being processed by the consumer then it will get confused and cause a renderer crash. This CL causes the consumer to error out instead. Bug: 1161236 Change-Id: I44c7ad9115b05e321ba7cacaf28863f88ab14492 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615675Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#843005}
-
Bence Béky authored
Implement logic for https://httpwg.org/http-extensions/draft-ietf-httpbis-priority.html#name-disabling-http-2-priorities in SpdySession, adding accessors for HTTP/2 priorities and PRIORITY_UPDATE frame. Add |enable_priority_update| knob to SpdySessionDependencies via SpdySessionPool to SpdySession. Default to current behavior both in tests and production. HttpNetworkSession: :Params and plumb it through from Change-Id: Iada98d7d692b3ce10e37cd9681ba16a99d564237 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616834Reviewed-by:
Renjie Tang <renjietang@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#843004}
-
Rushan Suleymanov authored
The list can be used by the server to send invalidations to other clients on commit request. The list contains all known FCM tokens from all active devices known to the client via DeviceInfo data type. A device is considered active if it sent DeviceInfo specifics within its pulse time interval (with an additional margin interval). The list might contain the FCM token of the local device to support reflections. There is also a limit of the size of the list to restrict the additional data in a commit request. The empty list means that there is no known information about all other clients and the server should decide itself where to send invalidations. To distinguish the case when there is the only client (which doesn't expect a reflection invalidation), the client should provide the single client flag. Bug: 1164849 Change-Id: I4770091d8e5a577ad9581f899676feeaf381ba97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620560Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#843003}
-
Bence Béky authored
In SpdyStream::OnFrameWriteComplete(), remove early returns for specific, allowed frame types, remove CHECK on frame type, and replace them with an early return for any frame type other than HEADERS and DATA. The CHECK was not particularily useful, since it is okay not to take action when a frame write is complete, but with the CHECK in place one is forced to modify this method when adding a new frame type (that is why the reserved frame type logic got in there at https://crrev.com/c/1207750). This change makes the code easier to extend with potential future frame types like PRIORITY_UPDATE. Removing hardcoded reserved frame types formula is also beneficial, because special treatment of reserved frame types is potentially error-prone, and also goes against the spirit of GREASE. Change-Id: I53efa954411db42af051b4a06c7c3b30b969b0b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615479Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#843002}
-
Pâris MEULEMAN authored
This ensures that the |RenderFrameHost|'s Policy Container is properly initialized when a speculative |RenderFrameHost| is committed early following a crash of the RenderProcess. This allows the following navigation to have a properly initialized |PolicyContainerHost|. Change-Id: Ie8274bdcbdebcf5a0b9b7023ef5c137ab9688ecc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536466Reviewed-by:
Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#843001}
-
Mason Freed authored
A recent bug [1] showed that in SkiaRenderer, it was possible for a backdrop-filter element to blend pixels from a neighboring (but not underlapping) render pass, due to some clipping issues. This test checks for this situation. The original bug was fixed in [2], but I verified that this test breaks pre-[2] (see patchset 1 of this CL). [1] https://crbug.com/1162743 [2] https://chromium-review.googlesource.com/c/chromium/src/+/2611452 Bug: 1162743 Change-Id: I86d00d9831057ace40476d29848c11ba1b671a82 Fixed: 1165868 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625156 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#843000}
-
Maxim Kolosovskiy authored
TBR=caseq@chromium.org Bug: 1164469 Change-Id: I28d850db9a5664ee168906c4d793a4751a670c28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626655Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#842999}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1610517435-75fc59b03a49bc3203d88e1f39423cb5de4c8383.profdata to chrome-linux-master-1610538373-541aee2d8154a147aea334eed2074efc5a2f470f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I7cd93fefd8079129e2b268eb2176326dfdf3e1af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627054Reviewed-by:
-
Nohemi Fernandez authored
Bug: N/A Change-Id: I2ae05f6d5ff8b3518d4a22211b03d386414b6732 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627312Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#842997}
-
Peter McNeeley authored
Recent Finch data has indicated a large percentage of failing overlays. In order to better understand why these overlays might be failing we add a new fail enum that indicates that the overlay candidate failure was a deliberate act by prioritization. Also included in this cl is a minor fix for a specific case with low latency surfaces. Some low latency surfaces (eg Ink) do not change content Ids even when the pixel data changes. We now detect these content changes by testing for a valid surface damage index. If the surface has a damage index we can assume that the content has changed. Change-Id: I00b7015ee78a952105c7107eb4cedaf798f88b12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614860Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Peter McNeeley <petermcneeley@chromium.org> Cr-Commit-Position: refs/heads/master@{#842996}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-linux-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I8e8e8dc6ea6de00580edb42cc6f4ea31126a1f20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627567Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610517435-6cb290631927ae5ce3c51d7b67446e43eb76cc98.profdata to chrome-win32-master-1610528340-b101588b91e5587ca53d6a4d812cdea4439c3876.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib4c450e8640f605faf893688774c005aa243f331 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627547Reviewed-by:
-
Maxim Kolosovskiy authored
TBR=finnur@chromium.org Bug: 1166152 Change-Id: Ifb502e17cc80718bef3106ffa9da52d5b0343ed1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627151Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/44ba8e1708ab..8fccd82e4e02 2021-01-13 fmayer@google.com Merge "Treat perfetto_config.descriptor.h as binary." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I5fb4554364f2a6270e6578297679b3543f44df67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627570Reviewed-by:
-
Maxim Kolosovskiy authored
TBR=mlamouri@chromium.org Bug: 1157239 Change-Id: I94f5aef90870471863c37003f9cd06988645502c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627271Reviewed-by:
-
Rune Lillesveen authored
Allow traversal into and update pseudo elements affected by container queries. Bug: 1146097 Change-Id: I41916286f20bc038089f2f3420d568259a817f62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624631 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#842990}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8d62769d7e71..95ab239e91ec 2021-01-13 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. 2021-01-13 jacktfranklin@chromium.org Fix report view component doc 2021-01-13 tvanderlippe@chromium.org [module.json extensions] changes If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1134103 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I34d63e713282606e84744bfad9b625032f56f07f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627548Reviewed-by:
-
Monica Basta authored
This CL implements the select avatar dialog for the local profile creation in the profile picker. Change-Id: I6a4fb4e49fbd2e5fc25af5b1c0045a529c416d6c Bug: 1162443 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606353 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
-
Reid Kleckner authored
Example failing build: https://ci.chromium.org/ui/p/chrome/builders/ci/ToTWin64/8096/overview This buildbot is chrome-branded, so it uses the chrome-tester-service-account mixin. I believe this means it uses separate pools of machines. There are no bots in that machine pool that match the precise Windows 10 version specified in the Windows 10 mixin. The ToTWin bot is the 32-bit analogue of this bot, and it does not have the win10 mixin, and it runs successfully. Bug: 1166036 R=jam@chromium.org,jochen@chromium.org Change-Id: Ia99937cc830e4270d37bda309c06e834e0e35676 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626827 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#842987}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0ebc1e8f4c65..fe6147b4a04c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC kolos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: kolos@google.com Change-Id: Ibc405cae141e30a5114ba81f7099cba9647bd75b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627289Reviewed-by:
-
Tim van der Lippe authored
R=szuend@chromium.org Bug: 1050549 Change-Id: I763f8596ab931c97a5b15dcd2639f59baab2763b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627412 Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#842985}
-
Yuta Hijikata authored
This change renames deprecated macro name IS_LACROS and IS_ASH with IS_CHROMEOS_LACROS and IS_CHROMEOS_ASH. Bug: 1052397 Change-Id: I58d95a81555a4915b8e80edc1edd23cc3f7d49bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626685 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
kylechar authored
SkiaRenderer will use GL by default if not using Vulkan or Dawn. The --use-gl switch isn't required to get into this state. Add a check that we're using GPU compositing first, since if that is false Chrome will use SoftwareRenderer. Also change the skia-renderer-gl tag to be true if 'opengl' feature is enabled but not using Vulkan or Dawn. Bug: 1163586 Change-Id: Ica5ee59d59b8e437faf0aa9c954e3280d1c7d0e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622237Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#842983}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610517435-1554e99a291ef2bcb6f5a0139dcc2bec362b747b.profdata to chrome-win64-master-1610528340-1fc68c0c17222e2254fe428312433be61c378c49.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I6f3dd9bfafb1c22961eee183f0874787a34f6880 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627088Reviewed-by:
-
Andrey Zaytsev authored
Mock: https://docs.google.com/presentation/d/1_6jDegg169xJ5qgaABZ_wV3-Csd_OL5bf9H1NeUqS9Y/edit?pli=1#slide=id.gac1f62eb2c_0_23 Screenshot: https://screenshot.googleplex.com/8oc3STHihHMNwaF.png Bug: 1152351 Change-Id: Ib4692d6a540652ab761ab373de619385f76fa08e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611098 Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Kamila Hasanbega <hkamila@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Cr-Commit-Position: refs/heads/master@{#842981}
-
Maxim Kolosovskiy authored
This reverts commit 85753b0f. Reason for revert: I suspect this CL caused failures SubresourceRedirectLoggedInSitesBrowserTest.TestCancelBeforeImageLoadForLoggedInSite https://ci.chromium.org/ui/p/chromium/builders/ci/linux-lacros-tester-rel/6414/overview Fontconfig error: Cannot load default config file: No such file: (null) BrowserTestBase received signal: Terminated. Backtrace: #0 0x5596f4879789 base::debug::CollectStackTrace() #1 0x5596f47e4163 base::debug::StackTrace::StackTrace() #2 0x5596f4dcc0c6 content::(anonymous namespace)::DumpStackTraceSignalHandler() #3 0x7f128ca544c0 (/lib/x86_64-linux-gnu/libc-2.23.so+0x354bf) #4 0x7f12902ec9ff __libc_send #5 0x5596f2a8598f mojo::core::ChannelPosix::WriteNoLock() #6 0x5596f2a854b2 mojo::core::ChannelPosix::Write() #7 0x5596f2a7370e mojo::core::NodeChannel::SendChannelMessage() #8 0x5596f2a7808a mojo::core::NodeController::SendPeerEvent() #9 0x5596f2a78707 mojo::core::NodeController::ForwardEvent() #10 0x5596f6c728d2 mojo::core::ports::Node::SendUserMessageInternal() #11 0x5596f6c72720 mojo::core::ports::Node::SendUserMessage() #12 0x5596f2a768e1 mojo::core::NodeController::SendUserMessage() #13 0x5596f2a71afe mojo::core::MessagePipeDispatcher::WriteMessage() #14 0x5596f2a6744c mojo::core::Core::WriteMessage() #15 0x5596f579b850 mojo::Connector::Accept() #16 0x5596f579d9db mojo::InterfaceEndpointClient::SendMessageWithResponder() #17 0x5596f579dd5f mojo::InterfaceEndpointClient::AcceptWithResponder() #18 0x5596f26f4662 content::mojom::ChildHistogramFetcherProxy::GetChildNonPersistentHistogramData() #19 0x5596f2d9b2aa content::HistogramController::GetHistogramData() #20 0x5596f2d9c905 content::HistogramSynchronizer::RegisterAndNotifyAllProcesses() #21 0x5596f2d9ca56 content::FetchHistogramsAsynchronously() #22 0x5596f4dd4781 content::FetchHistogramsFromChildProcesses() #23 0x5596f52f70fa subresource_redirect::RetryForHistogramUntilCountReached() #24 0x5596f0f9d3d1 subresource_redirect::SubresourceRedirectLoggedInSitesBrowserTest_TestCancelBeforeImageLoadForLoggedInSite_Test::RunTestOnMainThread() #25 0x5596f4dcb6e9 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #26 0x5596f491e0aa ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #27 0x5596f491cea5 ChromeBrowserMainParts::PreMainMessageLoopRun() #28 0x5596f2c33516 content::BrowserMainLoop::PreMainMessageLoopRun() #29 0x5596f30a1833 content::StartupTaskRunner::RunAllTasksNow() #30 0x5596f2c324f9 content::BrowserMainLoop::CreateStartupTasks() #31 0x5596f2c34e78 content::BrowserMainRunnerImpl::Initialize() #32 0x5596f2c30c28 content::BrowserMain() #33 0x5596f373dc93 content::ContentMainRunnerImpl::RunBrowser() #34 0x5596f373d886 content::ContentMainRunnerImpl::Run() #35 0x5596f373ad84 content::RunContentProcess() #36 0x5596f373b70c content::ContentMain() #37 0x5596f4dcac68 content::BrowserTestBase::SetUp() #38 0x5596f47d0edb InProcessBrowserTest::SetUp() #39 0x5596f0f9e065 subresource_redirect::SubresourceRedirectLoggedInSitesBrowserTest::SetUp() #40 0x5596f1cf66e8 testing::Test::Run() #41 0x5596f1cf757f testing::TestInfo::Run() #42 0x5596f1cf7f57 testing::TestSuite::Run() #43 0x5596f1d05777 testing::internal::UnitTestImpl::RunAllTests() #44 0x5596f1d050df testing::UnitTest::Run() #45 0x5596f48d0724 base::TestSuite::Run() #46 0x5596f47b935f ChromeTestSuiteRunner::RunTestSuite() #47 0x5596f4dfaab7 content::LaunchTests() #48 0x5596f47b9632 LaunchChromeTests() #49 0x5596f47b6df4 main #50 0x7f128ca3f840 __libc_start_main #51 0x5596f008526a _start [ RUN ] SubresourceRedirectLoggedInSitesBrowserTest.TestCancelBeforeImageLoadForLoggedInSite Original change's description: > [Safe Browsing] Abstract signin dep from RealTimeUrlLookupService > > This CL continues with the abstraction of dependencies on signin and > sync from //components/safe_browsing's access token fetching flow in > order to enable reuse by WebLayer. The concrete step taken here is to > abstract the dependencies on > //components/safe_browsing/core/browser/sync from > RealTimeUrlLookupService, passing these dependencies in via the > constructor. There are no behavioral changes in this CL: > - //chrome and //ios/chrome's factories glue the relevant parameters > from //components/safe_browsing/core/browser/sync > - //weblayer's factory passes in values for the parameters such that > access token fetching for URL lookups continues to be disabled in > WebLayer > > Followup work will bring up support for access token fetching in > WebLayer. > > Bug: 1080748 > Change-Id: I69fca4b2d04118088bb48596eb192beab7bafb4f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621301 > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Reviewed-by: Xinghui Lu <xinghuilu@chromium.org> > Commit-Queue: Colin Blundell <blundell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#842942} TBR=blundell@chromium.org,sdefresne@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,xinghuilu@chromium.org Change-Id: I9aa193871848c7e07353bb2bb428a2a39ba5cb00 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1080748 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627391Reviewed-by:
-
David Roger authored
This CL updates the string to: "To access your Chrome stuff across all your devices, sign in, then turn on sync." https://storage.cloud.google.com/chromium-translation-screenshots/d11144bc8bc505baf22f44152b590dc96c796574 Another version of the string is also added, for possible experimentation later: "To access your Chrome stuff across all your devices, sign in so that you can turn on sync." https://storage.cloud.google.com/chromium-translation-screenshots/6cdbd1b209a8657e0a790d1ec671d522e0c54344 Change-Id: I08e74567ef64e0916366992f35a2901d94975fe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626648 Auto-Submit: David Roger <droger@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#842979}
-
