- 08 Oct, 2020 40 commits
-
-
Laís Minchillo authored
Change testCanInjectHeaders to pass an ImmutableMap to loadUrl instead of a mutable map. Some older WebView versions would crash if an immutable map was passed. This test now prevents this to regress in the future. R=ntfschr Test: run_webview_instrumentation_test_apk -f *testCanInjectHeaders* Change-Id: Ie74893361088dec46f0470ba934b1d185dc0f9fb Fixed: 1032049 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449473 Auto-Submit: Laís Minchillo <laisminchillo@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#815128}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1602136563-0d72642499ba1a8379313d017bceff00a59e9e7c.profdata to chrome-linux-master-1602158210-2b3a542037c8eff782f3f4efb30eab1c7f804d13.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ica99366f1645017a65cbbcd8e194b149162a13d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461686Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815127}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1602136563-35c37307a75e48d8d50dea3abef2bbe00d3f301f.profdata to chrome-mac-master-1602158210-9de918de8f612323e79e5b6447a9374f3934b014.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I36f1cc66321d60cf63b819b62a4e73533a488d89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461399Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ac0723a06b53..8d43858ed21a 2020-10-08 kjlubick@google.com [canvaskit] Update jsfiddle links and fix renderSKP If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jvanverth@google.com Change-Id: Ic616fe728a9d613e4fa1f238c67e06118a11d873 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461398Reviewed-by:
-
Alex Moshchuk authored
The existing entries were failing to actually disable those tests on the bot, seemingly because they were missing "All/". Example failure: https://ci.chromium.org/p/chromium/builders/ci/Site%20Isolation%20Android/46774 Bug: 906256 Change-Id: Ic59ee49e16ac063bd2a25dff879a2bd47ff22ad5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459571 Auto-Submit: Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#815124}
-
Vladimir Levin authored
If, for any reason, we should have recursed into a subtree for a compositing update but it was prevented by the display lock, then we have to restore this state so that we can recurse later. This is a real DCHECK that I have seen, and also is a speculative fix for the referenced bug. R=chrishtr@chromium.org Bug: 1133244 Change-Id: I5adfa04563d94702fa1b38dd2753e76e2a86e317 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453790 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#815123}
-
Manu Cornet authored
Bug: 1056219 Change-Id: Ie2b0b9149653eac2b33d3d841937b99517b404e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446211 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#815122}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/851a5e7f..dba8d09f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id0dabb440cf253328bc93835279d78b9a4c5a5d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461586Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815121}
-
Viktor Semeniuk authored
This change makes username editing compliant with Butter for passwords feature. Account and profile passwords storage are treated as separate entities for the already used username checkup. Bug: 1135181 Change-Id: Idac7d0188e16c4053fb52c746a793469a50a0116 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450310 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#815120}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6a09a9d46097..a8bb3df77a94 2020-10-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from bacaef3237c5 to 2067d1a93e6e (8 revisions) 2020-10-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from a638f3acae94 to dc8a96d60b6b (2 revisions) 2020-10-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 635de036d766 to 952149303d06 (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I936dfaea29ecdcaa63a4fbeaff23a72e94d596a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461395Reviewed-by:
-
Matt Jones authored
The omnibox needs to be unfocused to unsuppress the bottom sheet that is triggered when attempting to share. This patch does that by providing a runnable to the ShareButtonCoordinator that performs the unfocus action. Bug: 1135907 Change-Id: I3b9f14f76b90f13f381f910e4b495ebbecba9168 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456508 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#815118}
-
Hyunjune authored
Reason for revert: After a patch[1], this issue is fixed. So this patch is not needed anymore. Because pass a if statement relied to check cull-rect and a function called |ClearInvalidationMask| is called in painting time. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2050382 Original change's description: > Fix that mask containing image with clip-path can not apply to client > > When image contained mask is loading, it touches a mask flag called > |computed_invalidation_mask_|. > Because |MarkForLayoutAndParentResourceInvalidation| is called in > |ImageChanged| without layout while loading, so this flag would be > changed without clear. And this flag is used in the next layout. > Actually this mask can not apply to client element in next time. > This patch clears the mask flag in pre-paint time. > > Bug: 1086070 > Change-Id: I55a7a16faafe4eeefac88e8e15e6d3b18b097acf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432151 > Reviewed-by: Fredrik Söderquist <fs@opera.com> > Commit-Queue: Hyunjune Kim <hyunjune.kim@samsung.com> > Cr-Commit-Position: refs/heads/master@{#813061} TBR=fs@opera.com,hyunjune.kim@samsung.com,schenney@chromium.org Change-Id: Ifca23ff31590ebc13e1b5a7492c04724847e748f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1086070 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460527Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Hyunjune Kim <hyunjune.kim@samsung.com> Cr-Commit-Position: refs/heads/master@{#815117}
-
Hidehiko Abe authored
There's on going work to unset OS_LINUX on Chrome OS build, however, it is not yet completed, so it is still defined. This CL adds the explicit !defined(OS_CHROMEOS) to fix the behavior. Bug: 1110266 Test: Built locally. Change-Id: I60731672aabb6bb6025e29a0b641988e68ecade5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460826 Auto-Submit: Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#815116}
-
Alessio Bazzica authored
Stop using APM in the Blink peer connection module, since the active APM instance is owned and handled in the Blink media stream module. Less CPU usage at call initialization, less memory and more importantly no misleading logs from APM (in particular, those from `AudioProcessing::ApplyConfig()`). Tested: chromium compiled, appr.tc call successfully made, logs now look ok. Bug: 1136418 Change-Id: I83fd5c2c04da279e997bef76cdd18872463f5b4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461107Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Ale Bzk <alessiob@chromium.org> Cr-Commit-Position: refs/heads/master@{#815115}
-
Etienne Pierre-doray authored
Change-Id: I5a837c6e49c0beec1db69a54d6c8653e7d688045 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459348Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#815114}
-
Raphael Kubo da Costa authored
Implement https://github.com/w3c/screen-wake-lock/pull/291, which makes the |type| parameter optional and default to "screen" in WakeLock.request(). Intent to Implement and Ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/HxWEyZz2nmI ChromeStatus entry: https://chromestatus.com/feature/5725750881681408 Fixed: 1133696 Change-Id: Id3eb6281bfedeaabfa3a7e22d530d0133b50411f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445017 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#815113}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c895058e8c27..53db73226239 2020-10-08 szuend@chromium.org [ts] Type-check network/NetworkOverview.js with TypeScript 2020-10-08 szuend@chromium.org [ts] Type-check network/NetworkConfigView.js with TypeScript 2020-10-08 szuend@chromium.org [ts] Type-check network/NetworkWaterfallColumn.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia1a0c247398573c324bc0641f21cd445ab237937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461394Reviewed-by:
-
Justin Cohen authored
Bug: 1027429 Change-Id: Ic8d48b4a3a0a070bb850d5283ce688a8d4c1a703 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456312Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#815111}
-
Yunke Zhou authored
Bug: 1135512 Change-Id: I5526b5cf4f06f7cba136d1981df977ebeb683bc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459867Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Yunke Zhou <yunkez@google.com> Cr-Commit-Position: refs/heads/master@{#815110}
-
Kent Tamura authored
IsContentMinimumInlineSizeZero() was wrong. Text controls should return true only if LogicalWidth().IsPercentOrCalc(). This change fixes 9 failing tests with LayoutNGTextArea flag. This CL has no behavior changes. LayoutNGTextArea flag is disabled yet. Bug: 1040826 Change-Id: I9f22de17ba8ea674240516c481558e5570a0c956 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461086Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#815109}
-
Olga Sharonova authored
This reverts commit 2a4aa8b6. Reason for revert: Speculative, suspected in breaking cros_browser_sanity_test, see https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-chrome/10590 Original change's description: > [CCA WebUI] Add deploy_swa function in cca.py > > It can help to boost the development when simply changing JS/CSS/HTML > on CCA (SWA). > > Bug: 1127459 > Test: cca deploy-swa [BOARD] [DEVICE] > Change-Id: I3f494a8d455b4c5632f91942f95b428b03294af9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456706 > Reviewed-by: Shik Chen <shik@chromium.org> > Reviewed-by: Inker Kuo <inker@chromium.org> > Commit-Queue: Wei Lee <wtlee@chromium.org> > Cr-Commit-Position: refs/heads/master@{#815087} TBR=shik@chromium.org,inker@chromium.org,wtlee@chromium.org Change-Id: I0ec15027ea4000d30ca7f7851dd8a6c806c37e0a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1127459 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461270Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#815108}
-
Peter Kasting authored
Bug: 772945 Change-Id: I29af810a0b850c6e5d267dfa6f725865fe0de835 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456486 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
-
Clemens Arbesser authored
Change-Id: Ic8f53c116cdbbf2fc752a348d1fc220288a54770 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461306 Auto-Submit: Clemens Arbesser <arbesser@google.com> Commit-Queue: Luca Hunkeler <hluca@google.com> Reviewed-by:
Luca Hunkeler <hluca@google.com> Cr-Commit-Position: refs/heads/master@{#815106}
-
Jan Krcal authored
This CL makes the tests more robust by always explicitly waiting for a concrete event and also improves logging for the future. Bug: 1126913 Change-Id: Ie6026f2c1e2b9ba06a3fe752e904418a9000e507 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461109 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#815105}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1602104345-f59e702ee5ca3195d69eeaf0b87216343ca1f336.profdata to chrome-win32-master-1602125584-6713bc5f5f4e479763b7dc4b9c334026b7e04f91.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I34f2d9a27c716a8c92bdf652a6904ccabcf9630c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460568Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c942e1b7..851a5e7f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I443150691363b25ecf5b9af3739ae97df8e0b469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461031Reviewed-by:
-
Matt Menke authored
They're mostly not being used, since IsolationInfo now mirrors those fields. While the fields in IsolationInfo still have one issue the fields in NetworkIsolationKey had (namely, they may be site instead of origin, for requests created from a NetworkIsolationKey), this does resolve one of the issues with the field: NetworkIsolationKeys are used as keys, and having two NIKs that are logically equal buy observably different is a potential source of bugs. Bug: None Change-Id: Id96ede47a3df2653e9db1c92694d261e13be4fb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451607 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#815102}
-
Stepan Khapugin authored
This reverts commit bb4205e3. Reason for revert: this test still fails. example: https://ci.chromium.org/p/chrome/builders/ci/ipad-device/13104 Original change's description: > [ios] Fix test ReplaceScrolledOffScreenCell > > Re-enables disabled test ReplaceScrolledOffScreenCell. > Uses hardcoded number of items in test instead of flakey > dynamic approach. > > Bug: 1104872 > Change-Id: Ic7ca34b7fa8936452fbc6efaee12563803eb023e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450812 > Reviewed-by: Mark Cogan <marq@chromium.org> > Commit-Queue: edchin <edchin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#814776} TBR=marq@chromium.org,edchin@chromium.org Change-Id: I01adfe29516ad5d31642892331f573c96246b1dd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1104872 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461110Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#815101}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0fe0c2f7. With Chromium commits locally applied on WPT: ae057949 "Add infrastructure/testdriver/actions/penPointerEventProperties.html" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: drott@chromium.org: external/wpt/css/css-text-decor NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I1fee023995f6cd41f42ab5527e92d24f2b135d6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461028Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815100}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1e48b0c6724e..c895058e8c27 2020-10-08 alexrudenko@chromium.org Migrate CommandMenu.js to TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5b1c7bf313ecabf9dd270b49b3ab8a6db5a246c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461126Reviewed-by:
-
Roman Sorokin authored
Also transfer ownership to rsorokin@ and cros-oac@ Fixed: 1130645 Change-Id: I441ac889d92c17197a88f90b30fa9af220e3d264 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445469 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Greg Levin <glevin@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#815098}
-
Swapnil authored
We want to investigate why the force installed extensions fail to install with error CRX_HEADER_INVALID. This CL adds UMA statistics to record whether the extension is from Chrome Web Store or not when extension fails with CRX_HEADER_INVALID error to get more details about it. New histogram added: "Extensions.ForceInstalledFailureWithCrxHeaderInvalidIsCWS" Bug: b/170080693 Change-Id: I5cbaef996151fa75aa5716c985c5ce2035a04ac1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449334 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/5f4e70b81046..952149303d06 2020-10-08 bclayton@google.com SpirvShaderDebugger: Have Function inherit LexicalBlock If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I0b653f86c4dc5301e5c590bc43b363a6ab622bbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460869Reviewed-by:
-
Eric Willigers authored
DesktopPWAsWithoutExtensions has shipped. The test no longer needs to be parameterized Bug: 1065748 Change-Id: I8005d00dc569fb63d1b3ca5f9856308a7216a88d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455787 Commit-Queue: Sergey Poromov <poromov@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#815095}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/24d353df49fd..b8389aa11092 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC olka@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: olka@google.com Change-Id: Ie75feda03fb3cf636b770454455e9e8a99733b0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460870Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815094}
-
Maksim Sadym authored
content_shell uses `ExecuteJavaScriptMethod` instead of `ExecuteJavaScriptForTests`, which should reduce serialisation/deserialisation overhead. The improvement for test run in `third_party/blink/web_tests/http/tests/devtools` is 2.02s (~1.2%). 95% confidence interval of this difference: From 0.3398 to 3.6936 Bug: chromium:1029427 Change-Id: Iba108d23192bde0fa12aa66654271cd85c5e4ada Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452670 Commit-Queue: Maksim Sadym <sadym@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#815093}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/acdf3c1947a2..56df381f7893 2020-10-08 dberris@chromium.org [pinpoint] Support Monorail projects in UI If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1111450 Tbr: zhanliang@google.com Change-Id: I27ecfdcf1abb0d26188bcc1305325fe4b4cf1a33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459897Reviewed-by:
-
Bret Sepulveda authored
This removes part of permission prompts' dependency on PermissionRequest, with the goal of eventually moving the latter's functionality into the UI layer. Bug: 1110905 Change-Id: Icf53d3774c7415453c2266a0db07622483e7b197 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367836 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Olesia Marukhno <olesiamarukhno@google.com> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#815091}
-
Tim van der Lippe authored
This is required for landing https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2450036 R=szuend@chromium.org Bug: 1011811 Change-Id: Iff89f391e7bfa238c4eaeeb5e1ddc4efad19bd05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461267 Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#815090}
-
Gauthier Ambard authored
The flag has been removed for a while, I forgot to remove the entry when removing the flag. Bug: none Change-Id: I5c733e1e659f30b6f003b2879be08e80f15af99c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460810 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#815089}
-
