- 20 Aug, 2020 40 commits
-
-
Jonah Ryan-Davis authored
These two tests pass. Bug: chromium:1099979 Change-Id: I76b553918990e3a4d768c93888a9990391237dee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363808Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Cr-Commit-Position: refs/heads/master@{#800141}
-
David Van Cleve authored
Trust Tokens is a new Chrome feature that adds origin-scoped state and operations, associated with outgoing resource requests, that can mutate this state. In order to avoid certain denial-of-service attacks, executing two of the three Trust Tokens operations requires the trust-token-redemption Feature Policy feature in the executing context. To verify that this holds for outgoing subresource requests, we bind to each frame-level URLLoaderFactory an "upper bound" on whether the frame has the Feature Policy feature present. This state has two values, "forbid" and "potentially permit". In theory, if it is "forbid," we know for sure that we should not see these restricted Trust Tokens operations from the frame, and, if a renderer initiaties a restricted Trust Tokens request from such a frame, we kill the renderer because we "know" that it is misbehaving. We recently encountered a synchronization issue (crbug.com/1111735) where the browser process's view of a frame's Trust Tokens state became inconsistent with well-behaved renderers' views, leading to erroneous renderer kills. It seems like a similar issue might be occurring with the CorsURLLoaderFactory Feature Policy check. This change disables the renderer kill in question as a stopgap to halt the erroneous crashes (we believe almost all such crashes are false positives) and instead logs a histogram and records a DumpWithoutCrashing. R=csharrison Bug: 1117458 Change-Id: Icb1aac4e9d5812fe8d11467f4884c1d4218cb002 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363851 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#800140}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I256f424e774d7c609ef8b147c9fb049e966a57e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367172Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800139}
-
Clemens Arbesser authored
Lite scripts should never show the overlay. This is achieved in two steps: - Auto-insert a ConfigureUiState action as the first action to run. - Blacklist ConfigureUiState, such that scripts can't override this. Bug: b/164506953 Change-Id: Ibce93307e2f8fd3ef15bb1aeb0b2e338b0e48457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362822Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#800138}
-
Viktor Semeniuk authored
This change adds timestamp of the last password check. Timestamp is visible only during unsafe state. Bug: 1075494 Change-Id: I8e1bf94b27a94bbc1cbb83736fd4cd3f7344889f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332605 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#800137}
-
Sebastien Lalancette authored
We should not dismiss the viewController when opening in a new Window. Bug: 1119762 Change-Id: I3520dbbaaa4123f564df28e1636aa52e180dd025 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365978 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Auto-Submit: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#800136}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/eeedb6ea3337..93a9d19d4eb5 2020-08-20 jonaso@webrtc.org p2p_transport_channel: Add estimated disconnected time to CandidatePairChangeEvent 2020-08-20 handellm@webrtc.org Linux ADMs: fix recursive mutex locks. 2020-08-20 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 9fa04bfc..7a8fca54 (799612:800031) 2020-08-20 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 75c4e773..9fa04bfc (799488:799612) 2020-08-19 orphis@webrtc.org Don't do legacy conference mode temporal layer allocation on non-screenshare If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I1756aa0db88816b149664bbd59d1c3b5abb1e614 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366675Reviewed-by:
-
Rushan Suleymanov authored
During processing conflict the local entity might be deleted, e.g. when there is a remote update upon local tombstone. Bug: 1093024 Change-Id: I29341f26b000771a012cbe23f0373e9cb8c00802 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366742Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#800134}
-
Danila Kuzmin authored
Add a new component for oobe. The slides can be used for scrolling. Contains title, body text and illustration. Bug: 1117161 Change-Id: If583db26a82d108a96c33c71616b2e01d38180e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362812 Commit-Queue: Danila Kuzmin <dkuzmin@google.com> Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#800133}
-
Maggie Cai authored
This CL updates the integration test to use fake static to override the sharesheet apis in the files app. BUG=1097623 Change-Id: I37c6238bce7a1e0f401d725cab819b9e81d001c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359791 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#800132}
-
Clark DuVall authored
Need to pass version_code to the android_app_bundle() target. Bug: 1119488 Change-Id: I6a5c0501b54b2acc45bf7ac40c427aabf7f0891a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363669Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#800131}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1e53cb87ed5e..b36c2d9991f1 2020-08-20 tvanderlippe@chromium.org Revert "Remove Properties subpane from Elements panel" 2020-08-20 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-08-20 tvanderlippe@chromium.org Typecheck console/ConsoleView.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I73bc93aca1caf85d968b642524e9188e8b800c96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366676Reviewed-by:
-
Jeff Yoon authored
13.6 sdk is not found for the current xcode version. reverting it to 13.4 to unblock CLs from landing. Bug: 1119668 Change-Id: I10b3259860d04101dbeb65f81657c08028cecce4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366562 Auto-Submit: Jeff Yoon <jeffyoon@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#800129}
-
Hazem Ashmawy authored
Add espresso tests for HomeFragment to test: - Correct info is shown when the app is launched from the current WebView provider and when it's not. - Long press on the items copy the correct info to clipboard. Bug: 1106300 Test: out/Debug86/bin/run_webview_instrumentation_test_apk -f "*android_webview.devui*" Change-Id: I63bab2647e65b758e4b14838d1ba34edd54a064a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352738 Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#800128}
-
Alex Chau authored
chrome/services/sharing/* - Introduced PayloadListener::GetFileForPayload for requesting file from browser process based on payload_id - Introduced PayloadListener::OnPayloadReceived for passing incoming payload chrome/browser/nearby_sharing/nearby_connections_manager* - Browser side usage of the above APIs NearbyConnectionsManager stores the payload in a map, and can be retrieved via GetIncomingPayload - NearbyConnectionsManager provides API to register base::FilePath for specific payload_id. payload_id are sent via Nearby Share specific introduction frames from NearbyDecoder. Bug: 1076008 Change-Id: I177986dba2a66805085539d2b30a282ec948cf43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352792Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Himanshu Jaju <himanshujaju@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#800127}
-
Lijin Shen authored
1. A simple container on the main layout for locating a message 2. The basic message mvc components(properties and viewbinder) 3. A simple render test for the mvc Bug: 1111911 Change-Id: Id6830571995d9c2696283a7eb4128c469a8c4462 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331638Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#800126}
-
Richard Knoll authored
This adds Get/GetOrCreate methods for ShareTargetInfo so we don't accidentally create entries in the maps. Only a few places actually need to create a new entry and this makes it easier to track those. Bug: 1085067 Change-Id: I3d9f20a9a371a0af3968a485748d611840e299b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353334Reviewed-by:
-
Vikas Soni authored
Cache SurfaceControls for the lifetime of SurfaceView. This is to avoid creating/destroying a surface each time the video scrolls off the screen. Bug: 1102623 Change-Id: Idb02923e6d71109be983ea879f4c8b7fa23121f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360488 Commit-Queue: vikas soni <vikassoni@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#800124}
-
Peter E Conn authored
This will allow TWAs to determine whether a browser supports launching to site settings without having to hard code Chrome's package and version. Change-Id: I37b226be1a5118b38f10acb4edefce89db3ad973 Bug: 1119727 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366934 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#800123}
-
Sky Malice authored
Bug: 1119674 Change-Id: I41c282796aed83d17565fd27349dcddcd6b0db72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366394Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
-
Viktor Semeniuk authored
This change shows new Password Details screen from Passwords screen in the scope of Password Check feature. Bug: 1075494 Change-Id: Ic103bce25166beae8eff42b5c3281ace39d1b965 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359130 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
-
Aaron Leventhal authored
Bug: 1116942 Change-Id: Id2e05b209c5de82a83402d2eb28a85231424c4e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364169 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#800120}
-
Sky Malice authored
Bug: 1116201 Change-Id: Ib4664f4dcc78380da556cb89e2ad4c544e4de312 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366572 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
-
Andrey Zaytsev authored
Bug: 1070620 Change-Id: I27b0b8097b73dc92d5ee9cbcaba26233e7ff50db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362653 Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Cr-Commit-Position: refs/heads/master@{#800118}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2d613f1e1be9..56d9df4fa53f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I47a93ec7dcffc85c0379697d70acbb67b0a744de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366251Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/dff47d5fdaac..c060d8d65786 2020-08-20 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from c97acd1d3e07 to 0d6b4440549b (6 revisions) 2020-08-20 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 3434cb0b006d to a711c594b8cc (2 revisions) 2020-08-20 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from 30b3f3857835 to 2979391e5b0c (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: I72addf44dd5d5eeb88731cc505038ca98d0a59f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366246Reviewed-by:
-
Mohamed Amir Yosef authored
Change-Id: I03c1dd29b972819f6021a402f2a481ce4b304f3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366724Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#800115}
-
Renato Silva authored
Adds the pin input field used for auto submit on the login and lock screen together with the switch button to toggle between the modes. Bug: 1075994 Change-Id: Idb6a06f906672fcb79bd84a2212aa20dceebc4e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339992 Commit-Queue: Renato Silva <rrsilva@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#800114}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c244e33eadec..7f343135480a 2020-08-20 abennetts@google.com bq_export: Fix export of jobs.benchmark_arguments.* If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC eseckler@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: eseckler@google.com Change-Id: Id66134476ac96e94377fa666538c9a26e0ae78df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366248Reviewed-by:
-
Sreeja Kamishetty authored
This CL disables following tests which didn't consider caching: - RenderDocumentHostUserDataTest.FailedNavigation - RenderDocumentHostUserDataTest.CheckWithFrameCrashDuringNavigation Bug: 1102629 TBR=arthursonzogni@chromium.org Change-Id: I3dce29531399ae8dfae2e4c101e41298ba155843 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367112 Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#800112}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b85e471255be..5be2204fa998 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC hendrich@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:10918587 Tbr: hendrich@google.com Change-Id: I288cdbc43d7a15881a09dabf481498cca1569481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366249Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800111}
-
Milica Selakovic authored
Bug: 1086114, 1092444 Change-Id: I5e2fc549fbeed1bb1b69ec624a8f91403ef1c3ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367062Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Milica Selakovic <selakovic@google.com> Cr-Commit-Position: refs/heads/master@{#800110}
-
Mugdha Lakhani authored
I had removed the clicklistener on the TextView for the demo app here: https://chromium-review.googlesource.com/c/chromium/src/+/2362817 since I was setting it on the parent view. Turns out, to make the child TextView clicks go up to the parent, I'll need to mark it non-clickable in the layout xml, which we don't want to do for production. Adding the click listener explicitly on the TextView fixes this. Change-Id: I7feaf35a436abb4ca4313f94b12e448c74f58562 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366900Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#800109}
-
Filip Gorski authored
Lands a feature flag for MV tiles on Android as well as necessary string prior to branch cut for M86. Feature is targeting FastPath++. Bug: 1106109 Change-Id: I6a27db87a1fc865c5b7d58c0a42bb1f0ad05c9a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364703 Commit-Queue: Filip Gorski <fgorski@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#800108}
-
Eleonora Rocchi authored
This CL adds a dialog that shows a compromised credential. The dialog is shown when the ¨View password¨ entry is clicked on the More menu of a compromised credential. It also adds a test to verify the close button of the dialog works correctly. Screenshot in the linked bug. Bug: 1117502, 1092444 Change-Id: Iff5784b3e78a3f58072c7e7944f85f6d93b6820a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363750Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
-
Clemens Arbesser authored
This reduces the threshold from 3 to 2, as discussed in the launch bug crbug.com/1110887. Bug: b/165787825 Change-Id: Ied8c26cf6d3ce0c14bd7f13e0968f8212a9835b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367037 Commit-Queue: Clemens Arbesser <arbesser@google.com> Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Auto-Submit: Clemens Arbesser <arbesser@google.com> Reviewed-by:
-
Mohamed Amir Yosef authored
This issues has been surfaced in crrev.com/c/2364508. Details are in the linked bug Bug: 1119758 Change-Id: Id973f22c31a37853351034ac1d449f6e7afed396 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366740Reviewed-by:
-
Ioana Pandele authored
The sorting be handled entirely on the Java side, in PasswordCheckMediator. Bug: 1102025, 1092444 Change-Id: I8cee5bb162900387d7de21b6ab9201a845f6287b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367056 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 290cb807. With Chromium commits locally applied on WPT: 3b705a74 "WPT: Service Worker: Add unexpected state check to wait_for_state()" 49fd0e16 "Origin isolation: add initial popup WPTs" 9f52c7e4 "COOP: add reporting to redirects" f4e154cc "Origin isolation: finish off popup test coverage" c69eee24 "[LayoutNG] Correct border painting for block fragmentation." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: bokan@chromium.org: external/wpt/scroll-to-text-fragment ksakamoto@chromium.org, npm@chromium.org, yoavweiss@chromium.org: external/wpt/resource-timing mkwst@chromium.org, andypaicu@chromium.org: external/wpt/content-security-policy npm@chromium.org, yoavweiss@chromium.org: external/wpt/navigation-timing rego@igalia.com: external/wpt/css/selectors NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: Ief6bc96bc0a1bd028dcebb25f16b519c2d9d38b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365897Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800103}
-
Eleonora Rocchi authored
This reverts commit 19ec1bc6. Reason for reland: fix broken test Original change's description: > Revert "[PwdCheckAndroid] Add redirect to Google Password Check on quota limit" > > This reverts commit b27232d7. > > Reason for revert: Test failures, see crbug.com/1117676 > > Original change's description: > > [PwdCheckAndroid] Add redirect to Google Password Check on quota limit > > > > This CL adds the logic to redirect the user to the Google Password > > Check on quota limit error. The redirect is called through > > PasswordCheckBridge to avoid dependencies on chrome_java. > > > > IDS_PASSWORD_CHECK_STATUS_MESSAGE_ERROR_QUOTA_LIMIT_ACCOUNT_CHECK.png > > https://storage.cloud.google.com/chromium-translation-screenshots/c4546cf199aa6314ead807fa1fc0e1ed8b779a83 > > > > Bug: 1092444 > > Change-Id: I374ad088c305d299fea00f412f27dd6ab3d0e9b5 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362023 > > Reviewed-by: Ioana Pandele <ioanap@chromium.org> > > Reviewed-by: Friedrich [CET] <fhorschig@chromium.org> > > Commit-Queue: Eleonora Rocchi <erocchi@google.com> > > Cr-Commit-Position: refs/heads/master@{#799117} > > TBR=fhorschig@chromium.org,ioanap@chromium.org,erocchi@google.com > > Change-Id: I38a6779f2a9a278317ab5ce2be2edb0742e34f34 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1092444 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363444 > Reviewed-by: Sky Malice <skym@chromium.org> > Commit-Queue: Sky Malice <skym@chromium.org> > Cr-Commit-Position: refs/heads/master@{#799397} TBR=skym@chromium.org,fhorschig@chromium.org,ioanap@chromium.org,erocchi@google.com # Not skipping CQ checks because this is a reland. Bug: 1117676, 1092444 Change-Id: Ib8ffb9cd0b18b5454ffcfa48f8e890d087f5bc42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362823Reviewed-by:
-
