- 20 Jan, 2021 40 commits
-
-
Sebastien Lalancette authored
The work around that was built doesn't meet the quality and stability requirements. Bug: 1139208 Change-Id: I7d1f7bcc9eb9c2f3b6c3cdabc50cbe5eadc92421 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639400 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#845322}
-
Ravjit Singh Uppal authored
The OneTimeGeolocationPermissionProvider tries to unregister itself from an already shutdown context, causing the crash. Update the observer unregistration pattern in the OneTimeGeolocationPermissionProvider to handle the case of the context being already shutdown. Bug: 1168488 Change-Id: Id92b9a3b15410b3732d9021a666282ad1f568036 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640096 Commit-Queue: Ravjit Singh Uppal <ravjit@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Ravjit Singh Uppal <ravjit@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#845321}
-
Mike Jackson authored
No product code changes, just updating comments, and removing TODOs. Explainer: https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/master/RunOnLogin/Explainer.md I2P: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/T6d2zqF_jpw/76TP7Bc2DwAJ Bug: 897302 Change-Id: Id8f1a8e9bfbb3435f3b653d6b9a587279b401fc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637265Reviewed-by:
Chase Phillips <cmp@chromium.org> Commit-Queue: Mike Jackson <mjackson@microsoft.com> Cr-Commit-Position: refs/heads/master@{#845320}
-
Stepan Khapugin authored
Since the button has a descriptive text now, there's no need for this background label which was previously providing context for voicover users. Bug: 1164917, 1138892 Change-Id: Ia3fcd9a43dd9814559e0909f4c3849014b518c22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637706 Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#845319}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1611142151-b9d265a27dc1ef032fcc18909cf95e9a04349e8f.profdata to chrome-mac-master-1611165592-ce7a0617ff859a9176e865c0be149d7728639a62.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I67b874f43c44c4d1f7277d9befeb6c8d19129aae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639216Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845318}
-
Lily Chen authored
This fixes a bug where a base::Feature ref was implicitly converted to reference_wrapper incorrectly, such that the feature override worked on debug builds but not on release builds. This explicitly converts it via std::cref, which fixes the behavior for release builds. Bug: 986319 Change-Id: Ic2511f71d83b2c25e4a5cbf2bc8a3f205fec464e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640921Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#845317}
-
Joe Mason authored
This feature was never enabled and is not well tested. * Remove json_splicer which was only used to modify installed extension lists in JSON files. * Remove force_installed_extension which tracks detected extensions that could be removed. * Remove extension_util functions that remove extensions. * Remove uwe_matcher.proto which defines extensions to be removed, and GetUwEMatchersResourceID that returns the id of the proto file. * Remote uwe_scanner_wrapper and uwe_engine_cleaner_wrapper which inject extension cleaning steps into the scanner and cleaner. * Remove force_installed_extension_scanner that implements detection of extensions that could be removed. * Remove the disable extension methods from ChromePrompt, which notify the user of extensions to remove (these have never been enabled). * Remove WriteRegistryValue which was only used to modify installed extension lists in the registry. * Clean up some unused includes and dependencies. R=drubery Bug: 981388 Change-Id: I87173308d1af939154abac254946638d4a0a0ecb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638001Reviewed-by:
Bettina Dea <bdea@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#845316}
-
Li Lin authored
This CL includes adding: - Feature flag for gating Projector feature. - ProjectorController: the main controller - ProjectorUiController: the controller responsible for interacting with the UI. - ProjectorMetadataController: the controller responsible for recording and saving the screencast metadata. - ProjectorMetadata: model of the projector metadata. Follow up CLs will add more implementations and unit tests. More detail about Projector at: go/projector-prd Bug: 1164029 Test: unit tests Change-Id: I808a044c444a999ecfdbcf1615949cdd4df182b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627441 Commit-Queue: Li Lin <llin@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#845315}
-
Peter E Conn authored
Change-Id: I6ba0d84b62120e380c6a8fa5b4ce7cf27e472cd0 Bug: 1166691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640376 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#845314}
-
Christos Froussios authored
[Sheriff] Disable external/wpt/focus/iframe-activeelement-after-focusing-out-iframes.html on Win and Mac It is flaky. Bug: 1168522 Change-Id: Idcc7293410a65f3f41d172b31d486789b0004bcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640333 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Auto-Submit: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#845313}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2c92c33564e4..a3c06205b28b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Icac215d3faee367dabdb3229505db5a4697eaebe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640736Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4c89481be495..1b1c73ad500b 2021-01-20 bungeman@google.com Remove deprecated SkBase64 interface. 2021-01-20 ethannicholas@google.com Refactored SkSL convertVarDeclaration to make it more accessible from If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Change-Id: Ib666b52b7072cac9531a9221b13699dd22e773e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639937Reviewed-by:
-
Joshua Pawlicki authored
Bug: 1168582 Change-Id: I15a8dbbd9d4f65a5f996909319b0d78b544db73b Fixed: 1168582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639817Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#845310}
-
Darin Fisher authored
This involves adding a new UrlHandler interface to crosapi. We can potentially utilize this interface for other url handling needs in the future (e.g., Android app intent filtering). Teaches Lacros about a new preference that is currently a ChromeOS namespace'd preference but is only used by the browser. It may make sense to move where this preference is registered even for Ash. Fixed: 1166939 Change-Id: I25c68e33aac577e34b82381233375ead9827a0b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631292 Commit-Queue: Darin Fisher <darin@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#845309}
-
Eugene But authored
Change-Id: If1ae96b07a8448a60425a9afb37d0eb4e6eb779c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638549Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#845308}
-
Ben Mason authored
Change-Id: I88d2005edacb587a8fd28eb147b5ca5e801edd3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640793 Auto-Submit: Ben Mason <benmason@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845307}
-
Andrew Grieve authored
Bug: 1167766, 1167767, 1160844, 116085, 1160846, 1160847, 1160848, 1160849 Change-Id: Ie56fac3fbb8b7895731d1615fcf900bc046c9234 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637715 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#845306}
-
Xianzhu Wang authored
Bug: 1164610 Change-Id: I354b0a20e47d6890af3239437ac2315c7488de0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640917Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#845305}
-
Esmael El-Moslimany authored
When the NTP has a vertical scroll bar, the NTP contents had a 32px empty space at the bottom. This was from the cr-button which was using "position: sticky" to stick to the bottom right of the window. The empty space looks good, but it should not be due to the height of the cr-button (it is not obvious). This CL introduces a div to explicitly set a 32px empty space at the bottom of the NTP content area, removing the dependency on the cr-button height. Change-Id: Ib035affef92445d3c7f1effdc61b5daea108c4ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638633 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#845304}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1611142151-59c02f8532ae979e0b13a34b9cbf149a736aa67f.profdata to chrome-win32-master-1611153816-d2f18273110c533af9e6c4795ef7f831ac05328f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I11d159b6f18ef74cae328a9711c5ebc9057f8a73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640734Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ff509c5440f5..40fbf5738639 2021-01-20 soxia@microsoft.com Service Worker Update Cycle Timeline 2021-01-20 tvanderlippe@chromium.org Put platform on the global scope in layout tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1050549,chromium:1066604 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I018ee80ed4a0982db93513735d6b8197ebd204d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639520Reviewed-by:
-
Bin Du authored
We are continuing data collection from this histogram. Bug: 1167829 Change-Id: I2114321350cf2ae940b2239eb82eebd243e436c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638073Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a3c06205b28b..477bd92472cc 2021-01-20 hjd@google.com Merge "ui: Support zoom to 1us" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ie9a21ea56513137dfe446527289f3b8d82d1da2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639302Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1611142151-f3b642624b7e7391f296111a04b779942697c546.profdata to chrome-linux-master-1611165592-f4f825a470f7704c21486baf150746af41ae52eb.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I89733be810dc859982b739572c6b26decde7f5cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640738Reviewed-by:
-
gogerald authored
Bug: 1168574 Change-Id: I41f45073df9b7a8249d9c5b529439d718a32675a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640633 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Auto-Submit: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#845298}
-
Xinghui Lu authored
Add SafeBrowsingPasswordProtectionReferringAppEnabledAndroid to control whether to include referring app info in password protection requests on Android. The flag is disabled by default. Bug: 1154860 Change-Id: I26d0384601f84067a00bc08a548fc4f7f14eb8c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638781Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e48903477157..39ca1963aa25 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC harringtond@google.com,gab@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: harringtond@google.com,gab@google.com Change-Id: Icdc7c1bd96d2708bf08e95e03cf82af675eea8f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639017Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845296}
-
Aaron Colwell authored
Replacing whitelist usage with allowlist terms to bring the code in line with our inclusive code guidelines. https://chromium.googlesource.com/chromium/src/+/master/styleguide/inclusive_code.md No functionality has change. I simply updated comments and a few variable names. Bug: 842296 Change-Id: I84c6e5594eb85d5b1d5d0a56b41fa366e669ddac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638547 Commit-Queue: Brad Nelson <bradnelson@chromium.org> Auto-Submit: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Brad Nelson <bradnelson@chromium.org> Cr-Commit-Position: refs/heads/master@{#845295}
-
Peter McNeeley authored
Due to existing limitations in damage calculations some overlay candidate quads will still lack a valid |surface_damage_index|. This means that separating out the damage of a promoted overlay quad from the damage on the primary plan is now virtually impossible. However, a simple optimization is still possible if the overlay candidate is opaque and sits above the primary plane (pure overlay not underlay). So in this case the |display_rect| of the promoted overlay can be subtracted from the primary plane damage. The motivation for these changes is primarily improved Lacros power performance. The special case mentioned above is far more common in existing lacros due to the entire lacros window being contained in one compositor frame. Finally, it should be noted that with this change some pages now move closer to power equivalence between Lacros and ash chrome. Specifically the Google Keeps drawing application has now only ~6% greater power usage on Lacros than ash chrome. Change-Id: I83af491adb3dd2832f599d34e5849fd518ffdfa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634926Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Peter McNeeley <petermcneeley@chromium.org> Cr-Commit-Position: refs/heads/master@{#845294}
-
Devon OBrien authored
Change-Id: Iebbad1bb62f55e24fae2fe8240e06ae9d60b78ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638595Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Devon O'Brien <asymmetric@chromium.org> Cr-Commit-Position: refs/heads/master@{#845293}
-
Shakti Sahu authored
Added toolbar shadow for the video tutorial list. Also modified the change language button text to show a constant string. Bug: 1168267 Change-Id: I682e527a37a677da0ca40f809c7e19bfddbe8887 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638414 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#845292}
-
Jeroen Dhollander authored
This CL is part of a migration of all interactions with the Libassistant 3rd party library to a mojom service. Currently Libassistant is invoked directly from the browser thread. This specific CL focuses on the display controller, which in the current Libassistant V1 API has 2 jobs: - Configure Libassistant parameters that only apply to devices which have a display (as opposed to for example Google home devices). - Receive updates about the user speech input volume. In the new Libassistant V2 API, the first job is handled by the display service (http://shortn/_XZThaXrQKb), while the second job is handled by a newly introduce recognition event API (http://shortn/_GyiHLrIRtn). As such, this CL also introduces 2 distinct mojom files to handle these different jobs. Bug: b/177471991 Bug: 1168230 Test: compiled & deployed on real hardware Change-Id: Ic404db5b29d9c12332b584501a43012b9ee8312d Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625963 Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:Sam McNally <sammc@chromium.org> Reviewed-by:
Meilin Wang <meilinw@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#845291}
-
Mike Jackson authored
As we look towards adding a enterprise policy, we want to have an option to show/hide the menu item, and an option to enabled/disabled the menu item. This CL updates the existing parameter to indicate what the flag actually does. Explainer: https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/master/RunOnLogin/Explainer.md I2P: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/T6d2zqF_jpw/76TP7Bc2DwAJ Bug: 897302 Change-Id: I4ef7becd32dd003d8efaab503f0d51a7919d589a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637329Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
-
Filip Gorski authored
Bug: 1160779 Change-Id: I273f33b905ac886a5c192cf3fb0d1014f41109e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611330 Commit-Queue: Filip Gorski <fgorski@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
-
Rohit Agarwal authored
Bug: 1168161 Change-Id: I776a8f152a05cde5fbb939a707ee0e8eba43b083 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640033Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/master@{#845288}
-
Collin Baker authored
A TouchModeChanged() call may happen just after a session ends, but just before the associated OnSessionEnded() call. This caused a DCHECK. Handle this case by ignoring it. Fixed: 1165462 Change-Id: Id8c8a52acd94fef6a34a5349693af7caa9c570d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622529Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#845287}
-
Robert Liao authored
BUG=1168231 Change-Id: I7d0249efadf3da294414932f9511e18d1752994e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638550 Auto-Submit: Robert Liao <robliao@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#845286}
-
Mitsuru Oshima authored
Bug: 1155308 Change-Id: Ib42a0acc0a29beb35ced0e9cd717456c1d62a92e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638540Reviewed-by:
-
Nate Fischer authored
record_netlog.py was constructing an on-device path with "os.path." This isn't correct on Windows, where we want to use posixpath for on-device paths and os.path for on-host paths. Fixed: 1156518 Test: validity check the script still works as intended on Linux Change-Id: I8120bf5416fc957d4cc0605a49d2a32d190aa2e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577634 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Reviewed-by:
-
Kevin McNee authored
We recently added a CHECK that MimeHandlerViews can't navigate away from their handling extension. However, attempting to perform a lighthouse audit of the PDF viewer causes it to navigate to about:blank. While this is still a bug, we no longer CHECK in response to about:blank. Bug: 1168046, 1158381 Change-Id: I84f137cffb1dbf6173bd6ad53d7bf24703acba3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637404Reviewed-by:
Lucas Gadani <lfg@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#845283}
-
