- 11 Sep, 2020 40 commits
-
-
Hidehiko Abe authored
The file was migrated into build/chromeos_buildflags, so no longer needed. BUG=1114198 TEST=Build locally. Change-Id: Iffafe7c3d4f2417cfbe4c1ceff21397937cbd9d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397975Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#806037}
-
kdillon authored
This name is more contextual, which matches the naming conventions of the other prioritisation types and indicates what the prioritisation type is used for. Change-Id: I4a6bb87abafc5268a3031e9bb6ed258cd0b0e00a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399012 Commit-Queue: Katie Dillon <kdillon@chromium.org> Reviewed-by:
Scott Haseley <shaseley@chromium.org> Cr-Commit-Position: refs/heads/master@{#806036}
-
Toshiki Kikuchi authored
This CL fixes SetBoundsSize and SetBoundsOrigin methods to take “default scale cancellation” into account. If “default scale cancellation” is disabled, we expect a client to send bounds in pixels instead of dp, so these SetBounds* method should be sensitive to the flag. Also, this CL adds an unittest for SetBounds methods in the case of default scale cancellation-enabled and -disabled. BUG=b:167997508 TEST=SetBoundsWithAndWithoutDefaultScaleCancellation Change-Id: Icfcaf445372c5eae0425226f802b27e7d7372bf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398055 Commit-Queue: Toshiki Kikuchi <toshikikikuchi@chromium.org> Reviewed-by:
Mitsuru Oshima (Slow: gardener) <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#806035}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3b19b9d3347f..a4cfaa2dfc7f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I38aced69714456c8ebed2e68e3a7e2f599ad1a4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405616Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806034}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0f64e0dfd845..9d6f955f52e9 2020-09-11 csmartdalton@google.com Chop tessellated strokes in the vertex shader If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: reed@google.com Change-Id: I92fbd527989b8b808fbd737ea8480efdaab53628 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405733Reviewed-by:
-
Findit authored
This reverts commit 18c62e03. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 806003 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzE4YzYyZTAzNjE0NGYxOThmYjVlYjIwNDAzODg2Yjg1ZWNmNDg5OWMM Sample Failed Build: https://ci.chromium.org/b/8869495277819118464 Sample Failed Step: compile Original change's description: > Update Crashpad to 3e065b11d0cad1742f4cc4cf8acb8fa075f364ca > > 3e065b11d0ca linux, mac: disable cfi-icall for cross-dso calls > > Change-Id: I92931ffe81b3004149b33017853d8c1e0548141d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404066 > Reviewed-by: Mark Mentovai <mark@chromium.org> > Commit-Queue: Joshua Peraza <jperaza@chromium.org> > Cr-Commit-Position: refs/heads/master@{#806003} Change-Id: If5ace2f60f7376d4583cb750eaa10486df35d4f7 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405524 Cr-Commit-Position: refs/heads/master@{#806032}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/da7c69c8fd9c..edae54b8a91e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC rakina@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1126211 Tbr: rakina@google.com Change-Id: Ic7c167a7065612540485739179b41734f3c84236 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405514Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806031}
-
Julie Jeongeun Kim authored
This CL resets mojom::PrintPreviewUI receiver when the print preview ID is cleared. The problem is that printing::PrintPreviewUI clears the ID and gets the new one when it's reloaded through the inspector but the receiver still keeps using the previous binding. This change resets the receiver when the ID is cleared and the mojo pipe is bound again when it gets the preview. Bug: 1122515, 1008939 Change-Id: I2852212f8bf3bc2e5ea233915d480bc58c5b87bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381225Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#806030}
-
Rakib M. Hasan authored
Builder is not ready to be on the main Android waterfall. There are way to many failures on this builder. More work needs to be done in order to turn it green. Bug: 1126998, 1050760 Change-Id: Ie4c5eadacc2188bc89e948c571427dd2b5999bef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404472Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#806029}
-
Alan Screen authored
The advanced capabilities used by ChromeOS printing never make use of the |kNone| capability type. Bug: 809738 Change-Id: I27b0cdba58fa2ad2c4d803cf63ab2bf32dc15556 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404475 Commit-Queue: Alan Screen <awscreen@chromium.org> Reviewed-by:
-
Yoichi Osato authored
As per IETF spec https://tools.ietf.org/html/rfc7540#section-8.1.2.4, A pseudo-header is a HTTP/2 header fields beginning with ':' and it is not H/1 header. Not to expose these to js API, this CL removes the headers w/o converting to H/1 compatible header. As a side effect, DevTools will not show these headers. Test: Manual Fixed: 1107710 Change-Id: Ie52ebe585c2a55a661a888c71f7687fee145aa73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379438 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#806027}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1599760756-5eeaad3a0935fac8a24777486ae90bd2f43c056f.profdata to chrome-mac-master-1599781911-9c360a18426c47cd39d0c24797835d08f90d685a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Icfd4aa886d95bf0f184f167bb546ee532f1c13f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405732Reviewed-by:
-
David Tseng authored
This is a proposed output change for ChromeVox's treatment of both dialog and alert dialog roles. When entering these types of containers, ChromeVox will output the text content of the dialog first, followed by the control with range. R=akihiroota@chromium.org Bug: none AX-Relnotes: ChromeVox will now summarize the text content of a dialog when entering one. Test: browser_tests --gtest_filter=ChromeVox*.DialogAuto* Change-Id: Ic24f05bfb9f65e582239ed1e271ba4a78fefb034 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378730 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#806025}
-
Maggie Cai authored
Extend the preferred apps histogram expiry date for another 2 milestones. BUG=853604 Change-Id: Ib5b8107ce391b81d05ac7dc9ddb7382b3c08d41c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397060Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#806024}
-
Michael Spang authored
This fixes a link error for cast_accessibility_unittests when built with chromecast_branding = "internal": ld.lld: error: undefined symbol: chromecast::CreateSysInfo() Bug: b/168243031 Change-Id: I90529de006b6a97a6f933591db8efe981e24621e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405564Reviewed-by:
Sean Topping <seantopping@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#806023}
-
Caitlin Fischer authored
See comment 5 on the bug. Bug: 1084107 Change-Id: I95dca05857cc6c6412ed78ce1992809de30b17d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404159Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#806022}
-
Min Qin authored
BUG=1125832 Change-Id: Ie83c36b7ee2a8abccc83e1386321a35a433b468c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399449Reviewed-by:
-
Ian Swett authored
Rolling 2 dependencies Roll src/net/third_party/quiche/src/ edf934d71..5c52ad843 (23 commits) https://quiche.googlesource.com/quiche.git/+log/edf934d71e96..5c52ad843f8a $ git log edf934d71..5c52ad843 --date=short --no-merges --format='%ad %ae %s' 2020-09-10 wub When switch from QUIC BBR to BBRv2, use BBR's cwnd as the initial cwnd of BBRv2. 2020-09-10 fayang Include stream information in idle timeout connection close detail. 2020-09-10 quiche-dev Fix use-after-move in SimpleLinkedHashMap 2020-09-10 quiche-dev Self-instrument for QUIC library via setsockopt for on-host-monitoring. 2020-09-10 fayang Internal QUICHE change 2020-09-09 bnc Fix stream ID sent in GOAWAY frame. 2020-09-09 dschinazi Deprecate quic_fix_print_draft_version 2020-09-09 quiche-dev Automated g4 rollback of changelist 330572491. 2020-09-09 nharper Add method to get reason why 0-RTT was accepted or rejected in QUIC 2020-09-09 danzh gfe-relnote: fix QUICHE windows compilation errors. No behavior change. 2020-09-08 haoyuewang Deprecate gfe2_reloadable_flag_quic_simplify_received_packet_manager_ack & gfe2_reloadable_flag_quic_remove_unused_ack_options. 2020-09-08 nharper Set crypto_negotiated_params for IETF QUIC client in 0-RTT 2020-09-08 quiche-dev Remove support for ephemeral streams in QBONE. These have been unused for months (since switching to message frames). 2020-09-08 bnc Internal QUICHE change 2020-09-08 fayang Revert quic_anti_amplification_factor from 10 to 5. Also add a copt to set the factor to 10 for experiment. 2020-09-08 bnc Use IETF application error codes for STOP_SENDING frames. 2020-09-08 wub Deprecate --gfe2_reloadable_flag_quic_bbr2_improve_adjust_network_parameters. 2020-09-07 ianswett gfe-relnote: Remove pending_version_negotiation_packet_ from QuicConnection because it's only set to true in a method that's protected by checking whether it's already true. No functional change, not flag protected. 2020-09-02 fayang Close QUIC connection if writer is still blocked while calling OnCanWrite. 2020-09-02 quiche-dev Add method to send HTTP/3 shut down notice GOAWAY frame 2020-09-02 quiche-dev Fix flaky //third_party/http2:http2_structures_test 2020-09-02 bnc Change STOP_SENDING frame related APIs to use QuicRstStreamError type. 2020-09-02 danzh Make QUIC connections send PATH_RESPONSE upon receiving PATH_CHALLENGE according to IETF QUIC draft v29. Roll src/third_party/quic_trace/src/ a3f901c6a..2dccbe8e9 (1 commit) https://chromium.googlesource.com/external/github.com/google/quic-trace.git/+log/a3f901c6a99e..2dccbe8e996d $ git log a3f901c6a..2dccbe8e9 --date=short --no-merges --format='%ad %ae %s' 2020-08-20 vasilvv Add bzl_library rules for .bzl files without one. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src R=dschinazi@chromium.org Change-Id: I7c7ce3075a9096fdbbfc4a50273094d7b9460aac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405372 Commit-Queue: Ian Swett <ianswett@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Auto-Submit: Ian Swett <ianswett@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#806020}
-
Patti authored
Replace uses of 'whitelist' and 'blacklist' with 'allowlist' and 'blocklist' respectively, the latter being chosen to be consistent with other existing uses of 'blocklist' in the extension strings. Bug: 1114004 Change-Id: Iafd862dedc69d10c020de890724b4b63ea5b4599 No-Presubmit: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377668Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Patti <patricialor@chromium.org> Auto-Submit: Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#806019}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8b9424e9da85..60c25a303fac 2020-09-10 mbonadei@webrtc.org Reland "Switch from "rtc_ios_xctest_test" to "rtc_test"." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Id5494651635bdee74b92d9cd40cf481de24a2956 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404665Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0379b611. With Chromium commits locally applied on WPT: d3d1f16b "Visited background-color alpha channel in Forced Colors Mode" 612ba1ba "CookieStore: Remove matchType" da055314 "Revert "CookieStore: Remove matchType"" 9693c35f "Move pointerevent_mouse_pointercapture_inactivate_pointer to wpt" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Change-Id: Id801fe5e235ea8c8decce05dbb9f16f80533362f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404485Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806017}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1bd71b48fb5c..1ab73f0f8ce7 2020-09-10 jonahr@google.com Cleanup disable_program_binary workaround 2020-09-10 hidehiko@chromium.org Expand is_linux to is_linux || is_chromeos. 2020-09-10 sugoi@google.com Added integer overflow detection to ClipRectangle If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1091364,chromium:1110266 Tbr: ianelliott@google.com Test: Test: Built locally. Tryjob. Change-Id: I28099ee268eb50510c07de800b557a8e16ef32cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404861Reviewed-by:
-
Shrek Shao authored
TBR=kbr@chromium.org Bug: 1127140 Change-Id: Ia7d5ae99b425fe1abc69951b34bd1346a2135d54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404070Reviewed-by:
Shrek Shao <shrekshao@google.com> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#806015}
-
Shrek Shao authored
Bug is fixed and the test is passing on bots. TBR=kbr@chromium.org Bug: 1108588 Change-Id: Ied77c504ddb297444c9d23b1b28bb3e5bb8c247a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404951Reviewed-by:
-
Richard Li authored
Since the main structure of hdr_metadata.h has been moved to ui/gi/, this CL removes hdr_metadata.h in media/base/ and switches related reference of media::HDRMetadata/MasteringMetadata/HdrMetadataType into their gl version. Bug: 1122910 Change-Id: I3d0dfe1410d43b18262e11239ae9a9e48134de45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397013Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
-
Jinsuk Kim authored
Delete all the classes and resources left unused by Duet (BottomToolbar). Bug: 1081343 Change-Id: Ic5ae5dbd6e2d995b7959b72daf4b1d9c5981b80e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391942Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#806012}
-
John Williams authored
The overall effect of this change is that when the user clicks the Cast button in a web page, the global media control button is shown even if it wouldn't be otherwise. This can happen, for instance, when a YouTube video is loaded with the audio muted. The button appears in all windows associated with the same profile. Bug: 1107164, b/161612881 Change-Id: I2c8687bec1c51f4b77e62c235161a3f3677adf5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363947 Commit-Queue: John Williams <jrw@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#806011}
-
wutao authored
The row height should be 64px for two lines Settings. Bug: b/166807600 Test: new js test Change-Id: I7a06e51b4d921e55457a5ffbe35964c888c1c979 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399767Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#806010}
-
John Williams authored
Bug: 1124982, b/168119903 Change-Id: Ifd971c6ad521f436e2af79d168bc643704575690 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401046 Commit-Queue: John Williams <jrw@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
-
Alan Cutter authored
Blink now uses subdirectory owners, I am listed in the subdirectories I have history with. I don't know Blink very well outside of those directories. Change-Id: I735cc7e7173e8dd90ec036a77562736f3258e178 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397064 Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
dstockwell <dstockwell@google.com> Commit-Queue: dstockwell <dstockwell@google.com> Cr-Commit-Position: refs/heads/master@{#806008}
-
Lukasz Anforowicz authored
This CL changes CreateFileSystemURLLoaderFactory so that it returns mojo::PendingRemote to a FileSystemURLLoaderFactory that is owned by its |receivers_| and will self-delete when the last receiver disconnects. This CL removes the ability to directly construct and own a std::unique_ptr<FileSystemURLLoaderFactory>, because this ability means that the factory can be destructed while receivers bound via the Clone method are still alive (see the associated bug). This CL mostly just follows the pattern established earlier by https://crrev.com/c/2337411. Bug: 1106995 Change-Id: Id98b6df97ad4e96e033ba638ccc2c3ff20a92c97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357462Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#806007}
-
Sammie Quon authored
Moves AccessibilityFocusAnnotator to OverviewSession to accommodate. Change OverviewGrid::RemoveItem callsites to use OverviewSession::RemoveItem since it does some more stuff. Change OverviewItemView a11y role to GenericContainer so its children (label, close button) can be focus with a11y. I tried removing the overview focus widget outright in crrev.com/c/2388623 but issues came up with making the OverviewItem widget's activatable. If DesksWidget is always available in the future we can remove it. Test: manual Bug: 853589 Change-Id: I1ea63a88a0d0b5511edd1fd6925a35e82409d229 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392993Reviewed-by:
Min Chen <minch@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#806006}
-
Maggie Chen authored
ProcessSurfaceOccludingDamage was split into two functions and an internal function to support the new structure CompositorRenderPass and AggregatedRenderPass. In stead of calling ProcessSurfaceOccludingDamage() on a per surface basis, now we call this function in CopyQuadsToPass() so the destination AggregatedRenderPass is always available. With this change, we can merge these two functions into one. This is also aligned with the direction of future support for multiple overlays. Bug: 1117235 Change-Id: I05703e5fe44b0611f73ec6f588e6b11776fbe0cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393529Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#806005}
-
phillis authored
On OSX, file handlers are managed via app shim in the Application directory, this removed duplicating app shortcut creation during installation and moves shortcut update logic from file manager to OsIntegrationManager. Apps.FileHandler.Registration.Mac.Result UMA metric is removed and WebApp.Shortcuts.Creation.Result is created Bug: 1123201 Change-Id: I0a6850424a7050c8c0f14acf5166a9123abad2b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377900 Commit-Queue: Phillis Tang <phillis@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#806004}
-
Joshua Peraza authored
3e065b11d0ca linux, mac: disable cfi-icall for cross-dso calls Change-Id: I92931ffe81b3004149b33017853d8c1e0548141d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404066Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#806003}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1599760756-c4035dc0b0474f5a6f2e7d19fc7457941683bae1.profdata to chrome-linux-master-1599781911-7dd6ce5c7bf44a9e9e915c505640214d1e509445.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC liaoyuke@google.com,chrome-brapp-engprod@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:linux-chrome Tbr: liaoyuke@google.com,chrome-brapp-engprod@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com Change-Id: If690b6a2ea926e28d7cb93f9c70a22b9a086e53b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405692Reviewed-by:
-
Andre Le authored
Add the task continuation section (continue browsing) to PhoneHub tray bubble (mock UI with implementation). Bug: 1106937,1126208 Change-Id: I15144c8f875c56454b0125498417bd37ee4bc7c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399802 Commit-Queue: Andre Le <leandre@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#806001}
-
Elly Fong-Jones authored
We don't have a notion of "app-modal". We do have window-modal and system-modal, but system-modal a) is much more "aggressive" than app-modal and b) doesn't work at all on Mac, so demote these dialogs to window-modal. Note that they are *not* demoted on ChromeOS because of the linked bug 1127133. Bug: 1121132,1127133 Change-Id: Ib145b97529c08227f7888a51d0fb8e6fa3799b36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398961 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#806000}
-
Christopher Cameron authored
The problem is in DoScheduleCALayerInUseQueryCHROMIUM. This lists a bunch of textures, and a callback comes back to GLRenderer::DidReceiveTextureInUseResponses about whether or not they are in use. Only once InUseResponses indicates that a texture is not in use will the GLRenderer release it. Here's what goes wrong -- ScheduleCALayerInUseQueryCHROMIUM takes many textures as arguments. If a single texture is invalid, then the entire call is discarded. And so no InUseResponses are returned, and no textures are freed. No texture is removed from the InUseQuery until it reports that it is not in use. Consequently, frame after frame, every texture reports that it is in use, more textures are allocated because the pools are empty. The fix is to make DoScheduleCALayerInUseQueryCHROMIUM be fail-safe instead of fail-deadly. If a texture is invalid, report that it is not in use. Bug: 1120795 Change-Id: I4f82d854b9a0620d0c8b829fadeaf5ad4d0ea506 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402759 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#805999}
-
K. Moon authored
Moves OutOfProcessInstance::LoadUrl() to PdfViewPluginBase, so the implementation may be shared between the Pepper and Pepper-free PDF plugins. The PdfViewWebPlugin implementation creates a BlinkUrlLoader instead of a PepperUrlLoader. Bug: 1099022 Change-Id: I2d3c97ba7adb8d3608f32760c942d7333a4e54db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401507 Commit-Queue: K. Moon <kmoon@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#805998}
-
