- 20 Aug, 2020 40 commits
-
-
Sky Malice authored
Bug: 1116201 Change-Id: Ib4664f4dcc78380da556cb89e2ad4c544e4de312 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366572 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#800119}
-
Andrey Zaytsev authored
Bug: 1070620 Change-Id: I27b0b8097b73dc92d5ee9cbcaba26233e7ff50db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362653 Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Cr-Commit-Position: refs/heads/master@{#800118}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2d613f1e1be9..56d9df4fa53f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I47a93ec7dcffc85c0379697d70acbb67b0a744de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366251Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800117}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/dff47d5fdaac..c060d8d65786 2020-08-20 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from c97acd1d3e07 to 0d6b4440549b (6 revisions) 2020-08-20 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 3434cb0b006d to a711c594b8cc (2 revisions) 2020-08-20 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from 30b3f3857835 to 2979391e5b0c (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: I72addf44dd5d5eeb88731cc505038ca98d0a59f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366246Reviewed-by:
-
Mohamed Amir Yosef authored
Change-Id: I03c1dd29b972819f6021a402f2a481ce4b304f3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366724Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#800115}
-
Renato Silva authored
Adds the pin input field used for auto submit on the login and lock screen together with the switch button to toggle between the modes. Bug: 1075994 Change-Id: Idb6a06f906672fcb79bd84a2212aa20dceebc4e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339992 Commit-Queue: Renato Silva <rrsilva@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#800114}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c244e33eadec..7f343135480a 2020-08-20 abennetts@google.com bq_export: Fix export of jobs.benchmark_arguments.* If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC eseckler@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: eseckler@google.com Change-Id: Id66134476ac96e94377fa666538c9a26e0ae78df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366248Reviewed-by:
-
Sreeja Kamishetty authored
This CL disables following tests which didn't consider caching: - RenderDocumentHostUserDataTest.FailedNavigation - RenderDocumentHostUserDataTest.CheckWithFrameCrashDuringNavigation Bug: 1102629 TBR=arthursonzogni@chromium.org Change-Id: I3dce29531399ae8dfae2e4c101e41298ba155843 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367112 Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#800112}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b85e471255be..5be2204fa998 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC hendrich@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:10918587 Tbr: hendrich@google.com Change-Id: I288cdbc43d7a15881a09dabf481498cca1569481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366249Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800111}
-
Milica Selakovic authored
Bug: 1086114, 1092444 Change-Id: I5e2fc549fbeed1bb1b69ec624a8f91403ef1c3ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367062Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Milica Selakovic <selakovic@google.com> Cr-Commit-Position: refs/heads/master@{#800110}
-
Mugdha Lakhani authored
I had removed the clicklistener on the TextView for the demo app here: https://chromium-review.googlesource.com/c/chromium/src/+/2362817 since I was setting it on the parent view. Turns out, to make the child TextView clicks go up to the parent, I'll need to mark it non-clickable in the layout xml, which we don't want to do for production. Adding the click listener explicitly on the TextView fixes this. Change-Id: I7feaf35a436abb4ca4313f94b12e448c74f58562 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366900Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#800109}
-
Filip Gorski authored
Lands a feature flag for MV tiles on Android as well as necessary string prior to branch cut for M86. Feature is targeting FastPath++. Bug: 1106109 Change-Id: I6a27db87a1fc865c5b7d58c0a42bb1f0ad05c9a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364703 Commit-Queue: Filip Gorski <fgorski@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#800108}
-
Eleonora Rocchi authored
This CL adds a dialog that shows a compromised credential. The dialog is shown when the ¨View password¨ entry is clicked on the More menu of a compromised credential. It also adds a test to verify the close button of the dialog works correctly. Screenshot in the linked bug. Bug: 1117502, 1092444 Change-Id: Iff5784b3e78a3f58072c7e7944f85f6d93b6820a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363750Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
-
Clemens Arbesser authored
This reduces the threshold from 3 to 2, as discussed in the launch bug crbug.com/1110887. Bug: b/165787825 Change-Id: Ied8c26cf6d3ce0c14bd7f13e0968f8212a9835b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367037 Commit-Queue: Clemens Arbesser <arbesser@google.com> Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Auto-Submit: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#800106}
-
Mohamed Amir Yosef authored
This issues has been surfaced in crrev.com/c/2364508. Details are in the linked bug Bug: 1119758 Change-Id: Id973f22c31a37853351034ac1d449f6e7afed396 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366740Reviewed-by:
-
Ioana Pandele authored
The sorting be handled entirely on the Java side, in PasswordCheckMediator. Bug: 1102025, 1092444 Change-Id: I8cee5bb162900387d7de21b6ab9201a845f6287b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367056 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 290cb807. With Chromium commits locally applied on WPT: 3b705a74 "WPT: Service Worker: Add unexpected state check to wait_for_state()" 49fd0e16 "Origin isolation: add initial popup WPTs" 9f52c7e4 "COOP: add reporting to redirects" f4e154cc "Origin isolation: finish off popup test coverage" c69eee24 "[LayoutNG] Correct border painting for block fragmentation." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: bokan@chromium.org: external/wpt/scroll-to-text-fragment ksakamoto@chromium.org, npm@chromium.org, yoavweiss@chromium.org: external/wpt/resource-timing mkwst@chromium.org, andypaicu@chromium.org: external/wpt/content-security-policy npm@chromium.org, yoavweiss@chromium.org: external/wpt/navigation-timing rego@igalia.com: external/wpt/css/selectors NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: Ief6bc96bc0a1bd028dcebb25f16b519c2d9d38b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365897Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800103}
-
Eleonora Rocchi authored
This reverts commit 19ec1bc6. Reason for reland: fix broken test Original change's description: > Revert "[PwdCheckAndroid] Add redirect to Google Password Check on quota limit" > > This reverts commit b27232d7. > > Reason for revert: Test failures, see crbug.com/1117676 > > Original change's description: > > [PwdCheckAndroid] Add redirect to Google Password Check on quota limit > > > > This CL adds the logic to redirect the user to the Google Password > > Check on quota limit error. The redirect is called through > > PasswordCheckBridge to avoid dependencies on chrome_java. > > > > IDS_PASSWORD_CHECK_STATUS_MESSAGE_ERROR_QUOTA_LIMIT_ACCOUNT_CHECK.png > > https://storage.cloud.google.com/chromium-translation-screenshots/c4546cf199aa6314ead807fa1fc0e1ed8b779a83 > > > > Bug: 1092444 > > Change-Id: I374ad088c305d299fea00f412f27dd6ab3d0e9b5 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362023 > > Reviewed-by: Ioana Pandele <ioanap@chromium.org> > > Reviewed-by: Friedrich [CET] <fhorschig@chromium.org> > > Commit-Queue: Eleonora Rocchi <erocchi@google.com> > > Cr-Commit-Position: refs/heads/master@{#799117} > > TBR=fhorschig@chromium.org,ioanap@chromium.org,erocchi@google.com > > Change-Id: I38a6779f2a9a278317ab5ce2be2edb0742e34f34 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1092444 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363444 > Reviewed-by: Sky Malice <skym@chromium.org> > Commit-Queue: Sky Malice <skym@chromium.org> > Cr-Commit-Position: refs/heads/master@{#799397} TBR=skym@chromium.org,fhorschig@chromium.org,ioanap@chromium.org,erocchi@google.com # Not skipping CQ checks because this is a reland. Bug: 1117676, 1092444 Change-Id: Ib8ffb9cd0b18b5454ffcfa48f8e890d087f5bc42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362823Reviewed-by:
-
Elly Fong-Jones authored
This change just renames these files and updates references to them in other files without adjusting any class/variable names or anything else. A subsequent change will begin renaming classes & variables inside them. This change also deletes 'master_preferences_dummy.cc', which used to be needed for 32-bit builds but is no longer referenced anywhere. Bug: 1097204 Change-Id: I462039568493ae52a4333f1e939d71be2edc7185 Tbr: asvitkine@chromium.org,battre@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364012 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#800101}
-
Lutz Vahl authored
This is a roll-back to 8.6.395. This is the most stable candidate out of the latest Canaries. If this commit results in failures in Blink please contact the Blink sheriff. They may need to make changes to Blink because of the roll-back. When in doubt please try to contact the committer and reviewers of this CL before reverting it. R=machenbach@chromium.org,vahl@chromium.org Change-Id: Ib03e3f3232c358f2e2d3410cfd596fe9533ccf90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366796Reviewed-by:
Michael Hablich <hablich@chromium.org> Commit-Queue: Lutz Vahl <vahl@chromium.org> Cr-Commit-Position: refs/heads/master@{#800100}
-
Alexander Hendrich authored
This reverts commit c4de5e43. Reason for revert: failing test, see https://crbug.com/1104083#c8 Original change's description: > Use document background color as active tab color for tabbed web apps > > This CL hooks up the document's background color as the active tab > background color for experimental tabbed web app. > Tabbed web apps are hidden behind the DesktopPWAsTabStrip feature flag. > > This CL plumbs background color through from the renderer process along > the same route as document theme color. > > Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=460591&signed_aid=NcgKQaq5Y47QkcbQbbgNiw==&inline=1 > After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=460590&signed_aid=RlnBzb7mQq1SIW1fGBY-oA==&inline=1 > > Bug: 1104083 > Change-Id: If1c3e2172f80375a1a4619c17ee52594ef813005 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342426 > Commit-Queue: Alan Cutter <alancutter@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Michael Wasserman <msw@chromium.org> > Auto-Submit: Alan Cutter <alancutter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#800051} TBR=avi@chromium.org,msw@chromium.org,alancutter@chromium.org,haraken@chromium.org,dominickn@chromium.org Change-Id: I9ed61a2044703edcac2127d1a50c3ae47b12b872 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1104083 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366757Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1cb771bfe063..1e53cb87ed5e 2020-08-20 jacktfranklin@chromium.org Load runtime stylesheets in to the components server 2020-08-20 szuend@chromium.org [ts] Improve types in ui/Context.js 2020-08-20 szuend@chromium.org [ts] Type-check ui/PopoverHelper.js with TypeScript 2020-08-20 jacktfranklin@chromium.org Fix empty function bodies in component bridges 2020-08-20 alexrudenko@chromium.org [Metrics] UMA tracking for suggest color feature in Color Picker If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1093227 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5ad51e3c12d46f7e5f5d0252ba46a33e86b13b0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367017Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ef0fb4c2707e..2d613f1e1be9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Id61297f54b0bec7fd5d39736bbea26e5c1f96257 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367016Reviewed-by:
-
Oleh Lamzin authored
Bug: b:158658869 Change-Id: I6685b09c455156ad21a62d18546c61bd6a966cea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362595 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#800096}
-
Danil Chapovalov authored
Change Log: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/1beb3191c2..dc969f34a7 Full diff: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/1beb3191c2..dc969f34a7 Bug: None Change-Id: Ic1c197cc401aec83ac7c974003b50b7902ca399f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367093 Commit-Queue: Danil Chapovalov <danilchap@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Auto-Submit: Danil Chapovalov <danilchap@chromium.org> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#800095}
-
chrome://managementAndreea Costinas authored
Change the wording and location of the proxy server disclosure in the transparency panel. First landed as CL:2360073, reveted due to failed MSAN tests. TBR=glevin@chromium.org Bug: 1116961 Test: unittests Change-Id: I133ad760e41d03ad3edf2ba3685c552257c8e9e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366772Reviewed-by:
Andreea-Elena Costinas <acostinas@google.com> Commit-Queue: Andreea-Elena Costinas <acostinas@google.com> Cr-Commit-Position: refs/heads/master@{#800094}
-
Changhao Han authored
Change-Id: Iecbf7ff7d7a8f636b55d251cc105bac1e22f4b5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362921 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Auto-Submit: Changhao Han <changhaohan@chromium.org> Cr-Commit-Position: refs/heads/master@{#800093}
-
Christoph Schwering authored
This CL moves the probable-form-submission detection from the renderer process to the browser process. The new behaviour is active iff kAutofillEnableProbableFormSubmissionInBrowser is enabled. The current state is that probable form submission is detected in FormTracker::DidStartNavigation(), which forwards the event to AutofillAgent::OnProbablyFormSubmitted(), which then notifies ContentAutofillDriver::FormSubmitted(). The 'submitted form' is the one returned by AutofillAgent::GetSubmittedForm(). This CL moves the event detection to the newly added ContentAutofillDriverFactory::DidStartNavigation(), which calls the newly added ContentAutofillDriver::ProbablyFormSubmitted(). The 'submitted form' should again be the one returned by AutofillAgont::GetSubmittedForm(). For the browser process to have access to that form, AutofillAgent now proactively sends it to the browser process by calling SendPotentiallySubmittedFormToBrowser(). See the referenced bugs for further details. Bug: 1113740, 1117451 Change-Id: I46be9e8b7058f4a309e3e9c64f34ca4d8852e641 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332622 Commit-Queue: Christoph Schwering <schwering@google.com> Reviewed-by:
Matthias Körber <koerber@google.com> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#800092}
-
Koji Ishii authored
This patch moves |FontHeight| to |platform/fonts|, so that classes in platform can use this class. This class was renamed from |NGLineHeightMetrics| in r800012 <crrev.com/c/2366375>. This is preparation to add BASE table support. With this change, |FontMetrics| can return |FontHeight| instead of constructing from |FontMetrics|. Also changed the default constructor to create zero- initialized instance to match other classes. |Empty()| static function returns an empty instance. This patch has no user-observable behavior changes. Change-Id: Icd289dff0c90b4fb19c497a4e64b31ea42ed7952 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363514 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Koji Ishii <kojii@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#800091}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ef0fb4c2707e..2d613f1e1be9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I7b30cd28c84946461cc7fe4ed80bf9768805687d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366145Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/eff9ef0f2212..7f265d1d4074 2020-08-20 tommek@google.com Fixing offset alignments when using DynamicUploader If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I09715a0696b4d4de2cad7d0cd9ce7d1777adbaea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366247Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/193cfbd67529..bbb2038a3f14 2020-08-20 tsepez@chromium.org Nest CFWL_ListItem as CFWL_ListBox::Item. 2020-08-19 tsepez@chromium.org Make ~CFWL_CheckBoxTP() be the default destructor. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I13a6f0d6ac9b91974e760a6842fa292c2e5c4b04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366245Reviewed-by:
-
Guido Urdaneta authored
These changes are intended to address a crash that occurs in WebRtcAudioRenderer::SwitchOutputDevice. Android behavior left unmodified due to issues with the test version of frames, but this is not an issue because setSinkId() is not supported on Android. Bug: 1116409 Change-Id: Icb88c32b29cb8450fed48e6961e123b3c25917af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355926 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#800087}
-
Ryan Daum authored
The callback wrapper being local stack allocated means the asynchronous callback invocation may fail if invoked after the method returns; this has been causing crash/JNI failure. Switch to a unique_ptr and move it along. Additionally the callback argument itself may go out of scope, so needs to be switched to the correctly scoped JNI handle. Bug: internal b/162882383 Test: manual on device Change-Id: I4bb4c87531e9a4b099f61ad9133ad1b3922de4be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364559 Commit-Queue: Ryan Daum <rdaum@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Cr-Commit-Position: refs/heads/master@{#800086}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2d613f1e1be9..56d9df4fa53f 2020-08-20 simonmacm@google.com Merge "Fix suspend detection." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ia4a99964746a33a501a5aa1a44fadd698ece9bea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366244Reviewed-by:
-
Nohemi Fernandez authored
TBR=marq@chromium.org This fixes a BUILD issue due to a deprecated API in MDCSnackbarManager. Bug: 1117399 Change-Id: I27a9c5ce03e319bb4f402236d32f593a4d7f073e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367032Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#800084}
-
Stephen Chenney authored
An error introduced in a previous patch caused background-position calculations to be broken due to incorrect source rect transforms. Fix it and add a more thorough test. The test fails pending fuzzy matching in Chrome. Bug: 1108698 Change-Id: Iabdc332474daa0c5dc4aeb61df338c6028212c65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365914 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#800083}
-
Titouan Rigoudy authored
It was mistakenly added in crrev.com/c/2282932 after a bad rebase operation. Bug: chromium:986744 Change-Id: Iefdfac6cfa564f7d4cd3b12b7a322f56a2945ecc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366734Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Titouan Rigoudy <titouan@chromium.org> Cr-Commit-Position: refs/heads/master@{#800082}
-
arthursonzogni authored
Reenable two test: -CoopReportingOriginTrialBrowserTest.AccessReportingWithToken -CoopReportingOriginTrialBrowserTest.CoopStateWithToken They were disabled by: https://chromium-review.googlesource.com/c/chromium/src/+/2365362 We think this might be fixed by: https://chromium-review.googlesource.com/c/chromium/src/+/2366778 Feel free to immediately revert this patch if the two tests start to fail. We will also monitor them today. Bug: 1119555 Change-Id: Ibd6fc4af82fcc4cbd3dcf5fe2b1472d81cb9c8cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366894Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#800081}
-
Rainhard Findling authored
This reverts commit 1708a344. Reason for revert: I forgot that there was an explicit reason why we did exclude the "Check now" button and the safety check parent element secondary label from Settings search: it breaks another user journey: 1. In the main page, the users searches for "Check now" (or for any other string that is matched only by the button or the parent element secondary label). Safety check is shown as a the only result of the Settings search in the main page. 2. The user runs a safety check. The "Check now" button is replaced by the re-run icon button, and the string of the secondary label changes. 3. The user navigates from the main page to another Settings page through safety check to inspect some details. 4. The user navigates back from the Settings page to the main page. Safety check is no longer shown and the main page is empty, as the search term does no longer match anything inside safety check. Original change's description: > Safety check: include "Check now" button in Settings search > > * Include the previously excluded "Check now" button in the Settings > search. This lists safety check as a result when searching for "Check > now" if the button is visible at the moment the search is done. > > Bug: 1015841,1114020 > Change-Id: I09ba5e15b27371cf6a4aff2105a7bc8f4a33d706 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339996 > Reviewed-by: dpapad <dpapad@chromium.org> > Commit-Queue: Rainhard Findling <rainhard@chromium.org> > Cr-Commit-Position: refs/heads/master@{#795996} TBR=dpapad@chromium.org,rainhard@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1015841 Bug: 1114020 Change-Id: Id824aca8bc74b52872e3986cc8b0cb5084183bcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362936Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Rainhard Findling <rainhard@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#800080}
-
