- 09 Apr, 2020 40 commits
-
-
Austin Tankiang authored
Bug: 1068479 Change-Id: Iaca92655f6633658e56cd4969646e96fc8030b48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139060 Commit-Queue: Austin Tankiang <austinct@chromium.org> Reviewed-by:
Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#757761}
-
Colin Blundell authored
The APIs via which AuthenticatorNavigationInterceptor instances are obtained from Tabs are currently being refactored. However, those APIs are used downstream. To allow those refactorings to proceed without breaking downstream this CL introduces an AuthenticatorNavigationInterceptorTabHelper wrapper that downstream can use to be isolated from the specific APIs being refactored. I will delete this wrapper once the upstream refactorings have landed and I have converted downstream to use them. Bug: 1031465 Change-Id: I232e785674d155d16b968c8d91889df6c73b7ebc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142257Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#757760}
-
Daniel Hosseinian authored
An earlier change [1] to printing/BUILD.gn that built CUPS IPP files for macOS made it such that some files already built for fuzzing get built twice. That resulted in a macOS fuzzing builder breakage. TBRing this CL as it is a minor change that will fix a high priority bug. [1] crrev.com/754744 TBR=thestig@chromium.org Bug: 1069349 Change-Id: I99343e035c0d1f1599930e5fc3f127a888664fb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143514 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#757759}
-
Gauthier Ambard authored
This CL makes sure that the virtual URL of the items are restored when finishing the session restoration. Fixed: 1065433 Change-Id: I9570c73caad9e025ff5425412d83a5b7c4532dba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134296Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#757758}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/15398905e2cd..46d2d5e4c4ce git log 15398905e2cd..46d2d5e4c4ce --date=short --first-parent --format='%ad %ae %s' 2020-04-09 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 6c7769b5..9fa8abd9 (757605:757716) Created with: gclient setdep -r src/third_party/webrtc@46d2d5e4c4ce If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I72ce395a810b7532ba0165e88e09fbc9362cd5bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143558Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#757757}
-
Josh Simmons authored
Bug 1067499 requires the addition of individual browser tests to validate the MIME type detected and reported by Quick View for all file extensions known to Files.app. This CL is the first of many and adds MIME type checks for file extensions with existing tests. It also adds a new test that highlights the quirks of the file content sniffing used by the Media Gallery API (the underlying implementation used by Quick View to determine and report MIME type in the right-hand metadata information box). Subsequent CLs will split out MIME type testing from some of the current tests (where it is overloaded in the test of a wider feature) and add new tests for currently untested file extensions. Bug: 1067499 Change-Id: I08fb9926ac3aa734f95cc5cc04afa1c241300cc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141563Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Commit-Queue: Josh Simmons <simmonsjosh@google.com> Cr-Commit-Position: refs/heads/master@{#757756}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I4d8b5d03212fcca5dbe66a39104803c651e892a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141498Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#757755}
-
John Pham authored
This allows screen readers to announce when a tree view node collapses/expands after user action. Change-Id: Ia4e686a88ddc9c73643342453f08d3603b3e151b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136865 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#757754}
-
Dominic Mazzoni authored
This was originally needed so that we wouldn't cast a BrowserAccessibility* into a platform-specific subclass in a unit test that was explicitly constructing the parent class. We got rid of all such unit tests now, so there's no longer a need for IsNative. Bug: None Change-Id: I934f08f22aa497c3894ee60c0c8f13fb046fc98e Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141047Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2319607679d7..2caf7ffda74f git log 2319607679d7..2caf7ffda74f --date=short --first-parent --format='%ad %ae %s' 2020-04-09 xinghua.cao@intel.com Address a TODO for instance uniform block Created with: gclient setdep -r src/third_party/angle@2caf7ffda74f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: I7e4722ea58803ceb3b1c1413bf31fa87d9f54fd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143556Reviewed-by:
-
Alex Danilo authored
The selection menu button was using 'cr-button', while all of the other menu buttons on the action bar were using 'button' elements. Styling for files-ng was added to our CSS targeting 'button' for some background-color cases. Changes the selection menu button to 'button' element so those styles apply. Fixes 2 integration tests to look for lack of 'display:none' on the selection menu button, i.e. actually test for visibility. Bug: 1067218 Change-Id: I6fc8050128ec42b9e743f8facf405281b9d9c013 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143415 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/dcf3a9b3dce1..330286ebf4aa git log dcf3a9b3dce1..330286ebf4aa --date=short --first-parent --format='%ad %ae %s' 2020-04-09 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps 2020-04-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 65c03361..9fa8abd9 (398 commits) Created with: gclient setdep -r src/third_party/skia@330286ebf4aa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: csmartdalton@google.com Change-Id: I6de8d087012185570fe1f5bee90d9016d5706e63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143557Reviewed-by:
-
Henrique Ferreiro authored
Migrate this test out of third_party/blink/web_tests/css3/filters/ and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Bug: 1063749 Change-Id: I0576fddfd300a57f8d92d62306e6d58ba6b7338f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141919 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#757749}
-
Henrique Ferreiro authored
Migrate this test out of third_party/blink/web_tests/css3/filters/ and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Bug: 1063749 Change-Id: If42f93a2184eff9a8f47a193a1c6bc3ebca89452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139656Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#757748}
-
Igor authored
We would like to get in logs a string description of value received from the server rather than the integer value associated with enum. BUG=chromium:1021892 TEST=None Change-Id: Ic1a97924b9b070f35e9e0854dc97380dd115d6c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142268Reviewed-by:
Igor <igorcov@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Igor <igorcov@chromium.org> Cr-Commit-Position: refs/heads/master@{#757747}
-
Austin Tankiang authored
Bug: None Change-Id: I67d1337c2b72ed23937863bdd33db52de9ac8383 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143025Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#757746}
-
Alan Cutter authored
This CL updates ChromeLauncherControllerTest.WebAppPolicy* to be ShelfWebAppBrowserTest.WebAppPolicy* tests and removes the dependency on web apps being Extensions. Bug: 1068919, 1054116 Change-Id: I0a89b926d1ff2184896c03f608879a3265922a4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141397Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#757745}
-
Henrique Ferreiro authored
Migrate this test out of third_party/blink/web_tests/css3/filters/ and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Additionally, rename svg-relative-urls-0001.html to svg-relative-urls-001.html, and add this test as a second test for the same use case. Bug: 1063749 Change-Id: Ifc0a6abfa45a6e6ad16f08388210ddcb0286142a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135755Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#757744}
-
Henrique Ferreiro authored
Migrate this test out of third_party/blink/web_tests/css3/filters/ and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Bug: 1063749 Change-Id: Ib1b0b13c1d02e80dd11ec63afaeeb34c13eb2a6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134242Reviewed-by:
-
Devlin Cronin authored
Add documentation on how to use the chrome.test API, including the core functionality of the API and when to use it, different common methods, design patterns, and do's and don't's. Bug: 1049047 Change-Id: I23130140b4c9ae1247d3703452357895ec265691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133558 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#757742}
-
Nnamdi Theodore Johnson-Kanu authored
This CL moves remaining chromeOS strings from settings_strings.grdp to chromeos_strings.grdp. It continues the process of moving all chromeOS specific strings. Bug: 967883 Change-Id: I296e0c4768f75e49176e76f9b308b26f44f5a168 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142585 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#757741}
-
Samuel Huang authored
extract_unwind_tables.py calls dump_syms, and processes ~400 MB of data from ~105 M lines. Previously these data were written to a temp file, which is then opened and read line-by-line. This approach creates churn, and is prone to out-of-disk-space problem. This CL removes temp file usage by directly piping dump_syms output to _ParseCfiData(), using subprocess.Popen(bufsize=-1)'s |stdout|. Run time is unaffected. Fixed: 1068862 Change-Id: Iaa0d433dcb91a8b15fff4dd6ce0a34fcba8d6376 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141220 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#757740}
-
Kuo-Hsin Yang authored
When ARC is launched, the min filelist configuration may be changed, notify the change to the memory component. BUG=1014871 TEST=check the swap configuration after ARC launch. Change-Id: Ib7d074c4183ff3e7323eb582bf0c8706ec612d10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141488Reviewed-by:
Brian Geffon <bgeffon@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Kuo-Hsin Yang <vovoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#757739}
-
Andrew Comminos authored
Updates the isInputPending implementation to use a discrete/continuous predicate options object, rather than the old list of events. Alters the scheduler tracking to accept a (stubbed out) delegate for querying event attribution information, now that we have it. Bug: 910421 Change-Id: I7aadbdca00cb7c396de1c595f75b365522c204b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130895Reviewed-by:
Scott Haseley <shaseley@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Andrew Comminos <acomminos@fb.com> Cr-Commit-Position: refs/heads/master@{#757738}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I13adf3c6501afb8ff19a5f4444e9379b260b1c8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143553Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/68219bfacaa8..dcf3a9b3dce1 git log 68219bfacaa8..dcf3a9b3dce1 --date=short --first-parent --format='%ad %ae %s' 2020-04-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader ba0c95eb406f..3cfa8e28be80 (9 commits) Created with: gclient setdep -r src/third_party/skia@dcf3a9b3dce1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: csmartdalton@google.com Change-Id: I6ad6415c9d1de5c36b337938f67bab9a2623e421 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143552Reviewed-by:
-
Nnamdi Theodore Johnson-Kanu authored
This CL moves chromeOS strings for apps section page from settings_strings.grdp to chromeos_strings.grdp and os_settings_strings.grdp. It continues the process of moving all chromeOS specific strings. Bug: 967883 Change-Id: I8411437ef5af1c445941ac3a494a92a52fa4b548 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142776 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5dcf1b66..2d536d03 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ida0e8b83b986f4a997ba89dedb8e9e281b280ad7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142501Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#757734}
-
Nicholas Verne authored
The Restore operation only happens if the Crostini container upgrade failed. Bug: 1064915 Change-Id: I5b3b0e1bce6c26d756e6fb9e70346736740b63fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141568Reviewed-by:
Nic Hollingum <hollingum@google.com> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#757733}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/5d56a75005e3..c72a211d0090 git log 5d56a75005e3..c72a211d0090 --date=short --first-parent --format='%ad %ae %s' 2020-04-09 carmenjackson@google.com Update the default systrace tags to the recommended Android defaults. Created with: gclient setdep -r src/third_party/catapult@c72a211d0090 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC eseckler@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: eseckler@google.com Change-Id: Ia616f4c4fda9de3b9020d87bde64807a62f8abc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142978Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f9f8e4b0d42d..c4e55491a936 git log f9f8e4b0d42d..c4e55491a936 --date=short --first-parent --format='%ad %ae %s' 2020-04-09 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@c4e55491a936 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I126dd8dad9d4335e18c346f737016ca8a16eef67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142985Reviewed-by:
-
Nnamdi Theodore Johnson-Kanu authored
This CL moves chromeOS strings for internet page from settings_strings.grdp to chromeos_strings.grdp. It continues the process of moving all chromeOS specific strings. Bug: 967883 Change-Id: I835813d7a5a98269aba997950326c1661735fcc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142766Reviewed-by:
-
Chris Hall authored
- Refactor and simplify next/previous unignored sibling methods on AXNode. - Add extensive documentation, both interface and implementation. - Add more extensive and finer-grained unit tests. R=aboxhall,dmazzoni,aleventhal,janewman@microsoft.com,ethavar@microsoft.com Change-Id: Idd85a35de6a0cfa314dfba7255c22bc58005f1e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102269 Commit-Queue: Chris Hall <chrishall@chromium.org> Reviewed-by:
Jacques Newman <janewman@microsoft.com> Reviewed-by:
Ethan Jimenez <ethavar@microsoft.com> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#757729}
-
Mei Liang authored
The composing favicon logic comes from the explore_sites::ImageHelper. This CL moves the composing logic to a different class, so it can be shared with the FaviconHelper. In addition, this CL integrate the composing logic to FaviconHelper. Change-Id: I267d5611979875ae28e7df09bf0ef02c2206058e Bug: 1064153 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123513 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#757728}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8d8bae65e67d..15398905e2cd git log 8d8bae65e67d..15398905e2cd --date=short --first-parent --format='%ad %ae %s' 2020-04-08 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision e20438c5..6c7769b5 (757496:757605) Created with: gclient setdep -r src/third_party/webrtc@15398905e2cd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I4b64fbdac67857cbb07ceddc92fee6328d1ae430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142974Reviewed-by:
-
Noel Gordon authored
This API was public: I assumed I would need for testing. Turns out no, it's not needed for testing, so make it private. Bug: 1035691, 1061388 Change-Id: I1672d1e9764de5d98ba87b29f0a7823a35dda844 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143095 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Bartek Nowierski authored
Change-Id: Iff85302bb633d9166139bde65a9b627eec13c4d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139951Reviewed-by:
Omer Katz <omerkatz@chromium.org> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#757725}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ac910b82. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" 239eeaa8 "[css-filters] Migrate effect-reference-image.html to WPT" 29baa8ce "[css-filters] Migrate effect-reference-image-hw.html to WPT" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I007c5df260af10c9f37fe7b787568ac19e935176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142499Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#757724}
-
Yu Han authored
Previous to this CL, during manual slot assignment, if an exception is thrown, the state of the HTMLSlotElement is indeterminate. HTMLSlotElement should be restored to the previous state where previous assigned nodes are preserved. This CL implements this behavior by doing the exception check of assigned nodes before the actual assignment. Thus, if an exception is encountered, the assign() function could just return, preserving the previous state. However, this way of doing slot assignment adds an extra loop for assigned nodes. I had tried to do it in one loop. But that required saving the previous state of the Slot and restoring it if exception is detected. I think the added complexity isn't worth it for the little performance benefit. In addition, I made sure that the state of the candidate_assigned_slot_map_ is accurate after each slot assignment recalc. The previous implementation could leave removed nodes still in the map. Because in SlotAssignment:RecalcAssignment(), the children traversal, NodeTraversal::ChildrenOf(owner_->host(), wouldn't encounter removed nodes. Bug: 869308 Change-Id: I3c8938f1c4360d664497b6d16a7753c545729e6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124293 Commit-Queue: Yu Han <yuzhehan@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#757723}
-
Kent Tamura authored
This CL has no user-visible behavior changes Bug: 1067527 Change-Id: Ied6beefbdefb438be69f18132930bafed6b6581a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139178 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#757722}
-
