- 11 Aug, 2020 40 commits
-
-
Nazerke authored
Current behaviour: When focusing the Omnibox, the icon on the far left (G icon, Favicon, e.g.) has no animation. Intended behaviour: The icon on the far left should have a short animation starting from an opacity of 0 and a scale of 0 towards an opacity of 100 and a scale of 1. Bug: none. Change-Id: I06a90707db4e496fe1aef032e2ce110f392e3d81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339531Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#796931}
-
Aya ElAttar authored
This is a reland of f4832bba after re-adding the old PolicyMap::Set Original change's description: > Reland "Remove the old version of PolicyMap::Set" > > This is a reland of 9b84489c > after fixing google_update_policy_fetcher_win.cc > > Original change's description: > > Remove the old version of PolicyMap::Set > > > > 1. Removed the old version of PolicyMap::Set, > > which passes value as unique_ptr. > > 2. Changed all the remaining refs use the new > > version which passes value parameter as base::Value > > instead of unique_ptr. > > > > Bug: 1092469 > > Change-Id: Ie45bb05b603cedcad8119a65134c4f5f008964dc > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332191 > > Reviewed-by: Avi Drissman <avi@chromium.org> > > Reviewed-by: Eugene But <eugenebut@chromium.org> > > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > > Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#795078} > > Bug: 1092469 > Change-Id: I4dfdf57753377ca49a6965b416e2a88c306f2ec7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339958 > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#795338} Bug: 1092469 Change-Id: Ic7ff28813caf0eb258f5e0581c6e9d89fc313812 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346435Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Cr-Commit-Position: refs/heads/master@{#796930}
-
Andy Lu authored
Change the existing Open URLs in Chrome Siri shortcut so that instead of only one URL, it can now accept multiple URLs. Also refactored the code for creating the std::vector of URLs to avoid duplication of code with Open URLs In Chrome Incognito. Bug: 1114012 Change-Id: I22896c3cf1b05c78d5838793c01d2e1bb0b1e211 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342207 Commit-Queue: Andy Lu <andyhylu@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#796929}
-
Andreas Haas authored
This CL adds the "gpu.angle" category to the list of categories in about:tracing. The "gpu.angle" category was enabled by default and could not be disabled before. R=eseckler@chromium.org Change-Id: I243ffcdf1b170371b312e6895b1544cf1e20e551 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349348Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#796928}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/dc4568899168..0376edf14e58 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I8600f924ae47e6dfdd147fac093a18ceaaa96f2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348543Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796927}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c2df5e99..347e854b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie8d626d10e1077fbe4151888076816dea3cd7bdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348579Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796926}
-
Vikas Soni authored
Update feature name string to be consistent with feature variable name. Bug: 1091945 Change-Id: I54ba99dc465cdc40e4189fd642647bfd2d85042a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348335 Auto-Submit: vikas soni <vikassoni@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#796925}
-
Yue Li authored
Adding state guard to fix possible timing issue in QuickAnswersMenuObserver and QuickAnswersControllerImpl. Bug: b/163112381 Test: Manual Test Change-Id: Ibde6a0c3d643d915ad5e2836e10ba45bae501ff9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342140 Auto-Submit: Yue Li <updowndota@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#796924}
-
bttk authored
Likely by mistake some OWNERS files contain email addresses on domains google.org and chomium.org Change-Id: Iade1531598c672cfb7f85b909c72597534ebdce9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347917Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Jon Mann <jonmann@chromium.org> Commit-Queue: who/bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#796923}
-
Gary Tong authored
Bug: 1106950 Change-Id: Ib7e5b508be46a6f9950d2c2ba2b7173b3d9b402e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342248Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Gary Tong <gatong@chromium.org> Cr-Commit-Position: refs/heads/master@{#796922}
-
Elly Fong-Jones authored
This also requires undefining an earlier MAYBE_ macro, which is kind of icky. These tests should have more distinctive names. Bug: 1105167 Change-Id: Idf608d94fabd5ea8de7808007a08fbfe0ba8592c Tbr: anthonyvd@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346976Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#796921}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5ec5587c. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org: external/wpt/css/css-writing-modes NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: Ia4fef08b22f913d2bb63e70e40a94d57cca6e107 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348581Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796920}
-
Hui Yingst authored
This CL removes DISALLOW_COPY_AND_ASSIGN macros in pdf/ and uses explicit deletions instead, since DISALLOW_COPY_AND_ASSIGN is deprecated. Bug: 1010217 Change-Id: Id6ed7fbc30bde1ad8b039f8b78799869699b7c93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347321 Commit-Queue: Hui Yingst <nigi@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
K. Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#796919}
-
zhaoyangli authored
Added the gn flag 'enable_run_ios_unittests_with_xctest=true' to all iOS builders running GTests. Previous it only runs on FYI builders. Bug: 1001667 Change-Id: I3a7cdd01bf1e8abc429ea24823bb0fc1e354304b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348289Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#796918}
-
Peng Huang authored
For Android Surface control, we only use hardware rotation for GL, but not vulkan, because a surface control bug. Bug: 1110443 Change-Id: Iee26f1e86161a6122de2603049fd3a3d664b4ac0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324499Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#796917}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 36 histograms that have been used to generate alerts in the past 90 days and do not already have a date later than or within 60 days of 2021-02-07. TBR=chromium-metrics-reviews@google.com Change-Id: I49d4d4e376ce61e5016ae22d6099dd91e6c1eca9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349368Reviewed-by:
Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Cr-Commit-Position: refs/heads/master@{#796916}
-
Dan Zhang authored
https://quiche.googlesource.com/quiche.git/+log/13ebfa60c3f2..07b2e8df6cc8 $ git log 13ebfa60c..07b2e8df6 --date=short --no-merges --format='%ad %ae %s' 2020-08-10 renjietang Prevent QuicSession from directly accessing streams' flow controller. 2020-08-10 dschinazi Deprecate QUIC version Draft25 2020-08-10 dschinazi Deprecate quic_dont_pad_chlo 2020-08-10 dschinazi Deprecate quic_dont_send_max_ack_delay_if_default 2020-08-10 renjietang Merge QuicStream::ValidateFlowControlLimit() into QuicStream::ConfigSendWindowOffset(). Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src deprecate flags R=dschinazi@chromium.org Change-Id: I9e3fc38118fc51b7c2e67e6134540136376eecfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348030 Auto-Submit: Dan Zhang <danzh@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#796915}
-
Xiaoqian Dai authored
- Fix a bug that back gesture nudge dismiss metrics can be recorded even before back gesture nudge is shown. - Fix a bug in BackGestureContextualNudgeControllerTest class, there are two BackGestureContextualNudgeControllerImpl instances. - Fix several other tests in BackGestureContextualNudgeControllerTest. - Add contextual_tooltip::DismissNudgeReason::kTimeout metrics back, which is logged after back nudge animation sequence is finished. - Modify the timing to record contextual_tooltip::DismissNudgeReason:: kPerformedGesture. Previously it's recorded after back gesture is finished, now it's recorded when back gesture starts. Bug: 1101105 Change-Id: I6cd2b59bb0091892f9c24511c57d692e03272265 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345705 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#796914}
-
Wan-Teh Chang authored
https://chromium.googlesource.com/external/github.com/AOMediaCodec/libavif.git/+log/50c5bbd8f04a..4cfee6282b97 $ git log 50c5bbd8f..4cfee6282 --date=short --no-merges --format='%ad %ae %s' 2020-08-10 ccom Add AVIF_FMT_ZU to fix compiling with non-standard/old compilers (#260) 2020-08-10 wtc Fail if a tile is completely outside grid bounds 2020-08-10 wtc Pass true to avifDecoderDataGenerateImageGridTiles 2020-08-10 wtc Fail if any tile in an image grid is not supported 2020-08-10 wtc Add the disableGridImages setting to avifDecoder 2020-08-10 wtc Update codec_dav1d.c 2020-08-10 wtc Set max image size to 16384 * 16384 2020-08-10 wtc avifImageIdentity8ToRGB8ColorFullRange needs 4:4:4 2020-08-07 wtc Fix incorrect 8-to-16 monochrome YUV conversion 2020-08-06 jdrago Revert "Disable libgav1 until abseil-cpp stops using CMP0077 on newer CMake versions" 2020-08-05 wtc Check out Abseil release tag 20200225.2 2020-08-05 jdrago Update references of VS2017 in comments to VS2019 (minor) 2020-08-05 jdrago v0.8.1 Created with: roll-dep src/third_party/libavif/src Disable grid images. Test: Manually test with https://github.com/AOMediaCodec/av1-avif/blob/master/testFiles/Microsoft/Summer_in_Tomsk_720p_5x4_grid.avif R=dalecurtis@chromium.org,pkasting@chromium.org Bug: 1114916 Change-Id: I1c69c418e6ac82b91a0e89bb65bc06d6a9107a52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347085 Commit-Queue: Wan-Teh Chang <wtc@google.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#796913}
-
Xing Liu authored
It's possible that we may rollback download later feature. We should not load the download schedule data when the feature is disabled. Bug: 1114855 Change-Id: Iaca2998a85296f3a16f0b23d14215425356a4895 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346932Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#796912}
-
Yusuke Sato authored
BUG=1114931 TEST=try Change-Id: I5405f092efdd70f992e9165e4d40d08be863e58d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348333Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#796911}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 133 histograms that show frequent access in the past 90 days. These are the 90% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2021-02-07. TBR=chromium-metrics-reviews@google.com Change-Id: Id1ca3344fdb2f50fd0ad7ad9c4348d3c42a8e766 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348697Reviewed-by:
Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Cr-Commit-Position: refs/heads/master@{#796910}
-
zhaoyangli authored
Accept the request `"<app name>" would like to find and connect to devices on your local network.` Bug: 1114928, 1115099 Change-Id: I777b70c13c6b19c3fc0f30a9a67663afeaa7bc9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347201Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#796909}
-
Li Lin authored
Since there is no server side dependencies, we decided to enable the feature by default. The feature flag will be used as killer-switch in case anything goes wrong and clean up in future milestones. Bug: 921142 Test: manual tests Change-Id: Ibc849d549a394b6487626e6d71435a14e76e9ad6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348010 Commit-Queue: Li Lin <llin@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#796908}
-
Elly Fong-Jones authored
This reverts commit 659a4e4e. Reason for revert: Closed the tree with a compile failure: https://ci.chromium.org/p/chromium/builders/ci/mac-arm64-rel/334 [263/11988] OBJCXX clang_x64/obj/base/base/sdk_forward_declarations.o FAILED: clang_x64/obj/base/base/sdk_forward_declarations.o /opt/s/w/ir/cache/goma/client/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -...(too long) In file included from ../../base/mac/sdk_forward_declarations.mm:5: ../../base/mac/sdk_forward_declarations.h:70:3: error: declaration shadows a variable in the global namespace [-Werror,-Wshadow] kCMVideoCodecType_VP9 = 'vp09' ^ ../../build/mac_files/xcode_binaries/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.0.sdk/System/Library/Frameworks/CoreMedia.framework/Headers/CMFormatDescription.h:618:2: note: previous declaration is here Original change's description: > Reland: "Add support for creating VP9 format extensions for VTVDA." > > Creates a vpcc box based on the configuration info. Reland now uses > a forward declaration for the kCMVideoCodecType_VP9 which is in the > 11.0/10.16 SDK. > > R=avi, sandersd > > Bug: 1103432, 1105187 > Test: Updated unittests. > Change-Id: I15158ec3329054981cab4eefc3316283952f2f48 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348330 > Commit-Queue: Dale Curtis <dalecurtis@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#796873} TBR=avi@chromium.org,dalecurtis@chromium.org,sandersd@chromium.org Change-Id: I6b767665887cee003dea63c3b037769a34021ea7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1103432 Bug: 1105187 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346979Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#796907}
-
Karel Král authored
Implement support for auto-generated mojo method parameters of map types. Thus provide more information for developers while debugging. Bug: 1103623 Change-Id: I3223db2075b174b46e731ca43e1a783726084c28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332713 Commit-Queue: Karel Král <karelkral@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#796906}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/59b4828f293e..72ea2ee4650f 2020-08-11 sugoi@google.com Prevent accessing deleted ImageView objects If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1110549 Tbr: swiftshader-team+autoroll@google.com Change-Id: I5e5dc5c0374c137fec31c999629a738fe2314ae3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347402Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796905}
-
Erik Chen authored
This is no longer necessary now that deploy_chrome handles everything for the developer, including putting lacros-chrome onto an always executable mount point. Bug: 1115083 Change-Id: I1ecb39dd650bfca746bbb26c9a138e784eaadfbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349392 Commit-Queue: Erik Chen <erikchen@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#796904}
-
Randy Rossi authored
Added a id to replace tab_id as unique identifier for the webviews that are created from the platform views service. The tab_id was always 0 because is_root_frame is true on creation. Subsequent lookups for the ax tree id by tab id were only working by chance. The linear search for the tab id among the list of windows always matches the first one found, which was the correct one. This ensures tab ids will be unique. Bug: None Test: display assistant created webviews followed by navigation causing render frames to be swapped Change-Id: Ib6b9f1fd217367423f15965e5b760df1f170caa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342640 Commit-Queue: Randy Rossi <rmrossi@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#796903}
-
Ryan Hansberry authored
Follow guidance by reillyg@ in crrev.com/c/2314024 to discourage clients other than Nearby from using [Sync] methods on adapter.mojom. Change-Id: Ic71e1330747b240ba3f153ac96f6cbab0f375701 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347166Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#796902}
-
Arthur Eubanks authored
Bug: 1114873 Change-Id: Ie2a30e03680172546052c00b83e8f10bf1be0dce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346974 Commit-Queue: Arthur Eubanks <aeubanks@google.com> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#796901}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5edf510941a3..49983ef4e7de 2020-08-11 brianosman@google.com Runtime effect: Gather uniforms in one pass 2020-08-11 jvanverth@google.com MSAA improvements for Direct3D. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: fmalita@google.com Change-Id: Ie8779aa37fed168e1549ddec4c253ca0c10c867e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348282Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796900}
-
Mike Jackson authored
Takes into account the display_override manifest value when determining if the PWA is installable. For example, if the developer specifies: display: "browser" display_override: ["standalone"] This should be installable, but prior to this change, chromium would only evaluate the display property. Since unsupported values are ignored when parsing the manifest, only the first value in the parsed display_override array needs to be evaluated. To test the change use: chrome --enable-features=WebAppManifestDisplayOverride Example websites: - (not installable) https://mwjacksonmsft.github.io/pwa/display-override-browser/index.html - (installable) https://mwjacksonmsft.github.io/pwa/display-override-custom/index.html Explainer: https://github.com/WICG/display-override/blob/master/explainer.m Design document: https://docs.google.com/document/d/1hEmbGVHMN38q1YTaaGccQ-Y5CHr7xIURYPRWXTuvZLo/edit?usp=sharing I2P: https://groups.google.com/a/chromium.org/d/topic/blink-dev/WvIeZT8uSzw/discussion Bug: 1109520 Change-Id: Ib3f7465ed36474b1166f136c3cd6655cc34add0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333541 Commit-Queue: Mike Jackson <mjackson@microsoft.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#796899}
-
yilkal authored
This is a reland of b545f589 The original cl failed in the MSAN test in SupervisedUserNavigationThrottleTest:: AllowEDUCoexistenceInnerWebContents where the inner WebContents is not attached by the time it is expected to. This only happens in the MSAN test case. The fix simply delays the test until it is sure that the inner WebContent is attached. Bug: 1113054 Original change's description: > Use only SafeSearch filter for EduCoexistence webview. > > This cl fixes the bug where the child user is stuck > in EDU account addition flow when the user's parental > control setting is 'Only allow certain sites'. > > Inorder to prevent this error from happening we will do > only safe search filter for the EduCoexistence webview > and not enforce the 'Only allow certain cites' settings > potentially set by the child's parents. > > "https://accounts.google.com" is manually whitelisted. This > is because there is a race condition where we don't know > whether the WebContent is an inner WebContent belonging > to EduCoexistence flow or not by the time throttling happens. > This happens because navigation to accounts.google.com is > started before the <webview> WebContents is attached to > the outer WebContents hosted by the EduCoexistence flow WebUI. > > We are making this exception only to the webview that is present in > the EDUCoexistence flow. The exception is made because the parent is > present with the child during the flow. Extending this exception > to every inner webcontents will may allow the child to break parental > settings. > > Bug: 1079510 > Change-Id: I4f3e65e58537a845613b0c49b03f801f0a3caa08 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316443 > Reviewed-by: Marc Treib <treib@chromium.org> > Reviewed-by: Aga Wronska <agawronska@chromium.org> > Commit-Queue: Yilkal Abe <yilkal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#794661} Bug: 1079510 Change-Id: Ida69bb2fc63efbdbc3e06365290ddc2aed9790c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338856Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#796898}
-
Andrey Zaytsev authored
* Added logic to delay setting status icons on initialization * Removed unnecessary logic to invoke setInitialState in the Mediator constructor Bug: 1070620 Change-Id: I21174d0c874f56eb6ee218fa844bead1fe4a0451 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346285 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Cr-Commit-Position: refs/heads/master@{#796897}
-
Andrew Grieve authored
This reverts commit 393e7114. Reason for revert: Proper fix landed (see bug). Original change's description: > Reduce link pool to stop android-archive-rel OOM'ing > > I'd like to still work on a fix that doesn't reduce the size for bots > with less RAM, but need something quick'ish to fix bot. > > Bug: 1098333 > Change-Id: Ifdfe8f07712e5073419ea0c0c0eb89092c31a1de > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347384 > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Dirk Pranke <dpranke@google.com> > Auto-Submit: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@google.com> > Cr-Commit-Position: refs/heads/master@{#796585} TBR=dpranke@google.com,agrieve@chromium.org Change-Id: I6b445001d0a8ab57d16f3ba2623906da1b509d37 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1098333 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349398Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#796896}
-
Rakib M. Hasan authored
instrumentation tests I temporarily need to remove GOMA compilation. I can't seem to start the GOMA proxy when running the recipe locally. I will be working with LUCI users in order to figure out what to do for that. For the time being I can work around this issue by removing GOMA compilation. Bug: 1041619 Change-Id: Idab34e78b2ec0f6c8ea7e5517bb709096ed1aef1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346939Reviewed-by:
Erik Staab <estaab@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#796895}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I9b6e20194d7697e70cf0e4a787d023ebe26af457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347316Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#796894}
-
Nektarios Paisios authored
This is the first step in the process of merging BrowserAccessibilityPosition and AXNodePosition into one class. We need to adopt the same definition of an embedded object in both places. This is the definition used by IA2 and ATK hypertext, which makes all non-textual nodes that are exposed to the platform APIs into embedded objects. Additionally, we include the definition used by UIA, which makes all empty leaf objects (objects with ignored descendants) as embedded objects. AX-Relnotes: n/a. R=dmazzoni@chromium.org, aleventhal@chromium.org Change-Id: I19bbc26f40d37a07b7dd6436fb0025505a0cfd89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346653Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#796893}
-
Dave Tapuska authored
This test was disabled due to flakiness. Flakiness was fixed in https://chromium-review.googlesource.com/c/chromium/src/+/2347392 BUG=1110429,1112931 Change-Id: Ia3eaa8c85d13761bc3934768e85a0faab6bc039c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347403Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#796892}
-