- 10 Nov, 2020 40 commits
-
-
Vasilii Sukhanov authored
The tests were creating PasswordStoreX early before it was overridden by the testing factory. Now the tests will create TestPasswordStore from the beginning. Fixed: 1146503 Change-Id: I2701d9d44064536acf2d52a0721def71f9e69473 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527382 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#825737}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4f7c1ce4..bc5c4781 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I733458bd3de2139afb22d8544f7dc30949e7e3e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527349Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825736}
-
Sigurdur Asgeirsson authored
Replace ScopedObserver with base::ScopedObservation in /content/browser/storage_partition_impl_unittest.cc. ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was uploaded by git cl split. R=kinuko@chromium.org Change-Id: I87a97adbc8cd1ad3e9bb6131289df74f9afb691a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526167 Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#825735}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1604955437-c91abc52162c185f79a73166dbe14ec0b1c66fea.profdata to chrome-win64-master-1604966213-11b581102b343c7a1c3accf4f99e5d9072414c62.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If5c9183338acc5596272c275f70db23bb705f517 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527956Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825734}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7f9e30c27f7b..aa1e66743da1 2020-11-10 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id3bdcb7e2138ced99ebe8ef3f7cd31f60648165b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528726Reviewed-by:
-
Luciano Pacheco authored
Preparation for JS Modules/Polymer 3, the polymer_modulizer() expects the Polymer element to not be assigned to a variable, so change this for <files-toggle-ripple>. The assignment to variable was used to be able to refer to the type name, however the correct way to refer to type of the Polymer element is to use the `Element` suffix, replace the references to use the right format. When checking this I realized that the externs `files_elements.js` isn't used so removed it too. Bug: 1133186 Change-Id: I09b1929bc8fc9f2efa42cb646a008203f9f46f92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526892 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#825732}
-
Alan Cutter authored
These windows should let the title bar bleed into the WebContents below without any separator. Web app windows with a title bar require a separator line to show the outline of any tabs when adjacent colors are too similar. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=475568&signed_aid=70iR6Zl6eyaEks4wOpBBZg==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=475569&signed_aid=MoU4hgqV5NSMUiizHK5tsw==&inline=1 This CL effectively reverts the change made in https://chromium-review.googlesource.com/c/chromium/src/+/2367584/5/chrome/browser/ui/views/frame/browser_non_client_frame_view.cc to only allow strokes for tab strip web apps instead of all web apps. Bug: 1137301 Change-Id: Ie0dd29872765921f7c1c8840c39bd70736423bed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526756Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#825731}
-
Nico Weber authored
With a chance of 1/256, we'd read past the end of kValidLiteralValues. In practice, that read would return zeroes, which we'd write to kTestLibData -- but zeroes aren't valid literal values, so that would then make TestShader() crash when it tried to link the program. Not sure if this is related to crbug.com/1051923, but it's in the same area at least. Add a components/metal_util:unit_tests target. Covering code is useful even if the test doesn't verify a lot, because then the ASan bots can find stuff like this for us. (...but in this case, asan doesn't find the out-of-bounds read because we build with `-asan-globals=0` on macOS because of https://crbug.com/352073 . But the test also checks for non-0 and runs the code often enough that the test consistently fails before the fix and consistently passes with it.) Drive-by no-op cleanups while here: - Remove EXPORTs on enums, they don't have any effect - Remove redundant is_ios block in components/BUILD.gn Bug: 1147027,1051923,1085899 Cq-Include-Trybots: luci.chromium.try:mac_chromium_asan_rel_ng Change-Id: Ia7f9735e450c70eb64b826a499dc60690714112e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526161 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#825730}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1604966213-a7264b10c906377cb4db39810bd54ed14433c102.profdata to chrome-mac-master-1604987499-7dfc90285fa0600b167fa15e7d7c9c3f744524d3.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I0da505edb9e653dc21ccfeb40f500b6154a2db5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528725Reviewed-by:
-
Anupam Snigdha authored
Initialized the boundingRect property of the virtualKeyboard object to default values during construction. Bug: 1147243 Change-Id: I2a751d08aaff2c70f3cf06931e4b8d183a29b413 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527564 Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#825728}
-
Devlin Cronin authored
Add support for a new property on function types, serializableFunction. IDL Example: callback SerializableFunction = void(); dictionary SerializableFunctionObject { [serializableFunction]SerializableFunction func; }; JSON Example: { "type": "object", "id": "SerializableFunctionObject", "properties": { "func": { "name": "func", "serializableFunction": true, "type": "function", "parameters": [] } } } If this trait is present, functions will be serialized and deserialized as strings, rather than as empty base::DictionaryValues. Add testing for the same. Note: this only provides support in the JSON schema compiler (which includes support in our auto-generated strong-typing code); a follow-up will add support in our bindings code for parsing the values passed from extensions. Bug: 1144841 Change-Id: I430fb211166a5ccffaa6b478642e98115fd25565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518717 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#825727}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1d532cbd0baa..eba8b028ddbc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ib7558e84f081cf3a3b530e38575a45321333e9ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527052Reviewed-by:
-
Devlin Cronin authored
Short-circuit our localization logic to only attempt to localize a file if it may be required. Bug: None Change-Id: I0b418dbad004a6cc890ae02713f9ebeeed9c92fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518199Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ca2031075565..33858054c805 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ricea@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: ricea@google.com Change-Id: If55f62b089303fcfb835fa3b6556194243058d22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528724Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825724}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/eba8b028ddbc..38f3d771bd8e 2020-11-10 treehugger-gerrit@google.com Merge "Use std::any_of to find if any guardrails are used." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ied3384d6a2c46baf60f67dfe0f13b3f4e2b1a3a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527691Reviewed-by:
-
John Palmer authored
Bug: 1111135 Change-Id: I0ecb9491026851d01331a95d20b29fc1e5caf0b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521552 Commit-Queue: John Palmer <jopalmer@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#825722}
-
Ryo Hashimoto authored
This CL depends on CL:2517272 BUG=b:171408795 TEST=components_unittests TEST=Launch Play Store Change-Id: Ie79568e6f03b3433b8d9af1b50fd1db817d76794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517269 Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#825721}
-
Yu-Hsuan Hsu authored
Change stream type to CRAS_CLIENT_TYPE_LACROS for lacros-chrome. The stream type is used while recording UMA logs in CRAS. So we can separate data between ash-chrome and lacros-chrome. BUG=b:167941044 Change-Id: I35a8320bd9b5d372d9f5ac883078d010ed42ee9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521473Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Yu-Hsuan Hsu <yuhsuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#825720}
-
Mathias Carlen authored
The Autofill Assistant stack's lifecycle is not using Chrome's framework designed to provide exactly that. This patch introduces a TabHelper that will become a proper entry point to control construction and destruction of components of the Autofill Assistant stack that depend on a WebContents. This initial patch only adds an empty TabHelper and test and hooks it up in the tab_helpers registry behind a default disabled AutofillAssistantTabHelpers feature. Bug: b/169389571 Change-Id: I3129fd04e5e4dd6c65c1df891383cf29cad508d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521620 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#825719}
-
Keishi Hattori authored
This CL adds accessors to PartitionFreelistEntry::next in order to Hide encoding/decoding of PartitionFreelistEntry pointer as much as possible. Change-Id: Ia01251e27464d33ecff660eb7867f9c06b8f5449 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513846Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#825718}
-
Jérémie Boulic authored
In //ui/file_manager/file_manager/background/js: - app_window.js - app_window_wrapper.js - background_base.js Bug: 1133186 Change-Id: I5d90323c2f330eb4967c4710141d52ce9cd26b87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525885 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#825717}
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: I95c93df05b77c03b3686d7bd9430dfde74229761 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461547 Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#825716}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/528ae31edd58..36787dcb4382 2020-11-10 syoussefi@chromium.org Vulkan: Fix PBO assuming color images 2020-11-10 m.maiya@samsung.com Vulkan: Bug fix in texture respecification code If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Test: Test: ImageTest.Source2DTarget2DTargetTextureRespecify* Change-Id: I72906b4d0039a58000ec1c8286d63d0e98e42fce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527957Reviewed-by:
-
Koji Ishii authored
r824961 crrev.com/c/2515933 copied the code from |LayoutBlock| but the code in |LayoutBlockFlow| that prevents it from running when |ChildrenInline| was not copied. This patch adds the check. Note, the test creates |LayoutNGCustom| in legacy, and adds a |LayoutTextFragment| as a child of the |LayoutNGCustom|. Not to blockify the child is likely an issue in |LayoutNGCustom|, but this case could probably be reproduced by inline custom layout or other inline objects that forces NG. Bug: 1146789 Change-Id: I7ffacc2465ad205d13702dfda03433cc50c423f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526702 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#825714}
-
Victor Hugo Vianna Silva authored
No behavior is changed. Old code is migrated to OnceCallback/BindOnce() or RepeatingCallback/BindRepeating(), using OnceCallback whenever possible. Some instances of base::*Closure() are also migrated to base::DoNothing(). TBR=rdevlin.cronin@chromium.org Bug: None Change-Id: I489a44033b5ffeefb0a68100ba8480c7399970d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527142 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Rushan Suleymanov <rushans@google.com> Auto-Submit: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#825713}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c32d29e103de..7f9e30c27f7b 2020-11-10 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0819e05b662de1cd62bb10ee9a49413dce123c89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527959Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I982dd85364561c588f4457dc80047fba48082a33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528801Reviewed-by:
-
sandromaggi authored
This refactors WaitForDocumentReadyState (and GetDocument ReadyState) to take an (optional) ElementFinder::Result instead of an optional Selector. An optional ElementFinder::Result is here defined as having an empty node_frame_id (which will map to the main frame). Bug: b/2523176 Change-Id: I7db89cc0ec2ede071616b30db42c1f8de9ab2d0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526441 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#825710}
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: Ib9e67a3cccd20549836019db36c507d71db70aa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494202 Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#825709}
-
Ben Reich authored
Move the JavaScript script output from being saved in the devtools_code_coverage directory instead moving into a subdirectory called scripts. This avoids pollution of the devtools_code_coverage directory as merged coverage files will be saved there. R=noel@chromium.org Bug: 1113941 Test: browser_tests --gtest_filter=*FilesApp* --devtools-code-coverage Change-Id: I109846b21d2d31e9a677f68f360409e2ecb3897e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527903Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Ben Reich <benreich@chromium.org> Auto-Submit: Ben Reich <benreich@chromium.org> Cr-Commit-Position: refs/heads/master@{#825708}
-
sandromaggi authored
The previous implementation used a differing strategy based on the optional selector. This CL changes to use the |EvaluateParams| based approach for both cases. This is step 1 in a plan to refactor * WaitForDocumentReadyState * WaitForDocumentToBecomeInteractive to become one. Bug: b/172542134 Change-Id: I5d8cd765e4cb4e922bd3f5e65a03678caa0d52c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523176 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
-
Yusuf Sengul authored
Bug: 1147244 Change-Id: Ib0931d9d8090c343483a1d2c0bcf98ddc2c7d18b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527687Reviewed-by:
Rakesh Soma <rakeshsoma@google.com> Commit-Queue: Yusuf Sengul <yusufsn@google.com> Cr-Commit-Position: refs/heads/master@{#825706}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0833ef41..4f7c1ce4 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7cc1004b02a6dc76d3f8c713c0668f162b0a88ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527538Reviewed-by:
-
Kenichi Ishibashi authored
It owns remotes to ServiceWorkerResource{Reader,Writer} which can be disconnected at any time. Handle these disconnections to provide graceful error propagations. This CL doesn't add tests for some comparison cases (copying and resuming). Follow-up CLs will add these tests. Bug: 1133143 Change-Id: Ie8d76b93ff0ffbf3bfde4ddfe2dfe98b2ab920d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525702Reviewed-by:Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#825704}
-
Jérémie Boulic authored
In //ui/file_manager/file_manager/common/js: - file_type.js - file_type_unittest.js - lru_cache.js - lru_cache_unittest.js Bug: 1133186 Change-Id: Id2b0dc75b4bc18969e6e7b862d0c9282baa0ba06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521886 Auto-Submit: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
-
Bartek Nowierski authored
We're currently evaluating performance of PartitionAlloc-Everywhere (PA-E). Any regressions from zeroing would be inedvartantly attributed to PA-E, as it hugely increases number of memory allocations going through this path. The best course of action would be to postone zeroing until PA-E is fully evaluated and enabled in trunk. Then we should re-enable zeroing and properly re-evaluate it in the new world. Change-Id: I06ee7c63d10b2a14c76a7bd51faab7b616621c88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521881Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#825702}
-
Trent Begin authored
This change adds an implementation of the net error diagnostics dialog for Chrome OS. Now if the connectivity diagnostics webui feature is enabled, the new application is launched, otherwise the legacy chrome app is launched. Bug: 1144261 Change-Id: I924cc5c2fbedfb1a7a5cba90fcd6bbf0b3f48855 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510799 Commit-Queue: Trent Begin <tbegin@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Edward Jung (EMEA) <edwardjung@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#825701}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b6999d94c051..ca2031075565 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ricea@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1064151,chromium:1078229,chromium:1131897,chromium:1136305,chromium:1141619,chromium:1146194,chromium:1147190 Tbr: ricea@google.com Change-Id: I275b0cdd2cb00115c4574053e978cac57d40d75b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528799Reviewed-by:
-
Yuchen Liu authored
b6f2d0699633 [Android] Fix un-paired namespace declare for higher __ANDROID_API__ Change-Id: I6894e4f9a9455f180fdca0b81e8540ff4613f727 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527799 Commit-Queue: Yuchen Liu <yucliu@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Yuchen Liu <yucliu@chromium.org> Reviewed-by:Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#825699}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1d532cbd0baa..eba8b028ddbc 2020-11-10 adsrini@google.com Merge "Add a proto for frametimeline events" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I7aaee782b151bcd021fc3c44ee1ec566eb38e58f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528610Reviewed-by:
-
