- 04 Jan, 2019 40 commits
-
-
Eric Karl authored
GL uses triple buffering, but Vk was set to use double in most cases. Bump Vk to triple buffering for now. Change-Id: I8e68106b5f0306eb6867382d58d1195341d62a07 Reviewed-on: https://chromium-review.googlesource.com/c/1388223Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#619978}
-
Xida Chen authored
leak TBR=maxmorin@chromium.org NOTRY=true Bug: 919117 Change-Id: I74df3710087857eaab2a44e8d1751b4bc7df4a19 Reviewed-on: https://chromium-review.googlesource.com/c/1396235Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#619977}
-
Steven Bennetts authored
This forces explicit dependencies for code relying on //chromeos/login. Only code that is part of the Chrome process should have these deps. For minor BUILD.gn changes: TBR=rdevlin.cronin@chromium.org,hidehiko@chromium.org Bug: 918682 Change-Id: Ic443725f1f6763e36a7214f569542822db94482c Reviewed-on: https://chromium-review.googlesource.com/c/1394800 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#619976}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/936a99460834..f3d4ab343082 git log 936a99460834..f3d4ab343082 --date=short --no-merges --format='%ad %ae %s' 2019-01-04 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@f3d4ab343082 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I5972a30c28af89df8c6b29da5a70ce002ef04746 Reviewed-on: https://chromium-review.googlesource.com/c/1396186Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619975}
-
Roger McFarlane authored
This CL annotates as obsolete and removes the code which generates the following histograms: Autofill.Unknown.HttpResponseOrErrorCode Autofill.Unknown.RequestDuration Autofill.Unknown.BackoffDelay Autofill.Unknown.FailingPayloadSize Samples for these histograms have never been generated in the wild. Bug: 915891 Change-Id: Ic74997a0326c22dee3dc95267c3157c4d646573f Reviewed-on: https://chromium-review.googlesource.com/c/1396233Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#619974}
-
Jungshik Shin authored
It has one change to update the IANA timezone database to 2018i. See https://chromium-review.googlesource.com/c/1395498 for details. TBR=gsathya@chromium.org Bug: 473288 Test: See the CL description at https://crrev.com/c/1395498 Change-Id: Idefb26be5852a4839a0a6d8cf062b09815b626a4 Reviewed-on: https://chromium-review.googlesource.com/c/1396231Reviewed-by:
Jungshik Shin <jshin@chromium.org> Commit-Queue: Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#619973}
-
edchin authored
This CL works towards reducing duplicate code in snapshot_generator.mm. An improvement made in an earlier CL was only made to web view snapshots and not to native views. This CL fixes native view snapshots. Bug: 918032 Change-Id: I37d0a9bdead31ccce8e467846c2927105c0a76c7 Reviewed-on: https://chromium-review.googlesource.com/c/1395878Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#619972}
-
Roger McFarlane authored
This CL removes expires-after="M73" for the following histograms: Autofill.Query.BackoffDelay Autofill.Query.HttpResponseOrErrorCode Autofill.Query.RequestDuration These histograms continue, and will continue, to be of value and should not expire. In particular, these histograms will be of use when comparing the autofill canary server environment users with the prod environment control group. Bug: 915896 Change-Id: Icf9845bc24c2e3cbf5f80ce453c7ff234c5ba756 Reviewed-on: https://chromium-review.googlesource.com/c/1394790Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#619971}
-
Mike Wasserman authored
The Keyboard Shortcut Viewer app has been on by default since M-70. The deprecated codepath to run synchronously in Ash is no longer needed. Remove the flag and cleanup. Bug: 841020 Test: KSV app (Ctrl-Alt-/) works well enough, flag no longer exists. Change-Id: I1c156705acbd1a5d9a5d5cc3beda50a3d1c4ed26 Reviewed-on: https://chromium-review.googlesource.com/c/1394994Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#619970}
-
Xida Chen authored
TBR=maxmorin@chromium.org NOTRY=true Bug: 919100 Change-Id: Iae7d18c3664a0aef21ebee4bc7e5bdcf9ea4a08c Reviewed-on: https://chromium-review.googlesource.com/c/1396300Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#619969}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/63707fc2cc12..5d262aa379e9 Created with: gclient setdep -r src-internal@5d262aa379e9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I712ba8ff8f689ed68edeeec93a93429fa800e461 Reviewed-on: https://chromium-review.googlesource.com/c/1396184Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619968}
-
Theresa authored
Also use BlackHeadline for selectable list layout toolbar (e.g. bookmarks, history, photo picker, etc). BUG=849845 Change-Id: Idc1e643b0d3a22bfb6d8dd9f595e77d48a618195 Reviewed-on: https://chromium-review.googlesource.com/c/1387672 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#619967}
-
Antonio Gomes authored
This is an oneliner removal follow up of crrev.com/c/1351152. TBR=msarda@chromium.org BUG=909715 Change-Id: I8bc16bfb73348c23425351761695cca2258342c6 Reviewed-on: https://chromium-review.googlesource.com/c/1396237Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#619966}
-
Maxim Kolosovskiy authored
Bug: 919089, 919088, 910546 Change-Id: I0ce5a28ccf7f13cfa6fda547b628fbe6cf4d9a83 Reviewed-on: https://chromium-review.googlesource.com/c/1396032 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#619965}
-
Vladimir Levin authored
This patch adds style & layout containment as another criteria for when we establish isolation. R=chrishtr@chromium.org Change-Id: I325edc499d41ea8580d138e982a358f74d13f22e Reviewed-on: https://chromium-review.googlesource.com/c/1388747Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#619964}
-
Vladimir Levin authored
This patch removes the flag added earlier, since the feature has been on without any problems. R=chrishtr@chromium.org, pdr@chromium.org Change-Id: I42e41417f531e2ba47a096cf172234d4f549a5fd Reviewed-on: https://chromium-review.googlesource.com/c/1394915Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#619963}
-
Stephen Chenney authored
With background-repeat: no-repeat and background-size: cover, the computations for dest rect for the no-repeat case use the tile size to set the dest rect. This prevents tiled drawing from painting more than one tile. But the background-size computations for cover and contain use an unsnapped position area to set the tile size, which produces an unsnapped tile size. This unsnapped tile size, when set as the dest rect for painting, results in a tile that doesn't fill the background as one would expect for cover or contain. This patch switches to always computing the cover and contain tile sizes using a snapped position area to give a snapped dest rect. R: fs@opera.com, fmalita@chromium.org Bug: 785171 Change-Id: I38343ac09d689e9d1360e7043b2ef49adeadb983 Reviewed-on: https://chromium-review.googlesource.com/c/1394014 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#619962}
-
Ryan Meier authored
To fix a class of theme-related contrast bugs, BrowserThemePack now does processing for the toolbar to generate COLOR_TOOLBAR by compositing the provided image with the color it will be drawn on top of, and then samples that image into COLOR_TOOLBAR - this solves some issues with contrast checking not working properly if a toolbar image is specified alongside an explicit toolbar color that doesn't represent the color of the image. Additionally, COLOR_FRAME (and its variants) now similarly get replaced with the values computed from their composited images regardless of whether an explicit color was provided (previously, the colors only got set as such if there was no explicit color provided). To preserve some existing behavior, any explicit color provided for COLOR_TOOLBAR is copied into COLOR_INFOBAR (new), and COLOR_DETACHED_BOOKMARK_BAR_BACKGROUND (existing), and several UI elements have been updated to draw using those colors instead of COLOR_TOOLBAR. Bug: 913227 Change-Id: Idc4166f3f4e4ee75f178fddc40458b03883e85cc Reviewed-on: https://chromium-review.googlesource.com/c/1387154 Commit-Queue: Ryan Meier <rameier@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#619961}
-
Liquan(Max) Gu authored
Currently, FCP++ records new image and text for the whole life cycle of a tab. However, FCP++ should only be interested in the elements attached before user input. This is because user input can cause changes to the DOM. That's why FCP++ need to stop recording new elements upon user input. The CL causes behavior changes to FCP++. * When users give input other than kMouseMove, kMouseEnter, kMouseLeave and pinches, FCP++ deactivate its detectors. Note that the user inputs include both those handled by mainthread (click, touch, etc) and compositor thread (off-mainthread scrolling, gesture, etc). But these exclude the input events that have been filtered from the browser side. * When deactivated, the text and image detector stops to record new entries and node removal. But they still observe the loading status. In other words, if an image is recorded before deactivation, and finish loading after deactivation, the image paint detector can still observe the loading being finished. Bug: 915804 Change-Id: I49d3d9aa0b2e73a4775147ff1a2bb4b065c5b9b2 Reviewed-on: https://chromium-review.googlesource.com/c/1380947Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#619960}
-
Friedrich Horschig authored
This CL adds and connects the new view binder which creates chips and footer commands based on the AccessorySheetTab data. In order to make the "ripple effect" work for chips, the drawable draws a large rounded rectangle in the background color over the animated image which effectively cuts and rounds the corners. Bug: 853772, 911084 Change-Id: If2740994aa752e11233c90eca062b529b8ea36ce Reviewed-on: https://chromium-review.googlesource.com/c/1367650 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#619959}
-
Xida Chen authored
TBR=maxmorin@chromium.org NOTRY=true Bug: 919100 Change-Id: Ie218eb7ea89b447c9f53d303b5d0d73ed9a9b4c3 Reviewed-on: https://chromium-review.googlesource.com/c/1396226Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#619958}
-
Max Morin authored
Tbr: charliea Bug: 820282 Change-Id: Ifa750d2c2a1b208b1c07acb1c473c220b7356a44 Reviewed-on: https://chromium-review.googlesource.com/c/1396146Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#619957}
-
Morten Stenshorne authored
4 new failing tests. 1 test that used to fail in NG now passes. 12 tests recently marked as failing in legacy, but pass in NG. TBR=atotic@chromium.org, kojii@chromium.org Bug: 864398 Change-Id: I2f39ba62a4162da0834b3a29342315b1c334cd67 Reviewed-on: https://chromium-review.googlesource.com/c/1396028Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#619956}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5df21f21..d16e9a9b Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I21ccefd229e0b1e5796131389e7e1e54dfc0b461 Reviewed-on: https://chromium-review.googlesource.com/c/1395993Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619955}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/231bbe3a803d..63707fc2cc12 Created with: gclient setdep -r src-internal@63707fc2cc12 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie0d88abfb402eb8416559976d0cc4448b9b2f74d Reviewed-on: https://chromium-review.googlesource.com/c/1396180Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619954}
-
Xida Chen authored
This reverts commit 873fae30. Reason for revert: This is not the cause of the net_unittests failure, apparent there is crbug.com/869227 Sorry about that. Original change's description: > Revert "Fix incorrect behaviour of settings UI for IP address and name servers." > > This reverts commit 6d16ec71. > > Reason for revert: Suspect causing failure to the net_unittests here: > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/38075 > > Original change's description: > > Fix incorrect behaviour of settings UI for IP address and name servers. > > > > * Block IP address and name servers checkboxes and input fields when > > corresponding settings are enforced by policy and not recommended. > > * Correctly show policy indicators for these settings. > > > > Bug: 847429 > > Change-Id: I3db8ad751ebe44dff487cc01721019738f72c4e5 > > Reviewed-on: https://chromium-review.googlesource.com/c/1335487 > > Commit-Queue: Zakhar Voit <voit@google.com> > > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > > Reviewed-by: Alexander Hendrich <hendrich@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#619929} > > TBR=stevenjb@chromium.org,hendrich@chromium.org,voit@google.com > > Change-Id: I986daf88eb60ac7e1e5113ef9c857b473a7f8d0e > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 847429 > Reviewed-on: https://chromium-review.googlesource.com/c/1396219 > Reviewed-by: Xida Chen <xidachen@chromium.org> > Commit-Queue: Xida Chen <xidachen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#619947} TBR=stevenjb@chromium.org,xidachen@chromium.org,hendrich@chromium.org,voit@google.com Change-Id: I8e7a192ea6ea63f18d520212ef3792864d2c1068 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 847429 Reviewed-on: https://chromium-review.googlesource.com/c/1396224Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#619953}
-
Xida Chen authored
Test is flaky TBR=maxmorin@chromium.org NOTRY=true Bug: 919096 Change-Id: I90e8113f1e1271ff9faaa6185bb34036916b2f4f Reviewed-on: https://chromium-review.googlesource.com/c/1396222Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#619952}
-
Rune Lillesveen authored
The apply code early returns if the type is not a CSSBorderImageSliceValue. Create an initial value which matches the expected type. Bug: 918243 Change-Id: I3228d2410789306d915db892ad54e918631b8864 Reviewed-on: https://chromium-review.googlesource.com/c/1396118Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#619951}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/8743424b5d6d..39a48a8a5d7d git log 8743424b5d6d..39a48a8a5d7d --date=short --no-merges --format='%ad %ae %s' 2019-01-04 dhanyaganesh@chromium.org lib/buildstore.py: Initial BuildStore Created with: gclient setdep -r src/third_party/chromite@39a48a8a5d7d The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ia0f4d46ed1a8f8f36207d902b4d481e9951bbe53 Reviewed-on: https://chromium-review.googlesource.com/c/1396178Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619950}
-
Nasko Oskov authored
As of https://crrev.com/617708 the expectation is that all renderer initiated navigations must specify the origin of the document that started the navigation. This CL fixes OpenNewForegroundTab to supply initiator origin for the navigation in the newly opened tab. To achieve that, the initiator origin is exposed through NavigationHandle's public API. TBR=ortuno@chromium.org Bug: 882053 Change-Id: I3867a5579d5dcc954f0759a93cc5c0f431a092b8 Reviewed-on: https://chromium-review.googlesource.com/c/1395418 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#619949}
-
Vadym Doroshenko authored
Along the way the function CanProvisionalManagerSave is renamed to IsReadyForAutomaticSaving because it shows better what this function checks. Bug: 831123 Change-Id: Iabf125fd8b46a15cccbe5e6152e98352e5facde2 Reviewed-on: https://chromium-review.googlesource.com/c/1391685 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#619948}
-
Xida Chen authored
This reverts commit 6d16ec71. Reason for revert: Suspect causing failure to the net_unittests here: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/38075 Original change's description: > Fix incorrect behaviour of settings UI for IP address and name servers. > > * Block IP address and name servers checkboxes and input fields when > corresponding settings are enforced by policy and not recommended. > * Correctly show policy indicators for these settings. > > Bug: 847429 > Change-Id: I3db8ad751ebe44dff487cc01721019738f72c4e5 > Reviewed-on: https://chromium-review.googlesource.com/c/1335487 > Commit-Queue: Zakhar Voit <voit@google.com> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Alexander Hendrich <hendrich@chromium.org> > Cr-Commit-Position: refs/heads/master@{#619929} TBR=stevenjb@chromium.org,hendrich@chromium.org,voit@google.com Change-Id: I986daf88eb60ac7e1e5113ef9c857b473a7f8d0e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 847429 Reviewed-on: https://chromium-review.googlesource.com/c/1396219Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#619947}
-
Biren Roy authored
This CL lands server change 226511201 by birenroy. BUG=488484 Change-Id: I1cc9db648b8cd7f74cae239cd53c684fd24e568e Reviewed-on: https://chromium-review.googlesource.com/c/1394433Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Birendro Roy <birenroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#619946}
-
Xida Chen authored
TBR=maxmorin@chromium.org NOTRY=true Bug: 919090 Change-Id: Ie7e13df26de11ef7183cba9f6f08778e0ab97898 Reviewed-on: https://chromium-review.googlesource.com/c/1396218Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#619945}
-
Morten Stenshorne authored
Was failing, but not marked as such. Now it should pass. TBR=atotic@chromium.org,kojii@chromium.org Change-Id: I430859f81ede22e6cb33c724c912250137b71f51 Reviewed-on: https://chromium-review.googlesource.com/c/1396122Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#619944}
-
Oleh Prypin authored
https://github.com/webrtc/apprtc/blob/20cdd7652d58c9cf47ef92ba0190a5505760dc05/src/web_app/js/call.js#L159 sends an XHR on page close which is now an error in Chromium. Ignoring the error doesn't cause any problems, especially for the purpose of this test, so until a real fix is made, this is a simple way to un-break tests. (https://ci.chromium.org/p/chromium/g/chromium.webrtc) Bug: 918871 Change-Id: I29497a39424a1c54e7b6875edc0cb896663221ea Reviewed-on: https://chromium-review.googlesource.com/c/1396019Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Oleh Prypin <oprypin@chromium.org> Cr-Commit-Position: refs/heads/master@{#619943}
-
Jérôme Lebel authored
AccountSigninItem uses SettingsImageDetailTextCell to display the UI. Change-Id: I225f1967287ead71297cb9b0873fb7b14552e8d9 Reviewed-on: https://chromium-review.googlesource.com/c/1392962 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#619942}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dd0edf714415..231bbe3a803d Created with: gclient setdep -r src-internal@231bbe3a803d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Id86b0a004b50f0710a9cb6ce39037a4685b1250a Reviewed-on: https://chromium-review.googlesource.com/c/1396177Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619941}
-
Gauthier Ambard authored
This CL fixes the frame computation for the NTP, taking into account the BrowserContainerFullscreen experiment. Bug: 918435 Change-Id: I55e31b86262c3b30ae3a51029dba2336929076a5 Reviewed-on: https://chromium-review.googlesource.com/c/1392956 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#619940}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c519fed6ddce..5f1692c60a43 git log c519fed6ddce..5f1692c60a43 --date=short --no-merges --format='%ad %ae %s' 2019-01-04 kjlubick@google.com [canvaskit] Allow providing webgl context and canvas element Created with: gclient setdep -r src/third_party/skia@5f1692c60a43 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: Ibabe7a70a4ce2c43785f2941c06fb38e256901fa Reviewed-on: https://chromium-review.googlesource.com/c/1395736Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619939}
-