- 11 Aug, 2020 40 commits
-
-
Piotr Bialecki authored
(potential) Fix for flakiness has already landed, but the test got disabled before that happened. This CL will reenable the test. In case the fix is not sufficient to get rid of flakiness, the test logic will have to be rewritten. Bug: 1112773 Change-Id: Ifeb07c6b9cf30e587d7804f0b3af9e345e550c5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346923 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#796956}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0b969adbdff1..ae8f8fdcda03 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC slightlyoff@google.com,ellyjones@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: slightlyoff@google.com,ellyjones@google.com Change-Id: I1b1e147930d54898ef08cced93496a30b1608132 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349393Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796955}
-
Rouslan Solomakhin authored
This is a reland of b772a8f1 Original patch: https://crrev.com/c/2341163 Revert: https://crrev.com/c/2348532 Reason for revert: New WPT test revealed a memory issue in //third_party/blink/renderer/modules/payments/payments_validators.cc when serializing data larger than than 1MB into JSON. Reason for reland: Split out the large data serialization tests into a separate patches for fixing the JSON serialization issue separately: 1) https://crrev.com/c/2348411 2) https://crrev.com/c/2348540 3) https://crrev.com/c/2346973 Original change's description: > [Web Payment] Secure payment confirmation Blink parameters. > > Before this patch, requesting "secure-payment-confirmation" method in > PaymentRequest API would not validate the parameters. > > This patch adds the "secure-payment-confirmation" parameters to > PaymentRequest API and validates them, if the > "SecurePaymentConfirmation" feature is enabled. > > After this patch, PaymentRequest API validates the secure payment > confirmation parameters. > > Explainer: https://github.com/rsolomakhin/secure-payment-confirmation > Feature status: https://chromestatus.com/feature/5702310124584960 > Intent to prototype: > https://groups.google.com/a/chromium.org/g/blink-dev/c/myUR5gyd5Js/m/iELL67NQAgAJ > > Bug: 1110324 > Change-Id: I7a4b6f9da1b3e1d7604bcd9e4733dc789f77ec4b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341163 > Reviewed-by: Nick Burris <nburris@chromium.org> > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > Auto-Submit: Rouslan Solomakhin <rouslan@chromium.org> > Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#796792} TBR=ellyjones, nburris, kouhei Bug: 1110324, 1115091 Change-Id: I05ebdbfe234d3bee8ceb2016dafc5679a9a28ef9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348410 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#796954}
-
ckitagawa authored
This is an alternative/complimentary change to http://crrev.com/c/2346905 Using First Meaningful Paint has two benefits. 1. It waits for key content to paint. 2. It doesn't wait for total loading to stop just down to a couple network requests. This is good in that we stop showing the preview earlier (which is desirable if the page is actually painted sooner). I think both this and LoadingProgress are feasible. This one is more promising in the sense that it takes a guess as to when the painting is mostly done whereas the PageLoadProgress variant is mostly about network requests being done. One option might be to combine the two and take the later of the signals? With these changes it might be worth making the removal delay 0 ms or at least smaller. Bug: 1110360 Change-Id: I6c4400166d0bfef57160424de2238bcbe238949a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346863Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#796953}
-
Liviu Tinta authored
Intent to Ship link: https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=footer#!msg/blink-dev/ZRI-7X_4GwM/Sp1ZMIw5AgAJ Bug: 1069500 Change-Id: I01630006c2eebb1fdb0b09a08af59cf230ed33f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343385Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Cr-Commit-Position: refs/heads/master@{#796952}
-
Dave Tapuska authored
AutoResize only worked for the top level widget. Move the handling from RenderWidget into WebViewFrameWidget. BUG=1097816 Change-Id: I66f18640531676c688fe3ee149ed253d4f01c0a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317807Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#796951}
-
Gang Wu authored
This CL enable copy image by default before enable copy image experiment to 100%. Bug: 1043329 Change-Id: Iad07f1bf496449f8e02e24f3a3d9de8f3a8dec57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298180Reviewed-by:
Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#796950}
-
Zhongyi Shi authored
Bug: 1114590, 1090532 Change-Id: Ic149aa63ee65fe2f78c4bb8f28497677ec4ac4c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347325 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#796949}
-
Devlin Cronin authored
Content scripts can specify if they should be injected in about:-scheme frames or use the effective origin as a fallback in the case of e.g. opaque frames. Currently, these are stored in two separate booleans on the user script. Instead, use a single enum to track this behavior, with three settings: match, don't match, or match and climb the frame tree for about: frames (the latter is necessary for the current behavior of about:blank). Update UserScript and references appropriately, and add additional unit test coverage for match_about_blank and use_origin_as_fallback. This CL does not change behavior for match_about_blank. match_origin_as_fallback now matches both data: and about: schemes. Bug: 55084 Change-Id: I3a52a244a8a6b0b3535608d8a6551aa94057aa22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343312 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#796948}
-
John Lee authored
Bug: 973674 Change-Id: I88427bb8259bda94af6550228e7925212df791a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341178Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#796947}
-
Elly Fong-Jones authored
It is flaky on Linux. Bug: 1115201 Change-Id: I6fc6b61d511decb288d2d311f9a412bd8bc98e6e Tbr: cduvall@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349669Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#796946}
-
James Long authored
This change brings in the vue-material package and updates the UI to use its Material design components. All the graph controls are now in a sidebar, and the graph canvas is responsive to fit the size of the page. Bug: 1102546 Change-Id: If47d8319337a9700bd921ba3938d3fe3da7b67b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347407Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: James Long <yjlong@google.com> Cr-Commit-Position: refs/heads/master@{#796945}
-
Weilun Shi authored
Add extract_histograms_test to metrics_python_tests so that extract_histograms_test will be run by trybot. Bug: 1114894 Change-Id: Ieae44071631a018e705dd11baa60fe0ab7cd9d7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347891 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Auto-Submit: Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#796944}
-
Liviu Tinta authored
Different browsers fire different number of events for this test. Stop the test when the done button is clicked instead of when a certain number of events are fired. There are significant differences in how browsers fire pointer events and compatible mouse events when an element is removed from the DOM. There is a discussion here: https://github.com/w3c/pointerevents/issues/285 about the order of pointerenter events and compatible mouseenter events when an element is removed from the DOM. Once the discussion is finalized and there is consensus this test might have to be adjusted. Change-Id: I5202eb7a1fcc557985279a978596c9446105f417 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348530 Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Reviewed-by:
-
Olesia Marukhno authored
Add accessibility support for pedals and dedicated row. Updated announcements for normal state to include information about available actions (pedals, search, switch to tab). If there are multiple actions available, they aren't read individually but suggestion to iterate over them is read. Added announcements for pedal buttons and search button when they are focused. Message for focused pedals doesn't include information about suggestion because the suggestion information doesn't contain any additional information about pedal. Bug: 1104264 Change-Id: I740afef8c8bc39cadd4ca5f5d5d263f4481d32af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339626Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com> Cr-Commit-Position: refs/heads/master@{#796942}
-
Mikhail Khokhlov authored
A benchmark to measure the power effect of downloading one big vs several small files. Bug: b/161112814 Change-Id: Ia27528bcf3aac9acd3e0602cc11df5561f47b83f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329304Reviewed-by:
Wenbin Zhang <wenbinzhang@google.com> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#796941}
-
Takumi Fujimoto authored
This fixes a regression relative to the extension MRP where we were establishing a presentation connection only if a client ID is set. If mirroring is initiated by a site with cast:0F5096E8 there is no client ID but we still need a presentation connection. Bug: 1114891, b/163366468 Change-Id: Ib66768c52851bb87aba307775d917b81bf669572 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347890 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#796940}
-
Collin Baker authored
This enables mocking in tests. It also is a step towards exposing the interface in chrome/browser/ui. Bug: 1106523 Change-Id: If909e252e982857975aacf348a90d9ef0269dee4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343321Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#796939}
-
Adrienne Walker authored
Once AppCache has been removed from Chrome, sites will have no way of cleaning up user data in local profiles. To fix this, when a storage partition is accessed when AppCache has been disabled, we will delete the AppCache directory from that profile directory. Bug: 1081897 Change-Id: Iea404f7c83595ba1397fab4a5d3f97d1e3280916 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343588 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#796938}
-
zhaoyangli authored
WebRTC test configs were fixed in crrev/c/2321333. The workaround is no longer needed and removed in this CL. Bug: 1110375 Change-Id: I57acb3f10de89eb810c79f46baf811111c35d8e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347973Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#796937}
-
Thiabaud Engelbrecht authored
As detailed in this CL: https://chromium-review.googlesource.com/c/chromium/src/+/2314832 These should have been "Small", they currently don't show up in the UMA. Bug: 1106364 Change-Id: I7c7b040d5cbfab25c579668951e2e0a16cf3a76a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348704Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#796936}
-
Marijn Kruisselbrink authored
Bug: 1114898 Change-Id: I0b527a8fdc2dd4d5fcb5b9eb7140fa8ac4faa069 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347921 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#796935}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f867ba8b5d48..5401bad7015d 2020-08-11 nisse@webrtc.org Prepare for deleting VideoCodec::plType 2020-08-11 dharmesh.r.chauhan@gmail.com Disable switch camera and route change buttons when processing 2020-08-11 titovartem@webrtc.org Move initialization of GoogleMock and flags to main from test_main_lib 2020-08-11 philipp.hancke@googlemail.com video_replay: wrap main thread 2020-08-11 hta@webrtc.org Reland "Implement transceiver.stop()" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:980879 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I0f20716350e06947f7d98ebcf9908ccec75a7ec0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349390Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796934}
-
Jan Wilken Dörrie authored
This change moves the classes PasswordReauthenticationFragment.java and ReauthenticationManager.java from chrome/android to chrome/browser/password_manager/android. The goal of this change is to be able to re-use these classes in the password_check module, without having to depend on chrome_java. Bug: 1114720 Change-Id: Id8c20716453a42f4187c6da21c5b9f8eb5744ed4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346570Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#796933}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/dc4568899168..21e5b4554a5f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I3af9677f0328b8b51e18fea1eb8f260863732167 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349388Reviewed-by:
-
Nazerke authored
Current behaviour: When focusing the Omnibox, the icon on the far left (G icon, Favicon, e.g.) has no animation. Intended behaviour: The icon on the far left should have a short animation starting from an opacity of 0 and a scale of 0 towards an opacity of 100 and a scale of 1. Bug: none. Change-Id: I06a90707db4e496fe1aef032e2ce110f392e3d81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339531Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#796931}
-
Aya ElAttar authored
This is a reland of f4832bba after re-adding the old PolicyMap::Set Original change's description: > Reland "Remove the old version of PolicyMap::Set" > > This is a reland of 9b84489c > after fixing google_update_policy_fetcher_win.cc > > Original change's description: > > Remove the old version of PolicyMap::Set > > > > 1. Removed the old version of PolicyMap::Set, > > which passes value as unique_ptr. > > 2. Changed all the remaining refs use the new > > version which passes value parameter as base::Value > > instead of unique_ptr. > > > > Bug: 1092469 > > Change-Id: Ie45bb05b603cedcad8119a65134c4f5f008964dc > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332191 > > Reviewed-by: Avi Drissman <avi@chromium.org> > > Reviewed-by: Eugene But <eugenebut@chromium.org> > > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > > Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#795078} > > Bug: 1092469 > Change-Id: I4dfdf57753377ca49a6965b416e2a88c306f2ec7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339958 > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#795338} Bug: 1092469 Change-Id: Ic7ff28813caf0eb258f5e0581c6e9d89fc313812 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346435Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Cr-Commit-Position: refs/heads/master@{#796930}
-
Andy Lu authored
Change the existing Open URLs in Chrome Siri shortcut so that instead of only one URL, it can now accept multiple URLs. Also refactored the code for creating the std::vector of URLs to avoid duplication of code with Open URLs In Chrome Incognito. Bug: 1114012 Change-Id: I22896c3cf1b05c78d5838793c01d2e1bb0b1e211 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342207 Commit-Queue: Andy Lu <andyhylu@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
-
Andreas Haas authored
This CL adds the "gpu.angle" category to the list of categories in about:tracing. The "gpu.angle" category was enabled by default and could not be disabled before. R=eseckler@chromium.org Change-Id: I243ffcdf1b170371b312e6895b1544cf1e20e551 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349348Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/dc4568899168..0376edf14e58 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I8600f924ae47e6dfdd147fac093a18ceaaa96f2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348543Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c2df5e99..347e854b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie8d626d10e1077fbe4151888076816dea3cd7bdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348579Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796926}
-
Vikas Soni authored
Update feature name string to be consistent with feature variable name. Bug: 1091945 Change-Id: I54ba99dc465cdc40e4189fd642647bfd2d85042a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348335 Auto-Submit: vikas soni <vikassoni@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#796925}
-
Yue Li authored
Adding state guard to fix possible timing issue in QuickAnswersMenuObserver and QuickAnswersControllerImpl. Bug: b/163112381 Test: Manual Test Change-Id: Ibde6a0c3d643d915ad5e2836e10ba45bae501ff9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342140 Auto-Submit: Yue Li <updowndota@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#796924}
-
bttk authored
Likely by mistake some OWNERS files contain email addresses on domains google.org and chomium.org Change-Id: Iade1531598c672cfb7f85b909c72597534ebdce9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347917Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Jon Mann <jonmann@chromium.org> Commit-Queue: who/bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#796923}
-
Gary Tong authored
Bug: 1106950 Change-Id: Ib7e5b508be46a6f9950d2c2ba2b7173b3d9b402e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342248Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Gary Tong <gatong@chromium.org> Cr-Commit-Position: refs/heads/master@{#796922}
-
Elly Fong-Jones authored
This also requires undefining an earlier MAYBE_ macro, which is kind of icky. These tests should have more distinctive names. Bug: 1105167 Change-Id: Idf608d94fabd5ea8de7808007a08fbfe0ba8592c Tbr: anthonyvd@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346976Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5ec5587c. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org: external/wpt/css/css-writing-modes NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: Ia4fef08b22f913d2bb63e70e40a94d57cca6e107 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348581Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796920}
-
Hui Yingst authored
This CL removes DISALLOW_COPY_AND_ASSIGN macros in pdf/ and uses explicit deletions instead, since DISALLOW_COPY_AND_ASSIGN is deprecated. Bug: 1010217 Change-Id: Id6ed7fbc30bde1ad8b039f8b78799869699b7c93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347321 Commit-Queue: Hui Yingst <nigi@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
K. Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#796919}
-
zhaoyangli authored
Added the gn flag 'enable_run_ios_unittests_with_xctest=true' to all iOS builders running GTests. Previous it only runs on FYI builders. Bug: 1001667 Change-Id: I3a7cdd01bf1e8abc429ea24823bb0fc1e354304b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348289Reviewed-by:
-
Peng Huang authored
For Android Surface control, we only use hardware rotation for GL, but not vulkan, because a surface control bug. Bug: 1110443 Change-Id: Iee26f1e86161a6122de2603049fd3a3d664b4ac0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324499Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#796917}
-
