- 21 May, 2020 40 commits
-
-
Ahmed Fakhry authored
We found that a process snapshot was being built multiple times individually while the task manager is running by vm and arc code. Since each build of the process snapshot is full walk of /proc fs, this is wasteful and unnecessary. This CL introduces the ProcessSnapshotServer to serve a process snapshot to its vm and arc clients that is refreshed only once every certain delay that matches the smallest one requested by all clients. BUG=chromium:1083062, b/154362057 TEST=Manually, added some tests. Change-Id: I68ea1cfad6b024dc47276e4681a408f052ec3240 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2183473 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#771162}
-
Yi Gu authored
The scroller in the updated tests is not composited by default. When we run the tests with the virtual/threaded test suite, the tests can not properly run on the compositor because cc::ScrollTimeline is considered as inactive, i.e. scroller is not in cc::ScrollTree because it's not composited. This patch forces compositing the scrollers if the animation needs to play. Note that once all ScrollNodes including uncomposited ones are in the compositor after the scroll unification (crbug.com/476553), we no longer need to add will-change to the scrollers. Bug: None Change-Id: I0e379abb071c9bffc58f2167f4cac9f92edbb9da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211048Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#771161}
-
ckitagawa authored
If a recording contains a reference to a GPU accelerated image it cannot be accessed from another thread. As such serialization should be done only on the capturing thread. Bug: 1084183 Change-Id: Ibe13c5e636d94b0fabb86a152ec4225e31088c59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212451 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Commit-Queue: Fred Mello <fredmello@chromium.org> Auto-Submit: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Fred Mello <fredmello@chromium.org> Cr-Commit-Position: refs/heads/master@{#771160}
-
Liviu Tinta authored
Move mouse pointerevents compat events to wpt Change-Id: I9581dde4d6016a3eb81ea16674c439e63897523c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199985 Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#771159}
-
Ramya Nagarajan authored
This reverts commit be2aab1c. Reason for revert: Step "compile" failing on 3 builder(s) Builder: chromeos-betty-pi-arc-cfi-thin-lto-chrome https://ci.chromium.org/p/chrome/builders/ci/chromeos-betty-pi-arc-cfi-thin-lto-chrome First failing build: https://ci.chromium.org/p/chrome/builders/ci/chromeos-betty-pi-arc-cfi-thin-lto-chrome/b8879666664893307472 -------------------- Builder: chromeos-arm-generic-cfi-thin-lto-chrome https://ci.chromium.org/p/chrome/builders/ci/chromeos-arm-generic-cfi-thin-lto-chrome First failing build: https://ci.chromium.org/p/chrome/builders/ci/chromeos-arm-generic-cfi-thin-lto-chrome/b8879668479378837648 -------------------- Builder: chromeos-eve-chrome https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-chrome First failing build: https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-chrome/b8879665644223805168 Original change's description: > Remove set_owned_by_client() from AutoclickScrollPositionHandler. > > It's safe for the Widget to own the underlying View via > SetContentsView(). This was not immediately obvious; much of this CL is > adjacent refactoring and cleanup that simplifies the ownership/lifetime. > > Bug: 1044687 > Change-Id: I76cbc402edb7195c42cbae679a89839384d0615a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210914 > Commit-Queue: Peter Kasting <pkasting@chromium.org> > Auto-Submit: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Katie Dektar <katie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#771122} TBR=pkasting@chromium.org,katie@chromium.org Change-Id: I7a18d84cfae23938b683f9a3aaf7b533781b975a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1044687 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212824Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Commit-Queue: Ramya Nagarajan <ramyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#771158}
-
Bo Liu authored
Users reporting issues with DFM installs. Bug: 1064314 Change-Id: I0b113ce1b822ca8281289372f91681e8a0eb77be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212484 Auto-Submit: Bo <boliu@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#771157}
-
behdad authored
Updates: - Guides added for adding experimental attribute to a story and when to do so. - How to run perf tests locally is added to the document Bug: none Change-Id: Ie2c3f34906d185cd3992e4a614c49f43e4c3ad4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210632Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#771156}
-
Peng Huang authored
The problem is because a recent CL https://crrev.com/c/2149640 which implements ProduceOverlay() but doesn't provide gpu fence for the overlay access. Workaround the problem by creating a gpu fence for the primary plane in SkiaOutputDeviceBufferQueue when GL is used. Bug: 1082519,1085485 Change-Id: I86431c866d94ee2f1e29a939aed11f6dab6a57b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212548Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#771155}
-
Wan-Teh Chang authored
Pass gfx::ColorSpace by reference to the YUVToRGBConverter constructor. Change-Id: I1f704e0eff21fbee47ab27df6f3c557684303812 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211937Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#771154}
-
Henrique Nakashima authored
A bug in JellyBean with rewinding buffers required a workaround. JellyBean has not been supported for a while, so this can be removed. Change-Id: I99aa7ea55ded13e9748b34c3902ce085fade4c2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212448Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#771153}
-
Noel Gordon authored
CL:2144427 added Polymer iron-a11y-announcer.html to cr_toast.html but no dep for same to the js_library("cr_toast") build rule: fix that and add the same dep to js_library("cr_toast.m") per review comments. Minor: add @private CLosure markup to announceA11yMessage_(). Bug: 1033660, 1002391 Change-Id: Ic0cfbe4177c7813339481dfa5d5c5c7e289f9ad0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210194 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:dpapad <dpapad@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#771152}
-
Nicolás Peña Moreno authored
This CL adds the LCP content type and the LCP algorithm termination state to a new event PageLoad_Internal which may not be sampled at the same rate as the PageLoad event. Ukm collection review: https://docs.google.com/document/d/10UwogGASJIoEQvuOaZOHgG8XTnyE7HMgvjKcceKOwqU/ Bug: 1082483 Change-Id: Ie002d201a529366231d0d6b6e5e8c01756b307ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202116 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#771151}
-
Jeroen Dhollander authored
This will help us detect failures caused by LibAssistant sending the |OnInteractionFinished| event before all the responses (like |OnOpenAndroidApp|) are received. This will help us detect if the current test failures are caused by this, or if there is some other cause we need to find. The failure looks as follows (newlines added for commit message only): assistant.OpenAndroidApp [ FAIL ] Failed to send the Assistant text query: Error: OnOpenAppResponse was called after the interaction was closed Bug: b/157144814 Change-Id: I22b29f1d7bcdebd3844cf996ffe1fbfece42754d Tests: Tast tests with pattern "*ssistant*" Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211049 Commit-Queue: Jeroen Dhollander <jeroendh@google.com> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#771150}
-
Megan Jablonski authored
Bug: 1077547 Change-Id: I36a18d846e75fd89237e28b777910d88a346e354 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208545 Commit-Queue: Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#771149}
-
Alison Maher authored
We were previously setting forced colors at the body element. However, we should instead set these at the root html element. Bug: 970285 Change-Id: I0719d09fb7993a02162cca24a266c6a0c8eb70fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211124Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#771148}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/10792279b603..48c10ec7c5b0 2020-05-21 treehugger-gerrit@google.com Merge "Create tables for cpu info" 2020-05-21 simonmacm@google.com Merge "Improve time-in-state UI." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I39bf781a49a85158e1cb7f52268de7a40ba1bf88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212684Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771147}
-
Patrick Monette authored
This change simply renames OnWorkerStarted() and OnBeforeWorkerTerminated() with OnWorkerCreated() and OnBeforeWorkerDestroyed() to be be more in line with the SharedWorkerService observer interface. No behavior changes. Bug: 993029 Change-Id: I53582e7d7704116166127de426ed581cf1dd4b4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200077 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#771146}
-
wutao authored
Bug: b/157099464 Test: pass current tests. Change-Id: Ie364f743da23dc73b136c77416a630db3ba6e840 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209891Reviewed-by:
-
Adrienne Walker authored
Special storage policy is a dynamic, complicated, browser-only data structure that IndexedDB needs to query on shutdown to determine whether or not to delete particular session-only directories (or not delete protected directories). Because shutdown is time-sensitive, this chooses to push updates to policies based on active origins (i.e. origins that IDBFactories have been created for). This is the IndexedDB equivalent of this local storage change: https://chromium-review.googlesource.com/c/chromium/src/+/1945940 Bug: 1015214 Change-Id: I18f65a6416be508b298e8046d4d6c20c2e56b1f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203146Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#771144}
-
Nate Fischer authored
No change to logic. This adds logs to capture the duration of the user's session with each tool. This captures each tool in a different histogram, measuring from onResume until onPause (so we intentionally don't include time when the app is in the background). Fixed: 1084177 Test: Add a log statement and verify it fires as expected Change-Id: I9933a97c5c99d123440ed4e46b94bc056964ada3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211146Reviewed-by:
Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#771143}
-
Travis Skare authored
Change-Id: I8353bf9af8aaf858d882af03608be6fe30532a1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211098Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Travis Skare <skare@chromium.org> Cr-Commit-Position: refs/heads/master@{#771142}
-
Rouslan Solomakhin authored
Before this patch, the logic for notifying the payment app of updated pricing on desktop was in the desktop specific controller, which prevented sharing this logic across platforms and between different types of apps. This patch moves the PaymentHandlerHost.UpdateWith() and PaymentHandlerHost.OnPaymentDetailsNotUpdated() calls from the desktop PaymentRequest controller to the ServiceWorkerPaymentApp. The PaymentApp interface moves to //components/payments/content to enable depending on mojom::PaymentDetails. After this patch, it would be easier to make the C++ ServiceWorkerPaymentApp cross-platform. Design: https://bit.ly/cross-platform-pay-app-factory Bug: 1083242 Change-Id: Ib02cc981eb8ad955e33e593deb4c57cdebe93962 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208094 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#771141}
-
Nate Chapin authored
Bug: 1083485 Test: fast/frames/document-addressSpace-in-detached-document.html Change-Id: I6bc8a617ce4c3cd8c6736c13fb029c2826a048ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210498 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#771140}
-
Sujie Zhu authored
Rearrange credit card edit dialog when nickname management is enabled. Add the UI string, expose the flag via loadTimeData, and use hidden and dom-if to achieve the fields reorder. Before: cardholder name (Autofocused) card number expiration month/year After: card number (Autofocused) expiration month/year cardholder name card nickname Added interactive ui tests for credit card edit dialog to test fields, focus and input values. Local build test video (googlers only): https://drive.google.com/file/d/12yQecsJWEA0YtA2_ITSKDKVGcOHK20YB/view?usp=sharing Also add nickname field to CreditCardEntry. The follow-up CL is to update autofill_private api to populate nickname from native credit_card and to save nickname from settings page input. Bug: 1082013 Change-Id: I45c1a7a0c1c6dd43a885e1f5b77e722cf2ba89c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208028 Commit-Queue: Sujie Zhu <sujiezhu@google.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Siyu An <siyua@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#771139}
-
Trent Begin authored
When the prohibited technologies property is modified, update the internal vector inside of ShillPropertyManager. Bug: chromium:1081488 Change-Id: I56244113f0f645a7e79ba7c0074423018fb7ec94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197136 Commit-Queue: Trent Begin <tbegin@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#771138}
-
Mike Wittman authored
This reverts commit db2cb995. Reason for revert: caused 30ms startup performance regression on Windows Original change's description: > Roll ICU to 67.1 f2223961 > > ICU 67.1 release notes: http://site.icu-project.org/download/67 > ICU 66.1 release notes: http://site.icu-project.org/download/66 > CLDR 37: release notes: http://blog.unicode.org/2020/04/unicode-locale-data-v37-released_23.html > > 1. Update to 67-1 > Diary https://docs.google.com/document/d/1ZDtSPa3ZkzBIJmqrDVmGmyrTihjx8Me4fKQoQcBj02E/edit# > > Size changes: > 65-1 . 67-1 > 7786368 7778704 android/icudtl.dat > 6412768 6400752 android_small/icudtl.dat > 1418320 1430976 android_small/icudtl_extra.dat > 5060880 5048912 cast/icudtl.dat > 10481632 10470736 chromeos/icudtl.dat > 10506736 10498032 common/icudtb.dat > 10506736 10498032 common/icudtl.dat > 900576 . 898416 flutter/icudtl.dat > 6375984 6363968 ios/icudtl.dat > > > Bug: 1064326, 827538 > Change-Id: I169e1f99514b36cafd54a6bc8a9914ccf222d008 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155530 > Reviewed-by: Koji Ishii <kojii@chromium.org> > Commit-Queue: Frank Tang <ftang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#764138} TBR=machenbach@chromium.org,kojii@chromium.org,jshin@chromium.org,ftang@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1064326, 827538, 1080367 Change-Id: I98ebe6e01631b10ecc1955ac9d3bc53be11e23c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209232 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#771137}
-
Regan Hsu authored
This CL resolves 2 a11y issues related to jumping between subpages via the new settings search: (1) Currently, when the BT subpage is navigated to while ChromeVox is enabled, "Bluetooth enable Toggle Button Pressed..." may sometimes be verbalized before the back button, even though the back button is the focused element and the toggle is not. (2) When the user navigates away from the BT subpage to another different subpage (e.g Languages subpage), ChromeVox almost always announces "Bluetooth enable Toggle Button Pressed..." as the first item upon arrival to the new subpage. This is because the CL uses aria-live and aria-relevant to keep ChromeVox from announcing the transient 'Disabled' state, which produces unwanted side effects in the new user journey of the new setting search. This CL therefore removes the aria-live and aria-relevant, and uses a different method of hiding the transient 'Disabled' state. See crbug/1007378 for more details. This is achieved by disabling pointer events on the element registering bluetooth on/off clicks, instead of disabling the toggle itself. That way, the toggle cannot change as it's controller has been disabled. Bug: 1071284 Change-Id: Ie029f64315b3f269c0699539a3f54ab04b38c683 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209893 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#771136}
-
Gayane Petrosyan authored
Moving out QR code image from textview, as it doesn't scale properly. Also add border as background. Screenshot: https://screenshot.googleplex.com/BQT41RTwBYA.png Bug: 1085435 Change-Id: I0aaa994caf9879dbe3103aea94c0eda5c67b40b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211909Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#771135}
-
Miguel Casas authored
This CL cleans up the code in said class and applies Chromium style. vp9_reference_frame_vector.h file: - Removes a a prescriptive class comment, instead uses a descriptive one. - Removes closed TODO from class documentation. vp9_reference_frame_vector.cc file: - Uses =default for destructor instead of {} - Uses a std::bitset<> instead of bit shifting and testing, which is error prone and more verbose. - Uses std::fill() instead of an explicit for loop. Comments are supposed to be in descriptive style ("uses") and not imperative ("use"): > These comments should open with descriptive verbs in the indicative mood ("Opens the file") rather than verbs in the imperative ("Open the file"). https://google.github.io/styleguide/cppguide.html#Function_Comments Also fixed orthographic and grammar mistakes where applicable. Change-Id: Ie78e2fbad5f3317e2c291127ac678360ce96d625 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207749 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#771134}
-
danakj authored
The TestRunnerBindings::TooltipText() method was changed to use the main frame instead of the bound frame, to avoid a crash, but that would give an incorrect result in an iframe and crash in an OOP iframe. We move it back to using the bound frame, but acknowledge new understanding given to us by the blessed clusterfuzz bots. In the test it binds an iframe's window, and thus its window.testRunner, objects to a variable in the parent frame, and then detaches the child. This means the TestRunnerBindings is kept alive, but the RenderFrame its attached to goes away. To handle this case, we introduce a RenderFrameObserver for the TestRunnerBindings. When the RenderFrame is destroyed, the TestRunnerBindings sets |invalid_|, invalidates its weak pointers, and stops doing anything ever again. It should not use any of its state from that point forward as it is a detached zombie of an object. With this change, the WeakPtr to TestRunner is now understood, but not needed as it is redundant with |invalid_|, so we remove that. R=avi@chromium.org Bug: 1084717, 866140, 1069111 Change-Id: I6038fd83162d099f220dab632e051fb08ccd8af7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210670 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#771133}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: cr-fuchsia+bot@chromium.org Change-Id: I5d573839b6ca766ef1785188e5f3ed20b2e56381 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212687Reviewed-by:
-
Mei Liang authored
To support closing and grouping suggestion, TabSuggestionMessageService needs to use all TabSuggestions from the TabSuggestionObserver#onNewSuggestion, and sends all those TabSuggestions to its MessageObservers. Change-Id: Ia7a17413f4079879d1425c2e5926a5b21a6a1ded Bug: 1076538 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197958 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#771131}
-
Joe DeBlasio authored
This CL just kills 4 periods to be consistent with Chrome UX guidelines. That's it. Fixed: 1085450 Change-Id: I3a6c8c4473297ba3415aa8efcecd8a53835b4f2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212463 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#771130}
-
Tom Anderson authored
BUG=1048386 R=msisov Change-Id: I75d36d80af5b3593e5425f0b97bcd176e3036f00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211061Reviewed-by:
Maksim Sisov <msisov@igalia.com> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#771129}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1590047700-a706b1a99569faae4b31ea10afb5af7a8db8e3e7.profdata to chrome-win32-master-1590076755-e9de4b57569c4058e940202038caaf51f7563125.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: If411da4182c3c841188c9dcf4b12619d82ac3f19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212642Reviewed-by:
-
Ramin Halavati authored
Profile API is being updated (issue 1033903) and the usage of GetOffTheRecordProfile and HasOffTheRecordProfile without argument is getting deprecated. Use cases of this call that ONLY refer to incognito or guest mode can use [Get/Has]PrimaryOTRProfile() instead. SafeBrowsing tests are updated to use the new API, and in a few simple cases a new test is added to check for non-primary OTR profiles. Bug: 1060940 Change-Id: Ibe82693e6856dd525d26b435c8b669e624cf6d21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210582Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Auto-Submit: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#771127}
-
Thomas Guilbert authored
The VideoDecoder and VideoTrackReader share the same callback definition to send VideoFrames back to JS. This CL updates the name of the callback to a more generic name usable by both. Bug: 1080834 Change-Id: I2b5cd5d2ed775abd2adfff582320617fd954b85b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203217 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#771126}
-
Eric Seckler authored
Otherwise we can end up hitting DCHECKs in e.g. BeginImplFrameDeadlineModeToString(). Change-Id: Ibaac3356ba94664ce9c08d378ab78631e8aaa890 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2196582Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#771125}
-
Gabriel Charette authored
Prior to this CL: all death tests had been failing on win-asan (dcheck_is_configurable = true) for a while with error "Result: failed to die.". LOG_DCHECK defaults to LOG_INFO severity in these builds, with severity upgraded to LOG_FATAL by FeatureList::SetInstance() if --gtest_internal_run_death_test is in the process' command-line. However, SetInstance() is only invoked on a per-test basis via a TestEventListener, while TestEventListeners are deliberately skipped in death-test sub-processes. This results in death-test sub-processes running with non-FATAL DCHECKs, causing death-test expectations to fail. Full diagnosis @ crbug.com/1057995#c11 This CL changes the production default (LOG_INFO) to a test default (LOG_FATAL) in --gtest_internal_run_death_test processes under DCHECK_IS_CONFIGURABLE. R=chromium-metrics-reviews@google.com, wez@chromium.org Bug: 1057995 Change-Id: Ia7d3f92d72dddc74e17cc9416c0b586dae1fc221 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208298 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#771124}
-
Alexei Svitkine authored
This information isn't being used and so it's better not to log it. Bug: 1072801 Change-Id: Ia92c43d313f33b6d88e79cc1b3f5b019ec45d831 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210937Reviewed-by:
-
