GitLab

Review URL: https://codereview.chromium.org/685983007

Cr-Commit-Position: refs/heads/master@{#302676}

This is a companion change to https://codereview.chromium.org/696353005/.

BUG=412374,412376
R=smut@google.com, smut@chromium.org

Review URL: https://codereview.chromium.org/693183003

Cr-Commit-Position: refs/heads/master@{#302675}

This change prevents overwriting a foreign session SessionTab  with a data from another node if the SessionTab we already have has a newer timestamp. This ensures that if there are multiple tabs with the same ID, the tab that we end up associating with a window is the most recent one.

BUG=423501

Review URL: https://codereview.chromium.org/699033002

Cr-Commit-Position: refs/heads/master@{#302674}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/697413002

Cr-Commit-Position: refs/heads/master@{#302673}

Adds a histogram to measure the difference between the bandwidth estimate at 2 seconds and 20 seconds into a WebRTC call.

BUG=425925
R=asvitkine@chromium.org

Review URL: https://codereview.chromium.org/682813004

Cr-Commit-Position: refs/heads/master@{#302672}

BUG=426640

Review URL: https://codereview.chromium.org/685963004

Cr-Commit-Position: refs/heads/master@{#302671}

This CL adds a new extension API that can be used to implement VPN clients by third party.

BUG=407541

Review URL: https://codereview.chromium.org/671163002

Cr-Commit-Position: refs/heads/master@{#302670}

Revert of Add logs to debug a flakiness on GPU Mac bots. (patchset #2 id:20001 of https://codereview.chromium.org/684423005/)

Reason for revert:
It was temporary and no longer needed.

Original issue's description:
> Add logs to debug a flakiness on GPU Mac bots.
>
> This is temporary and will be removed after we pin down the issue.
>
> BUG=424024
> TEST=
> R=kbr@chromium.org
> TBR=dgozman@chromium.org
> NOTRY=true
>
> Committed: https://crrev.com/16aa242c3456dc68cd91ef2c683158799c8441b0
> Cr-Commit-Position: refs/heads/master@{#302371}

TBR=dgozman@chromium.org,kbr@chromium.org,pfeldman@chromium.org,yurys@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=424024

Review URL: https://codereview.chromium.org/698353002

Cr-Commit-Position: refs/heads/master@{#302669}

Revert of Adding more logs for the browser.GetSystemInfo() random crash. (patchset #1 id:1 of https://codereview.chromium.org/699043002/)

Reason for revert:
This CL was temporary and is no longer needed

Original issue's description:
> Adding more logs for the browser.GetSystemInfo() random crash.
>
> This is temporary - will be removed once we pin down the crash.
>
> BUG=424024
> TEST=
> TBR=kbr@chromium.org
> NOTRY=true
>
> Committed: https://crrev.com/c3b22dcdcb90725e9c3d9ffe05847a56e8fd1e10
> Cr-Commit-Position: refs/heads/master@{#302512}

TBR=kbr@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=424024

Review URL: https://codereview.chromium.org/703633004

Cr-Commit-Position: refs/heads/master@{#302668}

Revert of Adding more logging to see why DevToolsHttpHandlerImpl::BrowserTarget is flaky. (patchset #2 id:20001 of https://codereview.chromium.org/702503002/)

Reason for revert:
It was temporary and no longer needed.

Original issue's description:
> Adding more logging to see why DevToolsHttpHandlerImpl::BrowserTarget is flaky.
>
> BUG=424024
> TEST=
> TBR=kbr@chromium.org
>
> Committed: https://crrev.com/d3ac15e57aade01f1524f554e00c6113e8e9b364
> Cr-Commit-Position: refs/heads/master@{#302453}

TBR=kbr@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=424024

Review URL: https://codereview.chromium.org/702773002

Cr-Commit-Position: refs/heads/master@{#302667}

Freon supports a user mode console that is drm based.  So,
to transition between the user console and chrome, we will
initiate dbus messages to effect the transition.  This change
is the chromeos/dbus part.

BUG=406031
TEST=test with user mode console

Review URL: https://codereview.chromium.org/697493002

Cr-Commit-Position: refs/heads/master@{#302666}

Previous instrumentations showed that SSLClientSocketNSS::Core::DoHandshake alone is responsible for 14.4 janks per hour in IO thread. I need to instrument the code inside it to find out which part causes jank.

This is a mechanical change that adds instrumentation required to locate the source of jankiness (i.e. a long-running fragment of code executed as a part of the task that causes jank) in the code. See the bug for details on what kind of jank we are after.
A number of similar CLs were landed, and none of them caused issues. They've helped to find and fix janky code. The code of the instrumentation is highly optimized and is not expected to affect performance. The code simply creates a diagnostic task which is identical to ones created by PostTask or IPC message handlers.

BUG=424386

Review URL: https://codereview.chromium.org/687843002

Cr-Commit-Position: refs/heads/master@{#302665}

On iOS, we can't link directly to the date and time settings, so we hide the primary button and add an extra description to the main paragraph instructing them how to do so.
For all platforms, we completely hide the 'Advanced' button on the SSL clock interstitial. (It was replaced with 'Reload' in previous iterations.)

Hide Reload button for all clock errors.

BUG=414843

Review URL: https://codereview.chromium.org/693093003

Cr-Commit-Position: refs/heads/master@{#302664}

The dependency is necessary to avoid multiple definitions of memory
allocation functions in static_library Debug builds on Windows.

BUG=429498
NOTRY=true

Review URL: https://codereview.chromium.org/695913003

Cr-Commit-Position: refs/heads/master@{#302663}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/7a10fb6..a30b2ee

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=egdaniel@google.com

Review URL: https://codereview.chromium.org/690283003

Cr-Commit-Position: refs/heads/master@{#302662}

Webview attributes are now only stored in one location (in the webview node), so that all the code needed to sync up the copies could be removed (and was).

Also reworked the behavior of the |allowtransparency| and |autosize| to be both consistent with each other and more intuitive in general (they are both treated like booleans now). I updated the tests to reflect this new behavior.

Review URL: https://codereview.chromium.org/698973003

Cr-Commit-Position: refs/heads/master@{#302661}

Revert of Remote assistance on Chrome OS Part V - It2MeHost Continue Window (patchset #5 id:120001 of https://codereview.chromium.org/690183002/)

Reason for revert:
Build failure on
http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=Linux%20ChromiumOS%20Builder%20%28dbg%29&number=54095

Original issue's description:
> Remote assistance on Chrome OS Part V - It2MeHost Continue Window
>
> This CL implements the ContinueWindow on ChromeOS, which will
> be shown to the user for confirmation after 10 minutes into a Remote
> Assistance session.
>
> To implement the ContinueWindow, this CL introduces a new class
> MessageBox, which is a re-usable component built on top of the
> widget framework.
>
> BUG=424908
>
> Committed: https://crrev.com/6410d7ad4937a4a86e9ad28b9ecf99f961305b2d
> Cr-Commit-Position: refs/heads/master@{#302657}

TBR=wez@chromium.org,dcaiafa@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=424908

Review URL: https://codereview.chromium.org/689093004

Cr-Commit-Position: refs/heads/master@{#302660}

BUG=421864

Review URL: https://codereview.chromium.org/642943002

Cr-Commit-Position: refs/heads/master@{#302659}

BUG=429652

Review URL: https://codereview.chromium.org/700463005

Cr-Commit-Position: refs/heads/master@{#302658}

This CL implements the ContinueWindow on ChromeOS, which will
be shown to the user for confirmation after 10 minutes into a Remote
Assistance session.

To implement the ContinueWindow, this CL introduces a new class
MessageBox, which is a re-usable component built on top of the
widget framework.

BUG=424908

Review URL: https://codereview.chromium.org/690183002

Cr-Commit-Position: refs/heads/master@{#302657}

Instead of calling CopresenceSocket::Send with the size of the packet we
created, we were calling it with the size of the original data. This CL fixes
that bug and adds more logging when we're sending data.

R=xiyuan@chromium.org
BUG=None.

Review URL: https://codereview.chromium.org/698153005

Cr-Commit-Position: refs/heads/master@{#302656}

To help Domain Reliability collectors know whether the client's IP
address is actually the address from which they experienced network
issues, label beacons with '"network_changed": true' if the client's
network connection changes between logging and reporting the beacon.

BUG=

Review URL: https://codereview.chromium.org/691053003

Cr-Commit-Position: refs/heads/master@{#302655}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=gbillock@chromium.org

Review URL: https://codereview.chromium.org/680993004

Cr-Commit-Position: refs/heads/master@{#302654}

Reduces flakiness; improves test readability. Also introduces a
callback on SimpleIndexFile to signal completion of writing the index,
useful for deflaking cache serialization.

R=jkarlin@chromium.org
BUG=255775,429672

Review URL: https://codereview.chromium.org/699743002

Cr-Commit-Position: refs/heads/master@{#302653}

Review URL: https://codereview.chromium.org/699873005

Cr-Commit-Position: refs/heads/master@{#302652}

BUG=82385

Review URL: https://codereview.chromium.org/691093003

Cr-Commit-Position: refs/heads/master@{#302651}

Previous instrumentations showed that "DoCallback(rv);" call inside HttpNetworkTransaction::OnIOComplete
alone is responsible for 18.2 janks per hour in IO thread. I need to instrument
the code inside it to find out which part causes jank.

This is a mechanical change that adds instrumentation required to locate the
source of jankiness (i.e. a long-running fragment of code executed as a part of
the task that causes jank) in the code. See the bug for details on what kind of
jank we are after.
A number of similar CLs were landed, and none of them caused issues. They've
helped to find and fix janky code. The code of the instrumentation is highly
optimized and is not expected to affect performance. The code simply creates a
diagnostic task which is identical to ones created by PostTask or IPC message
handlers. The task gets created only in developer build and in Canary channel.

BUG=424359

Review URL: https://codereview.chromium.org/670993003

Cr-Commit-Position: refs/heads/master@{#302650}

Previous instrumentations showed that AccountIdFetcher::Start
alone is responsible for 20.5 janks per hour in UI thread, with 203ms average
run time. I need to instrument
the code inside it to find out which part causes jank.

This is a mechanical change that adds instrumentation required to locate the
source of jankiness (i.e. a long-running fragment of code executed as a part of
the task that causes jank) in the code. See the bug for details on what kind of
jank we are after.
A number of similar CLs were landed, and none of them caused issues. They've
helped to find and fix janky code. The code of the instrumentation is highly
optimized and is not expected to affect performance. The code simply creates a
diagnostic task which is identical to ones created by PostTask or IPC message
handlers. The task gets created only in developer build and in Canary channel.

BUG=422460

Review URL: https://codereview.chromium.org/685033006

Cr-Commit-Position: refs/heads/master@{#302649}

Introduces the metadata required to link together the desktop tree and a views::WebView. Additionally, implements the js side logic to resolve these links.

A views::WebView now gets assigned an AXRole of webView and its immediate child resolves to the rootWebArea it hosts. This resolution is done dynamically at runtime using the underlying AX tree id which itself is mapped using AXTreeIDRegistry back in the browser. If the hosting webView has yet to load its child rootWebArea, enableFrame will be called to and a callback waiting for the subroot's data; this auto load occurs as soon as a webView is seen during a tree update and results in a childrenChanged event once its child rootWebArea is available. When a caller asks for the parent of a rootWebArea, a dynamic lookup is also performed to retrieve a hosting webView, if any.

Review URL: https://codereview.chromium.org/667713006

Cr-Commit-Position: refs/heads/master@{#302648}

BUG=none

Review URL: https://codereview.chromium.org/685793002

Cr-Commit-Position: refs/heads/master@{#302647}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=jochen@chromium.org

Review URL: https://codereview.chromium.org/678093002

Cr-Commit-Position: refs/heads/master@{#302646}

BUG=424387

Review URL: https://codereview.chromium.org/692723002

Cr-Commit-Position: refs/heads/master@{#302645}

BUG=427584

Review URL: https://codereview.chromium.org/693893004

Cr-Commit-Position: refs/heads/master@{#302644}

BUG=415774

Review URL: https://codereview.chromium.org/699963002

Cr-Commit-Position: refs/heads/master@{#302643}

Review URL: https://codereview.chromium.org/699183002

Cr-Commit-Position: refs/heads/master@{#302642}

This adds several performance tests for CSS Animations
initiated in various ways.

BUG=421733

Review URL: https://codereview.chromium.org/665833002

Cr-Commit-Position: refs/heads/master@{#302641}

When decoder is draining, the current access unit is pointing to the config change AU.
If something interrupts the draining, a surface change for example,
CreateMediaCodecBridge() will fail because the current AU is not an i-frame.
This will cause an unnecessary browser seek.
To avoid this, we should call OnDecoderDrained() first to let video decoder know that config change AU is consumed.

The issue is captured by the DecoderDrainInterruptedBySurfaceChange test on nexus 9.
And this change reenables that test, so no additional test is added.

BUG=429889

Review URL: https://codereview.chromium.org/699763002

Cr-Commit-Position: refs/heads/master@{#302640}

This CL changes the account reconcilor to use the new cookie store
API that allows clients to adds callback for cookie changed events.
It adds logic to the chrome sign-in client to register for cookie
changed events on the IO thread and call the cookie changed callback
on the main thread.

Note that in order to access the cookie store, we need to use the
URL context which can only be used on the IO thread. Subscribing for
cookie change events requires thus a thread jump to the IO thread on
all platforms.

BUG=NONE

Review URL: https://codereview.chromium.org/695553002

Cr-Commit-Position: refs/heads/master@{#302639}

Review URL: https://codereview.chromium.org/698293002

Cr-Commit-Position: refs/heads/master@{#302638}

This patch makes more explicit the set of dependencies
allowed from //extensions onto //ui.

//extensions was allowing dependencies on all of //ui
by default. This is unfortunate for people who want to
introduce new code into //extensions only to be shot
down because they depend on pieces of ui that aren't
allowed.

BUG=None

Review URL: https://codereview.chromium.org/702513002

Cr-Commit-Position: refs/heads/master@{#302637}