- 30 Oct, 2019 40 commits
-
-
Alexander Timin authored
Remove kInternalIPC task type. - If it's used to bind associated interface, use kInternalNavigationAssociated instead. - If it's used to bind non-associated interface, use the task source mentioned in the spec or kInternalDefault if it's not speced. R=haraken@chromium.org Change-Id: I2ddb25f5b65874c32ba3f54a41dc4494927043cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887614Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#710765}
-
Hajime Hoshi authored
This CL adds a new histogram BackForwardCache.HistoryNavigationOutcome. BLocklistedFeature to record blocklisted features when a page cannot be put into the cache due to them. Bug: 1004676 Change-Id: I96f9789cdeb7f176c802ede764124cd5ac177880 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871493 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
-
Antonio Gomes authored
This CL implements phase 8 on the design document [1]. [1] https://docs.google.com/document/d/1AJKVA5U4nDkyDB9p4ROrggWXadCxyy-grKaE9KS5vOU/ It moves from content/renderer/media/webrtc to Blink the following files: - rtc_peer_connection_handler.cc | h | test - webrtc_set_description_observer.cc | h | test - peer_connection_tracker.cc | h | test - media_stream_track_metrics.cc | h | test The following unit tests are also moved to Blink, although not accompained of their respective source and header files (already in Blink). - peer_connection_dependency_factory_unittest.cc - rtc_peer_connection_test.cc It is also worth it to mention that testing_platform_support_with_web_rtc.cc and .h (both in renderer/platform/testing/) got adapted now that the blink::Platform method they relied on got removed: instead of overriding Platform::CreateRTCPeerConnectionHandler(), RTCPeerConnection gets a static factory setter method that tests can use to override how RTCPeerConnectionHandler is created. The method is named SetRtcPeerConnectionFactoryForTesting() and is used in scheduler_affecting_features_test.cc and rtc_peer_connection_test.cc (twice). For completeness, this CL has a series of predecessor CLs, being the following ones below the most relevant: - crrev.com/c/1845802 - Lazy initialize PeerConnectionTracker - crrev.com/c/1831197 - Migrate PeerConnectionTracker and PeerConnectionTrackerHost to Mojo Note that the CL opens the door for various follow up, including: - Migration of base::Bind to WTF::Bind. - Migration from std::string to WTF::String. - Migration for stl structs (eg vector, map) by their WTF's counterparts. - Reduce the API footprint - Clean up if content/tests/BUILD WebRTC dependencies. - ... Bug: 787254 Change-Id: I49d6f84c747eb944ec55665722fc4046d14f66cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842414Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
-
arthursonzogni authored
The patch: https://chromium-review.googlesource.com/c/chromium/src/+/1854901 was reenabling the tests: - IndexedDBExecutionContextConnectionTrackerBrowserTest.ObserverDedicatedWorker - IndexedDBExecutionContextConnectionTrackerBrowserTest.ObserverNavigate - IndexedDBExecutionContextConnectionTrackerBrowserTest.ObserverServiceWorker - IndexedDBExecutionContextConnectionTrackerBrowserTest.ObserverSingleConnection - IndexedDBExecutionContextConnectionTrackerBrowserTest.ObserverTwoLocks - LockManagerBrowserTest.ObserverDedicatedWorker - LockManagerBrowserTest.ObserverNavigate - LockManagerBrowserTest.ObserverServiceWorker - LockManagerBrowserTest.ObserverSingleLock - LockManagerBrowserTest.ObserverStealLock - LockManagerBrowserTest.ObserverTwoLocks on Android KitKat. They are still failing => disabling them again. https://ci.chromium.org/p/chromium/builders/ci/KitKat%20Phone%20Tester%20%28dbg%29/18113 TBR=fdoray@chromium.org CC=ahemery@chromium.org,fergal@chromium.org,altimin@chromium.org R=arthursonzogni@chromium.org Bug: 1019659,1011765,1014015 Change-Id: I5be59757f1f37d58150700c331c22cbd8343187f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890071Reviewed-by:
-
Maks Orlovich authored
We are going to be asking cookies accessible in 3rd party contexts to be marked as samesite=none and secure, so make tests that want such cookies (if only to test them being blocked by preferences) set those attributes and use HTTPS. Bug: 1006816 Change-Id: I3c4b58de2b75736b85ce87b694c57fd8db04cbe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873154Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#710761}
-
Roman Sorokin authored
Supposed to be fixed TBR=antrim@chromium.org Bug: 1003772 Change-Id: If9f00577aced44ddf0de36c89e5961a3d152a300 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890037Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#710760}
-
Marc Treib authored
The ARTICLES ModelType was never launched and all the code has been removed. Bug: 965503 Change-Id: Ifb1841d875ff6ee5f6d8d0a001efb6e69c83c281 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872587 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#710759}
-
Rune Lillesveen authored
WontFix along with the other tests for the unimplemented feature. Bug: 246571 Change-Id: Ia3da325693993eba36c1a5685c547631f7f628e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889971Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#710758}
-
Marc Treib authored
InvalidatorRegistrarWithMemory is the main "real" implementation of a registrar, so it's important to run any tests on this one. Previously, the tests were only instantiated for DeprecatedInvalidatorRegistrar (which is deprecated and will hopefull be removed soon) and for InvalidatorRegistrar (which is a base class of InvalidatorRegistrarWithMemory that is never used directly). Bug: none Change-Id: I591442c0cff1b10d8e17cf6d7f63f3d470154545 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890034 Auto-Submit: Marc Treib <treib@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#710757}
-
Jeevan Shikaram authored
This CL checks that the apps have been loaded before checking if an app exists in the apps list. It also handles a race condition where the dom-switch element's onRouteChanged is called before the dom-switch has a child loaded. Bug: 1014919 Change-Id: Id0712b74b006580bfbed2c701a3e61320094a036 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889274 Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#710756}
-
Yi Gu authored
virtual/threaded/external/wpt/animation-worklet/stateful-animator.https.html is still flaky on Mac [1]. [1] https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=virtual/threaded/external/wpt/animation-worklet/stateful-animator.https.html TBR=yigu@chromium.org NOTRY=true Bug: 1014810, 1014812 Change-Id: Ib6811c0f14fbfcecff0d5d151ae446afbda5e98d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890615Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#710755}
-
Yi Su authored
Remove the extra space at bottom of NTP article cells if no image is displayed. Screenshots: normal-font-top: https://drive.google.com/open?id=11r17WFEdLeN2nr5lXAbidq0d6Pfa-2g4 normal-font-bottom: https://drive.google.com/open?id=1Ss-R_HLKEN5I8HpP4vdWDl3FeCm47CyK a11y-font-top: https://drive.google.com/open?id=1IS1_NoZKGBDEmU2jsVNWY6e6VBD4jkkr a11y-font-bottom: https://drive.google.com/open?id=1bTPAeXJPjR8qHpeP5Z_5MAaziUypbj8J Bug: 1003693 Change-Id: I3e38560a28636850b41400a5099f3f2ad320b11d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889652Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#710754}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/46994599..f752e377 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8f53cd18fbb8af769885bb3c90bf8bd358d41ad3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890230Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710753}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/470b2d5144a3..4778f6ce7a0b git log 470b2d5144a3..4778f6ce7a0b --date=short --no-merges --format='%ad %ae %s' 2019-10-30 titovartem@webrtc.org Revert "Refactoring of the noise suppressor and adding true multichannel support" 2019-10-30 sakal@webrtc.org Fix invalid @Nullable handling in TextureBufferImpl. 2019-10-30 srte@webrtc.org Cleanup of feedback observer interface Created with: gclient setdep -r src/third_party/webrtc@4778f6ce7a0b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:b/143344262,chromium:None Change-Id: Ic24032eacfc8b8c4765051190e7bcde50566ca74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890212Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710752}
-
Donn Denman authored
Changes the length of the caption to depend on whether we're showing the new or old layout. This doesn't automatically adjust the length as the panel opens but the caption is either fixed length or scrolls away when the panel is expanded, so this is not a significant problem (see bug 1016973). BUG=1019007 Change-Id: Iccb13eac1ca297d87c2a64cf682ac87cc341d535 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887749 Auto-Submit: Donn Denman <donnd@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#710751}
-
Mark Cogan authored
The hardware keyboard utils aren't chrome- or EG-specific, so this CL moves them to the more general //ios/testing directory. Change-Id: Idae0307e618117e987304fc6a89097735b41f937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889875 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#710750}
-
Henrique Ferreiro authored
blink::WebFloatPoint3D is defined in public/platform but it has no users outside of //third_party/blink. Replace it with blink::FloatPoint3D. Bug: 919392 Change-Id: Ie637185f1aa81c7793f724b7afe94dce1edf8762 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886812Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#710749}
-
ckitagawa authored
This is a reland of ba5c7d6f Reverted as PaintPreviewTest.TestInvalidProto broke on the Win7 Test dbg and Linux Test dbg waterfall bots. Fix: modify the test to avoid serializing an invalid proto and instead just serialize a string. The point of the test was to see that the invalid proto wouldn't deserialize and that state would be handled properly. Using TBR as lots of reviewers (some OOO) and there is minimal change from original CL aside from one test. Revert: 29b91f26 Original change's description: > [Paint Preview] Compositing Service > > Adds a paint preview compositor service for compositing collections of > SkPictures representing frames into bitmaps. This is very similar > in principle to the PDF compositor service, but produces tileable > bitmaps rather than a PDF. > > A client to this service should start the compositing collection > portion of the service in a utility process. The client can then > create and delete dedicated compositor instances for each group of > SkPictures. Realistically only one compositor will be actively > communicating at a time. However, multiple compositors can be > "warm" (data is deserialized and in memory for fast switching). > > Bug: 1011430 > Change-Id: I21cb594cd94982f8d4fc5800d9ae4d74b5d9973b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842273 > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Colin Blundell <blundell@chromium.org> > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Reviewed-by: Ian Vollick <vollick@chromium.org> > Reviewed-by: Mehran Mahmoudi <mahmoudi@chromium.org> > Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> > Cr-Commit-Position: refs/heads/master@{#709946} TBR=kenrb@chromium.org,jochen@chromium.org,blundell@chromium.org Bug: 1011430 Change-Id: Ieafd0d2e197feb8b1d1711e05dd4acc6f185655f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886986Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#710748}
-
Michael Achenbach authored
This adds a missing explicit include of jumbo.gni. It is included indirectly through V8, which blocks removing jumbo support on the V8 side: https://crrev.com/c/1890090 Bug: 994387 Change-Id: Ib5d3310d57c9bc50c11d4a4339e062dba298e5c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890311Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#710747}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/11a79e755c5e..d85805a32efe git log 11a79e755c5e..d85805a32efe --date=short --no-merges --format='%ad %ae %s' 2019-10-30 eseckler@google.com protozero: Make generated cpp enum/class order stable Created with: gclient setdep -r src/third_party/perfetto@d85805a32efe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: chromium:1017699 Change-Id: Id713a876b3355636bd267a39bc629d3dfe5a02b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889994Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a660eacc675c..6d56bdc1447a Created with: gclient setdep -r src-internal@6d56bdc1447a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I9dbaf55e6b35444edf4bf1ad569b6db9bd39b822 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889991Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710745}
-
Himanshu Jaju authored
To move the callback logic to SharingFCMSender, we would also need to move the device naming part to SharingUtils since we use GetDeviceName while sending the message using FCM. Bug: 1018274 Change-Id: I5f67d439a22015105b6202e9bba9f204034a492d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887616 Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#710744}
-
Lindsay Pasricha authored
due to crashes. Bug: 1019211 Change-Id: Idc7d059fcadd0dfa589130f8cde1ac275a1c0088 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888537 Auto-Submit: Lindsay Pasricha <lindsayw@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#710743}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: I68125a7d6f3509c7adaa8423bb1556a41145b0f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890470Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710742}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I8154a95b7ba808b1e5be4d52bd593ea1f50a0cd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889990Reviewed-by:
-
Andy Paicu authored
This reverts commit 905e57cc. Reason for revert: Still causing crashes in canary. Original change's description: > Reland "Kill quiet permission requests if a new request is made" > > This is a reland of 55a4bb68 > > The original CL caused a crash (crbug.com/1016233) > > The first patchset is the original CL, unmodified. > > https://chromium-review.googlesource.com/c/chromium/src/+/1860015 > introduced a crash because InfoBarService::RemoveInfoBar DCHECKS that > the infobar is part of the owned list of infobars. When the tab is > closed, the infobar is removed but then the PermissionPromptAndroid > object destructor attempts to remove it again. This CL ensures that > that this situation does not happen by listening for the infobar > remove event and ensuring we don't try to remove the infobar that > was already removed. > > Original change's description: > > Kill quiet permission requests if a new request is made > > > > Bug: 1014026 > > Change-Id: I5fe93b9bc7b39873900d9e15dcba66dfddd7c4ef > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860015 > > Commit-Queue: Andy Paicu <andypaicu@chromium.org> > > Reviewed-by: Balazs Engedy <engedy@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#706445} > > Bug: 1014026, 1016233 > Change-Id: Iaa857811c6617afd97af9708a51ea49ea98fe385 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871698 > Commit-Queue: Andy Paicu <andypaicu@chromium.org> > Reviewed-by: Balazs Engedy <engedy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#708160} TBR=engedy@chromium.org,andypaicu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1014026, 1016233 Change-Id: If930a94246d4805d95ca77bc5d5354f643b25d71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888385Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#710740}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/42f885238114..7e2cba6a5241 git log 42f885238114..7e2cba6a5241 --date=short --no-merges --format='%ad %ae %s' 2019-10-29 bclayton@google.com utils/vscode: Change assembly file ext to .spvasm (#2995) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@7e2cba6a5241 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,ynovikov@google.com Bug: None Change-Id: I41699d57e9c4f17699a9bc89ba7a8063731aff3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889670Reviewed-by:
-
Hirokazu Honda authored
This reverts commit ac6f2444. Reason for revert: This CL breaks HW decoder on hana. Original change's description: > media/gpu/v4l2: Check request support in queue. > > The queue's support is currently checked in the video decoder but the > queue should be responsible to check whether it does support requests or not. > This patch moves the check for the request support to the V4L2Queue > constructor. > > BUG=chromium:1009921 > TEST=ran tast with video.DecodeAccelVDVP8ResolutionSwitch on veyron_minnie-kernelnext. > TEST=ran tast with video.DecodeAccelVDH264ResolutionSwitch on veyron_minnie-kernelnext. > TEST=ran tast with video.DecodeAccelVDVP8 on veyron_minnie-kernelnext. > TEST=ran tast with video.DecodeAccelVDH264 on veyron_minnie-kernelnext. > TEST=ran tast with video.DecodeAccelVDVP8ResolutionSwitch on veyron_minnie. > TEST=ran tast with video.DecodeAccelVDH264ResolutionSwitch on veyron_minnie. > TEST=ran tast with video.DecodeAccelVDVP8 on veyron_minnie. > TEST=ran tast with video.DecodeAccelVDH264 on veyron_minnie. > > Signed-off-by: Francois Buergisser <fbuergisser@chromium.org> > Change-Id: Icdceab06d3b263d0ce68993b3ee753bd650706dd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880208 > Commit-Queue: Alexandre Courbot <acourbot@chromium.org> > Reviewed-by: Alexandre Courbot <acourbot@chromium.org> > Cr-Commit-Position: refs/heads/master@{#709376} TBR=acourbot@chromium.org,fbuergisser@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:1009921 Change-Id: Ib3cf55aa900296f882372d4cf092e947115859e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890190Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#710738}
-
Arthur Hemery authored
Modified some content_unittest expectations to work with BackForwardCache enabled. Change-Id: Ia754e152a557a13acc25182791626d45e2e7913f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880044Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#710737}
-
Kamila Hasanbega authored
Revert "Reenable PromptForXHRWithoutOnSubmit and PromptForFetchWithNewPasswordsWithoutOnSubmit tests" This reverts commit 557416cf. Reason for revert: The tests started to fail here https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/30656?blamelist=1#blamelist-tab Original change's description: > Reenable PromptForXHRWithoutOnSubmit and PromptForFetchWithNewPasswordsWithoutOnSubmit tests > > The two probable reasons for the flakiness were: > - we didn't wait until the keystrokes were processed in the renderer. See > crbug.com/955455 > - we don't wait for the password store returning some results after navigation. > > Both are fixed in the CL. Let's observe the pass rate. > > Bug: 1013743 > Change-Id: Ic328afbe2cd652119a773c28d49ff450cf0d5405 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879237 > Reviewed-by: Dominic Battré <battre@chromium.org> > Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#709464} TBR=battre@chromium.org,vasilii@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1013743 Change-Id: Iee2265f768e89fb112157645c1fadd715c35fb53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890051Reviewed-by:
Kamila Hasanbega <hkamila@chromium.org> Commit-Queue: Kamila Hasanbega <hkamila@chromium.org> Cr-Commit-Position: refs/heads/master@{#710736}
-
Kamila authored
Change-Id: Ie023a5d635de0c976033d7f510a2a0f7bb9ca72e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1018027 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890330Reviewed-by:
Kamila Hasanbega <hkamila@google.com> Reviewed-by:
-
Rohit Rao authored
https://chromium.googlesource.com/external/github.com/google/EarlGrey.git/+log/498c7945364e..ff524fb64625 $ git log 498c79453..ff524fb64 --date=short --no-merges --format='%ad %ae %s' 2019-10-23 rohitrao UIWebView deprecation. Created with: roll-dep src/ios/third_party/earl_grey/src BUG=None Change-Id: I75e3ad30e3d9ff6534fe8ebc4d1a0b17bb9670f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888101 Auto-Submit: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#710734}
-
Marc Treib authored
Updating comments, removing some unused members and some typedefs that are only used a single time. Bug: none Change-Id: Icc7f37f9f0d8d9d7f707a5db6955726d0668b41e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889653Reviewed-by:
-
Yang Guo authored
https://chromium.googlesource.com/devtools/devtools-frontend/+log/a2ca5d5c44..df0ca90392 TBR=aerotwist@chromium.org Change-Id: I3db2bf865e867523e5c883a9eb9129e70dd5f45b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888671Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Paul Lewis <aerotwist@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#710732}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/87a7b82520b8..470b2d5144a3 git log 87a7b82520b8..470b2d5144a3 --date=short --no-merges --format='%ad %ae %s' 2019-10-30 mbonadei@webrtc.org Stop relying on GN's sources_assignment_filter. 2019-10-29 peah@webrtc.org AEC3: Adding a configurable render signal gain Created with: gclient setdep -r src/third_party/webrtc@470b2d5144a3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: Id42251ea9dda7b6ea3f6bc563aa5b38634b842c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889810Reviewed-by:
-
Mikel Astiz authored
We've wondered why some tests failed flakily instead of failing deterministically due to blocking operations not being allowed in the UI thread. One explanation is the FakeServer's direct use of base::ThreadRestrictions::SetIOAllowed(), which doesn't revert the allowing of IO. This has the side effect that it would hide any misuse of blocking IO operations in sync integration tests. This patch fixes one remaining test surfaced as part of this work. Bug: 1004312,1009372 Change-Id: Id8e57485860873e78093c18069935a646514a469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883630 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#710730}
-
Elad Alon authored
Bug: None Change-Id: I8bed811ba52e7ecf0dd772c0222bc57d8b99f46d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886821Reviewed-by:
-
Henrique Ferreiro authored
Bug: 919392 Change-Id: I3a90a95ebb307d812ac7cd80348853d061b74302 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886681Reviewed-by:
-
Bruce Dawson authored
Using the system clipboard for tests causes race conditions (it's a shared resource), means that tests pollute global state, and causes tests to fail on Windows if the workstation is locked (opening the clipboard fails in that case). So, using the TestClipboard is important. This was tested by running this command: unit_tests --gtest_filter=SharedClipboardMessageHandlerTest* Before the clipboard contents were perturbed. After, they were not. Bug: 996325 Change-Id: Idec21ce709463bcd9c70d7d25f1a6bc851170ba1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881988 Auto-Submit: Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#710727}
-
Javier Ernesto Flores Robles authored
This is a reland of 959cddb1 The failing test has been fixed. Original change's description: > [iOS][MF][EG2] Migrate keyboard observer test > > Remove deprecate test that would require new code to be migrated. > Update and enable keyboard disappear test. > Create app interface to interact with a shared instance of the observer > in the app. > Remove OCMock usage in the test. > > TBR=eugenebut@chromium.org > > Change-Id: Iaa5384f241e63b95ee516d4666b2e2adf65b7da6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881566 > Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> > Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org> > Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#709939} TBR=eugenebut@chromium.org Bug: 1018715 Change-Id: I64b81585275d799ab3bf7d325af5ef5d6000f6f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886331 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#710726}
-
