GitLab

Bug: None
Change-Id: I347e159bf8913e36239019f227bacb6389ed3122
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594182Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838198}

Bug: 1157567
Change-Id: Icebc4367286fcb7372b9c6e7c8909b84d9dc9917
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591487
Commit-Queue: Sven Zheng <svenzheng@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/master@{#838197}

Re-land #2 includes update to licenses.py and removes stale files.

Re-land includes missing headers directory.

This replaces several grouped dependencies with one meta-repo.
The meta-repo will allow us to group multiple inter-dependent
deps rolls into one single roll. This solves the problem of
separate rollers breaking because of the inter-dependencies.
It also allows ANGLE and Chrome to share common bits like the
README and .gitignore files.

Bug: angleproject:5390
Bug: 1153258
Change-Id: Ie425e232096a25711dd90e84a6d91bf3324903ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595457
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Auto-Submit: Jamie Madill <jmadill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838196}

Adds logic to the settings view controller to replace the sign-in item
with an info button item that grays out the sign-in option. The info
button's popover menu explains that sign-in is disable by the managed
browser's organization, and provides a link to the chrome://management
page for more information.

As part of this change, the TableViewInfoButtonItem class was modified
to support changing the color of the cell's main text and letting
callers provide a pre-instantiated UIImage. Passing an image rather
than an image name is necessary in the case of sign-in, because the
image must be created by the SigninResourcesProvider.

In addition, the EnterpriseInfoPopoverViewController was modified to
enable one of the disabled constructors, which lets callers provide
the primary text message.

Screenshots of the new UI when sign-in is disabled:
https://screenshot.googleplex.com/38X86W24GXm2Ej5
https://screenshot.googleplex.com/9yee95xBSJ7u3D6

UI mocks:
go/bling-enterprise-q42020 (slide 6)

Bug: 1155745
Change-Id: I099c67b93023fb3f78181bdfeae13dcb73a0e59e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591388
Commit-Queue: Guillaume Jenkins <gujen@google.com>
Reviewed-by: Nohemi Fernandez <fernandex@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838195}

This TODO was addressed in https://crrev.com/c/2571806.

Change-Id: I0c0b28e8cc9af0a6662a3da02f8550d86dd23733
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595718
Commit-Queue: Chris Fredrickson <cfredric@chromium.org>
Commit-Queue: Eric Orth <ericorth@chromium.org>
Auto-Submit: Chris Fredrickson <cfredric@chromium.org>
Reviewed-by: Eric Orth <ericorth@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838194}

These classes are no longer used when |NGFragmentItem| is
enabled.

Functions that are marked "to be moved in future" in
|ng_physical_text_fragment.cc| are moved to
|ng_fragment_item.cc|.

Bug: 1154531
Change-Id: I5f4d2411b5c3d5f131c2f09420e67224624aa1c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596656Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Auto-Submit: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838193}

In some cases, we can give a new AXTreeID to an existing AXTree,
replacing the key associated to the tree's AXTreeManager in the
AXTreeManagerMap for the new tree id. This happens on a page reload or
on same-page navigation.

We store a AXPlatformNodeTextRangeProviderWin::TextRangeEndpoints -
which is an AXTreeObserver on the AXTree. When such a scenario happens,
the AXPlatformNodeTextRangeProviderWin loses its access to the access
because its nodes are not referencing the new tree id. we then start our
destruction process and try to remove the observer from the tree's
obersers list - without success, because we can't get the AXTreeManager
from the previous tree id. This causes us to keep a reference to a
destroyed object in the observers list.

To avoid this issue, the AXTreeManagerMap is now notifying the observers
about its removal right before it happens. This allows us to remove the
observer before if needed.

Bug: N/A
AX-Relnotes: Fix crash occurring on page reload with UIA enabled.
Change-Id: I6fe6b35764e3c7c3e7391733217b84bb43201a58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596013
Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838192}

Metrics added in this CL:
PasswordProtection.RequestReferringAppSource

Bug: 1154860
Change-Id: I4707a6c95e7702f29760d0331f24d6954bd9094d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592630Reviewed-by: Bettina Dea <bdea@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Xinghui Lu <xinghuilu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838191}

Bug: 1048632
Change-Id: Idd21c222dcfeff9bd901788823dac392da0da1ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597579Reviewed-by: Yue Zhang <yuezhanggg@chromium.org>
Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838190}

Re-landing after revert:
  https://chromium-review.googlesource.com/c/chromium/src/+/2593096

IntersectionObserver may require sticky position information, so if
a lifecycle update is forced by IntersectionObserver, make sure it
proceeds far enough to update sticky position.

As noted in the code comments, even if sticky position update is
moved up to the layout phase (which is planned, I think), if the
document is servicing any IntersectionObservers with
track_visibility=true (i.e. V2 features), then we will still need to
force the lifecycle update to continue far enough to enable hit
testing. That's the root cause of the bug.

Bug: 1156937
Change-Id: Ibbb7025d5dd5d1b1dd0d93e027cd5fb6d3d04ebc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595477Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838189}

If a cache is hit during real time URL check, we'll fall back to
hash-based check. We'd like to know how often that the cache is safe
while the response from hash-based check is unsafe.

Metrics added in this CL:
SafeBrowsing.RT.GetCache.FalsePositive

Bug: 1157331
Change-Id: Ib91e8c6ae2149645f31e69252d5f2f74594cb6de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594095Reviewed-by: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Xinghui Lu <xinghuilu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838188}

The file xr_cube_map.cc contains a line using the C library function
pow with floats as input arguments. The C lib function "pow" returns
a double, while the rest of the arguments to base::ClampToRange on the
same line are floats. It looks like the intention here is to either use
"powf" or "std::pow", which would not return a double.

This line was introduced by the following CL:

https://chromium-review.googlesource.com/c/chromium/src/+/2535915

This line builds fine against libc++, however it does not with
libstdc++ where it causes a template deduction error. This patch
changes the function call in question to std::pow in order to avoid said
template deduction error.

Bug: 957519
Change-Id: I1907f85acd475a48ea12d8c476004d2c09abb579
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595280Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Commit-Queue: Hans-Filip Elo <helo@vewd.com>
Cr-Commit-Position: refs/heads/master@{#838187}

https://skia.googlesource.com/skia.git/+log/4052510f0b7a..860d01ca8bae

2020-12-17 reed@google.com Idea: implement drawImageNine by calling drawImageLattice
2020-12-17 reed@google.com Revert "Revert "Reland "Rename getTopDevice/getDevice to topDevice/baseDevice"""
2020-12-17 bsalomon@google.com Fix images used in orientation GMs
2020-12-17 egdaniel@google.com Update creating GrProgramDesc for vulkan resolve loading.
2020-12-17 kjlubick@google.com [canvaskit] Update to 0.22.0
2020-12-17 jlavrova@google.com Remove static allocattion of UText
2020-12-17 kjlubick@google.com [canvaskit] Modify drawImageNine API to handle Filter quality
2020-12-17 bsalomon@google.com Support luminance-alpha GL format for YUVA planes
2020-12-17 reed@google.com Remove obsolete dox w.r.t. filter-quality
2020-12-17 michaelludwig@google.com Revert "Reland "Rename getTopDevice/getDevice to topDevice/baseDevice""

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: tdenniston@google.com
Change-Id: I581aa92486d52248cd468ebc158c00d02c72f550
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595681Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#838186}

It seems that this needs to be a RepeatingCallback instead of
a OnceCallback. Because at the:
chrome/browser/media_galleries/win/snapshot_file_details.h,
this callback is used by SnapshotRequestInfo which is then owned
by SnapshotFileDetails. The SnapshotFileDetails need to have
const access to the SnapshotRequestInfo and hence the callback
cannot be a OnceCallback.

This is a code health CL, no behaviour change is expected.

Bug: 1152278
Change-Id: Ia5eb65521cf100c38b47ae288daa41e2e432e897
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595928
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838185}

The file ax_tree_formatter.h does not include <memory> and  <string>
while they are used there - but still seems to compile with libc++. For
libstdc++ - this does not compile.

This patch adds the missing includes.

AX-Relnotes: n/a.
Bug: 957519
Change-Id: I45f0a474b67c0b26729a24bc9028e75fbfa25729
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597306Reviewed-by: Joanmarie Diggs <jdiggs@igalia.com>
Commit-Queue: Hans-Filip Elo <helo@vewd.com>
Cr-Commit-Position: refs/heads/master@{#838184}

Adds a new Feature to control whether to show a help section inside
the Panel as a promo for the Longpress experiment.

The Feature implementation is stubbed out.
BUG=1158621

Change-Id: I1dd09eec35ff158a8268ca6d031299412d72a72e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592393Reviewed-by: Sinan Sahin <sinansahin@google.com>
Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Theresa  <twellington@chromium.org>
Auto-Submit: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838183}

This patch updates test expectations so that they pass when the
ProcessSharingWithStrictSiteInstances process model is enabled instead
of ProcessSharingWithDefaultSiteInstances. Most of the changes just
rearrange the existing expectations to make it clearer which ones
apply to the default SiteInstance mode and which ones apply to
"strict SiteInstance" modes where we don't allow multiple sites to be
assigned to a single SiteInstance. Several helper functions were added
to make it easier to update expectations as the process model changes
in future CLs.

- Added AreStrictSiteInstancesEnabled(),and
  IsIsolatedOriginRequiredToGuaranteeDedicatedProcess() helper functions
  to make it easier to express differences in test expectations.
- Updated TestWebContents::CrossProcessNavigationPending() to actually
  verify that the navigation is cross process instead of just verifying
  whether a speculative RenderFrameHost was created. This is needed for
  ProcessSharingWithDefaultSiteInstances because this mode can trigger
  speculative RenderFrameHosts creation for a navigation that will
  stay in the same process.
- Updated many test expectations that compare SiteInstance pointers.
  Many cases only should expect pointers to match when the default
  SiteInstance mode is enabled. Logic related to these comparisons were
  reorganized to make this more clear.
- Updated several tests to explicitly isolate origins when
  ProcessSharingWithStrictSiteInstances is enabled, just like they are
  for ProcessSharingWithDefaultSiteInstances. This is needed because
  these two modes might allow sites to share a process when the tests
  explicitly want them to have dedicated processes.

Bug: 1158650
Change-Id: I4cb361e1105ebab800ebc94b51aeda416e37f40e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551275Reviewed-by: Aaron Colwell <acolwell@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Aaron Colwell <acolwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838182}

-Adds methods to record the un/succsessful network duration of articles fetch,
more articles fetch and actions upload.
-Creates a new Histogram for un/succsessful actions upload

Bug: 1159119
Change-Id: Id83b824be73d7340876a968016426187eebd1001
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593743
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Dan H <harringtond@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838181}

https://android.googlesource.com/platform/external/perfetto.git/+log/cc9b7694ce3d..0d23e521cc40

2020-12-17 dsrbecky@google.com Merge "Reuse libunwindstack buffers between consecutive unwinds."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I7e76bac499791e2e466229fe8e881c917b5f6719
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597620Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#838180}

The overall project aims to expose CNAME aliases to the
SubresourceFilter to aid in ad tagging and blocking.

A previous CL stored CNAME aliases in net::AddressList during
DNS resolution. This CL's parent added an accessor to
net::ResolveHostRequest/net::HostResolverManager::RequestImpl.

This change continues the plumbing by adding a base::Optional parameter
to net::ConnectJob::SetSocket.

net::Socket, on the other hand, gains both a getter and a setter for
the aliases, which need to be stored in the sockets in case of socket
reuse. But only three derived classes get a nontrivial implementation
with an actual field to store the aliases: net::TCPClientSocket,
net::SSLClientSocketImpl, and net::WebSocketStreamSocket.

Relevant tests:
net:net_unittests
out/Default/net_unittests --gtest_filter=*Dns*Alias*

Bug: 1151047
Change-Id: Ib1d8f6d8358aa445fad9051218336ec9953ff9b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563439
Commit-Queue: Cammie Smith Barnes <cammie@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838179}

Send the server and computed types to autofill service when the
response arrives after the autofill starts.

Add test to cover this case.

Bug: 1151542
Change-Id: I91ffab1f0bd3ce62fb768ed690e90e2094c4d86d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595792
Commit-Queue: Michael Bai <michaelbai@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838178}

TBR=bling-team@google.com

Change-Id: Ie939ae9c326a22934ddd26454b6d5cbb3dd7ed86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595460Reviewed-by: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#838177}

In [1], handshake error information was provided via an |OnFailure|
call. But the failure message is still provided via the pipe's reset
reason. This change removes that duplication.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/2527889

Change-Id: I767cc75504ed305252713db0ef6683d3ebe9544f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538203Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838176}

To cleanup OobeDialogHostBehavior

Bug: none
Change-Id: Icfcb9722da2ed8d98e44147a741466bb28f698e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595407Reviewed-by: Roman Aleksandrov <raleksandrov@google.com>
Commit-Queue: Roman Aleksandrov <raleksandrov@google.com>
Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838175}

This is a reland of 3d519f44

Original change's description:
> Move CanExecuteScripts() to V8ScriptRunner::CompileAndRunScript()
>
> To unify how CanExecuteScripts() is checked across
> classic script evaluation code paths.
>
> This CL doesn't change the behavior.
>
> Bug: 1111134
> Change-Id: If95a32043c52767eda05f16f9630edee26c5e75f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544938
> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
> Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#832649}

The original CL was reverted due to build time increase
(crbug.com/1155843) by
https://chromium-review.googlesource.com/c/chromium/src/+/2576236.

This reland CL moves ScriptController::ExecuteScriptPolicy out of
ScriptController, to avoid an extra #include of script_controller.h
that caused the build time increase.

Bug: 1111134, 1155843
Change-Id: I02119f1e522d6446904dd87a8ff0d507aa246793
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594209
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838174}

* Dialog now stays the same height at each step of flow.
* Change font family of title to Google Sans from default Roboto.

Screenshots:
https://drive.google.com/drive/folders/1HFqo9TJfPttAzsPkJGjWizUYgoDQk67q?usp=sharing

Fixed: 1158507, 1155684
Bug: 1106937
Change-Id: Ic1e03dd010aef2613659274afffa5520405a1971
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596244
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838173}

Kenneth Christiansen ran into a few interop issues while trying to get
his polyfill implementation to pass the WPT tests.  In particular, it
seems browsers and nodejs do not agree on hostnames with characters like
'|', '^', etc.

This CL removes these test cases for now.  Solving URL interop issues
is outside of the scope of URLPattern.  It simply builds on top of the
platforms existing URL canonicalization behavior.

Kenneth also suggested testing a protocol with a dash in it.

Bug: 1141510
Change-Id: I5bdf75b93545dd59592d6be9c7870f4367f7b0dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596113Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838172}

This CL updates the url_pattern and liburlpattern DIR_METADATA to point
to the new Blink>URLPattern component.

It also updates the liburlpattern OWNERS file to simply refer to the
blink url_pattern OWNERS instead of duplicating content.

Bug: 1141510
Change-Id: I312eef95812038cd8acbe186d657cb0a586c33ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596011Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838171}

For tablet mode, we should better use the regular way to launch CCA,
which means opening CCA in a Browser, rather than using CameraDialog so
that the size of the CCA can be fullscreen as well.

Bug: b/175322338, b/175326967, b/174891007
Test: tast run [DUT] camera.CCAUIIntent*
Change-Id: I39cecffb36e4d104253d74ffd9e44c6740a648b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596282
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Shik Chen <shik@chromium.org>
Auto-Submit: Wei Lee <wtlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838170}

- Remove `kAssistantQuickAnswersEnabled` pref
- Clean up its ref in assistant and quick answers code
- Clean up its settings bindings and settings ui
- Clean up its policy bindings

Bug: b/159670857
Test: Run existing tests
Change-Id: I4cbd620c1aa80a34a81b9316abaf4e649fa6eeab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582804
Commit-Queue: Yue Li <updowndota@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Jeroen Dhollander <jeroendh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838169}

Schedule tab search benchmark on Windows 10 since
most of the failures are fixed.

Bug: 1099917
Change-Id: I806ac094647f54b0b1bbf4c45b686dd39fa77ef1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595983Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Yuheng Huang <yuhengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838168}

When the option element is rendered, neither spaces nor line breaks are
preserved in the text, so nowrap makes more sense than pre.

Firefox currently has nowrap, whereas safari has pre.

Bug: 561071
Change-Id: I5293453192b379761649de76eeb29130086747a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587607
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838167}

This is regarding the move single or multiple passwords to the Google
Account triggered from chrome://settings.

Since the move bubbles in settings are shown upon explicit user action,
the cancel button should have the text "Cancel" instead of "No thanks"

This is different from the native move bubble shown automatically upon
successful signin which correctly has the text "No thanks" in the
cancel button.

TBR=cpu@chromium.org

Bug: 1139263
Change-Id: I76961128d0c0c6f78ec3a5f1bb6b8ae33b47b132
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597438Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838166}

https://chromium.googlesource.com/catapult.git/+log/92c77100518e..5039608d3366

2020-12-17 yuhengh@chromium.org Log trace collect time in TracingBackend.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC wenbinzhang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1152598
Tbr: wenbinzhang@google.com
Change-Id: I6a4f977a8484c23a72d1524075e7460139a99bdb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597408Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#838165}

Frontend CL:
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2409192

Bug: 1159502
Change-Id: I3f3c479504f2d71c09bb73441b89ccdaa495edc7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596217Reviewed-by: Brandon Goddard <brgoddar@microsoft.com>
Commit-Queue: Songtao Xia <soxia@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#838164}

Fixed: 1129157
Change-Id: Ifc31c71ad0810df279fb1e9ca3869654f882cab5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593935Reviewed-by: David Bienvenu <davidbienvenu@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Auto-Submit: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838163}

 * Implement |install_create_shortcut_tabbed|
 * Implement |set_open_in_window_internal|
 * Implement |assert_window_created|
 * Add a testing journey

Bug: 1156363, 1156733, 1156379
Change-Id: I70293d6b4fd06773e6e01d9d4806ef8367794a41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595977
Commit-Queue: Jarryd Goodman <jarrydg@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838162}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f8ca67ef2d09..fdd70108b562

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC kmilka@google.com,gayane@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: kmilka@google.com,gayane@google.com
Change-Id: I16ebd808502803bd7c2a71f1ae77a0410f99b792
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597616Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#838161}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/25c49a45ff39..7df55c21d64b

2020-12-17 wolfi@chromium.org Show service workers in the Application Panel's frame tree
2020-12-17 sigurds@chromium.org Show an issue if a SAB is passed to postMessage

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1051466,chromium:1122507
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Id43d6be9ab6373c6a095f40f175c9ead2a186a8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597413Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#838160}

Bug: 1155724
Change-Id: Icf0a258854ca518596c4b48a9b67bcfec9ec0928
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596834
Auto-Submit: Eugene Zemtsov <eugene@chromium.org>
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838159}