- 08 Aug, 2020 30 commits
-
-
Akihiro Ota authored
This change: 1. Fills in content for the tutorial given in the OOBE. 2. Automatically opens the OOBE tutorial if ChromeVox is started from the OOBE. Only do this if the --enable-experimental-accessibility-chromevox-tutorial flag is enabled. 3. Adds a Panel method for creating the interactive tutorial. The logic for this function existed prior to this change; we add this method for better cleanliness and readability. Bug: 1075752 Change-Id: I3aaefb2a934cde078747bfee105c1427af305400 AX-Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330048 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#796205}
-
Claude van der Merwe authored
Privacy page was included in both os_settings.js and lazy_load.js for Polymer 2 -> Polymer migration. It should just be in lazy_load.js. Change-Id: I7ab9a30defc581dce696839e436c7522ea0f39f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343774Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Claude van der Merwe <cvandermerwe@google.com> Cr-Commit-Position: refs/heads/master@{#796204}
-
wutao authored
This patch fixes a11y for Settings topic source row. Bug: b/163119293 Test: manual Change-Id: Ied501b54d3e5c34b565484f4bb4d8d1691963bc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343317Reviewed-by:
-
Karan Bhatia authored
This reverts commit 7d96ee5f. Reason for revert: This broke assertions we make in the extensions docserver causing the docserver to stop updating. Several places (including extension bindings) depend on callbacks always being the last parameter to a function. Original change's description: > Add an optional boolean parameter in boundsForRange > > Current boundsForRange will clip the bounds to ancestors. This CL adds an > optional boolean parameter, clipped, to the boundsForRange method. The > default value of the parameter is true. When the clipped is set to false, the > bounds will not be clipped to the ancestors of the nodes. > > This CL is a part of the fix for bug 775659. > > Bug: 775659 > Change-Id: I804637a2e6a8ec695dc176b88bd55d12fbc7f8a0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335390 > Commit-Queue: Lei Shi <leileilei@google.com> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#795339} TBR=dmazzoni@chromium.org,dtseng@chromium.org,leileilei@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 775659, 1114299 Change-Id: If9f19eb87f798afc10734cccd8b533ecd36bdacd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343876 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#796202}
-
James Hawkins authored
R=khorimoto@chromium.org Bug: 1045266 Test: CrComponentsCrPolicyNetworkBehaviorMojoTestV3.All Change-Id: I1dea92e46fd096dc7e1db599a296b5f5c75bb984 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343847Reviewed-by:
-
cfredric authored
Bug: 1085645 Change-Id: Ie50ebdc503ae238644e7e9679942696e79763c84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308889Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Chris Fredrickson <cfredric@google.com> Cr-Commit-Position: refs/heads/master@{#796200}
-
Ben Pastene authored
The two builders look stable and their owners would like them sheriffed: https://ci.chromium.org/p/chromium/builders/ci/linux-bfcache-rel https://ci.chromium.org/p/chromium/builders/ci/android-bfcache-rel Bug: 1031391 Change-Id: I75cdac4c4108bdb771d2a679f7a01000144405b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343765Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#796199}
-
Carlos Knippschild authored
This merge includes the following commits: commit 5c177dff913851f5adaf4c536c67154c4c1041a7 Author: Dan Anderson <danrand@google.com> AuthorDate: Tue Jul 28 12:29:32 2020 -0700 Commit: Copybara-Service <copybara-worker@google.com> CommitDate: Tue Jul 28 12:30:21 2020 -0700 Adds ActionSurface to feed_action.proto PiperOrigin-RevId: 323628979 Change-Id: Ia0e187327c6720e225b2c54f35ca23df73c08d2d Change-Id: I22e19a8cb9a2dbf7fb6ec2c08aab706cc643bdb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343555 Auto-Submit: Carlos Knippschild <carlosk@chromium.org> Reviewed-by:Dan H <harringtond@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#796198}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/005aa46e0e2d..df7c08830093 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC robertocn@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1064151,chromium:1085419,chromium:1099917,chromium:1110346,chromium:1113301 Tbr: robertocn@google.com Change-Id: Ide5a020105f3f9dbb72f3f0e41e623c0b44ba5ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343677Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796197}
-
Joe DeBlasio authored
This CL updates the strings to reflect our latest iteration with UX. Bug: 1114359 Change-Id: Ica65640967f7323286f65cd5f31f1ba491b49f14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343661Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#796196}
-
James Hawkins authored
This is in preparation for adding more tests for CrOS-specific cr_components. R=khorimoto@chromium.org Bug: none Test: CrComponents*Test Change-Id: Icfb887e992f5bd3d4e429c369d900effc8e4320e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342252 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
-
Wan-Teh Chang authored
Add a test that reproduces the IsColorSpaceSupportedByPCVR() bug fixed in https://crrev.com/c/2343535. Test: blink_platform_unittests --gtest_filter=*AVIF* Bug: 1108626 Change-Id: I1d1d7e887116240feb9a8b9e8df615d6e78d03d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343506 Commit-Queue: Wan-Teh Chang <wtc@google.com> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#796194}
-
Sorin Jianu authored
This CL adds the RPC end points invoked by --wake, and the ControlService classes for Windows. After this CL lands, then --wake should work on Windows using the new --wake code path. There is still work to be done in other areas, such as promoting the candidate updaters, sxs class registration, etc. Bug: 1107586 Change-Id: Ia7b4ad94037bea01581384add2451156685d5a8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332854Reviewed-by:
S. Ganesh <ganesh@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#796193}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e0dd3df0934a..31954bf23f24 2020-08-07 johnstiles@google.com Enable ClangTidy check performance-unnecessary-copy-initialization. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: herb@google.com Change-Id: I8e87a6382f7bc0d180d1dfd0e8ca61ce21656294 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343639Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796192}
-
Emily Stark authored
Previously, we were searching for the registrable domain from the left end of the text and using that as our simplified domain bounds. This is incorrect in the case that the registrable domain is also a subdomain, e.g. example.com.example.com. Now we instead search from the right end of the hostname. Bug: 1111902f Change-Id: I0fe97036986688b19f3a2315a32f413c8bf50b68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343572 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#796191}
-
Livvie Lin authored
Change-Id: I10a4bc85fc77d2c7310c573a72adce4bb5fc076f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343769Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#796190}
-
Wan-Teh Chang authored
Add the AVIF image format to the canvas-createImageBitmap-e_srgb.html test in wpt/html/canvas/element/manual/wide-gamut-canvas/. Also update lint.ignore to have the wpt lint tool ignore *.avif files. The AVIF test images pattern-srgb.avif and pattern-srgb-transparent.avif were generated from pattern-srgb.png and pattern-srgb-transparent.png using the 'avifenc' program in libavif v0.8.0 with the following command lines: avifenc --speed 0 --yuv 420 --cicp 1/13/1 --range full \ pattern-srgb.png pattern-srgb.avif avifenc --speed 0 --yuv 420 --cicp 1/13/1 --range full \ pattern-srgb-transparent.png pattern-srgb-transparent.avif Test: third_party/blink/tools/run_web_tests.py -t Default \ external/wpt/html/canvas/element/manual/wide-gamut-canvas/canvas-createImageBitmap-e_srgb.html Bug: 1099028 Change-Id: I3577682a0e23dd768af32907cf549270f331c7a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304961Reviewed-by:Stephen Chenney <schenney@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#796189}
-
Chris Cunningham authored
Small number of crashes in the linked bug. Re-init seems the only possible explanation. Not obvious how that might occur. Bug: 1114128 Change-Id: Idf34a1b7bdf11f43cf6469f9d5b24ce10ec79e7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342390 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Auto-Submit: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#796188}
-
Justin Cohen authored
XCUIElement queries used in ARQuickLook are broken on Xcode 12 beta 4 when running on the iOS 12 simulator. Disable until Xcode is fixed. This is a re-land of a reverted CL using testInvocations to disable instead. Unfortunately, this doesn't work in the test runner. Bug: 1114202 Change-Id: Ibfd60c9bb4742c03e459080be81bb7f14dc9c9a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343552 Commit-Queue: Justin Cohen <justincohen@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#796187}
-
Matthias Körber authored
Copying the input data fits the structure of the test setup. Change-Id: I822ee962aaaaed433494bad604e59f69a2583eea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343266 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#796186}
-
Karan Bhatia authored
This reverts commit a4dc12c8. Reason for revert: This breaks an assertion in the Docserver causing it to stop updating. Original change's description: > [DNR] Change listed availability of Modifyheaderinfo > > The structs were already functional by M85, but because the > documentation was updated after the branch cut, the docserver listed > ModifyheaderInfo as being available at M86. > > The availability is usually determined automatically by looking over API > schemas over different versions/channels in > chrome/common/extensions/docs/server2/availability_finder.py > > Bug: 947591 > Change-Id: Iae71ac3c7b6bc9fb7e7d86815e855e31f588f36e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340074 > Reviewed-by: Karan Bhatia <karandeepb@chromium.org> > Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> > Auto-Submit: Kelvin Jiang <kelvinjiang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#795805} TBR=karandeepb@chromium.org,kelvinjiang@chromium.org Change-Id: Ic9c8fdfed838d8e5e134db029e4220ef1f677c90 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 947591, 1114299 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343946Reviewed-by:
-
Carlos Knippschild authored
Reporting implicit user actions will be enabled in either of these cases: * When Feed V1 is enabled AND ReportFeedUserActions is enabled. * When Feed V2 is enabled. Bug: 1044139 Change-Id: I0dfa1d8d1f05a82f2308b7a84e5f58919e81b432 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339590Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
-
Xinghui Lu authored
Add a flag named "privacy-reordered-android" to control this layout change. For more details on why these preferences are reordered, see: go/ep-clank. before: http://screen/gHQewPrMJK7 after: http://screen/RRSAYxS3K1y Bug: 1097310 Change-Id: I9866d9fc62ea3decb5db6712c7cc47d2b4609459 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340391 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#796183}
-
Scott Violet authored
This takes the heavy handed approach of deleting *all* favicon data any time clearing data is requested. To do otherwise would be challenging as there isn't enough information in the db to really know which favicons should be deleted in a range. The chrome side keys off visits to track this information, but we don't have that. BUG=1076463 TEST=ProfileBrowserTest.ClearBrowsingDataDeletesFavicons Change-Id: I033ece1197889ff7f5f5edd864fc2f84e27606fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340870 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#796182}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3a3d419df752..1dcb3eb267e9 2020-08-07 syoussefi@chromium.org Vulkan: Don't expose MSRTT on Mac/SwiftShader 2020-08-07 syoussefi@chromium.org Vulkan: Fix render-to-texture simultaneously bound to two FBOs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1112986 Tbr: geofflang@google.com Change-Id: I86ee3124c08ea40c5f02ce19b6f35c8a3ce104a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342260Reviewed-by:
-
Ben Pastene authored
There's a few failing tests in both suites, so just mark the tests as experimental for now while they're greened up to prevent alerting sheriffs. Bug: 1092973 Change-Id: I0e777044720790753056a8ba3b83ba1fe302af8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343632 Commit-Queue: Ben Pastene <bpastene@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Auto-Submit: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#796180}
-
Ken Rockot authored
Introduces a new PreemptiveMobileNetworkActivation feature. When this is enabled, the network stack will ask the OS to activate a connected mobile network whenever it suspects the current default (Wi-Fi) network has degraded connectivity. This also adds a new histogram when the feature is enabled, to capture how often this preemptive mobile network activation is imminently followed by a system-wide default network change to that same network or any other network. Bug: 1079396 Change-Id: Ib8b8294addb51c60b55cf512b293fa5418976452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339595Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
-
sczs authored
Bug: 1085419 Change-Id: Ic038ca854016a3d2ad460ab1133527bedbd0ff78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343636 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#796178}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I2bab251279b1dee5de8492e4a6f1c621aa672e17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343676Reviewed-by:
-
Xiaohan Wang authored
These two functions are needed to notify the CDM about the last used key IDs during suspend and resume. Bug: 999747 Change-Id: I4f988784cc67d6e0699ec31ba2236de38c64615e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331092 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#796176}
-
- 07 Aug, 2020 10 commits
-
-
Justin Cohen authored
This reverts commit 2d01e3cc. Reason for revert: testInvocations isn't supported by test runner. Original change's description: > ios: Disable ARQuickLook tests on iOS12/Xcode12b4. > > XCUIElement queries used in ARQuickLook are broken on Xcode 12 beta 4 > when running on the iOS 12 simulator. Disable until Xcode is fixed. > > Bug: 1114202 > Change-Id: Ib16458ee93e6821b5520cbd791e3ba8e6beccfe4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341220 > Auto-Submit: Justin Cohen <justincohen@chromium.org> > Commit-Queue: Rohit Rao <rohitrao@chromium.org> > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#795982} TBR=rohitrao@chromium.org,justincohen@chromium.org Change-Id: Ic1ea153414e47bc0a3867dcf609a3313bd877623 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1114202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343551Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#796175}
-
Nick Harper authored
Change-Id: I91fc22ca7f30912ed57e80837af7223a6263cd97 Bug: 815267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339452Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#796174}
-
Ilia Samsonov authored
This CL removes the blink Mac10.10 and Mac10.11 configurations. Requires https://chromium-review.googlesource.com/c/chromium/tools/build/+/2343182 Bug: 1107003 Change-Id: Ic4d82e7d0d76d7b60894d919e47c1e19122a0f0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343310Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#796173}
-
Tommy Martino authored
This CL addresses a few comments that were received after landing https://chromium-review.googlesource.com/c/chromium/src/+/2337407 Bug: 1099268 Change-Id: Ieb8fa406f69fc28ab15ce89d79030d93b39cc8ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341665 Commit-Queue: Tommy Martino <tmartino@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#796172}
-
James Long authored
Convex hull buildtarget groupings in the class graph now contain a label above their highest node with the name of the target. Change-Id: I11509290940fc2540cbaf987d29b6cca7d58ecc0 Bug: 1109274 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340067Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: James Long <yjlong@google.com> Cr-Commit-Position: refs/heads/master@{#796171}
-
Ethan Jimenez authored
1. Adding missing track sizing function flags in `GridTrackSize`; these new flags shouldn't regress legacy grid's functionality. 2. Implementing an iterator for every `NGGridSet` in a track collection. `TestNGGridLayoutAlgorithmTrackCollectionSetIterator` is updated to verify `NGGridLayoutAlgorithmTrackCollection::GetSetIterator`. 3. Introducing track size normalization in `NGGridSet`; this is done in order to guarantee consistency with the definitions from css-grid-1 in future steps of the track sizing algorithm. Also, adding a unit test that checks if the normalized track sizes match the https://drafts.csswg.org/css-grid-1/#algo-terms spec. 4. Setting up the track sizing algorithm in `NGGridLayoutAlgorithm`; this change comprises the "initialize track sizes" step of the algorithm (see https://drafts.csswg.org/css-grid-1/#algo-init). 5. Setting up column width and row height resolution steps for grid sizing (https://drafts.csswg.org/css-grid-1/#algo-overview). 6. Adding unit test for the straightforward case of resolving track sizes of a grid with tracks of fixed sizing functions. Since extra space distribution in `NGGridLayoutAlgorithm::ComputeUsedTrackSizes` is still missing, expectations for this test are temporary and are only meant to test initialization of base sizes and growth limits. Bug: 1045599 Change-Id: Ia3a4ee9ea0a7e3acdca3e3a7b9f80d5307584d2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320128 Commit-Queue: Ethan Jimenez <ethavar@microsoft.com> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#796170}
-
Nasko Oskov authored
The NavigationThrottleRunner is tracing events related to the NavigationRequest, however using the delegate pointer does not work to associate the two logs together. This CL changes both NavigationRequest and NavigationThrottleRunner to use the navigation id as the common identifier to tie the tracing events together. Bug: 1043616 Change-Id: I84594851724f1026fa9c9a5409705a127347a251 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343564 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#796169}
-
Piotr Bialecki authored
The regression (crash) was introduced when fixing an issue with hit test source cancellation not getting propagated to the device. In addition, already-cancelled hit test sources should throw when they are cancelled yet again - this was also regressed. Changes: - fixes the crash when cancelling a hit test source on a session that has already ended - ensures that double-cancelling a hit test source throws InvalidStateError (as per spec) - add instrumentation test that would have caught the browser crash - add WPT that would have caught the double-cancel issue Bug: 1113461 Change-Id: I174c48d096faa902e2210e3660874dd48ca88545 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341179Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#796168}
-
dpapad authored
This file is no longer shared between OS and Browser Settings, and can be fully migrated to JS modules. Also, did minor cleanups now that were possible as a result of dropping the Polymer2 codepath. Bug: 1069258 Change-Id: Ia0da4ac10f2858fa4fc5fe460de3b96c203bc733 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343010 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#796167}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/55eebf450c36..06994a23acac 2020-08-07 changhaohan@chromium.org Clear Grid node map when document is updated If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1113878 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id5df70c7cb59f5c8333e108dcf1ce9cbf6c058db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343580Reviewed-by:
-
