- 10 Apr, 2020 40 commits
-
-
Samuel Huang authored
This CL removes the warning message DeprecationWarning: the imp module is deprecated... from running print_python_deps.py on SuperSize (or other Python 3 projects). The key is to follow the recommendation to use importlib. Caveats: * The library only in Python 3, so we need to keep on using imp for Python 2. * This requires Python version detection and using import statements locally. * importlib.util is more fine-grained than expected, and requires: * Manually extracting module name from module path. * Explicitly adding loaded module to sys.modules. Meanwhile, once the module runs, the modules it transitively uses will be automatically added. Fixed: 1069660 Change-Id: I41b6be8975db1219da006e0c9e5d98b42acf15c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145094Reviewed-by:Andrew Grieve <agrieve@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#758136}
-
Jimmy Gong authored
This is a reland of 75e29f77 - The fix is to ensure that the print-management dom element is created and ready by the time we're querying for its child elements. - This was done by flushing the dom when the whenCalled promise is resolved, ensuring that the elements are ready. Original change's description: > Fix flaky printmanagement browser test > > - The original cause of the flaky is because the page element was not > ready by the time we try to query for elements within it. > - The fix is to attach a promise to the instatiation of the page and > to only continue with the test once the promise is resolved. This > ensures that each step of the test is handled synchronously. > > Bug: 1068860 > Test: browser_tests > Change-Id: I0a30e2971107b44354603adbb0396ddfea3c218d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142951 > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Commit-Queue: jimmy gong <jimmyxgong@chromium.org> > Cr-Commit-Position: refs/heads/master@{#757687} Bug: 1068860 Change-Id: I4b2e8b3836aa676c3d5aa43295432dd1afed6927 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145253 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#758135}
-
edchin authored
This CL: 1) Ports chrome/browser/bookmarks/managed_bookmark_service_factory.h/cc to iOS 2) Updates bookmark_client_impl.h/cc with an instance of ManagedBookmarkService, gotten from the factory. 3) Instantiates the new service where all browser state keyed service factories are invoked. Bug: 1065187 Change-Id: I840a3b2496310f0a3f40be20a35e6d71144dcdc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142106 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#758134}
-
Hirokazu Honda authored
There are several QP value variables. Their meaning might be ambiguous. This clarifies them by modifying comments. Bug: 1067522, 1034382 Test: webrtc.* and video.EncodeAccel.* on eve Change-Id: I4c3812fd2126b6c3d4e6747262474bd5d095ac5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134181Reviewed-by:
Jeffrey Kardatzke <jkardatzke@google.com> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#758133}
-
Hiroki Nakagawa authored
This reverts commit 275bf019. Reason for revert: NewTabPageDoodleShareDialogTest.All constantly fails on Mac bots: https://ci.chromium.org/p/chromium/builders/ci/Mac10.14%20Tests/3224 https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests/33302 Original change's description: > [webui][ntp] Add doodle share dialog > > The share dialog opens when clicking the share button on simple and > animated doodles. The dialog lets the user share the doodle via > Facebook, Twitter, email, and copy the doodle URL. > > + Add doodle description tooltip. > > + Remove TODO about the share button focus ring working for dark > doodles. We decided it's an edge case and doesn't warrant fixing. > > Bug: 1039910 > Change-Id: Ib2b8d9ca9447a2d6363d3c76167b393f914f60e1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138792 > Reviewed-by: Esmael Elmoslimany <aee@chromium.org> > Reviewed-by: Alex Gough <ajgo@chromium.org> > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#758033} TBR=tiborg@chromium.org,aee@chromium.org,ajgo@chromium.org,owone@google.com Change-Id: I62f6bc2e7d5e442e4c57e23fe16412313268861b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1039910 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142884Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#758132}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/55d00afb3680..b60df8ed2de8 git log 55d00afb3680..b60df8ed2de8 --date=short --first-parent --format='%ad %ae %s' 2020-04-10 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@b60df8ed2de8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If7b3887d43391c00d3b9a60503a620e29d7821de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145191Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758131}
-
Ramin Halavati authored
Profile API is being updated (issue 1033903) and the usage of GetOffTheRecordProfile without argument is getting deprecated. Use cases of this call that only refer to incognito or guest mode can use GetPrimaryOTRProfile() instead. All calls to this function in ProfileHelperImpl are updated. This CL does not make any behavioral changes. Bug: 1060940 Change-Id: I946e0e39817ab32ce07a93009dddf5c5aef3019b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143813Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#758130}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9173e675..f3470cbf Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6f9f78d663f200948ef0a3d39f39f65ed262af1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144238Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758129}
-
Chromium WPT Sync authored
Using wpt-import in Chromium b0994171. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" c53a40f4 "Update size.attributes.parse.trailingjunk" 86131ac4 "Add a test for ReplaceTrack that verifies video track content." a9c7f7ae "[css-filters] Move drop-shadow-clipped.html to WPT" 380347e7 "[css-masking] Migrate clip-path-columns-svg-clippath-usou.html to WPT" 8b540121 "[css-masking] Migrate clip-path-css-tranform-mutated.html to WPT" 67f851b8 "[css-masking] Migrate clip-path-columns-shape.html to WPT" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org: external/wpt/css/css-text/line-break NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I98c74819b74fe858a329bdb6cb880a0c21e525c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144515Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758128}
-
Jinsuk Kim authored
TabObserver.onActivityAttachmentChanged is passed WindowAndroid object (or null) instead of boolean |isAttached|. Used DisplayCutoutController for an example. Bug: 952703 Change-Id: If827a6a1df9338added95f0ffcff5400e49ddefe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134171 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#758127}
-
Minoru Chikamune authored
This reverts commit d0b13ee1. Reason for reland: crbug.com/1067937 reported me that the original CL made a surprising impact to rendering.mobile/queueing_durations. So I reverted the original CL. But even if I revert it, the measurement wasn't changed at all. So I think my CL isn't related to the Issue. I reland this CL. Bug: 1067937 Change-Id: I1187a09b1f609d2023fa4a1b9c2fd845a80f4b1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143787Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#758126}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I5b37c3a8ac664b2283496432dccb4ee06b1b3f11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145187Reviewed-by:
-
dpapad authored
When an HTML import is marked as "migrated" polymer_modulizer() will produce a path ending with ".js" instead of ".m.js". This allows mixing auto-generated and checked-in Polymer3 code while finishing Settings Polymer3 post-launch cleanups. Bug: 1069258 Change-Id: Ia7bec750e93da0e97b455ea3b2bb304ddd51c3cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144614 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#758124}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/83844953c478..8277ecb30334 git log 83844953c478..8277ecb30334 --date=short --first-parent --format='%ad %ae %s' 2020-04-09 btolsch@chromium.org Disable discovery e2e tests on mac Created with: gclient setdep -r src/third_party/openscreen/src@8277ecb30334 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I6cd49c0900026699ab505f54dde72ee8c0585748 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144980Reviewed-by:
-
Hiroki Nakagawa authored
Bug: 1069695 Change-Id: I57c087da2d2f4ccb83337d82087b9f03a4fe59fb Tbr: ellyjones@chromium.org Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143883Reviewed-by:
-
Regan Hsu authored
* Aligns RHS and LHS icons of search input to match search result rows. * Changes row's selected property to attribute instead. * Add optional margin to input placeholder text so it appears centered for new settings search. Using conventional centering of placeholder does not work because the search input is a div placed next to the magnifying glass icon, causing a center of the text to be less than centered. Screenshots: https://screenshot.googleplex.com/iSb8VuxzVN7 align icons https://screenshot.googleplex.com/HureEGYMWFk align icons (narrow) https://screenshot.googleplex.com/FF2hGVoFxe6 'center' placeholder text Bug: 1056909 Change-Id: If17be29eea183d3822a37c787a72d3f21e78c267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134657Reviewed-by:
John Lee <johntlee@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=bindusuvarna@chromium.org Change-Id: Ib60c495dde03be56e0264e9870af17e1dadabd75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144924Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758120}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1eaaf114..9173e675 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I72335a45456579601412dc1fd0eaac3f9695a15e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144237Reviewed-by:
-
Hiroki Nakagawa authored
This reverts commit 21cd313b. Reason for revert: These tests are already disabled by https://chromium-review.googlesource.com/c/chromium/src/+/2144426 Original change's description: > Revert "Disable regression tests for bug 1042010 only on Windows." > > This reverts commit 2500b17b. > > Reason for revert: > These tests are failing on several Mac bots: > https://ci.chromium.org/p/chromium/builders/ci/Mac10.14%20Tests/3215 > https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests/33296 > https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/49144 > > Original change's description: > > Disable regression tests for bug 1042010 only on Windows. > > > > Also add comment linking the related issue. > > > > Bug: 1042010 > > Bug: 1068579 > > Change-Id: Ia956aef5d609261f543c1a3eb0e06da80fc64eb9 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139763 > > Commit-Queue: Bret Sepulveda <bsep@chromium.org> > > Reviewed-by: Bret Sepulveda <bsep@chromium.org> > > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#757824} > > TBR=dmazzoni@chromium.org,bsep@chromium.org,jaragunde@igalia.com > > Change-Id: Ia2cb645cb260074bb4667787612e2470feceb132 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1042010, 1068579 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144795 > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> > Cr-Commit-Position: refs/heads/master@{#758114} TBR=dmazzoni@chromium.org,nhiroki@chromium.org,bsep@chromium.org,jaragunde@igalia.com Change-Id: I9ffee3bd997776308032777f0b8f459ed5350cf5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1042010, 1068579 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142880Reviewed-by:
-
rbpotter authored
- Move CreateCloudPrintSigninTab() to the c/b/ui/webui/print_preview/ directory in a new file, since it's only used by the print_preview_handler. - Delete print_dialog_cloud_posix.cc since it only contains a NOTIMPLEMENTED() function, and instead make the caller and print_dialog_cloud.* Windows only. Bug: 982641 Change-Id: Id292511b4c2b418a809f25957f99f76f9cdcb6fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143112Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#758117}
-
rbpotter authored
Mirror only exists on Chrome OS, which doesn't have the avatar row. https://chromium-review.googlesource.com/c/chromium/src/+/1763413 added the correct handling for the Chrome OS case, so per https://crbug.com/982641#c28 this code never executes. TBR=sinhak@chromium.org Bug: 982641 Change-Id: I00e810d16c5a8c61a5fd846c9e6041f28b489bb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145092 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
David Bertoni authored
This test was disabled in 2013. It needed to be rewritten for the modern era. After testing 3000 iterations on the bots, there were no flakes with the new version. Bug: 174934 Change-Id: I102482ad66025eb1061e916455b565be0d959acf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144613Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#758115}
-
Hiroki Nakagawa authored
This reverts commit 2500b17b. Reason for revert: These tests are failing on several Mac bots: https://ci.chromium.org/p/chromium/builders/ci/Mac10.14%20Tests/3215 https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests/33296 https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/49144 Original change's description: > Disable regression tests for bug 1042010 only on Windows. > > Also add comment linking the related issue. > > Bug: 1042010 > Bug: 1068579 > Change-Id: Ia956aef5d609261f543c1a3eb0e06da80fc64eb9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139763 > Commit-Queue: Bret Sepulveda <bsep@chromium.org> > Reviewed-by: Bret Sepulveda <bsep@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#757824} TBR=dmazzoni@chromium.org,bsep@chromium.org,jaragunde@igalia.com Change-Id: Ia2cb645cb260074bb4667787612e2470feceb132 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1042010, 1068579 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144795Reviewed-by:
-
Esmael El-Moslimany authored
Frontend for selecting and showing the selection when no background and a background image is selected. Bug: 1032328 Change-Id: Iff7864dd54ef0a2eb7b7bfb186178ef6d4d0b30f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136035 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#758113}
-
Matt Falkenhagen authored
To get a rough idea if there is any performance benefit to combining the two messages into one (of course, even if there is none, there is still the primary benefit of code simplification). This adds the UMA for navigation loads only, in the browser process. I tried doing the same for all loads in the renderer process in url_loader_client_impl.cc, but testing locally there was up to ~1 second of delay, which means likely there are some loaders that don't send the two messages immediately after each other. So, holding off on the UMA for the renderer until we understand what it's measuring more. Bug: 1017710 Change-Id: Ica7452e834a6583a763422ae356d75423fbf5fe0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141482 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#758112}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/6574f92747a2..ab2c84ffd2a4 git log 6574f92747a2..ab2c84ffd2a4 --date=short --first-parent --format='%ad %ae %s' 2020-04-09 brandon1.jones@intel.com Residency 6: Enable D3D12 Residency and Add Tests 2020-04-09 brandon1.jones@intel.com Residency Bug: Make Setting Heap's Last Submission Serial Optional 2020-04-09 enga@chromium.org Fix use-after-free if BindGroup is the last owner of its BindGroupLayout Created with: gclient setdep -r src/third_party/dawn@ab2c84ffd2a4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ib548fabc724d328e6e38160336d7356635cb3b6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145176Reviewed-by:
-
Jon Mann authored
The Polymer binding to the translated string was using single quotes around the i18n() function call, but in Dutch the string actually contained an apostrophe/single quote which caused broken syntax. Bug: 1069632 Change-Id: I2dd4e094f683ab3ce9875ec2db22ccd7e9b6cb2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144408Reviewed-by:
-
Garrett Beaty authored
Bug: 1067057 Change-Id: If6c3b2e16b99f3fd252a4d02244cab3c93e19c56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140977 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#758109}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c12c1f571aec..df3cc205af96 git log c12c1f571aec..df3cc205af96 --date=short --first-parent --format='%ad %ae %s' 2020-04-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-tools/src bb32b2a70168..ae6787114fb5 (4 commits) 2020-04-09 timvp@google.com Vulkan: Support Program Pipeline Objects Created with: gclient setdep -r src/third_party/angle@df3cc205af96 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: Ic1ba13bfc52fbac61f66bbbcd5df640f917274a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145172Reviewed-by:
-
Kevin Marshall authored
Allows the WebEngine to connect to an Agent-published MetricsRecorder service. Some simplification of CastRunner code, eliminating the need for an alternate constructor for "isolated runners" by decoupling service publishing from runner construction. Added an integration test. Bug: 1060768 Change-Id: Ia36a13cbd9a68565bd80bb32facf393b23d3cfb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133056 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#758107}
-
Jinsuk Kim authored
Browser controls state is for WebContents in base (main) tab. Preview Tab contents (or any ThinWebView clients) doesn't need to have it enabled. This CL turns it off. Bug: 1068944 Change-Id: I07396406c57a56db6e8452fce677433bfab74530 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143072Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#758106}
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: I2f5c8c7fccb2734dca3f53a44be9c155e32a5f7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144424 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#758105}
-
Hiroki Nakagawa authored
This reverts commit cce3bf4a. Reason for revert: Looks like lint failure fails the compile step on android-archive-rel: https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/10732 Original change's description: > Android: Use lint from cmdline-tools > > This version of lint is up-to-date with Android Studio and the lint team > intends to keep it that way. > > We no longer need a separate tools-lint directory for an up-to-date > version of lint. > > Bug: 1069186 > Change-Id: I8846406c4787d36863718489c3c54c4b1438d79b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144367 > Auto-Submit: Peter Wen <wnwen@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#758085} TBR=wnwen@chromium.org,agrieve@chromium.org Change-Id: I9d6c6abfc06089372ef2bf6314bfa3d6ab0cb25e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1069186 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143786Reviewed-by:
-
Ayu Ishii authored
This change adds cleanup and comments we discussed during code walk through. Change-Id: I0b5ce06501257c1285c7e907d77fd942bbc076f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140906Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#758103}
-
Hiroki Nakagawa authored
This test frequently fails on multiple bots (Linux, Mac, Win). Bug: 1068681 Change-Id: I8a0708a5bb9ecd37cd1e1363e07ca7acc3fe7db9 Notry: true Tbr: nhiroki@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143784Reviewed-by:
-
Aaron Leventhal authored
Nodes that are now ignored should not be considered cells. Bug: 1061248 Change-Id: Ic0118c58a696dc52f6528e7a9e1da34cc1eef885 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144423Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#758101}
-
Esmael El-Moslimany authored
When an OGB overlay is open, a backdrop is shown essentially making the overlay modal. The embedder is notified using an 'activate' message. The embedded updates the z-index of the OGB to be on top while the overlay is shown. Bug: 1039913 Change-Id: Ie9c1dd436bb43d6366b198d2d8aa839f58679635 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142103Reviewed-by:
-
Alan Cutter authored
This CL fixes the following warning in components_unittests: The following parameterized test case is not instantiated: UninstantiatedParamaterizedTestSuite<ActivationStateComputingThrottleMainFrameTest> The ActivationStateComputingThrottleMainFrameTest tests were not being run. All/ActivationStateComputingThrottleMainFrameTest.NoPageActivationNotification_NoActivation/0 regressed during this time. Bug: 1069398, 1045846 Change-Id: I694129e58ba5272863ee810ee7949d7e34bc72ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143779 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#758099}
-
Alan Cutter authored
This CL removes the uninstantiated test suite GestureEventQueueWithSourceTest to fix the warning in content_unittests: The following parameterized test case is not instantiated: UninstantiatedParamaterizedTestSuite<GestureEventQueueWithSourceTest> Bug: 1045846 Change-Id: I82146898d77e36240b0e26a0dcf551228435cf35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143874 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#758098}
-
Gyuyoung Kim authored
This CL migrates clip-path-columns-shape[-expected].html tests from css3/masking to external/wpt/css/css-masking/clip-path with WPT styles, adding links to the relevant specs, and test description. Additionally, this test is renamed to clip-path-columns-shape-001[-ref].html to be align with existing test naming style. Bug: 1063749 Change-Id: I146b61e8f0a841e71a05e7f93d823939e1a11ea7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143055Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#758097}
-
