GitLab

Review-Url: https://codereview.chromium.org/2283593002
Cr-Commit-Position: refs/heads/master@{#414666}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/973bb63aa294b6e2f87027c8738ddcad1c339df2 Remove blink_downstream (phajdan.jr@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=584079

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2283633002
Cr-Commit-Position: refs/heads/master@{#414665}

As per comments on the bug, this may be fixed now. Speculatively
reenabling.

BUG=461489

Review-Url: https://codereview.chromium.org/2278403002
Cr-Commit-Position: refs/heads/master@{#414664}

Cr-Commit-Position: refs/heads/master@{#414663}

Previously the code couldn't correctly validate inlined nullable unions.

BUG=None.

Review-Url: https://codereview.chromium.org/2286513002
Cr-Commit-Position: refs/heads/master@{#414662}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/23c1b4a4e779..30b05c202793

$ git log 23c1b4a4e..30b05c202 --date=short --no-merges --format='%ad %ae %s'
2016-08-25 benjhayden Modernize RelatedValueSet, RelatedValueMap, Composition to use ES6 classes.

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2283603002
Cr-Commit-Position: refs/heads/master@{#414661}

FrameTypeTopLevel in this case will be considered bad message by PlzNavigate.

This fixes browser tests with PlzNavigate:
ErrorPageTest.DNSError_DoClickLink
ErrorPageTest.DNSError_DoReload
ErrorPageTest.DNSError_DoReloadAfterSamePageNavigation
ErrorPageTest.DNSError_DoSearch
ErrorPageTest.StaleCacheStatus

BUG=576285

Review-Url: https://codereview.chromium.org/2285493002
Cr-Commit-Position: refs/heads/master@{#414660}

* Event order: (see July F2F[1] and GitHub discussion[2])
  1. Clipboard API cut
  2. (Clipboard update)
  3. 'beforeinput' InputType=|deleteByCut|
  4. (DOM update)
  5. 'input' InputType=|deleteByCut|

* Canceling 'beforeinput' will only prevent DOM update.

* |dataTransfer| field: (see Editing spec discussion[3])
  1. NULL for |deleteByCut| (JS could always get from selection)
  2. Readonly |dataTransfer| for |insertFromPaste|

[1] Editing TF July F2F:
https://docs.google.com/document/d/1XxIEF0So-kMF5mcJ03Yj0zsYMFRHEgXw1fV1K5FOwuQ/edit#heading=h.l9vlzb1oc68r

[2] GitHub discussion for event order:
https://github.com/w3c/editing/issues/144#issuecomment-240892363

[3] Editing spec discussion:
https://github.com/w3c/editing/issues/144#issuecomment-240259209

Intent to Implement:
https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/InputEvent/blink-dev/RrnitB0OElc/rirueVekCwAJ

BUG=639139

Review-Url: https://codereview.chromium.org/2258663003
Cr-Commit-Position: refs/heads/master@{#414659}

I want to reuse this struct for borders and padding as well, so I want
to rename it to a more generic name, and it belongs more to ng_units.h

R=eae@chromium.org,ikilpatrick@chromium.org
BUG=635619

Review-Url: https://codereview.chromium.org/2281763002
Cr-Commit-Position: refs/heads/master@{#414658}

We've been shipping CSS Variables since M49, no need for this flag :)

BUG=402536

Review-Url: https://codereview.chromium.org/2279133002
Cr-Commit-Position: refs/heads/master@{#414657}

BUG=

Review-Url: https://codereview.chromium.org/2286533002
Cr-Commit-Position: refs/heads/master@{#414656}

There is still a slew of things to do, but this is a good start (and
rather lengthy).

There are two distinct ways for immersive mode to work in mash:

1. Mash takes care of it all. In this mode a separate ui::Window is
   created for the reveal of the title area. HeaderView is used to
   render the title area of the reveal in the separate window. The
   client does nothing special here.
2. The client takes control of it all (as happens in chrome). Chrome
   too creates a separate window for the reveal. This window is a
   child of the chrome frame. Mash knows to paint window decorations
   by way of a special property set on the window. Chrome runs all the
   immersive logic, including positioning of the reveal window.

To get 2 to work I had to relax a constraint of mus, in particular
this allows the window manager to set the underlay of any
window. Previously only the owner could, but as 2 requires mash to set
the underlay I had to relax the constraint.

I also changed it so that events in the underlay always go to the
window manager, not the owner as previously.

BUG=634972, 640365
TEST=none
R=jamescook@chromium.org, tsepez@chromium.org

Review-Url: https://codereview.chromium.org/2277563002
Cr-Commit-Position: refs/heads/master@{#414655}

Spec: https://svgwg.org/svg2-draft/types.html#InterfaceSVGElement

BUG=636108

Review-Url: https://codereview.chromium.org/2231053003
Cr-Commit-Position: refs/heads/master@{#414654}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/c6931f815555..23c1b4a4e779

$ git log c6931f815..23c1b4a4e --date=short --no-merges --format='%ad %ae %s'
2016-08-25 eakuefner [TBMv2] Make the JS impl of MreResult a class
2016-08-25 eakuefner [TBMv2] Remove custom value set view support

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2283583002
Cr-Commit-Position: refs/heads/master@{#414653}

BUG=641220,613883

TBR=nparker@chromium.org
NOPRESUBMIT=true
NOTRY=true

Committed: https://crrev.com/ade822e48b63a78dbe5b812702f74fe831bd6a5c
Review-Url: https://codereview.chromium.org/2272793009
Cr-Original-Commit-Position: refs/heads/master@{#414637}
Cr-Commit-Position: refs/heads/master@{#414652}

Revert of Permission Action Reporting: Fix upload url. (patchset #1 id:1 of https://codereview.chromium.org/2272793009/ )

Reason for revert:
PermissionReporterTest.SendReport started failing on many bots after this CL:

https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/29240

Original issue's description:
> Permission Action Reporting: Fix upload url.
>
> BUG=641220,613883
>
> TBR=nparker@chromium.org
> NOPRESUBMIT=true
> NOTRY=true
>
> Committed: https://crrev.com/ade822e48b63a78dbe5b812702f74fe831bd6a5c
> Cr-Commit-Position: refs/heads/master@{#414637}

TBR=nparker@chromium.org,kcarattini@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=641220,613883

Review-Url: https://codereview.chromium.org/2279153002
Cr-Commit-Position: refs/heads/master@{#414651}

BUG=616112
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2273273003
Cr-Commit-Position: refs/heads/master@{#414650}

Document::styleForElementIgnoringPendingStyleSheets() is wrongly using
parentNode(), where LayoutTreeBuilderTraversal::parent() should be used instead.

BUG=639776

Review-Url: https://codereview.chromium.org/2266353004
Cr-Commit-Position: refs/heads/master@{#414649}

BUG=633580

Review-Url: https://codereview.chromium.org/2273103003
Cr-Commit-Position: refs/heads/master@{#414648}

BUG=
TEST=webgl2_conformance
TBR=kbr@chromium.org
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2279043002
Cr-Commit-Position: refs/heads/master@{#414647}

We added a new sysroot in r414564 and reverted the change in
r414594, but we left the .gitignore entries in. I suspect
that this is keeping the sysroot directory from being cleaned
up, and the license checks are still failing.

TBR=thomasanderson@chromium.org, jianli@chromium.org, haraken@chromium.org
NOTRY=true
BUG=638394

Review-Url: https://codereview.chromium.org/2279143002
Cr-Commit-Position: refs/heads/master@{#414646}

Fix FOUC issue on Quick View by making img/audio/video initially be hidden and removing hidden on the event of resize.
This is a workaround until the root cause is fixed.

BUG=640525
TEST=manually tested by opening Quick View for audio, video and image files which were/weren't producing the FOUC issue before.

Review-Url: https://codereview.chromium.org/2274713006
Cr-Commit-Position: refs/heads/master@{#414645}

Currently, on Mac most of the tests in render_text_unittest.cc use
RenderText::CreateInstance to create their render text instance. Also, many
tests which would fail on Mac with RenderTextMac are not compiled on Mac. As a
result there is negligible test coverage for RenderTextHarfBuzz on Mac.

This CL uses parameterized tests to test both RenderTextMac and
RenderTextHarfBuzz on Mac. It does this by introducing three new test fixture
classes which support parameterized tests-
-RenderTextTest
-RenderTextHarfBuzzTest
-RenderTextMacTest
The test helper class RenderTextAllBackends is removed.

Before this CL, 65 tests in render_text_unittest.cc are run on Mac. After this
CL, a total of 129 tests in render_text_unittest.cc are run on Mac.

BUG=639194

Review-Url: https://codereview.chromium.org/2251893004
Cr-Commit-Position: refs/heads/master@{#414644}

R=tsergeant@chromium.org
BUG=640893
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2284463002
Cr-Commit-Position: refs/heads/master@{#414643}

Cr-Commit-Position: refs/heads/master@{#414642}

This includes UI NQE, //components/data_reduction_proxy/, and
spdy_proxy. Implicitly, this includes //components/previews as well.

BUG=

TBR=caitkp@chromium.org

Review-Url: https://codereview.chromium.org/2265223002
Cr-Commit-Position: refs/heads/master@{#414641}

The main resource requests which the content_unittests were making using
mojo were failing in RDHI because the renderer is not supposed to make
main resource requests with PlzNavigate. Worked around this by setting
the process type to PROCESS_TYPE_UNKNOWN in ResourceMessageFilter for
these unittests and added a check in the related code to only enforce
these checks for PROCESS_TYPE_RENDERER.

The other change was in the TestURLLoaderClient methods which run the
message loop waiting for states like response received, body received etc.
For some reason, with PlzNavigate enabled the response for the body
arrives immediately following the header response causing the next wait to
just block. The fixes were to see if already have a response_body_ in the
TestURLLoaderClient::RunUntilResponseBodyArrived method and return
immediately and a similar check in TestURLLoaderClient::RunUntilComplete()

BUG=439423

Review-Url: https://codereview.chromium.org/2283473002
Cr-Commit-Position: refs/heads/master@{#414640}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/eedef30a4151..c6931f815555

$ git log eedef30a4..c6931f815 --date=short --no-merges --format='%ad %ae %s'
2016-08-25 fmeawad v8CallStats: Fix count summarization
2016-08-25 ccraik Complain about missing adb
2016-08-25 ccraik Use devil to get device list

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2279983002
Cr-Commit-Position: refs/heads/master@{#414639}

BUG=615123
TEST=
1. Go to the following URLs in different tabs:
   http://ianfette.org
   http://parkerly.com/sb-tests/bad-subresources.html
   https://parkerly.com/sb-tests/bad-subresources.html
2. Click through the warnings that appear
3. Verify that the omnibox security indicator shows a red triangle

Review-Url: https://codereview.chromium.org/2270283002
Cr-Commit-Position: refs/heads/master@{#414638}

BUG=641220,613883

TBR=nparker@chromium.org
NOPRESUBMIT=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2272793009
Cr-Commit-Position: refs/heads/master@{#414637}

BUG=638744
TBR=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2279963002
Cr-Commit-Position: refs/heads/master@{#414636}

This patch adds a call to USBDEVFS_DISCARDURB when we time out a USB
transfer. This causes the host controller to stop polling the device for
data and means that a later transfer will receive the next bytes that
are sent from the device. Otherwise those bytes will be claimed by the
cancelled transfer and discarded.

BUG=640725

Review-Url: https://codereview.chromium.org/2274343002
Cr-Commit-Position: refs/heads/master@{#414635}

If PreferHtmlOverPlugins feature is enabled, map the obsolete ASK setting to DETECT_IMPORTANT_CONTENT.

More info about Html5 by Default here: go/hbd-design-doc

BUG=626728

Review-Url: https://codereview.chromium.org/2264583003
Cr-Commit-Position: refs/heads/master@{#414634}

Revert of Make calling SetHeader() with invalid value fatal (patchset #1 id:1 of https://codereview.chromium.org/2143903002/ )

Reason for revert:
This CL has served its purpose of finding bad callers of SetHeader() and should be reverted before the branch point.

Original issue's description:
> Make calling SetHeader() with invalid value fatal
>
> crrev.com/2134083003 made net::HttpUtil::IsValidHeaderValue() reject
> individual CR and NL as well as CRNL.
>
> I believe that all callers of net::HttpRequestHeaders::SetHeader() and
> SetHeaderIfMissing() which use user-supplied values already verify the
> value with IsValidHeaderValue() first. However, to be sure, temporarily
> make it a fatal error to call SetHeader() with an invalid value.
>
> If you see a crash attributed to this CL:
>
> 1. Associate it with the bug.
> 2. Follow the stack flow to work out how untrusted data ended up
> being passed to SetHeader().
> 3. Add a call to IsValidHeaderValue() at the point where the untrusted
> data was introduced. A tighter check such as IsToken() may be appopriate.
>
> BUG=627398
>
> Committed: https://crrev.com/c5c1a790acc423f359c22641ac2ab0f3f9e6d7a9
> Cr-Commit-Position: refs/heads/master@{#405702}

R=mmenke@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=627398

Review-Url: https://codereview.chromium.org/2268423004
Cr-Commit-Position: refs/heads/master@{#414633}

TBR=waffles
BUG=615187

Review-Url: https://codereview.chromium.org/2286483002
Cr-Commit-Position: refs/heads/master@{#414632}

Most of the fields in CastSysInfoDummy will have format
dummy.field_name. This will allow run widevine cdm testing code in
desktop build.

BUG=internal b/27699230
TEST=Run widevine testing code

Review-Url: https://codereview.chromium.org/2066743004
Cr-Commit-Position: refs/heads/master@{#414631}

BUG=640133
TEST=manually

Review-Url: https://codereview.chromium.org/2285533002
Cr-Commit-Position: refs/heads/master@{#414630}

The function eglCreateImageKHR() seems to fail on this GPU
for L8 textures which results in YUV->RGB conversion failures.
EGLImage is used for Spitzer in WebView.

BUG=632461
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2281663002
Cr-Commit-Position: refs/heads/master@{#414629}

This moved from policy/proto to components/policy/proto in https://codereview.chromium.org/2273783002 and this updates the Python server code to unbreak the test.

TBR=jianli@chromium.org

Review-Url: https://codereview.chromium.org/2286473003
Cr-Commit-Position: refs/heads/master@{#414628}

BUG=613883

Review-Url: https://codereview.chromium.org/2269863002
Cr-Commit-Position: refs/heads/master@{#414627}