- 06 Jun, 2018 40 commits
-
-
Alexander Potapenko authored
This reverts commit eb29c355. Reason for revert: broke CrOS MSan bots: crbug.com/850020 BUG=850020 Original change's description: > [VK] Change KeyboardController::GetInstance to never return null. > > Currently, KeyboardController::GetInstance returns null if the keyboard > is disabled. This patch changes it so that |GetInstance| always returns > a valid KeyboardController. > > However, existing code determines whether the keyboard is enabled by > checking whether KeyboardController is null or not. With this patch, > KeyboardController will never be null. So we have to replace the null > checks with calls to KeyboardController::enabled(). In some cases, > calls to KeyboardController::enabled() can be omitted, but we leave > that to a future patch for easier review. > > Bug: 731537 > Change-Id: Ica487e69bae0a589d79c726f131611f0bf934672 > Reviewed-on: https://chromium-review.googlesource.com/1032230 > Commit-Queue: Darren Shen <shend@chromium.org> > Reviewed-by: Yusuke Sato <yusukes@chromium.org> > Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Cr-Commit-Position: refs/heads/master@{#564779} TBR=jamescook@chromium.org,yusukes@chromium.org,sky@chromium.org,yhanada@chromium.org,shend@chromium.org Change-Id: I6bf00360e30529ae5f3a1ac4d8a70efbb169e958 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 731537 Reviewed-on: https://chromium-review.googlesource.com/1088567Reviewed-by:
Alexander Potapenko <glider@chromium.org> Commit-Queue: Alexander Potapenko <glider@chromium.org> Cr-Commit-Position: refs/heads/master@{#564842}
-
Gyuyoung Kim authored
FMP signal has sometimes been used for dismissing a splash screen in some downstream Web Application platforms. But, FMP signal couldn't occasionally be generated or happened a little bit late, then it could cause that the splash screen dismissed a little bit late in the Web Application platforms. This CL is to export FirstMeaningfulPaintCandidate() in order to be used when FirstMeaningfulPaint() doesn't work or generates a signal a little bit late. Bug: 848639 Test: Covered by FirstMeaningfulPaintDetectorTest.FirstMeaningfulPaintCandidate Change-Id: I492d98ef4998e772d293f81b9991a066cb346233 Reviewed-on: https://chromium-review.googlesource.com/1080499Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> Cr-Commit-Position: refs/heads/master@{#564841}
-
Yoichi Osato authored
This patch rebases editing/selection/paint-hyphen.html image expectation. On NG, we don't paint block end hyphen. That's reasonable because no following word after that. Plus, this follows Edge and Firefox. Bug: 708452 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I976691f32be99283b526b1daf2dbfbe893fbfd4f Reviewed-on: https://chromium-review.googlesource.com/1088465Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#564840}
-
Yoshifumi Inoue authored
This patch changes |EndOfWordPosition()| to utilize |TextSegments| class to make |EndOfWordPosition()| to work with LayoutNG. This patch also changes |GranularityAdjuster| to handle end of word position in flat tree mapped before start of word position in DOM tree. This patch changes following test expectations: * third_party/WebKit/LayoutTests/fast/text/international/cjk-segmentation.html |TextSegments| provides more context characters to ICU word breaker. * VisibleSelectionTest.expandUsingGranularity * ParameterizedVisibleUnitsWordTest.EndOfWordShadowDOM Due by |PositionInFlatTree| to |Position| conversion. Bug: 778507, 810579 Change-Id: Ie888f8b76e00386bc728a5c647aecf8f33ef7b6e Reviewed-on: https://chromium-review.googlesource.com/1086811Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#564839}
-
Marcin Wiacek authored
Change-Id: Id1e7002a475c43e23abb78f0292709385eaa0356 Reviewed-on: https://chromium-review.googlesource.com/1087907Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Cr-Commit-Position: refs/heads/master@{#564838}
-
Rayan Kanso authored
The WebApp Manifest spec defines the ImageResource dictionary to represent icon. https://w3c.github.io/manifest/#dom-imageresource This CL changes references to ManifestIcon in blink and mojo to ManifestImageResource. TBR=ortuno@chromium.org Bug: 817445 Change-Id: I75783f8fe1f86edb672a97f6d762f713584b88c9 Reviewed-on: https://chromium-review.googlesource.com/1080794 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#564837}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ff6ae37..6be71e7 git log ff6ae37..6be71e7 --date=short --no-merges --format='%ad %ae %s' 2018-06-06 dgarrett@google.com scheduler_stages: Use --buildbot for all slaves. Created with: gclient setdep -r src/third_party/chromite@6be71e7 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:834076 TBR=chrome-os-gardeners@chromium.org Change-Id: I6ab2ebd812e38b388e484d957c1ee595882872f2 Reviewed-on: https://chromium-review.googlesource.com/1088195Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#564836}
-
Kunihiko Sakamoto authored
This patch (temporarily) disables Signed Exchange when Network Service feature is enabled, since cert and CT verification we currently use (via URLRequestContext) is not wired up in the Network Service code path. If Network Service feature is enabled, WebPackageLoader will fail with ERR_INVALID_SIGNED_EXCHANGE and warning message will be shown on devtools. WebPackageRequestHandlerBrowserTest tests this behavior. Layout tests with network service are disabled for now. Bug: 849935 Change-Id: Ic72f9af4d68f55d8557ea0c631020ed871408a70 Reviewed-on: https://chromium-review.googlesource.com/1088270Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#564835}
-
Vaclav Brozek authored
This CL replaces a redundant type mention with 'auto' in form_parser.cc makes the use of trailing ',' consistent and removes unnecessary {} from form_parser_unittest.cc. Bug: 845426 Change-Id: I292af1e436d9b7e98880b3392f0232d88a81e84b Reviewed-on: https://chromium-review.googlesource.com/1087267Reviewed-by:Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#564834}
-
Sylvain Defresne authored
With https://crrev.com/c/1070158, base::Bind() supports block so convert uses of base::BindBlockArc() to instead use base::BindOnce() or base::BindRepeating(). Bug: 701275 Change-Id: Ib251d93328858adfee6ccaddafebaa91124a8a24 Reviewed-on: https://chromium-review.googlesource.com/1087060Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#564833}
-
François Beaufort authored
Picture-in-Picture Origin Trial has been cancelled due to multiple risk factors incl. surface layer memory regressions which require investigating, as well as PiP related issues (crashes, resizing, etc.). Bug: 806249 Change-Id: I35d06042e949b6e931e16799ca7abb6f0ff36bfa Reviewed-on: https://chromium-review.googlesource.com/1084451Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#564832}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I0cb4d772c1b45afa092121d0414de239254fa95d Reviewed-on: https://chromium-review.googlesource.com/1088322Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#564831}
-
Arthur Sonzogni authored
Bug: 816646 Change-Id: I76f84ba670a69a7e599d43b3dcd0eddde43578fa Reviewed-on: https://chromium-review.googlesource.com/1082397Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#564830}
-
Hajime Hoshi authored
Always use GetExecutionContext() instead of event targets in EventQueueImpl and MediaElementEventQueue This is a preparation for merging EventQueueImpl and MediaElementEventQueue. This CL resuces the dependencies on usages of |event->target()|. Design Doc: https://docs.google.com/document/d/1BBtBPTarOF4NeVKSWZe3XaDHo4yTGhdlqYm35yVzPs4/edit# Bug: 846618 Change-Id: Ib17a49226ea24a33b053f31a70ae3fe050dccb36 Reviewed-on: https://chromium-review.googlesource.com/1088356Reviewed-by:
-
Olivier Robin authored
This reverts commit 5316b1cb. Reason for revert: breaking ios_chrome_settings_egtests Original change's description: > [ios] Hook up remote tabs in tab grid > > This CL hooks up the remote tabs in the tab grid. > > A user can sign in from the remote tabs page in the tab grid. The > transition animation that displays the signin interaction controller > looks bad (and we are investigating the cause). If the user is signed > in but does not have sync enabled, the user can enable sync from here. > > Currently, tapping on a tab does nothing. This will be enabled in a > future CL. > > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: Ifba06919e1fb496917254a0da7e5462a4b854d79 > Reviewed-on: https://chromium-review.googlesource.com/1084080 > Commit-Queue: edchin <edchin@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Reviewed-by: Sergio Collazos <sczs@chromium.org> > Reviewed-by: edchin <edchin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#564684} TBR=rohitrao@chromium.org,eugenebut@chromium.org,edchin@chromium.org,sczs@chromium.org,javierrobles@chromium.org Change-Id: Idc0b0b2def356a173949298bc7f560ee4dad3744 No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1088566Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#564828}
-
Marcin Wiacek authored
1. Open "Page Info" screen for HTTPS site 2. Click on "Details" link 3. Click on "Certificate information" link Without patch: fast clicking on link from point 3 can result in opening Certificate Viewer few times. With patch: Certificate Viewer is showed once. Change-Id: I3fd98b2e9d3be76c2743e47a2ab1e3c86e45abea Reviewed-on: https://chromium-review.googlesource.com/1070202Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Cr-Commit-Position: refs/heads/master@{#564827}
-
Manuel Rego Casasnovas authored
Text form the spec (https://drafts.csswg.org/css-contain/#containment-layout): "If the contents of the element overflow the element, they must be treated as ink overflow." The patch modifies LayoutBox::LayoutOverflowRectForPropagation() so the overflowing contents of an element with "contain: layout" are treated as ink overflow. That way they don't interfere at all in the layout of its ancestors. BUG=843320 TEST=external/wpt/css/css-contain/contain-layout-015.html Change-Id: Iedd47edf46a0e4ce0e4102abe5881d25771fe0fa Reviewed-on: https://chromium-review.googlesource.com/1087462Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#564826}
-
Mohamed Amir Yosef authored
Bug: 516866 Change-Id: Iceaaeee84acd899c63936f6a864c48f7cf1a45df Reviewed-on: https://chromium-review.googlesource.com/1087956Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#564825}
-
Yoichi Osato authored
This patch rebases image failures that NG paints 1px taller than old. This is by-product but got lgtm at the previous patch: crrev.com/c/1080442 ([LayoutNG] Fill selection paint line gap.) Bug: 708452 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I26ab17747655017be2750355ab5c23708398fa40 Reviewed-on: https://chromium-review.googlesource.com/1086671 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#564824}
-
Yuki Shiino authored
As a preparation to move DOMException's exception code into platform/, this patch decouples the definition of exception code from the implementation of DOMException class (especially data table). Also makes the value of exception code match the legacy error code of DOMException defined in Web IDL. Bug: 849607 Change-Id: I3044c1ebac8ddb344b3c1d380a08482c57225b30 Reviewed-on: https://chromium-review.googlesource.com/1086955Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
-
Yoichi Osato authored
This patch make the layout test contenteditable to reduce NG failure. Bug: 679977, 708452 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Iafc1d315fe9b3b88b66bf68a46939c98bda25409 Reviewed-on: https://chromium-review.googlesource.com/1086891Reviewed-by:
-
Christian Dullweber authored
When site data is removed, persistent quota gets resetted to zero. Instead of keeping the origin in the database, we should just delete it to remove traces of browsing_data. Bug: 849677 Change-Id: Ice2282274012fe8d2cb65bbac0b328523e8ce666 Reviewed-on: https://chromium-review.googlesource.com/1087057Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#564821}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2d16b804. With Chromium commits locally applied on WPT: e8832df8 "webrtc wpt: remove test_state_change_event" bf5d61ae "Make fetch-event.https.html faster." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/19108 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org: external/wpt/css/css-scoping TBR=foolip No-Export: true Change-Id: Ice0d22c5e9582452b7017142246036f31d511fc0 Reviewed-on: https://chromium-review.googlesource.com/1088190 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#564820}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/9861a71..ba9d017 git log 9861a71..ba9d017 --date=short --no-merges --format='%ad %ae %s' 2018-06-06 nednguyen@google.com Add deprecation message for grouping_keys Created with: gclient setdep -r src/third_party/catapult@ba9d017 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:849363 TBR=sullivan@chromium.org Change-Id: I5f393ee53d460a1081b727dc6bfc276643f2a553 Reviewed-on: https://chromium-review.googlesource.com/1088252Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#564819}
-
Dominic Mazzoni authored
Refactor the messages used to communicate accessibility events from (1) the renderer to the browser, (2) from in content to outside of content, and (3) from the browser to the automation extension API. All three message structs are distinct, but previously each accessibility message consisted of one or more structs consisting of one AXTreeUpdate and one accessibility event (a few fields like type and id). Refactor all of these to a single struct consisting of (1) zero or more AXTreeUpdates, followed by (2) zero or more AXEvents, where AXEvent is a new struct that bundles together the common information needed about an event like its type and its target ID. See the design doc linked from the bug for additional motivation behind this refactoring. Bug: 848043 Change-Id: I6f5c743bcb79f8fe69453a7d1f9d24e515bbf123 Reviewed-on: https://chromium-review.googlesource.com/1080992Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/844791e..ff6ae37 git log 844791e..ff6ae37 --date=short --no-merges --format='%ad %ae %s' 2018-06-06 yunlian@google.com filter -Wl,-plugin-opt,-import-instr-limit= for simple chrome. Created with: gclient setdep -r src/third_party/chromite@ff6ae37 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=chrome-os-gardeners@chromium.org Change-Id: I3a8d944f734395a6ebfe678b9dac72775f04d821 Reviewed-on: https://chromium-review.googlesource.com/1088251Reviewed-by:
-
Yutaka Hirano authored
Bug: 721400 Change-Id: I033be720b2b1deb69ddb70cdd25a76087935423f Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1084809Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#564816}
-
Christian Biesinger authored
This is sort of a followup to https://chromium-review.googlesource.com/c/chromium/src/+/1084989, which added this call to a different location. R=mstensho@chromium.org Bug: 847807 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I7e59f26b1d20615ae8ae4c8099991164533a6c21 Reviewed-on: https://chromium-review.googlesource.com/1087586 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
-
Peter Qiu authored
Currently, when ui::mojo::Gpu interface is exposed by the Browser process (kMash feature is not enabled), only the binding requests from the Renderer processes are being handled. For certain devices and applications, it is desirable to access the ui::mojo::Gpu interface from a non-Renderer process, in order for that process to access video encode/decode accelerators hosted in the GPU process. This CL will allow other processes to bind to ui::mojom::Gpu interface hosted by the Browser process (assuming allowed by the manifest), by also handling ui::mojom::Gpu interface binding requests in CommonBrowserInterface. The handling for ui::mojom::Gpu interface binding requests from Renderer processes will stay the same. Bug: 836874 Test: run content_browsertests Change-Id: Ib1e3751d8c593a3c8d29096e7dc9cc609f6a1fa4 Reviewed-on: https://chromium-review.googlesource.com/1028556Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Peter Qiu <zqiu@chromium.org> Cr-Commit-Position: refs/heads/master@{#564814}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7d43296..79725d3 git log 7d43296..79725d3 --date=short --no-merges --format='%ad %ae %s' 2018-06-06 fmalita@chromium.org [skottie] Add a tool for dumping encoded animation frames Created with: gclient setdep -r src/third_party/skia@79725d3 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=halcanary@chromium.org Change-Id: Ib989a9e93c188395fc69eb0185fc4137dc35b24a Reviewed-on: https://chromium-review.googlesource.com/1088248Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#564813}
-
Ramin Halavati authored
ExtensionFunction::include_incognito() is renamed to ExtensionFunction::include_incognito_information() to provide more clarity on the use cases. Bug: 845845 Change-Id: I0ba7bf58faf763a2ca8a50bf15f4c82e75ea82a0 Reviewed-on: https://chromium-review.googlesource.com/1078810 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#564812}
-
Hiroki Nakagawa authored
Referrer handling spans multiple algorithms in multiple specs, so I leave only the entry points of them. For top-level module script loading and static imports, referrer is determined based on the "outside settings": "Fetch a module worker script graph given url, outside settings, destination, the value of the credentials member of options, and inside settings." https://html.spec.whatwg.org/multipage/workers.html#worker-processing-model For dynamic imports, referrer is determined based on the "referencing script's settings object". In this case, it's "inside settings": Step 2.4: "Fetch a module script graph given url, referencing script's settings object, "script", and options. Wait until the algorithm asynchronously completes with result." https://html.spec.whatwg.org/multipage/webappapis.html#hostimportmoduledynamically(referencingscriptormodule,-specifier,-promisecapability) These tests are still failing. Subsequent CLs will fix them. Bug: 842553 Change-Id: I3855b91c7e6ba93f5c99fb63b24b6274e6b43211 Reviewed-on: https://chromium-review.googlesource.com/1088339 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#564811}
-
Hajime Hoshi authored
When the ExecutionContext is destroyed in an event queue, the event queue should no longer be available. Then it must delete all the queued events and close itself. Design Doc: https://docs.google.com/document/d/1BBtBPTarOF4NeVKSWZe3XaDHo4yTGhdlqYm35yVzPs4/edit# Bug: 846618 Change-Id: I2de831956238bc2e783e9c8c2eadc56f75f3faaf Reviewed-on: https://chromium-review.googlesource.com/1088341Reviewed-by:
-
Koji Ishii authored
From a manual review of build 6212. * Images match, and text dumps match after known normalizations: compositing/self-painting-layers.html fast/forms/control-clip-overflow.html ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling.htm virtual/video-surface-layer/media/video-display-toggle.html virtual/video-surface-layer/media/video-transformed.html * No images but text dumps match after known normalizations: printing/single-line-must-not-be-split-into-two-pages.html * Images match. Has additional anonymous LayoutBlockFlow: compositing/overflow/scroll-ancestor-update.html * Images match. NG does not create a text run for a space-only run in some cases due to different way to collapse whitespaces. css3/filters/effect-brightness-clamping.html css3/filters/effect-brightness.html fast/css/resize-corner-tracking.html images/feature-policy-max-downscaling-image-resize.html images/feature-policy-max-downscaling-image-styles.html images/feature-policy-max-downscaling-image.html * Console message differ. plugins/iframe-plugin-bgcolor.html * The height of culled inline box differ. transforms/3d/general/perspective-non-layer.html * Space differences in non text-dumps: images/color-profile-munsell-adobe-to-srgb.html http/tests/devtools/device-orientation-success.js TBR=atotic@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I72b3e82c3a7713fb330ef44e015d9113b24f86e4 Reviewed-on: https://chromium-review.googlesource.com/1088340Reviewed-by:
-
Allen Vicencio authored
This adds the metrics for the errors received during a failure in Remount in Native SMB File Share Bug: 757625 Change-Id: Ibb63eda818b0de190526b26e79a87288a13b67db Reviewed-on: https://chromium-review.googlesource.com/1080209 Commit-Queue: Allen Vicencio <allenvic@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#564808}
-
François Beaufort authored
This makes sure clicking the native Picture-in-Picture button (after entering Picture-in-Picture) exits Picture-in-Picture and that video controls are reflected when entering and exiting Picture-in-Picture. Screenshot: https://i.imgur.com/081Xbmb.png Bug: 840516, 806249 Change-Id: I410a4a06cc4eea62dae8e1d368e4d05394f13c86 Reviewed-on: https://chromium-review.googlesource.com/1084833 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#564807}
-
Joel Hockey authored
Currently async tests end up timing out when they call assert but don't catch the resulting exception and call done(true). It seems more natural that when an async test has an assertion failure, that the harness should catch the exception and take care of continuing tests. The alternative that async tests should catch there own errors has the drawback that specific errors are not ever reported. E.g. code below is bad. testAsync(done) { try { assertEquals('foo', 'bar', 'foo should match bar'); done(); } catch (err) { done(true) } } Bug: 813477 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Idbc88f94f6055eec37ab0d90b4b8d423fba6eb3f Reviewed-on: https://chromium-review.googlesource.com/1088327Reviewed-by:Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#564806}
-
Hiroki Nakagawa authored
See the issue for details. Bug: 849975 Change-Id: If597bdb282a3f50b7f9f36d1e9970ae7eae27271 Notry: true TBR: nhiroki@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1088347 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/36d4a47..9861a71 git log 36d4a47..9861a71 --date=short --no-merges --format='%ad %ae %s' 2018-06-05 sadrul@chromium.org tabs: Switch back to async trace events. Created with: gclient setdep -r src/third_party/catapult@9861a71 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:849182 TBR=sullivan@chromium.org Change-Id: Id29f0c07a689efcbb900a4d9f0b54d2267602f51 Reviewed-on: https://chromium-review.googlesource.com/1088247Reviewed-by:
-
Caleb Rouleau authored
Bug: chromedriver:2446 Change-Id: I63cfdc367af8cdbfc7f116fb51a3e3148ee0a950 Reviewed-on: https://chromium-review.googlesource.com/1087803 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#564803}
-
