GitLab

When LayoutNGListItem::OrdinalValueChanged() is called on an ":after"
list item element, |marker_| is a nullptr.

Similar to LayoutNGListItem::ListStyleTypeChanged(), we need to check
that |marker_| is not nullptr before invalidation to avoid
null-dereferences in this case.

Bug: 1020669
Change-Id: I66913cde0420a3612e881dab9e44a006c276ec64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902666
Commit-Queue: Alison Maher <almaher@microsoft.com>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713894}

Range [111000000, 111999999] is reserved for Chime job scheduler.

Bug: 1013386
Change-Id: Ia211cf20adc4580bcdbb6fcc3303dc0fd4367c4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904947Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713893}

Updates WindowTransformToHomeScreenAnimation to use

window_util::HideAndMaybeMinimizeWithoutAnimation().

Change-Id: I3cb191d72a351bf6dd700857b85d2b0775aa4bf1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905268Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713892}

Work around an Installer.app bug.

Bug: 1022413
Change-Id: I4eab147d15bcae44f1d0fc6a4e4da9ac78a34772
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904688
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Auto-Submit: Avi Drissman <avi@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713891}

The post_build_ninja_summary.py uses "weighted time" as one of its key
measures to summarize build performance but this is only documented in a
comment in the script itself. This adds documentation to the page that
recommends using this script for build-speed investigations (chiefly
through set NINJA_SUMMARIZE_BUILD=1).

This also updates the example output to say elapsed time instead of the
inaccurate term CPU time.

Change-Id: I148df429722a33f70123d9f3076b1b7e5e6cb347
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902113Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713890}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1917f7a09940..d5c0b56e84e0

git log 1917f7a09940..d5c0b56e84e0 --date=short --no-merges --format='%ad %ae %s'
2019-11-08 danakj@chromium.org Use git fetch --no-tags to fetch commits to apply via cherry-pick.

Created with:
  gclient setdep -r src/third_party/depot_tools@d5c0b56e84e0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=agable@chromium.org

Bug: chromium:1019824
Change-Id: I82a2b944fd99329515f04e978c11cd5310ed3335
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906868Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#713889}

TBR=lazyboy@chromium.org

Bug: 1003244
Change-Id: I88bfd3e89650a53fb6701685fa317f6cd6100f67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906946Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713888}

Bug: 987646
Change-Id: Ie3ad81dddbd70f63f5ee1a251490913224bcb8ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898514
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713887}

It seems like maybe this was just overlooked? The fix is as easy as
adding it to the idl file.

It seems like this is already in the spec as:
https://html.spec.whatwg.org/multipage/canvas.html#offscreencanvasrenderingcontext2d
contains the line
OffscreenCanvasRenderingContext2D includes CanvasTransform;
And https://html.spec.whatwg.org/multipage/canvas.html#canvastransform lists the
getTransform() function.

Bug: 1016454
Change-Id: Icb5405d716524e2a0b6935db81b18ff53cd31d4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872562Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Juanmi Huertas <juanmihd@chromium.org>
Commit-Queue: Aaron Krajeski <aaronhk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713886}

Bug: 1020386
Change-Id: Ife52a8257203b980492d77f4290b4bf1802f8c81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902229
Commit-Queue: Ana Salazar <anasalazar@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Manu Cornet <manucornet@chromium.org>
Reviewed-by: Andrew Xu <andrewxu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713885}

Bug: 723854
Change-Id: I6cb7a4c60dd458c76d59019175c04984e0b75abc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904757Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Commit-Queue: John Wu <jzw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713884}

This reverts commit 0d929861.

Reason for revert: Breaks UBSAN builds (crbug.com/1022818).

Original change's description:
> perfetto: Use TraceProcessor for proto2json conversion
> 
> TraceProcessor replaces the existing (unmaintainable) proto2json
> converter and adds features like combining of BEGIN/END events
> and support for heap profiles.
> 
> Also updates a devtools test that was expecting separate begin/end
> events where TraceProcessor now combines them into a complete event.
> 
> We have reduced the trace procesor's binary size overhead
> by selectively excluding features Chrome doesn't need from >400kB to
> ~50kB. We could probably save a couple more kB if we invest even more
> eng time and accept the maintenance burden for this in trace processor,
> however, we feel that we've reached an acceptable state that balances
> binary size & code health.
> 
> Binary-Size: see paragraph above.
> Bug: 1006770
> Change-Id: Ia7f6b3a784c1a9c40574e1dcd80eca1ca2dfb03f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746258
> Commit-Queue: Eric Seckler <eseckler@chromium.org>
> Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
> Reviewed-by: oysteine <oysteine@chromium.org>
> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#713593}

TBR=caseq@chromium.org,oysteine@chromium.org,skyostil@chromium.org,eseckler@chromium.org

Change-Id: Icc6bd802248c59d82d9697caaaae65a98f0487cd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1006770, 1022818
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907006Reviewed-by: Eric Seckler <eseckler@chromium.org>
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713883}

This is a followup to crrev.com/c/1796047

This patch changes AXPosition::CreateNext/PreviousCharacterPosition
so that it can also accept the BoundaryBehavior::StopIfAlreadyAtBoundary.
This is necessary to be able to support navigating through characters
that are not in the basic multilingual plain when using IAccessible2 and ATK.
If a client calls e.g. IAccessibleText::get_CharacterAtOffset and the provided offset is
in the middle of a multi-byte character, both the start and end offsets need to be
adjusted. We can't always assume that only the end offset would need to be changed in order to
cover the range that a particular character occupies.

R=dmazzoni@chromium.org, kbabbitt@microsoft.com

Bug: 720370
Change-Id: I1ce87325da2479b9d8d7085adae8aac41f79f294
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888540
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713882}

It is possible for window objects in <webview> tags to have
window.opener relationships.  In particular, one <webview> can use
window.open('', 'foo') to look up another <webview> which has
window.name equal to 'foo', and update its window.opener to point to
itself.  This triggers an UpdateOpener IPC, which ensures that the new
opener chain has proper proxies so that 'foo' is able to reach any
frame on that chain (see RenderFrameHostManager::DidChangeOpener).

Unfortunately, this had a bug because the proxy creation also tried to
create proxies for the outer delegate (i.e., the chrome app)
SiteInstance, for all frames on the new opener chain, including
subframes.  This is wrong because we intentionally do not want to
expose a guest's subframes to the embedder -- see
RenderFrameHostManager::CreateProxiesForChildFrame(), which
intentionally skips the outer delegate's proxy.  In this case, this
later led to a crash in CreateRenderFrameProxy(), because the proxy we
tried to create for a subframe didn't have a RenderViewHost (which is
intentional -- we do not create a RVH for the outer delegate's
SiteInstance, just the proxy, and only for the guest's main frame).

This CL fixes this by ensuring that we skip the outer delegate
SiteInstance when creating proxies for subframes in
CreateProxiesForSiteInstance(), which is used when updating the opener
chain as well as more generically (e.g., when creating speculative
RenderFrameHosts).  This hopefully will better protect against this
type of bug in the future compared to a more targeted fix in
opener update logic (e.g., if/when we add OOPIF support in
GuestViews).

Change-Id: I6a2e452883faa140a86523b2afda372c62cbdbcb
Bug: 1013553
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903245Reviewed-by: James MacLean <wjmaclean@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713881}

Pre-finalizers are heavy and not supposed to be used on short-living small
objects. Spend an additional word to store the header on registration. This
allows inspecting liveness without going through a call on every garbage
collection.

Bug: 982754
Change-Id: I30a2d60198dd6b2b49febcd49983d17175874dad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904177
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Omer Katz <omerkatz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713880}

On being asked to review
https://chromium-review.googlesource.com/c/chromium/src/+/1732329/30#message-bf7d81a19611d7d93e129ac9921dbea9f690ae3e
I realized I'm not too up-to-date on the latest Chromium styles, so I
should probably remove myself here.

Removed cpu@ too, as I don't think he's active here any more.

Change-Id: I7bdfa937384c931dbb6d6b5f52d0fefb76296864
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906253Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713879}

- Turn on kAutofillNoLocalSaveOnUploadSuccess so that uploading a card
  does not create a local only copy.
- Turn on kAutofillNoLocalSaveOnUnmaskSuccess so that unmasking a card
  does not save a full card locally.
- Remove ability to delete cards from Google Pay.
- Add menu item to go to payments website.

Change-Id: I009ab5b1671320f8eac0c10d7e3c0843a2139c6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904541Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Commit-Queue: John Wu <jzw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713878}

Change-Id: Ic6231566fbf929d263ce69dcf2437e7650d3d5fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904337Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Manu Cornet <manucornet@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713877}

Bug: 999737, 706728
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780074
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Auto-Submit: Wez <wez@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#712377}
Change-Id: I627b5250055233ea89718a9143de356c85633add
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905270
Cr-Commit-Position: refs/heads/master@{#713876}

- Do not call MSAARole() in InternalQueryInterface(). It calls GetParent(),
   which is dangerous here, because as JAWS responds to the destruction
   of a Window by releasing some objects, and that can lead to a QI by UI
   Automation -- However, BrowserAccessibility::GetParent() calls into
   the render frame host which is already destroyed.
   In any case we only need to get the role once here, and we can just
   use the internal role that is stored.
- Remove some duplicate conditions in
  BrowserAccessibilityComWin::InternalQueryInterface() that will be
  reached in the upcall to AXPlatformNodeWin::InternalQueryInterface()
- More consistency in IsImage() across renderer/browser, which allows url
  to be exposed in more situations.

Bug: 1012643
Change-Id: I51808cb0b578f5eceed58168d9ab77494ad65b21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903963
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713875}

Bug: 1022208
Test: Not necessasry.
Change-Id: I0a8c0a3b473fec93e13e68583dd0aea52d1c057e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906328Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Luke Sorenson <lasoren@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713874}

These are part of the 10.15 SDK but are not yet implemented or used
in this code.

Bug: 973128
Change-Id: I8b34aa764d9501323f97c9650f3e1555cfa89dd0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906332Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713873}

PLY has a feature where it'll load a generated lexer
table by importing it as a python module. It turns out
that we were being inconsistent in how we were generating
these modules and that could lead to incomplete builds depending
on when the various IDL compilation targets ran.

This CL attempts to be more consistent about the generation
of the cached files to eliminate that problem, by requiring
the scripts to consistently pass in the location of the cached
files. We can't really fix this without doing more serious
surgery on PLY (or working around it) to be more deterministic
in how the cached file is imported.

R=dcheng@chromium.org, haraken@chromium.org
BUG=1022647

Change-Id: I141059341634633f0df33848638eecc432aa764c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903938Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713872}

When creating a new subframe or WebContents with an initial empty
document, it inherits the last committed origin of the originating
frame. We now also set the Network Isolation Key (NIK) at the same time.

Certain subsequent requests are both same-document navigations and the
first to result in a call to RenderFrameHostImpl::CommitNavigation, e.g.
the last navigation of NavigationControllerBrowserTest.
BackAfterIframeDocumentWrite. Previously, requests in such a case could
be made without a valid NIK. We also add a DCHECK to ensure the NIK is
always set after the call to CommitNavigation.

Bug: 1014077
Change-Id: I33e3c223352d6f82fb7849b6be9ce6bd585b96fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872790
Commit-Queue: Alex Turner <alexmt@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Shivani Sharma <shivanisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713871}

compression_utils_portable

This allows client code to select the wrapper format used which may be
faster (e.g. zlib format on older ARMv7 and early ARMv8 SoCs) depending
on the application.

The wrapper format selection code was partially taken from
zlib_bench.cc.

Bug: 833361
Change-Id: I8a317e6abc8bd2d66f2e940406badfd7e930e809
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904505Reviewed-by: Adenilson Cavalcanti <cavalcantii@chromium.org>
Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713870}

This will help to discover bugs and incorrect Results Processor usage earlier.

Bug: 981349
Change-Id: Icd2ba7f2187166b452702681392417ab3ec8e6dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904168
Commit-Queue: Mikhail Khokhlov <khokhlov@google.com>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713869}

Bug: 1017341
Change-Id: I719f13dd45a75783dc919a0f74be996445951be6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875481Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Commit-Queue: Aran Gilman <gilmanmh@google.com>
Cr-Commit-Position: refs/heads/master@{#713868}

Change-Id: I47d8314c480b1a3e64a5f8ebb63c97c0af9bf516
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903759Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Aran Gilman <gilmanmh@google.com>
Cr-Commit-Position: refs/heads/master@{#713867}

Change-Id: Iecc102fca57b21132085671f43e597ae43263bab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904618
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713866}

BUG=5027

Change-Id: Iab491d8e238f49c981e026e07fde9de916af82f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904816
Auto-Submit: Robert Liao <robliao@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713865}

(Re)use EventTarget::EnqueueEvent rather than (re)implementing something
pretty much identical.

Bug: 998526
Change-Id: I79a8d84141e37f485c9b74ee6dc2e4afacda080a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906150
Auto-Submit: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713864}

This also allows us to replace base::Bind with base::BindOnce.

Bug: 1007798
Change-Id: Iab43f746e3c4507d9b9b7b82e6f58cedcd08faa9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904847Reviewed-by: Olga Sharonova <olka@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713863}

Enables OverviewWindowDragTest.NormalDrag and
ScreenRotationTest.RotateInTabletOverview back, as the use-after-free
because of which they were disable has been fixed.

Bug: 1021936
Change-Id: I431f8fe4fb1be1eb0f4c8816d9dcb91a42d41ee3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904160Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713862}

For go/split-settings-sync we want to defer sync of all OS types until
the user turned on the feature. Add a user profile pref that enables
the feature. Add ModelTypeControllers for OS preferences and printers
that observe the pref and use it to enable/disable the their sync via
preconditions.

The two ModelTypeControllers are very similar but are separate because
they have different superclasses. I think trying to create a mixin that
could be shared would be more complicated than just having each class
have a separate PrefChangeRegistrar.

For now the "feature enabled" pref is set via a placeholder toggle
button in the OS settings UI. A future CL will tie it to the sync
consent that appears in OOBE.

Bug: 1013466
Test: added to unit_tests
Change-Id: If4e24eea93a103f2cf5fada3771481a7ab843759
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904342Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713861}

Tested locally and didn't see the crash mentioned in crbug.com/545547.

Bug: 545547
Change-Id: I597c4ae170b3d5297a18472d3e4f1b7923856057
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897244Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713860}

This creates a policy engine that forwards calculated priority values
out of the graph, applying the priorities to RenderProcessHosts (and
subsequently to the process itself).

BUG=971272

Change-Id: I11c8c040e5382a8fa6881c40f80f6885f26e88df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904367
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713859}

This function has historically been opening a file for exclusive r/w/d
with FILE_ALL_ACCESS. FILE_ALL_ACCESS is nearly almost never, ever the
right choice when opening a file. This is especially true when opening a
file from an ordinary non-elevated user session, since it attempts to
gain things like WRITE_DAC and WRITE_OWNER and will fail if it's not
possible to gain those access rights.

A better way to determine if a file is "in use" (and what we really mean
is "is an executable that is running") is simply to try to write to
it. This is because CreateProcess opens its target with only exclusive
write mode (read and execute are shared for obvious reasons).

This change also eliminates the exact copy of this function, which
included the incorrect formatting from the original, that was used in
the unittest.

R=gab@chromium.org

BUG: 474401
Change-Id: I0488e2a5333f74353f46ae6c87795e2833a30b61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905948
Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
Reviewed-by: David Bienvenu <davidbienvenu@chromium.org>
Auto-Submit: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713858}

This cl removes an unnecessary break condition that prevented collection
for CreditCards.
The metrics recorder already supports recording non-password tabs (like
addresses) but this artifact prevented recording sheet triggering.

Bug: 926372
Change-Id: Ia4a92e06b2c21000ee61aa14a060bb4a521fc360
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905687Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713857}

This CL converts all ChromeOS code to use CoreAccountId instead of
std::string for the account id.

Bug: 959157
Change-Id: Ia27b9e566100ecd7c1ead3a5ca8e46da39e569ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906149Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713856}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/8c6f1f9af3f4..fc61fb037d2c

git log 8c6f1f9af3f4..fc61fb037d2c --date=short --no-merges --format='%ad %ae %s'
2019-11-08 dburger@chromium.org config: mark grunt-unittest-only not important.

Created with:
  gclient setdep -r src/third_party/chromite@fc61fb037d2c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: Ic9762f94cdd7cbbe558456837496a25508e5b30e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906290Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#713855}