- 27 Aug, 2018 40 commits
-
-
Robert Ogden authored
This removes the previews piece of verbose status triggering from the weird security checks that offline uses. Since the preview badge is shown under all cases expect when a bad SSL page is being shown, make the code reflect that. Bug: 871839 Change-Id: If14d110f23a90b36906df7d846c5c1a8ff957baa Reviewed-on: https://chromium-review.googlesource.com/1191027 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#586381}
-
Lei Zhang authored
Change-Id: I45224f299e5ac7fcff88241c7a5e0689603717cf Reviewed-on: https://chromium-review.googlesource.com/1189545Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#586380}
-
Charlie Harrison authored
Bug: 873316 Change-Id: I2d034ad8e7e272b487741eaa40f5318185caff6c Reviewed-on: https://chromium-review.googlesource.com/1190664 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#586379}
-
Simeon Anfinrud authored
The special properties of ObserverList were not needed because of how Controller uses a Sequencer to avoid concurrent modification. This also avoids heap allocation of iterators and the use of the O(n) memory Itertools.reverse() when closing scopes. Bug: None Test: cast_base_junit_tests Change-Id: I91ef516caf07de8b9a899c17b015f2e2838fee35 Reviewed-on: https://chromium-review.googlesource.com/1191087Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Simeon Anfinrud <sanfin@chromium.org> Cr-Commit-Position: refs/heads/master@{#586378}
-
Yao Xiao authored
Bug: 864194 Change-Id: I84311118bdfc6921875741fa6ba31ba38bcf1fb6 Reviewed-on: https://chromium-review.googlesource.com/1185217Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/master@{#586377}
-
Maks Orlovich authored
Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I305000589be2e48356c1c7168269edd83cf9a7ec Reviewed-on: https://chromium-review.googlesource.com/1191284Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#586376}
-
Victor Costan authored
On 32-bit Windows builds where DCHECK is enabled, ComInitCheckHook hot-patches CoCreateInstance() to DCHECK that it is called in appropriate circumstances. The hot-patching method can only be used once (details in base/win/com_init_check_hook.cc), and Chrome's usage may conflict with other drivers that may want to hot-patch the same method (example in https://crbug.com/737090). This CL adds answers to the following questions that may arise when investigating hot-patch failures. 1) Is hot-patching failing due to a bug where the HookManager singleton is instantiated twice? This can happen if base is linked in twice. This question is answered by printing the bytes that would be written to the hot-patch area, so they can be compared with the current values. 2) Is hot-patching failing due to a previous failure to revert the hot-patch? This question is answered by DCHECKing that reverting the hot-patch never fails. (The code previously just assumed that.) Bug: 877868 Change-Id: I94f81b3816417447d31fc700c6b81d8325222d1a Reviewed-on: https://chromium-review.googlesource.com/1189143 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#586375}
-
Doug Arnett authored
Adds about:flags support for ResourceLoadingHints and fixes an issue for determining the initial PreviewsState (where we need to "allow" ResourceLoadingHints preview even if no hints loaded for it yet (will be checked at commit time). Bug: 871795 Change-Id: I52529a29dabf6e5be23c49bf7f597783418d053b Reviewed-on: https://chromium-review.googlesource.com/1187574 Commit-Queue: Doug Arnett <dougarnett@chromium.org> Reviewed-by:
-
Sarah Hu authored
PatchSet 1 is originally reviewed in https://chromium-review.googlesource.com/c/chromium/src/+/1142384 On top of the original CL, this updates the following: 1. Notify oobe dialog state based on the visibility of the oobe dialog. 2. Send additional data SetShowGuestButtonForGaiaScreen to login shelf. Bug: 857514, 869811 Change-Id: Ic8baae2e31d2818f356e7fc79f172e4091053fec Reviewed-on: https://chromium-review.googlesource.com/1168105 Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#586373}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/89664843c656..22f7aafb44b7 git log 89664843c656..22f7aafb44b7 --date=short --no-merges --format='%ad %ae %s' 2018-08-27 bryan.bernhart@intel.com Add webgl checks in GetActiveUniformsiv. 2018-08-27 syoussefi@google.com Fix dEQP_GLES3.functional.negative_api.shader.program_binary Created with: gclient setdep -r src/third_party/angle@22f7aafb44b7 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I34db6d41e53ea531bc1045dda512de054b4c163f Reviewed-on: https://chromium-review.googlesource.com/1191144Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#586372}
-
Victor Costan authored
Change-Id: I0cf147382da7458f9e63ddfbdec797880a78724e Reviewed-on: https://chromium-review.googlesource.com/1188827Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#586371}
-
Lei Zhang authored
Use base::NoDestructor, range-based for loops, and initialize members in headers. Also mark some constants as constexpr. Change-Id: I7cfef2e80f8fc285af560f48cfbcaf264b03513e Reviewed-on: https://chromium-review.googlesource.com/1189542Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#586370}
-
Alexei Filippov authored
Make Poisson sampler a separate class that is responsible for listening for allocation and doing the sampling with given sampling interval. SamplingHeapProfiler is now an observer of PoissonAllocationObserver. Once a sample added it record the native stack and stores the sample in the map. The list of recorded samples can then be retrieved by clients. TBR=ajwong@chromium.org BUG=803276 Change-Id: I1e568b9839d9cc0099704ba1b9f047c14a46a0ee Reviewed-on: https://chromium-review.googlesource.com/1189713Reviewed-by:
Alexei Filippov <alph@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#586369}
-
iOS Autoroller authored
TBR=smut Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ic7c8ce07306d1aec6915f5390a6c6107a14efa58 Reviewed-on: https://chromium-review.googlesource.com/1191243 Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org> Reviewed-by:
iOS Autoroller <ios-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#586368}
-
spirv-chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/d94a2077d68c..06b42949b620 git log d94a2077d68c..06b42949b620 --date=short --no-merges --format='%ad %ae %s' 2018-08-27 31666470+s-perron@users.noreply.github.com Validate uses of OpTypeFunction. (#1867) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@06b42949b620 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Idd0289bbb82e98dfc9200f9ebc89b4e43ec90c90 Reviewed-on: https://chromium-review.googlesource.com/1191142Reviewed-by:
spirv-chromium-autoroll <spirv-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: spirv-chromium-autoroll <spirv-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#586367}
-
Rune Lillesveen authored
We no longer (re-)attach the layout tree from style recalc. Change-Id: Ia944649b6e12345c23ecbd7e6ea91d8d6aaba94c Reviewed-on: https://chromium-review.googlesource.com/1190205Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#586366}
-
Alex Moshchuk authored
Change-Id: I3f664cb970a58b34e91075cf29928390878e182d Reviewed-on: https://chromium-review.googlesource.com/1191146Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#586365}
-
Bo Liu authored
Bug: 855390 Change-Id: Icf7785b87dd04b9b2a9dd641fb7eaea6e401f611 Reviewed-on: https://chromium-review.googlesource.com/1189029Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#586364}
-
Nicolas Ouellet-payeur authored
'safe_browsing_g4_update': s/g4/v4/ Bug: 876856 Change-Id: Iefda4121e331a5005d9372e5bfcc493646e5e47d Reviewed-on: https://chromium-review.googlesource.com/1187322 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
-
Eric Orth authored
Convert the //net/dns:public source_set into :host_resolver and move all public headers to source. Access to these previously-public headers will now only be allowed for BUILD.gn rules listed in the friend list. Added friend entries with explanation comments for all remaining usage. Some with TODOs to remove, eg because they'll be migrated to network service. Confirmed that there are no other remaining usage in code where private headers are or are not enforced (checking unenforced by searching for "net/dns" in the error output). Removed a couple includes that were no longer needed. TBR=jochen@chromium.org Bug: 846454 Change-Id: I7bb633088689dc896f9fc27e1dec87ae699410db Reviewed-on: https://chromium-review.googlesource.com/1183981 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
-
Antonio Gomes authored
This is a follow up of CL https://crrev.com/c/1136518 where, CrDownloader/UrlFetcherDownloader migrated from URLFetcher to SimpleURLLoader. As part of the migration, it was verified that CrxDownloader::Result had struct members only used in unit tests: |downloaded_bytes| and |total_bytes|. Additionally, the CrxDownloader::ProgressCallback did not use its |result| parameter. This CL removes the struct members from CrxDownloader::Result as well as their use (mocked up anyways) in unittests, and removes the unused |result| parameter from CrxDownloader::ProgressCallback. BUG=844972, 871211 Change-Id: I5b36c63784ff2632f71c1e5a0cd44b6e0c7c7f37 Reviewed-on: https://chromium-review.googlesource.com/1190324 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#586361}
-
Victor Costan authored
AppCacheResponseIO is an abstract (with pure virtual methods) base class for classes that also use WeakPtrFactories. Some method in the base class currently use the WeakPtrFactory embedded in the base class to vend WeakPtrs, which will point to instances of the derived classes. These pointers will be invalidated when the base class' WeakPtrFactory is destroyed. So, there is a time window when the weak pointers are valid, but the members in derived classes are being destroyed. To avoid reasoning about such complexities, this CL removes the WeakPtrFactory in the base class. Instead, base class methods use a virtual method to get weak pointers from the derived classes' factories. Change-Id: I343a0e1159d839b0f71fb09518704ce560b2c5ad Reviewed-on: https://chromium-review.googlesource.com/1188825Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#586360}
-
Allen Bauer authored
The previous patch attempting to fix this, https://crrev.com/c/1188434, didn't blend in the right direction. It got the background color calculation correct, but the title color calculation wasn't right. This change just uses GetColorWithMinimumContrast directly so that the text (and the close button icon) has sufficient contrast on a selected inactive tab. Bug: 876794 Change-Id: I8ee0a8f2a38aac60c14d104fbf75c3ef85304720 Reviewed-on: https://chromium-review.googlesource.com/1191189Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#586359}
-
Etienne Bergeron authored
No code change. R=ssid@chromium.org Change-Id: I7eaef6cab924fb60dd7b242d333276dce83522aa Reviewed-on: https://chromium-review.googlesource.com/1191327Reviewed-by:
Siddhartha S <ssid@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#586358}
-
Weilun Shi authored
Change Font Family to Segoe UI for custom link when using Windows and make it bolder for fallback icon letter. Before: https://screenshot.googleplex.com/pRPVmEC3yc8.png After: https://screenshot.googleplex.com/m16uEv78QBp.png Bug: 867778 Change-Id: I1f16dbf044cad7504617868f131b7517985cd2c2 Reviewed-on: https://chromium-review.googlesource.com/1178469 Commit-Queue: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#586357}
-
Manu Cornet authored
This changes the color, alpha and size of indicators according to the spec (see linked bug for the spec). Bug: 877351 Change-Id: I6237ab1f0d4727907b344147a0cf816319192b26 Reviewed-on: https://chromium-review.googlesource.com/1189196 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#586356}
-
Eunseok Oh authored
This patch replaces the erase(std::remove()) used in the media folder with base::Erase(). Bug: 875665 Change-Id: Id832871a1fbfcb657e4160f57ff206f93950e7ab Reviewed-on: https://chromium-review.googlesource.com/1180953Reviewed-by:
Kuang-che Wu <kcwu@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#586355}
-
Scott Violet authored
Here's the list of changes: git mv services/ui/common services/ws (update build files, rename services/ui/common:mus_common to common) git mv services/ui/public/cpp services/ws/public git mv services/ui/gpu_host services/ws git mv services/ui/ime services/ws git mv services/ui/test_ws services/ws git mv services/ui/input_devices services/ws/ git mv services/ui/ws2/* services/ws BUG=876924 TEST=covered by tests TBR=jamescook@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_dbg_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ia93dc557a45dc75bcf8a2b3bf80f2e393d4362ed Reviewed-on: https://chromium-review.googlesource.com/1188961 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
jonross authored
The last bots running surface_sync_content_browsertests were Android. However Surface Sync is now on by default on Android, so these tests are redundant. This removes the config from test_suites, and all Android bots. TEST=surface_sync_content_browsertests Bug: 849746 Change-Id: Ie9de3fabaaee8a694acb5ce48c8ff2a9c58e0e42 Reviewed-on: https://chromium-review.googlesource.com/1190125Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#586353}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b6bda5336f20..9b4fbc6e4341 git log b6bda5336f20..9b4fbc6e4341 --date=short --no-merges --format='%ad %ae %s' 2018-08-27 jbudorick@chromium.org devil: add arm64 version of empty_system_webview. Created with: gclient setdep -r src/third_party/catapult@9b4fbc6e4341 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I7349e57f96257fd64301982b964478b5914b1eac Reviewed-on: https://chromium-review.googlesource.com/1190903Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#586352}
-
Xida Chen authored
Right now in TouchActionFilter, we set |gesture_sequence_in_progress_| false when processing GestureTap and GestureTapCancel. This is wrong with considering the following gesture sequence: 1. A simple tap: GestureTapDown-->GestureTapUnconfirmed-->GestureTap 2. Double tap: GestureTapDown-->GestureTapUnconfirmed-->GestureTapCancel -->GestureTapDown-->GestureTapCancel-->GestureDoubleTap 3. A gesture scroll: GestureTapDown-->GestureTapCancel -->GestureScrollBegin-->GestureScrollUpdate-->GestureScrollEnd 4. A fling: GestureTapDown-->GestureTapCancel-->GestureScrollBegin -->GestureScrollUpdate-->GestureScrollEnd All these sequence indicates that the gesture_sequence_in_progress_ should be true when filtering a GestureTapCancel and false when GestureTap. This CL does that. In additional to that, this CL also mark gesture_sequence_in_progress_ false when it is GestureLongTap or GestureTwoFingerTap. Unit tests are added for both cases. TBR=dtapuska@chromium.org Bug: 851644 Change-Id: I40e70cb95a93c20b13952c571d1e1108405c6051 Reviewed-on: https://chromium-review.googlesource.com/1190423 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#586351}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/441ef218c20b..d3220624aa66 git log 441ef218c20b..d3220624aa66 --date=short --no-merges --format='%ad %ae %s' 2018-08-27 thestig@chromium.org Add a "lastchange" hook. Created with: gclient setdep -r src/third_party/pdfium@d3220624aa66 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I31689f09585535157510c076eb194190ba6490ce Reviewed-on: https://chromium-review.googlesource.com/1191143Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#586350}
-
Weidong Guo authored
Bug: 878000 Change-Id: I22ee53ca780fa1fa5c848f11352ab251306e0bab Reviewed-on: https://chromium-review.googlesource.com/1191090Reviewed-by:
-
Dave Tapuska authored
The spec pull request has been updated provided feedback from others: https://github.com/whatwg/fullscreen/pull/129#issuecomment-415873900 This change brings our implementation to match the current pull request. BUG=829937 Change-Id: I9374ddcb694e4322090da1cc8b4ce0c51628158a Reviewed-on: https://chromium-review.googlesource.com/1188885Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#586348}
-
Ben Pastene authored
crrev.com/c/1179227 didn't actually disable it. Looks like we messed up the conditional a little. Bug: 875104 Change-Id: Ide2caab7969f2aa33f6c16e7b73e2f389273f9fe Reviewed-on: https://chromium-review.googlesource.com/1189033Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#586347}
-
Daniel Rubery authored
LOG doesn't even evaluate the streamed arguments if the conditions for logging aren't met (verbosity, debug, etc.) Now CRSBLOG does the same, so that CRSBLOG << Function() is a noop if there are no listening chrome://safe-browsing tabs. Bug: 874693 Change-Id: I6e1316b280b87264e65cb789151cff8596eb380a Reviewed-on: https://chromium-review.googlesource.com/1187008 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
-
Filip Gorski authored
* Updates referrer for content suggestions to https://feed.google.com * Makes the referrer configurable through Field Trials bound to the NTPArticleSuggestions experiment. Bug: 870750 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I87b0af69e05e9b1c38bf12caade61ebb80f6cee0 Reviewed-on: https://chromium-review.googlesource.com/1185857 Commit-Queue: Filip Gorski <fgorski@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
-
Kai Ninomiya authored
This was introduced in my earlier patch https://chromium-review.googlesource.com/c/chromium/src/+/1147251 because I didn't realize it would affect regular GLES2 contexts. I backported this fix from my in-progress patch: https://chromium-review.googlesource.com/c/chromium/src/+/1186129 NOTRY=true Bug: 877952 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I8930bcb7b4c739a49c533141f28aebd6a5181712 Reviewed-on: https://chromium-review.googlesource.com/1191124 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#586344}
-
Elly Fong-Jones authored
This change: 1) Renames MenuDelegate::GetLabelFontList to MenuDelegate::GetLabelStyle; 2) Removes MenuDelegate::GetShouldUseNormalForegroundColor() in favor of the MenuDelegate supplying its own foreground color; 3) Removes the "emphasized" notion from MenuItemView, since it was only used in one place (AppMenu) to achieve the behavior of having a disabled item paint as an enabled item; This leads into a cleanup of MenuItemView::GetTextColor() to use TypographyProvider to retrieve all colors. Bug: 865318 Change-Id: Ie6238cfd5c9baac7be595809560485c23b804a08 Reviewed-on: https://chromium-review.googlesource.com/1186702 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
Soojung choi authored
This patch simplifies conditions around the code in ui/ozone Bug: 561800 Change-Id: I910244a9a50ff89b2979e9942e619752bbc319b1 Reviewed-on: https://chromium-review.googlesource.com/1183262Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#586342}
-
