- 18 Jul, 2017 40 commits
-
-
Jinho Bang authored
This is an initial implementation of AbortPaymentEvent in WebIDL level. Related spec change: https://github.com/w3c/payment-handler/pull/170 Bug: 736745 Change-Id: I5cdf6b8e6a8019121aed4e10d33e884076bb519b Reviewed-on: https://chromium-review.googlesource.com/571345 Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#487463}
-
Vitalii Iarko authored
This CL adds SubscriptionManager interface and renames the current implementation to SubscriptionManagerImpl. Bug: 745383 Change-Id: I1cbbb2b77e987a1d300f5926ae5bef8d20839dc1 Reviewed-on: https://chromium-review.googlesource.com/576027Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#487462}
-
Peter Marshall authored
We would like to increase the max string size in v8, but this test fails if we do so. The test generates a huge string as a response, which is then fed into a string object via v8::String::Concat in chunks. This works for the current string size but is slow (hence why the test is marked as 'Slow') but with an increased limit, this approach no longer works. V8 already includes a test in test-api.c -> StringConcatOverflow for the contract that Concat should return an empty handle rather than throw when the concat would produce a too-large string. Bug: v8:6148 Change-Id: I7879b0c5a284fea73273085a33ffb0722f8b70b7 Reviewed-on: https://chromium-review.googlesource.com/576089Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#487461}
-
Mark Cogan authored
This CL removes use of IDC_NEW_TAB and IDC_NEW_INCOGNITO_TAB. Call sites were already using NewTabCommand instead of the raw command_ids, but there were still plenty of plumbing changes needed to switch over to calling dispatcher methods. The commands are now split into a BrowserCommands method, -openNewTab:, and an ApplicationsCommands method, -switchModesAndOpenNewTab:. Both methods take a NewTabCommand as their argument. Since NewTabCommand includes a flag to indicate if an incognito tab should be opened, there's no separate methods for that. If the BVC gets an openNewTab: whose incognito-ness (incognition?) doesn't match the BVC, it sends -switchModesAndOpenNewTab: instead. The application command endpoint (MainController) then switches active BVCs and sends the newly-active one a new openNewTab: command on its dispatcher, passing the same NewTabCommand. BVC also exposed a special -newTab: method for various classes to use instead of sending tedious ChromeCommands. That's gone, and all of the callers of -newTab: now use openTab: on a dispatcher like everyone else. Removing -newTab: as a public BVC method meant some tests had to change, too. Tab now needs a dispatcher handed to it, so it can send commands. It only needs to do this for its ManageAccountsDelegate methods, so when they are moved out of Tab, the dispatcher can go away as well. It's not feasible to attach a dispatcher to each Tab as it's created, since that happens (ideally) outside of the UI layer where the dispatchers live. Thus, the BVC attaches a dispatcher to the tab in -installDelegatesForTab:. TabStripController, TabSwitcherController, TabSwitcherPanelController, and TabSwitcherPanelOverlayView all have a dispatcher plumbed into them. NewTabButton no longer sets its own target/action. It's only used in the Stack View, and should probably be moved into that directory. StackViewController now sets the right target/action on it. Menu items that have selectors defined -- that is, those that are triggering commands that will be sent via dispatcher -- now take care of sending those selectors themselves in an -executeCommandWithDispatcher: method. This means that the new tab menu items can take care of creating the necessary NewTabCommand internally. Bug: 738881 Change-Id: Ic63da24612906b5c9bfe7ef2bb92181233c8198c Reviewed-on: https://chromium-review.googlesource.com/567987 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Jean-François Geyelin <jif@chromium.org> Cr-Commit-Position: refs/heads/master@{#487460}
-
Jérôme Lebel authored
Simplyfing mediator API TBR=sdefresne@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Bug: 661794 Change-Id: Iee39a518e2f958a093467b5d1f1663a7210b33f8 Reviewed-on: https://chromium-review.googlesource.com/575969Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#487459}
-
Daniel Bratell authored
NotificationDataTest, NotificationImageLoaderTest and NotificationResourceLoaderTest all use constants, such as kBaseDir, with the same name. That is normally no big deal but in jumbo builds they can be compiled in the same translation unit and then the constants will collide. This patch gives the constants unique prefixes so that the tests don't have to be excluded from jumbo. Change-Id: Ib01d88e75cdc876a58c52a6ee3b49a942ccb19ab Reviewed-on: https://chromium-review.googlesource.com/576088Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#487458}
-
Bernhard Bauer authored
Bug: 728558 Change-Id: Ie0d82eba52ecbd0ba397c6b28f8a5bb33050a67b Reviewed-on: https://chromium-review.googlesource.com/570024 Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#487457}
-
tzik authored
This CL removes all dependencies to BrowserThread::FILE in sync_file_system, and replaces them with base/task_scheduler's ones. Change-Id: Idd3ffb66d2d3079f3b6b680bde8b016d696ce268 Reviewed-on: https://chromium-review.googlesource.com/575735 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#487456}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/001e72263fee..0aa492d0f47d $ git log 001e72263..0aa492d0f --date=short --no-merges --format='%ad %ae %s' 2017-07-18 fmalita Remove leftover Android ctable reference Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=caryclark@chromium.org Change-Id: I800af2f73eac7aa25ee0547be0d9e2c7fa03a9ee Reviewed-on: https://chromium-review.googlesource.com/576074Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#487455}
-
Xiaocheng Hu authored
This patch changes the DCHECK of clean layout in TextIterator to CHECK, so that we can catch remaining lifecycle issues. Bug: 739060 Change-Id: I0ee0a152b438d3d8e1f97de0acd2844b190ef703 Reviewed-on: https://chromium-review.googlesource.com/575597Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#487454}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b7509b51..b56b94be Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: If6c03cee3f7b37ffd47cedd93542aed163868261 Reviewed-on: https://chromium-review.googlesource.com/575833Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#487453}
-
Jérôme Lebel authored
Removing 3 properties for metrics, all related to the access point value. Bug: 661794 Change-Id: I4f97831e1bf775d9c660d6658e6dfa3bf857260d Reviewed-on: https://chromium-review.googlesource.com/575137Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#487452}
-
Mikhail Pozdnyakov authored
This patch brings following improvements: - Same call chain is used for actual Sensor state updating and for firing the events (i.e. no implicit Sensor state change on JS side) - All the pending notification is suppressed after Sensor has stopped (or an error has occurred) - Notification for initial reading Bug: Change-Id: Ia0505a4f51e17fbfaa8faa07602fff5618b8dc3d Reviewed-on: https://chromium-review.googlesource.com/559344Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> Cr-Commit-Position: refs/heads/master@{#487451}
-
Xida Chen authored
These functions are called within the same class, no reason to be public. This is a pure clean up CL, no behavior change at all. TBR=junov@chromium.org Bug: None Change-Id: I26f87e53d6bab6c3cf71df2228db852087542c39 Reviewed-on: https://chromium-review.googlesource.com/575828Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#487450}
-
Yutaka Hirano authored
Bug: 745345 Change-Id: I77528117274d0bc79a376bfad976ff3adc2f95a2 NoTry: true Tbr: tyoshino@chromium.org Reviewed-on: https://chromium-review.googlesource.com/574897Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#487449}
-
Naoki Fukino authored
Bug: 743091 Change-Id: I1e1261c2de63baceb90b5fdcfbcb3b6a03401c10 Reviewed-on: https://chromium-review.googlesource.com/575115Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#487448}
-
gaschler authored
Add unit tests for CachedImageFetcher to cover image fetches from cache, from URL, and a failing URL fetch. Bug: n/a Change-Id: Ia049db29fcf375f5d9eb5c707f2a505cb5a4511d Reviewed-on: https://chromium-review.googlesource.com/574711 Commit-Queue: Andre Gaschler <gaschler@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#487447}
-
Kent Tamura authored
We should ignore trailing "." and digits after a number. We should reject a leading "-", a leading "+", and scientific notation. Bug: 742104 Change-Id: I4e5ed15e0a07f361fd86680a60430cb2d760dc83 Reviewed-on: https://chromium-review.googlesource.com/574973 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Cr-Commit-Position: refs/heads/master@{#487446}
-
Kent Tamura authored
We don't need a special handling for 0 value. https://html.spec.whatwg.org/multipage/common-dom-interfaces.html#clamped-to-the-range > On setting, it behaves the same as setting a regular reflected unsigned integer. Bug: 745376 Change-Id: I6dead5b474324cd19e811c950971e5804532508a Reviewed-on: https://chromium-review.googlesource.com/575738Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#487445}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/44b022b2a095..6fc5e4196940 $ git log 44b022b2a..6fc5e4196 --date=short --no-merges --format='%ad %ae %s' 2017-07-18 perezju [devil] Set permissions on install and gracefully handle errors Created with: roll-dep src/third_party/catapult BUG=732724,739531 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I2e1bd2fc2ce6d34a3364e89fee82e220c4db508d Reviewed-on: https://chromium-review.googlesource.com/576073 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#487444}
-
Hiroki Nakagawa authored
This CL separates WorkerThreadStartupData into 2 structs: GlobalScopeCreationParams for creating global scope and WorkerBackingThreadStartupData for initializing WorkerBackingThread. Before this CL, WorkerThreadStartupData contains both the data and it causes awkward initialization like [1]. This CL simplifies parameter handling and unblocks further refactorings like separating WorkerBackingThread initialization from WorkerThread. [1] https://chromium-review.googlesource.com/c/567794/ Bug: 710364 Change-Id: I3123b84faa8df29bcc0988395f5efb7906ba2341 Reviewed-on: https://chromium-review.googlesource.com/571519 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#487443}
-
Hector Dearman authored
Bug: 739710 Change-Id: Ib926ae1ec013b33b7a90dcedb78960713cfa97e0 Reviewed-on: https://chromium-review.googlesource.com/565510Reviewed-by:
Siddhartha S <ssid@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Commit-Queue: Hector Dearman <hjd@chromium.org> Cr-Commit-Position: refs/heads/master@{#487442}
-
Vaclav Brozek authored
This CL mentions iossim's -c option for passing aruments to the test app in the iOS build instructions. Bug: None Change-Id: I80ccddb56e142b547117297ae0fdb85e2b8d63f3 Reviewed-on: https://chromium-review.googlesource.com/575047 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#487441}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/c2bd631c431c..001e72263fee $ git log c2bd631c4..001e72263 --date=short --no-merges --format='%ad %ae %s' 2017-07-18 fmalita Add guard to unblock the Chromium roll 2017-07-17 scroggo Use SkRasterPipeline to blend GIF frames and use proper offset 2017-06-27 mtklein add 32-bit Windows SkJumper backend 2017-07-17 reed Don't store colortables in pixmaps or pixelrefs 2017-07-17 reed Revert "SkPDF: Non-outline glyphs as images" 2017-07-17 fmalita Skip bilerp for integral-translate-only matrices 2017-07-17 halcanary SkPDF: Non-outline glyphs as images 2017-07-17 reed remove SK_SUPPORT_LEGACY_INDEX_8_COLORTYPE for google3 2017-07-17 reed Index8 is dead, remove guarded code 2017-07-17 fmalita Delete dead SK_SUPPORT_LEGACY_BILERP_IGNORING_HACK code 2017-07-17 ethannicholas fixed skslc vec4 uniforms Created with: roll-dep src/third_party/skia BUG=744674,705480 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=caryclark@chromium.org Change-Id: I0d593da3a5d007dd22f298629e20a45bf7bfad13 Reviewed-on: https://chromium-review.googlesource.com/575363Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#487440}
-
Eddy Mead authored
Found during testing: - scale(sx) should be the same as scale(sx, sx) spec here: https://drafts.csswg.org/css-transforms/#valdef-transform-scale Bug: 545318 Change-Id: Icfb150ecc83e55b142d6d6ea21e00caf28b117ad Reviewed-on: https://chromium-review.googlesource.com/554634 Commit-Queue: meade_UTC10 <meade@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#487439}
-
Benoit Lize authored
ACTION_VIEW intents should contain a Uri as data, but in some cases they might not (explicit intent incorrectly set, for instance). Don't crash in this case. For instance, adb shell am start -a android.intent.action.VIEW -n org.chromium.chrome/com.google.android.apps.chrome.Main would crash, this fixes it. BUG=742294 Change-Id: Ic44d7cb656d193449363ef63506e0d9852a6e782 Reviewed-on: https://chromium-review.googlesource.com/569964 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Nicolas Dossou-Gbété <dgn@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#487438}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c2021812..b7509b51 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: Ief104a8ee32420a11766c8f121e3e4e422b0b8a7 Reviewed-on: https://chromium-review.googlesource.com/575688Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#487437}
-
Hidehiko Abe authored
This CL migrates ArcIntentHelperBridge. BUG=672829 TEST=Ran try. Ran on DUT. Change-Id: Ic7bba1bdd95dc5c41c7789d4081f9abb3fc9ad12 Reviewed-on: https://chromium-review.googlesource.com/571384Reviewed-by:
Yusuke Sato (in China Mon-Thurs, may be offline) <yusukes@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#487436}
-
Mark Cogan authored
This CL removes all contextual search code from the BVC. Almost all of the logic contained in the BVC is ported to a new wrangler class. Any object wishing to use contextual search (without further refactoring) will need to furnish a provider object as defined in the wrangler class header, which at this stage just encapsulates all of the interfaces into the BVC that the contextual search code used to use. Bug: Change-Id: I23ffe787b26ead87c9c50e4730851f6b992c95a4 Reviewed-on: https://chromium-review.googlesource.com/574534 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#487435}
-
Mark Cogan authored
This CL removes -resetAllWebviews, which no longer has any call sites. This CL also removes -ensureViewCreated, which is just our implementation of [UIViewController loadViewIfNeeded], which has been available since iOS9. Bug: Change-Id: Ia2adab95a7a5726114a7e81ce784aaa4e40aa676 Reviewed-on: https://chromium-review.googlesource.com/570019 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#487434}
-
Juan A. Navarro Perez authored
TBR=nednguyen@google.com Bug: 742475 Change-Id: I5c4e2e05c45c835e9163cfd5f2e47ee958298064 Reviewed-on: https://chromium-review.googlesource.com/574916Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#487433}
-
Kouhei Ueno authored
Bug: 594639 Change-Id: Iabb2f3780d21c0f896073e6cad6178deced61e83 Reviewed-on: https://chromium-review.googlesource.com/575797Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#487432}
-
Alexandr Ilin authored
In the current state we skip preconnect even if prefetch is disabled because the check is inside MaybeAddPrefetch() method. We have prefetch data even if prefetching is disabled because LoadingPredictor uses common LEARNING mode. Bug: 699080 Change-Id: I48aef431bf0771e5c7e74b0b0dd164b77aab493c Reviewed-on: https://chromium-review.googlesource.com/570421Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#487431}
-
Henrik Boström authored
https://chromium-review.googlesource.com/c/566806 showed that the WebRtcRtpBrowserTest.AddAndRemoveTracks* tests would reliably crash if the garbage collector was invoked between addTrack and getSenders. Tracks that were added using addTrack would have their track adapters (glue between blink and webrtc) kept alive only by the blink layer sender holding on to a reference, since these were not kept alive by any "local streams" holding a reference. The blink::RTCPeerConnection now holds a strong reference to senders and receivers to prevent GC while in-use, with TODOs to remove ones no longer used when addStream/removeStream is implemented using addTrack/removeTrack. Furthermore the content::RTCPeerConnectionHandler holds on to the content layer representation of senders so that their associated set of streams are not forgotten between addTrack and getSenders. Having the handler keep track of senders is good practice, this gets rid of the assumption that blink layer senders have to be kept alive. A TODO was added to do the same for receivers (not yet required because blink layer receivers are kept alive). With this change, the AddAndRemoveTracks* tests pass and are re-enabled. Bug: 740650 Change-Id: Iec3a39a994bef31904f2969d791125867ec1e398 Reviewed-on: https://chromium-review.googlesource.com/567184Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Taylor Brandstetter <deadbeef@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#487430}
-
Jérôme Lebel authored
Conflict between crrev.com/c/559001 and crrev.com/c/559101 Bug: 661794 Change-Id: Ia7601ba8f334adad8a33fb1cbd744fb050382856 Reviewed-on: https://chromium-review.googlesource.com/574236 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#487429}
-
Boris Sazonov authored
This CL makes several changes to AuthException and its users: 1. Add second constructor that accepts message that can be used to report info about context that caused auth failure. 2. Use newly-added constructor to report authTokenScope that caused GoogleAuthException. 3. Add AuthException.TRANSIENT and AuthException.NONTRANSIENT constants to use in AuthException constructors. Bug: 741883 Change-Id: I6448ef2e4ecc66a885a0d3dc21f8665f678689ca Reviewed-on: https://chromium-review.googlesource.com/574541Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#487428}
-
Marc Treib authored
The new images have the proper size for display on the NTP. This should make them look a bit less blurry. Fun fact: These images were last updated in 2011 [1]. Somewhat surprisingly, the web pages haven't changed much since then. Before: https://screenshot.googleplex.com/Wn7Sb6UyjdN After: https://screenshot.googleplex.com/ef7zJfGcE0Q optimize-png-files.sh was run on the new images. [1] https://codereview.chromium.org/8820002 Bug: 734038 Change-Id: Id9c9fb5b771fe2df973830e7b6392a555dfcda5c Reviewed-on: https://chromium-review.googlesource.com/574230Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#487427}
-
henrika authored
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/beaccf9..2048bc4 $ git log beaccf9..2048bc4 --date=short --no-merges --format=%ad %ae %s 2017-07-17 zstein@webrtc.org Remove default implementation of PeerConnectionInterface::SetBitrate. 2017-07-17 steveanton@webrtc.org Android bindings for ice_regather_interval_range RTCConfiguration option 2017-07-13 zijiehe@google.com Expose IsCurrentSessionSupported() from ScreenCapturerWinDirectx 2017-07-17 minyue@webrtc.org Revert "Prefer external video codecs over internal in SDP" 2017-07-17 tschumim@webrtc.org Don't run NoBandwidthDropAfterDtx test on andriod because it's flaky. 2017-07-17 tschumim@webrtc.org Reimplemeted "Test and fix for huge bwe drop after alr state" 2017-07-16 eladalon@webrtc.org nit: Avoid pointer-to-unique_ptr in RtcEventLogImpl 2017-07-15 tommi@webrtc.org Fix incorrect DCHECK in generic_decoder.cc. When ownership is not external, the decoder pointer should be valid. 2017-07-14 jtteh@webrtc.org Revert of Injectable Obj-C video codecs (patchset #2 id:370001 of https://codereview.webrtc.org/2979983002/ ) 2017-07-14 steveanton@webrtc.org Reinstate "iOS - Add iceRegatherIntervalRange." 2017-07-14 steveanton@webrtc.org Reinstate "Add additional check when setting RTCConfiguration" 2017-07-14 steveanton@webrtc.org Reinstate "API for periodically regathering ICE candidates" 2017-07-14 mbonadei@webrtc.org Disabling test on iOS64 debug bot 2017-07-14 tommi@webrtc.org Reland of Make the default ctor of rtc::Thread, protected 2017-07-14 zstein@webrtc.org SignalPacketReceived should pass packet as a pointer instead of a non-const reference. 2017-07-14 zstein@webrtc.org Adding stats that can be used to compute output audio levels as described here https://w3c.github.io/webrtc-stats/#dom-rtcmediastreamtrackstats-totalaudioenergy. 2017-07-14 magjed@webrtc.org Prefer external video codecs over internal in SDP TBR= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng Bug: Change-Id: Ic042ed27f7e9d91532f3cbf2b979b76f1b853448 Reviewed-on: https://chromium-review.googlesource.com/575987Reviewed-by:
Henrik Andreasson <henrika@chromium.org> Commit-Queue: Henrik Andreasson <henrika@chromium.org> Cr-Commit-Position: refs/heads/master@{#487426}
-
Hidehiko Abe authored
This CL migrates ArcBootPhaseMonitorBridge. BUG=672829 TEST=Ran try. Change-Id: I2a6988e5867092de9b8a981a253f7b1993a9eebc Reviewed-on: https://chromium-review.googlesource.com/575287Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Yusuke Sato (in China Mon-Thurs, may be offline) <yusukes@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#487425}
-
Marc Treib authored
This is a replacement for CaptureThumbnailOnLoadFinished, which was reverted due to perf regressions (see https://chromium-review.googlesource.com/c/570218/). Bug: 718413 Change-Id: I399507f5791b5ca1fc7779331b82bb9782a27268 Reviewed-on: https://chromium-review.googlesource.com/571223Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#487424}
-