- 07 Oct, 2020 40 commits
-
-
Tymofii Chudakov authored
Implemented exceptions section redesign of the content settings pages. This CL includes redesign of the following content setting categories: - ADS - MIDI_DEVICES - AR - MIXEDSCRIPT - AUTOMATIC_DOWNLOADS - MOTION_SENSORS - BACKGROUND_SYNC - PAYMENT_HANDLER - CAMERA - PLUGINS - CLIPBOARD - POPUPS - FILE_SYSTEM_WRITE - PROTECTED_CONTENT - GEOLOCATION - SOUND - IMAGES - UNSANDBOXED_PLUGINS - JAVASCRIPT - VR - MIC Bug: 1113642 Change-Id: I843de142fa297323b795480cecc9ecaaafc18fe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403280 Commit-Queue: Tymofii Chudakov <tchudakov@chromium.org> Reviewed-by:
Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Sean Harrison <harrisonsean@chromium.org> Cr-Commit-Position: refs/heads/master@{#814639}
-
Joanmarie Diggs authored
If an existing node becomes ignored or unignored, we notify platform ATs that the parent of that node has changed children, but not that the children of that node have a changed parent. Some platforms, such as AT-SPI2, cache parent information separately from child information and expect notifications about parent changes to maintain an accurate cache. Address this problem by creating a new AXEventGenerator parent-changed event and emit it on the existing children of a newly-un(ignored) node. It turns out that the ordering of these notifications can also matter. If an about-to-become-focused node is in an about-to-be-reparented subtree, we need to notify ATs about the reparenting before we notify them about the focus change. If we do the reverse, the AT may have stale information about where the new focus is with respect to the accessibility tree which in turn can break AT-driven navigation. But BrowserAccessibilityManager::OnAccessibilityEvents was firing focus events prior to events for any other tree updates in order to ensure screen readers will correctly process events associated with the focused node. We should be able to address both needs by first firing tree updates that come from the ancestors of the focused node, then then firing a focus event if needed, and finally firing the remaining events. Also add expectations for existing related content browser tests for which AuraLinux expectations did not exist, along with fixing a bug in the AuraLinux accessible-event recorder and adding detail for children- changed events. AXRelnotes: The Orca screen reader has a non-performant workaround for the lack of parent-changed notifications, namely to not use the AT-SPI parent caching feature. This fix will make it possible for Orca to use AT-SPI's parent caching and improve performance. Bug: 1047496 Change-Id: I6421543f471054c10cf6a4fa657de4d184cd6bfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418652 Commit-Queue: Joanmarie Diggs <jdiggs@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#814638}
-
Shakti Sahu authored
This CL moves AsyncImageView to components/browser_ui/widget, which includes moving AutoAnimatorDrawable, ForegroundRounderCornerImageView, and unavailable/waiting drawable XML files. Bug: 1134412 Change-Id: I0466620ec4571a75f9839fa575b9d07f1f201b40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444172Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#814637}
-
Peter Marshall authored
This test calls generateJSFrame after createPerformanceModelWithEvents, except this already calls generateJSFrames. It just happens that this is idempotent under some circumstances which this test narrowly falls into. This meant that `events` was always empty and thus the merge did not. Remove all this. Test results are still the same. Bug: 1127827 Change-Id: I6c1d0d776bf692f3563583ea4fa72d1fff9ea3b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455706Reviewed-by:
Paul Lewis <aerotwist@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#814636}
-
Olesia Marukhno authored
If you request a permission, then open another tab and request the same permission, the chip appears without animating and the origin in the omnibox disappears. This patch fixes this behaviour. If request was already shown to user and user switches back to a tab with a pending request, request stays collaped and won't reanimate. Bug: 1019129 Change-Id: I9d46f1fbe479de584bcce988d7a20deb4e7e76a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445774Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com> Cr-Commit-Position: refs/heads/master@{#814635}
-
chrome://accessibilitydpapad authored
Calling JS functions by name from C++ is an obsolete pattern. Use FireWebUIListener/addWebUIListener which is the suggested approach. Also extracting all chrome.send() calls to a local BrowserProxy class which makes the code more readable and is consistent with the BrowserProxy pattern used in other WebUIs. Bug: None Change-Id: I911b114b6687e7b0108296a38636811bc066dd12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450722 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
-
Renato Silva authored
Add some extra logging information to some of the enrollment steps to help us on determining if forced enrollment is preventing some integrating tests from running. Bug: 1109176 Change-Id: Icd375f78bb238a40380d9bc9234a6301ab521e75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442534Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#814633}
-
sandromaggi authored
Both methods are refactored to take an |ElementFinder::Result| instead of a |Selector|. Bug: b/168107066 Change-Id: I99e93d0b7683be74a4390735ac254cbb4017683a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426505 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#814632}
-
Arthur Hemery authored
Refactors the is_coop_coep_cross_origin_isolated and coop_coep_cross_origin_isolated_origin parameters all over content into a class. Change-Id: I5df8ffcb951c783c2d077567ba2c35d214dd1c1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412287 Commit-Queue: Arthur Hemery <ahemery@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#814631}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8274c1978a88..306f83589eb0 2020-10-07 tikuta@chromium.org Revert "Roll out new goma client binary VERSION=206" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I79d08712b709e8ead1774a14debe5d37d7f2ce6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455532Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814630}
-
Vasilii Sukhanov authored
Tbr: bsep@chromium.org Bug: 1136011 Change-Id: Ie874f5f4b10479856af54f7ab3fd4d9012b60d04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454719Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#814629}
-
Vasilii Sukhanov authored
This reverts commit 6b3c4bdb. Reason for revert: Broke PolicyServiceAndroidTest.PolicyUpdateEvent on Android ASAN https://ci.chromium.org/p/chromium/builders/ci/android-asan/8133 Original change's description: > Add onPolicyUpdate notification in Java. > > Support PolicyService::onPolicyUpdate event in Java. Same as other > functions, only Chrome policies are supported. > > Other changes: > 1) Implement PolicyMap.equals() > 2) Use ObserverList instead of Set to manage PolicyService's observers. > > Bug: 1127469 > Change-Id: I40c6958e87c746aa40afec306ee632bba52183f6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446639 > Commit-Queue: Owen Min <zmin@chromium.org> > Reviewed-by: Sky Malice <skym@chromium.org> > Cr-Commit-Position: refs/heads/master@{#814310} TBR=zmin@chromium.org,skym@chromium.org Change-Id: Ibde93e22e01f4d3eb8d9eb2a8d4d9c42166ed191 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1127469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454653Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8e79d255b3b9..025eeee82946 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC vasilii@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1135707 Tbr: vasilii@google.com Change-Id: I65709ccf799796d2babfb32102f263b90bf6fa51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455303Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814627}
-
Vasilii Sukhanov authored
This reverts commit de6bbcbc. Reason for revert: Broke SystemWebAppLaunchProfileBrowserTest tests https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/85648 Original change's description: > system-web-apps: better handle incognito in LaunchSystemWebApp > > LaunchSystemWebApp used whatever profile is provided in the parameter to > create SWA windows and launching SWAs, even if the profile may not > suitable to host a SWA window. > > This CL adds logic to determine the appropriate profile if the provided > one is unsuitable. This serves as a mid-term solution for launching > SWAs, and acts as a safety net to prevent chrome crashing if unsuitable > profiles are provided. > > Specifically, it catches these two types of profiles: > - Guest session "original" profile: launch into guest session's > primary off the record profile (which is used for guest session > browsing and SWAs). > - Normal session incognito profile: launch into the original profile, > because we don't support incognito SWAs. > > Fixed: 1109594 > Change-Id: Ibe4a3b1bf7c811ef1ee02fd967307ad9bf070ee7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423760 > Commit-Queue: Jiewei Qian <qjw@chromium.org> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Cr-Commit-Position: refs/heads/master@{#814602} TBR=ortuno@chromium.org,qjw@chromium.org Change-Id: Ie46ed4204f9c841be9d4dff8772fd2f9af85c96f No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455747Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e1f2ce586075..c4ab7a75eb5a 2020-10-07 szuend@chromium.org [ts] Type-check network/RequestResponseView.js with TypeScript 2020-10-07 alexrudenko@chromium.org Migrate InputModel.js to TypeScript 2020-10-07 bmeurer@chromium.org Rebaseline test expectations. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1134531 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I310314fd61575c8075372fa51f15fbb653e1b928 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455304Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 245022d0. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I9957c7eb6ef62c91162d8bc5ee6ea540137f9923 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455313Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814624}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7cdc44f903d3..6e7d3e86fcbc 2020-10-07 treehugger-gerrit@google.com Merge "Fix build failure due to extra parent dir" 2020-10-06 treehugger-gerrit@google.com Merge "perfetto-ui: Move query result to details panel" 2020-10-06 lalitm@google.com Merge "tp: fix type affinity of string columns" 2020-10-05 ssid@google.com Add a typed event for mojo notify event 2020-10-05 cfijalkovich@google.com Merge "Calibrate HSC-emulated app launch measurements" 2020-10-05 treehugger-gerrit@google.com Merge "Added new proto format for flow events" 2020-10-05 treehugger-gerrit@google.com Merge "Added category and name columns for flow details panel" 2020-10-05 ilkos@google.com Merge "Fix quantization error" 2020-10-05 lalitm@google.com Merge "tp: wait to fill buffers when parsing gzip before sending to next stage" 2020-10-05 hjd@google.com Merge changes I4f8eb249,I829c77e0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:164191691 Tbr: perfetto-bugs@google.com Change-Id: Ibc7159df49daaf98c3aa0761e86dc09ac1da67a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455299 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Vasilii Sukhanov authored
AccessibilityTest.GetAccessibilityLinkInfo AccessibilityTest.GetAccessibilityPage PDFiumPageLinkTest.TestAnnotLinkGeneration PDFiumPageLinkTest.TestLinkGeneration PDFiumPageTextTest.GetTextRunInfo PDFiumPageTextTest.TestHighlightTextRunInfo Tbr: thestig@chromium.org Bug: 1135988 Change-Id: Ibf3a150a812a402e7e604c382d0d1fd372c4ccbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454076Reviewed-by:
-
arthursonzogni authored
Prior to this patch RenderFrameHostImpl::is_mhtml_document_ wasn't set for iframes. This was very confusing. This patch makes the NavigationRequest to compute whether the new document is an MHTML one. This is now less confusing. Moreover this allows: - Fixing a TODO(lukasza) [Done in this patch] - Compute the sandbox flags for MHTML document [In follow-up]. Bug: 1041376 Change-Id: Id99f99b8daf709687986490a06906b2d96ecca0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450270 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
-
David Roger authored
Bug: 1115247 Change-Id: I021ed4188b4aca948b54df2af0117c6a5ce9f398 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445490 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#814620}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Id8840c4ad14f1532c59a4d12be4a55ff09cc7873 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455302Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/f15133788010..fc8264854c53 2020-10-06 afdx@google.com spirv-fuzz: Replace dead-block terminators with OpKill etc. (#3882) 2020-10-06 vasniktel@gmail.com spirv-fuzz: TransformationPropagateInstructionDown (#3692) 2020-10-06 afdx@google.com spirv-fuzz: Transformation to add wrappers for OpKill and similar (#3881) 2020-10-06 afdx@google.com spirv-fuzz: Use overflow ids when duplicating regions (#3878) 2020-10-06 vasniktel@gmail.com spirv-fuzz: Fix rvalue references (#3883) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,timvp@google.com Change-Id: Ib4ad31f2422336dd942227d2a437492930b65310 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455298Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8f6d8b45..86a4dade Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Idc0ec5211d6ea18e0c2403f2c25b43d75d0e9af6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454279Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814617}
-
David Roger authored
Bug: 1130945 Change-Id: Ia1f0c9b8f20ae472dbc4a06711d3d2a4fe574e43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446055 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
-
Vasilii Sukhanov authored
This reverts commit fbdd1097. Reason for revert: Fails consistently on Mac10.13 Tests (dbg) https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20%28dbg%29/20278 Original change's description: > Re-add EyeDropperBrowserTests on FYI bot > > Can't repro the flaky test locally. Re-adding to FYI bot for further > debugging and remain disabled for CI/CQ bot. > > Bug: 1131319 > Change-Id: Id0efb7067480d668dd7caad1cbb6763cb0a1ae84 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446025 > Reviewed-by: Stephen Martinis <martiniss@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Commit-Queue: Sven Zheng <svenzheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#814349} TBR=ellyjones@chromium.org,martiniss@chromium.org,svenzheng@chromium.org Change-Id: I6d90db5e79679597dc7cadd42adb7491df196891 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1131319 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455606Reviewed-by:
-
Rohit Agarwal authored
EnableAmbientAuthenticationInIncognito and EnableAmbientAuthenticationInGuestSession feature flags are removed as a follow-up cleanup, since ambient authentication is now disabled for private modes for many milestones. Ambient authentication for private modes is now only manageable using Enterprise policies. Bug: 458508 Change-Id: I98263fa763c18132bc977865a29604a58f4e478f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452669 Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#814614}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/439af79f26e2..57c37ad0e4c8 2020-10-07 csmartdalton@google.com Add a 2d cross product intrinsic to sksl If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jvanverth@google.com Change-Id: I073a8e92e9ee3e4402c2a26eff66e6045d3a5802 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455301Reviewed-by:
-
Fredrik Söderqvist authored
This is now always equal to the stroke bounding box (or object bounding box if stroke does not apply or otherwise have no influence), so it can be removed and VisualRectInLocalSVGCoordinates() forwarded to StrokeBoundingBox(). Ditto for |LayoutSVGRoot::visual_rect_in_local_svg_coordinates_|. Bug: 1028061 Change-Id: Idebfb8fb5ca4fd3c954c99068163e3947e042b49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450321 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#814612}
-
Alice Wang authored
This CL adds tests to check uma recording when account picker is suppressed when no accounts are on device and when sign-in is not allowed. Bug: 1134874 Change-Id: I88817b536d9dcb02b34fcee3a294801a3706ae5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448797 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#814611}
-
Austin Tankiang authored
Bug: 1135930 Change-Id: Ia981112e2525fb2b2c883197a1a10f675c9d6142 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454435Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#814610}
-
Fabio Tirelo authored
Bug: 1135570 Change-Id: I508f9fb7f5a3c6a9decd37666934cfc25ea59481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453902 Auto-Submit: Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#814609}
-
Sylvain Defresne authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. Bug: 1018739 Change-Id: I0302d272b769933d9deceb25883d00cc4e4c2e78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445614 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#814608}
-
David Roger authored
Notes: * on the mock, there is a color row missing. I've confirmed that it should be added (this is done in this CL). * The input is not plumbed (does not update the profile name) * the pink color is hardcoded * the brush icon for the custom color is larger than the mocks Screenshot: https://screenshot.googleplex.com/AStdxggC7tftUN2.png Mock: https://screenshot.googleplex.com/4Ntu44ka2iBMJxm.png Bug: 1130945 Change-Id: I736119eae9714f6662955c41f30e13624710dd52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450010 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f3f59fd5e5fa..e1f2ce586075 2020-10-07 alexrudenko@chromium.org Migrate ScreencastApp.js to TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I79e1df15fd76511ff0d2a5011fe657d115780fa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454277Reviewed-by:
-
Boris Sazonov authored
Replaces existing calls to PrimaryAccountManager::HasUnconsentedPrimaryAccount with HasPrimaryAccount(ConsentLevel::kNotRequired) and removes the method. Bug: 2440621 Change-Id: Icacc73e23d7165e523d463d03967f9c5f71c9247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450019 Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
-
Koji Ishii authored
r813630 crrev.com/c/2448269 added the early return for hit- testing in NG. It turned out that the logic in |LayoutNGBlockFlowMixIn| was copied from |LayoutBox| in 2017 (r508056 crrev.com/c/710498) but the logic in |LayoutBox| has evolved since then. The new logic was then improved further and extracted to |LayoutBox::MayIntersect| in r814225 crrev.com/c/2448709. This patch changes LayoutNG to use the code instead. Note, we may need to add more early return checks to |NGBoxFragmentPainter|, e.g., |HitTestBlockChildren| and/or |HitTestChildBoxFragment|, but the early return itself has some costs. I will investigate the hit-testing in FragmentTraversal codepath and how much adding early return can improve in future patches. Bug: 1134574 Change-Id: Ibe95bfd5fdaafe1d3e6cd964f479eda98d48306a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452011Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#814604}
-
chrome://accessibilitydpapad authored
Also adding some minimal JS type checking. Bug: None Change-Id: I17a74b88666b5d8e17ab5ce65f0271392bb0ee00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444485 Auto-Submit: dpapad <dpapad@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
Abigail Klein <abigailbklein@google.com> Reviewed-by:
-
Jiewei Qian authored
LaunchSystemWebApp used whatever profile is provided in the parameter to create SWA windows and launching SWAs, even if the profile may not suitable to host a SWA window. This CL adds logic to determine the appropriate profile if the provided one is unsuitable. This serves as a mid-term solution for launching SWAs, and acts as a safety net to prevent chrome crashing if unsuitable profiles are provided. Specifically, it catches these two types of profiles: - Guest session "original" profile: launch into guest session's primary off the record profile (which is used for guest session browsing and SWAs). - Normal session incognito profile: launch into the original profile, because we don't support incognito SWAs. Fixed: 1109594 Change-Id: Ibe4a3b1bf7c811ef1ee02fd967307ad9bf070ee7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423760 Commit-Queue: Jiewei Qian <qjw@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#814602}
-
Milica Selakovic authored
|GetForWebContents| should only retrieve RuntimeManager for given web contents and |GetOrCreateForWebContents| should create instance if one does not exist. Bug: 1133783 Change-Id: Ib26162b69d1b3359fc571e139ba3724ec951aa12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453389Reviewed-by:
-
Francois Beaufort authored
This CL tracks the number of times a video capture device is accessed simultaneously to understand if Chrome should add some restrictions around simultaneous camera access. Test: Go to chrome://histrograms/Media.VideoCapture.NumberOfClients and access camera device from several tabs. Change-Id: I1a4bb4020ff13bd1ddc54a59094379115e2f65e5 Bug: 1134077 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440514 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
-
