- 03 Dec, 2019 40 commits
-
-
Fergal Daly authored
PROBLEM: Each event resolve a pending promise if set, however this is racy, sometimes it is set after the event. FIX: Switch to waiting until there is *at least* N events. We need to track more state in the test but we can cope with events arriving early. Bug: 1029238 Change-Id: If4c14b82907d5bb6460208e6218e84501b836ff9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946187Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#720764}
-
David Vallet authored
TEST=simple chrome Bug: 937152 Change-Id: Id7cdb80ee6390c78589a4ff8042b4f7ed911eb32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942670 Commit-Queue: David Vallet <dvallet@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#720763}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/33ae3e65534f..0724e61c3c58 Created with: gclient setdep -r src-internal@0724e61c3c58 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1013386,chromium:1017165,chromium:1024588,chromium:1026318 Tbr: jbudorick@google.com Change-Id: I95dab3f33c96bc7469b0cdccaa59cae85fdc712a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947425Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720762}
-
Clark DuVall authored
The top bar was still taking up space even though it is not needed in fullscreen. This also fixes a bug where pressing the back button did not exit fullscreen in the shell. Bug: 1029894 Change-Id: I215e8e1066670ba2e57d83114537b95c70186d99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946629Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#720761}
-
Thomas Anderson authored
This reverts commit bbfce899. Reason for revert: Issue should be fixed after https://chromium-review.googlesource.com/c/chromium/src/+/1937507/ lands Original change's description: > Revert PowerSaveBlockerLinux [2/4] > > and the subsequent PowerSaveBlockerLinux [3/4] and PowerSaveBlockerLinux [4/4] patches > > This reverts commit 2fdeba1b. ("Rewrite PowerSaveBlockerLinux [2/4]") > This reverts commit 38fdf074. ("Rewrite PowerSaveBlockerLinux [3/4]") > This reverts commit 3bc463b4. ("Rewrite PowerSaveBlockerLinux [4/4]") > > The patch caused timeouts in WakeLockTest.ChangeType() and other tests in the services_unittests on > Linux Tests (dbg). More details in crbug/1027852. > > TBR=thomasanderson@chromium.org > > Bug: 1013812,1027852 > Change-Id: I7688c72f9d9d6c12ff3731f3abde6a05508cfbeb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932357 > Commit-Queue: Tim Schumann <tschumann@chromium.org> > Reviewed-by: Tim Schumann <tschumann@chromium.org> > Cr-Commit-Position: refs/heads/master@{#718447} TBR=thomasanderson@chromium.org,tschumann@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1013812, 1027852 Change-Id: I84a6681cc8ec347587d38f0f5f38ed628e624274 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937509Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Tim Schumann <tschumann@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#720760}
-
Anand K. Mistry authored
Also NULL->nullptr at call sites to satisfy presubmit checks. Bug: 1007645 Change-Id: I2b1e30c68e4040f3e6e340f8c9e5f448998e2980 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943647Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#720759}
-
Sean Kau authored
Refactor is necessary so that we can have more Prefs binders than Settings binders when we have multi-profile. Making this change removes the refcounting logic that we had and allows the two binders to be owned by different classes. Bug: chromium:1015949 Change-Id: Icd341c511d31c7a2742bd50343726718262f5dad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935414Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#720758}
-
Dale Curtis authored
https://chromium.googlesource.com/external/github.com/videolan/dav1d.git/+log/564d3d9119da..39667c751d42 $ git log 564d3d911..39667c751 --date=short --no-merges --format='%ad %ae %s' 2019-12-02 jb Update NEWS 2019-12-01 martin arm: 32: ipred: Fix assembling with older binutils 2019-11-22 gramner Avoid excessive L2 collisions with certain frame widths 2019-11-25 janne-vlc build: do not error out if clock_gettime is not found on darwin 2019-11-22 gramner Specify inlining decisions for common ipred_z C functions 2019-11-26 me cli: Return only EXIT_SUCCESS or EXIT_FAILURE from main 2019-11-23 gramner tools: simplify get_seed on macOS 2019-07-29 jbeich checkasm: replace gettimeofday with clock_gettime 2019-11-22 jbeich tools: prefer mach_absolute_time on macOS for forward compatibility 2019-11-22 jbeich tools: mach_absolute_time is not portable, so stop checking at configure 2019-11-21 ltrudeau Avoid adding offsets to NULL pointers 2019-11-22 thresh snap: bump grade to stable 2019-11-23 gramner input: Use EIO instead of ENODATA 2019-11-22 martin annexb: Cast size_t to int before adding to an int 2019-11-17 rsbultje Fix accidental capital letter in variable name 2019-11-21 rsbultje Fix stride type 2019-11-21 martin section5: use signed type for seeking backwards 2019-11-16 rsbultje Add demuxer probing 2019-11-15 rsbultje Add section-5 raw OBU demuxer 2019-11-16 rsbultje Make OBU_* types public 2019-11-19 gramner Increase DAV1D_PICTURE_ALIGNMENT to 64 Created with: roll-dep src/third_party/dav1d/libdav1d TBR=tguilbert Fixes: 1027029 Change-Id: If00ab333797cb321a9323a3d1af8ae94d2e07fd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946877Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#720757}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ebec004c878f..ca84a4265921 git log ebec004c878f..ca84a4265921 --date=short --first-parent --format='%ad %ae %s' 2019-12-02 perezju@chromium.org [dashboard] Remove old code to allow point_id jump. Created with: gclient setdep -r src/third_party/catapult@ca84a4265921 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:632309 Tbr: nuskos@google.com Change-Id: If47a6eb32703404dbe12ead1fdd6ff65aa7aa40f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945806Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720756}
-
Yue Zhang authored
Bug: 1029419 Change-Id: I904d29eb86b61a4b8d13100e0146b868a5591af6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946871Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#720755}
-
Avery Musbach authored
Instead of a CanSnapInSplitview function referring to the root window of the argument window, there shall be a SplitViewController::CanSnapWindow function referring to the root window of the SplitViewController. Leveraging that, the split view drag indicators on each root window shall account for whether the dragged window can be snapped in split view on that root window. The present CL is also a step toward properly implementing functionality where you drag from one display to another and snap (see the TODO in OverviewWindowDragController::SnapWindow). Bug: 970013, 995413 Change-Id: I0e0b6d34ec8b3b3856d26fc5750bb062405f8dc6 Fixed: 961171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906931Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#720754}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7724a9414f89..a5287b0409dc git log 7724a9414f89..a5287b0409dc --date=short --first-parent --format='%ad %ae %s' 2019-12-02 lalitm@google.com trace_processor: add helper methods for adding constraints on typed cols Created with: gclient setdep -r src/third_party/perfetto@a5287b0409dc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ieae4be878290a28b3178aff2a4eece571576f359 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947062Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cdf1bc3bd32e..8ebac1732c99 git log cdf1bc3bd32e..8ebac1732c99 --date=short --first-parent --format='%ad %ae %s' 2019-12-02 mtklein@google.com remove T*/void* union in SkTArray 2019-12-02 mtklein@google.com tweak for GCC, memcpy() -> for-loop 2019-12-02 mtklein@google.com remove pointless tests 2019-12-02 egdaniel@google.com Update GrSwizzle to only store key and not string. 2019-12-02 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-12-02 bsalomon@google.com This is a reland of GrDomainEffect with significant changes: 2019-12-02 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-12-02 michaelludwig@google.com Compare textureType separately from backend format Created with: gclient setdep -r src/third_party/skia@8ebac1732c99 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bsalomon@google.com Change-Id: I38c8d2b69f4c26225cf756f137afae9bd971986e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947289Reviewed-by:
-
Sebastien Marchand authored
Change-Id: I1e58983e062d03f2c8532d6b7ed282509a625371 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943349 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#720751}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/02b5af35755b..6d31ed5d639e git log 02b5af35755b..6d31ed5d639e --date=short --first-parent --format='%ad %ae %s' 2019-12-02 ehmaldonado@google.com cpplint: Fix Python 3 errors. Created with: gclient setdep -r src/third_party/depot_tools@6d31ed5d639e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1027160 Tbr: agable@chromium.org Change-Id: I5b78c8a634cb0b15fb8026298f5fc7cfa1658510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947303Reviewed-by:
-
Changwan Ryu authored
You can set frequency, duration, recording method, among other things in record_options. Especially, frequency seems makes some difference in terms of coverage and accuracy. Alternative considered: exposing frequency, duration, recording method separately. There are many other options for record_options, so adding numerous args would make it too complicated. Bug: 1015236 Change-Id: I081e95a7f02a3d54dba3b5a0f55291deb309b4bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946019Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#720749}
-
Maggie Chen authored
in_gpu_initialization_ was set by the GPU main thread and read by the watchdog thread. This caused data race. This CL fixes it by setting the flag in the watchdog thread only after the init in the constructor. Bug:1029475, 1028946 Change-Id: I5c38a2af70962e0d68880e930b6657f7107d2def Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943545Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#720748}
-
Adrian Taylor authored
Change-Id: I661e2983db1324459fc6a112be00c908f6ba85e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938034 Auto-Submit: Adrian Taylor <adetaylor@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#720747}
-
Xiaoqian Dai authored
The overview gesture kDragFromShelfToHomeOrOverview feature is disabled by default, and is only enabled on the devices that has hotseat feature enabled (i.e., on Krane and on Dogfood devices). Bug: 1029991, 997885 Change-Id: I2e783b099160b42b03e452d6e4ec044504973c19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946881Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#720746}
-
Toni Barzic authored
The search result page opacity might get set to a partially opaque value during app list drag - this resets the opacity to 1.0 before showing app list view again (in case the app list was dragged really close to shelf before closing, in which case last opacity set on the layer might have been small). This should not affect initial search result page appearance (as the page starts in invisible state). BUG=1027805 Change-Id: I7a5fbd22647f976a22a39aa61a4f44ab03756215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936108Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#720745}
-
Jarryd authored
The current All Sites page forces users to go into site details to clear data for any site with only 1 origin listed in the siteGroup. This change saves the user from having to do so, and lets them clear data and reset permissions directly from the all sites page. Bug: 997258 Change-Id: I186439d73330f8489149f849e68dfc98db2b26c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884579 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#720744}
-
Kenny Levinsen authored
Pulls latest stable of wayland-protocol to get a few minor spec fixes to xdg-shell stable before we implement support for it. Also pulls in latest stable of wayland core, as the in-tree version at the time of commit is 3.5 years old, with upstream containing many fixes since then. Bug: 997631 Change-Id: I135ef605635b9f50576d078cd024aa7901805126 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937075 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#720743}
-
Ian Struiksma authored
Verified different states of tests from top 275 autofill list. This meant adding a 25 that had been failing previously and doing an audit of failure reasons. Also, sorted them in the json file as the states should be steady now. Includes update to cipd version for autofill wpr/test files. Bug: 984664 Change-Id: I0b506140dd62679e5fef5928cff160ac0694476f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937508Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Ian Struiksma <ianstruiksma@google.com> Cr-Commit-Position: refs/heads/master@{#720742}
-
Vadim Bendebury authored
Much more Cr50 versions were released since last update, this patch brings the enum list up to date. The same python script (now attached to the bug) was used to generate version strings for all images. BUG=chromium:728134 TEST=None Change-Id: I4c276cd61ce0c2e021d9d2d884fb878d29c9c27d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946453 Auto-Submit: Vadim Bendebury <vbendeb@chromium.org> Reviewed-by:
-
Dan Harrington authored
suppress.py outputs XML tags in sorted order, which makes seeing the changes difficult when suppressions.xml is not sorted. I've re-ordered tags in this file so that running suppress.py results in no diff beyond missing comments. Added a note at the top to suggest inserting tags in sorted order. There should be no material changes to suppressions.xml in this CL. Change-Id: I43b8ad4928bc6262e486bcba71aa2c0bb282c1f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947227Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#720740}
-
Kyle Milka authored
Wire up QRCode sharing feature to the sharing hub. Bug: 1009124 Change-Id: Ie3aa5723f90ec7ea54989e7ebe85dff1fc3dd42e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888736 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#720739}
-
behdad authored
Instead of the averages the CI_095 was being used for comparison. This bug was introduced at: https://chromium-review.googlesource.com/c/chromium/src/+/1856824 Bug: chromium:1029946 Change-Id: If8486e10c12fe620a3b7256d14d8590cfbc2ab0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947047Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#720738}
-
David Trainor authored
This metric was set to expire in M77, but is used in conjunction with the others that do not expire to understand the browser landscape and Chrome's default usage on the device. Removing M77 because this is an ongoing thing we'd like to track. Change-Id: I263a73f145fb6bd44e496bb2afbb42295eb808f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625270 Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Auto-Submit: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#720737}
-
Hector Carmona authored
Bug: 854362 Change-Id: I3efd2b9294204005ff02d55eccfae91507b44550 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928237 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#720736}
-
Anand K. Mistry authored
Bug: 1007645 Change-Id: Iae95405396c6bc7b1eef1cf91113bcb16c53e134 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942748Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#720735}
-
Jordan Bayles authored
https://chromium.googlesource.com/openscreen/+log/fddca10f23f5..1ab48f99911c $ git log fddca10f2..1ab48f999 --date=short --no-merges --format='%ad %ae %s' 2019-11-29 jophba Fix for Chrome-only fuzzer code compile bug 2019-11-27 rwkeane mDNS: Publisher Skeleton 2019-11-22 miu Minify platform/api/time.h by splitting-out traits definitions. 2019-11-27 rwkeane mDNS: Responder + Publisher API 2019-11-27 mfoltz [OSP] Remove name aliases. 2019-11-26 miu Move SerialDeletePtr to util, clean-up ScopedWakeLock platform/api. 2019-11-26 mfoltz [Open Screen] MdnsQuerier shared and unique record support. 2019-11-26 mfoltz [Open Screen] Add missing alias. Created with: roll-dep src/third_party/openscreen/src Change-Id: I9b4190d335a862738d43ce8118583fc27695d62f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946692 Commit-Queue: Jordan Bayles <jophba@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#720734}
-
Karan Bhatia authored
This was an existing TODO from a previous round of review. BUG=974391 Change-Id: If2776d1146e757795ceb1abcae949886094fc97a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937581 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#720733}
-
Shimi Zhang authored
With https://crrev/c/1925239, PrintingControllerImpl.getInstance() will always give an non-null instance, we don't need to check if it is null or not anymore. Chrome for Android doesn't support less than KitKat, so we could remove few checks and annotations now. Bug: None Test: Current tests should pass, manually tested window.print() and share Test: menu code paths. Change-Id: Ia0a9e41c0eef6d693b39547646e462bb4af4292c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928629Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#720732}
-
nancy authored
Move below unit tests to AppService folder, because they use AppServiceAppModelBuilder for test: CrostiniAppModelBuilderTest ExtensionAppModelBuilderTest InternalAppModelBuilderTest BUG=1016159 Change-Id: I2aef91d4bb3b847a8861dca6b692bd0d92f0c4de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942897Reviewed-by:
-
Anqing Zhao authored
Bug: 1010213 Change-Id: I53f0d6a2bb4939fc229dbe6a730fa185a1c2da9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940278Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Anqing Zhao <anqing@google.com> Cr-Commit-Position: refs/heads/master@{#720730}
-
Tao Bai authored
Check if ContentCaptureReceiver is valid before start capture. Also, add a DCHECK() to the other call site of ContentCaptureReceiverForFrame(). Bug: 1029678 Change-Id: Iaed486b6a7e9b322174e06fc0469defd5babb2c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947284Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#720729}
-
Tobias Sargeant authored
This CL provides an API to the embedder for receiving crash notifications, and triggering upload or deletion of crashes. It is designed so that the notification can be used to trigger an upload job to execute later (potentially in a different process) without fully initializing weblayer. A number of things in the minidump_uploader (chiefly MDUploadCallable -> MinidumpUploader) have been forked. The intention is to unfork immediately after this patch. Doing so will address existing TODOs in the component, and address some existing separation of concerns issues. Bug: 1027076 Test: run_weblayer_support_instrumentation_test_apk -f '*CrashReporterTest#*' Change-Id: I86b9b37830014c468fd69cf99a67f6f00809f9fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940271 Auto-Submit: Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#720728}
-
Ben Pastene authored
This makes the usage a little more clear, especially in a future world where (hopefully) no one is running the `cros chrome-sdk` scripts directly, subsequently making the phrase "cros_chrome_sdk" meaningless. As we replace/deprecate Simple Chrome, this arg will start showing up in many build files, so it's important that its purpose is clear in its name. eg: http://crrev.com/c/1922977/9/ui/events/ozone/BUILD.gn Bug: 937821 Change-Id: I967aa9498ed04e351b9423bc75939632ad01fd7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925330 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#720727}
-
Tim Volodine authored
Make sure to add a renderer-side safebrowsing throttle in order to check renderer initiated url loads using the safebrowsing API. This also ensures that resource requests for e.g. .js and .svg files are also checked. This approach matches the behavior in WebView and Chrome. Due to the addition of methods the original safebrowsing initialization sequence is slightly changed (see below for details). Additionally the ResourceContext destruction has to happen on the IO thread (see below for details). In particular in this patch: - Add and implement ExposeInterfacesToRenderer method to make sure renderer can execute safebrowsing calls. - Move safebrowsing_service initialization to the ExposeInterfacesToRenderer() method because it is executed before CreateURLLoaderThrottles. - Implement UrlLoaderThrottleProvider in weblayer/renderer/ which amongst other things adds the safe_browsing::RendererURLLoaderThrottle. - Implement RenderThreadStarted() and CreateURLLoaderThrottleProvider() methods for ContentRendererClient. - Update build and deps files accordingly. - Also make sure to destroy ResourceContext on the IO thread (otherwise profile destruction sequence can result in a DCHECK, see crbug.com/1029317). BUG=1015418,1028659,1029317 Change-Id: I67482a450d1974a8b14cb07f4fbedd14e4983e7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937173 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#720726}
-
Anand K. Mistry authored
Bug: 875700 Change-Id: I81cd3b54b1119e9475ee4653efcd4817d4ea4a39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943786Reviewed-by:
Austin Tankiang <austinct@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#720725}
-
