GitLab

This reverts commit 03914101.

Bug: 827599
Change-Id: I40ed04058540604fe58b30f666fdb87041e9cb29
Reviewed-on: https://chromium-review.googlesource.com/1166232Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581646}

This change replaces the PassGamepad interface usage with
SerializeAndDeserialize() which is the modern and simpler way of testing
struct traits. Also, gamepad_mojom_traits_unittest.cc is moved to
//device/gamepad/public/cpp.

Bug: 612330
Change-Id: I9e8ebe3e8d62a08503d1aa24fdec39f9af280134
Reviewed-on: https://chromium-review.googlesource.com/1164404Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581645}

This change fixes a regression where the icon is not visible on Mac
and Windows platforms.

Bug: 870652
Change-Id: Id1649a113e13b0168f197c8e53fc91e61655bab2
Reviewed-on: https://chromium-review.googlesource.com/1166450Reviewed-by: apacible <apacible@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581644}

The implementation of DevToolsFileWatcher::RemoveWatch was calling
DevToolsFileWatcher::AddWatchOnImpl. Each call to
DevToolsFileWatcher::AddWatchOnImpl would create [potentially] hundreds of
thousands of file watchers, depending on the directory being watched.

This is likely the cause of an observed 40GB leak in the wild.

Bug: 810155
Change-Id: I61449ec232bba639bfeff2e1094c86d00e23665f
Reviewed-on: https://chromium-review.googlesource.com/1163930Reviewed-by: Alexei Filippov <alph@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581643}

Bug: 871422
Change-Id: I76e5faebaa2f2f338bbb27bfaefe097f9006474a
Reviewed-on: https://chromium-review.googlesource.com/1165268
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581642}

The path was needed in SPv1 when we issued transforms as display items
for some layers. Now we can use the normal paint path for those layers
with paint properties.

This also fixes the crash on print bug.

Bug: 869917

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Idc5d61c2703b778604c48b3fc74712b19f3632c3
Reviewed-on: https://chromium-review.googlesource.com/1164468
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581641}

When undoing a close all tabs action, the recently closed tabs would
continue to show all the tabs. This CL properly removes the restored
tabs by removing them from the TabRestoreService.

Bug: 846786
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I3c02270cd8f4e9998f3e51032f5973fe0329bf6e
Reviewed-on: https://chromium-review.googlesource.com/1167118Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581640}

Change-Id: I8a6d9f3096c04667dc729b8754c4e5adb82b0b4e
Reviewed-on: https://chromium-review.googlesource.com/1167058Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Farah Charab <farahcharab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581639}

The singleton/switch-to-tab browser tests, which happened to load
Maps and chrome://settings, were taking so much time, that on
Windows, they were timing out. By using simpler sites and loading
settings asynchronously, the time is cut in half.

Bug: 822071
Change-Id: I73e6de0e8a7c13e1670c8daa76d18c2acb9cc9d4
Reviewed-on: https://chromium-review.googlesource.com/1165797Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581638}

This CL fixes the issue when the view for ConsentBumpFragment was
displayed without the data related to the selected account. This was
caused by the following flow:
1. ConsentBumpFragment is displayed.
2. "More options" is clicked, opening ConsentBumpMoreOptionsFragment.
   ConsentBumpFragment is kept in FragmentManager back stack.
3. "Back" in ConsentBumpMoreOptionsFragment is clicked, popping the back
   stack entry.
4. To display ConsentBumpFragment again, FragmentManager recreates
   the view by calling ConsentBumpFragment.onCreateView.
5. The view is displayed without profile data.

Bug: 869426
Change-Id: Ia63c4df694cad921794ce8c9ab8e2e22b81f9c17
Reviewed-on: https://chromium-review.googlesource.com/1167520Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581637}

There are two bugs fixed here:
First, restoring a minimized window causes letterboxing in some cases:
GetClientAreaInsets as calculated by BrowserDesktopWindowTreeHostWin
is scaled by the DPI for the associated HWND.  That works great except
when restoring a window from a minimized state, during which the window
is in some weird off-screen no-man's-land and is not actually on any
display.  GetSystemMetricsForHWND() defaults to the closest display in
this case, and if that guess is wrong, you can get letterboxing.

This CL passes in the correct scale factor explicitly, so OnNCCalcSize
can pass in the scale for the display that the window is being restored
to.

Second, some setups always have (less noticeable) letterboxing.  This is
simply fixed by using the GetSystemMetricsForDpi API (if it's available)
instead of scaling the results of GetSystemMetrics ourselves and getting
letterboxing if Windows did not scale the same way.

Bug: 656730
Change-Id: I4eedce3fc3ef427e0986f086623094152940ba2b
Reviewed-on: https://chromium-review.googlesource.com/1149273Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Taylor Bergquist <tbergquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581636}

It used to show when enter or exit tablet mode. But with new tablet mode
disambiguation the keyboard may be disabled when in clamshell mouse with
external mouse connected.

Users will still need a way to enter overview in flip or tablet form
factor with external mouse connected, so check if the keyboard is
disabled instead of tablet mode is on or off.

It seems shelf was waiting for status area widget to change bounds to
update to tablet mode shelf ui (back button visible and other items
shifted). Now that overview tray may not change visibility on enter/exit
tablet mode, status area widget bounds may remain the same. So shelf ui,
needs to be updated directly.

Also fix a bug with users being able to leave tablet mode with external
mouse when force-tablet-mode is set to tablet mode.

Test: Added tests
Bug: 870458
Change-Id: If8cd6e14d90238e87d1695b8f59ef167d9420479
Reviewed-on: https://chromium-review.googlesource.com/1163913
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581635}

On tablets the toolbar more or less stays consistent between the NTP and
regular web pages so it feels less jarring to leave the clear tab button
visible.

BUG=871905

Change-Id: I41689586facd855869852ecec8b044295bf15a12
Reviewed-on: https://chromium-review.googlesource.com/1165532Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581634}

The VideoDecodePerfHistory is used to make smoothness predictions for
the MediaCapabilities API. For normal profiles, the perf stats are to
a saved to small DB on disk. For incognito profiles we instead save the
stats "in memory" and they disappear when the session ends.

The lines removed in this change "seeded" the Incoginto profile with
the performance stats of the original profile. This has caused some
crashes because we appear to be using the seed DB after its freed (or
perhaps corrupted).

The root cause is not yet known, so the temporary fix is to simply
stop providing a seed DB for incognito. This is already the case for
Guest profiles (no notion of an originating profile) and for any
new on-the-record profile.

The impact will be fairly small, as it only takes ~30 seconds of
playback for enough new stats to accrue such that prediction quality
is unaffected.

In a follow up (after the release) I will revert this
and add some observer code to CHECK when seed_db_ is destroyed before
the InMemoryDB.

Bug: 865321
Change-Id: I103b4679bcfa99310d44f4bb810db0535f2d44f0
Reviewed-on: https://chromium-review.googlesource.com/1167514
Commit-Queue: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581633}

This CL removes the member var |previous_image_release_callback_|
and method DrawingBuffer::SwapPreviousFrameCallback(), because
they are not used in a meaningful way.

It's extracted from junov@'s crrev.com/c/1103011.

Bug: 839970
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I0c410d5181ceb973843f74bc7e419e7e8305baf7
Reviewed-on: https://chromium-review.googlesource.com/1165833Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581632}

By an investigation inspired by crbug.com/870178, a few
problems were found in computing kMaxCharacterIndex.

1. Often the number of glyphs is compared with
   kMaxCharacterIndex. This is meaningful only when code
   point:glyph is 1:1.
2. Because limiting the number of glyphs is important to
   reduce reallocations, this patch adds kMaxGlyphs.
3. In RTL, the logic did not handle when character_index
   is in descending order.
4. Makes sure runs are split at cluster boundary.
5. Take the check out of the loop to ensure vectors
   allocated before the loop don't need reallocations.

A couple of notes:
1. By taking this logic out of the loop, we can probably
   do this before allocating RunInfo, and thus avoid all
   reallocations related to kMaxCharacterIndex and
   kMaxGlyphs. Haven't looked into it much yet.
2. The ordering maybe still incorrect, especially in RTL.
   May need more tests and a few more iterations.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I8d70435c9f28287206b41831f68e7183d61fafcb
Reviewed-on: https://chromium-review.googlesource.com/1166768
Commit-Queue: Koji Ishii <kojii@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581631}

Device-policy wallpapers are not blurred. A blurred wallpaper is required for
readability of the UI elements. To increase readability when the wallpaper is
not blurred, draw dark rounded rectangles around the user views and the shelf.

Bug: 839604
Change-Id: I560613402bc37feb5f7fd02dd29b86c3eb10cc5d
Reviewed-on: https://chromium-review.googlesource.com/1138861
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581630}

Change-Id: I775a9de0e99e4e45b2facfccb6e79e17c9c41b90
Reviewed-on: https://chromium-review.googlesource.com/1167204
Commit-Queue: Mike Klein <mtklein@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581629}

https://boringssl.googlesource.com/boringssl/+log/c7db3232c397aa3feb1d474d63a1c4dd674b6349..6410e18e9190b6b0c71955119fbf3cae1b9eedb7

BUG=none

Change-Id: Ib6b65420f57dcffed50898113d7f910ee4a332f4
Reviewed-on: https://chromium-review.googlesource.com/1167469
Commit-Queue: Steven Valdez <svaldez@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581628}

This is done to avoid a runtime crash at startup when
Chrome starts up on devices with a very old Linux kernel.

This is only one way to address the problem, but probably
the simplest patch to fix it. See bug entry for all details
and alternatives considered.

BUG=871722
R=agrieve@chromium.org, pcc@chromium.org, thakis@chromium.org

Change-Id: I9a197a347538ae9cf9ce6de7b243f522cb425043
Reviewed-on: https://chromium-review.googlesource.com/1167502Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: David Turner <digit@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581627}

The whitelist list irrelevant to the EasyUnlock prefs and we are about
to move at least one of them to a new location. Rather than update this
unecessary reference, I'd like to just get rid of it before the
migration.

Bug: 824568
Change-Id: Id9a90fff2139f665c9696f104f45bc6590decb93
Reviewed-on: https://chromium-review.googlesource.com/1166286Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581626}

Also move README.chromium up one level as it's expected by
tools/licenses.py.

TBR=tinskip@chromium.org

Bug: 729194
Change-Id: I52551222bf635d5e525d7baa0580243d0a30aa8a
Reviewed-on: https://chromium-review.googlesource.com/1166325
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581625}

This makes sure other always_on_top windows won't be covered
by the divider.

Bug: b:112266826
Test: locally build and start assistant in split view, see assistant
Test: window always above divider.
Change-Id: I7183a4fc01c1bd831bf73e99d90300b0ea803a7e
Reviewed-on: https://chromium-review.googlesource.com/1166255
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581624}

https://android.googlesource.com/platform/external/perfetto.git/+log/f8335664915c..964e15665fbc


git log f8335664915c..964e15665fbc --date=short --no-merges --format='%ad %ae %s'
2018-08-08 treehugger-gerrit@google.com Merge "TraceProcessor: add support for complete JSON events"


Created with:
  gclient setdep -r src/third_party/perfetto@964e15665fbc

The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: Icfacdbc0efed246c419731c0684a8f17afd0ed27
Reviewed-on: https://chromium-review.googlesource.com/1167126Reviewed-by: perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#581623}

Removes the "Offline" string from the XML and moves it to Java to allow
it to be chosen dynamically. See bug for more context.

Also fixes the text appearance presubmit stuff from
https://crbug.com/775198

Bug: 871839
Change-Id: I0973b1e874f48dd4b913bbe1467b245971fdc335
Reviewed-on: https://chromium-review.googlesource.com/1166155Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581622}

This allows for multiple Envs at the same time. Additionally:
. NativeWidgetPrivate::CreateNativeWidget: now takes InitParams
. NativeWidgetPrivate::IsMouseButtonDown() is now an member function.

BUG=847992
TEST=covered by tests

Change-Id: Ic35b274c0a927a7c602809a7e611383b5d3dd3e2
Reviewed-on: https://chromium-review.googlesource.com/1166148
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581621}

Bug: 871200
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I73ec397b9fcc9d243766753e2251ba261c443022
Reviewed-on: https://chromium-review.googlesource.com/1164256Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581620}

Remove InvalidateBackgroundObscurationStatus() from various
UpdateLayout() methods, and call it from UpdateAfterLayout() instead.
LayoutNG doesn't use UpdateLayout(), but it does still call
UpdateAfterLayout() when it has done its layout thing.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I3467d3c466e9c02885ffd7153d71f17e2c12da3a
Reviewed-on: https://chromium-review.googlesource.com/1166917Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581619}

This test appears to have timing/scheduling-dependent flakes.

TBR=miu

Bug: 872340
Change-Id: I92a42315b4b5e15bfae88f5b7430b4e0210a3ea7
Reviewed-on: https://chromium-review.googlesource.com/1167560Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581618}

This change moves the logic from DeviceOrientationDispatcher into
DeviceOrientationEventPump and removes DeviceOrientationDispatcher.
DeviceOrientationController now uses DeviceOrientationEventPump directly,
and a separate instance of DeviceOrientationEventPump is created for
every document. Webkit layout tests were updated to reflect this, and
webkit unit tests have been updated to use a MockDeviceOrientationController.

Bug: 861902
Change-Id: I1c376ec54208abb3fcfb627304f47a4cbd01894d
Reviewed-on: https://chromium-review.googlesource.com/1161446
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581617}

This was used in the code-path where animation of images was driven by
blink, which is not the case anymore.

R=pdr@chromium.org, ericrk@chromium.org

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ie1ba09724b87e461e41d0675c9132a0d8fb655dd
Reviewed-on: https://chromium-review.googlesource.com/1161562Reviewed-by: enne <enne@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581616}

The method returns an object that needs to be released. All existing
callers were failing to do so.

Change-Id: Ic50117c3359004b958a6c373ab4acaec826abc0e
Reviewed-on: https://chromium-review.googlesource.com/1167365
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581615}

This implements slide #13 of the spec attached to the bug.

When we enable the new unified autoplay sound settings UI the
sound settings dropdown on the page info UI should have custom
wording based on the state of the sound content setting and
the unified autoplay enabled pref.

BUG=865548

Change-Id: Ib7fcb5625cc9f71add1f84ca5dbf6301aefc1007
Reviewed-on: https://chromium-review.googlesource.com/1158857
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581614}

This was already happening on tablet mode. Ux said it is ok to match
the two now. Also change some values for the header fade in animation.

Test: manual
Bug: 829292
Change-Id: I428081f0d19d1b8508e8576f5ea8a36e75843e6b
Reviewed-on: https://chromium-review.googlesource.com/1164534Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581613}

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Ib62c9cdd67d33019d2e80df59c2a4ead4357691a
Reviewed-on: https://chromium-review.googlesource.com/1165142Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581612}

This dependency is no longer required, this CL just cleans up some
includes and makes a minor change to
FakeAuthPolicyClient::RefreshUserPolicy to remove the cryptohome
dependency and support tests.

For minor fix to chrome/browser/chromeos/policy/ includes:
TBR=emaxx@chromium.org

Bug: 863439
Change-Id: I519ea33d7e5ad9355c45bfc172f97a4cb51b8122
Reviewed-on: https://chromium-review.googlesource.com/1165491
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581611}

CompositeOpaqueScrollers has been shipping since M56.
https://codereview.chromium.org/2450473002

BUG=644833, 651305

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I2efd8b92d96177ebfa45b360c02a5cf5e31a18dc
Reviewed-on: https://chromium-review.googlesource.com/1166611Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581610}

This reverts commit 9871f52a.

Reason for revert: <INSERT REASONING HERE>
Was not the culprit of failing chromeos dbg SpokenFeedbackTests.


Original change's description:
> Revert "Always build ChromeVox as compressed js"
> 
> This reverts commit 725ceeda.
> 
> Reason for revert: Broke lots of tests on https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg
> 
> chromevox test:
> BackgroundTest.NavigationEscapesEdit
> 
> interactive_ui_tests
> TestAsNormalAndGuestUser/SpokenFeedbackTest.OverviewMode/0
> TestAsNormalAndGuestUser/SpokenFeedbackTest.OverviewMode/1
> TestAsNormalAndGuestUser/SpokenFeedbackTest.OpenStatusTray/0
> TestAsNormalAndGuestUser/SpokenFeedbackTest.OpenStatusTray/1
> TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxNextTabRecovery/0
> TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxShiftSearch/0
> TestAsNormalAndGuestUser/SpokenFeedbackTest.FocusToolbar/1
> TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxShiftSearch/1
> TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxNextTabRecovery/1
> LoggedInSpokenFeedbackTest.KeyboardShortcutViewer
> TestAsNormalAndGuestUser/SpokenFeedbackTest.FocusToolbar/0
> TestAsNormalAndGuestUser/SpokenFeedbackTest.FocusShelf/0
> TestAsNormalAndGuestUser/SpokenFeedbackTest.FocusShelf/1
> GuestSpokenFeedbackTest.FocusToolbar
> 
> 
> Original change's description:
> > Always build ChromeVox as compressed js
> > 
> > ChromeVox can be run as both compressed (minified js) and uncompressed. The latter facilitates faster development.
> > 
> > It appears that in some instances, with the kevin board in particular, gn evaluates the ChromeVox build file incorrectly.
> > 
> > The end result is we end up with both uncompressed and compressed js files in ChromeVox leading to duplicate js objects.
> > 
> > Bug: 868579
> > Test: clean build for
> > 1. prior to this patch
> > 2. after this patch
> > 
> > Before each deployment, ensure we delete the chromevox folder on-device. This should be equilvanet to a new image.
> > 
> > Change-Id: I64cf826bda9239edc7764ba598bfed6dd0572d56
> > Reviewed-on: https://chromium-review.googlesource.com/1165787
> > Reviewed-by: Alex Newcomer <newcomer@chromium.org>
> > Commit-Queue: David Tseng <dtseng@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#581325}
> 
> TBR=dtseng@chromium.org,newcomer@chromium.org,oxyflush@google.com
> 
> Change-Id: Ifb3c2556f44b07161f491b18b49d556e364963fb
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 868579
> Reviewed-on: https://chromium-review.googlesource.com/1167442
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Commit-Queue: Avi Drissman <avi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#581564}

TBR=avi@chromium.org,dtseng@chromium.org,newcomer@chromium.org,oxyflush@google.com

Change-Id: Ifb1ec50fd3cbaa1e0b97a5b5cfdb7b3b9712b353
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 868579
Reviewed-on: https://chromium-review.googlesource.com/1167604Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581609}

Bug: chromium:653531
Change-Id: I3d9741962cd3845a5f351587509c5beb4e27c796
Reviewed-on: https://chromium-review.googlesource.com/1164949Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581608}

This reverts commit feb758c3.

Reason for revert: <INSERT REASONING HERE>
SpokenFeedbackTests failing on chromeos dbg
Original change's description:
> Only alert accessibility when a notification's text changes
> 
> Bug: 867426
> Change-Id: I7f220566f3e7a2b4ce7ef639d012f4323b762208
> Reviewed-on: https://chromium-review.googlesource.com/1166231
> Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> Commit-Queue: David Tseng <dtseng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#581474}

TBR=stevenjb@chromium.org,dtseng@chromium.org

Change-Id: I8b23c03e08642caa7b05d2ce88e6f330dd056c37
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 867426
Reviewed-on: https://chromium-review.googlesource.com/1167603Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581607}