- 22 Dec, 2017 40 commits
-
-
lgcheng authored
When add a view with complicated children layers to parent, the Z order of children layers is not respected. TBR=sky@chromium.org Bug: 797396 Test: Add unit_test to descibe the bug. Change-Id: I017d857ec64242ba22b79575b0cb768869dc5ea4 Reviewed-on: https://chromium-review.googlesource.com/843446 Commit-Queue: Long Cheng <lgcheng@google.com> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#526088}
-
Sean Kau authored
Change ExternalPrinters to perform slow operations off the UI thread to avoid introducing jank. Also add infrastructure to observe preferences and manage instances by user. Bug: 758680 Change-Id: I56f4dae9f0c2062cfe177fcdac88785978874217 Reviewed-on: https://chromium-review.googlesource.com/826705 Commit-Queue: Sean Kau <skau@chromium.org> Reviewed-by:
Xiaoqian Dai OOO until Jan 2nd <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#526087}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/0482ced2cd10..707719ceeeec $ git log 0482ced2c..707719cee --date=short --no-merges --format='%ad %ae %s' 2017-12-22 angle-deps-roller Roll skia/third_party/externals/angle2/ 2b7bbc282..06f863774 (1 commit) 2017-12-22 bsalomon Rearrange GRTC::drawPath() 2017-12-22 csmartdalton Revert "CCPR: Initial semi-optimized vertex shader Impl" Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=csmartdalton@chromium.org Change-Id: Id0c73a1c0f98c977c56f427fda97e50cccbd509a Reviewed-on: https://chromium-review.googlesource.com/843009Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#526086}
-
Peter Boström authored
* Rename "More Options" back to "Options" (distinguisher no longer necessary). * Update in-progress title to "Translating...". * Update done title to "Translated". * Show "Options" menu from done panel. * Move "Always translate" checkbox inside advanced panel. * Remove "Language settings" link from advanced panel (not slated for updated UI either). * Update "never" options to state "Don't translate X" instead of "Never translate X". Also replaces the views::MenuButton with a Harmony-compliant bubble and updates the option menu on every click so any language changes done inside the advanced panel are reflected in the menu outside. TBR=tapted@chromium.org Bug: chromium:730521 Change-Id: I2e05bdacfb7c9e487e4f7f32e7934ba521ef54bd Reviewed-on: https://chromium-review.googlesource.com/832850 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#526085}
-
Sammie Quon authored
See bug for screenshots of the bug. Test: manual Bug: 797236 Change-Id: Ibcb145a0c4ef126b1937aa302eb121e2a013de40 Reviewed-on: https://chromium-review.googlesource.com/842478 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#526084}
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/11556464a62e..0be3851088f8 $ git log 11556464a..0be385108 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtcBUG=None,None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib4afef7b29c98c782bb5c651503466af817ad7c9 Reviewed-on: https://chromium-review.googlesource.com/843373Reviewed-by:
WebRTC Roll Bot <webrtc-autoroll@chromium.org> Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#526083}
-
Kurt Horimoto authored
If a user taps on a CardView during the presentation animation, and the card's corresponding WebState is closed before the presentation finishes, we should not attempt to dismiss the stack view and show the tapped card's Tab. This will result in a crash because the WebState's UserData (which owns its corresponding Tab object) has been destroyed. Bug: 792511 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I2989230867982d7f419192b063c6565af1ae96c9 Reviewed-on: https://chromium-review.googlesource.com/843419Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#526082}
-
Koji Ishii authored
When no glyphs are found in the source text to shape, and if HarfBuzzShaper decided not to create a run instead of creating an empty run, ShapeIndexForResult does not work. This patch fixes the situation by creating an empty run. Note, in order to avoid the risk of the synthesized run affects existing layout, it creates only when the start is not zero. Only LayoutNG uses this case. Bug: 794149 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Id3980fc4bb0f76cf86d08be138ca2876618f7423 Reviewed-on: https://chromium-review.googlesource.com/842603Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#526081}
-
Brad Nelson authored
600 memories puts a high burden on implementions, reducing for now to 20. R=eholk@chromium.org Bug: Change-Id: If2e9b9b0e550ade8a05b036d539d0ac01b2142de Reviewed-on: https://chromium-review.googlesource.com/842845Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Brad Nelson <bradnelson@chromium.org> Cr-Commit-Position: refs/heads/master@{#526080}
-
Roger McFarlane authored
Part 1 of many. BUG=797289 R=sebsg@chromium.org Change-Id: Ic7f85eddbff9555a5cc51d73d1148906da28129a Reviewed-on: https://chromium-review.googlesource.com/843084 Commit-Queue: Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#526079}
-
Johann authored
All 'UNKNOWN' files have been fixed. Check now passes cleanly. BUG=chromium:98319 Change-Id: Ie7095592ee2875ff672992bb858fe9c2f844b7b6 Reviewed-on: https://chromium-review.googlesource.com/843458Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#526078}
-
Hiroki Nakagawa authored
This CL moves a part of files in modules/fetch to core/fetch. Fetch is a primitive mechanism and should be available in core/. See the issue for a use case. Previous CLs: (1) https://chromium-review.googlesource.com/c/chromium/src/+/841903 Bug: 794837 Change-Id: Ice42e2a201b9c6833232c94daa049550ce29e3ac Reviewed-on: https://chromium-review.googlesource.com/842383 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#526077}
-
Eugene Ostroukhov authored
1. Preview will now attempt to deduce content type from the mime type and not the resource type. Images loaded via fetch will now be properly shown. 2. "Response" type will now recognize SVG as a text file and show the source code. Bug: 688563 Change-Id: Ie0ec2e46314e0d71ecc69e0517984bcdb3a2f755 Reviewed-on: https://chromium-review.googlesource.com/837731Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org> Cr-Commit-Position: refs/heads/master@{#526076}
-
Roger McFarlane authored
BUG=797353 R=sebsg@chromium.org Change-Id: Ibbf0db72bc76f4c08bd85b84616d0a27874a203c Reviewed-on: https://chromium-review.googlesource.com/842951 Commit-Queue: Roger McFarlane <rogerm@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#526075}
-
Marijn Kruisselbrink authored
This reverts commit 56ddd032. Reason for revert: looks like it might be causing crashes in syncxhr Several synxhr tests started crashing somewhat regularly after this landed (see bug for details), reverting to see if this change is actually to blame. Original change's description: > [mojo-loading] Remove ChromeIPC code > > This CL removes all ChromeIPC messages defined in resource_messages.h. > The removed code include: > > - components having counterparts in mojo-loading: > - async_resource_handler > - sync_resource_handler > - components implementing features we are no longer using: > - resource_message_delegate > - child_resource_message_filter > - resource_scheduling_filter > - shared_memory_received_data_factory > - resource_dispatch_throttler > - messages defined in resource_messages.h > - a bunch of branches > > Bug: 788241 > Change-Id: I90a95163eb44bd7c34136d28db5d2625204f6f5c > Reviewed-on: https://chromium-review.googlesource.com/821796 > Commit-Queue: Yutaka Hirano <yhirano@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#525943} TBR=dcheng@chromium.org,kinuko@chromium.org,yhirano@chromium.org Change-Id: I4a93fc6ad418a26ce646523b9c366512f32cce10 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 788241, 797374 Reviewed-on: https://chromium-review.googlesource.com/842226Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#526074}
-
Steve Kobes authored
Typically the LayoutView is marked for layout when it acquires children, who mark themselves and their containers. But we want an initial layout pass even if the LayoutView has no children, for bookkeeping tasks like setting LocalFrameView::last_viewport_size_. Setting last_viewport_size_ during the initial layout ensures that we send a resize event when an iframe leaves the display: none state. Two paint invalidation tests have updated baselines reflecting earlier removal of an iframe's initial vertical scrollbar. Bug: 795661 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I3e7984b2f4cd012056e964114a803b484da584f1 Reviewed-on: https://chromium-review.googlesource.com/838249Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#526073}
-
Brad Lassey authored
This reverts commit ece1b14d. Reason for revert: suspected of causing the crash in crbug/797267 Original change's description: > Roll clang 318667:321204. > > Ran `tools/clang/scripts/upload_revision.py 321204` > and cherry-picked the non-clang changes from > https://chromium-review.googlesource.com/c/chromium/src/+/828400 . > > TBR=brettw@chromium.org,rsesek@chromium.org,hans@chromium.org > > Bug: 787920 > Cq-Include-Trybots: master.tryserver.chromium.android:android_arm64_dbg_recipe;master.tryserver.chromium.android:android_compile_mips_dbg;master.tryserver.chromium.android:android_compile_x64_dbg;master.tryserver.chromium.android:android_compile_x86_dbg > Change-Id: Iaec5677e2afee0edb685db816e00f3c900214d14 > Reviewed-on: https://chromium-review.googlesource.com/835358 > Commit-Queue: Peter Collingbourne <pcc@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Hans Wennborg <hans@chromium.org> > Reviewed-by: Peter Collingbourne <pcc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#525638} TBR=eugenis@chromium.org,brettw@chromium.org,hans@chromium.org,rnk@chromium.org,pcc@chromium.org,rsesek@chromium.org NOTRY=true Skipping the CQ because there appear to be Android bot capacity issues. Bug: 787920,797267 Change-Id: I3a033492561ae2ff4fcf46fe9087efbbd9f015f6 Cq-Include-Trybots: master.tryserver.chromium.android:android_arm64_dbg_recipe;master.tryserver.chromium.android:android_compile_mips_dbg;master.tryserver.chromium.android:android_compile_x64_dbg;master.tryserver.chromium.android:android_compile_x86_dbg Reviewed-on: https://chromium-review.googlesource.com/843242 Commit-Queue: Reid Kleckner <rnk@chromium.org> Reviewed-by:
Reid Kleckner <rnk@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#526072}
-
Fredrik Söderquist authored
This appears to have been dead/unused since the complicated weak handling for SVGCursorElement was removed in https://codereview.chromium.org/2522443002 (together with SVGCursorElement itself.) Simplify SVGElement::EnsureSVGRareData a little while at it. Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I0e29e2830bc20fd595d41d72eb9c3ec23c2df2ce Reviewed-on: https://chromium-review.googlesource.com/843023Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#526071}
-
Christian Fremerey authored
This reverts commit 7b74ab48. Reason for revert: This CL caused test HangoutServicesBrowserTest.RunComponentExtensionTest to fail. See https://bugs.chromium.org/p/chromium/issues/detail?id=796601 Original change's description: > Autoplay: enable unified policy by default on trunk. > > Bug: 779087, 746554 > Change-Id: I22fea53534db6404da794c04320ef6b889dc5ac6 > Reviewed-on: https://chromium-review.googlesource.com/817739 > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> > Cr-Commit-Position: refs/heads/master@{#524987} TBR=mlamouri@chromium.org,jochen@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 779087, 746554, 796601 Change-Id: If27fa373985aaaa77ad4d7c87058d839c7ee332f Reviewed-on: https://chromium-review.googlesource.com/842225 Commit-Queue: Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#526070}
-
Mustafa Emre Acer authored
Bug: 795820 Change-Id: I78202ba73a1c4e3d874a4faa973bb398fa2d30f8 TBR: estark@chromium.org Reviewed-on: https://chromium-review.googlesource.com/842855Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#526069}
-
Gauthier Ambard authored
This CL sets the incognito property of the OmniboxPopupViewController before the view is created when passed to the mediator as the property is used in viewDidLoad. Bug: 797239 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I0db9d1754ea32d6d1a6c7cde5d2638f187da5fd3 Reviewed-on: https://chromium-review.googlesource.com/842723Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#526068}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/2b7bbc282280..06f863774011 $ git log 2b7bbc282..06f863774 --date=short --no-merges --format='%ad %ae %s' 2017-12-22 zmo Revert "Re-land "Vulkan: Roll loader/validation layers SDK. (2/2)"" Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I7c3b58bf692c0bbd20e1426b84dbbcf7e07c486a Reviewed-on: https://chromium-review.googlesource.com/843228 Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#526067}
-
Vadim Tryshev authored
It will never come back. This CL shaves off some layer, but I'm leaving more cleanups (around SpeechUIModel) for the next CL to keep it comprehensible. Bug: 781407 Change-Id: I86e0681794e1f84f3267e5b29cd3e5e55bdc385a Reviewed-on: https://chromium-review.googlesource.com/841744Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Vadim Tryshev <vadimt@chromium.org> Cr-Commit-Position: refs/heads/master@{#526066}
-
Jonathan Metzman authored
When chromium fuzzers are run with AFL, the process forks before calling LLVMFuzzerTestOneInput. This didn't work here because initialization needed for LLVMFuzzerTestOneInput to execute (specifically its call to run_loop.Run) needs to be done in the same thread running LLVMFuzzerTestOneInput. This CL moves the initialization to the same thread, by doing the initialization in the first execution of LLVMFuzzerTestOneInput. Bug: 797366 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ic725d564490a3065df4a1ac3f0f079462fe093ed Reviewed-on: https://chromium-review.googlesource.com/843070 Commit-Queue: Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#526065}
-
Marijn Kruisselbrink authored
Update test expectation for virtual/mouseevent_fractional/fast/events/touch/gesture/gesture-tap-hover-state-iframe.html TBR=rbyers@chromium.org Bug: 795250 Change-Id: If5f6df738c35c1ee7920f83f1ebc2771a4f06dac Reviewed-on: https://chromium-review.googlesource.com/843008Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#526064}
-
Tom Finegan authored
Disable high bit depth to avoid a visual quality issue in AV1 playbacks. BUG=aomedia:1173 TBR=jzern,johannkoenig Change-Id: I95c54a5a63646f4ce3b305c36184f932bc8c5d3b Reviewed-on: https://chromium-review.googlesource.com/842851 Commit-Queue: Tom Finegan <tomfinegan@chromium.org> Reviewed-by:
Tom Finegan <tomfinegan@chromium.org> Cr-Commit-Position: refs/heads/master@{#526063}
-
Eric Lawrence authored
Add two custom domain entries to the HSTS preload list. Bug: 170913 Change-Id: Idce21cc1b8f6f7850d9a1f854ee835932b135044 TBR: palmer@chromium.org Reviewed-on: https://chromium-review.googlesource.com/843125Reviewed-by:
Eric Lawrence <elawrence@chromium.org> Commit-Queue: Eric Lawrence <elawrence@chromium.org> Cr-Commit-Position: refs/heads/master@{#526062}
-
Doug Turner authored
Bug: 796657 Change-Id: I49d2cd5fe8112fda7ec6ae6ae472ee13510d9394 Reviewed-on: https://chromium-review.googlesource.com/837730Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Doug Turner <dougt@chromium.org> Cr-Commit-Position: refs/heads/master@{#526061}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/891aaf63b349..05dcbc931eac $ git log 891aaf63b..05dcbc931 --date=short --no-merges --format='%ad %ae %s' 2017-12-22 thestig Only set CPDF_ColorSpace component count on successful load. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I448f5d48dea567368d80aed5648f40c476fa7754 Reviewed-on: https://chromium-review.googlesource.com/843232 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#526060}
-
danakj authored
Pass in the ContextProvider instead of each capability individually. And in the DirectRenderer classes, the FrameBuffer hint is always used so stop making it conditional (this is a leftover from ResourceProvider code this was based on) and just pass mipmap as a bool so that new bitflags can't be added without child classes knowing about it. Last, pass RenderPassRequirements consistently to both methods that receive them, instead of unpacking it for one of them, so that the relationship is more clear in the APIs. R=piman@chromium.org Bug: 738190 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ie53c2041183207561efae7d10c0c32e42daf1bd2 Reviewed-on: https://chromium-review.googlesource.com/843162 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#526059}
-
Michael Thiessen authored
There's a bug where if the control container is already hidden, we fail to pause VSync when entering WebVR. This happens when we enter WebVR from VR browsing. This CL fixes that hackily by just immediately pausing VSync if we're coming from VR browsing. This will be fixed properly with the fallback UI path. See crbug.com/793430 Bug: 797349 Change-Id: I8d35a0c38caa7aaf285c140bef368883aaa0765b Reviewed-on: https://chromium-review.googlesource.com/843237Reviewed-by:
Biao She <bshe@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#526058}
-
Zhenyao Mo authored
https://chromium.googlesource.com/angle/angle.git/+log/2b7bbc2..06f8637 BUG=797253 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=jmadill@chromium.org,thestig@chromium.org Change-Id: I85383d0eb6618c11b306d954d7c697a44a8a090d Reviewed-on: https://chromium-review.googlesource.com/843229Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#526057}
-
Thomas Anderson authored
This reverts commit f93b585a. Reason for revert: Windows don't get shown Original change's description: > Remove ui::X11EventSource::BlockUntilWindowMapped > > This CL removes BlockUntilWindowMapped() and the 2 references to it. > > The first reference, in X11WholeScreenMoveLoop, waits until an offscreen window > is mapped. The window is override-redirect (so there's not WM that > asynchronously decides when to map the window), so any operations done on the > window should succeed after the window is mapped since the X server processes > events in sequence. > > The second reference is from X11WindowBase. A similar removal was done in > DesktopWindowTreeHostX11 in [1], so BlockUntilWindowMapped() shouldn't be needed > here either. > > [1] https://chromium.googlesource.com/chromium/src/+/662c24fc6debb33ee34a927d21dc26154b8973d6 > > R=sadrul@chromium.org > > Change-Id: I251e67839dd5216f5164a103a82ad8a906811a03 > Bug: None > Reviewed-on: https://chromium-review.googlesource.com/823212 > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Cr-Commit-Position: refs/heads/master@{#525869} TBR=sadrul@chromium.org,thomasanderson@chromium.org Change-Id: I7bc83f409171941ce812ab09e0191b935127a38b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 797358 Reviewed-on: https://chromium-review.googlesource.com/842685Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#526056}
-
Andrew Grieve authored
See: https://developer.android.com/studio/projects/android-library.html webrtc and cronet have both expressed interest in this at one point or another. While this doesn't support all aar features, it's a good start (and wasn't that hard). Bug: 506230, 762967 Change-Id: I1a5144311c1e7a30ccd2a50f77183977d820ea78 Reviewed-on: https://chromium-review.googlesource.com/841862 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#526055}
-
Bill Budge authored
Bug: chromium:756050 Change-Id: I13b8eaa26eb94dc1b1f4e37c678b82853246c423 Reviewed-on: https://chromium-review.googlesource.com/818449 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#526054}
-
John Abd-El-Malek authored
Instead, use net::URLRequest::ReferrerPolicy. This is in preparation for moving the struct to services/network. In a follow-up, I'll switch content::Referrer to use the net enum as well. Bug: 753658 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I622cba8d8c8f828f3961b9cb3a524b8cf487a3c1 Reviewed-on: https://chromium-review.googlesource.com/842249 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Yuzhu Shen <yzshen@chromium.org> Cr-Commit-Position: refs/heads/master@{#526053}
-
David Reveman authored
This enables motion-stills by default and adds a feature flag for turning it off. Bug: 769140 Test: chrome --disable-features=ChangePictureVideoMode Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia2eef2d627914572d95c91d08e876e5e37d282e6 Reviewed-on: https://chromium-review.googlesource.com/842703 Commit-Queue: David Reveman <reveman@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#526052}
-
Jiaquan He authored
This commit does miscellaneous work in preparation for breaking ChromeAppListItem from AppListItem to make future CL smaller, with the following change: - For ChromeAppListItem: - overriding AppListItem methods explicitly; - moving methods into proper scopes; - add test apis for non-public methods in tests. - For (Chrome)AppListModelUpdater: - adding more methods that will be used; - moving methods into proper scopes; - grouping and reordering methods by their behaviors; - add test apis for non-public methods in tests. Bug: 733662 Change-Id: I3e9661b83b8b5493afe4fa4847edef48d01951f7 Reviewed-on: https://chromium-review.googlesource.com/841755Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jiaquan He <hejq@google.com> Cr-Commit-Position: refs/heads/master@{#526051}
-
Sahel Sharify authored
org.chromium.chrome.browser.vr_shell.VrShellControllerInputTest#testControllerScrolling failed after landing browserside touchpad fling. The resean for this regression is that with touchpad fling the proper event stream is WebMouseWheelEvents from which Gesture scroll events are generated and then a GFS event with touchpad source. However in VR while scrolling with touchpad Gesture scroll events are directly injected to RWHI rather than injecting WebMouseWheelEvents and then generating gesture scroll events from them. The proper fix is to make the VR event stream similar to the proper event stream for touchpad scrolling but meanwhile this cl fixes the issue by handling the VR case separately. The fix has three parts: 1- The ProgressFling is called in RWHV_Android to progress the fling. It used to get called only on Aura for touchpad flings on chromebook. 2- is_in_gesture_scroll_ DCHECK logic in RWHI is changed for Android VR: When a GFS with touchpad source gets handled by FlingController, the controller sends wheel events to progress the fling. In Android VR the is_in_gesture_scroll_ should get reset on GFS since the first wheel event sent by the FlingController will cause a GSB generation in MouseWheelEventQueue. This GSB generation happens since during scrolling with touchpad the WebContentsEventForwarder directly injects gesture scroll events to the RWHI rather than injecting wheel events. Once Motion events are used for VR event processing this DCHECK change must get back to what it was. 3- Input_handler_proxy used to assume that nonblocking wheel events have always had a blocking wheel event before them. This assumption is not valid anymore since as explained in number 2, in VR case the first wheel event that is send by the flingController is nonblocking and it doesn't have any wheel events prior to it since the scrolling is directly handled by gesture scroll event injection. TBR: dtapuska@chromium.org, tdresser@chromium.org Bug: 797322, 797299 Change-Id: I9ab4e8236c6fd274d84e3d571ef0fc2388ec17e1 Reviewed-on: https://chromium-review.googlesource.com/842707 Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> Reviewed-by:
Sahel Sharifymoghaddam <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#526050}
-
Hector Carmona authored
Bug: 791666 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I847476ac80c96d7df6e66ea4547d6fab32845b38 Reviewed-on: https://chromium-review.googlesource.com/835470 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#526049}
-