- 19 Feb, 2018 40 commits
-
-
Nathan Parker authored
Bug: 808721 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I0bb1055e363340ab58db1d557f2e9c46dc5a33d8 Reviewed-on: https://chromium-review.googlesource.com/912388 Commit-Queue: Nathan Parker <nparker@chromium.org> Reviewed-by:
Jialiu Lin (OOO Feb 14-19) <jialiul@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#537680}
-
vasilii authored
The new button appears when a password field is focused or when other password suggestions are displayed. The latter may happen when a username field is focused. Click on the button opens the list of passwords. User can find the relevant one there and copy it. Bug: 782287 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I199851bd28c76ac4b626f8a1ff81a86e8479a51e Reviewed-on: https://chromium-review.googlesource.com/816479 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#537679}
-
Scott Graham authored
Flaked at https://build.chromium.org/p/chromium.fyi/builders/Fuchsia/builds/14138. TBR: wez@chromium.org Bug: 813631 Change-Id: Ifda5f9f3efc04fa8f17859678713b9658e3652d7 Reviewed-on: https://chromium-review.googlesource.com/925450 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#537678}
-
https://pdfium.googlesource.com/pdfium.git/+log/03632fb7fd1f..c8785f736df5 $ git log 03632fb7f..c8785f736 --date=short --no-merges --format='%ad %ae %s' 2018-02-19 dsinclair Simplify CXFA_FMToken creation 2018-02-19 dsinclair Skip font loading in formcalc embedder tests Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I87db1c73e7b2f3d378381c5ff2553b362b87b232 Reviewed-on: https://chromium-review.googlesource.com/925441Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#537677}
-
Bartosz Fabianowski authored
This adds a class that holds push-install event logs for all apps. The class is not hooked up to anything yet, so no log entries are read or written. Bug: b/73277923 Test: unit_tests Change-Id: Ic95c02d9a47b56492e9ac9ef9f0d8e1ce8aa4ea1 Reviewed-on: https://chromium-review.googlesource.com/916243 Commit-Queue: Bartosz Fabianowski <bartfab@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#537676}
-
Guido Urdaneta authored
This reverts commit 447c696a. Reason for revert: Introduces a regression. See https://crbug.com/813243 Original change's description: > Don't trigger end of track when starting a new disabled track > > Fix reporting a size of 2x2 on the video element during the loading > phase. > > Bug: 684288 > Change-Id: Id4adceefaf4c3df57a1ba41fd285862d72792b1a > Reviewed-on: https://chromium-review.googlesource.com/806215 > Commit-Queue: Florent Castelli <orphis@chromium.org> > Commit-Queue: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Cr-Commit-Position: refs/heads/master@{#523152} TBR=guidou@chromium.org,orphis@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 684288, 813243 Change-Id: I60bc092c23d1840a9c7e95b4b1d8d02c52c6fb46 Reviewed-on: https://chromium-review.googlesource.com/924190 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#537675}
-
https://webrtc.googlesource.com/src.git/+log/de25a9a4be51..2b6f13508ec1 $ git log de25a9a4b..2b6f13508 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Iabff0eea6a3b451b7687cdcd65750b07d6e2737c Reviewed-on: https://chromium-review.googlesource.com/924984 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#537674}
-
Dave Tapuska authored
Shadowed variables can make code harder to read. Don't support them in the content layer. BUG=794619 This CL was uploaded by git cl split. R=fsamuel@chromium.org Change-Id: Id33101d8feb26d33e4b3c8301bfb496bd9535298 Reviewed-on: https://chromium-review.googlesource.com/924163Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#537673}
-
Patrick Monette authored
Refactor most of SettingsAppMonitor into a base class. Move some functions to a utility header. Bug: 717696 Change-Id: Ia5d3765db6450ef5dd8e66d5ff607422914b37dc Reviewed-on: https://chromium-review.googlesource.com/907542Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#537672}
-
Michael Giuffrida authored
When a Chrome app restarts itself, its windows get closed before it is unloaded. It will then be asynchronously loaded again and sent the onLaunch event, at which point its background page may create a window. At each of these steps, we might have no windows open. In AppShell, closing the last window ends the main RunLoop. (Chrome has similar behavior, but only when there are no other Chrome windows open and no apps enabled that keep Chrome open in the background). Work around this by creating keep-alives spanning from when the app is unloaded for a reload, to when its first app window is shown. The tricky part is removing the keep-alive if an app fails to reload, or if it reloads but decides not to create a window. This class could be used by Chrome's ExtensionService as well, with some tweaks. See crbug.com/759811. Bug: 759867 Change-Id: I9040306ef18b8948d2f73e57e69de75a8aac997a Reviewed-on: https://chromium-review.googlesource.com/911733Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#537671}
-
https://pdfium.googlesource.com/pdfium.git/+log/f51cdbd2bddd..03632fb7fd1f $ git log f51cdbd2b..03632fb7f --date=short --no-merges --format='%ad %ae %s' 2018-02-19 dsinclair Simplify formcalc token list Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Iaf7e73cb8da2f81b7f5c6af702348a49226d4e86 Reviewed-on: https://chromium-review.googlesource.com/924773 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
-
Anita Woodruff authored
Change-Id: Id007aa212c96d2d171a9f658da16d47e17ba21e3 Reviewed-on: https://chromium-review.googlesource.com/911573 Commit-Queue: Anita Woodruff <awdf@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#537669}
-
Paul Jensen authored
For the most part this comes down to piping the SocketTag from the HttpRequestInfo down to the QuicStreamRequest and into the QuicSessionKey. By including the SocketTag in the QuicSessionKey it means QUIC sessions will not be shared between requests with different tags, which facilitates accurately tagging all traffic. If streams with different tags shared a session, it wouldn't be possible to accurately attribute all traffic as packets could contain data meant to have multiple distinct tags. QuicStreamFactory makes sure to apply the SocketTag to the underlying socket. Bug: 520198 Change-Id: I7874713688dec76a71fef3bb331e20ea5233ddcc Reviewed-on: https://chromium-review.googlesource.com/886861 Commit-Queue: Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#537668}
-
Bernhard Bauer authored
Bug: 813594 Change-Id: I33c8d72cb8a856f363799049743c63584593a362 Reviewed-on: https://chromium-review.googlesource.com/925272Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#537667}
-
Yutaka Hirano authored
This doesn't change the behavior. Bug: 808390 Change-Id: I54f04cd5aa7b69e25d9fa72fc82489ac9e006d28 Reviewed-on: https://chromium-review.googlesource.com/923923Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#537666}
-
Dave Tapuska authored
Shadowed variables can make code harder to read. Don't support them in the content layer. BUG=794619 This CL was uploaded by git cl split. R=kinuko@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I496a5dbfd270826969deea1edb01dd572dff2d99 Reviewed-on: https://chromium-review.googlesource.com/923353Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#537665}
-
Yutaka Hirano authored
This CL uses ResourceTiming API to speed up the test cases while avoiding flakiness. Bug: 779965 Change-Id: I40dc2fae470df296c87c12e432fc7fc7644cc40a Reviewed-on: https://chromium-review.googlesource.com/923625 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#537664}
-
Martin Sramek authored
Bug: 813554 Change-Id: I0f9944b5919b9d51e46868aaafa16dd18952dee6 Reviewed-on: https://chromium-review.googlesource.com/924034Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#537663}
-
Thomas Tangl authored
This CL adds a unit test for the account image persistence in AccountTrackerService. Bug: 794522 Change-Id: I4e5afde41d9d1518ac4f10c968cf122f0dc44bcb Reviewed-on: https://chromium-review.googlesource.com/923970Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#537662}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e1bb2695. With Chromium commits locally applied on WPT: 91310914 "Port another set of sticky tests to JS rather than reftests" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/12605 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: bugsnash@chromium.org, ericwilligers@chromium.org, meade@chromium.org, nainar@chromium.org, rjwright@chromium.org, shend@chromium.org: external/wpt/css/css-cascade cbiesinger@chromium.org: external/wpt/css/css-flexbox external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/flexbox domenic@chromium.org, ricea@chromium.org, tyoshino@chromium.org: external/wpt/streams drott@chromium.org, kojii@chromium.org: external/wpt/css/css-fonts kozyatinskiy@chromium.org: external/wpt/console meade@chromium.org: external/wpt/web-animations mstensho@chromium.org: external/wpt/css/css-multicol smcgruer@chromium.org: external/wpt/css/css-position tyoshino@chromium.org, yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch TBR=lukebjerring No-Export: true Change-Id: Ieb61139e5e661017069c6ae87005442b3071b6c7 Reviewed-on: https://chromium-review.googlesource.com/924903 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#537661}
-
Paul Jensen authored
Bug: 520198 Change-Id: I4313f295c704d852c98feadc009e5720c0aea5a9 Reviewed-on: https://chromium-review.googlesource.com/893804 Commit-Queue: Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#537660}
-
https://chromium.googlesource.com/angle/angle.git/+log/9fdaa497b489..697bf65c1107 $ git log 9fdaa497b..697bf65c1 --date=short --no-merges --format='%ad %ae %s' 2018-02-16 oetuaho Avoid redundant symbol lookup when parsing functions Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: If64885d53a2bc2c78b103d0f53b402b2fcc3f4a6 Reviewed-on: https://chromium-review.googlesource.com/924770Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#537659}
-
Thiemo Nagel authored
BUG=813578 TBR=vmpstr Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I17a59d1d7d20c4bdd36388b2133892625253977d Reviewed-on: https://chromium-review.googlesource.com/924197 Commit-Queue: Thiemo Nagel <tnagel@chromium.org> Reviewed-by:
Thiemo Nagel <tnagel@chromium.org> Cr-Commit-Position: refs/heads/master@{#537658}
-
tzik authored
After this CL: * TaskRunnerBoundObserverList no longer needs tuple for its invocation. * No ObserverStoreType support, as there was no user of that. Also, this CL drops base::internal::ParamsUseScopedRefptrCorrectly, as there's no user of it after this CL. Change-Id: Iefc215690070aaed5d57178be058c7916c811483 Reviewed-on: https://chromium-review.googlesource.com/923225Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#537657}
-
Kinuko Yasuda authored
Mechanical changes only (for now), will make a separate change to sort out BUILD.gn changes. TBR=mek@chromium.org, jam@chromium.org, haraken@chromium.org Bug: 809983 Change-Id: Iea0383a50dfac6a49eef6fcd61051ea8d58ed27b Reviewed-on: https://chromium-review.googlesource.com/923905 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Thiemo Nagel authored
BUG=813545 TBR=media-dev Change-Id: I1e0f2d69d4e3d962be5e7fbeadc9af7b0e705342 Reviewed-on: https://chromium-review.googlesource.com/924704Reviewed-by:
-
Hans Wennborg authored
This reverts commit b0dc3696. Reason for revert: The best breaks all Windows buildbots on the chromium.clang waterfall, and I guess others might be broken too. Either these need to be added to the blacklist for this test, or ideally there would be some mechanism to express this test needs to run on Win10 hosts. Original change's description: > Run notification_helper_unittests on Chromium buildbots > > Since this unit test requires WinRT which only exists on Windows 8 or above, > we don't run it on Windows 7 bots. > > Bug: 734095 > Change-Id: I6889efb1e9425fe3cc4ae37ae6b0f0d54e7c4f5a > Reviewed-on: https://chromium-review.googlesource.com/915016 > Commit-Queue: Xi Cheng <chengx@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#536906} TBR=dpranke@chromium.org,chengx@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 734095, 813553 Change-Id: I9ae4611aedb58d1ecf58ba25c2b4f387ae40a59b Reviewed-on: https://chromium-review.googlesource.com/923740Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#537654}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8afe6561..1880a2eb Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ibd38aa2f4b5cd7684127bfff0455ad94f7cb022f Reviewed-on: https://chromium-review.googlesource.com/924731Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#537653}
-
Raphael Kubo da Costa authored
Some of the new flexbox tests upstreamed by Mozilla have been flaky on Linux (they pass linux_blink_trusty_rel but not linux_chromium_rel_ng); mark them as flaky to unblock WPT imports. See e.g.: * https://ci.chromium.org/buildbot/tryserver.chromium.linux/linux_chromium_rel_ng/649535 * https://ci.chromium.org/buildbot/tryserver.chromium.linux/linux_chromium_rel_ng/649928 TBR=lukebjerring, cbiesinger, robertma Bug: 467127 Change-Id: I81e9606f1bd0633e8b4d18d47888b2d6a9911e92 No-Try: True Reviewed-on: https://chromium-review.googlesource.com/923991 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#537652}
-
Ramin Halavati authored
Network traffic annotation is added to the XmppConnection socket. Bug: 656607 Change-Id: If7eb6984fa11d94dfee575309028a07cb0a317b4 Reviewed-on: https://chromium-review.googlesource.com/919782Reviewed-by:
Nicolas Zea <zea@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#537651}
-
Rune Lillesveen authored
We used to inherit RtlOrdering() from the viewport style, but documentElement now sets RtlOrdering() from initial style instead. Remove the unnecessary modification of the viewport style. Gets rid of one MutableStyleRef(). TEST=fast/text/international/iso-8859-8-* Bug: 813068 Change-Id: I96a24950a8a27fac9b97c60a7fe3b220c4523429 Reviewed-on: https://chromium-review.googlesource.com/924035Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#537650}
-
Manish Jethani authored
Instead of a for loop we use std::find_if with a lambda, which makes the code easier to follow. BUG=608854 Change-Id: Ib08efabfb8d0d21da4d3397b4fb27406fe096dc1 Reviewed-on: https://chromium-review.googlesource.com/923348Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Manish Jethani <m.jethani@eyeo.com> Cr-Commit-Position: refs/heads/master@{#537649}
-
https://webrtc.googlesource.com/src.git/+log/707ca31ea4b5..de25a9a4be51 $ git log 707ca31ea..de25a9a4b --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I98617bd6a324b72094b0f01ca59335d0b4a1e154 Reviewed-on: https://chromium-review.googlesource.com/925103 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
-
Marton Hunyady authored
Add two new device policies: DeviceRollbackAllowedMilestones and DeviceRollbackToTargetVersion. These policies are only used in update_engine, so no preference mapping is necessary. Bug: 813036 Change-Id: Ic4b33a66ef959df9f19a83db194e833536cd941f Reviewed-on: https://chromium-review.googlesource.com/916563 Commit-Queue: Marton Hunyady <hunyadym@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
-
François Beaufort authored
This CL fixes an issue when list item string is too long in overflow media icons list. Test page: https://beaufortfrancois.github.io/sandbox/media/overflow-video.html Legacy controls screenshots: https://imgur.com/a/l8Q4l Modern controls screenshots: https://imgur.com/a/OGd8n Bug: 763301 Change-Id: Ic25397706450fc6b3c7bf1eccf227f141c47f25a Reviewed-on: https://chromium-review.googlesource.com/916005Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#537646}
-
Sergey Kuznetsov authored
Some clients (in tests) doesn't call SetPrefModelAssociatorClient. This leaves pref_model_associator_client_ in uninitialized state. And CreateSyncable call creates PrefServiceSyncable with invalid client_ pointer. Change-Id: I89b310729ef817d75374d2fe66245d7538665e5b Reviewed-on: https://chromium-review.googlesource.com/923968Reviewed-by:
-
Greg Thompson authored
This string was added to chromium_strings.grd in r515542, but was accidentally left out of google_chrome_strings.grd. BUG=None R=finnur@chromium.org Change-Id: I9d5054121f729fb96c973b47b62e09db6147b6bd Reviewed-on: https://chromium-review.googlesource.com/925265Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#537644}
-
Luka Dojcilovic authored
This CL chnages IsPasswordFormReappeared so it doesn't compare form actions if they are empty. R=cfroussios@chromium.org, kolos@chromium.org Bug: 699539 Change-Id: Ia57c6ec7245d972e5df5f88b64c5ddac9c2c5c43 Reviewed-on: https://chromium-review.googlesource.com/916565 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#537643}
-
Thiemo Nagel authored
BUG=813547 TBR=rtoy Change-Id: Ibe7e66ee64a0ccffda81bab85a33068c1226680a Reviewed-on: https://chromium-review.googlesource.com/924195Reviewed-by:
-
Sergey Poromov authored
Previously, active sessions and recent users were reported separately, that is confusing on the server side. This change adds 'user_email' field to ActiveTimePeriod proto message and populates it for affiliated users that are eligible for reporting. Also, user email is reported only if user reporting is turned on. Initially landed in https://crrev.com/c/904527 Reverted in https://crrev.com/c/923228 TBR=xiyuan@chromium.org BUG=810093 TEST=Browser tests added. TEST=ASAN_OPTIONS="detect_leaks=1" ./out/asan/browser_tests --gtest_filter=DeviceStatusCollectorTest* TEST=ASAN_OPTIONS="detect_leaks=1" ./out/asan/browser_tests --gtest_filter=Blub* Change-Id: I9db2c07f6aa0ba89b9f5fc6fc890207ad5e9a97b Reviewed-on: https://chromium-review.googlesource.com/924005 Commit-Queue: Sergey Poromov <poromov@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#537641}
-
