- 31 Oct, 2019 40 commits
-
-
Tibor Goldschwendt authored
This gets rid of the whitelist in Module.java. Going forward DFM authors simply have to specify native_deps in the module_desc and the native library will be automatically loaded when first accessing the module (when using the autogenerated module class). See go/native-dfm-load-v2 for more context and details. This is a reland of 06c7b1cd No changes have been made. 06c7b1cd was reverted due to the revert of a9dcd64a and that CL has been fixed in c9901c6a. TBR: cjgrant@chromium.org,mthiesse@chromium.org Bug: 870055 Change-Id: Ib7939f43f2e3ca758c8ab039f91d6f78b6d84f22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891434Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#711460}
-
Rakina Zata Amni authored
ViewSourceWithSplitCacheEnabledTest.NetworkIsolationKeyReusedForBackNavigation expects us to re-load a page after a back navigation (and reuse the network isolation key while doing so), which doesn't happen when the page is restored from bfcache. We will disable bfcache for this test, because the reload is an essential part of the test. Bug: 1017597 Change-Id: I92a42ab8811750c54400119f276d2a9ec3dec13e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886531Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#711459}
-
Piotr Bialecki authored
There should be no functional changes introduced by this CL. Renames XRInputSource-related data in mojom structs. This CL does not attempt to fix names of other variables / functions that are used to compute the data that will then be set on the mojom structs - this will have to happen in a follow-up (mostly on device side, blink usage should already be consistent). Change-Id: I1b4888158a7ed57cecce7de87634e639cf23d6ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891455Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#711458}
-
Nina Satragno authored
If the application parameter is a dummy value, do not store the credential on the virtual authenticator. Fixed: 1019828 Change-Id: Iacfdcff64fba895b5283bf620b4e48c11279c65b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891134 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Auto-Submit: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#711457}
-
Jeremy Apthorp authored
this fixes an ambiguous reference error when compiling with MSSTL Change-Id: I19a56e9268cac76afc8dd3fcf391b3a2d5fe7d2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891762Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Auto-Submit: Jeremy Apthorp <jeremya@chromium.org> Cr-Commit-Position: refs/heads/master@{#711456}
-
Matt Menke authored
It's much clearer to have a single include rule than to include everything in a single list, and then have exclude rules at the bottom of the file. Bug: None Change-Id: Ifbb669ea13999ca9232012063ac6031065d216d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890964 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#711455}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f9ac8f056b7f..b0434c1ced7a Created with: gclient setdep -r src-internal@b0434c1ced7a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:1019931,chromium:1014539,chromium:None,chromium:None,chromium:None Change-Id: I51d1c4502756686114c45fd61e9c751c6dfcf826 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894251Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711454}
-
Nate Fischer authored
This is a reland of 011e523c This removes an assert which is not true when DCHECKs are disabled (in such a case, we do not log the is_instrumented_build proto at all). Original change's description: > AW UMA: integration tests for more metadata fields > > No change to production logic. > > This adds tests for already-implemented UMA proto fields. This > intentionally skips fields which don't apply to Android OS (ex. > os.is_jailbroken, os.arc, os.kernel_version). > > Bug: 1011991 > Test: run_webview_instrumentation_test_apk -f AwMetricsMetadataTest.* > Change-Id: I35fe2b75164a421a9a5dbc80df621f75ec9b5474 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889171 > Auto-Submit: Nate Fischer <ntfschr@chromium.org> > Reviewed-by: Changwan Ryu <changwan@chromium.org> > Commit-Queue: Nate Fischer <ntfschr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#710655} Bug: 1011991 Change-Id: Ib0ac14fb25b8a61833f32c1df36f2719c060b4f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891430 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#711453}
-
Daniel Murphy authored
This patch: * Changes most raw pointers to base::WeakPtr * Removes the IndexedDBFactory raw pointer in IndexedDBDatabase and instead uses callbacks to report: 1. If blobs are in use for a given origin, and 2. If the blob journal has been cleaned. * Changes the IndexedDBActiveBlobRegistry to use callbacks instead of the IndexedDBFactory as well, and also use callbacks for calling ReportUnusedBlob in IndexedDBOriginFactory. This simplifies the testing of that class. There are no functional changes in this patch, and while all of those raw pointers should be safe based on the architecture of the code, it is much safer to store them appropriately now that we have our fancy new pointer types. Finally, this patch also does some naming changing in IndexedDBActiveBlobRegistry to make that class easier to understand. Bug: 1018741,960992 Change-Id: I6fd402c68d13870f347fe934b85e6281c396901d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885094 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#711452}
-
Lei Zhang authored
- Refactor Viewport.rotateClockwise(increments) into rotateBySteps_(), rotateClockwise() and rotateCounterclockwise(). - Fix a typo in pdf_viewer.js to balance the braces. Change-Id: Ic91cab4bd930fd87538da801e643c87115327135 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892672 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#711451}
-
Kevin McNee authored
This reverts commit 849315dd. Reason for revert: Suspecting this CL for compile failures on windows e.g. https://ci.chromium.org/p/chrome/builders/ci/win64-builder-perf/127136 [7893/15918] CXX obj/chrome/browser/ui/ui/app_menu_model.obj FAILED: obj/chrome/browser/ui/ui/app_menu_model.obj c:\b\s\w\ir\cache\goma\client\gomacc.exe ..\..\third_party\llvm-build\Release+Asserts\bin\clang-cl.e...(too long) ../../chrome/browser/ui/toolbar/app_menu_model.cc(166,21): error: no class named 'HelpMenuModel' in 'AppMenuModel' class AppMenuModel::HelpMenuModel : public ui::SimpleMenuModel { ~~~~~~~~~~~~~~^ ../../chrome/browser/ui/toolbar/app_menu_model.cc(819,41): error: unknown type name 'HelpMenuModel'; did you mean 'AppMenuModel'? sub_menus_.push_back(std::make_unique<HelpMenuModel>(this, browser_)); ^~~~~~~~~~~~~ AppMenuModel Original change's description: > Make AppMenuModel keep most submenus in a vector. > > They are only needed for ownership, so no need to give them names and concrete > types. Removes some forward declarations from the header and serendipitously > happens to remove GOOGLE_CHROME_BUILD from the header as well. > > No intended behavior change. > > Bug: 961769 > Change-Id: Ibaaf3375bd9d367b4cc83b9a8ec3e64193750a69 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894032 > Commit-Queue: Robert Sesek <rsesek@chromium.org> > Auto-Submit: Nico Weber <thakis@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#711431} TBR=thakis@chromium.org,rsesek@chromium.org Change-Id: I40cdc0d770d2d49ed568fb2c7d22fa791088c0a2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 961769 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893861Reviewed-by:
Kevin McNee <mcnee@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#711450}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: Ied490c4b890ab553c91deaf28b9c952b22eb3d45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892999Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711449}
-
Yue Zhang authored
Bug: 983170 Change-Id: Ie165a27c52a5524ce1c41f8ec4661be45b945674 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891117 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#711448}
-
Robert Ogden authored
TBR=ryansturm@chromium.org Change-Id: Id22af52d89c0d880ce0df0c55fba0440193a3bfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894186Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#711447}
-
Avery Musbach authored
Merge IndicatorState::kCannotSnap{Xxx} to IndicatorState::kDragArea{Xxx} as the distinction is whether the dragged window can be snapped in split view, which can be determined in SplitViewDragIndicatorsView now that the parent CL [1] has added dragged_window_ thereto. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1880201 Bug: None Change-Id: Ic3fc184e29b8ccf30647016f57dd89a1f055909e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881331 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#711446}
-
Henrik Boström authored
Intent to Implement and Ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/OqPfCpC5RYU For background, motivation, requirements and implementation notes, see https://docs.google.com/document/d/1XLwNN2kUIGGTwz9LQ0NwJNkcybi9oKnynUEZB1jGA14/edit?usp=sharing Parameterless setLocalDescription() implicitly creates an offer or answer as appropriate based on the current signaling state. This is already implemented in third_party/webrtc using an operations chain. This CL reuses existing plumbing (used by SLD/SRD already) to surface state changes when invoking the new SetLocalDescription variety. The PeerConnectionTracker is updated to track parameterless SLD so that it shows up in chrome://webrtc-internals/. The old SLD and SRD showed up as events as follow: - When SLD(sdp) is called, a "setLocalDescription" event shows up with the SDP as the event's value. - When SLD(sdp) resolves, a "setLocalDescriptionOnSuccess" event shows up without a value. The parameterless setLocalDescription() instead shows up in chrome://webrtc-internals/ as: - When SLD() is called, a "setLocalDescriptionImplicitCreateOfferOrAnswer" event shows up without a value. - When SLD() resolves, a "setLocalDescriptionImplicitCreateOfferOrAnswerOnComplete" event shows up with the resulting SDP as the event's value. As such, chrome://webrtc-internals/ remains useful for debugging even if parameterless SLD is used. Bug: chromium:980885 Change-Id: I469f63cdaab83991749d5a0d47fe751666304fe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890420Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Steve Anton <steveanton@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#711445}
-
Jasper Chapman-Black authored
Bug: 1011921 Change-Id: I50ddf9493080432a1797ee2deec7517f77b42d1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893360Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org> Cr-Commit-Position: refs/heads/master@{#711444}
-
Min Qin authored
DownloadPathReseavationTracker::CheckDownloadPathForExistingDownload() is called on UI thread. However, the g_reservation_map should only be used DPRT's own task runner. As a result, there are race conditions that cause the method to hit a null pointer. This CL fixes the issue by posting a task on to DPRT's own task runner. And also remove the feature flag that is already enabled. BUG=1019627 Change-Id: Ibff4468f5a1fbaea4479481a115c835220089653 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891734 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#711443}
-
kylechar authored
Have SkiaOutputSurfaceImplOnGpu check that the SharedContextState isn't null before using it. It will return null if MakeCurrent fails. Bug: 1019690 Change-Id: I812f805413f57d0063a1c7c66dfdd556026db70e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893988Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#711442}
-
Eric Stevenson authored
The method references prevent the generated JNI wrapper classes from being fully inlined. Bug: 993421 Change-Id: Id4771b73cd28ba462d8cdf950573575ab215f1ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893990Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#711441}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/6524ae660745..0fa7fef72b53 git log 6524ae660745..0fa7fef72b53 --date=short --no-merges --format='%ad %ae %s' 2019-10-31 tsepez@chromium.org Make CFDE_TextOut::CalcLogicSize() take a WideStringView 2019-10-31 thestig@chromium.org Make CPDFXFA_WidgetHandler::NewAnnotForXFA() return a std::unique_ptr. 2019-10-31 thestig@chromium.org Refactor some common code in CPDF_DIBBase. 2019-10-31 tsepez@chromium.org Avoid c_str() then strlen() in view constructor in CFWL_ComboList. Created with: gclient setdep -r src/third_party/pdfium@0fa7fef72b53 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: I87aacf6221cd562fb61b7158ba6552ab3be42bff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894231Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711440}
-
Brandon Wylie authored
Bug: 998233 Change-Id: I16030e0984e8bab91c50078805642aa956dddcf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775263 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#711439}
-
dpapad authored
- SetZoomLevelForView() was not used anywhere. - GetZoomLevelForView() was only used in a test. Replaced with GetZoomLevel(). Bug: None Change-Id: If481d2477e924a4119d49ba586679c63d0320fc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877647 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#711438}
-
Eric Orth authored
DnsConfigChangeManagerClient::OnSystemDnsConfigChanged -> DnsConfigChangeManagerClient::OnDnsConfigChanged because, as of crrev.com/c/1783280, such notifications can now include non-system changes added by the Chrome net stack to the effective config. TBR=jam@chromium.org Bug: 971411 Change-Id: If46b175497a5995442e52f66152d065b0ec9b61d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787999 Commit-Queue: Eric Orth <ericorth@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Auto-Submit: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#711437}
-
Yue Zhang authored
Bug: 1019727 Change-Id: I4a07764eb71c4ff7f843602795e35d7262120c4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890393Reviewed-by:
-
Eric Stevenson authored
Same version, but the local patch now updates the max depth for a cycle detection search in R8. This allows -checkdiscard to work for generated JNI wrapper classes. Bug: 993421 Change-Id: Ib98d3ee31698788d0b0296335ff334dd2c46128f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893987 Auto-Submit: Eric Stevenson <estevenson@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#711435}
-
Jesse Schettler authored
Add a std::map to store a PrintRenderFrame with the RenderFrameHost used to bind it. When calling GetPrintRenderFrame(), use the provided RenderFrameHost to fetch the correct PrintRenderFrame associated remote or create a new one. Bug: 1019847, 1019960, 1020108 Test: https://clusterfuzz.com/testcase-detail/4896664890245120 Change-Id: I5ebf26b1dcdcd045bac1d1c5b204c8517fdb5ea3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892055Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Auto-Submit: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#711434}
-
Yuly Novikov authored
conformance/textures/misc/texture-complete.html flaky on Win7 NVIDIA passthrough Vulkan. TBR=kbr Bug: 1020295 Change-Id: Ib4e0a8437e0238291eb1ca4ea97d59e1d013a4aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894176Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#711433}
-
Joshua Bell authored
None of the AllowIndexedDB/AllowCacheStorage overrides use the "origin" params, so remove them. The renderer shouldn't be trusted anyway. Bug: 1019772 Change-Id: Ibc29455d9631b2eb36743dc5e389d0661f71219e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893678 Auto-Submit: Joshua Bell <jsbell@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#711432}
-
Nico Weber authored
They are only needed for ownership, so no need to give them names and concrete types. Removes some forward declarations from the header and serendipitously happens to remove GOOGLE_CHROME_BUILD from the header as well. No intended behavior change. Bug: 961769 Change-Id: Ibaaf3375bd9d367b4cc83b9a8ec3e64193750a69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894032 Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#711431}
-
Matt Menke authored
Also correctly populate log entry fields that were not being correctly populated, and rename one that now has a different meaning. Bug: 997049 Change-Id: I646a8e837b2aca6631c701fba261d1ea149b19f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893733Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#711430}
-
Greg Thompson authored
ScopedPathOverride instances must be cleaned up after TaskEnvironment so that residual tasks have a chance to close all open file handles. BUG=546640 R=joedow@chromium.org Change-Id: I4c3b26e1176ec851625e2d8041ed91c9ce56b9ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889976 Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#711429}
-
Etienne Pierre-doray authored
This will be used in follow up to compute agent interference metric. https://chromium-review.googlesource.com/c/chromium/src/+/1888091 Bug: 1019856 Change-Id: I493a253a4370cc24455efb0290a13f1579d7773e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881726Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#711428}
-
Arnaud Mandy authored
Adding more appropriate wording. WAITING->UNKNOWN EXISTED->SUPPORTED ABSENT->NOT_SUPPORTED renaming also EcLidAngleDriverPath to ECLidAngleDriverPath Bug: 1018705 Change-Id: Ife204169ff99c4f0c6de10f55b3e39dd17bc8d7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883574 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#711427}
-
Long Cheng authored
Bug: 1019519 Change-Id: Iea88af5abfba789cc0c02fd734d1e0954c33911c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890723Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Long Cheng <lgcheng@google.com> Cr-Commit-Position: refs/heads/master@{#711426}
-
Tommy Steimel authored
This CL makes MediaNotificationView notify its container when the header is clicked. This allows GMC's MediaNotificationContainerImplView to handle header clicks as if the container itself was clicked (which is fine since clicking the header on GMC has no effect since we hide the expand button). This fixes an issue where if the user clicked on the header (which is visually indistinguishable from the rest of the notification) then we would not go back to tab. Bug: 1020300 Change-Id: I7640b4d268871f2fe49c87c3b174f4a49e716500 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894190Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Jazz Xu <jazzhsu@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#711425}
-
Kevin McNee authored
Tbr: wjmaclean@chromium.org Bug: 1020313 Change-Id: I6acb083812d8d5c91bba57bc7b4fc367798c2624 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894256Reviewed-by:
-
Omer Katz authored
Incremental marking queries the background_marking_time statistic when it evaluates progress. The concurrent marker can update the statistic at the same time. Querying the statistic needs to be atomic. Bug: 986235 Change-Id: If69dca913f9ba2dba2d03a27801443248ce8f272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893266 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#711423}
-
Daniel Rubery authored
This reverts commit 9015f1fd, relanding 1a90cb5c. The TestBinaryUploadService did not initialize saved_result_ or saved_response_, leading to MSAN failures. Original change's description: > Preserve original Safe Browsing verdict for download deep scanning. > > In cases where deep scanning fails, we currently supply a SAFE verdict. > If the original verdict from Safe Browsing was UNCOMMON, we will > therefore downgrade the warning. This CL preserves the original verdict > and returns it in cases where deep scanning fails. It also adds a test > implementation of the BinaryUploadService, for easier testing of code > using uploads. > > Fixed: 1017921 > Change-Id: I444b301c3fe75ebbe0561bc6b201945242f09dc2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887736 > Commit-Queue: Daniel Rubery <drubery@chromium.org> > Reviewed-by: Bettina Dea <bdea@chromium.org> > Cr-Commit-Position: refs/heads/master@{#711049} Bug: 1017921 Change-Id: Ia9dfc92f1e67b9d0bffc011c6ddbaa71467f41d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893743Reviewed-by:
Bettina Dea <bdea@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#711422}
-
Omer Katz authored
Incremental marking goes in and out of AtomicPauseScope during marking. Checking InAtomicPause while concurrent marking can race with the incremental marker exiting AtomicPauseScope. Checking InAtomicMarkingPause only if !IsInIncrementalMarking checks the same condition overall but concurrent markers won't need to check InAtomicMarkingPause because IsInIncrementalMarking will always be true while concurrent marking is active. Bug: 986235 Change-Id: I6d21843b25db553dfcd0ae0e95ec3c43eaa99d49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893851Reviewed-by:
-
