- 25 Oct, 2019 40 commits
-
-
Jasper Chapman-Black authored
Usage: 1. Install emscripten locally (so that em++ works) 2. Apply the patch file 3. run build_html_viewer.py Bug: 1011921 Change-Id: I7216f57bdf76da163bff358f6c52953cd36d76da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873284 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#709484}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a7f3157ac012..60e7962ee93f git log a7f3157ac012..60e7962ee93f --date=short --no-merges --format='%ad %ae %s' 2019-10-25 halcanary@google.com Upload text blob traces as assets for the bots 2019-10-25 rmistry@google.com Remove Perf LottieWeb_Canvas CPU/GPU bots 2019-10-25 rmistry@google.com Move SkottieWASM/LottieWeb* GPU bots to Golo 2019-10-25 halcanary@google.com nanobench: option to execute directory of TextBlobTraces as benches Created with: gclient setdep -r src/third_party/skia@60e7962ee93f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Bug: None Change-Id: I5210ffaf73afc8d9dcf6be47746cdee83b768725 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880156Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709483}
-
Dominique Fauteux-Chapleau authored
This function name collides with the one in deep_scanning_dialog_delegate.cc when using use_jumbo_build=true, this rename is to fix this. Change-Id: I44d3b91e5a7a0f1df22ed243e3f985ca3799c2cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879197Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#709482}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/52d33c48770b..28bdba9493b9 Created with: gclient setdep -r src-internal@28bdba9493b9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I4cdefe3f73522d3b8879e9ed989c2cd70d4598a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880154Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709481}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/208c36706ef6..e663c7caf23c git log 208c36706ef6..e663c7caf23c --date=short --no-merges --format='%ad %ae %s' 2019-10-25 skyostil@google.com Merge "TrackEvent: Add support for dynamically enabled tracing categories" Created with: gclient setdep -r src/third_party/perfetto@e663c7caf23c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Ib857194befeeaae558ecdde01b62daf45d83faee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880153Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709480}
-
Jasper Chapman-Black authored
This establishes the framework through which the WebAssembly-backed web worker will send tree updates to the viewer thread. Currently WebAssembly constructs a JSON object, writes it to a char* in heap memory, passes that pointer to JavaScript, which reads the string out of heap memory, parses it into a JS object, and frees the heap pointer. Since sending the JS object from the web worker to the viewer thread involves a serialization/deserialization, this is performing an extra serialization/deserialization, but because any given tree load is only loading a 1-deep view of the file tree, the performance hit is very small. This sacrifice lets us maintain a common web worker API between the wasm and non-wasm implementations. TODOs have been liberally sprinkled through the CL reflecting future functionality like node filtering, components, and type-based size breakdowns. Bug: 1011921 Change-Id: I383ec97bf252657c8840d0e36cb99f52645116c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873108Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#709479}
-
Yifan Luo authored
As discussed in https://github.com/w3c/webappsec-fetch-metadata/issues/45, We have decided to shift the model around nested navigations from exposure via the request's `mode` to its `destination`. This patch shift the `nested-navigate` mode to two parts: - `navigate` for frame and iframe. - `no-cors` for object. Change-Id: I09a2be6b41547f6eeb1e308416234a40f0c9b5b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862690 Commit-Queue: Yifan Luo <lyf@google.com> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#709478}
-
Peter E Conn authored
Bug: 1017114 Change-Id: I072639120d59897cd81818944f865772019833dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879297Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#709477}
-
Sigurd Schneider authored
This is temporary to enable landing changes in DevTools. These tests will be re-baselined and re-enabled after that changes have landed. Bug: chromium:1009396 Change-Id: Id3413db3a060f070bb504ff9e94d6af120b07fb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879455Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#709476}
-
Pavel Yatsuk authored
Search engine propagated from Play API should provide search suggestions. This CL adds support for suggestions_url parameter. R=krb@chromium.org,tedchoc@chromium.org Bug: 1002271 Change-Id: I45ee7bf9585363b4c793b81369a8ce72f75246ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880372Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Kevin Bailey <krb@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#709475}
-
Manu Cornet authored
Change-Id: I9d496a7a8b4b8cb00c8a38831aa80de17ff901c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879456 Auto-Submit: Manu Cornet <manucornet@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#709474}
-
Eric Stevenson authored
Change-Id: Ie5427f4c9602502633b308ce9e89c7e7fd62e01b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881270 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#709473}
-
Jose Dapena Paz authored
Fix GCC build because of missing include: ../../ui/gfx/font.cc: In function ‘gfx::Font::Weight gfx::FontWeightFromInt(int)’: ../../ui/gfx/font.cc:114:8: error: no matching function for call to ‘lower_bound(const gfx::Font::Weight*, const gfx::Font::Weight*, int&, gfx::FontWeightFromInt(int)::<lambda(const gfx::Font::Weight&, const int&)>)’ }); ^ In file included from /usr/include/c++/8/bits/char_traits.h:39, from /usr/include/c++/8/string:40, from ../../ui/gfx/font.h:8, from ../../ui/gfx/font.cc:5: /usr/include/c++/8/bits/stl_algobase.h:984:5: note: candidate: ‘template<class _ForwardIterator, class _Tp> _ForwardIterator std::lower_bound(_ForwardIterator, _ForwardIterator, const _Tp&)’ lower_bound(_ForwardIterator __first, _ForwardIterator __last, ^~~~~~~~~~~ /usr/include/c++/8/bits/stl_algobase.h:984:5: note: template argument deduction/substitution failed: ../../ui/gfx/font.cc:114:8: note: candidate expects 3 arguments, 4 provided }); ^ Bug: 819294 Change-Id: Ic59dcf3a06bdd54d1d426c08a61624873a0ff30c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879909 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#709472}
-
Thomas Tellier authored
Bug: 993972 Change-Id: Icc6797cc36d9337c7fb7f34d7d91a67b42bff5d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873748 Commit-Queue: Thomas Tellier <tellier@google.com> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#709471}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0e0b9a97..008243fd Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia29a37476ac0f71c75588121e9ae316944efdb9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881187Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709470}
-
Jose Dapena Paz authored
GCC fails to build because the declaration of the enum class ForcedColors clashes with the GetForcedColors method. Bug: 819294 Change-Id: I5c7647978d15c771f5372a8c70ac6aeb2284fb2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879452Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Cr-Commit-Position: refs/heads/master@{#709469}
-
Tibor Dusnoki authored
There is currently a workaround for this test failure for Windows ARM64 https://chromium-review.googlesource.com/c/chromium/src/+/1593360 but it is no longer needed since the fix has landed in llvm https://reviews.llvm.org/D63635 Bug: 925584 Change-Id: I32de8ee38e50265d4875a05f9964cbcb8fc37eba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869413 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#709468}
-
Ryan Sleevi authored
CertStatus contains additional information than contained solely within a net::Error, and so converting from a Status -> Error -> Status loses that fidelity, even though it's "safe" to go Error -> Status -> Error. This also corrects a few unittest CertVerifiers flagged during review which have no functional impact. Bug: 618799 Change-Id: I6a098c70c2a870f4f9c22801f24d906a4faf04ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879852Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#709467}
-
Matt Menke authored
We want to make server auth cache respect the NetworkIsolationKey, but need that capability to be able to be toggled during runtime (and possibly per profile) so enterprises can disable it. Loading enterprise configurations while in the middle of copying server auth credentials gives us non-deterministic behavior configs when this setting is toggled, and copying it between two profiles with different settings is also pretty weird. The simplest solution is just to only copy proxy credentials, which are what the copying logic is only really intended for, anyways. Bug: 993806 Change-Id: I26d4f0f92e695e844ff72ec5df83eeaefd9f1b5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875271Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#709466}
-
Jinsong Fan authored
In the current implementation, always use the selection rect fully between the handles to calculate the location of the context menu, but the selection rect may be clipped, so in this case, the position of the context menu will be far from the clipped selection rect. The CL computes the clipped selection rect for showSelectionMenu. Bug: 1015274 Change-Id: I7aaf27337c7009eb9fef78f3a1ee92e521de8cda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868575Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Jinsong Fan <fanjinsong@sogou-inc.com> Cr-Commit-Position: refs/heads/master@{#709465}
-
Vasilii Sukhanov authored
The two probable reasons for the flakiness were: - we didn't wait until the keystrokes were processed in the renderer. See crbug.com/955455 - we don't wait for the password store returning some results after navigation. Both are fixed in the CL. Let's observe the pass rate. Bug: 1013743 Change-Id: Ic328afbe2cd652119a773c28d49ff450cf0d5405 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879237Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#709464}
-
Robert Ma authored
Instead of relying on PATH, we explicitly call the luci-auth binary (or luci-auth.bat on Windows) in blinkpy. Bug: 1017404 Change-Id: Ic44afadad52d17370db4ada910d6c02e37a95289 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879559Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#709463}
-
Kenichi Ishibashi authored
A brief summary of this plumbing is below: blink::ServiceWorkerContainer::registerServiceWorker() -> (IPC from a renderer to the browser) -> content::ServiceworkerContextCore::RegisterServiceWorker() Start a registration job asynchronously Create a ServiceWorkerVersion and set the passed settings object -> content::ServiceWorkerVersion::StartWorker() -> (IPC from the browser to a renderer) -> WebEmbeddedWorkerImpl::StartWorkerContext() -> ServiceWorkerGlobalScope::FetchAndRunClassicScript() (Note that renderer processes of above don't have to be the same.) This CL has behavioral changes. The 'Referer' header of the request triggered by register() in a document will be changed. Before this CL it was the url of the top-level script but after this CL it is document's url. This behavior is consistent with the spec. Bug: 937177 Change-Id: I4c137d10b7d5204151ae7eff8bfd8fdeb34fb365 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861294 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#709462}
-
Dan Elphick authored
Add a v8_maybe_snapshot dependency to generate_v8_context_snapshot so it is rebuilt when the v8 snapshot changes. Without this change, in component builds v8 changes would cause libv8.so to rebuild but would rarely trigger a v8 context snapshot build. Fixed: 865389 Change-Id: Ib35b564bc28147fcb090c3b7f7fa852c11846684 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878249Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#709461}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/24a409611f24..a7f3157ac012 git log 24a409611f24..a7f3157ac012 --date=short --no-merges --format='%ad %ae %s' 2019-10-25 herb@google.com Only scale fallback font if it is too big Created with: gclient setdep -r src/third_party/skia@a7f3157ac012 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Bug: None Change-Id: I86e7a4de908f34d8f9dbdcb820e21a381f828a92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881167Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709460}
-
Robbie Gibson authored
Bug: 1014702 Change-Id: Ie3b0e41a11a36bddd41be0dfbeb86423ae235847 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879236Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#709459}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4f2783b9fe77..16cec3be2c96 git log 4f2783b9fe77..16cec3be2c96 --date=short --no-merges --format='%ad %ae %s' 2019-10-25 philipel@webrtc.org Added allow_codec_switching parameter to RTCConfig. 2019-10-25 hbos@webrtc.org Revert "[PeerConnection] Use an OperationsChain in PeerConnection for async ops." 2019-10-25 danilchap@webrtc.org Cleanup PacketBuffer tests to use immediate result Created with: gclient setdep -r src/third_party/webrtc@16cec3be2c96 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I6ba84d5eefe5239bd1e88d5e9889de1ee3ccd0b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881168Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709458}
-
Sebastien Marchand authored
This is unlikely to happen in practice, but there's still a tiny race possibility that could cause this if we ever decide to immediately freeze tabs after they're being sent to background. Change-Id: I33fbd9f31692e3e1c8c2c269da01f83c9d672363 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869721 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#709457}
-
Thomas Tangl authored
Mocks: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZS4C13RU2slZ/files/MCEJu8Y2hyDScSRec_gUtrkQDjJvcy3ALJI Bug: 1017241 Change-Id: I4a06b95fb6d93de04c3c031674ef7f422da99bd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879917 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Auto-Submit: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#709456}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I201d491e379e473196343ee07d2ccc7c08b98544 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880700Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709455}
-
Sebastien authored
This is triggering a Finch warning when trying to make changes to the GCL file. (cl/275848776) Change-Id: Id95ed8dd6e34ab48f171ec8e3ec8614567ea0519 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879867Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Auto-Submit: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#709454}
-
Olle Liljenzin authored
SysUtils has to be in main dex file since child processes use SysInfo::IsLowEndDevice() which depends on it. Bug: 1018167 Change-Id: I61c2a040e1ccb78725c852bcabe31cf45f217522 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879896 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#709453}
-
Sigurd Schneider authored
This test adds a regression test for breakpoints in inline scripts with #sourceURL=. Bug: chromium:1017738 Change-Id: Id5c58cf7e8346879b1ad37a79262d4516708b580 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878652 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#709452}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/57b9fe40c414..e0f4b5423da2 git log 57b9fe40c414..e0f4b5423da2 --date=short --no-merges --format='%ad %ae %s' 2019-10-25 mmortensen@google.com Improve error handling in determine_android_package for portage errors. Created with: gclient setdep -r src/third_party/chromite@e0f4b5423da2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I7094aef96ab9573e1b7b0e2f1c5efe87c02b501e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880803Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709451}
-
sandromaggi authored
Some sites require a format of MM/YY which was previously not available for required fields. Bug: b/143266929 Change-Id: I68bc11b752d00a088e1514a7c0db1edfd4b7ff74 Bug: b/143266929 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879892 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#709450}
-
Peng Huang authored
With this change, --gr-context-type=Vulkan or --enable-features=Vulkan will enable vulkan compositing. If the --use-vulkan=impl_name is used, the specified vulkan implementation will be used otherwise the native vulkan implementation will be used by default. Bug: 1009029 Change-Id: I7730f48ab000b7edf6db892ac63bc585383d4fb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878529 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#709449}
-
Thomas Tangl authored
Bug: 1018191 Change-Id: I2db59d17037f4933751545a85ea372841241d010 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879295 Auto-Submit: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#709448}
-
Tim Volodine authored
In this patch: - add the abstract GmsBridge class and its corresponsing upstream implementation (GmsBridgeImpl.java). GmsBridge class manages functionality related to Google Mobile Services (GMS). - add the initialization of safebrowsing handler on WebLayer startup. - add .gn build deps and targets needed for the relevant upstream targets. In the future a different GmsBridgeImpl class will be compiled-in depending on whether an internal clank/ checkout is present. BUG=1015418 Change-Id: I5a45023a0ab6f31ce6db1daa7f62bf7c2579a84b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876032Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#709447}
-
Boris Sazonov authored
Disables DirectActionAvailabilityTest#testCoreDirectActionInWebappActivity as it has been flaking a lot. Failed build link: https://ci.chromium.org/p/chrome/builders/ci/test-n-phone/8984 TBR=szermatt@chromium.org Bug: 1018183 Change-Id: I0812cff148432b0990a66411f94d9d2415531e56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879898Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#709446}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a446a6f7..0e0b9a97 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I03456adddc1830a3a0b84a8c08c754345d5628b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880054Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709445}
-