- 16 Aug, 2018 11 commits
-
-
Daniel Zhang authored
Landed functionality separately. Bug: 865543 Change-Id: Ic44263ff2273ef97aec357c7a842a1134d57d061 Reviewed-on: https://chromium-review.googlesource.com/1171342 Commit-Queue: Daniel Zhang <oxyflush@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#583462}
-
David Tseng authored
Bug: 869898 Change-Id: I66d0ac277e0b78ea40b1eff277fbdda61bdee0fb Reviewed-on: https://chromium-review.googlesource.com/1176423Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#583461}
-
Zhongyi Shi authored
Change-Id: I1962561658a57be3adfcd88368926dff90091fa8 Reviewed-on: https://chromium-review.googlesource.com/1176189Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#583460}
-
Takumi Fujimoto authored
If there is an issue associated with a sink, use the issue text as the status text for the sink. Bug: 874625 Change-Id: I2dd844a851cc58828047dd3305b3fd729ba514e0 Reviewed-on: https://chromium-review.googlesource.com/1176473Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#583459}
-
Ben Smith authored
It is currently enabled via finch for these platforms on 67+. Bug: chromium:821270 Change-Id: Id402c71a8b9d108bbe0d8bca7fc585aff201241a Reviewed-on: https://chromium-review.googlesource.com/1159358Reviewed-by:
Ojan Vafai <ojan@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Ben Smith <binji@chromium.org> Cr-Commit-Position: refs/heads/master@{#583458}
-
Yoshifumi Inoue authored
This patch changes |IsEditablePosition()| to use |Position:: ComputeContainerNode()| instead of |Position::ParentAnchoredEquivalent()| not to incorporate |EditorIngoreContetns()|, e.g. <hr>, <img>, etc. For "<hr contenteditable>", |IsEditablePosition(<hr>@0)| returns false before this patch. After this patch, it returns true. Bug: 873088 Change-Id: Id75bd2c857dbd85e59f7795d02f3583802347060 Reviewed-on: https://chromium-review.googlesource.com/1172273Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#583457}
-
Eric Karl authored
A change earlier in M70 allowed us to more aggressively re-use discardable handles. Unfortunately, as handle IDs (even those with outstanding refs) were re-used as well, leading to issues where the same handle was being used for two textures. This change moves to a globally-incrementing ID system for discardable handles, which removes the possibility of accidentally referencing a deleted but re-used handle. Bug: 870317 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I6ba8999d5f90d3ddb9c909cbbbd7f66c30ae6613 Reviewed-on: https://chromium-review.googlesource.com/1176223Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#583456}
-
Jun Cai authored
Based on the comment at: https://bugs.chromium.org/p/chromium/issues/detail?id=862176 This CL makes: SecurityExploitBrowserTest.InvalidOriginHeaders ExtensionUnloadBrowserTest.UnloadWithContentScripts early return if network service is enabled. Bug: 862176 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I040ac9615a6deed786825d306a9192d14925a5cc Reviewed-on: https://chromium-review.googlesource.com/1176479Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#583455}
-
Danyao Wang authored
TabTest uses the internal NavigationManagerImpl::CommitPendingItem() API. WKBasedNavigationManager's implementation of this API requires a precondition that a WKBackForwardListItem exists for the to be committed pending item. Mocking out WKWebView allows injection of WKBackForwardList item to satisfy this precondition. Parameterized TabTest to test both navigation manager implementations on trybot. Bug: 863026 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I5f6b2faa94c1c63682a333c9f8c7c2600017cdea Reviewed-on: https://chromium-review.googlesource.com/1176376 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#583454}
-
Sonny Sasaka authored
This deprecates BlueZ.ChipLost because we need to filter out suspend/resume events even when adapter is disabled. Corresponding CL where metrics is used: https://crrev.com/c/1176398. BUG=chromium:813390 Change-Id: I8620fdd1c0225a97226d462e234643882f6553a5 Reviewed-on: https://chromium-review.googlesource.com/1176371 Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Miao-chen Chou <mcchou@chromium.org> Cr-Commit-Position: refs/heads/master@{#583453}
-
Anand K. Mistry authored
cros-disks doesn't raise this error. Chrome did for a while, but the last usage was removed in crrev.com/255348 BUG=None Change-Id: I847ccc818f67bb41b4e74f54ac6ed6c52d82858a Reviewed-on: https://chromium-review.googlesource.com/1174580Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#583452}
-
- 15 Aug, 2018 29 commits
-
-
rajendrant authored
This CL adds basic support (behind a flag) for deferring the load of html image elements until the user scrolls near them, in order to reduce network data usage, memory usage, and speed up the loading of other content on the page. LazyLoadImageObserver is created per document and that holds an IntersectionObserver to observe the <img> elements within the document. When the IntersectionObserver detects that the deferred image element is within a specific distance threshold of the viewport, it resumes loading the image. Subsequent CLs will defer CSS background images as well, and configure the hardcoded distance-from-viewport threshold from field trial. See the design docs below for more info. LazyImages design doc: https://docs.google.com/document/d/1jF1eSOhqTEt0L1WBCccGwH9chxLd9d1Ez0zo11obj14/edit LazyLoad design doc: https://docs.google.com/document/d/1e8ZbVyUwgIkQMvJma3kKUDg8UUkLRRdANStqKuOIvHg/edit Bug: 846170 Change-Id: I8c1024a4cdb19f3c6c700ae49eec6369b67b72b4 Reviewed-on: https://chromium-review.googlesource.com/1132573 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#583451}
-
John Budorick authored
Bug: 868525 Change-Id: I65aabb60d4823423d7f0bd4d5b51ea145c665658 Reviewed-on: https://chromium-review.googlesource.com/1176471Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#583450}
-
Ehsan Karamad authored
The test is disabled. Since it is Mac only, simply marking it as DISABLED. Also adding a bug reference for the test. TBR=avi@chromium.org Bug: 874417 Change-Id: I32703a9c0a874d15e3b9ea2f550a7d731f56cd3e Reviewed-on: https://chromium-review.googlesource.com/1176295Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#583449}
-
Philip Rogers authored
This patch removes UpdateLayers::BuildPropertyTrees trace events when in layer lists mode which is used by blink gen property trees and slimming paint v2. This patch also cleans up LayerTreeHost::DoUpdateLayers by removing the unused in_update_property_trees_ variable. Bug: 836886 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-gen-property-trees;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I35e6bd7c59b0384d8c2c62a1d3bdb1eed152353b Reviewed-on: https://chromium-review.googlesource.com/1176357Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#583448}
-
Trent Apted authored
Apart from some simple classes (Foo, Adder), the existing test suites really don't share very much code. After https://crrev.com/c/1053338 they will share even less. Split out the threaded tests to their own file to reduce complexity. This is largely a verbatim move (preserving order), apart from whitespace changes. Bug: 842987 Change-Id: I555662a5516add7267abd1608f54fd13cbd7d97c Reviewed-on: https://chromium-review.googlesource.com/1175508Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#583447}
-
Nicolas Norvez authored
biod collects some metrics that aren't taken care of by Chrome (see CL:1166462) for the Chrome-side metrics. Specifically biod knows about the capture/matching latency. We also add the number of fingers that have been enrolled as it's more readily accessible to biod than it is to Chrome. The corresponding Chrome OS CL is CL:1173770 R=xiaoyinh Bug: 862295 Change-Id: I8ae56d278fd9af4494bb969e7ff6e8bb336ad2bb Reviewed-on: https://chromium-review.googlesource.com/1175458Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Nicolas Norvez <norvez@chromium.org> Cr-Commit-Position: refs/heads/master@{#583446}
-
Kyle Horimoto authored
This CL adds a new set of APIs for getting/setting the states of the multi-device features as well as adding an observer pattern for receiving updates to these feature states. Bug: 824568 Change-Id: If79c713b9737a738bcb9347871f0db913b7abb5b Reviewed-on: https://chromium-review.googlesource.com/1172707 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#583445}
-
Mattias Nissler authored
This new notification alerts the user about a pending TPM firmware update for the device and directs them to the about page to trigger update installation. We currently only show the notification for a case where the user has already decided to install the update, but another powerwash is required to clear a vulnerable key that may have remained in some cases. BUG=chromium:872746 TEST=Manual Change-Id: Id0bf5146d411af1741bb35f7e6d4c8d2437a0080 Reviewed-on: https://chromium-review.googlesource.com/1175794Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Mattias Nissler <mnissler@chromium.org> Cr-Commit-Position: refs/heads/master@{#583444}
-
Zhongyi Shi authored
Change QSF::Job to create a new connection on the alternate network if the original connection fails on the default network before handshake is confirmed. Bug: 790547 Change-Id: I161c09bf97f98540dd8eb6e83c811ca34d31f883 Reviewed-on: https://chromium-review.googlesource.com/1175191Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#583443}
-
Dale Curtis authored
See bugs for more detail; this only helps M+ where we're using the callback API now and can get the true error status earlier than we could before. This also adds a log message when onError is called so that we can debug these more easily in the field. BUG=873094, 610523 TEST=none Change-Id: I3fbae95e872fe430f7dd0ddc70b01552492bd64a Reviewed-on: https://chromium-review.googlesource.com/1176168Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#583442}
-
Kristi Park authored
<button> is type="submit" by default. Adding type="button" will prevent the Cancel and Delete buttons from triggering the "submit" event. Bug: 874018 Change-Id: Ie72ec07ddbaeccee29588612fc8938f268150f20 Reviewed-on: https://chromium-review.googlesource.com/1174804 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#583441}
-
Etienne Bergeron authored
Safe browsing is a low bandwidth category and it worth collecting the information since it may affect system wide performance. Under that caterory, the main important trace events are to detect whether or not the chrome_cleaner tool is scanning or cleaning. We suspect that the cleanup tool is having system wide impact and may explain janks observed in slow-reports. R=oysteine@chromium.org Change-Id: I604fdb89fd2bbbb0b13751c281cc0d936f426848 Reviewed-on: https://chromium-review.googlesource.com/1176264Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#583440}
-
Miguel Casas authored
This CL changes the signature of GpuVideoAcceleratorFactories' VideoFrameOutputFormat(size_t bit_depth) to VideoFrameOutputFormat(media::VideoPixelFormat pixel_format) which is needed for the next CL (see also crrev.com/c/1171569). VideoFrame::BitDepth() is extracted to media/base/video_types.cc. Bug: 873345 Change-Id: I0afb480657ffb5ae5c3b01b6384832221476e1e9 Reviewed-on: https://chromium-review.googlesource.com/1174946Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#583439}
-
Findit authored
This reverts commit ec552f22. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 583369 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZWM1NTJmMjI5NTM5NzM4NzFjZWExZTYyNWNmNmIzNjZjOGMzNjM0NQw Sample Failed Build: https://ci.chromium.org/buildbot/tryserver.chromium.chromiumos/linux-chromeos-rel/71344 Sample Failed Step: mash_browser_tests (with patch) Sample Flaky Test: ChromeSitePerProcessPDFTest.SendSyntheticTapGestureOOPIF Original change's description: > Set touch action Auto in MaybeSendSyntheticTapGesture > > The MaybeSendSyntheticTapGesture can be called in PreProcessMouseEvent, > in which case the TouchActionFilter::allowed_touch_action_ has no value > and will result in a crash. > > This CL set the allowed_touch_action_ to auto to fix the issue. A > browser test is added. > > Bug: 873211 > Change-Id: If776a93fe2c8f7a311a10bc0fec42cda15d0ae9a > Reviewed-on: https://chromium-review.googlesource.com/1169585 > Commit-Queue: Xida Chen <xidachen@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: Timothy Dresser <tdresser@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583369} Change-Id: I2b4c4fb6b76a7a904603e7bf1086fe4f42d9f1e3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 873211, 874667 Reviewed-on: https://chromium-review.googlesource.com/1176503 Cr-Commit-Position: refs/heads/master@{#583438}
-
rbpotter authored
interactive_ui_tests: These tests are flaky on debug builds. browser_tests: These tests are failing on official builds. Bug: 862472 Change-Id: I4ec7ae2c6f42abd3ccaf023dc803d3317faa1434 Reviewed-on: https://chromium-review.googlesource.com/1176206Reviewed-by:
Reid Kleckner <rnk@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#583437}
-
Dominik Laskowski authored
This CL turns ShellSurfaceBase::OnSurfaceCommit into a template method to isolate logic for ShellSurface and ClientControlledShellSurface. Bug: b:77972398 Test: exo_unittests Change-Id: Iad359c3754f9955fd34ea372a06e6d53999b8877 Reviewed-on: https://chromium-review.googlesource.com/1176182Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Dominik Laskowski <domlaskowski@chromium.org> Cr-Commit-Position: refs/heads/master@{#583436}
-
Peter Boström authored
This fixes a bug where the browser window is left open and the dialog title rolls over from "A Chromium update is available" to "A Chromium update has been available for N days" which causes the title to wrap. This is only a band-aid fix, calling BubbleFrameView::UpdateWindowTitle should either push the width or height of the dialog to accommodate for the longer title string. Bug: chromium:869448 Change-Id: Ib78082e386111cb1da3835952fb9644051c6e572 Reviewed-on: https://chromium-review.googlesource.com/1173664 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#583435}
-
Alexandr Ilin authored
PlatformSharedMemoryRegion leaked handles after serializing into the IPC message on Windows, Mac and Fuchsia. Serialization code incorrectly assumed that HandleWin, MachPortMac and HandleFuchsia classes take ownership over the handle. What really happens is that HandleFoo is passed to WriteParam(), which causes ParamTraits<HandleFoo>::Write() to be invoked, before it returns, creating the HandleAttachmentFoo, which will duplicate the handle. By the time we return from WriteParam() the handle should have been duplicated into the serialized message, so we can safely let the PSMR close the handle when it goes out of scope. This CL makes the PlatformSharedMemoryRegion serialization repeat the logic of the base::SharedMemoryHandle serialization as if the OwnershipPassesToIPC() flag is always set to true. Bug: 873313, 873668 Change-Id: I4e98ff9483a48970ebcb2fcf6b150f447af82794 Reviewed-on: https://chromium-review.googlesource.com/1175918 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#583434}
-
Alex Newcomer authored
At request of PM/UX, disable playstore search in the launcher. Bug: 872397 Change-Id: Id3887904084be816e70a530bd143abe034a9d613 Reviewed-on: https://chromium-review.googlesource.com/1170990Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#583433}
-
Yue Cen authored
Bug: 835029 Change-Id: Ia7a73145c3d4840bd73db80170bc7eafef24ca8f Reviewed-on: https://chromium-review.googlesource.com/1173067Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Yue Cen <rsgingerrs@chromium.org> Cr-Commit-Position: refs/heads/master@{#583432}
-
Lei Zhang authored
There is only one caller and it does not pass in a GURL. Change-Id: I4ceef596436183e43e2276b3978b5f3137101eb1 Reviewed-on: https://chromium-review.googlesource.com/1175555 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#583431}
-
Helen Li authored
This CL adds NetLog events to SQLitePersistentCookieStore. This is split off from rdsmith@'s CL at https://chromium-review.googlesource.com/c/chromium/src/+/925181 TBR=marq@chromium.org Bug: 801910 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I6404a341bbebbd19078b834a483804f4b8468447 Reviewed-on: https://chromium-review.googlesource.com/1174570 Commit-Queue: Helen Li <xunjieli@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#583430}
-
Justin TerAvest authored
This reverts commit 4eb610a5. Reason for revert: Causing browser crashes when launching the play store on ChromeOS on Octopus machines. b/112321675 Original change's description: > Enable apps grid gap by default > > Bug: 871448 > Change-Id: I3f8b2c4c9e22065c6615db7d3fab8c8c6b1a7e20 > Reviewed-on: https://chromium-review.googlesource.com/1164245 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Weidong Guo <weidongg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581039} TBR=xiyuan@chromium.org,weidongg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 871448 Change-Id: I4c43f73fead16eb2c8208d9447968775d6d12dba Reviewed-on: https://chromium-review.googlesource.com/1174780Reviewed-by:
Justin TerAvest <teravest@chromium.org> Reviewed-by:
Weidong Guo <weidongg@chromium.org> Commit-Queue: Justin TerAvest <teravest@chromium.org> Cr-Commit-Position: refs/heads/master@{#583429}
-
Matt Reynolds authored
Under normal circumstances, gamepad state can only change in response to certain triggers. By using the gamepadController test API, the gamepad state may be changed in response to many more triggers, including gamepad events themselves, which may cause some events to not be dispatched. This CL modifies the layout test to only change gamepad state outside of gamepad event listeners. This CL also removes a hack where the string representation of the gamepad state was being compared instead of the underlying buffers. This hack was intended as a workaround for a bug caused by incorrect buffer reuse behavior. The bug still exists but the test is modified to test the reuse behavior as intended. BUG=855760 Change-Id: I75144ae68efa355992d03692e2fd52b2f832281f Reviewed-on: https://chromium-review.googlesource.com/1173329 Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#583428}
-
Chris Hamilton authored
These histograms are currently empty due to (a) incorrect reporting or (b) lack of reporting. Change-Id: Ia19b49a713fc59e57f10cdfa1d5344e39c63ee2e Reviewed-on: https://chromium-review.googlesource.com/1173325 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#583427}
-
edchin authored
Bug: 870145 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I56a5bb19f366ce570ca058f85853a35df472b4cf Reviewed-on: https://chromium-review.googlesource.com/1176221Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#583426}
-
Sidney San Martín authored
This change uses an undocumented interface to the Mac SMC (System Management Controller) to read power consumption by different parts of the computer, including CPU and GPU(s). These web pages and projects were all helpful, or critical, in writing it and checking assumptions: - https://opensource.apple.com/source/PowerManagement/PowerManagement-271.1.1/pmconfigd/PrivateLib.c.auto.html - https://opensource.apple.com/source/IOKitUser/IOKitUser-647.6/pwr_mgt.subproj/IOPMLibPrivate.c - https://web.archive.org/web/20140816041243/http://www.parhelia.ch/blog/statics/k3_keys.html - https://stackoverflow.com/questions/28568775/description-for-apples-smc-keys - https://github.com/theopolis/smc-fuzzer - https://github.com/beltex/SMCKit/ - https://github.com/hholtmann/smcFanControl/ - https://github.com/Chris911/iStats - https://github.com/RehabMan/OS-X-FakeSMC-kozlek/ - https://www.virtualbox.org/svn/vbox/trunk/src/VBox/Devices/EFI/VBoxSmcUtil-darwin.cpp Bug: 871801 Change-Id: I4dcd8e06b7506743e9c5e7514c7f6f9c8f2b3205 Reviewed-on: https://chromium-review.googlesource.com/1165314 Commit-Queue: Sidney San Martín <sdy@chromium.org> Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#583425}
-
Robert Ogden authored
Loads the original page on a 404 or 503 server response. Further actions for these response types will be in follow up CLs. Bug: 864656 Change-Id: I861685e0d19f5597ade3ed814e9847a3595d9e31 Reviewed-on: https://chromium-review.googlesource.com/1171799 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#583424}
-
lanwei authored
The DispatchKeyEvent in InputMethodWinBaseIMM32 does not have any code special to IMM32, so I move it to InputMethodWinBase, which can be shared by both InputMethodWinBaseIMM32 and InputMethodWinBaseTSF. This CL does not have any new behavior change. This DispatchKeyEvent works when TSF is enabled, but I will try to use TSF API to replace PeekMessage API in the following CLs. Bug: 657623 Change-Id: I0b03f7b393660676ff26df1a9bdbfbbd43dc6a45 Reviewed-on: https://chromium-review.googlesource.com/1173336 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#583423}
-