GitLab

The code has moved, so update the includes.

R=avi@chromium.org

Bug: 1091083
Change-Id: I2c9a5c20b78756fc0b460a85f00d8560f1883979
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412947
Commit-Queue: Avi Drissman <avi@chromium.org>
Auto-Submit: danakj <danakj@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807483}

Couple of comments about 'overflow:clip':
. Per spec it does not create a new formatting context.
. Implementation will create a PaintLayer, but it won't create a
  scrollable area.
. Can not be scrolled.

This adds IsScrollContainer to ComputedStyle and LayoutObject. The
name 'scroll container' comes from
https://www.w3.org/TR/css-overflow-3/#scroll-container .

As 'overflow: visible' may be set along one axis, and 'overflow: clip'
another, this renames IsOverflowVisible() to
IsOverflowVisibleAlongBothAxes() to make it clear it applies to both
axes.

BUG=1087667
TEST=this is mostly a rename, so no direct tests. Once OverflowClip is
     enabled, there are layout tests exercising this.

Change-Id: I5a4647a19e31c7ad212929bb9e408708fd61d441
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402303Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807482}

https://android.googlesource.com/platform/external/perfetto.git/+log/38f0f40310d6..d1382ae74fac

2020-09-16 primiano@google.com Merge "iorap API: fix thread race when initializing the consumer library"
2020-09-16 treehugger-gerrit@google.com Merge "Roll trace processor"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I3e6e58bed619a859b1cbc81fd370599ee7a209e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413237Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#807481}

This makes all methods of Tab/Browser throw an exception if
used after the Tab/Browser has been destroyed. Hopefully this
will make it easier to identify bad usage rather than NPEs slightly
deeper in the stack.

BUG=none
TEST=none

Change-Id: Id42839c5aca2061f811b5ec07aefd1e0f187d55a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412550
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807480}

* > autotest ... base/strings/strcat.cc
  will now run tests for base/strings/strcat_unittest.cc

* > autotest ... strcat
  no longer complains "strcat" is ambiguous, since strcat_unittest.cc is
  the only matching test file.

* Fixed rare case where caching could use the wrong
  target.

Change-Id: Id028b8d5477687bef02b6cd94688f74839d08964
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407857Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Dan H <harringtond@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807479}

If contacts are removed from the allowlist, only the selected-contacts
visibility private certificates need to be recreated. If the contact
list changes, only the all-contacts visibility private certificates need
to be recreated. (Ideally, we would only recreate all-contacts
visibility private certificates if contacts are removed from the contact
list, but we do not have this information.)

These revocations need to occur so that unauthorized contacts do not
have access to valid certificates. Previously, all private certificates
were being recreated in both scenarios, which is safe but overkill.

Fixed: b/168022980, 1123134
Change-Id: I9263e02f2cca72c5b350368d42596c5f2d5655e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412890
Commit-Queue: Josh Nohle <nohle@chromium.org>
Reviewed-by: James Vecore <vecore@google.com>
Cr-Commit-Position: refs/heads/master@{#807478}

Update obtaining a pinUvAuthToken using UV with the latest
specification.

* The error for a bad fingerprint read is now ERR_UV_INVALID.
* ERR_UV_BLOCKED now may be returned both before or after the user taps
  the authenticator. Query the number of remaining attempts before
  trying to obtain a UV token to avoid a locked authenticator from
  blocking requests to other authenticators.

Fixed: 1127062
Change-Id: I81a0eb7620213e1cbe0afbf63bf93c45fd4bea18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412892
Commit-Queue: Nina Satragno <nsatragno@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#807477}

When HardwareDisplayController get disabled we should disable all
planes, including the primary, by setting the fb to 0.
Not doing so can have privacy implications, where we might end up
reading back the last fb when modesetting again and show to the user
contents that should not be seen.

In the past, when legacy modesetting was used, the fb associated with
the crtc was set to 0 when calling drmModeSetCrtc. After that we'd
disable the other planes but the primary.

Since we moved to the atomic API for modesetting, we now need to
explicitly set to 0 the fb of the primary plane along the other planes.


Bug: 1102859
Test: Close/open the lid on krane, no old contents are visible.
Change-Id: Ib93347b59cc847898c0713f81ad0903773699b07
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412974
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Gil Dekel <gildekel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807476}

Reland "Consolidate translation check and execution logic between TranslateManager and RenderViewContextMenu"

This is a reland of 24c91f76

Original change's description:
> Consolidate translation check and execution logic between TranslateManager and RenderViewContextMenu
>
> Consolidated logic by having RenderViewContextMenu::ExecTranslate call
> TranslateManager::InitiateManualTranslation, and RenderViewContextMenu::AppendPageItems call
> TranslateManager:CanManuallyTranslate.
>
> Bug: 898168
> Change-Id: If91cf98626f73d0c357522f8fdca840695185bc2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385636
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: Megan Jablonski <megjablon@chromium.org>
> Commit-Queue: Anthony Cui <cuianthony@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#806161}

Bug: 898168
Change-Id: Iddd188034e471d3b4e8e09650d9f1e88cb2bc268
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410645Reviewed-by: Megan Jablonski <megjablon@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Anthony Cui <cuianthony@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807475}

Using chrome://theme/current-channel-logo, which does not work on
iOS and Android.

Bug: 820678
Change-Id: I5b0028bd75dd52c55359264b7d72e8cd04d4be9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1588799
Commit-Queue: Peter Boström <pbos@chromium.org>
Auto-Submit: dpapad <dpapad@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807474}

Bug: 1128463
Change-Id: I32f05328e590ad7e8772cec8119e6d253d456853
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412448
Auto-Submit: Mike Dougherty <michaeldo@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807473}

This CL fixes the broken fade-in animation and adds an overshoot
animation for the arriving suggestions (see linked bug for
screenrecording).
The animation is density-independent and works in RTL by mirroring the
movement.

Bug: 1124720
Change-Id: I3d93a610c66404ac0cfa6db5b277b0b210a62250
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411938Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807472}

This CL adds a search view to the bottom sheet and filters
the credentials list with every newly typed character.

Screenshot: https://bugs.chromium.org/p/chromium/issues/detail?id=1104132#c18

Bug: 1104132
Change-Id: Ib9528abcc8ffa3981f37fe3d7334156aa71ff0fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391132
Commit-Queue: Reda Tawfik <redatawfik@google.com>
Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807471}

Soon, the reports will contains URLS about the other document:
- openeeURL
- openerURL
- otherDocumentURL
- referrer
- initialPopupURL

Depending on whether they are same-origin or cross-origin with the
reporter document, they might be reported or not.

This patch add a same-origin/cross-origin variant for every type of
accesses.

Bug: 1090273
Change-Id: Ieeb396f6220877a2a61541cb33a964261e5f4070
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407314Reviewed-by: Pâris Meuleman <pmeuleman@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807470}

GCC fails to build with this:
../../pdf/thumbnail.cc:116:1: error: function ‘chrome_pdf::Thumbnail::Thumbnail(chrome_pdf::Thumbnail&&)’ defaulted on its redeclaration with an exception-specification that differs from the implicit exception-specification ‘’
  116 | Thumbnail::Thumbnail(Thumbnail&& other) noexcept = default;
      | ^~~~~~~~~
../../pdf/thumbnail.cc:118:12: error: function ‘chrome_pdf::Thumbnail& chrome_pdf::Thumbnail::operator=(chrome_pdf::Thumbnail&&)’ defaulted on its redeclaration with an exception-specification that differs from the implicit exception-specification ‘’
  118 | Thumbnail& Thumbnail::operator=(Thumbnail&& other) noexcept = default;
      |            ^~~~~~~~~

Problem is that Skia SkBitmap move constructor and assignment operators are
not noexcept (and after some discussion it is going to be kept this way).

So the default implementation of move constructor and assignment operator
of pdf::Thumbnail is noexcept, as SkBitmap is a member. The fix just
removes noexcept declarations.

Bug: 819294
Change-Id: I8e6d914e4850707fbfcb51200b2a80d185cd1c19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411656Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: José Dapena Paz <jdapena@igalia.com>
Cr-Commit-Position: refs/heads/master@{#807469}

https://chromium.googlesource.com/angle/angle.git/+log/5453e7b7795f..3018d5e57091

2020-09-16 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from e59713d4edda to f105898a102f (6 revisions)
2020-09-16 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 726af6f78f80 to e8ce4355ae1c (9 revisions)
2020-09-16 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from dc552fcef1fe to b33e0b36a08c (6 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: jmadill@google.com
Change-Id: Id26dbefab6a7f2840d4e644edac3a93ca35c613e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412446Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#807468}

Avatars displayed in webUI should have their size multiplied by the
device scale factor. Otherwise, the avatars look blurry when Chrome is
running with device scale factor > 1.

Fixed: 1128102
Change-Id: I9a3f5e38b5bf9e8c14889bbef619f2a6eae565b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413948
Commit-Queue: Alex Ilin <alexilin@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807467}

This reverts commit 8bb77f95.

Reason for revert: not a proper fix per mark's comments

Original change's description:
> base: extend ImmediateCrashTest.ExpectedOpcodeSequence for mac arm64
> 
> This test needs a case for what clang does on Mac Arm64, so add that.
> 
> Bug: 1128436,1121871
> Change-Id: I5d57f99f7d041bc91d9fc862c1d10ddc1b48f540
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412552
> Commit-Queue: Nico Weber <thakis@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#807243}

TBR=ellyjones@chromium.org,thakis@chromium.org

Change-Id: I32e706cd2544cd91974a39dc37f54438fe6822c2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1128436
Bug: 1121871
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413562Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807466}

Add tests for the different testable scenarios where the dev UI is
launched from a WebView package that is different from the current
system provider.

Fixed: 1128628
Test: run_webview_instrumentation_test_apk -f "*android_webview.devui*"
Change-Id: I5c59d2351fbb1ec10fb11919fada1a953c39070a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411984
Commit-Queue: Hazem Ashmawy <hazems@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807465}

This reverts commit f4886cba.

Reason for revert: This causes unintended throttling of TouchMoves if
the page is at the overflow already. Fix will land in next release.
See crbug/1123304 for details.


Original change's description:
> Ensure that TouchEvents are always async after scrolling has started.
>
> Currently we can flip flop back and forth between TouchMoves being sent
> async or sync which can cause some pretty noticeable cases of jank. This
> ensures that we are always consistently scrolling after deciding
> TouchMoves can be async.
>
> Bug: 1072364
> Change-Id: I3ef1ed6715d4b1fd2d3e1377ebd6b0c8bcc02872
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2182426
> Commit-Queue: Stephen Nusko <nuskos@chromium.org>
> Auto-Submit: Stephen Nusko <nuskos@chromium.org>
> Reviewed-by: David Bokan <bokan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#776487}

TBR=bokan@chromium.org,nuskos@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1072364,1123304
Change-Id: I7645aa130ddaf5214bde77a8cbcdd239e48f729c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413491
Auto-Submit: Stephen Nusko <nuskos@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Stephen Nusko <nuskos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807464}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/b09e7729..49c0daeb

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I10372035655d28c09fa64019c60725d1670adc0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414012Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#807463}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: I3d05a5636400c1b1333ee8384403f80f1bbe4c5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414149Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#807462}

This reverts commit 05a62e89.

Reason for revert: causes regression (crbug.com/1128292)

Original change's description:
> [ios] UI Polish Omnibox - Badges in the Location bar.
> 
> Current behaviour:
> The animation to enter fullscreen makes the Incognito badge next to the
> security icon appear as if it comes from the left. The animation to enter
> fullscreen makes icons on the far right (Share icon/ Mic icon) and left
> (Message badge/ Incognito badge) move towards the center before fading out
> completely.
> 
> Intended behaviour:
> There should be no x translation, when the Incognito badge appears, but
> instead it should start animating from a scale of 0, while maintaining
> the current fade behaviour. The icon should not move towards the centre,
> but instead combine the current fadeout with a scale translation
> towards 0.
> 
> Bug: none.
> Change-Id: Ie4b4c6844aa0618366d16bacb5b29adc26e8e03e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336837
> Commit-Queue: Nazerke Kalidolda <nazerke@google.com>
> Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#797237}

TBR=stkhapugin@chromium.org,nazerke@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I54e05a062d4c5c7677145c24bd8581966b3ccf26
Fixed: 1128292.
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414229Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Nazerke Kalidolda <nazerke@google.com>
Cr-Commit-Position: refs/heads/master@{#807461}

The original argument is needed by WebRTC.

Bug: angleproject:3162
Bug: 931731
Change-Id: I98c8dbb054ce5cd3c989c8fdd55195e4cf4a7c69
Cq-Do-Not-Cancel-Tryjobs: true
Tbr: dpranke@google.com
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412371Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807460}

Replace future_on with supported_on since the feature is ready.

Bug: 663982
Change-Id: Iacf856f105eb9e95baa0df3387db595b0627ce6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410043
Commit-Queue: Renato Silva <rrsilva@google.com>
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Auto-Submit: Renato Silva <rrsilva@google.com>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807459}

https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git/+log/8ca19625de30..d5148db386ce

$ git log 8ca19625d..d5148db38 --date=short --no-merges --format='%ad %ae %s'
2020-09-09 jdapena GCC: fix NEON type casts
2020-07-02 jonathan.wright Implement accurate DCT using Arm NEON intrinsics
2020-09-11 hidehiko Expand is_linux to is_linux || is_chromeos.

Created with:
  roll-dep src/third_party/libjpeg_turbo

Bug: 922430
Change-Id: Ibae73477f7aa156f4722a5eea3bf4554d71ad844
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412734Reviewed-by: Leon Scroggins <scroggo@google.com>
Commit-Queue: Jonathan Wright <jonathan.wright@arm.com>
Cr-Commit-Position: refs/heads/master@{#807458}

This is a reland of 1cb4c9a7

Rebaselined a few tests for mac 10.14 and 10.15.

Original change's description:
> New TextBreakIterator's default behavior breaks after space run
>
> Before this change, we were considering breaking opportunities before
> space runs. This approach allowed us to avoid re-shaping in many cases,
> which has an important advantage in terms of performance.
>
> However, the Unicode spec (UAX#14) state that breaking before a space
> character is not allowed [1], so we had to implement this logic after
> our TextBreakIterator had already determined the best breaking
> opportunity. This approach has been working fine so far for regular
> spaces (white-space, tabs, ...), but it doesn't work correctly for
> other BA [2] class characters; in the CSS Text specification, these are
> known as "other space separators" [3].
>
> In order to implement the correct behavior for any kind of space, we
> would need to change our TextBreakIterator implementation so that
> matches the Unicode rules, considering breaking opportunity after
> space runs. This change should also consider the performance impact
> of the extra re-shaping operations required to deal with trailing
> spaces.
>
> In order to prevent performance regressions, we'll store the position
> of the 'end of non-hangable run', which will be used in case of items
> with styles dictating rules to collapse trailing spaces.
>
> [1] https://unicode-org.atlassian.net/browse/ICU-20843
> [2] https://www.unicode.org/reports/tr14/tr14-39.html#BA
> [3] https://drafts.csswg.org/css-text-3/#other-space-separators
>
> Change-Id: Ie4a3890c75a3faff1a0155d4a40bcaa85bc6ac06
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047943
> Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
> Reviewed-by: Koji Ishii <kojii@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#806928}

Change-Id: I9b5204f0b2e49367ab7d7a2107900763844fd2bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412307
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807457}

GNU libstdc++ std::vector explicitely forbids creating an std::vector of
const types. Though, recent changes in FidoDeviceAuthenticator added
two usages of them.

This fixes it just removing the const for the contained type.

Bug: 957519
Change-Id: I55dde64617704707d0a4edb36fc676a2ee5409ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412137
Commit-Queue: José Dapena Paz <jose.dapena@lge.com>
Reviewed-by: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807456}

The updated specs require a 80dp scroll shadow to give a stronger hint
that the bar is scrollable.

Screenshots before/after are linked in the bug.

Bug: 1124722
Change-Id: I94dffc2b9375816997cae6c8492c21094a487f18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410134Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807455}

For example for AcceptOnProxyThread and AcceptSyncMessage both would
show up in a trace as a single slice just saying it was posted from
Accept() in the ipc_mojo_bootstrap.cc file. However you couldn't tell if
it was Sync or OnProxy and what mojom interface was being run. These
trace events illuminate these facts.

Fix some minor formatting issues in simple watcher since I noticed it
and this CL isn't large

Bug: internal b/162939995
Change-Id: I2925e6c11dfc3bb2bb8e67bf6aa1ff2bf4037890
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377926Reviewed-by: Stephen Nusko <nuskos@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Commit-Queue: Stephen Nusko <nuskos@chromium.org>
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Auto-Submit: Stephen Nusko <nuskos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807454}

AndroidSyncSettings exposes a few test methods that take a callback as a
parameter, so it is possible to wait for an account update operation to
finish. Before this CL, the callback was passed a boolean representing
whether syncability was changed.

This boolean return value was being used by a single test and can be
queried in other ways, so this CL converts the callback into a closure.
Apart from this, the CL also:
- Adds inline initialization for some members in the test fixture.
- Simplifies the waiting mechanism so that individual tests don't have
to refer to CallbackHelper directly.
- Replaces android.os.StrictMode with org.chromium.base.StrictModeContext
in AndroidSyncSettings, which uses a simpler try-with syntax and is
already used by some parts of the class.

Bug: None
Change-Id: Ie7909eba57e171569fc565a02f2ed8afc487e285
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410390Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Victor Vianna <victorvianna@google.com>
Cr-Commit-Position: refs/heads/master@{#807453}

In the method to assign a CrossThreadWeakPersistent<U> to a CrossThreadPersistent<T>,
there is a call to the parent class implementation of Get. It uses Parent, that is,
in CrossThreadPersistent<T> an alias to its parent. GCC resolves it as that, but
that's wrong, and it should resolve to the parent of CrossThreadWeakPersistent<U>.

To avoid the problem, we define in that method ParentU resolving to the right
parent, and use a static cast to it.

Bug: 819294
Change-Id: I0152dac92d4a28eb1f1abbc56473204b62f33797
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412138Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: José Dapena Paz <jdapena@igalia.com>
Cr-Commit-Position: refs/heads/master@{#807452}

third_party/gvr-android-sdk:controller_test_api_java has errprone
annotations that conflict with the doubledown rolled version of material
design. Exclude from jar.

Bug: 1110346
Change-Id: I7580aed9bc4aff65893f7cf7e65c5e925c70f555
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412638
Auto-Submit: Mohamed Heikal <mheikal@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807451}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/588efd970283..b87e7b7d3b0b

2020-09-16 changhaohan@chromium.org TypeScriptify elements/MetricsSidebarPane.js
2020-09-16 yangguo@chromium.org Fix corner case in sortAndMergeRanges

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1011811,chromium:1093296
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I802f39fca7eb6aacf9e4590d2ffcf1b9631c9b17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412445Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#807450}

Purpose:
In order to compute merchantSupportsBasicCard(), the business logic
, in //components, I am moving it from AutofillPaymentAppFactory into
BasicCardUtils, and move BasicCardUtils into //components.

Bug: 1106563

Change-Id: Ie245648b585dea807c28bb0029388286cc1398b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407238
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Sahel Sharify <sahel@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807449}

Bug: 1029320
Change-Id: Ia58e3c4c381fe34922888fb5d7cbb4282ccafda3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412293
Commit-Queue: Benoit L <lizeb@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807448}

Roll Chrome Linux PGO profile from chrome-linux-master-1600192792-36de61e8f764b4ecaec9d88047348ce6694afdaf.profdata to chrome-linux-master-1600257341-cdcb93ba007df24b60057506da5b299c67d8a739.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com
Change-Id: Ib8eaaa1c0585cf998c4f600ede382a3891bb800a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414151Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#807447}

https://android.googlesource.com/platform/external/perfetto.git/+log/5e931ebb24fb..38f0f40310d6

2020-09-16 treehugger-gerrit@google.com Merge "Fix broken default query."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I943df1513159462ec6c1f62ea980cc234e563e26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412442Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#807446}

https://webrtc.googlesource.com/src.git/+log/b10d4a612b87..08574aeb4454

2020-09-16 mbonadei@webrtc.org Revert "Reland "Switch from "rtc_ios_xctest_test" to "rtc_test".""
2020-09-16 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision dfb9023b..1519d2c4 (807259:807375)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I20d45f2c79abf690bb4caee7eac4749af1abe764
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412440Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#807445}

Before this patch:
PasswordReuseDetectorConsumer has only one method OnReuseFound()
which is invoked when there a reuse is found. When no password reuse is
found, the consumer isn't informed.

After this patch:
PasswordReuseDetectorConsumer now has a method OnReuseCheckDone() that
gets invoked whether a password reuse is found or not. A new parameter
is added |is_reuse_found| to indicate whether a password reuse is found
or not.

This change is necessary to support password reuse check for both the
profile and account store since it gives the consumer a clue when both\
stores have responded and it's possible to start processing the data.

Bug: 1119286
Change-Id: Iab6fcc01a7dc27e3c8a478c7e5d6e62805c0c76a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410248
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807444}