- 26 Jul, 2019 40 commits
-
-
Honglin Yu authored
Prior to crrev.com/c/1710251, the metrics of each type of system resource usage (RAM, cpu time etc.) of ml-service are aggregated over all the models. So one cannot see the resource usage of a particular model. In this CL, we make such histograms model-specific. For example, assume there are two models with |metric_base_name| "SmartDim" and "TestModel", respectively. In logging the cpu usage of "model loading", the previous code will only generate one histogram on UMA: MachineLearningService.LoadModelResult.CpuTimeMicrosec which contains metrics of both "SmartDimModel" and "TestModel". Now there will be two histograms, MachineLearningService.SmartDimModel.LoadModelResult.CpuTimeMicrosec MachineLearningService.TestModel.LoadModelResult.CpuTimeMicrosec which record the metrics for each model separately. Currently, two groups of histograms are added, for model "SmartDimModel" and "TestModel" respectively. BUG=chromium:924709 Test: ran validate_format.py and pretty_print.py Change-Id: I77e53d6ea6302c15b20778782a0068e91c96b6ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714405Reviewed-by:Ilya Sherman <isherman@chromium.org> Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Commit-Queue: Honglin Yu <honglinyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#681166}
-
Giovanni Ortuño Urquidi authored
Mojo JS Lite Bindings were recently renamed to align with the new C++ names. This CL changes usage of the old names with the new ones. See bug for more details. Also adds the closure_compile target to webui_closure_compile. Otherwise there is no type checking. Bug: 968369 Change-Id: Ie1e050a754a86ab7134ddacf8ebe482636221af5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717407 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#681165}
-
Yao Xiao authored
Parameterize the worker network isolation key tests with the feature kAppendFrameOriginToNetworkIsolationKey Bug: 955476 Change-Id: Id9f9b5bd76157892ed33231c5900e874ba9459cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715757Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/master@{#681164}
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: Iaf9b2a80a458188c3b95801aa3843e481fc12b92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700919Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#681163}
-
Maggie Cai authored
Currently the intent picker bubble is aligned to the intent picker icon, this CL aligns the intent picker bubble to the Omnibox. BUG=986145 Change-Id: I4940e000b7d9738b4fb886b79efe2edc7b1a18ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715349 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#681162}
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: I13984a7fcec68dda11f2664a92bc0ef58d30e455 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700936Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Commit-Queue: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#681161}
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: Idc2bf0d7371a9febba1471732f47d94e7df3303a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700826Reviewed-by:
-
Ian Vollick authored
Adds a minimal test file suitable for demonstrating spatial navigation behavior. Bug: 956209 Change-Id: I908d5c2f6c7c8e38c075ff5ee87dce3214ca2dbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719769 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#681159}
-
Ahmed Fakhry authored
ui::RecreateLayers() works only with LayerOwners. This means that Shadow which creates its own layers won't be recreated and the old layers won't be returned in the old layer tree returned by ui::RecreateLayers(). This fixes the shadow disappearing for the window-move-to-desk animation. BUG=977434 TEST=Manually, shadow should show while animating, no change in behavior. Change-Id: Iabd12036821a35b56804b5ac774714598fb39e95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711046 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
-
Stephen Chenney authored
Disable input for some browser and content Android tests. Disable input until we present something to the user When a document loads, there is a significant period between when the frame is created and when the user sees content. During this time, the document is not processing lifecycle updates but Javascript is scheduled and the RenderWidget exists to handle input. A major concern is that users might click on some place where there is something reactive laid-out and available for hit testing and processing (an ad, a link, start a video) before they have actually seen anything to click on. Think of something like a last ditch attempt to click on something on the page you're navigating away from only to hit something on the page you're navigating to. It seems safer to avoid this rather than have unexpected and potentially very nasty behavior. In theory this situation was possible before with deferred lifecycle updates though it apparently never warranted concern. But we're preparing to enable the flag that defers the first compositor commit until we have some content ready to raster (or a timeout), in which case document lifecycles are running and there is content there to hit-test against and send events to, but the user hasn't seen it yet (for half a second at most, right now). This patch adds a flag to suppress all input from the time when RenderWidget navigates to a frame to the time we are notified of the first compositor commit and paint, which is the best estimate we have for the user seeing something. This patch may affect the FirstInputDelay (FID) web platform metric. FID may improve because dropped input won't be measured at all, and the delay for the first event we actually process will be smaller because it will come when the system is less stressed. i.e. after initial layout and paint. Regardless, the impact on FID will be monitored when this patch lands. Tests disable this feature, with an open bug crbug.com/987626 to fix the tests and enable the feature. Bug: 958424 Change-Id: I9d288b6861f88e7101d9957d1a21b6bebb38bca8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590415 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#681157}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: I14e62dde98538aaed89091cba8be8f246de19ad8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720111Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#681156}
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: Ib0a8e987ee5259872c1ff8d64eff577ef758d863 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700868 Commit-Queue: Eric Foo <efoo@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#681155}
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: I86538c3364443afcda7ac0090461ef56557dabe7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699959 Commit-Queue: Eric Foo <efoo@chromium.org> Reviewed-by:
Eric Foo <efoo@chromium.org> Reviewed-by:
Anand Mistry <amistry@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Auto-Submit: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#681154}
-
Varun Khaneja authored
This should have been added with the code but was mistkenly not. R=holte Bug: 965587 Change-Id: I0ce554f6570aa9d0548b9d3c6215a7c98e79a043 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717481 Auto-Submit: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#681153}
-
Gabriel Charette authored
WaitableEventPerfTest.Throughput was incorrect; it relied on a const samples() but was looping through as many iterations as possible for 1 second... so the report was garbage. The test was disabled because the vector went over the allocated capacity (faster machines now mean this test can do in the order of 1'000'000 operations in 1 second). Allocating a vector of a million entries just to accumulate later is overkill. Switched to accumulating as we go. An upcoming change of mine will improve perf further I think; cleaning up and re-enabling these tests before helps show the delta. Renamed the tests to have them prefixed by "WaitableEvent" so they're easier to find on the perf dashboard (continuity is not an issue). R=kylechar@chromium.org Bug: 848499, 905412 Change-Id: I021886b472bfbb698af615038e393a92e654a122 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718598 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#681152}
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: Ic1551309a2c143a6298cd7a6a663616aa0bff434 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700727Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Eric Foo <efoo@chromium.org> Auto-Submit: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#681151}
-
Ian Vollick authored
Two tests needed to be updated after crrev.com/c/1716952 TBR=mahmoudi,dewittj Bug: 983734 Change-Id: I6bf9233601875f2f1dc973560eed6417a1ecb907 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720109Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#681150}
-
rajendrant authored
When Lite mode is turned off, lazyload and site-breakdown should not report byte savings. Also, the milestone bytes saved IPH should not show up when Lite mode is off. Bug: 987114 Change-Id: I4ee07774666524c7dd0cfff7e0442aecf37dae52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716111 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#681149}
-
Jyun-jhe Chou authored
There are some devices will have video encoder on it, and we will need to test these video encoder. We have check the building flags of some devices and find proper flags for adding video encode accelerator unittest to the build list. Run the default tests on the device. Bug: b/129457839 Test: Rebuild the image and check if the binary exists. Change-Id: I5133b65573edc7a8137244c163d0baefd5632201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712442Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Jyun-jhe Chou <hobexd@google.com> Cr-Commit-Position: refs/heads/master@{#681148}
-
Nicolás Peña Moreno authored
Currently startTime is 0, which is a problem because getEntries() methods all sort by startTime. To help with this problem, we set the startTime to renderTime, if available, or to loadTime, if renderTime is nt available. Bug: 965505 Change-Id: Ie70b69269f7ce4be0fdc94f33a44a84e062d3ba5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719379Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#681147}
-
Chris Harrelson authored
This presumably avoids defeating a RVO optimization in the compiler, and recovers nearly all of the performance lost in the referenced bug in local testing on Linux. Bug: 984965 Change-Id: I99567cc96391d410e71aba2fe4c2d29d5324fd11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717923 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#681146}
-
Chih-Yu Huang authored
Tegra driver calculates the wrong plane size of NV12. This CL disable all tests on nyan family for NV12 test. BUG=chromium:965348 TEST=`tast run $(DUT) video.EncodeAccelH264NV12` on nyan_big Change-Id: I4e79a5380501d866ffc4192dcfc35423f26f1bbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715516 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#681145}
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: I7c7f730f2cf326fa4e3cc40f9c7fe30698eaf4fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700831 Commit-Queue: Eric Foo <efoo@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#681144}
-
Mohamed Heikal authored
Resource name stripping was enabled in both debug and release when it was new so that issues are more likely to be found early. Now that the optimization has been on for some time without issue, it makes sense to disable it in debug mode so as to not annoy developers that are looking into resource related issues. Change-Id: I68ac00396dc8e2b5d37d276c22c58a1d020e1392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719451 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Auto-Submit: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#681143}
-
John Rummell authored
Bug: 987067 Test: EME content_browsertests pass Change-Id: Ia1573232a0c43b347e26ea4707406b92c652a82d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719452Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#681142}
-
Johannes Henkel authored
Please make sure I didn't simplify it too much. :-) Also, please let me know what comment to put (if any) for the second return. Thanks. Change-Id: Iffa201442e99c1df4896fe4c168845df2bcb9bc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718781 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#681141}
-
Nico Weber authored
Depends on https://chromium-review.googlesource.com/c/chromium/src/+/1715975; once that's in nothing uses CHROMIUM_BUILD any more. If you want to use CHROMIUM_BUILD: Instead, include build/branding_buildflags.h, make targets that include it depend on build:branding_buildflags, and use BUILDFLAG(CHROMIUM_BRANDING). I looked through all internal code bases I know of and didn't find any references to this symbol. Bug: 961769 Change-Id: I63724f2c32c82134fe7b65d98d4f80a8494875f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718449 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#681140}
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: Iafa471c00dd945dd5df30a4824ff9a2745368782 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700866 Commit-Queue: Eric Foo <efoo@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Auto-Submit: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#681139}
-
chrome://favicon2Victor Hugo Vianna Silva authored
Instead of making the distinction between page url and icon url with parameter url_type, we now have 2 optional parameters page_url and icon_url. In case both are specified, page_url takes precedence. Bug: 973192 Change-Id: I2daca543515b71998263908a48d113a37ced8eb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704258 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#681138}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/bf99f644ae32..3a6f61256488 git log bf99f644ae32..3a6f61256488 --date=short --no-merges --format='%ad %ae %s' 2019-07-25 eashanbhatt@google.com cros_chrome_sdk: Add --fallback-versions Created with: gclient setdep -r src/third_party/chromite@3a6f61256488 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ia4550915f2e142b107cc5eba8c2be89668a0e6ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719949Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#681137}
-
John Rummell authored
UMA stats are showing that the number of successful navigator.requestMediaKeySystemAccess() calls are lower on canary than before this change was landed. It's possible that the checks for secure playback are not working properly on some devices, so reverting part of the change that added them to verify. Bug: 707127,727918,846120 Test: EncryptedMedia content_browsertests pass Change-Id: I9d1be799121859181c996e5ea47234fae6c6fcf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719729 Commit-Queue: John Rummell <jrummell@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#681136}
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: I1c67a5c7e6af723022c1d631d90b405feb090a65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700927Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#681135}
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: I86a25d42415090528ba4a21821375d7a4d745e54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700838 Commit-Queue: Eric Foo <efoo@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Chirantan Ekbote <chirantan@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Auto-Submit: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#681134}
-
David Bertoni authored
This CL adds support for Service Worker-based extensions to the ExtensionBuilder class. It also renames the SetBackgroundPage() member function to SetBackgroundContext(). Bug: 853378 Change-Id: I30018b46aafefdfb8e6e450101b86f489669cc36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719376 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#681133}
-
Sajjad Mirza authored
Change-Id: If50d3479146a47dca502ddcf84b9eacdcd7ff710 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719650Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Sajjad Mirza <sajjadm@chromium.org> Cr-Commit-Position: refs/heads/master@{#681132}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c5817614666e..1c7dba2cadad git log c5817614666e..1c7dba2cadad --date=short --no-merges --format='%ad %ae %s' 2019-07-25 rmhasan@google.com [ Typ ] Make conflicts disallowed policy apply to test expectations with globs Created with: gclient setdep -r src/third_party/catapult@1c7dba2cadad The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=oysteine@google.com Bug: chromium:973936 Change-Id: I672efdb121067c508af41e693adf4cd2524194ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719580Reviewed-by:
-
Nigel Tao authored
"TODO... implement" has stayed unimplemented since 2014 (commit 630a27a6, https://codereview.chromium.org/118463002) Change-Id: I944d5d8c1e226f221e5c3c4f4a85d8f421a291e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716398 Commit-Queue: Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#681130}
-
Hwanseung Lee authored
Use enum class instead of enum for DesktopDragDropClientAuraX11::SourceState enum class is more type safety. Bug: 940736 Change-Id: Ib5365bbfda80b10301f6b6b6d25975e44b7e745a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713546Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6129e06e7f87..180f6291f9c9 Created with: gclient setdep -r src-internal@180f6291f9c9 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I7d845e06838cf5f154f5e6d8f36621943d4ddf58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719709Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#681128}
-
Vladimir Levin authored
The beforeactivate signal could have caused us to be unlocked (probably kCommitting, which is considered an unlocked state). In that case, we shouldn't DCHECK or start commits, we should just early out since the commit is already in progress. R=chrishtr@chromium.org, rakina@chromium.org Bug: 987730 Change-Id: I5fec0b992dc0673ff661e600604af307c9e8ca42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719330Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#681127}
-
