GitLab

Expanding or collapsing a section takes 350ms, but fading the new content
in and the old content out takes 500ms. This is a contributing factor to
the overlap seen when closing a section, as the old section is still
visible when the collapse animation has completed.

Shortening the fade duration to match the expand/collapse animation makes
that overlap much less likely to occur. It also makes the animations
appear snappier, IMO -- if the page is still fading after expanding, it
looks slugging.

This re-implements the fade animations, rather than programmatically
changing the neon-animated-pages' transition durations for the
existing fade-in-animation/fade-out-animation. The latter is not possible
due to https://github.com/PolymerElements/neon-animation/issues/209.

R=dbeam@chromium.org
BUG=716680
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2856223007
Cr-Commit-Position: refs/heads/master@{#469582}

Cr-Commit-Position: refs/heads/master@{#469581}

Added generated class level comments to all CSSPropertyAPIs with a
definition of the class and status.

BUG=668012

Review-Url: https://codereview.chromium.org/2864583002
Cr-Commit-Position: refs/heads/master@{#469580}

Today on reinitialization error, or decode error of the first buffer,
DecoderStream will fall back to decoders left in the DecoderSelector.
Since we will have less and less decoders in the DecoderSelector, the
ability to switch decoders is limited.

This CL updates DecoderSelector so that it takes a callback to create
a list of decoders, instead of taking the list of decoders directly.
This allows the DecoderSelector to select a decoder that has been
tried or selected before, such that upon decoder reinitialization error
(e.g. switching from clear to encrypted config), or upon decode error of
the first buffer, we always have the full list of decoders to select
from.

Two mechanisms are added to avoid trying the same failing decoder again:

1. Blacklist

When SelectDecoder() is called due to reinitialization failure, or
decoding failure of the first buffer, the existing decoder is listed as
the "blacklisted decoder" such that DecoderSelector will not even try
it.

There is one exception though. When DecryptingDemuxerStream is selected,
since the input steam is changed (encrypted -> clear), the blacklisted
decoder is ignored. For example, FFmpegVideoDecoder is slected first for
a clear stream. Then on a config change, the stream becomes encrypted so
FFmpegVideoDecoder fails to reinitialize and we need to select a new
decoder. After DecryptingDemuxerStream is selected, we should still be
able to use FFmpegVideoDecoder to decode the decrypted stream.

2. Fall back at most once

If fallback has already happened and decode of the first buffer failed
again, we don't try to fallback again. This is to avoid the infinite
loop of "select decoder 1 -> decode error -> select decoder 2 -> decode
error -> select decoder 1".

BUG=695595
TEST=Updated/Added unittests.

Review-Url: https://codereview.chromium.org/2837613004
Cr-Commit-Position: refs/heads/master@{#469579}

The UI thread is generally overbooked (esp at app startup time) so
avoiding it can greatly improve Cronet startup time.  The UI thread
was used for initialization previously because it simplified the
NetworkChangeNotifierAutoDetect and ProxyChangeListener logic because
BroadcastReceiver onReceived callbacks always happen on the UI thread
so those classes could be completely single-threaded.  This change
leaves those classes single-threaded except for their onRecieved()
methods which now immediately post to the new initialization thread
and check whether their BroadcastReceivers are currently registered.

BUG=709336
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2812963002
Cr-Commit-Position: refs/heads/master@{#469578}

Will use mb for gn args of chromium_codesearch.py. Add gn configs in
mb_config.pyl
(https://chromium.googlesource.com/chromium/tools/build/+/master/scripts/slave/recipes/chromium_codesearch.py#49)

BUG=718658

Review-Url: https://codereview.chromium.org/2865593002
Cr-Commit-Position: refs/heads/master@{#469577}

Currently, WebAPKs and legacy PWA shortcuts added from app banners are
both recorded using the ShortcutSource::SOURCE_APP_BANNER bucket. This
means it is impossible to determine what shortcut launches from banners
are triggered for legacy PWAs compared to WebAPKs.

This CL adds a new ShortcutSource enum bucket for WebAPKs added to the
homescreen via an app banner. This means that WebAPKs installed from
banners have an explicitly different source, allowing them to be
differentiated in metrics.

The legacy SOURCE_APP_BANNER bucket is still used for non-WebAPK PWA
shortcuts, and will be reported for launches of legacy PWAs added prior
to M59.

BUG=691739

Review-Url: https://codereview.chromium.org/2808263004
Cr-Commit-Position: refs/heads/master@{#469576}

This CL changes all of the test cases to use the abstract WebViewBase class in
place of WebViewImpl. This should be the final CL to decouple the use of
WebViewImpl in web/ and move everything over to WebViewBase.

As before, there were a number of methods defined in WebViewImpl that needed to
be made virtual in WebViewBase and then overridden in WebViewImpl.

Also, it was not possible to use CORE_EXPORT or MODULES_EXPORT to export the
statically defined symbols from WebViewBase, so I used PLATFORM_EXPORT instead.

A number of symbols were being transitively included, so in places needed to
add include files to bring the symbols into scope.

BUG=712963

Review-Url: https://codereview.chromium.org/2860673002
Cr-Commit-Position: refs/heads/master@{#469575}

This was deprecated since M58 (having been replaced by
chrome://net-export/)

If users still have bookmarks to #export, they will now get a dialog
prompt asking them if they want to be redirected to
chrome://net-export/

BUG=678386
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2856223006
Cr-Commit-Position: refs/heads/master@{#469574}

1, Fix hard code always translate value and show correct "always translate" state in the same session.
2, Refresh langauge list every time, in case use changed source/target language.
3, Fix menu button desc under talkback mode.

Tested on my local N5.

BUG=703887

Review-Url: https://codereview.chromium.org/2858013003
Cr-Commit-Position: refs/heads/master@{#469573}

Mediated three methods through WebDevToolsAgentImpl, which encapsulates
overlay logic inside. This will avoid changes outside of WebDevToolsAgentImpl
in case of multiclient.

BUG=590878

Review-Url: https://codereview.chromium.org/2859273002
Cr-Commit-Position: refs/heads/master@{#469572}

There are two redundant lines in this file, and this CL removes them. This CL
has no behavior change, only clean up code.

BUG=None

Review-Url: https://codereview.chromium.org/2863633002
Cr-Commit-Position: refs/heads/master@{#469571}

In preparation for upcoming MSE PTS/DTS compliance fixes, this change
fixes some code style and unclear comments in SourceBufferRange's
header.

BUG=398130

Review-Url: https://codereview.chromium.org/2857983005
Cr-Commit-Position: refs/heads/master@{#469570}

Replaced animation list parsing method ConsumeAnimationPropertyList
with a new more general list parsing method ConsumeCommaSeparatedList.
This removes the need to pass property information to the list parsing
method, instead passing a callback function to be called on each of the
items in the list.

This is pre work to implementing the parseSingleValue method in the
property APIs for the animation properties that expect a list, as the
APIs do not take property as an argument.

The new ConsumeCommaSeparatedList method can be used in other parts of
the code base, which may be done in future patches.

This patch
- Added ConsumeCommaSeparatedList templated function to
  CSSPropertyParserHelpers
- Made each animation list property in parseSingleValue use the new
  ConsumeCommaSeparatedList method instead of
  ConsumeAnimationPropertyList
- Deleted ConsumeAnimationPropertyList method

BUG=668012

Review-Url: https://codereview.chromium.org/2849363002
Cr-Commit-Position: refs/heads/master@{#469569}

Also made "Inspect Element" open DevTools for main page now.

BUG=652783

Review-Url: https://codereview.chromium.org/2859063002
Cr-Commit-Position: refs/heads/master@{#469568}

I stumbled on isValidForIntentFallbackNavigation and found that having this
more verbose tests would make it easier for me to understand what I can expect
from this method, without having to trace down its implementation.

Not feeling strongly, but I think these are worth adding.

BUG=

Review-Url: https://codereview.chromium.org/2855293002
Cr-Commit-Position: refs/heads/master@{#469567}

This patch generates the following fields as part of a group:
- background ('storage_only' of type FillLayer)
- background_color ('storage_only' of type Color)

Since both fields correspond to shorthands, we specify them in
ComputedStyleExtraFields.json5.

All deleted code are correspondingly generated in
ComputedStyleBase, apart from the line

  background_data_(o.background_data_)

which is implicit in the compiler generated ComputedStyleBase
copy constructor.

Diff of generated files:
https://gist.github.com/darrnshn/c2d2e7f7429b6281987c8f1ff6e2c313/revisions

BUG=628043

Review-Url: https://codereview.chromium.org/2861623002
Cr-Commit-Position: refs/heads/master@{#469566}

The Trusty sysroot was only used for building Chromium for ARM.  Since
this is now the responsibility of the Jessie sysroot, the Trusty
sysroot can be removed.

R=thestig@chromium.org,sbc@chromium.org

Review-Url: https://codereview.chromium.org/2859323002
Cr-Commit-Position: refs/heads/master@{#469565}

In most locations callers assumed the function returned !HTMLElement
already. Changed the one location (in advanced_settings.js line 177)
that did not assume this to not call the function, and changed
getChildElement to return !HTMLElement.

Also removed some asserts that are no longer necessary.

This CL reduces print preview closure compiler errors to 180.

BUG=717620
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2857983007
Cr-Commit-Position: refs/heads/master@{#469564}

The method is fundamentally flawed (it invalidates the TaskRunners for
anything that might have already be initialized), and also isn't
actually used other than in one particular test that doesn't seem to
need what it does anyway.

BUG=None

Review-Url: https://codereview.chromium.org/2863023002
Cr-Commit-Position: refs/heads/master@{#469563}

This avoids the condition from being repeatedly checked.

Also tweek other methods to avoid unnecessary checks. Add test.

BUG=717128

Review-Url: https://codereview.chromium.org/2858143003
Cr-Commit-Position: refs/heads/master@{#469562}

This CL adds UMA and Revocation reporting from site settings when a site
exception is added or removed. The goal is to match the behavior of the
old options.

BUG=718544

Review-Url: https://codereview.chromium.org/2861793005
Cr-Commit-Position: refs/heads/master@{#469561}

Remove unnecessary zoom argument from GetImage() as its value is always available through the LayoutObject argument. (rebased)

BUG=716203
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2847303002
Cr-Commit-Position: refs/heads/master@{#469560}

This will allow me to increase code reuse with a nice custom @Rule.

BUG=640116

Review-Url: https://codereview.chromium.org/2854943005
Cr-Commit-Position: refs/heads/master@{#469559}

Copy the shared-memory NV12 GpuMemoryBuffer into an NV12 D3D11 dynamic
texture, which can be used as the source for the video processing that
goes to the backbuffer.

This still needs --enable-gpu-memory-buffer-video-frames to be enabled.
In my testing it reduces power on a 1080p60 VP9 video from 4W to 3.1W.

BUG=716286
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2849963003
Cr-Commit-Position: refs/heads/master@{#469558}

This CL adds multiple trace events (TRACE_EVENTX) in various points in
the rendering to investigate the cause of glitches.

("webaudio", "AudioDestination::Start")
("webaudio", "AudioDestination::Stop")
("webaudio", "AudioDestination::RequestRenderOnWebThread", "frames_to_render", frames_to_render)
("webaudio", "AudioDestination::Render", "callback_buffer_size", number_of_frames)
("webaudio", "AudioDestinationHandler::Render")

BUG=718554

Review-Url: https://codereview.chromium.org/2858223003
Cr-Commit-Position: refs/heads/master@{#469557}

This CL rolls the sysroots after https://codereview.chromium.org/2863663003/

R=thestig@chromium.org

Review-Url: https://codereview.chromium.org/2866583002
Cr-Commit-Position: refs/heads/master@{#469556}

R=dpapad@chromium.org
BUG=696910
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2855123004
Cr-Commit-Position: refs/heads/master@{#469555}

Android did not update the docs when multiwindow was implemented. But
essentially Display.getSize/getMetrics no longer refer to the Display
size, but to the window size, in order to be backwards compatible.

Fix and simply DisplayAndroid. Remove the distinction between "size"
and "physical size" by removing the concept of "physical" size. Always
just get the most correct size available.

Went through all use cases getSize. They all either don't care, or
was already trying to get the most correct value.

Review-Url: https://codereview.chromium.org/2859313002
Cr-Commit-Position: refs/heads/master@{#469554}

If ReassociateLocalTab is called with a tab node that is already mapped to a
tab, it's possible to wind up with the synced session tracker holding two
tab objects referring to the same tab id. This can lead to memory corruption.

This CL makes the tracker defensive against that scenario, and adds some more
data verification in the unit tests

BUG=714524, 639009

Review-Url: https://codereview.chromium.org/2856913007
Cr-Commit-Position: refs/heads/master@{#469553}

The PNaCl compiler does not understand -Os.

BUG=660216
R=thakis@chromium.org

Review-Url: https://codereview.chromium.org/2865573002
Cr-Commit-Position: refs/heads/master@{#469552}

This is a (less ambitious) re-land of http://crrev.com/2852613002 which
was reverted due to content_browsertests crashes on ChromeOS. That CL is
a re-land of http://crrev.com/2779193002 which was reverted due to build
errors on Mac.

Instead of rolling Google Test to 1.8.0, this CL uses the last commit
before a breaking change was introduced. Details about the breakage are
in https://crbug.com/630705#c27 and https://crbug.com/630705#c28. It is
expected that rolling Google Test from there to the next usable version
will be much less disruptive.

GoogleTest (gtest) and GoogleMock (gmock) are now hosted into the same
googletest repository. In order to cope with this, the googletest
repository is now sourced at third_party/googletest.

The file/directory layout of Google Test is not yet considered stable.
To minimize disruption while Google Test stabilizes, Chromium code will
be insulated from third_party/googletest.

* testing/gtest/include/gtest/ and testing/gmock/include/gmock have
  been populated with headers that forward into the appropriate locations of
  third_party/googletest

* testing/BUILD.gn has been populated with the targets
  //testing/gtest(:gtest_main) and //testing/gmock(:gmock_main), which
  depend on the appropriate //third_party/googletest targets.

All Chromium code should keep depending on the targets and headers
in testing/{gtest,gmock} for now.

BUG=630705
TESTED=out/Default/content_browsertests --gtest_filter=MojoTest.Init
TESTED=ninja -C out/Default/ ced_unittests && ninja -C out/Default
TBR=rkc, dpranke

Review-Url: https://codereview.chromium.org/2856383002
Cr-Commit-Position: refs/heads/master@{#469551}

BUG=715859

Review-Url: https://codereview.chromium.org/2855943003
Cr-Commit-Position: refs/heads/master@{#469550}

This moves the views-related dependencies (including chrome/app/theme)
out of the top-level //apps static library.

Some DEPS includes were dropped entirely as they are no longer used in
//apps.

BUG=679971
R=benwells@chromium.org

Review-Url: https://codereview.chromium.org/2820563004
Cr-Commit-Position: refs/heads/master@{#469549}

Sanitizer coverage instrumentation increases linker memory consumption
significantly.

BUG=717552
R=thakis@chromium.org

Review-Url: https://codereview.chromium.org/2866443003
Cr-Commit-Position: refs/heads/master@{#469548}

https://skia.googlesource.com/skia.git/+log/783c43658d91..02ab8cc2909d

$ git log 783c43658..02ab8cc29 --date=short --no-merges --format='%ad %ae %s'
2017-05-04 mtklein Revert "Factor out common code from sweep and linear."
2017-05-04 amaury.leleyzour CRC32 no longer restricted to ARM64

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=scroggo@chromium.org

Change-Id: Ib7a60db4a9ca23c9543f61c3bb0b6b47e8d67f99
Reviewed-on: https://chromium-review.googlesource.com/497007Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#469547}

This class forwards user activity from ws to the
pre-servicification activity-handling mechanism, so it needs
to be used for --mus in addition to --mash. Check for
aura::Env::Mode::MUS to handle both modes.

BUG=717681
TEST=put --mus, --mash, and neither in /etc/chrome_dev.conf
     and check that user activity is reported in
     /var/log/power_manager/powerd.LATEST after hitting a
     key

Review-Url: https://codereview.chromium.org/2863623005
Cr-Commit-Position: refs/heads/master@{#469546}

Now that ForceReclaimResources is gone, frames with no render passes are
only submitted in unit tests. Also, since crrev.com/2835203002 we no
longer allow empty render pass lists to be sent over IPC. Fix the tests
and remove the checks for empty render pass lists in prod to simplify
code.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2855723002
Cr-Commit-Position: refs/heads/master@{#469545}

This allows us to remove the conditional dependency from //media/gpu to
//media/mojo/services, thus allowing future dependencies in the other
direction.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2857953006
Cr-Commit-Position: refs/heads/master@{#469544}

The cursor surface is parented to the primary root window, which may
change when using multiple displays. This CL fixes a crash caused by
removing the child from the primary root window when the parent is a
different root window or the child is orphaned.

BUG=714832
TEST=No crashes after changing primary display.

Review-Url: https://codereview.chromium.org/2862953002
Cr-Commit-Position: refs/heads/master@{#469543}