GitLab

Review URL: https://codereview.chromium.org/905883002

Cr-Commit-Position: refs/heads/master@{#315146}

Revert of NaCl: Update revision in DEPS, 2363d1a -> a3e1e94 (patchset #1 id:1 of https://codereview.chromium.org/905793003/)

Reason for revert:
Looks like it broke the build:

http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests/builds/42375/steps/compile/logs/stdio

FAILED: cd ../../remoting; python ../native_client/build/build_nexe.py --root .. --product-dir ../out/Release/xyz --config-name Release -t ../out/Release/gen/sdk/ --arch pnacl --build newlib_pexe --name ../out/Release/remoting_key_tester_newlib.pexe --objdir ../out/Release/obj/remoting/remoting_key_tester_pexe.gen/pnacl_newlib/remoting_key_tester_pexe "--include-dirs=../out/Release/gen/tc_pnacl_newlib/include .. .. \"../out/Release/gen\"" "--compile_flags=-O2 -g -Wall -fdiagnostics-show-option -Werror  -gline-tables-only -Wno-unused-function -Wno-char-subscripts -Wno-c++11-extensions -Wno-unnamed-type-template-args -Wno-extra-semi -Wno-unused-private-field -Wno-char-subscripts -Wno-unused-function " --gomadir /mnt/data/b/build/goma "--defines=\"__STDC_LIMIT_MACROS=1\" \"__STDC_FORMAT_MACROS=1\" \"_GNU_SOURCE=1\" \"_DEFAULT_SOURCE=1\" \"_BSD_SOURCE=1\" \"_POSIX_C_SOURCE=199506\" \"_XOPEN_SOURCE=600\" \"DYNAMIC_ANNOTATIONS_ENABLED=1\" \"DYNAMIC_ANNOTATIONS_PREFIX=NACL_\" \"NACL_BUILD_ARCH=x86\" \"BINARY_CORE=1\" \"BINARY_DESKTOP=2\" \"BINARY_HOST_ME2ME=3\" \"BINARY_NATIVE_MESSAGING_HOST=4\" \"BINARY_REMOTE_ASSISTANCE_HOST=5\" V8_DEPRECATION_WARNINGS \"_FILE_OFFSET_BITS=64\" CHROMIUM_BUILD \"CR_CLANG_REVISION=223108\" \"TOOLKIT_VIEWS=1\" UI_COMPOSITOR_IMAGE_TRANSPORT \"USE_AURA=1\" \"USE_ASH=1\" \"USE_PANGO=1\" \"USE_CAIRO=1\" \"USE_DEFAULT_RENDER_THEME=1\" \"USE_LIBJPEG_TURBO=1\" \"USE_X11=1\" \"USE_CLIPBOARD_AURAX11=1\" ENABLE_ONE_CLICK_SIGNIN ENABLE_PRE_SYNC_BACKUP \"ENABLE_REMOTING=1\" \"ENABLE_WEBRTC=1\" ENABLE_PEPPER_CDMS ENABLE_CONFIGURATION_POLICY ENABLE_NOTIFICATIONS USE_UDEV DONT_EMBED_BUILD_METADATA \"ENABLE_TASK_MANAGER=1\" \"ENABLE_EXTENSIONS=1\" \"ENABLE_PLUGINS=1\" \"ENABLE_SESSION_SERVICE=1\" \"ENABLE_THEMES=1\" \"ENABLE_AUTOFILL_DIALOG=1\" \"ENABLE_BACKGROUND=1\" \"ENABLE_GOOGLE_NOW=1\" \"CLD_VERSION=2\" \"ENABLE_PRINTING=1\" \"ENABLE_BASIC_PRINTING=1\" \"ENABLE_PRINT_PREVIEW=1\" \"ENABLE_SPELLCHECK=1\" \"ENABLE_CAPTIVE_PORTAL_DETECTION=1\" \"ENABLE_APP_LIST=1\" \"ENABLE_SETTINGS_APP=1\" \"ENABLE_SUPERVISED_USERS=1\" \"ENABLE_MDNS=1\" \"ENABLE_SERVICE_DISCOVERY=1\" V8_USE_EXTERNAL_STARTUP_DATA \"USE_LIBPCI=1\" \"USE_GLIB=1\" \"USE_NSS=1\" __STDC_CONSTANT_MACROS __STDC_FORMAT_MACROS" "--link_flags=-B../out/Release/gen/tc_pnacl_newlib/lib -O3 -lppapi_stub -lppapi_cpp" "--source-list=../out/gypfiles/remoting/pnacl_newlib.remoting_key_tester_pexe.source_list.gypcmd"
/mnt/data/b/build/slave/Linux_Tests/build/src/out/Release/gen/sdk/linux_x86/pnacl_newlib/bin/le32-nacl-ld.gold:error: cannot open ../out/Release/gen/tc_pnacl_newlib/lib/libnacl.a: No such file or directory
/mnt/data/b/build/slave/Linux_Tests/build/src/out/Release/gen/sdk/linux_x86/pnacl_newlib/le32-nacl/lib/libc.a:error: undefined reference to '_realloc_r'
/mnt/data/b/build/slave/Linux_Tests/build/src/out/Release/gen/sdk/linux_x86/pnacl_newlib/le32-nacl/lib/libc.a:error: undefined reference to 'read'
/mnt/data/b/build/slave/Linux_Tests/build/src/out/Release/gen/sdk/linux_x86/pnacl_newlib/le32-nacl/lib/libc.a:error: undefined reference to 'close'
/mnt/data/b/build/slave/Linux_Tests/build/src/out/Release/gen/sdk/linux_x86/pnacl_newlib/le32-nacl/lib/libc.a:error: undefined reference to 'lseek'
/mnt/data/b/build/slave/Linux_Tests/build/src/out/Release/gen/sdk/linux_x86/pnacl_newlib/le32-nacl/lib/libc.a:error: undefined reference to '_calloc_r'
/mnt/data/b/build/slave/Linux_Tests/build/src/out/Release/gen/sdk/linux_x86/pnacl_newlib/le32-nacl/lib/libc.a:error: undefined reference to 'isatty'
/mnt/data/b/build/slave/Linux_Tests/build/src/out/Release/gen/sdk/linux_x86/pnacl_newlib/le32-nacl/lib/libc.a:error: undefined reference to 'fstat'
/mnt/data/b/build/slave/Linux_Tests/build/src/out/Release/gen/sdk/linux_x86/pnacl_newlib/le32-nacl/lib/libc.a:error: undefined reference to '_free_r'
/mnt/data/b/build/slave/Linux_Tests/build/src/out/Release/gen/sdk/linux_x86/pnacl_newlib/le32-nacl/lib/libc.a:error: undefined reference to '_malloc_r'
../out/Release/gen/tc_pnacl_newlib/lib/libpthread.a:error: undefined reference to '__pthread_initialize_minimal'
../out/Release/gen/tc_pnacl_newlib/lib/libpthread.a:error: undefined reference to '__nacl_tls_initialize_memory'
../out/Release/gen/tc_pnacl_newlib/lib/libpthread.a:error: undefined reference to 'calloc'
../out/Release/gen/tc_pnacl_newlib/lib/libpthread.a:error: undefined reference to '__nacl_tls_combined_size'
../out/Release/gen/tc_pnacl_newlib/lib/libpthread.a:error: undefined reference to '__libnacl_mandatory_irt_query'
/mnt/data/b/build/slave/Linux_Tests/build/src/out/Release/gen/sdk/linux_x86/pnacl_newlib/le32-nacl/lib/libc++.a:error: undefined reference to 'malloc'
/mnt/data/b/build/slave/Linux_Tests/build/src/out/Release/gen/sdk/linux_x86/pnacl_newlib/le32-nacl/lib/libc++.a:error: undefined reference to 'free'
../out/Release/gen/tc_pnacl_newlib/lib/libppapi_stub.a:error: undefined reference to '_exit'
/mnt/data/b/build/slave/Linux_Tests/build/src/out/Release/gen/sdk/linux_x86/pnacl_newlib/lib/clang/3.5.0/lib/le32-nacl/unwind_stubs.bc:error: undefined reference to 'write'
/mnt/data/b/build/slave/Linux_Tests/build/src/out/Release/gen/sdk/linux_x86/pnacl_newlib/lib/clang/3.5.0/lib/le32-nacl/unwind_stubs.bc:error: undefined reference to 'abort'
FAILED with 1: ../out/Release/gen/sdk/linux_x86/pnacl_newlib/bin/pnacl-clang++ -o ../out/Release/remoting_key_tester_newlib.pexe.debug -Wl,--as-needed ../out/Release/obj/remoting/remoting_key_tester_pexe.gen/pnacl_newlib/remoting_key_tester_pexe/remoting_key_tester_61dcf3bc.o -B../out/Release/gen/tc_pnacl_newlib/lib -O3 -lppapi_stub -lppapi_cpp

Original issue's description:
> NaCl: Update revision in DEPS, 2363d1a -> a3e1e94
>
> This pulls in the following Native Client changes:
>
> 6c11549: (mseaborn@chromium.org) Add IRT interface for PNaCl's sandboxed linker to use to talk to Chromium
> 9fff96b: (teravest@chromium.org) NaCl: Remove use of NACL_BUILD_* in common.gypi.
> 76d6d4b: (mseaborn@chromium.org) PNaCl: Update Binutils revision in pnacl/COMPONENT_REVISIONS: use new IRT interface
> a3e1e94: (jfb@chromium.org) Delete Windows time code
>
> BUG=none
> TEST=browser_tests and nacl_integration
> CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_arm_compile,linux_nacl_sdk_build
>
> Committed: https://crrev.com/accbfa1e86e32df669fad209185cba4acd6847be
> Cr-Commit-Position: refs/heads/master@{#315133}

TBR=jfb@chromium.org,mseaborn@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=none

Review URL: https://codereview.chromium.org/905043002

Cr-Commit-Position: refs/heads/master@{#315145}

TBR=bauerb@chromium.org
BUG=456375

Review URL: https://codereview.chromium.org/893843009

Cr-Commit-Position: refs/heads/master@{#315144}

Roll third_party/cros_system_api to 286cec023e90f54f391fe32bae512f9ec7b4e807

BUG=407773
TBR=benchan@chromium.org

Review URL: https://codereview.chromium.org/909543003

Cr-Commit-Position: refs/heads/master@{#315143}

This broke quite a bit ago when the implicit ordering changed by refactoring.
It is unfortunate that we don't have test coverage for mac, and
trying to type accent characters (IME) from browsertest didn't work.

BUG=450641
Test=On mac, load a chrome app with <webview> that has an input box.
Try to type accent chars, e.g. Option+e followed by e. Proper chars
should be seen in the input box.

Review URL: https://codereview.chromium.org/904013002

Cr-Commit-Position: refs/heads/master@{#315142}

VideoFrame conversion is to RGBA, so we need to specify
BGRA when uploading the texture.

BUG=450205

Review URL: https://codereview.chromium.org/901683004

Cr-Commit-Position: refs/heads/master@{#315141}

Now that we have fastbuild and Goma working, it should be safe to
link the full binary again in a GN build on the bots.

TBR=brettw@chromium.org, jam@chromium.org
BUG=354261

Review URL: https://codereview.chromium.org/880373008

Cr-Commit-Position: refs/heads/master@{#315140}

This can be disabled with the allow-sandbox-debugging flag.

BUG=455964

Review URL: https://codereview.chromium.org/901683003

Cr-Commit-Position: refs/heads/master@{#315139}

This is really silly, but gyp doesn't seem to track if a static_library
contains C++ code and needs a C++ link step. So our copy of libxml
breaks us by containing a little bit of (chromium-added) C++ code. This
is really a correctness issue in the build system.

BUG=445627
TEST=linux_ecs_ozone tryjob

Review URL: https://codereview.chromium.org/872493004

Cr-Commit-Position: refs/heads/master@{#315138}

The public hardly knew ye.  Replaced by AppBannerInfoBars.

BUG=453170

Review URL: https://codereview.chromium.org/903263002

Cr-Commit-Position: refs/heads/master@{#315137}

Review URL: https://codereview.chromium.org/904033006

Cr-Commit-Position: refs/heads/master@{#315136}

BUG=429053
TEST=gpu_unittests
R=piman@chromium.org
NOTRY=True

Review URL: https://codereview.chromium.org/894373004

Cr-Commit-Position: refs/heads/master@{#315135}

This reverts commit c2e11810.

TBR=viettrungluu@chromium.org
NOTRY=true
NOTREECHECKS=true
NOPRESUBMIT=true
BUG=

Review URL: https://codereview.chromium.org/877993004

Cr-Commit-Position: refs/heads/master@{#315134}

This pulls in the following Native Client changes:

6c11549: (mseaborn@chromium.org) Add IRT interface for PNaCl's sandboxed linker to use to talk to Chromium
9fff96b: (teravest@chromium.org) NaCl: Remove use of NACL_BUILD_* in common.gypi.
76d6d4b: (mseaborn@chromium.org) PNaCl: Update Binutils revision in pnacl/COMPONENT_REVISIONS: use new IRT interface
a3e1e94: (jfb@chromium.org) Delete Windows time code

BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_arm_compile,linux_nacl_sdk_build

Review URL: https://codereview.chromium.org/905793003

Cr-Commit-Position: refs/heads/master@{#315133}

Re-landing the CL reverted here:
https://codereview.chromium.org/866573004

Opus audio codec is supported by the android platform starting from
Lollipop.  This CL enables canPlayType() support for Opus on Clank and
MSE playback of Opus in Clank. This brings Opus feature parity with
Desktop Chromium.

BUG=318436
TBR=jschuh,rsleevi

Review URL: https://codereview.chromium.org/898393002

Cr-Commit-Position: refs/heads/master@{#315132}

--single-process mode may happen crash in file of webrtc_logging.cc where code
is CHECK(!g_webrtc_logging_delegate). The orginal code is to expect there to
be only one g_webrtc_logging_delegate instance in a single render process.
g_webrtc_logging_delegate is created when a RenderThreadImpl is created.
But in --single-process model all RenderThreadImpl are created in browser
process and so g_webrtc_logging_delegate may be created many times in a single
process. Then CHECK(!g_webrtc_logging_delegate) will fail.

In this patch will change g_webrtc_logging_delegate from process-level to
RenderThread-Level. Since every render process will only keep one RenderThread.

BUG=455573

Review URL: https://codereview.chromium.org/889313003

Cr-Commit-Position: refs/heads/master@{#315131}

Add unittesting for ToolbarActionView to, at minimum, test the basic UI. Also
remove the dependency of ToolbarActionView on Browser, and create a
TestToolbarActionViewController.

BUG=453841
TBR=sky@chromium.org (gn file change)

Review URL: https://codereview.chromium.org/888043003

Cr-Commit-Position: refs/heads/master@{#315130}

Changes in this CL include:
1. Moved the daemon controller implemetation from |ElevatedDaemonController| to |DaemonControllerDelegateWin|
2. Removed all code related to COM activation in |DaemonControllerDelegateWin|.
3. Removed code related to SetOwnerWindow in |DaemonControllerDelegateWin|.
4. Removed code related to the pin confirmation dialog in |DaemonControllerDelegateWin|
5. Cleaned up the COM-styled code to make it adhere to the chromium coding styles.

BUG=453172

Review URL: https://codereview.chromium.org/877343004

Cr-Commit-Position: refs/heads/master@{#315129}

[Taken over from blundell's https://codereview.chromium.org/901843003/,
PS3.]

Adapt to de-clienting of Surface.

Have nacl_listener pass a SimplePlatformSupport instance to
mojo::embedder::Init to satisfy the DCHECK introduced in
https://codereview.chromium.org/898623002/diff/40001/mojo/edk/embedder/embedder.cc.

[Additional fix backported from
https://codereview.chromium.org/898423002/.]

Fix mojo::embedder::CreateChannel(): the evaluation order between the
channel_info->channel_id and channel_info.release() is undefined.

TBR=blundell@chromium.org
NOPRESUBMIT=true

Review URL: https://codereview.chromium.org/904103003

Cr-Commit-Position: refs/heads/master@{#315128}

$ git log 94aea8c60..bdad1183d --date=short --format='%ad %ae %s' | sed 's/@chromium\.org//'
2015-02-06 maruel Further limit parallelism on 32 bits user process.

R=vadimsh@chromium.org
BUG=419862

Review URL: https://codereview.chromium.org/903963004

Cr-Commit-Position: refs/heads/master@{#315127}

R=kalman@chromium.org
BUG=438301,438777

Review URL: https://codereview.chromium.org/862403006

Cr-Commit-Position: refs/heads/master@{#315126}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/d042358..2aafe6f

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/892803003

Cr-Commit-Position: refs/heads/master@{#315125}

The unittests were failing due to various bugs.
These have been fixed.

BUG=456240

Review URL: https://codereview.chromium.org/905823003

Cr-Commit-Position: refs/heads/master@{#315124}

This allows clients to tell when fallback to fake device has
occurred, which prevents silent no-audio failure situations.

The new key, "device_type" can be seen on all controllers and
streams created.

BUG=455371
TEST=chrome://media-internals

Review URL: https://codereview.chromium.org/890573003

Cr-Commit-Position: refs/heads/master@{#315123}

Revert of Add Autofill to webview (patchset #5 id:160001 of https://codereview.chromium.org/866523002/)

Reason for revert:
BUG=456215

Original issue's description:
> Add Autofill to webview
>
> The change in the chrome_autofill_client.cc is needed to enable the autofill popup on
> Mac.
>
> BUG=447938
> TEST=Start Chrome. Navigate to chrome://chrome-signin. Enter a correct username
> with an incorrect password. After the password error appears, you should be able
> to autofill that username.
>
> Committed: https://crrev.com/4a1e13b16b5ef2cb6f7c800ad3c08f1f44bef285
> Cr-Commit-Position: refs/heads/master@{#314889}

TBR=estade@chromium.org,fsamuel@chromium.org,lazyboy@chromium.org,noms@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=447938

Review URL: https://codereview.chromium.org/887003007

Cr-Commit-Position: refs/heads/master@{#315122}

BUG=455084

Review URL: https://codereview.chromium.org/893963004

Cr-Commit-Position: refs/heads/master@{#315121}

BUG=428729

Review URL: https://codereview.chromium.org/905813002

Cr-Commit-Position: refs/heads/master@{#315120}

AwURLRequestContextGetter::SetKeyOnIO now calls into the
DataReductionProxyAuthRequestHandler that is managed by
DataReductionProxyIOData.

BUG=453519

Review URL: https://codereview.chromium.org/881893004

Cr-Commit-Position: refs/heads/master@{#315119}

This is a pure code moving around CL.  No logic change at all.

So we add helper functions to pack/unpack strings to/from a bucket, so
the code generator is now much simpler.

This is to get the pack/unpack functions to be used by glGetUniformIndices.

BUG=429053
TEST=gpu_unittests, webgl_conformance
R=sievers@chromium.org

Review URL: https://codereview.chromium.org/902943002

Cr-Commit-Position: refs/heads/master@{#315118}

cache sends a CHLO and another connection that doesn't wait to load
server config from disk cache and sends INCHOATE_HELLO.

This is not enabled. QuicStreamFactory tests with this flag enabled
and disabled. Tested chrome and all unit tests with this flag enabled.

R=rch@chromium.org

Review URL: https://codereview.chromium.org/881133004

Cr-Commit-Position: refs/heads/master@{#315117}

This unindents the lines about PID/network namespaces, since those now
apply to both the setuid or unprivileged namespace sandbox.

BUG=312380

Review URL: https://codereview.chromium.org/873283004

Cr-Commit-Position: refs/heads/master@{#315116}

Making the (deprecation-in-progress) congestion field write only.

This is a bit of a hack because technically it's "required" for
QUIC_VERSION_23 but as all the internal servers and all of chrome builds
picking up this change consider the field optional despite the version,
it should just Work (TM).

I was hoping to stop sending the congestion fields for v24 clients but
that is not safe until the internal server fleet doesn't consider it a
required field for negotiated()=true.  Bah.

No longer reading the (deprecated) congestion fields for QUIC.

Merge internal change: 85158634
https://codereview.chromium.org/898233003/

Improving junk packet handling for QUIC by ignoring packets with client
port 0.

Merge internal change: 85067984
https://codereview.chromium.org/885713009/

Removing deprecated flag FLAGS_quic_use_initial_rtt_for_stats.

Merge internal change: 84999682
https://codereview.chromium.org/883393008/

Adding more error logging for failed QUIC writes.

Merge internal change: 84989992
https://codereview.chromium.org/898243002/

Further cleanup to QuicAckNotifier and QuicAckNotifierManager.
No functional change.

Merge internal change: 84784925
https://codereview.chromium.org/880403006/

Remove an unneeded hash_set from QuicAckNotifierManager.
No change in behavior.

Merge internal change: 84637544
https://codereview.chromium.org/872403007/

Minor cleanup and optimization of QuicConnection::IsConnectionClose.

Merge internal change: 84624803
https://codereview.chromium.org/903973002/

Rename QuicAckNotifier's AddSequenceNumber to OnSerializedPacket.
No functional change.

Merge internal change: 84624660
https://codereview.chromium.org/867293004/

R=rch@chromium.org

Committed: https://crrev.com/ff331b65e0aef293ed6f1d0954b83ae17cc66d28
Cr-Commit-Position: refs/heads/master@{#315086}

Review URL: https://codereview.chromium.org/903013002

Cr-Commit-Position: refs/heads/master@{#315115}

BUG=456214

Review URL: https://codereview.chromium.org/885233004

Cr-Commit-Position: refs/heads/master@{#315114}

Revert of Linux: Enable multi-threading with the gold linker. (patchset #2 id:20001 of https://codereview.chromium.org/894463003/)

Reason for revert:
Several CrOS folks are reporting linker errors locally, even though the CrOS buildbots are green.

Original issue's description:
> Linux: Enable multi-threading with the gold linker.
>
> BUG=161942
>
> Committed: https://crrev.com/226488abee2adbdb6e54e5bfca1c3b2f52f2da2d
> Cr-Commit-Position: refs/heads/master@{#314991}

TBR=thakis@chromium.org,tzik@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=161942

Review URL: https://codereview.chromium.org/909583002

Cr-Commit-Position: refs/heads/master@{#315113}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/904063003

Cr-Commit-Position: refs/heads/master@{#315112}

Need to turn it off to reduce the power used by the display when idling.

BUG=chrome-os-partner:35458
TEST=Wait for the displays to turn off and check with 'modetest -c' that the DPMS state is off

Review URL: https://codereview.chromium.org/877213005

Cr-Commit-Position: refs/heads/master@{#315111}

We want to restrict certain behavior (such as network reporting) to
auto-launched kiosk apps. This change updates KioskAppManager to track
whether a given app was auto-launched (which is different from whether a
given app is *currently* set to auto-launch, because policies can change
while an app is running).

BUG=452968

Review URL: https://codereview.chromium.org/900553006

Cr-Commit-Position: refs/heads/master@{#315110}

Instead of using the id of the worker-thread to keep track of the thread to
run the image-loader callbacks on, use the task-runner of the thread instead.

BUG=none
R=mkwst@chromium.org

Review URL: https://codereview.chromium.org/897733002

Cr-Commit-Position: refs/heads/master@{#315109}

BUG=441466

Review URL: https://codereview.chromium.org/904033004

Cr-Commit-Position: refs/heads/master@{#315108}

BUG=456001

Review URL: https://codereview.chromium.org/887243003

Cr-Commit-Position: refs/heads/master@{#315107}