GitLab

ShowImeIfNeeded() must be explicitly called to bring up the virtual keyboard
when the device is in touch mode.

This is a short-term solution covering only basic use cases. Notably,
it doesn't handle the case when the user dismissed the keyboard manually and
then re-clicked an ARC text field yet.

BUG=581282
BUG=b/25865847

Review URL: https://codereview.chromium.org/1605273002

Cr-Commit-Position: refs/heads/master@{#371481}

Note: the unittest still uses Profile. That will be fixed in subsequent CLs.

BUG=578823

Review URL: https://codereview.chromium.org/1623223006

Cr-Commit-Position: refs/heads/master@{#371480}

For static methods it does not seem to work properly with older gcc.
Indeed the compiler consider the result as not used in this example:

sequence_token_ = BrowserThread::GetBlockingPool()->GetSequenceToken()

"error: ignoring return value of 'static base::SequencedWorkerPool*
content::BrowserThread::GetBlockingPool()', declared with attribute
warn_unused_result [-Werror=unused-result]"

The solution is just to call GetSequenceToken() directly as:
base::SequencedWorkerPool::GetSequenceToken() as it is static.

BUG=579461

R=cpu@chromium.org, nico@chromium.org

TEST= GYP_DEFINES="clang=0 use_sysroot=0"

Review URL: https://codereview.chromium.org/1610103002

Cr-Commit-Position: refs/heads/master@{#371479}

The 'shape' attribute on HTMLAreaElement is an "enumerated attribute"
[1], which means that it should be matched ASCII case-insensitively[2].

To get a proper overload of equalIgnoringASCIICase(...) that matches the
required use (AtomicString against string literal/const char*),
restructure the definition of equalIgnoringASCIICase() to do away with
the templated version in favor of a generic StringImpl* version, and
specific wrappers around that one for AtomicString/String.
Also add a specialization for comparing against char/LChar.

No effect on the specified test because:
a) Invalid/missing value default is not per spec, so the unexpected shape
is picked anyway.
But more importantly:
b) the way case-folding is implemented/specified, no non-ASCII character
is case-folded to something in the ASCII-range.

[1] https://html.spec.whatwg.org/multipage/embedded-content.html#attr-area-shape
[2] https://html.spec.whatwg.org/multipage/infrastructure.html#enumerated-attribute

TEST=fast/html/area-shape.html
BUG=578125

Review URL: https://codereview.chromium.org/1624383002

Cr-Commit-Position: refs/heads/master@{#371478}

Remove the unnecessary and dangerous polling in startMonitoring(). mTestDelegate.mIsRunning is set directly in start(), so waiting for mTestDelegate.isRunning() does not guarantee anything. However, it does introduce the possibility of a race if the mHandler.postDelayed() call in mTestDelegate.start() switches threads.

Precisely, if mHandler.postDelayed() stays in the same thread, or causes uninteresting thread switches, the following happens in startMonitoring:

mTestDelegate.start ->
 mIsRunning = true;
 ...

CriteriaHelper.pollForCriteria ->
 mTestDeleted.isRunning() == true, exit immediately.

On the other hand, if there is an interesting thread switch in mHandler.postDelayed(), then we could have

mTestDelegate.start ->
 mIsRunning = true;
 mHandler.postDelayed()
  ... stuff happens ...
  mTestDelegate.run() is called
   mIsRunning = false;
  ... more stuff happens ..

(now back to main test thread)
CriteriaHelper.pollForCriteria ->
 mTestDeleted.isRunning() == false, loop until timeout and the test fails.

Before removing this poll, running locally the test occasionally retried tests on a nexus 4; after removing it it ran 20 times successfully with no retries. I think we have slightly higher confidence now that it won't flake on the build.

BUG=542627

Review URL: https://codereview.chromium.org/1634693002

Cr-Commit-Position: refs/heads/master@{#371477}

As part of processing the name attribute for a radio button, it is
added to the current radio button group. For buttons that are
additionally "required", that leads to double accounting for the
group's count of such required buttons, as the radio button group
doesn't keep track what has been registered as "required" already
or not.

Address by having the button group track the registered "required"
state of its members/buttons.

R=keishi,tkent
BUG=

Review URL: https://codereview.chromium.org/1632493002

Cr-Commit-Position: refs/heads/master@{#371476}

It was PaintInvalidationState::enclosingLayer(), but we actually need
the enclosing self painting layer to set repaint flags. Later changes
to optimize empty paint phases also need enclosing self painting layer.

We don't need to specially handle multicol spanner in the new function
because our paint invalidation of multicol spanner follows the true
layer painting order. Instead we need to special handle multicol
spanner in the assertion to check if the repaint flags are properly
set on layers.

This has been reviewed by mstensho@opera.com and chrishtr@chromium.org
as part of https://codereview.chromium.org/1584493002/.

TBR=mstensho@opera.com,chrishtr@chromium.org
BUG=574938

Review URL: https://codereview.chromium.org/1629563003

Cr-Commit-Position: refs/heads/master@{#371475}

Cr-Commit-Position: refs/heads/master@{#371474}

The metrics were added in the V8 patch reviewed at
https://codereview.chromium.org/1558113002
They measure
- Each of the three deprecated Promise functions
- Two nonstandard pieces of Intl functionality
- Accesses of the RegExp.prototype.unicode getter on the prototype

BUG=v8:3785,v8:3238,v8:4633

Review URL: https://codereview.chromium.org/1578143002

Cr-Commit-Position: refs/heads/master@{#371473}

This patch gets rid of rid of a redundant parameter |ResetCaretBlinkOption| from
|FrameSelection::updateAppearance()| with introducing |stopCaretBlinkTimer()|
by calling |stopCaretBlinkTimer()| at call site which calls |updateAppearance()|
with |ResetCaretBlink| to simplify source code for improving readability.

This patch is a follow-up patch of http://crrev.com/1629213002, which simplifies
code path in |updateAppearance()|.

BUG=n/a
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1632673004

Cr-Commit-Position: refs/heads/master@{#371472}

BUG=none
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/1632013004

Cr-Commit-Position: refs/heads/master@{#371471}

This adds a new BindingsPolicy exclusively for enabling
Mojo system API and ServiceRegistry modules to a render
view. Previously these were only made available in
conjunction with WebUI bindings.

While still implied by WebUI bindings availability, Mojo
modules are now also available to any view created during
a layout test run.

Part of a CL series to enable Mojo service mocks in layout
tests:

 1. https://codereview.chromium.org/1468903002
 2. this CL
 3. https://codereview.chromium.org/1470153002

TBR=dbeam@chromium.org for WebUI

Review URL: https://codereview.chromium.org/1470823002

Cr-Commit-Position: refs/heads/master@{#371470}

BUG=562431

Review URL: https://codereview.chromium.org/1609943003

Cr-Commit-Position: refs/heads/master@{#371469}

I forgot to add [Leak] when landing r371372.

BUG=
TBR=yosin@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1636963002

Cr-Commit-Position: refs/heads/master@{#371468}

Parallel copy can have huge performance drop in some cases. (See issue 578923 for the detail)
For safety and simplicity, this CL makes the recursive file operations sequential.

BUG=578923
TEST=manually confirm the performance of copying a directory to a SD card.

Review URL: https://codereview.chromium.org/1619733004

Cr-Commit-Position: refs/heads/master@{#371467}

Since we're no longer supporting XP, this is no longer needed.  Newer
versions of windows automatically tune the buffer sizes.

BUG=580691

Review URL: https://codereview.chromium.org/1626643002

Cr-Commit-Position: refs/heads/master@{#371466}

Review URL: https://codereview.chromium.org/1632173002

Cr-Commit-Position: refs/heads/master@{#371465}

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/1616673003

Cr-Commit-Position: refs/heads/master@{#371464}

BUG=525873

Review URL: https://codereview.chromium.org/1635643004

Cr-Commit-Position: refs/heads/master@{#371463}

BUG=525873

Review URL: https://codereview.chromium.org/1637753002

Cr-Commit-Position: refs/heads/master@{#371462}

BUG=580978

Review URL: https://codereview.chromium.org/1638433002

Cr-Commit-Position: refs/heads/master@{#371461}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/b94e0a97f615..f7563a0c32bf

$ git log b94e0a97f..f7563a0c3 --date=short --no-merges --format='%ad %ae %s'

CQ_INCLUDE_TRYBOTS=
TBR=catapult-sheriff@chromium.org

Review URL: https://codereview.chromium.org/1624383006

Cr-Commit-Position: refs/heads/master@{#371460}

BUG=525873

Review URL: https://codereview.chromium.org/1635723003

Cr-Commit-Position: refs/heads/master@{#371459}

BUG=525873

Review URL: https://codereview.chromium.org/1634023003

Cr-Commit-Position: refs/heads/master@{#371458}

BUG=525873

Review URL: https://codereview.chromium.org/1637733002

Cr-Commit-Position: refs/heads/master@{#371457}

Part 6.

This change adds two syncable preferences related to using cloud services with Media Router.

kMediaRouterCloudServicesPrefSet tracks whether or not the user has explicitly acknowledged the first run flow with the cloud services preference present. This is important to keep track of since there are users who have acknowledged the first run flow before the work related to the cloud services lands (currently in progress). This will be used to surface a different prompt to ask if users want to enable cloud services.

kMediaRouterEnableCloudServices tracks whether the user has enabled cloud services.

BUG=560457

Review URL: https://codereview.chromium.org/1582943003

Cr-Commit-Position: refs/heads/master@{#371456}

BUG=525873

Review URL: https://codereview.chromium.org/1635943002

Cr-Commit-Position: refs/heads/master@{#371455}

BUG=581256

Review URL: https://codereview.chromium.org/1636953002

Cr-Commit-Position: refs/heads/master@{#371454}

BUG=525873

Review URL: https://codereview.chromium.org/1628333005

Cr-Commit-Position: refs/heads/master@{#371453}

This is a regression from https://codereview.chromium.org/1530523002.
We should be passing signal_strategy_.get() instead of signal_strategy.get()
to the underlying JingleSessionManager in
it2me_host.cc

BUG=579758

Review URL: https://codereview.chromium.org/1638733002

Cr-Commit-Position: refs/heads/master@{#371452}

BUG=

Review URL: https://codereview.chromium.org/1633973002

Cr-Commit-Position: refs/heads/master@{#371451}

BUG=525873

Review URL: https://codereview.chromium.org/1633043002

Cr-Commit-Position: refs/heads/master@{#371450}

This test passes as is.  It was disabled due to a temporary regression
that cleared up a long time ago.

BUG=580744

Review URL: https://codereview.chromium.org/1624763002

Cr-Commit-Position: refs/heads/master@{#371449}

BUG=580633

Review URL: https://codereview.chromium.org/1622663002

Cr-Commit-Position: refs/heads/master@{#371448}

Cr-Commit-Position: refs/heads/master@{#371447}

BUG=577820

Review URL: https://codereview.chromium.org/1634793002

Cr-Commit-Position: refs/heads/master@{#371446}

BUG=525873

Review URL: https://codereview.chromium.org/1636923002

Cr-Commit-Position: refs/heads/master@{#371445}

Revert of Roll src/third_party/libvpx_new/source/libvpx/ c0307e6ce..732242ab3 (15 commits). (patchset #1 id:1 of https://codereview.chromium.org/1638443002/ )

Reason for revert:
Breaking win_clang build in webrtc:
https://codereview.webrtc.org/1637793002/

Original issue's description:
> Roll src/third_party/libvpx_new/source/libvpx/ c0307e6ce..732242ab3 (15 commits).
>
> https://chromium.googlesource.com/webm/libvpx.git/+log/c0307e6cea0f..732242ab3d00
>
> $ git log c0307e6ce..732242ab3 --date=short --no-merges --format='%ad %ae %s'
> 2016-01-21 marpan vp9 pickmode: Fix the shift on negative value.
> 2016-01-21 jzern vp9_aq_cyclicrefresh: fix double->float warning
> 2016-01-21 yaowu Fix a typo in ctrl_set_render_size()
> 2016-01-20 marpan vp9-aqmode=3: Reduce condition below which we turn off delta-qp.
> 2016-01-20 huisu Fix build with --enable-internal-stats
> 2016-01-20 aconverse Remove the vestigal skip_eob feature from tokenization.
> 2016-01-20 marpan vp9-svc: Allow frame-dropping in svc datarate control tests.
> 2016-01-20 marpan vp8-denoiser: Fix threshold for skin map.
> 2016-01-20 yaowu Remove duplicate definitions
> 2016-01-15 marpan Vidyo patch: Changes to the scalability code.
> 2016-01-19 slavarnway VP9: Eliminate MB_MODE_INFO
> 2016-01-18 rsbultje Use input framerate as timebase if none was explicitly specified.
> 2016-01-15 aconverse Tie the bit cost scale to a define.
> 2016-01-15 aconverse Deduplicate sign cost for ONE/TWO/THREE/FOUR tokens
> 2016-01-06 yunqingwang Amend and improve VP8 multithreading implementation
>
> R=johannkoenig@google.com
>
> Committed: https://crrev.com/1861c8bff5fa4f60b9078698d7fb9dc936a9914d
> Cr-Commit-Position: refs/heads/master@{#371296}

TBR=johannkoenig@google.com,marpan@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1638533003

Cr-Commit-Position: refs/heads/master@{#371444}

This affects both MD and non-MD and is based on the current glass behavior + the
fix for bug 580757.

12345678901234567890123456789012345678901234567890123456789012345678901234567890
* Eliminate kAvatarInnerSpacing.  Replace with the opaque frame equivalent of
  https://codereview.chromium.org/1624803002/ (which unfortunately is more
  complicated due to the split of OpaqueBrowserFrameView and
  OpaqueBrowserFrameViewLayout; I'm inclined to undo that split at some point).
  This deals with the "caption buttons on left" case better than the existing
  code, and avoids excessive space in incognito or MD.
* Position/size the incognito icon the same way in both normal and maximized
  mode for MD.  This matches glass, and is necessary because the MD incognito
  icon is much smaller and so shouldn't be positioned/clipped the same way as in
  non-MD.
* Remove unconditional addition of one pixel before tabstrip leading edge.
  Replace with code to position the tabstrip edges based on
  NonClientBorderThickness() instead of FrameBorderThickness() -- in restored
  windows, the two differ by kClientEdgeThickness (i.e. 1 pixel).  This is more
  correct in maximized mode, where that extra pixel is removed, and more correct
  for the "caption buttons on left" case as well, in which case AFAICT we want
  the mirror behavior.  (I don't know what the existing comment about how the
  two sides differ was supposed to mean; I think it's wrong.)  This results in a
  variety of 1-pixel changes to the tabstrip left and/or right edges,
  necessitating some unit test tweaks.
* Call LayoutIncognitoIcon() unconditionally so we can use it to adjust the
  tabstrip bounds even when there's no incognito icon.  This is all a bit more
  confusing than on glass, where we can just lay out a zero-width incognito icon
  and use it to position the tabstrip in all cases, because of the need to
  support caption buttons on either side (screw you Linux).

BUG=519020
TEST=none

Review URL: https://codereview.chromium.org/1622833002

Cr-Commit-Position: refs/heads/master@{#371443}

https://pdfium.googlesource.com/pdfium.git/+log/4a2aa1a..05e6741

TBR=tsepez@chromium.org

Review URL: https://codereview.chromium.org/1636943002

Cr-Commit-Position: refs/heads/master@{#371442}