- 04 Oct, 2019 40 commits
-
-
Lucas Furukawa Gadani authored
Bug: 984550 Change-Id: Icd4079ef0296a73c864adf7e765690cbb2682829 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833316Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#702923}
-
Sergio Villar Senin authored
There are several includes of that header because code in chrome/browser uses WebPluginAction::Type enum. In order to remove the dependency, the web_plugin_action.h file was moved to third_party/blink/public/common/plugin. Since the file is no longer in the public/platform/ directory we are also renaming it to PluginAction. Bug: 1008303 Change-Id: If0b370d23ca211cd3e5a85a845c86ac9821271e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837622 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#702922}
-
Sadrul Habib Chowdhury authored
RenderProcessHostCreationObserver is introduced for code that wants to be notified any time a new RenderProcessHost instance is created. Instead of using NotificationService with NOTIFICATION_RENDERER_PROCESS_CREATED, code can now use content::RenderProcessHostCreationObserver. BUG=357627 Change-Id: I3ad4f7f5fef6fa2b17f9a0a82c96bc9c22dc0fb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833282 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#702921}
-
Findit authored
This reverts commit 242c714f. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 702905 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzI0MmM3MTRmYTFjNjljNWRlMjVlOTA2NThjOWNkYzgyODA3MDZmYTgM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/fuchsia-x64-cast/55286 Sample Failed Step: compile Original change's description: > [chromecast] Add rounded corner decoration utility. > > Upstreams a utility which draws roundy corners on aura windows. > > Bug: internal b/141369549 > Test: manual > Change-Id: Ibbc57c6e15529ebc69fb294fc391cf349e9bb305 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841573 > Reviewed-by: Daniel Nicoara <dnicoara@chromium.org> > Commit-Queue: Ryan Daum <rdaum@chromium.org> > Cr-Commit-Position: refs/heads/master@{#702905} Change-Id: If11f7a9b914d232251303b6f3b96ba08ae398d24 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: internal b/141369549 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841937 Cr-Commit-Position: refs/heads/master@{#702920}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I11d64dffb69967fe9339fdfcebaa2e3b90f0b49d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841818Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702919}
-
Garrett Beaty authored
This is a reland of 16cbcb68 nocompile_tests test suite is only be adding to mac currently since it breaks on linux builders. Original change's description: > Add content_nocompile_tests to be run by some builders. > > Bug: 878706 > Change-Id: I5c3bd7d4393fe6c002171ff9937ad70d2b1ba191 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833297 > Auto-Submit: Garrett Beaty <gbeaty@chromium.org> > Reviewed-by: Stephen Martinis <martiniss@chromium.org> > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > Cr-Commit-Position: refs/heads/master@{#702132} Bug: 878706 Change-Id: Ifed8186ebe4f5ba856efe6528111f773c33a31cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837976 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#702918}
-
Ben Wagner authored
https://chromium.googlesource.com/external/github.com/libexpat/libexpat.git/+log/4f23e05a33a6..a7bc26b69768 $ git log 4f23e05a3..a7bc26b69 --date=short --no-merges --format='%ad %ae %s' 2019-09-25 sebastian Set release date for 2.2.9 2019-09-25 sebastian Bump version info from 7:10:6 to 7:11:6 2019-09-13 sebastian Bump version from 2.2.8 to 2.2.9 2019-09-25 sebastian Changes: Document #347 2019-09-21 sebastian CMake: Use libexpat*.(dll|lib) not expat*.(dll|lib) on Windows Created with: roll-dep src/third_party/expat/src R=bungeman@chromium.org,dcheng@chromium.org Change-Id: I1b04348966d0cc4872a89a45547cb16a28e11776 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829678 Commit-Queue: Ben Wagner <bungeman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#702917}
-
David Bertoni authored
Service Worker-based extensions should have the same limitations as event page-based extensions: 1. The extension must specify menu IDs. 2. The extension cannot use the "onclick" property to specify click handlers. Bug: 976052 Change-Id: I8bbd2f07e70860dbf4deba567ccdd591735ef20d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834648 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#702916}
-
Maksim Ivanov authored
Avoid showing the Network Error Screen when the timeout error happens during the security token (a.k.a. smart card) PIN dialog on the Gaia sign-in screen. Before this CL, if the user starts the SAML login using the smart card but doesn't type the PIN on time, the UI would eventually switch to the "you're offline" error screen. The exact timeout is not controlled by us, but it's typically around 30 seconds. The error screen is confusing for the user and provides no good way to retry the login attempt. After this CL, the login UI gets reset to the initial screen in this scenario, allowing them to make another login attempt and without confusing them with unexpected network error details. This is intended to be a short-term workaround; the more generic solution would be to handle specific network/HTTP errors more carefully and show the relevant UI. Bug: 1009591 Test: enroll Chromebook with device policies to support smart card sign-in, start SAML sign-in using the smart card, at the PIN dialog don't enter any PIN and wait for ~30 seconds, check that no Network Error screen is shown, and the initial sign-in screen is shown instead Change-Id: I5287332c6997d0d387f8055ef6a6a7cc507bb0b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833589Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#702915}
-
Hesen Zhang authored
- Rename validation check whether original path exist in disk, in Android Q path is using ContentUri, Failure of unavailable returned. - Android Q uses display_name column in media storage, we should SetDisplayName to update UI before run the callback. - Fix a missing rename dialog UI state machine transition case. Bug: 1007503 Change-Id: I2051d99449f39f6910a2ecd70250d6308e731917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834949Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Hesen Zhang <hesen@chromium.org> Auto-Submit: Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#702914}
-
Emily Stark authored
This is a stopgap fix for the fact that it's unclear which frame triggered a navigation to an external protocol. Eventually, we want to implement some more robust fixes, like preventing a frame from navigating another cross-origin frame to an external protocol, but that'll involve a bit more investigation and metrics (to be added in a follow-up CL). Bug: 754304 Change-Id: Ie7e8722281e364397072ade566abfc3739338b49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829932Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#702913}
-
Archana Simha authored
Change-Id: I95ef9cddc9260d17340644efcf559fba25f29e27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835265Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Archana Simha <archanasimha@chromium.org> Cr-Commit-Position: refs/heads/master@{#702912}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/95edac1c9a4a..9e951cd782c4 git log 95edac1c9a4a..9e951cd782c4 --date=short --no-merges --format='%ad %ae %s' 2019-10-04 kjlubick@google.com Reduce bandwidth to RPIs 2019-10-04 reed@google.com Simple iterator for textblobs 2019-10-04 rmistry@google.com Update sheriff doc with autorollers and handoff doc 2019-10-04 rmistry@google.com Remove always red SK_SUPPORT_LEGACY_CLIPTOLAYERFLAG bot and it's builder Created with: gclient setdep -r src/third_party/skia@9e951cd782c4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC rmistry@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmistry@google.com Bug: None Change-Id: I2c2d9c83b410140290dff3d5fdc43979fedf0ae2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841713Reviewed-by:
-
Adam Langley authored
This flag was removed some time ago, but its metadata remained. Change-Id: Ibf23e733b244b96e7b66cc2cbbe76ae0f5d6cf19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838956 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#702910}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3ed3be3e. With Chromium commits locally applied on WPT: 03ccd4e9 "html: Move autofocus tests to html/interaction/focus/the-autofocus-attribute/" c19433ef "Reland "[ChromeDriver] Stop using --ignore-certificate-errors"" afc509ca "[WPT/common/security-features] Fix typo" df884b61 "[WPT/referrer-policy] Add worker subresource tests" 86ea3d5b "Renaming fetch/metadata web platform tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: If997fcc6febc8bfe190360b3ec43c5bded35c1cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841531Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702909}
-
Maggie Chen authored
The majority of the GPU watchdog V2 crashes happen within the first 60 seconds after launch. Extend the timeout so the GPU can finish the initialization on a slower machine. Bug:949839 Change-Id: I173f0b6d9fd707b239e9f5598ff883e2054a054f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836973 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
Scott Little authored
This CL enables automatic lazy image and iframe loading by default. Note that by default, automatic lazy image and iframe loading is restricted to users with Lite Mode (aka Data Saver) turned on, and in practice, this also restricts automatic lazy loading by default to Android, since Lite Mode is only accessible through UI on Android. Bug: 989246, 954324 Change-Id: Iad30e42061838941d73a0742c1d2fd442d79f98c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838679Reviewed-by:
rajendrant <rajendrant@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#702907}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f83d0ef0859c..7536bc539500 git log f83d0ef0859c..7536bc539500 --date=short --no-merges --format='%ad %ae %s' 2019-10-04 nisse@webrtc.org Account for IP and UDP headers in emulated network 2019-10-04 hbos@webrtc.org Update RTC_LOGs in DtlsTransport to be able to distinguish errors. Created with: gclient setdep -r src/third_party/webrtc@7536bc539500 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Iccbfc60493ba329057b8cafeb862dd0dbcd464a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841371Reviewed-by:
-
Ryan Daum authored
Upstreams a utility which draws roundy corners on aura windows. Bug: internal b/141369549 Test: manual Change-Id: Ibbc57c6e15529ebc69fb294fc391cf349e9bb305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841573Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Ryan Daum <rdaum@chromium.org> Cr-Commit-Position: refs/heads/master@{#702905}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0ce0e2c0a426..23149ef7ce0b Created with: gclient setdep -r src-internal@23149ef7ce0b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I8d42a91840c3a33489a95dcb681d8226052cecb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841731Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702904}
-
Armando Miraglia authored
BUG=796964 Change-Id: I69cd354a43b51639234ae5e6b3aa15cc646b022d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841431Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#702903}
-
Alison Maher authored
If certain flags are enabled, NativeThemeMac may return a different NativeTheme instance for NativeTheme::GetInstanceForWeb(). This will cause NativeTheme::GetInstanceForWeb() on Mac to be out of sync in terms of dark mode and high contrast. To fix this, NativeTheme::GetInstanceForWeb() is added as an observer of NativeTheme::GetInstanceForNativeUi() in these cases. Bug: 970285 Change-Id: I832d182647f81491a761a071bc5633c2efdeedb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834028Reviewed-by:
-
Rob Schonberger authored
Add a fix to the recent neural utils where devices don't report X or Y resolution appropriately, by setting to the correct number (1). Add a unittest with a genuine touchscreen DeviceCapabilities to show this off. Bug: 1009290 Change-Id: I18af8c02e4a68d024be8f73581cda4c2329ca177 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839271Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Rob Schonberger <robsc@chromium.org> Cr-Commit-Position: refs/heads/master@{#702901}
-
Ana Salazar authored
Bug: 1005171 Change-Id: Ib89421a831edecce2c9eb3d35ab6b477557127a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838914Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Ana Salazar <anasalazar@chromium.org> Cr-Commit-Position: refs/heads/master@{#702900}
-
danakj authored
RenderFrameImpl wants to scale the position of a context menu by the emulator scale, if the position wasn't specified by the browser (this seems suspect). It can do this through the PageProperties directly instead of going through RenderWidget. R=avi@chromium.org Bug: 1006052 Change-Id: I72b5b684b2279902fca6cbcfa0920f0ba021cd2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834766Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/6021fbd09b1c..6fff5122a23e git log 6021fbd09b1c..6fff5122a23e --date=short --no-merges --format='%ad %ae %s' 2019-10-04 bclayton@google.com libVulkan: Wrap the marl scheduler in a shared_ptr. Created with: gclient setdep -r src/third_party/swiftshader@6fff5122a23e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/141380274 Change-Id: Iac2236642c773a5bc860bdc52a84eb92a894e1cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841711Reviewed-by:
-
Shawn Gallea authored
This will allow for custom framerate, to eventually be used to lower framerate for headless devices. Bug: b/139299756 Test: Compile cast_shell for headless device Change-Id: Ib08559a3101d55c7b004a7356f78a2f01010af4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814318 Commit-Queue: Shawn Gallea <sagallea@google.com> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Mark BoxedV8Module as final to avoid problems when having no virtual destructor which depends on TraceWrapperV8Reference. Change-Id: Ibab44d1c52f87bc099c0eca7602b175345e4cb2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841632 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#702896}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/97565d8a9687..f77a4786a334 git log 97565d8a9687..f77a4786a334 --date=short --no-merges --format='%ad %ae %s' 2019-10-04 treehugger-gerrit@google.com Merge "docs: Add tip about ccache" 2019-10-04 lalitm@google.com Merge "Expose full gpu_slice (with slice columns)" 2019-10-04 lalitm@google.com Merge "trace_processor: fix resize bug" 2019-10-04 lalitm@google.com trace_processor: improve logic of best index 2019-10-04 eseckler@google.com Merge "processor: Stitch chunks of legacy user json traces for export" 2019-10-04 lalitm@google.com Merge "Improve logging of GetCmdlineForPID." 2019-10-04 treehugger-gerrit@google.com Merge "CI: Add Bazel coverage" 2019-10-04 lalitm@google.com Merge "trace_processor: significantly improve performance of bitvector resize" 2019-10-04 tneda@google.com API for drawing flamegraph for selected heap profile 2019-10-04 primiano@google.com Merge "Add yapf python formatter and format all files" Created with: gclient setdep -r src/third_party/perfetto@f77a4786a334 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I508392c1e529bdd2166ae9f10b890dd752324574 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841652Reviewed-by:
-
Robbie Gibson authored
For a Voice Control name, the "1 unread reading list item" isn't useful. The name should still be just "Reading List." Bug: 1004319 Change-Id: I64e968a57c8aa027977220dbf8a62bc638baa07f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837792 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#702894}
-
Victor Fei authored
Fix for AXRange::GetScreenRects to not return bounding boxes for ranges that are offscreen. Previously, we assumed ranges that are offscreen will have empty bounding rects, this is incorrect because offscreen rects has its width/height clipped to 1 rather than 0; so bounding box is not empty. See doc: https://cs.chromium.org/chromium/src/docs/accessibility/offscreen.md Instead, GetScreenRects now looks at the offscreen status from the bounds API to ignore offscreen ranges. This fix is one of a series of fixes need for bug:964078. Bug: 964078 Change-Id: Ibfb4d245845b7e18d59724b8c7fd09f9cc3de793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824061 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#702893}
-
Anastasia Helfinstein authored
Instead of re-calculating whether the virtual keyboard is open every time auto-scan changes, cache the value and explicitly set it when the keyboard is entered or exited. Bug: None Change-Id: Ia86a95f6552df4f919d6e583829f5d3f15077cb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829767Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#702892}
-
Lei Zhang authored
Found using tools/check_grd_for_unused_strings.py. Change-Id: Ib94967bb7045e9de1c97f96f5ece96b7435eb04e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839632Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#702891}
-
Lei Zhang authored
- Refactor GetValue() to use an existing struct. - Make the parameter names in the .cc / .h files match for GetValue(). - Mark GetValue() and GetStringValue() const. - Make all ::VerQueryValue() callers consistent. - Add a comment to note |fixed_file_info_| is never nullptr. - Fix various nits. Change-Id: I4e73bf5791045005c2cfdeb6a039815c39e953ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837490 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#702890}
-
Jordan Demeulenaere authored
Change-Id: Ife5804b2897aac9463d91a5e20e154678ce274bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841633 Auto-Submit: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#702889}
-
Mitsuru Oshima authored
Bug: 1007397 Test: covered by unittest Change-Id: Ib6b5ed47c3368133d0dcccf7a9be202570d0f541 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833007 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#702888}
-
Alexander Timin authored
At the moment AppBannerManager disables bfcache when committing the initial navigation and prevents every frame from being cached. Fix this by requiring state to be not INACTIVE. R=arthursonzogni@chromium.org TBR=dominickn@chromium.org BUG=1001087 Change-Id: I5c63a35d2a56872b36f79e738d4db90c554a9caf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840233Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#702887}
-
Lei Zhang authored
Test to make sure no_version_info.dll, which has no version info, causes base::FileVersionInfo::CreateFileVersionInfo() and CreateFileVersionInfoForModule() to return nullptr. no_version_info.dll is just an one-off component build of pdfium.dll, with everything stripped out. Change-Id: I3e4b527f1d2f52dcec55c2c38af369a651608175 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838268Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/485edf28..666d4144 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I86327aa0af90495cb06d3524a8864cef7cee652b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841311Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702885}
-
Fergus Dall authored
In crrev.com/c/1454156 the checks in AppsGridView::ReparentItemForReorder and AppsGridView::ReparentItemToAnotherFolder to see if a folder would be deleted by removing an app was broken for persistent folders. This would cause the model for the folder to be deleted, while the view remained in place. Interacting with the empty folder would then cause a null dereference and crash chrome. Bug: 1009989 Change-Id: Ief7bc007683b38d536aabb1418d8142e5c0f7702 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837556Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#702884}
-
