- 29 Jul, 2019 40 commits
-
-
Mohamed Amir Yosef authored
This is a reland of 6811de35 It was reverted due to crbug.com/988010 The underlying issue was unrelated to that patch and has been fixed in https://chromium-review.googlesource.com/c/chromium/src/+/1722841 No changes are introduced and hence TBR'ing original reviewers. Original change's description: > [PasswordManager] Stop Using Native Backends on Linux systems > > Recent migrations moved all users who have been using the keying to the > LoginDatabase. This CL forces all users to using LoginDatabase > instead of native backends on Linux. > > TBR=pcc@chromium.org > > Change-Id: Ibac11e68d8f354ecf7f3c9828d95777ea5b3df60 > Bug: 950269, 950267 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713560 > Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> > Reviewed-by: Peter Collingbourne <pcc@chromium.org> > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > Reviewed-by: Christos Froussios <cfroussios@chromium.org> > Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> > Cr-Commit-Position: refs/heads/master@{#681042} TBR=cfroussios@chromium.org,vasilii@chromium.org,pcc@chromium.org Bug: 950269, 950267 Change-Id: I1f091e18f6e23da8a2c8588c9a00bdb08fbda2f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722964Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#681798}
-
Kamila authored
Bug: 986737 Change-Id: I7a96cbc5668adfb8c9922e2adca03bc7cfa5ab7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719127 Commit-Queue: Kamila Hasanbega <hkamila@google.com> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#681797}
-
Takuto Ikuta authored
Bug: 977804 Change-Id: Ib6d2a783bd053ef1554cb5a133b03d6fb894ace5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722272 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#681796}
-
Leonard Grey authored
Modal sheets use "NSTitleWindowStyleMask" for Reasons (looks like mostly input handling). This means that when we ask for their content rect, they account for the title bar, though we don't actually display one! In practice this means: 1. We've been undersizing modals for a while. 2. If it so happens that if we roundtrip back through NativeWidgetNSWindowBridge::SetBounds (motivating example: when the window is moved to a screen with different DPI), we lose *another* title bar's worth of height. This change modifies the style mask so that the title bar isn't accounted for when calculating the content rect. Bug: 982477 Change-Id: I79da0297a1d79eaae3f7eaef85a5986c12b74436 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721269 Auto-Submit: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#681795}
-
Edvard Thörnros authored
The (somewhat flakey) correct-events-for-short-animations-with-syncbases.html has been reworked and made more stable. This might affect it's coverage but it was too flakey to work reliably. rapid-syncbases.html has been created to hopefully catch what correct-events-for-short-animations-with-syncbases.html used to catch. Together these tests should have some redundancy which will improve the test stability and hopefully make them less flakey. Bug: 981522 Change-Id: I217903f66dc5a1a1739a258b32da39338a44bb3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722966 Commit-Queue: Edvard Thörnros <edvardt@opera.com> Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Edvard Thörnros <edvardt@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#681794}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d188f3a9613d..33f77d35ca2c git log d188f3a9613d..33f77d35ca2c --date=short --no-merges --format='%ad %ae %s' 2019-07-29 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@33f77d35ca2c The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@google.com Bug: None Change-Id: I06a360cd7cfc82bbd0f676ec4699bfec04d749ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722203Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#681793}
-
Lutz Justen authored
Disables the flaky test virtual/cors-rfc1918/http/tests/security/cors-rfc1918/ addressspace-serviceworker-basic.html on Linux. TBR=nhiroki@chromium.org BUG=chromium:988074 TEST=Made sure failure is OK. Failure shows up as "The test ran as expected (0 passed, 1 didn't)." Change-Id: I5a49ca60b7ab3bc1b15f96ffad456be65c9e35a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722543 Commit-Queue: Lutz Justen <ljusten@chromium.org> Reviewed-by:Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#681792}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ed0febf57383..630443aba2b4 git log ed0febf57383..630443aba2b4 --date=short --no-merges --format='%ad %ae %s' 2019-07-29 sprang@webrtc.org Remove usage of RTPSender::SetSsrc() in unit tests Created with: gclient setdep -r src/third_party/webrtc@630443aba2b4 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: Ia1a75afedb1cb3f12826284a50fe748fa264373f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723643Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a0ddf25cee99..da370c8e520b git log a0ddf25cee99..da370c8e520b --date=short --no-merges --format='%ad %ae %s' 2019-07-29 taylori@google.com Merge "perfetto-ui: Track data request changes" 2019-07-29 treehugger-gerrit@google.com Merge "Fix a few typos" Created with: gclient setdep -r src/third_party/perfetto@da370c8e520b The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: Ia1fde5f31130c3e69d1a803fcf698dd91fd731a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722202Reviewed-by:
-
Matthew Cary authored
Change use of the legacy base::SharedMemory to base::UnsafeSharedMemoryRegion. No functional change. Bug: 849207 Change-Id: I488e1ca93ea6dd28c70633a3271a8bb46a2ec447 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722540 Commit-Queue: Matthew Cary (CET) <mattcary@chromium.org> Reviewed-by:
Eero Häkkinen <eero.hakkinen@intel.com> Cr-Commit-Position: refs/heads/master@{#681789}
-
Ben Kirchman authored
Context: https://chromium-review.googlesource.com/c/chromium/src/+/1715173/10 Bug: 669707 Change-Id: I5445852775cc7e15fe01e70f16c58110e6e4a9e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721466Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Benjamin Kirchman <kirchman@google.com> Cr-Commit-Position: refs/heads/master@{#681788}
-
Omer Katz authored
Replace ObjectResurrectionForbiddenScope with NoAllocationScope Bug: 981414 Change-Id: Iced48387c20c431ee0918f4c239f6ef0b8de82a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702368 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#681787}
-
Sam Maier authored
Change-Id: I984ce23ea9494151e309aa69d7e0a9c27111a4a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721021Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#681786}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/df746d0e6fd4..c5656169e42b git log df746d0e6fd4..c5656169e42b --date=short --no-merges --format='%ad %ae %s' 2019-07-29 tmrts@chromium.org Add optional target selection for resolving fixed revisions Created with: gclient setdep -r src/third_party/depot_tools@c5656169e42b The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Bug: chromium:950731,chromium:982711 Change-Id: I0a14c8b3fa17d63b292174e8ecc5feba1f0179cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723015Reviewed-by:
-
Nico Weber authored
We're on a very different toolchain nowadays; maybe this works now. Bug: 485542 Change-Id: I5adfd8758853f18c1825d80e2b183ac1da1136f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721079 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#681784}
-
Armando Miraglia authored
crrev.com/c/1708136 fixed a bug so that when a device is unplugged and it was either a 'default' or a 'communications' device, or both, an onended event is triggered. This is a follow-up CL to add tests for it. BUG=970153 Change-Id: Id7bbe6428ae4ac735fe9ac0762a12d41c1b87240 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722834 Commit-Queue: Armando Miraglia <armax@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#681783}
-
Tanmoy Mollik authored
Remove AccountAdder.addAccount usage and replace it with calls to SignUtils.openSettingsForAllAccounts. Bug: 842860 Change-Id: I9187b916f7a8805dcdd7c39d9fca2580bd7eac62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712676Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@google.com> Cr-Commit-Position: refs/heads/master@{#681782}
-
Mohamed Amir Yosef authored
In PasswordStoreX migration_step_pref_ gets destroyed on the UI thread in PasswordStoreX::ShutdownOnUIThread() but there could be already a task posted in PasswordStoreX::UpdateMigrationToLoginDBStep() that would actually consume the destroyed pref. We should invalidate the weak pointer when destroying the migration_step_pref_ to make sure any posted tasks are preempted! Change-Id: I7af97af346c61d352e8a294ce4998e641c8f08f6 Bug: 988417 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722841 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Auto-Submit: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#681781}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1587f23b8531..3fea07b44639 Created with: gclient setdep -r src-internal@3fea07b44639 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I4d437e0c8819dbb86f806aab652a1c70ad409eb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723839Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#681780}
-
Mohamed Abdelhalim authored
This includes removing |pending_nav_entry_id_| from NavigationHandleImpl since it is always equal to the |nav_entry_id_| in NavigationRequest, and neither of them is modified after the creation of the handle. Removing the logic for initializing |reload_type_| and |restore_type_| in NavigationHandleImpl. This does not change the current behavior, since if the |pending_nav_entry_id_| was not 0, this means the |nav_entry_id_| is not 0, and we can simply initialize both |reload_type_| and |restore_type_| in NavigationRequest. Bug: 916537 Change-Id: Ia51aa8d64021e37d81ea20f6328b21315af6be9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715081 Commit-Queue: Mohamed Abdelhalim <zetamoo@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Lowell Manners <lowell@chromium.org> Cr-Commit-Position: refs/heads/master@{#681779}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/41b798cb4e1e..a0ddf25cee99 git log 41b798cb4e1e..a0ddf25cee99 --date=short --no-merges --format='%ad %ae %s' 2019-07-29 treehugger-gerrit@google.com Merge "trace_processor: add tracks table" 2019-07-29 fmayer@google.com Merge "Dump on StopDataSource rather than on Flush." 2019-07-29 skyostil@google.com Merge "client api: Add a way to trace directly to a file" Created with: gclient setdep -r src/third_party/perfetto@a0ddf25cee99 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: I9b8f428cfbf0961bada0b4639059dee07c5325b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724147Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ce4a26a406d3..ef732c88ba08 git log ce4a26a406d3..ef732c88ba08 --date=short --no-merges --format='%ad %ae %s' 2019-07-29 perezju@chromium.org [Telemetry] Fix typo in InvalidOptionsError message Created with: gclient setdep -r src/third_party/catapult@ef732c88ba08 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=simonhatch@google.com Bug: chromium:985712 Change-Id: Ib92aeeb0261891aa579404b0ca1c32dd6b1223f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724110Reviewed-by:
-
Marc Treib authored
After https://crrev.com/c/1642551 this is dead code. Bug: 836718 Change-Id: I6d429f0addaa201876a7fd6c574bb21180b8aef5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719491Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#681776}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9789d9e4..6d7e1dd2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib181e387ecefab66e0419d84d9add06e009145f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723512Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#681775}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/fd6d8d7129ee..ed0febf57383 git log fd6d8d7129ee..ed0febf57383 --date=short --no-merges --format='%ad %ae %s' 2019-07-29 srte@webrtc.org Add k prefix to FrameGenerator::OutputType enum values 2019-07-27 bryanf@microsoft.com Allow use of CroppingWindowCapturer via CreateWindowCapturer Created with: gclient setdep -r src/third_party/webrtc@ed0febf57383 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: Id4d20c4decf579ff32104f7f6f52c40e35a2f3cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724111Reviewed-by:
-
Lutz Justen authored
Disables org.chromium.chrome.browser.sync.ManageSyncPreferencesTest #testPaymentsIntegrationCheckboxEnablesPaymentsIntegration on Android. It's flaky on Nexus 5 devices. TBR=triploblastic@chromium.org,sahel@chromium.org BUG=chromium:987827 TEST=None Change-Id: If5bc156d28dc19f34d6bf2cf13e10ddb2d4ff4a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722961 Commit-Queue: Lutz Justen <ljusten@chromium.org> Reviewed-by: -
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d7e0a36ac618..c405776eb4a0 git log d7e0a36ac618..c405776eb4a0 --date=short --no-merges --format='%ad %ae %s' 2019-07-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/glslang/src 42f813401bdf..7fc868349143 (2 commits) Created with: gclient setdep -r src/third_party/angle@c405776eb4a0 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@google.com Bug: chromium:None Change-Id: I34253ba09aed85e367d13a6c0659d732db12bab7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723088Reviewed-by:
-
Nazerke authored
Bug: 976660. Change-Id: I2b97ebca86494d41b27b29c696eddd75a26f9f67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715278 Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Auto-Submit: Nazerke Kalidolda <nazerke@google.com> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#681771}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ae9673f68e84..41b798cb4e1e git log ae9673f68e84..41b798cb4e1e --date=short --no-merges --format='%ad %ae %s' 2019-07-29 fmayer@google.com Merge "Count invalid packets in TraceStats." Created with: gclient setdep -r src/third_party/perfetto@41b798cb4e1e The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: Iac6f580f3108a160f2fe1d6064f56a9b123254a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723087Reviewed-by:
-
Gabriel Charette authored
Also renamed the types to "Functions" instead of "Callbacks" as the latter is confusing with a properly bound base::Callback where the former clearly denotates a function pointer. This lack of initialization resulted in an access violation instead of using the non-overridden function when tracing is called in contexts where the perfetto override isn't in place yet as part of https://chromium-review.googlesource.com/c/chromium/src/+/1680893 We were simply lucky to get away with until now. R=eseckler@chromium.org Bug: 899897 Change-Id: I815fe5197888c32200cdf5166a0be4fbf79d355a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721071 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#681769}
-
Maksim Sisov authored
This reverts commit 6f370b54. Reason for revert: the CL[1], which resulted in the problem, was reverted. Thus, there is no need to have this anymore. I will keep my eye on the issue and report again if anything. [1] https://crrev.com/c/1685909 Original change's description: > Disable partial swap for gl es type of gl > > Currently, partial swap is disabled on Linux with Mesa drivers and > with gl_type: gl. > > Likely, we could not experience any glitches crrev.com/c/1685909, > but once that CL has been merged, partial swap became broken on > Mesa with OpenGL ES (which Wayland uses). Not sure why it started > to happen, but I can assume that the problem is in the Mesa impl > for Wayland as well. Even though, the spec says Wayland compositor > updates only that part of a surface, which has damage, other parts > of a surface showing black squares. > > One reason behind that might be missing EGL_NV_post_sub_buffer > extension, which we can't test while being in the GPU process > when dma buffers are used. It is required to create an egl > surface to test against that extension. However, the spec > does not say anything about that. Ideally, Wayland compositor > must handle that by itself, make a union of damages and copy > parts of backbuffer to frontbuffer without getting OpenGL > into play, but something bad happens. At this point, > the problem has only been spotted on Mesa drivers. Others > will be tested asap. > > Thus, remove the gl type and enforce the workaround for both > Mesa with OpenGL and OpenGL ES. > > Bug: 983933 > Change-Id: I159627e95f854053956914f57e6299289ef04a74 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705794 > Commit-Queue: Maksim Sisov <msisov@igalia.com> > Reviewed-by: Antoine Labour <piman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#679066} TBR=piman@chromium.org,msisov@igalia.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 983933 Change-Id: Ifadfe27b06c60032753b2a72d43305c622f2f8f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722839Reviewed-by:
Maksim Sisov <msisov@igalia.com> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#681768}
-
Lutz Justen authored
TBR=devlin@chromium.org BUG=chromium:988160 TEST=None Change-Id: Idabe57df448c82dcc596c5e1587ea446984e34ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724075Reviewed-by:
-
A Olsen authored
Trying to change the cryptohome password but supplying the wrong old password, can result in an "OnPasswordChangeDetected" instead of an OnAuthFailure. So, detect either one and treat them both as "incorrect old password", prompting the user to try again. Bug: 930109 Change-Id: I9aae5a52e377215f55ea0f788ff0ffacd2118865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724076Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: A Olsen <olsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#681766}
-
Stephane Zermatten authored
This change fixes the following small bugs: - the argument experiment_ids was not declared for the list_assistant_actions direct action. - there was no way for the caller to specify the user account to use for RPCs, like there is for AA in CCT, which could mean RPCs could fail with 401 in production if the user is not signed into Chrome. list_assistant_actions now has a new parameter for that. - AutofillAssistantPreferencesUtil.isAutofillAssistantSwitchOn() was checked too early, when creating direct action handler, that is, when creating the Activity. This meant that if it ever changed during the Activity's lifetime, the behavior would be incorrect. This change checks it for every call instead. - If, after showing the onboarding, AA couldn't start, we could end up in a state where the onboarding UI was still showing. To solve this, this change transfers control of the UI only once AA is started. If that doesn't happen, the default behavior of OnboardingController triggers, which is to dismiss the UI. Bug: b/138276953 Change-Id: Ibd6ea42c710dc95fb854eea57d5a0b64a585573d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720711Reviewed-by:
Jordan Demeulenaere <jdemeulenaere@chromium.org> Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#681765}
-
Ivana Zuzic authored
Save action is a prerequisite for the future commit that will save the changes made on the password. Bug: 377410 Change-Id: I6482ad013a9fb1acc909a461ceb623f7d809cb3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710315Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ivana Zuzic <izuzic@google.com> Cr-Commit-Position: refs/heads/master@{#681764}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/b110acba9e6f..12af46b649fd git log b110acba9e6f..12af46b649fd --date=short --no-merges --format='%ad %ae %s' 2019-07-24 apodtele@gmail.com * src/base/ftbbox.c (cubic_peak): Sanitize left shift (#56586). 2019-07-22 w1w2y3@gmail.com * src/cid/cidload.c (cid_hex_to_binary): Fix typo (#56653). Created with: gclient setdep -r src/third_party/freetype/src@12af46b649fd The AutoRoll server is located here: https://autoroll.skia.org/r/freetype-chromium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel TBR=bungeman@google.com,drott@google.com,thestig@google.com Bug: None Change-Id: Ice0b7783bb7ea08060e33737791c764ce931c6b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716394Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#681763}
-
Colin Blundell authored
Bug: 970295 Change-Id: I814a69f8e1c841cb0e58253382a568074414d62a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718967 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
-
Victor Hugo Vianna Silva authored
We introduce a feature that when enabled will stop sync from registering controllers for FAVICON_IMAGE and FAVICON_TRACKING data types. Bug: 978775 Change-Id: I8739e001a639c6ab31d4bba51a42c83b69129b61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653428 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#681761}
-
Raphael Kubo da Costa authored
When building HarfBuzz as part of Chromium, there is a single source set with all the files we need in the build. Upstream HarfBuzz, on the other hand, produces a few different libraries: harfbuzz, harfbuzz-icu and harfbuzz-subset. When |use_system_harfbuzz| is true, we were only looking for (and using) harfbuzz.pc with pkg-config even though we also use symbols from libharfbuzz-subset.so. This resulted in errors when linking: ld: obj/skia/skia/SkPDFSubsetFont.o: in function `SkPDFSubsetFont(sk_sp<SkData>, SkPDFGlyphUse const&, SkPDF::Metadata::Subsetter, char const*, int)': SkPDFSubsetFont.cpp:(.text._Z15SkPDFSubsetFont5sk_spI6SkDataERK13SkPDFGlyphUseN5SkPDF8Metadata9SubsetterEPKci+0x48a): undefined reference to `hb_subset_input_create_or_fail' ld: SkPDFSubsetFont.cpp:(.text._Z15SkPDFSubsetFont5sk_spI6SkDataERK13SkPDFGlyphUseN5SkPDF8Metadata9SubsetterEPKci+0x4af): undefined reference to `hb_subset_input_glyph_set' ld: SkPDFSubsetFont.cpp:(.text._Z15SkPDFSubsetFont5sk_spI6SkDataERK13SkPDFGlyphUseN5SkPDF8Metadata9SubsetterEPKci+0x5d7): undefined reference to `hb_subset_input_set_retain_gids' ld: SkPDFSubsetFont.cpp:(.text._Z15SkPDFSubsetFont5sk_spI6SkDataERK13SkPDFGlyphUseN5SkPDF8Metadata9SubsetterEPKci+0x5e4): undefined reference to `hb_subset_input_set_drop_hints' ld: SkPDFSubsetFont.cpp:(.text._Z15SkPDFSubsetFont5sk_spI6SkDataERK13SkPDFGlyphUseN5SkPDF8Metadata9SubsetterEPKci+0x5f3): undefined reference to `hb_subset' ld: SkPDFSubsetFont.cpp:(.text._Z15SkPDFSubsetFont5sk_spI6SkDataERK13SkPDFGlyphUseN5SkPDF8Metadata9SubsetterEPKci+0x66f): undefined reference to `hb_subset_input_destroy' as reported in https://groups.google.com/a/chromium.org/d/msg/chromium-packagers/UyJsVJ5QqWo/jSv5z7-rEQAJ Change-Id: I997af075c7b7263cd7cc71a63db5b0f93bd1ab59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715288 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by: -
Rune Lillesveen authored
Bug: 972752 Change-Id: I61ae4496ac0438e3ebf192dd3f44550e6862748c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722949Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#681759}
-
