- 01 Jul, 2020 40 commits
-
-
Cathy Li authored
Change-Id: I73993e7dd367f68cb9d6f57e18e4615710c0643d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268022 Commit-Queue: Cathy Li <chili@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Auto-Submit: Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#784518}
-
Becca Hughes authored
This is a reland of 87f410b6 TBR=steimel@chromium.org Original change's description: > Public side of Windows fix > > BUG=1099250 > > Change-Id: Ia73ff41012a1e4d9a7a524339ea30e0c327f1fe4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269510 > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#784168} Bug: 1099250 Change-Id: Ide88c07fe6ea556b5eaf3c8951d23fe6c69a6c6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277115 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#784517}
-
Michael Hansen authored
This lowers the interval for Fast Initiation advertising, and then restores it to a reasonable default when advertising stops. See design document: go/nearby-chrome-bt. Bug: b:154846208 Change-Id: I02720b0ee50ee2bd48f62c010d8da10b8aa6ed2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264623Reviewed-by:
Miao-chen Chou <mcchou@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Michael Hansen <hansenmichael@google.com> Cr-Commit-Position: refs/heads/master@{#784516}
-
Meilin Wang authored
Bug: b/160202872 Test: unittest. Change-Id: I355c704fd2adda7d96dfbb3c972964e2da7a1e6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275342 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#784515}
-
Shengfa Lin authored
Once/Repeating For audio_video_pipeline_device_unittest.cc, changed Bind and Closure to BindOnce and OnceClosure. Modified pass by reference to pass by value for OnceClosure and use std::move when transferring ownership Bug: 1007649 Change-Id: I079c26b8636b451768572ffe355da5ec3325c644 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275337Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Shengfa Lin <shengfa@google.com> Cr-Commit-Position: refs/heads/master@{#784514}
-
Andrew Walbran authored
This adds support for the analog mode, handles thumbstick buttons which give incorrect keycodes on old versions of Android, and marks the mapping as standard. The Android mapping of the thumbstick buttons was fixed in https://android-review.googlesource.com/c/platform/frameworks/base/+/1331927, so the fixed keycodes are also supported. BUG=1073130 Change-Id: Id14e3c7f5d5b35aa565d374860257d1f0960abbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245482 Commit-Queue: Andrew Walbran <qwandor@google.com> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#784513}
-
Theresa Wellington authored
Record two new histograms: - Android.PlayServices.Installed - Android.PlayServices.Version Bug: 1099935 Change-Id: I3c91120650c84d791634196b0a651828a38c0a1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2271109 Auto-Submit: Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#784512}
-
Nate Chapin authored
* Remove Document's IsSandboxed()/GetSandboxFlags(), use the LocalDOMWindow variant instead. * Prefer ExecutionContext/LocalDOMWindow variants to accessing the state on SecurityContext directly *unless* the code needs to handle RemoteFrames, in which can Frame::GetSecurityContext() is the canonical path to accessing state from a SecurityContext. Bug: 1101402 Change-Id: Iffe29c58210b97aa3c6c34fdcc9350b311aad11f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276616 Commit-Queue: Nate Chapin <japhet@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#784511}
-
Eric Orth authored
Move recording of Net.DNS.DnsTransaction.*.*.FailureError to ResolveContext::RecordServerFailure() which is called for all server errors and timeouts rather than just errors where a response is still received. Also fix a bug where ResolveContext::RecordServerFailure() was not being called for all the errors it should be called for. Bug: 1101073 Change-Id: I1e4032589b3ad1cab0e9cfe6f3bc7acc30c7dcca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276651Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#784510}
-
Fabrice de Gans-Riberi authored
This reverts commit 3fd89cb3. Reason for revert: Broke android-archive-rel. https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/12848 Original change's description: > Greatly expanded code coverage for cast_auth_util fuzz tests. > > Bug: 796717, b/149843583 > Change-Id: Iee9b406604c923d6109cc9f2391effedb33043d1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252691 > Commit-Queue: John Williams <jrw@chromium.org> > Reviewed-by: Doug Steedman <dougsteed@chromium.org> > Reviewed-by: mark a. foltz <mfoltz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#784502} TBR=mfoltz@chromium.org,dougsteed@chromium.org,jrw@chromium.org Change-Id: I99a5388d1b1a3f7d7b2b94a8d06d734e526dc74c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 796717, b/149843583 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278141Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#784509}
-
Fabrice de Gans-Riberi authored
CreativeOriginAdsPageLoadMetricsObserverBrowserTest. CreativeOriginStatusWithThrottlingNestedUnthrottled is flaky on all platforms. Bug: 1099545 TBR=csharrison@chromium.org Change-Id: I823d40894971135d5f5b719eae93a76c78a5052e Change-Id: I2303432fb48cbf4bc4833535cc668fb639f9ba78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278097Reviewed-by:
-
Xinghui Lu authored
This new widget is based on the existing RadioButtonWithDescription widget. It has a separator and an expand arrow on the right. The enabled state of the aux button can be set independently of the enabled state of the entire widget. Screenshots: Both enabled: http://screen/vnEEsHFn22Z Both disabled: http://screen/H1LbVu0yCSY Widget disabled, arrow enabled: http://screen/tkVoWBSuy6M Widget enabled, arrow disabled: http://screen/xKChak8vczO Mocks: go/esb-clank-dd Bug: 1097310 Change-Id: I697712ca46a7f8a6c929d3b39df3c178499c0202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259772 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/master@{#784507}
-
Christian Larson authored
Updated MFVideoCallback to have a shutdown method to invalidate the pointer to the observer_. Shutdown is needed because MFVideoCallback is a refcounted class and can live longer than the raw pointer to observer_. Added test to validate the crash before the fix and that the code update fixes the issue. Bug: 1099934 Change-Id: I1a80914f720638a4fda2d2155b547ec12bafd08a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275493Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Christian Larson <chrila@microsoft.com> Cr-Commit-Position: refs/heads/master@{#784506}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/b112fac0033c..57002d0447df 2020-07-01 johnkslang@users.noreply.github.com Merge pull request #2307 from KhronosGroup/location-validation 2020-07-01 johnkslang@users.noreply.github.com Merge pull request #2306 from ben-clayton/licenses If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,ianelliott@google.com Change-Id: Ic6f558c71e0418c24a136bd2fdc40ca2f67159e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278013Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784505}
-
Sinan Sahin authored
Bug: 1075640, 1088071 Change-Id: I0bfefc0574a66af4d30754ee37c9b6fc709175ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276671Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#784504}
-
Fabrice de Gans-Riberi authored
The test is flaky. Bug: 1100888 TBR=caseq@chromium.org Change-Id: Ie7e0f3ced487e9b75cd78b52ce42aece547cb399 Change-Id: Ieb252751cdddf7c5715820f3e339c3a841843c50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277116Reviewed-by:
-
John Williams authored
Bug: 796717, b/149843583 Change-Id: Iee9b406604c923d6109cc9f2391effedb33043d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252691 Commit-Queue: John Williams <jrw@chromium.org> Reviewed-by:
Doug Steedman <dougsteed@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#784502}
-
Mikhail Khokhlov authored
The Telemetry platform interface has changed recently to allow more user control over performance mode. This CL switches the startup.mobile benchmark to the new interface. Bug: chromium:1096589 Change-Id: I38b6627a8620f8822fe2c7cab2b9e7fa416d2a61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277728Reviewed-by:
Egor Pasko <pasko@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#784501}
-
Filip Gorski authored
This reverts commit 973a3636. Reason for revert: Newly added testEdgeSwipeIsNoopInTabSwitcher fails consistently on Lollipop Tablet Tester here: https://ci.chromium.org/p/chromium/builders/ci/Lollipop%20Tablet%20Tester Original change's description: > GestureNav: Detach layout when cancelled > > SideSlideLayout is a frame layout enclosing the arrow widget/glow UI > used in gesture navigation. It gets detached from view hierarchy after > use. There is a bug not detaching the layout if navigation UI is > cancelled/not triggered. This CL makes sure the layout is detached so > unnecessary views won't stay in the hierarchy when not in use. Added > tests to verify the behavior. > > Bug: 1100717 > Change-Id: I129ec5fe84d14023532bf5e0dd6a110ea84e354d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274498 > Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> > Reviewed-by: Donn Denman <donnd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#783887} TBR=donnd@chromium.org,jinsukkim@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1100717 Change-Id: Ifc1d77f5aedf65415f2c413f1e59e5bc35a5e242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278077Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#784500}
-
Albert J. Wong authored
The last implementation accidentally caused an AtomicString to be created even if externalization was not possible. The new code only generates an AtomicString when externalization can happen. This is broken out of https://chromium-review.googlesource.com/c/chromium/src/+/2204539 which in turn is broken out of https://chromium-review.googlesource.com/c/chromium/src/+/1557854 Bug: 1083392 Change-Id: I091872fcd0f8cf26d6d6e1a0fac4a3e115f7543b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268584Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
-
wutao authored
Previously we download one photo and display it and then discard the photo. However when the access token expires, we cannot get photo link info anymore. This patch saves previous downloaded photos to disk and then cycle through those photos for a longer time span. Bug: b/156919253 Test: new unittests Change-Id: I6a0bd0b3f69e1e6c3d950c158960071dfce122c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207755 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=bindusuvarna@chromium.org Change-Id: I063eb2c29ef5a8740b34bfd70fc3efb050560117 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278136Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784497}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5843fee4e7c1..0512adcf9ed5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1090082 Tbr: Change-Id: I655256007be33b07b3f1389096fff87213840840 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278010Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784496}
-
Robert Sesek authored
GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: 1052560 Change-Id: Ic9abb03711c95a6fb9d501b68b9e3a40edd26d01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276687 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#784495}
-
Leonid Baraz authored
1) Make StorageModule to be instantiated only by factory method 2) Make StorageModule overridable by TestStorageModule 3) Allow TestStorageModule to be constructed directly In the process I started to adjust tests, and ended up with rather significant refactoring there too: 4) Use TestEvent instead of callback_ and result_ in the test class; it allows to make multiple calls in the same test fixture (not happening right now, but will likely be needed in the future). 5) Eliminate specialized test classes and use MOCK_METHOD + ON_CALL + optionally WillByDefault to achieve the same result. This makes sure that later changes in one test class are not skipped in another - we now have only one. Bug: b:153364303 Change-Id: I4f7bcc956380c8b313ca4c2dc1f5ee6c716f586c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277505Reviewed-by:
Zach Trudo <zatrudo@google.com> Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#784494}
-
Robert Sesek authored
GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: 1052560 Change-Id: I172aa483c71f880b78668f857b8378ee1b9fe562 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276659 Commit-Queue: Kenneth Russell <kbr@chromium.org> Auto-Submit: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#784493}
-
David Bertoni authored
This test was disabled on Linux, Windows, and Mac debug. It passed 3000 iterations on Linux and Windows, and 600 iterations on Mac debug without flakes. Bug: 253417 Change-Id: Id71ceac3a8b5ae43145f93935b92851fbe8d04e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255661Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#784492}
-
Xiaohan Wang authored
Microsoft::WRL::ComPtr<T>::GetAddressOf() is banned due to the ease of causing memory leaks. Also replace CopyTo(foo.GetAddressOf()) with As(&foo) since CopyTo(&foo) does not work if we are copying to different interfaces. Also replace QueryInterface(foo.GetAddressOf()) with QueryInterface(IID_PPV_ARGS(&foo)). Bug: 914910 Change-Id: I9bec0dbdc7e22519e7e5a31d93ef31ca9a654265 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2271522Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#784491}
-
zhaoyangli authored
These tests fail on an internal builder. Bug: 1101099 Change-Id: I93d08ee2c6fd5206fc4f026a94a262876d8a1cdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276709 Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#784490}
-
Francois Beaufort authored
This CL allows users to see if a camera device supports PTZ in the the about:media-internals page. Bug: 934063 Change-Id: I85ae1c13799e5030457afaeb1201743536832cc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277732Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#784489}
-
Katie D authored
This is launching in M86. Flag can be removed in M87+ if all goes well. AX-Relnotes: Exposes custom cursor color setting and feature Bug: 1094071 Change-Id: I999d87631a1441e85f149f80540a2fde8acff11a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278085Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#784488}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d2ca995f88ba..8804d35c9a09 2020-07-01 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 7c1434b8ea35 to 7ff733fd65d7 (6 revisions) 2020-07-01 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from fc0dc3a9c734 to fba90d6b0a23 (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: I2a1f42739ba13b5de1ab40c8a30adb7de073dfc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278012Reviewed-by:
-
Aya ElAttar authored
Changed PolicyMap::Set to use the newer version with value parameter passed as base::Value instead of unique_ptr. Bug: 2270317 Change-Id: I6aa11ff068e19ab9017d63c116c3f830b1643a8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275881Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Parastoo Geranmayeh <parastoog@google.com> Commit-Queue: Aya Elsayed <ayaelattar@google.com> Cr-Commit-Position: refs/heads/master@{#784486}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Id0bfd89b05bc8f503bd436f54760cb5fbbfdf1b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278082Reviewed-by:
-
Lijin Shen authored
This CL adds a command line argument to allow disabling default browser promo on builds. Bug: 1099714, 1090103 Change-Id: I7c2db4def8f0ea4b3572d94e3c495d3bdd3b8d13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277042 Commit-Queue: Lijin Shen <lazzzis@google.com> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ia0bd2fc776dd459b42f3a9f6d7583909a8475467 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278063Reviewed-by:
-
Robert Sesek authored
GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: 1052560 Change-Id: I6a0e4f1c679d72cb799374dc1e20b93a71b872cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277975 Commit-Queue: Robert Sesek <rsesek@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Robert Sesek <rsesek@chromium.org> Reviewed-by:
-
Fabrice de Gans-Riberi authored
This reverts commit 30df8d48. Reason for revert: Broke linux-chromeos-chrome compile. See https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/6735 Original change's description: > Refactor platform keys service token ID > > This CL changes how platform keys service expects token IDs from the > service consumers and makes it clear what to expect in special cases > like empty/unprovided token IDs. > > Before this CL, platform keys service was accepting token IDs as strings > which is not as clear as enums especially for the cases of empty > strings. > > Bug: 1073512 > Change-Id: I4cbdfdc8f22b23ce0297314915e52804b2e495f3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270069 > Commit-Queue: Omar Morsi <omorsi@google.com> > Reviewed-by: Pavol Marko <pmarko@chromium.org> > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > Reviewed-by: Michael Ershov <miersh@google.com> > Cr-Commit-Position: refs/heads/master@{#784448} TBR=emaxx@chromium.org,pmarko@chromium.org,miersh@google.com,omorsi@google.com Change-Id: Ib163fce34664943e586b43a8c4a9f79eb59be260 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1073512 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277117Reviewed-by:
-
Nate Chapin authored
Bug: 1029822 Change-Id: Id57510e812405bdd453adbbb0b2d23c96a2fc34c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274721Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fdee3989..9e077af8 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If528c8ad5193fd08196c0d0188fca23605073c82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277663Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784479}
-
