GitLab

TBR=bokan@chromium.org
TEST=waterfall
BUG=372226

Review URL: https://codereview.chromium.org/272403003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269717 0039d316-1c4b-4281-b951-d872f2087c98

Handle TemplateURLService load failure better, and make some test correctness fixes that will be needed later.

This also does a variety of miscellaneous cleanups to the modified files.

BUG=364183
TEST=none
R=jered@chromium.org, pkasting@chromium.org
TBR=engedy

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269329

Review URL: https://codereview.chromium.org/272573004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269716 0039d316-1c4b-4281-b951-d872f2087c98

missing from uploaded crashes.

BUG=371817

Review URL: https://codereview.chromium.org/275213003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269715 0039d316-1c4b-4281-b951-d872f2087c98

BUG=356791

Review URL: https://codereview.chromium.org/238863005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269714 0039d316-1c4b-4281-b951-d872f2087c98

This is already initialized by CocoaProfileTest.

BUG=365762
TBR=asvitkine@chromium.org

Review URL: https://codereview.chromium.org/276063003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269713 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269709 0039d316-1c4b-4281-b951-d872f2087c98

BUG=367366

Review URL: https://codereview.chromium.org/263003003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269707 0039d316-1c4b-4281-b951-d872f2087c98

Looks simpler that way instead of having the action that generates the
pak file and the header files separated.

BUG=None
TEST=None
R=jamescook@chromium.org,jochen@chromium.org

Review URL: https://codereview.chromium.org/273783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269706 0039d316-1c4b-4281-b951-d872f2087c98

BUG=364141, 330264
TBR=jamescook@chromium.org, michaelbai@chromium.org

Review URL: https://codereview.chromium.org/261363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269705 0039d316-1c4b-4281-b951-d872f2087c98

without having access to the core Mojo system. Currently the only reason
these files depend on core is to get kInvalidHandle, but there's no such
constant on the C++ side anymore.

This CL replaces core.kInvalidHandle with |null| and teaches the handle
converters how to convert null to and from an invalid handle.

R=sky@chromium.org
BUG=372065

Review URL: https://codereview.chromium.org/278093003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269704 0039d316-1c4b-4281-b951-d872f2087c98

BUG=368034

Review URL: https://codereview.chromium.org/259863007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269703 0039d316-1c4b-4281-b951-d872f2087c98

This reverts http://crrev.com/216313007.

Re-rastering a layer with text during a scale animation can cause
many texture uploads during the animation (as new glyphs are generated
at each scale).

To re-enable this behavior in the future, we need to either make it
dependent on distance-field fonts, or we need a way to reuse glyphs
during scale animations (allowing text to become slightly blurry rather
than generating new glyphs every frame).

BUG=366225

Review URL: https://codereview.chromium.org/272283003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269701 0039d316-1c4b-4281-b951-d872f2087c98

"Multiple display test does not work on Windows bots. Please skip (don't
disable) the test using SupportsMultipleDisplays()"

Previously, this message only showed on Windows 8 if you forget to check
SupportsMultipleDisplays in a test with multiple displays. Now it shows
on Windows 7 as well.

Without this message, you get a much more confusing crash.

BUG=370796

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268933

Review URL: https://codereview.chromium.org/270253003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269700 0039d316-1c4b-4281-b951-d872f2087c98

TBR=hinoka@chromium.org
BUG=

Review URL: https://codereview.chromium.org/275313003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269696 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269692 0039d316-1c4b-4281-b951-d872f2087c98

Nothing is used from favicon_service.h, so remove the include.

BUG=371821

Review URL: https://codereview.chromium.org/278913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269690 0039d316-1c4b-4281-b951-d872f2087c98

TBR=bruening@chromium.org
BUG=372177

Review URL: https://codereview.chromium.org/278193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269689 0039d316-1c4b-4281-b951-d872f2087c98

Avoids releasing capture in EndMoveLoop if capture was switched to another window while dragging.
This variant relies on checking if a drag input window still has capture before releasing the grab.
A better alternative is in CL https://codereview.chromium.org/262893002/.

TBR=sadrul@chromium.org
BUG=363503
TEST=Follow the exact steps in the bug description.
TEST=interactive_ui_tests --gtest_filter=*TabDragging*

Review URL: https://codereview.chromium.org/272363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269688 0039d316-1c4b-4281-b951-d872f2087c98

BUG=362608

Review URL: https://codereview.chromium.org/274183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269687 0039d316-1c4b-4281-b951-d872f2087c98

Introduce a BrowserContextKeyedService to collect logs from the PasswordManagerClient instances, and distribute them to PasswordManagerInternalsUI instances for display. The service will also ensure that nothing is logged in Incognito profiles, and that logs are flushed as soon as no one is displaying them.

Except for checking the incognito bit, the whole functionality is implemented in the LogRouter class inside the password_manager component, for easy code sharing across platforms.
The service inherits from LogRouter, and adds nothing except for leveraging the BrowserContextKeyedServiceFactory framework to keep the functionality from OTR profiles.

This CL only introduces the service, it does not put it to use (outside tests) yet.
For that there will be another CL (https://codereview.chromium.org/269513003, but WIP, not fit for (re)viewing yet).
Yet another CL deals with renaming PasswordManagerLogger to LogReceiver: https://codereview.chromium.org/264793010/

Design doc: https://docs.google.com/document/d/1ArDhTo0w-8tOPiTwqM1gG6ZGqODo8UTpXlJjjnCNK4s/edit?usp=sharing#heading=h.cqh4wuj8j4yl

BUG=347927

Review URL: https://codereview.chromium.org/262583007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269686 0039d316-1c4b-4281-b951-d872f2087c98

This message can only affect RenderWidgetHostImpl::WaitForSurface, which
is only called on Mac. However, it is never sent on mac. So just remove
it.

BUG=None

Review URL: https://codereview.chromium.org/273113005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269685 0039d316-1c4b-4281-b951-d872f2087c98

BUG=363732
TEST=MaximizeModeControllerTest.Screenshot
TEST=When device is in maximize mode, hold volume down and press power to take a screenshot.

Review URL: https://codereview.chromium.org/263813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269684 0039d316-1c4b-4281-b951-d872f2087c98

TBR=bruening@chromium.org
BUG=NONE

Review URL: https://codereview.chromium.org/274343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269683 0039d316-1c4b-4281-b951-d872f2087c98

CUTOFF_ALLOW_NICE_TO_HAVE was only triggered for --force-gpu-rasterization.
This patch triggers it when the active or the pending tree uses GPU
rasterization. In case of a transition between CPU and GPU rasterization it
is preferrable to pre-paint less on the CPU rasterized tree (which may
checkerboard) than it is to pre-paint more on the GPU rasterized tree (which
may stall the browser compositor).

This patch depends on https://codereview.chromium.org/270823003/

R=enne@chromium.org, alokp@chromium.org
BUG=368884

Review URL: https://codereview.chromium.org/272033002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269682 0039d316-1c4b-4281-b951-d872f2087c98

ActiveScriptController tracks all running active scripts (content scripts and
scripts injected via tabs.executeScript), and, if the flag is enabled, ensures
an ExtensionAction is displayed in the location bar.

Next step: Require permission before executing scripts.

TBR=sky@chromium.org (mechanical, no-impact changes to c/b/ui)

BUG=362353

Review URL: https://codereview.chromium.org/270153004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269681 0039d316-1c4b-4281-b951-d872f2087c98

This CL removes BrowserPluginGuestManager entirely, leaving BrowserPlugin relying on the BrowserPluginGuestManagerDelegate interface. This CL significantly reduces complexity in content.

In a subsequent patch, BrowserPluginGuestManagerDelegate will be renamed BrowserPluginGuestManager. I am leaving that separate so it is clear what's going on.

BUG=364141, 330264

Review URL: https://codereview.chromium.org/269113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269680 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269679 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=173750:173822&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/276143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269678 0039d316-1c4b-4281-b951-d872f2087c98

BUG=372069

Review URL: https://codereview.chromium.org/280063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269677 0039d316-1c4b-4281-b951-d872f2087c98

BUG=365966

Review URL: https://codereview.chromium.org/273953002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269676 0039d316-1c4b-4281-b951-d872f2087c98

Flush() already accomplishes pausing by releasing all data and not
reading until Preroll() is called.

BUG=110814

Review URL: https://codereview.chromium.org/271923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269675 0039d316-1c4b-4281-b951-d872f2087c98

These are setup to have almost no cpu-time noise. There is
always only one frame source, and we either scroll 4 times
or wait for 10 seconds worth of frames.

Since these are jsbin pages, I've added a '?' label to give
the URL more meaning.

BUG=None

Review URL: https://codereview.chromium.org/250813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269674 0039d316-1c4b-4281-b951-d872f2087c98

No functional changes yet, just preparation for splitting NaCl's fork
delegate into two different implementations.

BUG=364945

Review URL: https://codereview.chromium.org/269413004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269673 0039d316-1c4b-4281-b951-d872f2087c98

BUG=348531

Review URL: https://codereview.chromium.org/267703003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269672 0039d316-1c4b-4281-b951-d872f2087c98

BUG=349065

Review URL: https://codereview.chromium.org/233623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269671 0039d316-1c4b-4281-b951-d872f2087c98

UMA for the data reduction proxy was gated behind preprocessor
directives that resticted the logic to Android and iOS. This
change opens UMA calculations and collection up to all platforms.

BUG=369619

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269026

Review URL: https://codereview.chromium.org/266033002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269670 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269669 0039d316-1c4b-4281-b951-d872f2087c98

Contains fixes for uniform structure packing and polygon offset.

Review URL: https://codereview.chromium.org/271173003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269668 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Android-side of insertion/selection handles visibility. (https://codereview.chromium.org/188023002/)

Reason for revert:
There are a number of cases where this incorrectly hides the selection/insertion
handles in an editable node.

Original issue's description:
> Android-side of insertion/selection handles visibility.
> 
> This patch relies on other two patches:
> https://codereview.chromium.org/177903010/
> https://codereview.chromium.org/186753002/
> to correctly compute the visibility of selection and
> insertion handles when editing text input, text area
> and contenteditable elements.
> 
> BUG=236033
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258839

BUG=372056
TBR=tedchoc@chromium.org

Review URL: https://codereview.chromium.org/278923003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269667 0039d316-1c4b-4281-b951-d872f2087c98

This changes the ExtensionDownloader to attempt multiple
sequential queries for CRX downloads, iterating over incremental
values for the authuser query parameter up to a max of 10.

This is a re-landing of http://codereview.chromium.org/279453002/
which was reverted due to a use-after-free bug in the unit tests.

BUG=370964
R=asargent@chromium.org

Review URL: https://codereview.chromium.org/274263002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269666 0039d316-1c4b-4281-b951-d872f2087c98