- 09 Oct, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/cef11fda71f6..be83c310e3d5 git log cef11fda71f6..be83c310e3d5 --date=short --no-merges --format='%ad %ae %s' 2019-10-08 ehmaldonado@chromium.org git-hyper-blame: Make tests run on Python 3. Created with: gclient setdep -r src/third_party/depot_tools@be83c310e3d5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1009809 Change-Id: Ib625d4372f0512f92a2d13597b8ec490b61283f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848456Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704040}
-
Joel Hockey authored
TBR=ellyjones@chromium.org Bug: 1012169 Change-Id: I66512bdab46358e96bbcf90e3fd056bc8468bdea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847704 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Julian Watson <juwa@google.com> Cr-Commit-Position: refs/heads/master@{#704039}
-
Rob Paveza authored
By presenting an interstitial dialog (like Ctrl+P), keyboarding users might get to a point where they can't put focus back into the styles pane. This is because tabIndex is set to -1 for all of the style blocks. Typically, losing focus causes the styles list to reset the first style block to tabIndex=0, but only if the style container doesn't already have focus. Because of an event ordering issue, the styles still have focus before the interstitials receive focus. This change allows the styles tree elements to reset the styles when they lose focus. Bug: 963183 Change-Id: I227c48fd88dbe46bbebc982b0c6e10232769d860 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842521Reviewed-by:
Lorne Mitchell <lomitch@microsoft.com> Commit-Queue: Robert Paveza <Rob.Paveza@microsoft.com> Cr-Commit-Position: refs/heads/master@{#704038}
-
Hiroki Nakagawa authored
CompositorWorker API was already removed in favor of AnimationWorklet API. Bug: 746212 Change-Id: I6e7fcfbeb4a0967442081a9f8a6eff6d39e1d85d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847462Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#704037}
-
Nicholas Hollingum authored
This change works by keeping track of a requested removal time and fading out the spinner over that duration. This is a continuation of crrev.com/c/1830254. The external API of this class is preserved, w.r.t. HasApp() calls and the like, but internally the controller will only actually evict its items once the fade-out animation has completed. Bug: 922977 Change-Id: Ief07b33157403d2141187558dabd866a7ebbbd5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837323Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#704036}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d01ae535b36c..7de9f95df905 git log d01ae535b36c..7de9f95df905 --date=short --no-merges --format='%ad %ae %s' 2019-10-09 efoo@chromium.org Add COMPONENT and TEAM information in OWNERS file Created with: gclient setdep -r src/third_party/angle@7de9f95df905 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@google.com Bug: chromium:977050 Change-Id: I02d9a5607be907ca865993370f10d2a1602768ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848455Reviewed-by:
-
John Delaney authored
This CL adds a boolean histogram that records true if an intervention did not occur due to being over the per-origin limit of the heavy ad intervention. This metric is important to monitor what percent of interventions are lost due to the imposed limits. Bug: 1012440 Change-Id: I28d5abaac8af3e80732478a5f2ca529ee7993520 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846318 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#704034}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/4e7bc8cf04b5..5eaaf59c1774 git log 4e7bc8cf04b5..5eaaf59c1774 --date=short --no-merges --format='%ad %ae %s' 2019-10-09 chrome-bot@chromium.org Update config settings by config-updater. 2019-10-08 lamontjones@chromium.org config: update configs to reduce skew. 2019-10-08 zamorzaev@chromium.org cbuildbot: Respect disabling HWTests. 2019-10-08 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@5eaaf59c1774 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Iddcaa87725b2bd3f8771a1cb8977071fd6ab5100 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848458Reviewed-by:
-
Rohit Rao authored
BUG=934252 Change-Id: Icf5009055afa0b4d83ece18022746c5bd373aafa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848771Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#704032}
-
Nancy Wang authored
This reverts commit ae4de2d6. Reason for revert: <INSERT REASONING HERE> Original change's description: > Update uninstall dialog heading from Remove to Uninstall. > > Currently, the uninstallation dialog head text is inconsistency for the > ARC apps and extension apps. ARC apps use Uninstall, and Remove for the > shortcut only, because for the shortcut, ARC apps use the extension > apps' IDS_EXTENSION_UNINSTALL_PROMPT_HEADING. Per request from the bug, > change the head text from Remove to Uninstall, and remove the quotes. > Linux apps use Uninstall as well, so I think Uninstall sounds better. > > BUG=1010303 > TBR=rdevlin.cronin@chromium.org > > Change-Id: I0e939943c37c295ebe2c8a73824c235420a98195 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844756 > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Commit-Queue: Nancy Wang <nancylingwang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#704004} TBR=rdevlin.cronin@chromium.org,dominickn@chromium.org,nigeltao@chromium.org,nancylingwang@chromium.org Change-Id: I4a037d6c8fc2141bc6fac60c78550d5583f734e6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1010303 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847465Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#704031}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/139e88015cb5..df2726ee7a36 git log 139e88015cb5..df2726ee7a36 --date=short --no-merges --format='%ad %ae %s' 2019-10-08 jcgregorio@google.com Revert "Another attempt to fix vpython in Cloud Build." 2019-10-08 robertphillips@google.com Add GrRenderTask and GrOp prePrepare framework Created with: gclient setdep -r src/third_party/skia@df2726ee7a36 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Bug: chromium:993053 Change-Id: Ic60725d041f89df912fb4562ba8e2922339aa849 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848544Reviewed-by:
-
Rakina Zata Amni authored
Bug: 1011694 Change-Id: If6610901703899d0f54aa44fdcc4cacb7fdb434d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846891Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#704029}
-
Julie Jeongeun Kim authored
This CL converts SpellCheckPanelRequest and SpellCheckPanelPtr in spellcheck_panel.mojom using PendingReceiver, ReceiverSet, and Remote. Bug: 955171 Change-Id: I145e80e71f152f6ac621299d5c2918bf174a8614 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845131Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#704028}
-
Kenneth Russell authored
Should be passing now that ANGLE has rolled forward. Tbr: jdarpinian@chromium.org Bug: 1011653 Change-Id: Ib889a711406026d7742b912b72a074ac96890966 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848547Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#704027}
-
Stefan Zager authored
Change-Id: I462d24c87b55710ceb1981833648545198449522 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848414Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#704026}
-
Mounir Lamouri authored
In practice, it means: - https://www.example.com => example.com - http://www.example.com => example.com - https://m.example.com => m.example.com Bug: 1011900 Change-Id: I9713dd22693e35c67ecdebdca67f4642442d2c3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846472Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#704025}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/6e9395c6b785..e1092c0bc8b8 git log 6e9395c6b785..e1092c0bc8b8 --date=short --no-merges --format='%ad %ae %s' 2019-10-08 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision a78cc9b4..b2d00427 (703818:703937) Created with: gclient setdep -r src/third_party/webrtc@e1092c0bc8b8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Ibd75fcaa785ba3fd7988a9aa2c74da3a214fef62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848499Reviewed-by:
-
John Lee authored
This updates the pinned tabs' dimensions to be dependent on the variable that controls an unpinned tab's height to prevent their dimensions from becoming out of sync when an unpinned tab's size changes. https://imgur.com/a/48J3hJF Bug: 989131 Change-Id: Ibfd7e45550a4d0490a28878c0d13884cf90f86bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848057 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#704023}
-
John Z Wu authored
It would be more flexible for //ios/web_view to leave consent handling to its clients. Bug: 1008677 Change-Id: I66b3a71f4466bf349cd782361fbe139c93affef7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845668Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#704022}
-
dpapad authored
It is only used by files under that folder. Bug: None Change-Id: Ic5a9a94b16e4a2f61b7b0470aee337514525852c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847680 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#704021}
-
Evan Stade authored
Don't create the storage partition until it's actually needed in DispatchReport(). Bug: 1011889 Change-Id: I9da607cceb7504642731e8afdc987bd0f90aa497 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845807 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#704020}
-
Sanket Joshi authored
Bug: 1010148 Change-Id: Ie4f14e8ed8d68e618a1afc7c60ad258f89342146 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834118Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
-
Miguel Casas authored
This CL adds a |min_resolution| field to VideoEncodeAcceleratorSupportedProfile and propagates it from its source(s) in the GPU process, via the |gpu_info| mojom interface definition, to its ultimate users: MediaRecorder and RTCVideoEncoder (the latter is used for WebRTC's PeerConnection). This new field is populated from VaapiWrapper to indicate that we should not use it for small resolutions (currently 320x240); software encoding should be used instead. This CL also wires this new field in the chrome:gpu informational UI. TEST=https://codepen.io/miguelao/pen/wzVMJb on nocturne (pixel slate), enable logging and verify that MediaRecorder doesn't use the encode accelerator, e.g. for 320x240 camera capture. Bug: 1008491 Change-Id: Ifb19232ca5a5bbbde0ba42e1c28de72e46dafc5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828078 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#704018}
-
Xiaoqian Dai authored
The class is getting large so put it into its own files. No functional change in this CL. Bug: 997885 Change-Id: Ie55ab03b1785fdb2ae4cbb3c930f7c2ac5aaf2a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848475 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#704017}
-
Robert Liao authored
The Relayout() code has been moved a lot. The comment is now current as of this revision BUG= TBR=thomasanderson@chromium.org Change-Id: Ieb391af093a40a9b42dbfbbfc1e6160ab6c93547 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848581Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#704016}
-
Mounir Lamouri authored
In practice, it means: - https://www.example.com => example.com - http://www.example.com => example.com - https://m.example.com => m.example.com This is implemented at the Media Session level which should affect all usage of it. Bug: 1011900 Change-Id: Id3007daebe200ed6b4ccf3d574e5b15ba8424903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846658Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#704015}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/fa588881c5b5..c6dbc23aeca4 git log fa588881c5b5..c6dbc23aeca4 --date=short --no-merges --format='%ad %ae %s' 2019-10-08 crouleau@chromium.org [Telemetry] run_benchmark list should not use expectations.config. Created with: gclient setdep -r src/third_party/catapult@c6dbc23aeca4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sadrul@google.com Bug: chromium:985103 Change-Id: Ib4f01f050178c37faaf75545b2f98581d8cdb78e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846770Reviewed-by:
-
Klaus Weidner authored
WebXR's immersive-ar mode was ignoring UpdateLayerBounds messages, and framebufferScaleFactor changes caused a size mismatch and GL error. Process these messages and resize the transfer buffer appropriately, and keep this separate from the camera image size which isn't affected by framebufferScaleFactor. Change-Id: I43db087cd1a9e5c03f9be6a9e4ca6e0fb61007c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848369 Commit-Queue: Klaus Weidner <klausw@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#704013}
-
Julie Jeongeun Kim authored
This CL converts mojo::StrongBindingPtr to SelfOwnedReceiverRef for network::mojom::NetLogExporter. Bug: 955171 Change-Id: I2848046e08671405f7c0940da775008e89498e37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846616Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#704012}
-
Bailey Berro authored
div for the dialog-title slot was mismatched, resulting in a bug where the error would not show. Bug: 1011586 Change-Id: Id35c21c1a5ff6c2c60845cd1f736fe713e301c23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848479 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Auto-Submit: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#704011}
-
Julie Jeongeun Kim authored
This CL converts PdfToEmfConverterClient, PdfToEmfConverter, and PdfToEmfConverterFactory to new mojo types using PendingRemote, Remote. Receiver, and PendingReceiver. Bug: 955171 Change-Id: I9e76d7b9360856e7f415ec24d408fd9d6a21e227 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827276Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
-
Arno Renevier authored
Implement compression for "gzip" and "deflate". That implementation is hidden behing ExperimentalCompressionStream flag. For unit tests, we compress and stream and uncompress it with pako, and we make sure its output is the same as our original data. Change-Id: I89dde0e06a07b695be93a3b4f81fa6b3ee80d760 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763344 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#704009}
-
Min Qin authored
This will help us analyze why parallel download failed in some cases. BUG=1011427 Change-Id: Ib8fbe5a69ce1486f5516c21e737b008c8e76a1c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848368 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#704008}
-
Wei Li authored
FullPanel has two child views which takes up 75% and 25% of the total width. This can be done by box layout manager instead of manually override Layout(). This CL refactors it into using a layout manager. BUG=1005568 Change-Id: Iaf01ebc6be64f449f793e60913bb1bf1ddca629f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848473 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
-
Julian Watson authored
Change-Id: I76b792e1191d735788575cbeac646bddeb9e10e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840291 Commit-Queue: Julian Watson <juwa@google.com> Auto-Submit: Julian Watson <juwa@google.com> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#704006}
-
Gyuyoung Kim authored
This is a reland of 5ccc40c0 Original change's description: > Reland "Replace .mojom-blink.h with .mojom-blink-forward.h in blink - 5" > > This is a reland of 5d024fd7 > > Missed including "ip_address_space.mojom-blink.h" > in worker_module_script_fetcher.cc > > Original change's description: > > Replace .mojom-blink.h with .mojom-blink-forward.h in blink - 5 > > > > To reduce pre-processed size of header files have been including > > foo.mojom-blink.h, this CL replaces .mojom-blink.h with > > .mojom-blink-forward.h in blink header files. > > > > This CL has no behavior changes and following CLs will > > continue replacing them more. > > > > Bug: 1001360 > > Change-Id: I49cfab31ec57b183570cf4551e4cd1acd20a1a75 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844752 > > Reviewed-by: Kent Tamura <tkent@chromium.org> > > Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> > > Cr-Commit-Position: refs/heads/master@{#703549} > > Bug: 1001360 > Change-Id: I5279e2fba33e46fa7eb002deeda34421c4176f53 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846416 > Reviewed-by: Kent Tamura <tkent@chromium.org> > Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> > Cr-Commit-Position: refs/heads/master@{#703592} Bug: 1001360 Change-Id: I78f9572ce9543ca83920a033595b956b98690f65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847695Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
-
nancy authored
Currently, the uninstallation dialog head text is inconsistency for the ARC apps and extension apps. ARC apps use Uninstall, and Remove for the shortcut only, because for the shortcut, ARC apps use the extension apps' IDS_EXTENSION_UNINSTALL_PROMPT_HEADING. Per request from the bug, change the head text from Remove to Uninstall, and remove the quotes. Linux apps use Uninstall as well, so I think Uninstall sounds better. BUG=1010303 TBR=rdevlin.cronin@chromium.org Change-Id: I0e939943c37c295ebe2c8a73824c235420a98195 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844756Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ffcde0af0c6d..4e7bc8cf04b5 git log ffcde0af0c6d..4e7bc8cf04b5 --date=short --no-merges --format='%ad %ae %s' 2019-10-08 engeg@google.com cbuildbot: set actual precq timeout to 12 hours Created with: gclient setdep -r src/third_party/chromite@4e7bc8cf04b5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ic26d2c905b0edd22443d3d781577ee7ab485e348 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848538Reviewed-by:
-
Nicolás Peña Moreno authored
Currently, TextPaintTimingDetector uses |invisible_objects_| to keep track of text paints which occupy a size of 0. It is an optimization: LCP does not care about these paints, so it does not need to queue them to obtain paint times nor store a full TextRecord for them. However ElementTiming wants to expose all of the text paints for elements that are annotated with the elementtiming attribute. It is confusing for an element that is painted when outside the viewport to never be reported. To solve this problem, there are two alternatives. One is to use a single |painted_objects_| map which would contain both the visible and the invisible objects, and hence no extra logic would be needed for ElementTimng to receive these objects (but some care might be needed so LCP does not report objects of size 0). This is simpler to code but is less efficient as it adds extra work and memory for the invisible objects. The second alternative is to use a new data structure for text nodes that are of size 0 but need to be reported to ElementTiming. Paint times for these are assigned in AssignPaintTimeToQueuedRecords() and then the TextRecords are deleted (the fact that the element has been painted is still being handled by |invisible_objects_| so there is no need to keep the records for longer). This is the alternative implemented in this CL. Bug: 1011009 Change-Id: I2d15393fc61134b08a5c15bd81d062d42dfb29e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838260Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#704002}
-
nancy authored
This CL is based on the review comments from crrev.com/c/1816495. To unify the enum on AppService, we prefer update the enum start from 0 to 10. BUG=1005640 Change-Id: Ifb70a24b1a3c1c4ac0693206c6df23cb190d067d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837551Reviewed-by:
Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#704001}
-
