GitLab

Reimplement callbacks GoogleSigninSucceeded and GoogleSignedOut as
OnPrimaryAccountSet and OnPrimaryAccountCleared, from IdentityManager.

Bug: 887461
Change-Id: I6a0f5758b8c07f21a8b06b4993a9f58528ee7c7e
Reviewed-on: https://chromium-review.googlesource.com/c/1261637
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603044}

The style guide says that static functions shouldn't be in the global
namespace.

TBR: dschuyler@chromium.org, dtrainor@chromium.org
Change-Id: I48230748abf496eb312ad0901bf88cbbf9307bcc
Reviewed-on: https://chromium-review.googlesource.com/c/1299233
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603043}

Generate a searchable URL when a <form> is submitted. When the Js file is injected,
it will add listeners to all the submit element(i.e. <button> and <input type="submit">
in all <form>s. This CL doesn't add listeners on <form>s' "submit" events.

Most of the code in this CL is based on code from Blink:
https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/exported/web_searchable_form_data.cc

Bug: 433824
Change-Id: Ib56808281265e5605d48148d4504eee0e51d1743
Reviewed-on: https://chromium-review.googlesource.com/c/1293914
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603042}

ExternalProtocolHandler::GetBlockState queries for a value in a dict
pref. Previously, it was using DictionaryPrefUpdate to get the
dict. This causes the pref file to be written out in its dtor. This CL
switches to ordinary read-only ops to avoid spurious pref file writes.

BUG=none
R=benwells@chromium.org

Change-Id: I9a42441cdee70e7bd9b0f67afefb67d411bef2dd
Reviewed-on: https://chromium-review.googlesource.com/c/1298715Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603041}

Test follow-up to crrev.com/c/1234334
[Locked Fullscreen] Fix regression in locked fullscreen mode

Bug: 883104
Change-Id: I31c28083b04513c640090a55659612b8b5c4ae8c
Reviewed-on: https://chromium-review.googlesource.com/c/1280248
Commit-Queue: Ivan Šandrk <isandrk@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603040}

The lone 'IDBCursor' can collide with the blink::IDBCursor. Remove the
'using' and specify the namespace instead.

TBR=pwnall@chromium.org

Bug: 717812
Change-Id: I092b6d3c30931f45d13fd5c35af24539884fa686
Reviewed-on: https://chromium-review.googlesource.com/c/1301434
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#603039}

To work with IDL types with extended attributes (aka. annotated types),
this CL defines IdlAnnotatedType class.
https://heycam.github.io/webidl/#idl-annotated-types

Bug: 894469
Change-Id: I2b59a391ada7657057f79685bad89f56a32a9349
Reviewed-on: https://chromium-review.googlesource.com/c/1296929
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603038}

Contains 2346cb3742fe0f8cfafe8c36a4bd5 and other commits that help with
forming clusters for emoji sequences.

Add a test to Blink layout tests ensuring that male/female sign
sequences are no longer broken up if the primary font contains
male/female sign characters.

Bug: 708604
Change-Id: I34d22a48ec8e4a9a627b12c68efefaabdcd015c7
Reviewed-on: https://chromium-review.googlesource.com/c/1264519
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603037}

https://google.github.io/styleguide/cppguide.html#Namespace_Names
> Namespace names are all lower-case.

This CL has no behavior changes.

Bug: 889726
Change-Id: I5c64c32974787491071b8cef410626c5568ad713
Reviewed-on: https://chromium-review.googlesource.com/c/1301136Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Cr-Commit-Position: refs/heads/master@{#603036}

These operations will be used for transferable streams. The operations
are implemented in JavaScript and exposed to C++ on the
ReadableStreamOperations object.

See design doc at
https://docs.google.com/document/d/1_KuZzg5c3pncLJPFa8SuVm23AP4tft6mzPCL5at3I9M/edit

The new operations are not used outside of tests so far.

The implementation currently has the serious issue that if the page
modifies the MessagePort or MessageChannel interfaces, it will use the
modified versions instead of the originals. Because the operations are
still unused this CL by itself it safe. It will be fixed in a followup
CL.

BUG=894838

Change-Id: Iff40cd9fdd5de39dfce8fbb2b845c1fbd5cbcab0
Reviewed-on: https://chromium-review.googlesource.com/c/1282516Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603035}

Following bot results are included.
11098 11096 11095 11092 11090 11089 11086 11082 11079
11078 11075 11069 11068 11101

3 lines were removed and 11 lines were deflaked by consecutive
results since 11075.

TBR=eae@chromium.org, mstensho@chromium.org
NOTRY=true

Bug: 591099
Change-Id: I57badc35cbed219bdb41bbea45887b3b2fa82258
Reviewed-on: https://chromium-review.googlesource.com/c/1297852
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603034}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/14d9c293..bb69b988

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I6d4e5eb7e498ce7bc254ea9afb674e923bdbd1ca
Reviewed-on: https://chromium-review.googlesource.com/c/1301118Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#603033}

TBR=pdr@chromium.org

Bug: 899087
Change-Id: Ib988d2211c232c60605e8b24946d564577c59f86
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/1301513Reviewed-by: Henrik Grunell <grunell@chromium.org>
Commit-Queue: Henrik Grunell <grunell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603032}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cb9e116dc8cf..4f6d8fb43536


Created with:
  gclient setdep -r src-internal@4f6d8fb43536

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I8651beac0fcea32de4e6b79852a7de315a619e82
Reviewed-on: https://chromium-review.googlesource.com/c/1301235Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#603031}

Bug: 835732
Change-Id: I551fb49ec4e3790d090985a7a79dbcd1630f63fa
Reviewed-on: https://chromium-review.googlesource.com/c/1297213Reviewed-by: Shinya Kawanaka <shinyak@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Simon Que <sque@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603030}

Since this header, after several refactoring steps, is now only
used to define the TracedValue class, renaming it makes sense.

This CL only updates base/. Note that a forwarding
trace_event_argument.h header is still provided, since a
_lot_ of callers outside of base/ need to be updated before
we can get rid of it.

BUG=898787
R=primiano@chromium.org, oysteine@chromium.org, chiniforooshan@chromium.org, nyquist@chromium.org, fdoray@chromium.org

Change-Id: I1156198070353429a6a9933ced3203335d1d874d
Reviewed-on: https://chromium-review.googlesource.com/c/1298955Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: David Turner <digit@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603029}

https://webrtc.googlesource.com/src.git/+log/5abd54166ae7..95dfa5223ac6


git log 5abd54166ae7..95dfa5223ac6 --date=short --no-merges --format='%ad %ae %s'
2018-10-25 zstein@webrtc.org Clarify the desired semantics of AsyncResolverInterface::GetResolvedAddress.
2018-10-25 yujo@chromium.org Split out a separate target for VP8EncoderSimulcastProxy


Created with:
  gclient setdep -r src/third_party/webrtc@95dfa5223ac6

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I7d9a8528e1214978345387e1f03d4d5310eb21b5
Reviewed-on: https://chromium-review.googlesource.com/c/1300578Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#603028}

Logs for unhandled interfaces are spammy and unnecessary. This CL
removes them.

Bug: None
Change-Id: I7135cee2db71edef5ca900395aab7536ff70fb77
Reviewed-on: https://chromium-review.googlesource.com/c/1301135Reviewed-by: Sam McNally <sammc@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603027}

Bug: b/118401289
Test: Local build
Change-Id: I49d75120af0d75df23772b55b9593bc09eefae2c
Reviewed-on: https://chromium-review.googlesource.com/c/1300094Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Yue Li <updowndota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603026}

 Delete MenuButton in PermissionSelectorRow. It seems it's not used after material refresh.
It was replaced with ComboBox.

Bug: none
Change-Id: I30804d833f78113a60f8ac4a9dce737ccf19e3ad
Reviewed-on: https://chromium-review.googlesource.com/c/1293289
Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603025}

It introduces DesktopDragDropClientOzone class to manage
drag-and-drop. 'DesktopWindowTreeHostPlatform::CreateDragDropClient'
creates DesktopDragDropClientOzone and it's connected to platform
windows and has an internal runloop like other DragDropClients.

It adds WmDragHandler and sets the platform window as a WmDragHandler.
When DesktopWindowTreeHostPlatform starts dragging, it gets
WmDragHandler through the platform window and sends the dragging
request to the platform layer.

It implements 'StartDragAndDrop' of 'DragDropClient' for Ozone
and adds 'OnDragSessionClosed' to DesktopDragDropClientOzone to
finish dragging session.

As Wayland platform window has the drag and drop implementation
at the platform layer already, it extends WaylandWindow interfaces,
StartDrag.

With this change, Ozone/Wayland build can start dragging from an
application to the Chromium browser.

Test=DesktopDragDropClientOzoneTest.StartDrag
BUG=875164

Change-Id: I4ebaedfae5f6affb80b4d6c7c6d8ed3ba86ef4ca
Reviewed-on: https://chromium-review.googlesource.com/c/1218446Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com>
Cr-Commit-Position: refs/heads/master@{#603024}

The beacon/headers/header-referrer-no-referrer.html test no longer
flakily leaks memory. Remove it from LeakExpectations.

BUG=762353

Change-Id: I6f9e1e5259c4985e7d50a4f18ac8ac766ee76fab
Reviewed-on: https://chromium-review.googlesource.com/c/1299094Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603023}

https://skia.googlesource.com/skia.git/+log/3f5b4ee4adfd..603c5da17491


git log 3f5b4ee4adfd..603c5da17491 --date=short --no-merges --format='%ad %ae %s'
2018-10-26 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files


Created with:
  gclient setdep -r src/third_party/skia@603c5da17491

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
TBR=brianosman@chromium.org

Change-Id: I052410197aa0349d0cfc783ab77cc235f3c1902d
Reviewed-on: https://chromium-review.googlesource.com/c/1301233Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#603022}

Due to reverting the commit r602299, now tests in the classes
FrameSwitchingTest and GetLogsTest are passing.
Enabling these tests on Waterfall.

Change-Id: Ia7df623e8eac41ec2272de3c17f1030c91948e18
Reviewed-on: https://chromium-review.googlesource.com/c/1300688Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603021}

This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
gbiv@chromium.org. Additional context: https://crbug.com/805539

Please note that, despite rolling to chrome/android, this profile is
used for both Linux and Android.

The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=gbiv@chromium.org

Change-Id: I135531b0410e88cd902e8f9fd4d17703e569e9a2
Reviewed-on: https://chromium-review.googlesource.com/c/1301234Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#603020}

The controller currently tracks ash::kWindowStateTypeKey which doesn't capture
the state transitions properly, instead use aura::client::kShowStateKey for
regular stuff and ash::kWindowPinTypeKey for pinned modes (locked fullscreen).

Bug: 897260
Change-Id: I9e0160f4cbf4951f147954f222c52c11670fc466
Reviewed-on: https://chromium-review.googlesource.com/c/1299238Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Ivan Šandrk <isandrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603019}

Currently the initial navigation URL is used for handling Signed Exchange in
SignedExchangeLoader. But this URL must be updated after redirection.

This CL adds |request_url| argument to MaybeCreateLoaderForResponse() method of
NavigationLoaderInterceptor to update the URL.

And also, this CL moves the location where SignedExchangeRequestHandler is
created when NetworkService is disabled from CreateNonNetworkServiceURLLoader()
to StartWithoutNetworkService() where ServiceWorkerRequestHandler is created.

Bug: 898128
Change-Id: I6fe34c7de2decd7d541988e026cef4ae4067fddf
Reviewed-on: https://chromium-review.googlesource.com/c/1296573
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603018}

Add an experiment to dispatch requests that have been queued for
a long time. This provides a fail-safe mechanism for requests to be
eventually dispatched to the network in case the scheduler blocks
them for too long behind long polling XHRs.

Dispatching such requests would allow the page load to proceed.

Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I02e30452f243dcd6369540c360b2b462cf6b6ea7
Bug: 897371
Reviewed-on: https://chromium-review.googlesource.com/c/1285072
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603017}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c2540ca187ba..cb9e116dc8cf


Created with:
  gclient setdep -r src-internal@cb9e116dc8cf

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I62687d72b6f710d8a8b2e36e66c907ee63593a20
Reviewed-on: https://chromium-review.googlesource.com/c/1300577Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#603016}

This CL moves the definition of MessageLoopCurrent::TaskObserver to
an individual header task/task_observer.h.

The motivation of this change comes from crrev.com/c/1295617.
MessageLoop is going away soon(-ish?), and Blink doesn't want to depend
on base::MessageLoop. It makes more sense to have TaskObserver in a
stand-alone header, given this current situation.

This CL does not touch any use sites of TaskObserver. The alias
MessageLoop::TaskObserver is still available, pending future mass
replacements.

Bug: 826203
Change-Id: I9e17bae3586e29cb76b23f5e247307760dac9a1f
Reviewed-on: https://chromium-review.googlesource.com/c/1298944
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603015}

This patch simplifies conditions around the code in ui/

It is much easier to write & read:
  EXPECT_NE(my_vector.cend(), std::find(my_vector.cbegin(),
 my_vector.cend(), my_search_value))
than:
  EXPECT_TRUE(base::ContainsValue(my_vector, my_search_value))

Bug: 561800

Change-Id: I268d33ee877a8cdfa7f6691467aedd59448d63ac
Reviewed-on: https://chromium-review.googlesource.com/c/1282807
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603014}

Thanks pkl@ for spotting this.

Bug: 898678
Change-Id: I74d2a11e89b62fef5a2a0c42f4d6b7c4d5d1519e
Reviewed-on: https://chromium-review.googlesource.com/c/1298720
Commit-Queue: David Jean <djean@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603013}

The image loader used by the Files App relies on setting the preload
attribute on a video element to trigger it loading some content to use
as a thumbnail. In some circumstances (e.g. data saver), preload is
ignored for video elements.

Invoke load() on the video element explicitly to ensure it loads the
video.

Bug: 888962
Change-Id: I2114bbb36feac3eafbb90cae2babd67d93247a25
Reviewed-on: https://chromium-review.googlesource.com/c/1301053Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603012}

Original: http://crrev.com/c/1292870
Revert: http://crrev.com/c/1299435

Fixes a corner case that wasn't addressed in the first patch,
where a LayoutObject has a continuation but no children - in
that case the continuation needs to be the first child. Adds a
new test for that case. See the diff between patch sets 1 and 2
for the fix.

Original description:

Code to walk the layout tree for accessibility had a subtle bug
when encountering continuations, resulting in strange corner
cases where content could be completely missing from the
accessibility tree.

This patch switches to a new, simpler algorithm to walk the
layout tree for accessibility. It's simpler to explain and
requires less code.

All existing tests pass, included are three new
regression tests demonstrating cases that failed previously,
plus another simple test illustrating the importance of
handling continuations correctly.

Bug: 834653
Change-Id: Id28611f3cd4f4ffbcf4c1b4bf2db91da13a9caa0
Reviewed-on: https://chromium-review.googlesource.com/c/1299609
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603011}

This is a reland of 77cbc4f0.
Added a missing ASH_EXPORT.

TBR=oshima@chromium.org

Original change's description:
> overview: Introduce OnOverviewStartAnimationComplete observer.
>
> Introdue a new overview observer which notifies observers when the start
> animation for overview is different.
>
> Uses will be both in and out of overview - for example adding mask, shadow
> and animating tray, shelf.
>
> Also modify CleanupObserverTest to use some new stuff.
>
> Test: ash_unittests StartAnimationObserverTest.Basic
> Bug: 898222
> Change-Id: I86bdd253f0a4a4dd81ad6ba03780baf07923d256
> Reviewed-on: https://chromium-review.googlesource.com/c/1297405
> Commit-Queue: Sammie Quon <sammiequon@chromium.org>
> Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#602941}

Bug: 898222
Change-Id: Idc7b84a5d47f4c872549ea55600b295f46e5127d
Reviewed-on: https://chromium-review.googlesource.com/c/1301073Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603010}

It is unused, and was never updated to Harmony/MD style.

Bug: 822074
Change-Id: Ic12e4dc5ffa9f271e940090f6954a4a16f7dde84
Reviewed-on: https://chromium-review.googlesource.com/c/1298095
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603009}

Add a new experiment group which is used for finch on stable release.

Bug: 838725
Change-Id: Ib4e140270e4a1aa70cc676aaae3c8eea8ab8abfc
Reviewed-on: https://chromium-review.googlesource.com/c/1300533
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603008}

This reverts commit 0275d360.

Reason for revert: 
Suspect compile failure on Android(x64) Builder Dbg.

Example:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20x64%20Builder%20%28dbg%29/30291

Log:
../../chrome/android/java/src/org/chromium/chrome/browser/vr/VrModuleProvider.java:114: error: cannot find symbol
        Toast.makeText(ContextUtils.getApplicationContext(), R.string.vr_module_install_start_text,
                                                                     ^
  symbol:   variable vr_module_install_start_text
  location: class string
../../chrome/android/java/src/org/chromium/chrome/browser/vr/VrModuleProvider.java:127: error: cannot find symbol
            int mToastTextRes = success ? R.string.vr_module_install_success_text
                                                  ^
  symbol:   variable vr_module_install_success_text
  location: class string
../../chrome/android/java/src/org/chromium/chrome/browser/vr/VrModuleProvider.java:128: error: cannot find symbol
                                        : R.string.vr_module_install_failure_text;
                                                  ^
  symbol:   variable vr_module_install_failure_text
  location: class string
3 errors


Original change's description:
> [vr] On-demand install VR dynamic feature module
> 
> With this CL we initate the module install once the user enters VR on a
> WebXR/VR page. In more detail this CL
> 
> - Introduces native VrModuleDelegate used to request VR module from
>   native,
> 
> - Refactors GvrDevice to request the VR module as part of its
>   initialization flow,
> 
> - Adds native side of the VrModuleProvider for Java-native
>   communication.
> 
> Bug: 862689
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> Change-Id: I960d2bdd4d2c64a19fa6069e457d44f77ab0e73b
> Reviewed-on: https://chromium-review.googlesource.com/c/1241458
> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
> Reviewed-by: Ted Choc <tedchoc@chromium.org>
> Reviewed-by: Bill Orr <billorr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#602922}

TBR=tedchoc@chromium.org,billorr@chromium.org,tiborg@chromium.org

Change-Id: I19d05dd6f13e5d6eee5ea0ac2f168a3a4d1a3680
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 862689
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/c/1301194Reviewed-by: Takashi Sakamoto <tasak@google.com>
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Cr-Commit-Position: refs/heads/master@{#603007}

Bug: 841886
Bug: b/115291749
Test: ash_unittests
Change-Id: Ibfd54d17fa035d432fbb0570ab5eee922b1a8856
Reviewed-on: https://chromium-review.googlesource.com/c/1300819Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Eliot Courtney <edcourtney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603006}

Absolute paths in zip files are invalid, as per the APPNOTE:

4.4.17 file name: (Variable)
       4.4.17.1 The name of the file, with optional relative path.
       The path stored MUST not contain a drive or
       device letter, or a leading slash.  All slashes
       MUST be forward slashes '/' as opposed to
       backwards slashes '\' for compatibility with Amiga
       and UNIX file systems etc.  If input came from standard
       input, there is no file name field.

However, zip files in the wild and ones generated by some services do
have them, so they should be handled in a reasonable manner, as other
platform (including Google Drive) do. Stripping the leading slash and
treating the path as relative seems reasonable. This won't work if there
are two files with the same path, but one being relative and the other
absolute. But in this case, the archive was already invalid, so any
attempt to handle it is best effort.

BUG=646850

Change-Id: I7681e888bb78d7f4f53c7bd3a5ab318bffb8c527
Reviewed-on: https://chromium-review.googlesource.com/c/1301094Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Commit-Queue: Anand Mistry <amistry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603005}