- 20 Sep, 2018 40 commits
-
-
yileili authored
This is a reland of c9b5d530 The internal repo uprev has landed in public HEAD. Original change's description: > Refresh access token only for auth error. > > Bug: b:114756954 > Test: Manual > Change-Id: I1d58906771ad789232d8c01f6de06ea44ad8e3f8 > Reviewed-on: https://chromium-review.googlesource.com/1226527 > Commit-Queue: Yilei Li <yileili@google.com> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#592467} Bug: b:114756954 Change-Id: I695953226bfaea3f332cccb7b61a98be2c541297 Reviewed-on: https://chromium-review.googlesource.com/1235330Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Yilei Li <yileili@google.com> Cr-Commit-Position: refs/heads/master@{#592856}
-
dpapad authored
These seem to have been fixed at r591110, but they were not properly re-enabled. Bug: 875452 Change-Id: Icdab27f5afd81a8e8c2c7a30b1ab76ec05ee8d8e Reviewed-on: https://chromium-review.googlesource.com/1235285Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#592855}
-
Mark Cogan authored
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I785464f847ff6344201a5ac8f7aa2a6a1aa2f3f5 Reviewed-on: https://chromium-review.googlesource.com/1233701 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#592854}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/52c63fdabb72..7b11354810a9 git log 52c63fdabb72..7b11354810a9 --date=short --no-merges --format='%ad %ae %s' 2018-09-20 mtklein@google.com add a bot that oughta fail Created with: gclient setdep -r src/third_party/skia@7b11354810a9 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@chromium.org Change-Id: Ic05e70f49f6496ad6ff979829f7be1a2d6b7dc16 Reviewed-on: https://chromium-review.googlesource.com/1236513Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592853}
-
Steven Bennetts authored
This reverts commit 2457438e. Reason for revert: desktopui_MashLogin is still failing Original change's description: > Mash: Protect virtualKeyboard events for null KeyboardController > > Currently the code is triggering a crash indesktopui_MashLogin: > http://ubercautotest.corp.google.com/tko/retrieve_logs.cgi?job=/results/239691238-chromeos-test/chromeos4-row2-rack3-host12/debug/ > > Bug: 843332 > For extensions change: > TBR=benwells@chromium.org > > Change-Id: I51d94a6924407fffbb49994ff4cb02718b517866 > Reviewed-on: https://chromium-review.googlesource.com/1235206 > Commit-Queue: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Cr-Commit-Position: refs/heads/master@{#592620} TBR=jamescook@chromium.org,stevenjb@chromium.org Change-Id: If44890c68926d991d4642fde4566408b6ce57fa0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 843332 Reviewed-on: https://chromium-review.googlesource.com/1236837Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#592852}
-
Kyle Milka authored
Bug: None Change-Id: Ie03079ca73e9e2593b73ff0e17e13c47bc077d3e Reviewed-on: https://chromium-review.googlesource.com/1231987Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#592851}
-
Antoine Labour authored
This reverts commit 1e9e40b7. Reason for revert: crbug.com/887263 and crbug.com/887398 Original change's description: > Use SharedImageInterface for gpu and OOP raster > > This wires up SharedImageInterface all the way to cc, and uses it for OOP and GPU raster. > This also adds memory accounting in SharedImageFactory/SharedImageStub. > > Bug: 870116 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I37eba221bc2aeb4d03b7d4d93bde772482dc681b > Reviewed-on: https://chromium-review.googlesource.com/1178977 > Commit-Queue: Antoine Labour <piman@chromium.org> > Reviewed-by: Bo <boliu@chromium.org> > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Reviewed-by: Eric Karl <ericrk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#592419} TBR=sadrul@chromium.org,boliu@chromium.org,piman@chromium.org,ericrk@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 870116 Change-Id: Ie4fbd60787c6fc3cefbc695595bc80234be6cfc1 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1236457Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#592850}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fd2e62420dba..84df59e3758f Created with: gclient setdep -r src-internal@84df59e3758f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I6af9fafd8ee5b759d036de631d57440e4662e976 Reviewed-on: https://chromium-review.googlesource.com/1236873Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592849}
-
Peter Kasting authored
Per markchang@, this is dead. Bug: none Change-Id: I56751472d648fce8df797f860f0bf088dbc7b5f5 Reviewed-on: https://chromium-review.googlesource.com/1235310Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#592848}
-
Khushal authored
We deserialize skia data while holding a lock, which we block on if skia tries to delete a handle as this data is creating new entries in the strike cache. R=ericrk@chromium.org Bug: 887422, 887152 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Id32cb071834186e7de0dac16902c452c3ccdb102 Reviewed-on: https://chromium-review.googlesource.com/1236455Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#592847}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d511948b9f82..52ea49706fd7 git log d511948b9f82..52ea49706fd7 --date=short --no-merges --format='%ad %ae %s' 2018-09-20 jmadill@chromium.org Vulkan: Enable a few BufferDataTests. Created with: gclient setdep -r src/third_party/angle@52ea49706fd7 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I9c4dd0eaec2f340de1304de2b5085ec4ed773ce7 Reviewed-on: https://chromium-review.googlesource.com/1236519Reviewed-by:
-
Guido Trotter authored
Since legacy supervised users are unsupported assume any call returns false and simplify the code accordingly. IsSupervised() calls are for now not affected Signed-off-by:
Guido Trotter <ultrotter@chromium.org> Bug: 882802 Change-Id: Id2f382aed0f919970dde46544bfacadde9247935 Reviewed-on: https://chromium-review.googlesource.com/1233577Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#592845}
-
Francois Doray authored
Bug: 833989 Change-Id: Id97ab3cf302067670b5a90e38d2077f1b7b3e89e Reviewed-on: https://chromium-review.googlesource.com/1231299Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#592844}
-
Lei Zhang authored
Change-Id: I6d2cc26c552a6f9947ebbc19066304446a9e3a44 Reviewed-on: https://chromium-review.googlesource.com/1235342Reviewed-by:
Ben Wagner <bungeman@google.com> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#592843}
-
Christian Biesinger authored
It's somewhat expensive to compute it. R=mstensho@chromium.org,ikilpatrick@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ic1fc1b7b2e11c18a96a268fb731716d074940a36 Reviewed-on: https://chromium-review.googlesource.com/1235213Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#592842}
-
Jordan Demeulenaere authored
Bug: 806868 Change-Id: I64212a92405c2021e42b37f7c8b60ae28cc86aca Reviewed-on: https://chromium-review.googlesource.com/1233699Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#592841}
-
Lukasz Anforowicz authored
Cross-Origin Read Blocking (CORB) was enabled by default in 68.0.3410.0. Since this feature has shipped quite a while ago, it seems that now is a good time to remove the code responsible for enabling/disabling the feature. Bug: 802835 Change-Id: I11b3058447607b31cb27a3e7dbc8db137411d7b8 Reviewed-on: https://chromium-review.googlesource.com/1228485Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#592840}
-
Xiyuan Xia authored
- Add content_browsertests in single process mash mode to bots; - Add a filter file of the failed/flaky tests; Bug: 874089 Change-Id: I806556b0de0b4ee154d03395a566d0e6610eb5c3 Reviewed-on: https://chromium-review.googlesource.com/1234258Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#592839}
-
Gauthier Ambard authored
This CL removes the class triggering the animations for the tools menu button in the toolbar. It is now directly triggered by the BVC. Bug: 800266 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I19feafb03776741bbde51fe54ace27b990811b2e Reviewed-on: https://chromium-review.googlesource.com/1236655 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#592838}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/5e97145328bd..3d81f7cc222b git log 5e97145328bd..3d81f7cc222b --date=short --no-merges --format='%ad %ae %s' 2018-09-20 dtu@chromium.org [pinpoint] Add try job and latency stats. Created with: gclient setdep -r src/third_party/catapult@3d81f7cc222b The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:887168 TBR=sullivan@chromium.org Change-Id: I182425628bb8f5540341ea21ff8da31cfca3104b Reviewed-on: https://chromium-review.googlesource.com/1236516Reviewed-by:
-
Mugdha Lakhani authored
when one of the settled fetches has a response with a bad status. Bug: 876691 Change-Id: I45af6b792a6a43e5b091bc5fe6f40d011bdabac5 Reviewed-on: https://chromium-review.googlesource.com/1233693Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#592836}
-
Rune Lillesveen authored
Change-Id: I7d928fc9847413805dd3179d49b13736fb8f6450 Reviewed-on: https://chromium-review.googlesource.com/1235993Reviewed-by:
Anders Ruud <andruud@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#592835}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/207cfdfbd889..0ad0c27a0bce git log 207cfdfbd889..0ad0c27a0bce --date=short --no-merges --format='%ad %ae %s' 2018-09-20 buildbot@webrtc.org Roll chromium_revision cc7b9c68..a7544fa3 (592452:592771) Created with: gclient setdep -r src/third_party/webrtc@0ad0c27a0bce The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I4f478b6b1fd08dfe415a8435c5f5b28c32ea3f23 Reviewed-on: https://chromium-review.googlesource.com/1236515Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5d2918e8ee83..e6dfe41ffa6e git log 5d2918e8ee83..e6dfe41ffa6e --date=short --no-merges --format='%ad %ae %s' 2018-09-20 hjd@google.com perfetto-ui: Rename rawQuery to query 2018-09-20 hjd@google.com Merge "perfetto-ui: Remove engine worker proxy hacks" Created with: gclient setdep -r src/third_party/perfetto@e6dfe41ffa6e The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I524fc5b7b49b9ec91b5d513f48d0344d937e38c2 Reviewed-on: https://chromium-review.googlesource.com/1236474Reviewed-by:
-
Finnur Thorarinsson authored
The SelectableListToolbar is setting FocusInTouchMode to true for all its children. This is problematic for the Done button, as it then requires two taps to click. Also, while I was at it, use the same styling for the Done button as the Done button in the Contacts Picker. Bug: 813422, 656015 Change-Id: I277626563885621b3bf677697d464a3299e6658f Reviewed-on: https://chromium-review.googlesource.com/1236435 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#592832}
-
Weiliang Chen authored
Skip GLImageNativePixmap tests and GLSurfaceEGLTest.SurfaceFormatTest for MSAN. TBR=kbr Bug: 886995 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I1b29243bd8219e81187aa0e8c5d8f50371423126 Reviewed-on: https://chromium-review.googlesource.com/1236833 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#592831}
-
Sergey Poromov authored
AuthFailure was remembered in OnAuthFailure() by a pointer and was freed after that leading to strange failure reason on next read. It was introduced 5 years ago in https://crrev.com/22900017 [719:719:0918/112724.240220:ERROR:auth_status_consumer.h(95)] NOTREACHED() hit. [Reason: info:NOTREACHED()] [719:719:0918/112724.240293:ERROR:device_event_log_impl.cc(159)] [11:27:24.240] Login: cryptohome_authenticator.cc:725 Login failed: [719:719:0918/112724.240371:ERROR:login_performer.cc(63)] Login failure, reason=0, error.state=0 [719:719:0918/112724.240414:ERROR:kiosk_profile_loader.cc(202)] NOTREACHED() hit. [Reason: info:NOTREACHED()] [719:719:0918/112724.240458:ERROR:auth_status_consumer.h(95)] NOTREACHED() hit. [Reason: info:NOTREACHED()] [719:719:0918/112724.240445:ERROR:kiosk_profile_loader.cc(188)] Kiosk auth failure: error= [719:719:0918/112724.240674:ERROR:kiosk_profile_loader.cc(50)] NOTREACHED() hit. [Reason: info:NOTREACHED()] [719:719:0918/112724.240732:ERROR:app_launch_controller.cc(526)] Kiosk launch failed, error=4 Bug: 885346 Change-Id: I46ca3b3630aa42e25a25d9cfecb3a16e3c361b9f Reviewed-on: https://chromium-review.googlesource.com/1236265Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#592830}
-
James Cook authored
ArcAppWindowLauncherController was observing the wrong aura::Env for window creation, so it wasn't calling AttachControllerToWindowIfNeeded to set the correct ShelfID on the window. Bug: 887129 Test: pin Play Store icon, then tap on it Change-Id: I2239a032962b783a50e562b822f021ef6e0a7511 Reviewed-on: https://chromium-review.googlesource.com/1235152Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#592829}
-
Guido Trotter authored
Both policies are deprecated and will always be false. Remove SupervisedUsersEnabled code, for ChromeOS Remove SupervisedUserCreationEnabled code, for Chrome Signed-off-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#592828}
-
Cathy Li authored
mv ntp/ContextMenuManager.java to native_page/ mv suggestions/SuggestionsNavigationDelegate.java to native_page/NativePageNavigationDelegate.java and remove suggestions-only methods cp suggestions/SuggestionsNavigationDelegateImpl.java to native_page/NativePageNavigationDelegateImpl.java and remove suggestions-only methods have suggestions/SuggestionsNavigationDelegate.java extend native_page/NativePageNavigationDelegateImpl to contain suggestions-only methods update all references thereof Bug: 867488 Change-Id: I64cb9bb6864da2a90b9358ec2a4f339d76df1cdc Reviewed-on: https://chromium-review.googlesource.com/1232336 Commit-Queue: Cathy Li <chili@chromium.org> Reviewed-by:
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I2bf66fbb151b60c3a26a2d0082ab760720a926d9 Reviewed-on: https://chromium-review.googlesource.com/1236497 Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592826}
-
Kevin Bailey authored
Previously OmniboxTabSwitchButton::IsSelected() wasn't asking if *this* result was selected, only if "the tab switch button" was focused. This could refer to another result. This change narrows the implementation of IsSelected() to check if this particular result is also selected. Bug: 886606 Change-Id: I463151848e6cefdbe3afa360d3dbc0e03d2c40ee Reviewed-on: https://chromium-review.googlesource.com/1234033Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#592825}
-
Mark Cogan authored
This CL: - Removes support for non-GRID tab switchers from the feature engagement egtest. - Simplifies tab_usage_recorder_test_util to only support the tab grid. - Removes non-grid support from the UKM egtest - Moves the TabletTabSwitcherOpenButton() helper function to chrome_matchers, out of the moribund tab_switcher/ directory. Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I6cbcfa88f13bdad6407e56746e9e76bd9e4a5d38 Reviewed-on: https://chromium-review.googlesource.com/1233195 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
-
Arthur Sonzogni authored
Renderer initiated back/forward navigations must not be able to cancel ongoing browser initiated navigation if they are not user initiated. Note: 'normal' renderer initiated navigation uses the FrameHost::BeginNavigation() path. A code similar to this patch is done in NavigatorImpl::OnBeginNavigation(). Test: ----- Added: NavigationBrowserTest. * HistoryBackInBeforeUnload * HistoryBackInBeforeUnloadAfterSetTimeout * HistoryBackCancelPendingNavigationNoUserGesture * HistoryBackCancelPendingNavigationUserGesture Fixed: * (WPT) .../the-history-interface/traverse_the_history_2.html * (WPT) .../the-history-interface/traverse_the_history_3.html * (WPT) .../the-history-interface/traverse_the_history_4.html * (WPT) .../the-history-interface/traverse_the_history_5.html Bug: 879965 Change-Id: I1a9bfaaea1ffc219e6c32f6e676b660e746c578c Reviewed-on: https://chromium-review.googlesource.com/1209744 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
-
Paul Meyer authored
These reports are only used for testing, are not web exposed, and the flag only covers the IDL file anyway, which is unnecessary. This patch removes that flag. TBR: japhet@chromium.org Change-Id: I3a1c63bbbaa2f50cec7c42217a7ce2882ae6f6c2 Reviewed-on: https://chromium-review.googlesource.com/1226077Reviewed-by:
Paul Meyer <paulmeyer@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Paul Meyer <paulmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#592822}
-
Tao Bai authored
These resources are used by hueristic field type prediction. Bug: 849913 Change-Id: Iab2935bce88984c604ac87f0148910c1a4b343c2 Reviewed-on: https://chromium-review.googlesource.com/1231819 Commit-Queue: Tao Bai <michaelbai@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#592821}
-
jchen10 authored
It causes no-over-optimization-on-uniform-array cases failing consistently. TBR=kbr@chromium.org Bug: 884210 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I5e61cdcfd793fb3a7916b9c25acca535d61771fd Reviewed-on: https://chromium-review.googlesource.com/1235327Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#592820}
-
Nico Weber authored
Bug: 832676 Change-Id: I0fb8d4b1f0197dab0b988a52741724f63a18ee9f Reviewed-on: https://chromium-review.googlesource.com/1236178 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#592819}
-
Chris Lu authored
- Updates _currentPage properly in response to 3-finger accessibility swipe. This will now properly read out the currently visible page if a user swipes to a different page. - Ensures that only the currently visible page's elements can be selected in the scroll view. This resolves an issue VoiceOver was having with what page to readout and to focus on. Oftentimes the visible page was not readout or selectable. Video: https://drive.google.com/open?id=1Q62MUlrVcNlqnFIQOfw_YiGHinTKb_45 Bug: 880079 Change-Id: I0696786292bec375af9d5326a790700000114559 Reviewed-on: https://chromium-review.googlesource.com/1221474 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#592818}
-
Mounir Lamouri authored
Adding a DCHECK() and a null check. Bug: 883329 Change-Id: I56efb844c7cc6788ac04e9f494608ef18e94cd78 Reviewed-on: https://chromium-review.googlesource.com/1236454Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#592817}
-
