- 29 May, 2020 40 commits
-
-
Sahel Sharify authored
paymentOptions used to get populated as an string arraylist in intent extras. This cl changes the paymentOptions to a bundle so that native app developers won't need to convert string values to boolean. Bug: 1026667 Change-Id: I6804d8765b9c90da73b8533ca55c7304823858f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219684Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#773372}
-
Shengfa Lin authored
Re-organize code so that when retry after initial setWindowBounds, will trigger setWindowBounds again in hope to trigger window state change. This is an attempt to add on the following fix. [chromedriver] Fix testWindowMinimize flakiness After setting window bounds, could potentially wait for 1 second using retries for window state to reflect. Bug: chromium:1068467 Change-Id: I62ca499879ec1d31e1eabafa8c8dea870e3e03da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222625 Commit-Queue: Shengfa Lin <shengfa@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#773371}
-
Robert Kroeger authored
conformance2/textures/image_data/tex-2d-srgb8_alpha8-rgba-unsigned_byte.html is flaky on Builder Win10 FYI x64 Exp Release (Intel HD 630). Suppress. TBR=kylechar@chromium.org Bug: 1087993 Change-Id: Icdfa404f6ab1b62fbb97b605cb6b0bb34e7d7a18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222881Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Robert Kroeger <rjkroege@chromium.org> Auto-Submit: Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#773370}
-
Kyle Horimoto authored
I'll start them out at medium for now, and we'll adjust the rankings accordingly once we get more testing completed. I updated a few ("Mono audio" and "Blue light reduction") to kLow since these have been interfering with "Bluetooth" and "Wi-Fi". Bug: 1082251 Change-Id: Ic45495e2fcb55939fd7a08e38312c875f364805a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222294 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#773369}
-
Elly Fong-Jones authored
This test relies on ChromeDriver's SetWindowBounds, which is flaky - it waits 100ms for the command to complete rather than observing an actual event. Bug: 867511 Change-Id: I7b4b759be6f2498b0ff3b46f705d2e2567d07558 Tbr: johnchen@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222720Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#773368}
-
Xianzhu Wang authored
Inset box shadow doesn't scroll, and it's in the scrolling area above the background below the scrolling contents, so the background must paint in the main graphics layer. Bug: 1086457 Change-Id: I6bf5fc3e7754a29cfa60d72acbe5699594152ce6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222626Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#773367}
-
Chris Harrelson authored
Change-Id: I3bd33fdfb707408809dfa777ce1a0abfcfd7991b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219159Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#773366}
-
Wei Li authored
This update is based on the feedback from estade@. Chromium itself doesn't have a style guide for documentation. For titles and headers, the existing documentation has different styles. To make our document consistent, we can follow "Google developer document style guide" (https://developers.google.com/style/) to use sentence case for titles and headings. BUG=none Change-Id: If9e63e94971b9015e1803c79b9995809ad166783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219302 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#773365}
-
Lei Zhang authored
The CL that triggered their flakiness got reverted. Bug: 1021545 Change-Id: I7d7862f2ee1031fbe402276d0ab62f6fcb13fe6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219349Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#773364}
-
Mounir Lamouri authored
Bug: 929156 Change-Id: Id923970af87c4924a26961a6f70145bffeab3005 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1460062 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#773363}
-
Thomas Guilbert authored
Add @RetryOnFailure to IncognitoStorageLeakageTest#testStorageDoesNotLeakFromActivityToActivity Although there are talk about removing the RetyOnFailure flag (see crbug.com/797002) for now this should be slightly less expensive than re-running the entire test suite. TBR: tedchoch@chromium.org Bug: 1087796 Change-Id: I2f76509aa7f5aecf9f7554cc3d825149055b428d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222727 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#773362}
-
kdillon authored
These histograms are still in use. Bug: 1072542 Change-Id: I7524ba1fc7f233ca84171ffdb4c11c58c767a8ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222630Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Katie Dillon <kdillon@chromium.org> Cr-Commit-Position: refs/heads/master@{#773361}
-
Ben Pastene authored
Same thing that crrev.com/c/2219679 did, but for tests invoked via host-side cmd (eg: telemetry) rather than device-side cmd (eg: gtests). Bug: 1087407 Change-Id: I514a01583bbfea6a4a600d738587d8663ae0adec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222901Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#773360}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7693b668..772196e5 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I13bec7b00a9e05d3e8cba4fb72c105b90d82a9c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222207Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773359}
-
Joe Mason authored
Instead of hardcoding a top and bottom border in the graph, add a border around each node's bounding area in boundingForce. This will keep nodes away from the lane markers as well as the graph edges. R=siggi Bug: 1086231 Change-Id: I58b52649aec0e921de5a85d8bd191591bf36f13b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222529Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Auto-Submit: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#773358}
-
James Long authored
In-memory representations of the two types of graphs were made serializable/deserializable to and from JSON. A new module `serialization` has been created to help with this process. The end result is one .txt file containing the JSON dump of both the class and package dependency graphs - more rationale on this format is included in the docstring of serialization functions. The performance of the de/serialization is very acceptable (within a second on my machine). The filesize of the output JSON file is ~7MB, which I also find acceptable. There are rooms for optimization in the JSON structure if the filesize becomes an issue in the future. Bug: 1081889 Change-Id: I03061372e0ed94aed62de58f41fb3f363f543b3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219817 Commit-Queue: James Long <yjlong@google.com> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#773357}
-
Francois Doray authored
This CL changes SetWakeUpRate(double wake_ups_per_second) to SetWakeInterval(base::TimeDelta interval) to avoid conversions between rate and interval. This CL is a no-op. Bug: 1075553 Change-Id: I1b72f6b56f364c24c73a14eb8f1c3aea8ca31bc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219524Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/b4e53be8a002..cfe3be0ee4c5 2020-05-29 rwkeane@google.com Code Coverage: Add new buildbot mixin If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I40c444d57a8ab9729262d99c327c7a66f52c077a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222712Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773355}
-
Etienne Bergeron authored
This CL is suspending the execution of delayed task while the system is suspended. The ThreadControllerPowerMonitor is used to notify the ThreadController when the power is back to normal. The delayed tasks can no longer be executed between suspend and resume notifications. They are postponed after the resume notification. On Windows, while going to suspend mode or waking up, the computer has bottleneck on clock API (system-wide lock) and has a lot of disk IO contention. It is not the right moment to wake up all the pending delayed tasks at once. It is better waiting for the resume notification while the computer is in a running state. Bug: 1074332 Change-Id: Icda16b76fc87a20fee22997baf7eeb5e5d02eb09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186200 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#773354}
-
Etienne Pierre-doray authored
To allow construction with multiple unwinder. This is necessary on android to provide native and chrome unwinders and will be used in a follow in stack_sampling_profiler_unittest.cc https://chromium-review.googlesource.com/c/chromium/src/+/2201658 Bug: 989102 Change-Id: I05ef97403668d82dc7e6e4e9505be95e941174dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211862 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#773353}
-
Scott Violet authored
WebLayer doesn't use ApplicationStatus. In order for WebLayer to use AccessibilityUtil this splits AccessibilityUtil into two parts. The core part dealing with determining if accessibility is enabled remains in AccessibilityUtil. The application state remains in a subclass called ChromeAccessibilityUtil. This code is easier to split when the there is an actual instance created. So, rather than a bunch of static methods, you have to create an instance of AccessibilityUtil. ChromeAccessibilityUtil takes care of this. Doing this means all chrome code now has to call a static function to get the instance. This necessitated a bunch of changes. There is one other interesting change here. Previously ApplicationStatus.ActivityStateListener, when RESUME was called, would reset state so that the next call to isAccessibilityEnabled() would trigger recalculating the value. If the value changed, this would *not* notify observers. This seemed like a bug, so I made the RESUME case immediately calculate the value and notify observers if necessary. Please let me know if you think the old code was correct. BUG=1085210 TEST=none Change-Id: Id4e58da4f96fb9d218e59d3e62a94f0085827bb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210358 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#773352}
-
Tom Anderson authored
R=thestig CC=thakis,maskray@google.com Bug: 1086636, 1084359 Change-Id: Ibc5f5da51278d90d7f45c4fdadff07f62f6dfd51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219606 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#773351}
-
Matt Menke authored
When there's an Expect-CT failure, a new URLRequest will be created to report the failure, and that request needs to have a NetworkIsolationKey to prevent cross-site information leakage. Bug: 969893, 1082280 Change-Id: I5daa400fed87ce23f7a9b34121888f91b9249895 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219091 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#773350}
-
Renjie Tang authored
Change-Id: I20c0ea03bf3fd21a260dd9f1fc67e66b6d8c7c44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216546Reviewed-by:
Renjie Tang <renjietang@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#773349}
-
Piotr Bialecki authored
Change-Id: I2f05f6eaa5ea7bcbaa27e0a8f4472affb42afa5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168768 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#773348}
-
Alex Moshchuk authored
If a history navigation targets a subframe, but the subframe has been removed by its parent, we currently fall back to reload the whole page. This CL tries to modify this behavior to instead do a no-op same-document navigation (to the same item sequence number) to the main frame. This approach will update the current history entry to the target one, but it avoids a reload and allows the main frame and other frames to continue to function. The CL tries to preserve the main frame reload behavior in the cases where that's still needed, including various kinds of reloads, session restore, and crash recovery, by refactoring FindFramesToNavigate() to explicitly queue a different-document load in those cases. We've also attempted ignoring the navigation completely, rather than doing a no-op same-document navigation. This had the problem of not notifying observers about the updated history entry, meaning that things like greying out of back/forward buttons didn't work properly, and history length/offset information wasn't updated properly in the renderer processes. Doing a redundant same-document navigation avoids these problems, as it goes through a complete navigation flow. There was one unwanted side effect of this approach, which is that the main frame would redundantly fire popstate events when the ISNs aren't changing. The spec [1] argues that popstate events should be fired whenever the "entry" changes, but "entry" in that context probably means the FrameNavigationEntry and not NavigationEntry. Although the NavigationEntry changes here, the spec probably expects FrameNavigationEntry to not change (due to how joint session history entries are supposed to work), even though it does change in our current implementation (see https://crbug.com/373041). Other browsers also don't trigger a redundant popstate in this case. So this CL also modifies DocumentLoader to avoid triggering redundant popstate events when the ISN doesn't change. This is a less risky option to solve this problem. It has some drawbacks -- if there are multiple history entries targeting a removed subframe, the user might have to keep clicking back/forward until finding an entry that still works. In the future, we could consider improving this to automatically walk past all history entries corresponding to the affected subframe. [1] https://html.spec.whatwg.org/multipage/browsing-the-web.html#history-traversal Bug: 705550 Change-Id: I11fca7a8f1062af347442922f49b2dfe50970d13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181973Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#773347}
-
Tommy Li authored
This CL creates a whole new flag for the On-Content variant of Contextual Web ZeroSuggest. Bug: 1087700 Change-Id: I4ccb748421470e2ccd3508d69fc317e12c27ff9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219597Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#773346}
-
Matt Menke authored
It then passes the NetworkIsolationKey on to the ExpectCTReporter. Also plumb NIK through the other TransportSecurityState methods that call it. Only one caller of TransportSecurityState is updated to pass in a non-empty NIK. The other 3 callers will be addressed in followup CLs. Bug: 969893, 1082280 Change-Id: I2982c06288e6ff9ec2dd863b0ecbcf01f46b2791 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217871Reviewed-by:
-
OlivierLi authored
This avoid having to type 1 << (numbits_ - 1) in several places which can make code harder to read and can be typo prone. This function can also be used within another template. Change-Id: I46af3ab832bb58a6565702a391db028b2a69807f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222526 Commit-Queue: Oliver Li <olivierli@chromium.org> Reviewed-by:
-
Tibor Goldschwendt authored
This ensures the most visited tiles as up-to-date. It's also what the local NTP does. Bug: 1087564 Change-Id: I724b99763952894617400d2733ce55992e3933dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222635 Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#773343}
-
Samuel Huang authored
SuperSize-archive calls _AddUnattributedSectionSymbols() to create symbols (in .other section) to account for sections that are not covered by symbols. However, previously this was done only ELF files inside APK and not for stand-alone ELF files. Also, the accounting was off, resulting in Supersize-console Print(size_info) producing file sizes that are off. This CL fixes the above problems. Details: * Add models.ClassifySections() to classify sections into one of three groups: (1) Unsummed sections: These don't add to binary size. E.g., .bss. (2) Explicitly summed sections: These add to binary size, and have symbols that are extracted by the "usual method" via .map file parsing, nm, etc. E.g., .text. (3) Implicitly summed sections: These add to binary size, but needs to be extracted via _AddUnattributedSectionSymbols(), and counted as part of the .other section. E.g., .dynsym. * The function is used by archive.py and describe.py, to eliminate previous size mismatches. * Add BaseSizeInfo.ClassifySection() to wrap this. * archive.py: Change main flow so that _AddUnattributedSectionSymbols() get called when an ELF file is the main input (even without APK). * describe.py: When describing section sizes, add note to make it clear that a section is counted in the .other section. This CL leads to extensive .golden file changes. Bug: 1084580 Change-Id: If663eb9acce89b32f857a0056b6f5ec39db35d8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217861Reviewed-by:Samuel Huang <huangs@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#773342}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/df546db4d8f7..cc7ec24ca824 2020-05-29 egdaniel@google.com Move backend surface vk getters and setters back out from behind compile flag. 2020-05-29 bungeman@google.com Revert "Hide ICU C++ API from Skia users." 2020-05-29 bungeman@google.com Create CTTypesetter without Options. 2020-05-29 herb@google.com tease apart GrTextBlob and SubRun 2020-05-29 bungeman@google.com Hide ICU C++ API from Skia users. 2020-05-29 herb@google.com Rename fUniqueID -> fMessageBoxID 2020-05-29 csmartdalton@google.com Wire up mouse and keyboard events in CanvasKit viewer 2020-05-29 egdaniel@google.com Add GrBackendMutableState object to handle shared texture state. 2020-05-29 michaelludwig@google.com Rename fIH variable to fInvH 2020-05-29 csmartdalton@google.com Merge PathText samples into one, with different modes 2020-05-29 nigeltao@google.com Fix markdown typo in the style guide 2020-05-29 senorblanco@chromium.org Modify SurfaceTest to only test readbacks from supported surfaces. 2020-05-29 brianosman@google.com Minor cleanup in the sample_matrix GMs 2020-05-29 robertphillips@google.com Update DDL test harness to better match OOP-R 2020-05-29 nifong@google.com Record code coverage in canvaskit tests, increase coverage 2020-05-29 herb@google.com Move hasW to SubRun If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: westont@google.com Change-Id: I5ced804b0b88c5c04788f5e10a879779ef17990f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222710Reviewed-by:
-
Chih-Yu Huang authored
CL:2035212 was reverted because we encountered some issue with the guest user, and VP8 on Intel device. Now those issues are solved. It's time to enable ChromeosVideoDecoder by default again. Bug: 984482 Test: ninja media/base Change-Id: I7ad037186fa4f62a0f7d14025e5f4590c7caad53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214764 Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#773340}
-
Arnaud Mandy authored
This CL enables possibility to isolate blink implementation of screen enumeration from the rest of the stack. It provides the possibility to create mock displays at test conveniences by rerouting the GetDisplay call to the JS implementation in the test. Existing test has been modified to use this test framework. Bug: 1075656 Change-Id: I1a38426deaccff14036f00806ef7dfc878bcd4ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214538 Commit-Queue: Arnaud Mandy <arnaud.mandy@intel.com> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#773339}
-
Sergey Ulanov authored
Previously there were tests that play audio and tests that play video, but no tests were playing a file with both audio and video. Also video was not played to the end. Added PlayVideo test that plays bear-vp9-opus.webm to the end. Also updated SetBlockMediaLoading tests to share play_video.html and reduce amount of duplicated code. Bug: b/153914562 Change-Id: Iba492ec252f692f7aa3f93c319d858a91bb38278 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219404 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#773338}
-
Matt Jones authored
This patch removes logic that would prevent the bottom sheet from showing when contextual search was visible. The code in question was relevant when the bottom sheet could trigger without a user action. Since this is no longer the case, the code is unneeded. This block of code should have been removed with https://crrev.com/c/1808180, which contained the rest of this logic. Bug: 100227 Change-Id: I6c1896c9c8907ec01542568162291e85aa2892cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204298Reviewed-by:
-
Behnood Momenzadeh authored
This CL provides an extra layer of protection to top domains with top 3 most visited TLDs. If a potential target embedding domain embeds a hostname with another valid TLD instead of the domain's actual TLD, the heuristic will flag it. For example, the heuristic will trigger on google.info-foo.com. This CL also flags domains that embed a target without the target's separators (e.g. googlecom-evil.com). Bug: 1087636 Change-Id: I14205e5b9830146d8aecfd216082d1213e5622bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215377 Commit-Queue: Behnood Momenzadeh <behnoodm@google.com> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#773336}
-
Alexander Cooper authored
Starting in M83, WebXr uses the permissions api. As such, the custom consent flow that it initially shipped with is no longer needed and can now be removed. Since the change to permissions is launched via finch for M83 (and not enabled by default in code until 84), the feature itself (and the finch configuration) will be left until M86; though it will not change any behavior. The feature is not exposed in about_flags. Bug: 1064384 Change-Id: I7fda1e70bc57feb9977bef7bcd07b47cb93f38ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219161 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#773335}
-
Wan-Teh Chang authored
Add variants of the gfx::ColorSpace::GetRangeAdjustMatrix() and gfx::ColorTransform::NewColorTransform() methods that take bit depths as input parameters, so that the range adjustment for high bit depths can be performed accurately. Use the new gfx::ColorTransform::NewColorTransform() method in AVIFImageDecoder. Tested: gfx_unittests --gtest_filter=*ColorSpace* blink_platform_unittests --gtest_filter=*AVIF* Change-Id: Ib36ba6c05d5d7da3a4d0715ad5880336c0b1693c Bug: 1087192 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213127 Commit-Queue: Wan-Teh Chang <wtc@google.com> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#773334}
-
danakj authored
This is a reland of d18bad64 This changes evaluateInPagePromise() to be evaluateInPageAsync() instead as the latter waits on the promise returned from eval()'ing the code before resolving the promise from the TestRunner. It also puts back the promise returned at the end of the eval()'d code in order for evaluateInPageAsync() to wait on it. Original change's description: > Fix the http/tests/devtools/console-cross-origin-iframe-logging.js test > > This test wants to verify that an error is seen when using a frame in > another origin. It was using a different site, where the frame's > contents is not visible at all when site-isolated. Instead, put the > frame in another origin in the same site so that the main frame can see > the contents of the iframe. > > R=caseq@chromium.org > > Bug: 623268 > Change-Id: Ib4ab03229f1033fc01717e561eb35b3c6d047e2c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218373 > Commit-Queue: danakj <danakj@chromium.org> > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Cr-Commit-Position: refs/heads/master@{#772769} Bug: 623268 Change-Id: I48bdb6ed1b24665c1b2f03a84454d7d4fe2c0360 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220468 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#773333}
-
