- 29 Jan, 2020 29 commits
-
-
Chan Li authored
This reverts commit d6979edd. Reason for revert: Caused compile failures. Sample failed build: https://ci.chromium.org/p/chromium/builders/ci/linux-ozone-rel/108130 Original change's description: > Move external protocol dialog to intent handling metrics. > > The external protocol dialog class recorded metrics that fall under > the purview of the intent handling metrics class, so it has been > moved to be under that class structure. > > BUG=1044710 > TEST=ran IntentHandlingMetrics.* unit tests. > > Change-Id: I156617bb999ca6072c744e117306b48287144c28 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024388 > Reviewed-by: David Jacobo <djacobo@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Commit-Queue: Alex Linker <ajlinker@chromium.org> > Cr-Commit-Position: refs/heads/master@{#736173} TBR=djacobo@chromium.org,dominickn@chromium.org,ajlinker@chromium.org Change-Id: I979e53ee6bf23ae8f80cac4eaac7e6c1792d878d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1044710 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026888Reviewed-by:
Chan Li <chanli@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#736174}
-
alex linker authored
The external protocol dialog class recorded metrics that fall under the purview of the intent handling metrics class, so it has been moved to be under that class structure. BUG=1044710 TEST=ran IntentHandlingMetrics.* unit tests. Change-Id: I156617bb999ca6072c744e117306b48287144c28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024388Reviewed-by:
David Jacobo <djacobo@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Alex Linker <ajlinker@chromium.org> Cr-Commit-Position: refs/heads/master@{#736173}
-
Sky Malice authored
This CL should expose enough to allow a sort of hello world example, but is missing critical pieces. This is because the design is not yet finalized and to try to avoid unnecessary churn. Bug: 1046069 Change-Id: I330222affdfe547685cfec5981f438b0e4ab4922 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023849 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#736172}
-
Daniel Rubery authored
Reporting of interstitials shown was done in SafeBrowsingBlockPage::ShowBlockingPage, but when committed interstitials is enabled, this function is never called. So this CL adds a call to report interstitials shown by the SafeBrowsingNavigationThrottle, which will trigger when committed interstitials is enabled. Bug: 1046525 Change-Id: I06e94f7ecd145352e3be55b3170931479604adf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025930Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#736171}
-
Peter Kasting authored
A whole slew of unrelated small changes: * Use =default more * Shorten code * Better use of idioms like GetMainAxis(), ClampToRange(), StrCat(), etc. * Attempt to improve comments (clearer, briefer, etc.) * Change some {} constructions to constructor syntax. Improves compliance with https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++-dos-and-donts.md#variable-initialization and makes the type in question clearer. * More use of pass-by-value-and-move where callee always copies. * Reorder declarations to match definitions * Eliminate default arg to AllocateFlexSpace(), which just decreased clarity slightly * Remove unnecessary conditionals * Eliminate else after return * Declare variables as close to first use as possible * Implement some equality checks with std::tie() (not required style, but mentioned in totw/43 and tends to reduce maintenance hassle when more fields are added; is also more consistent with how we already used it for some inequalities of these types) * Fix badly-copy-and-pasted param names * Remove unreachable code that also defeats warn-if-unhandled-enum-added Bug: none Change-Id: Ia0b22e1bc8981a3efc601d48c43180de4fd43f08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021293 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#736170}
-
Eugene But authored
Bug: 1046588 Change-Id: I8f3231aa19f029bb2d94d73490f5f8af221b778c TBR: michaeldo@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026372Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#736169}
-
Yi Gu authored
The test was flaky before Nov 2019 and disabled in crrev.com/c/1898295. However crrev.com/c/1917946 re-enabled it perhaps by accident. It's still flaky: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyQQsSBUZsYWtlIjZjaHJvbWl1bUBicm93c2VyX3Rlc3RzQEJvb2ttYXJrc0NvbW1hbmRNYW5hZ2VyVGVzdC5BbGwM TBR=hcarmona@chromium.org Bug: 1010381, 1040698 Change-Id: I96d9a13efdce7a1c3dd6127efb8608d29a3c6335 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026025Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#736168}
-
James Cook authored
It was added to make a decision about decoupling browser page zoom from ARC++/OS zoom. We made the decision and shipped the decoupling in M78. Mark the histogram obsolete and delete the code that records it. Bug: 1043721, 955071 Change-Id: I6b0058e093248041ef8693bb3f7a0b55ab709769 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015570Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#736167}
-
Wenbin Zhang authored
This is a reland of 1547c775 Original change's description: > Set limit for field trial parameters length. > > Windows has a limit of 32767 on a command line. When testing with field > trails, the command to launch chrome.exe may exceed the limit if there're > too many field trial configs passed as parameters. This was causing > the chrome perf waterfall to completely fail on Windows. > > This CL added a presubmit check to see whether the configs under Windows > will exceed the limit of 31000. > > Bug: chromium:1045530 > Change-Id: I9d181783f1bdad58eeba802583c052bfd0321c6f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021468 > Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Reviewed-by: Caleb Rouleau <crouleau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#735981} Bug: chromium:1045530 Change-Id: I04b664b6f8a6b21f6202df95d912bd220d669728 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025511 Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#736166}
-
Steven Bingler authored
Implement UKM metrics in storage_partition_impl to record when cookies are sent or set across schemes. This is the UKM version of the UMAs Cookie.SameSiteDifferentSchemeRequest and Cookie.SameSiteDifferentSchemeResponse. Doing so requires that the CookieInclusionStatus warning field be expanded to include cross-scheme warnings. Bug: 1030938 Change-Id: Iad13d610ae39e4d250157394459297698a2879de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015353Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Steven Bingler <bingler@chromium.org> Cr-Commit-Position: refs/heads/master@{#736165}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/f329c78b6cb0..74f5054ec925 git log f329c78b6cb0..74f5054ec925 --date=short --first-parent --format='%ad %ae %s' 2020-01-28 natlee@microsoft.com Handle Device Lost for Buffer Created with: gclient setdep -r src/third_party/dawn@74f5054ec925 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1042998,chromium:1043468 Tbr: cwallez@google.com Change-Id: Id52c0adf7506a975da2a3ccafed02d91a46bb7fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026023Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736164}
-
Rob Buis authored
Implement baseline adjustment calculation for the children in the row algorithm as well as calculating the baseline adjustment of the row itself. Bug: 6606 Change-Id: If8ec5f8fed28c6008c23284184e3c7e5bd7cc0e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003137 Commit-Queue: Rob Buis <rbuis@igalia.com> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#736163}
-
Ryan Sturm authored
This CL records when the navigation was the user's registered home page or DSE (for both starting URL and committed URL). Bug: 1044295 Change-Id: I25dbaff66720ef8d16ba1fb12225055bb020f2f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013802Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
Darren Shen authored
As a precaution, use the old InputMethodEngine when rulebased flag is off so that we return to old behaviour if we had to turn off the flag due to bugs. Bug: 1034355 Change-Id: I9a2b5288b0ca4f56d5c9972374720dc2318c3b14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026547 Commit-Queue: Leo Zhang <googleo@chromium.org> Reviewed-by:
Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#736161}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I78448c3ed4215014925a6c4ee225419679fb3944 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026408Reviewed-by:
-
Mark Schillaci authored
Added explicit case for <time> tags to prevent node from being ignored as a leaf on Android. This will allow the <time> nodes to be traversed with AT the same as on other platforms. Bug: 1043377 Change-Id: Ibd243578322485d7abafc4b5f7a8dbe0f9986d79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018243Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Mark Schillaci <mschillaci@google.com> Cr-Commit-Position: refs/heads/master@{#736159}
-
Sophie Chang authored
Got botched during migration but kept it with the old naming for consistency Change-Id: I66730a4e98868981a5f9536ee2e27b0d0b461d2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025230Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#736158}
-
Orin Jaworski authored
This CL creates the OmniboxButtonRow feature flag for command-line. Change-Id: I483bd37c212f0ff9bb558c170885ef71940aa77a Bug: 1046523 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024031 Commit-Queue: Orin Jaworski <orinj@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#736157}
-
Eugene But authored
Bug: 1046576 TBR: gambard@chromium.org Change-Id: Ia71daef408c0c6d102dde35b592be89f510ce635 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026467 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
-
Toni Barzic authored
When removing an item from a shelf view, the animation to update item bounds depends on view visibility: * if view is visible, the view first fades out, then the rest of the items' bounds are updated * if view is not visible, the view is removed, and the rest of the items' bounds animate immediately. Though, whether the view is visible is determined only by using View::GetVisible(), while the view may be in visible state, with zero opacity (e.g. during drag and drop from launcher). This case should be handled the same way as views whose visibility is set to false. (Otherwise, removing dragged launcher item from shelf apparently happens in two stages - first items right of the last dragged item spot move left to fill out the void, and then all items animate right to center the hotseat). BUG=1042493 Change-Id: Ic81c0ab24797714f1223d8c8e21282066360dea7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026348Reviewed-by: -
Andres Calderon Jaramillo authored
This CL fixes the service-side transfer cache to report memory correctly for accelerated image decodes. Prior to this CL, the service transfer cache reported multiple planes for hardware decodes (because they were treated as regular YUV decodes). The problem is that the driver does not report per-plane sizes, so we report the whole buffer size for the Y plane and 0 for the other planes. This CL changes that so that hardware image decodes report a single 'dma_buf' memory dump with the whole buffer size. This would be of the form: gpu/transfer_cache/cache_0x123/gpu/entry_0x567/dma_buf However, this only happens for unmipped decodes. When mips are generated, Skia owns the mipped textures, and since we flush pending Skia work before generating the YUV SkImage, we assume that the original unmipped textures are deleted. Therefore, we treat this situation as a regular YUV decode and we don't report the dma_buf dump. Bug: 995156 Test: added a lot of unit test coverage. Change-Id: Ie4990ada28fcbc573e9d85fb0a51a7095ed39cce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933199Reviewed-by:
Stephen White <senorblanco@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#736154}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f03c11602172..ba9da466cca5 git log f03c11602172..ba9da466cca5 --date=short --first-parent --format='%ad %ae %s' 2020-01-28 mtklein@google.com radial gradients in skvm 2020-01-28 herb@google.com Use a monotonic counter for atlas and plot generations 2020-01-28 mtklein@google.com incorporate r,g,b,a into shaderHash 2020-01-28 robertphillips@google.com Expand the compressed_textures GM 2020-01-28 kjlubick@google.com [debugger] Use correct archiver 2020-01-28 herb@google.com Atlas generation numbers is not tracking plot changes -- disable it 2020-01-28 mtklein@google.com prune unused SkPostConfig 2020-01-28 mtklein@google.com add --skvm to DM 2020-01-28 kjlubick@google.com Fix wasm builds Created with: gclient setdep -r src/third_party/skia@ba9da466cca5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1045016 Tbr: reed@google.com Change-Id: I77391d0309838b8f04e81dadbc858a73f9d633cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026014Reviewed-by:
-
Karan Bhatia authored
These are now made redundant by the "allowAllRequests" action. Note we don't officially deprecate the API functions since the API is still in beta. BUG=1038831, 696822 Change-Id: Ie4dfab84de99184e8c22a3f7f95c66c79cc05d64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001347Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#736152}
-
Yi Gu authored
This test is flaky on Linux and Android. See linked bug for details. TBR=mlamouri@chromium.org Bug: 1042417 Change-Id: I9a523e646973a9ce4efb578eff74c7e1961ea099 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026188Reviewed-by:
-
Shubham Aggarwal authored
The test referred to in the bug below has been flaky on multiple platforms: iOS(1032568) and FuchsiaOS(813631) as well as Win 7 and MacOS on Edge. This PR includes a short change which should fix this. It seems like the QuicServer running asynchronously hasn't had time to process all requests which is causing a race condition when the check in line 421 is made. So we wait until the server is finished processing the requests before making the expect check. Bug: 1032568 Change-Id: I52dc909b7167d811126fab99cf2b7ad334b2d96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008627Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#736150}
-
Eugene But authored
Bug: 1046580 TBR: michaeldo@chromium.org Change-Id: Id8424c65cf9f0827ddee02d59dce656184ebcb38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026371Reviewed-by:
-
Christopher Cameron authored
Change metal_util::TestShader to test either compile or link, and change the default behavior to link. Ensure that the Metal calls for the test are invoked on a thread that has base::TaskPriority::HIGHEST. Bug: 974219 Change-Id: I6d2db6c40182286a4af3489968a995dca73e7944 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024922Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#736148}
-
Chris Hamilton authored
This parallels the naming scheme for other parts of Blink's public interface. BUG=803242 Change-Id: Ib92a31fa379c184258e1ef41a9397d707220f3bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025991 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Auto-Submit: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#736147}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/3c63cf70e3b3..e5e522c140a2 git log 3c63cf70e3b3..e5e522c140a2 --date=short --first-parent --format='%ad %ae %s' 2020-01-28 thestig@chromium.org Rename functions in core/ that starts with "FPDF_". 2020-01-28 thestig@chromium.org Assert a cast inside cpdf_imagecacheentry.cpp is safe. 2020-01-28 dhoss@chromium.org Rename Left() and Right() in {Byte,Wide}String{,View} classes 2020-01-28 dhoss@chromium.org Rename First() and Last() {Byte,Wide}String{,View} classes 2020-01-28 tsepez@chromium.org Remove CPDF_ActionFields. Created with: gclient setdep -r src/third_party/pdfium@e5e522c140a2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I3325cc6e65353bdb7ed9f4e05af7f38efbb383e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026010Reviewed-by:
-
- 28 Jan, 2020 11 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9d635962bc78..ea8b58b970c0 git log 9d635962bc78..ea8b58b970c0 --date=short --first-parent --format='%ad %ae %s' 2020-01-28 apolito@google.com add apolito to owners Created with: gclient setdep -r src/third_party/depot_tools@ea8b58b970c0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Ied7d8ee7cef97f99ec249db11f5a72989fd81f36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026017Reviewed-by:
-
Daniel Rubery authored
In order to avoid cutting off the status label "Scan complete, no issues identified", expand the width of the download shelf item to the maximum of the file name label, status label, and the minimum text width (so short filenames aren't shortened by this change). New screenshot: https://screenshot.googleplex.com/YMMaw8r1CRd.png Bug: 1020418 Change-Id: I6ddcf6beb66526b168bf8b826d13d7be394cfc2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023280 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#736144}
-
Yi Gu authored
This test may timeout on CrOS. See bug for details. TBR=oshima@chromium.org Bug: 1043465 Change-Id: Id0381426d3e1b93b3ac413d4ab26a0d475e8d393 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026148Reviewed-by:
-
Philip Rogers authored
As of https://crrev.com/619964, style & layout containment creates an isolation boundary which means clip-related subtree updates can be skipped. PaintLayer::ClippingContainer is used for the clip property tree state of a squashing layer. This clipping container could be an ancestor of a style & layout isolation boundary. If a clip changed on a clipping container ancestor of an isolation boundary, the clip node of squashing layers below could become stale. This patch ensures PaintLayer::ClippingContainer stops at style & layout containment boundaries by making style & layout containment a clip-related property. Bug: 1044895 Change-Id: I898df21c0f65f79114564938042356b7ef587c19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025313 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#736142}
-
Lijin Shen authored
1. Since application context does not work with dark mode, presubmit check will warn users on using it. 2. Setting text color or size instead of text styles will make it hard to maintain if there are some future updates on text colors or sizes. 3. Encourage to use ButtonCompat for consistent style. Bug: 775198, 908651 Change-Id: I3101accd201c3622863fbb45d10abb3d580fcb73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963105 Commit-Queue: Lijin Shen <lazzzis@google.com> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Charlene Yan authored
This includes all actions from the tab group bubble (ungroup, close, color selecting, send feedback) as well as logging when a tab that belongs to a group is closed. Bug: 1040657 Change-Id: I44cda622d9f8e04adc5c9e76a5e841f821edb88e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019861Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#736140}
-
Nicolás Peña Moreno authored
This CL fixes flaky timeout of external/wpt/first-image-child.html by: * Adding a meta tag to let it take long. * Adding HTML tags for iframe and img instead of adding the resources on JS, to make it faster. * Wrapping the core of the test under window load to ensure that the resources are loaded by the time the entries are checked. It's possible that before this CL the iframe was sometimes not ready to receive the message from the parent, causing the test to timeout. Bug: 1041709 Change-Id: I135c11f5f3a8a3f8e3f65012843a61bab7c50aa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025909 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#736139}
-
Alexei Svitkine authored
The new presubmit about Windows command line limit fires with the current tip of tree. This CL attempts to remove more stale field trial configs to get it to pass. Removing both configs where the feature is no longer defined and those where the feature is enabled by default. Note: Not an exhaustive list, just based on some spot checks. Bug: 1045530, 1045636 Change-Id: Ie14de78fbfbc80d30cab931dd405cdc97c3120c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025829 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
-
Xiaoqian Dai authored
Previous CL https://chromium-review.googlesource.com/c/chromium/src/+/1967804 doesn't fix the issue entirely. Looking deeper in this issue, it's actually caused by ClientControlledShellSurface::UpdateBackdrop() can be called on a dragged window (whose backdrop has been disabled (kDisabled) when drag starts) to re-enable the backdrop. This CL makes sure an ARC window with disabled backdrop mode won't be modified. Bug: 1027269 Change-Id: Ia3508a92b5c9133b5821d5f9f0a2345eccad382f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981133Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#734250} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021283Reviewed-by:
-
John Delaney authored
This CL adds a new UI thread class, ConversionManager, owned by the StoragePartition. The ConversionManager initializes and owns a ConversionStorage instance and also implements the ConversionStorage::StorageDelegate. Specific API constraints like delaying conversion reports, and setting the maximum number of conversions are implemented in a separate composable class ConversionPolicy to allow tests to easily mock certain functionality, as well as centralize these constraints to a single include. Intended functionality of the ConversionManager includes: - ownership of the ConversionReporter, and timers for periodically fetching reports to send from storage. - methods to log new impressions / conversions to storage - ownership and usage of Report Cooldown throttling implementations This functionality is intended to be implemented in follow-up CL's due to dependencies, and to keep these changes small. A more complete implementation can be seen on the prototype change below. The functionality of the API is described on https://github.com/csharrison/conversion-measurement-api Design-doc(RVG): https://crbug.com/1039466 Reference prototype change: https://chromium-review.googlesource.com/c/chromium/src/+/1967220 Bug: 1014604 Change-Id: If432b0046b8c6dcd12ce828aea3917cf887fbe08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994016Reviewed-by:Charlie Harrison <csharrison@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#736136}
-
Wez authored
These tests were disabled on Fuchsia because all DomCodes were mapped to native_keycodes of zero. Bug: 829551 Change-Id: I7401117eecfd8e1f4c8af04ad3cc475051699a5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025388 Auto-Submit: Wez <wez@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Reviewed-by:
-
