- 28 Jul, 2020 40 commits
-
-
Andy Lu authored
completion should be called in every branch of the function, and it was not in this one, which is a bug. Separated out from CL: https://chromium-review.googlesource.com/c/chromium/src/+/2236243 so that in case of reverting, this change can stay. Change-Id: If1cf0522b492e8c240253e89432f16d21916da70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320133 Commit-Queue: Andy Lu <andyhylu@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#792327}
-
Sami Kyostila authored
This patch fixes raciness and thread safety issues in NestedMessagePumpAndroid by reimplementing it on top of the regular MessagePumpAndroid. This allows us to remove the complicated 100ms timeslicing logic between Java and C++ tasks and just share the underlying Looper directly. Bug: 872269 Change-Id: Id5f5e42f2dac6f065769d69743d78b1fb04bb916 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207171Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#792326}
-
Caitlin Fischer authored
Also, remove code that logs the histograms and add an owner. Bug: 1110301, b/162309838 Change-Id: I2ac0f064cfe5195640cd87e279195b5d8307582d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323137Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#792325}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 21e6c4e1. With Chromium commits locally applied on WPT: 051a934d "Reland "Reland "Do not expose media devices before a successful getUserMedia()""" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: binji@chromium.org: external/wpt/wasm foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Change-Id: I4b677024dfc032e99e550f5205d25c058f66fcf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323661Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792324}
-
Yann Dago authored
Bug: 1095226 Change-Id: I3c9cdb97eade7d967a434dd252487b1548021e95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317568 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#792323}
-
Zarah Tesfai authored
Purpose: Move payment files to components/ to be used for //weblayer. Change: * Move WebPaymentIntentHelperTypeConverter to /payments/intents * Move CanMakePaymentQuery to /payments * Edit dependencies and targets according to new paths Bug: 1098482 Change-Id: I31ec8ef883522237df49acece0f6108921016ee2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310922 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#792322}
-
Mustaq Ahmed authored
This is not used anywhere. Change-Id: I6e4adf739264a0a6bbd1f8c8a8910f3a07d680c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321068Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#792321}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I1a6b5ac999468514c9f269cbdbe22ca3000dcd81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322212Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792320}
-
Vasiliy Telezhnikov authored
Before https://crrev.com/2302924 we would exit the process on context immediately, so it wasn't problem. Now MarkContextLost abandons GrContext, so we need to abort draw here. Bug: 1109601 Change-Id: I649dffb065fa28a689279e6c8f6619bd9ec29516 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323132Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#792319}
-
Katie D authored
Check if the top center of a window is visible before moving SA focus to that window. It's still possible to end up at an occluded window when restoring SA focus from history, or by going to firstValidChild. We could add an eventhandler to the desktop or a repeated interval to each window node child to check for occlusion. This is left as a TODO. AX-Relnotes: N/A Bug: 1106080 Change-Id: Ib88d53a3b18b8c9f5da2403b61d1624e1258014c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318245 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#792318}
-
Olivier Robin authored
Note that this CL will make autofill follow the keyboard focus. But due to a bug in keyWindow system, this may not be the last webState that was focused on iOS13. See crbug.com/1109124 for details. Bug: 1106743 Change-Id: Ie9e8eccbca6ce0c139fcac423a1ef64adcb70612 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316579Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#792317}
-
Renato Silva authored
Enterprise Enrollment will be skipped and the normal Gaia login will be shown if enrollment was advertised, but isn't mandatory. Bug: 1084442 Change-Id: Ia26d75ebb85eec21942702d43b182b337b4ac858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279891 Commit-Queue: Renato Silva <rrsilva@google.com> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Auto-Submit: Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#792316}
-
dpapad authored
Bug: 1101598 Change-Id: I8a7286166fb204aaaab51fad66d9e1bf398f7047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321147 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#792315}
-
Mehran Mahmoudi authored
This adds a finch-controllable delay before removing the paint preview player on tab first paint, for startup experiment. It also increases the snackbar duration from 5 to 8 seconds. Bug: 1110360 Change-Id: I46d12eae990be2695af4ae7ca2ca27eb28f70902 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323822Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#792314}
-
ckitagawa authored
Additional clients are interested in using the paint preview capture pipeline for other usecases. Some of these do not require link capture. This CL makes link capture optional. It also fixes a small bug where capture size restriction only applied to the main frame. Bug: 1109775 Change-Id: I0b0921537f50ebc6d49a3f6c977ec4b909855d2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320628Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#792313}
-
Xianzhu Wang authored
This fixes the following issues: 1. crbug.com/1109053 we reported transform changes as layout shifts. According to https://github.com/WICG/layout-instability#transform-changes we should ignore transform changes. This is fixed by just accumulating offsets of PaintOffsetTranslations for the additional offset for layout shift (previous offset_to_2d_translation_root, now additional_offset_to_layout_shift_root) Test: external/wpt/layout-instability/transform-change.html 2. Movement of transformed element itself was ignored. This is fixed by resetting the additional offset for layout shift after updating paint properties for child instead of during updating the properties because the offset applies to the transformed element itself. Test: external/wpt/layout-instability/move-transformed.html 3. Stale old additional offset for layout shift (previously baked in FragmentData::VisualRectTo2DTranslationRoot). We don't always update the offset when it changes because it's neither a paint property nor a paint invalidation data, thus the old data may be stale. To avoid that, now save VisualRectForLayoutShiftTracking() which is in the local transform space and is always updated, and recover the old additional offset from the old paint properties. Bug: 1109053,1104794 Change-Id: I36a3dec0695f9674251e7f5ce85ae2411b135eda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316783Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#792312}
-
Ryan Harrison authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/f9ae06512ef7..7778792aec71 $ git log f9ae06512..7778792ae --date=short --no-merges --format='%ad %ae %s' 2020-07-28 post GLSL: Add option to force flattening IO blocks. 2020-07-23 tommek Adding BuiltInSampleMask in HLSL 2020-07-22 tommek Enabling setting a fixed sampleMask in Metal fragment shaders. 2020-02-20 cdavis MSL: Add support for processing more than one patch per workgroup. 2020-07-22 dsinclair Roll GLSLang, SPIRV-Headers and SPIRV-Tools. 2020-07-22 cdavis MSL: Factor creating a uint type into its own method. 2020-07-22 cdavis MSL: Factor a really gnarly condition into its own method. 2020-07-11 post MSVC 2013: Fix silently broken builds. 2020-07-07 troughton MSL: Ensure OpStore source operands are marked for inclusion in function arguments 2020-07-06 dsinclair Roll deps. 2020-07-01 post MSL: Do not emit swizzled writes in packing fixups. 2020-07-01 post MSL: Workaround broken vector -> scalar access chain in MSL. 2020-07-06 post MSL: Use input attachment index directly for resource index fallback. 2020-07-06 post GLSL: Support I/O flattening with arrays as final type. 2020-07-03 post GLSL: Support multi-level struct flattening for I/O. 2020-07-01 post Run format_all.sh. 2020-07-01 post test: Use --hlsl-dx9-compatible when attempting to compile SM 3.0 shaders. 2020-06-30 post GLSL: Fix nested legacy switch workarounds. 2020-06-29 post GLSL: Implement switch on ESSL 1.0. 2020-06-29 post GLSL: Use for-loop fallback instead of do/while for legacy ESSL. 2020-06-29 post Implement context-sensitive expression read tracking. 2020-06-29 post Fix bug with control dependent expression tracking. 2020-06-23 post HLSL: Workaround FXC bugs with degenerate switch blocks. Created with: roll-dep src/third_party/spirv-cross/spirv-cross Change-Id: I2881b6be32307e77fdebdae4e878aadcef284d32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323564 Commit-Queue: Ryan Harrison <rharrison@chromium.org> Commit-Queue: dsinclair <dsinclair@chromium.org> Auto-Submit: Ryan Harrison <rharrison@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Cr-Commit-Position: refs/heads/master@{#792311}
-
Joanmarie Diggs authored
The crash is due to the TextAttributeList never getting set in the TextAttributeMap for the node when the node is an empty Role::kButton from Blink. BrowserAccessibility::IsLeaf was enforcing leafiness for Role::kButton when there is exactly one child and that child is text. In all other cases (including no children), IsLeaf was returning false for buttons. As a result, BrowserAccessibility::ComputeTextAttributeMap was looking to the non-existent children of empty buttons rather than using the default attributes as it does for all other leaf nodes. To fix the crash, and potentially other issues, check for childless buttons in BrowserAccessibility::IsLeaf. AX-Relnotes: Prevents browser crash which can result from an assistive technology asking for the text attributes for an empty button. Bug: 1107407 Change-Id: I985ba0dc5c6eb1b28bcfe9e6c1e18f44ba0fcfe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310332Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#792310}
-
Eugene But authored
Bug: None Change-Id: I8a464113c62651cba7e18c694097d6f3b7798f74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321710Reviewed-by:
Ali Juma <ajuma@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#792309}
-
Nick Burris authored
PaymentHandlerHost uses a WebContents pointer to get devtools. This patch makes PaymentHandlerHost a WebContentsObserver to avoid a potential crash if the WebContents is used after it is destroyed. Bug: 1092532 Change-Id: I0985ac073f0530674a5c4806bdb835063bc33c07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321302Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#792308}
-
Robbie Gibson authored
This reverts commit 42e67c12. Reason for revert: Changed API to use one method to get all content types. Original change's description: > Add async methods to ClipboardRecentContent for URLs > > Bug: 1098722 > Change-Id: Icd9da0e758c288a44716fb6f5a505267a76f42b1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302756 > Commit-Queue: Robbie Gibson <rkgibson@google.com> > Reviewed-by: Olivier Robin <olivierrobin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#789987} TBR=olivierrobin@chromium.org,rkgibson@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1098722 Change-Id: I12f08509596dbf534072296dd03b977a57f9ee48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323682Reviewed-by:
Robbie Gibson <rkgibson@google.com> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#792307}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I93642fbd37fda8939c84124d5e68d70db3716b32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321576Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792306}
-
Boris Sazonov authored
Replace ChromeSigninController in TabSuggestionsServerFetcher with IdentityManager.hasPrimaryAccount(). This is safe to do, because the native side is already loaded - isSignedIn is only called from isEnabled that uses ChromeFeatureList via isServerFetcherFlagEnabled. Bug: 1046412 Change-Id: I98a119f1e37ca49247e7d8533f532bf2c80f9e86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316082Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#792305}
-
Eric Ye authored
display::ConfigureCallback's signature changed in go/cr-rev/2237653 Update call sites that use it. TEST=Build BUG=b/156411764 Change-Id: Ic7981d373aa048d80f5c754e160f7fac0f01c6ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322077 Commit-Queue: Eric Ye <ericye@google.com> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#792304}
-
Andy Lu authored
Now the Chromium shortcuts should work properly in iOS14. Fixed the issue by checking the widget box in intentdefinition file. This widget box only appears in Xcode 12. Also have confirmed that the changes in Intentdefinition is backward compatible with Xcode 11.5. Bug: 1105446 Change-Id: Iff37a8e4caa74ceea577153803b0f115c13751b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311825Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Guillaume Jenkins <gujen@google.com> Commit-Queue: Andy Lu <andyhylu@google.com> Cr-Commit-Position: refs/heads/master@{#792303}
-
John Abd-El-Malek authored
The browsertests should live beside the code they test. Also move the test helpers to be in weblayer/browser so they have access to implementation code. This is a followup to r790896. Change-Id: I8fd1d69308b0780300d641f43d694866f3d2fba5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321723Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#792302}
-
Chris Hamilton authored
This makes FrameTokens consistent with WorkerTokens. A further CL will migrate usage of base::UnguessableToken to FrameToken. BUG=1096617 Change-Id: If29b4e50b17b4ead953b378339df214afd619ddd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314276 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#792301}
-
Omer Katz authored
In practice the bailout is need just for when we trace a backing store. A lot of the bailout calls are no longer needed. Bailout calls remaining after this CL are only for HeapHashTableBacking, HeapVectorBacking and tracing inline buffers of vectors. Bug: 986235 Change-Id: I7909dd01559ca7bda3dea43e8f05ab8cabae7912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317190 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#792300}
-
Elly Fong-Jones authored
At pbos@' suggestion :) Bug: None Change-Id: I1e953cfc7ca79cb9eab0e0de448be5e3897c6d73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323133 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#792299}
-
evliu authored
This CL removes the registration of the SODA component for builds with the enable_soda build flag disabled. Bug: 1110086 Change-Id: I9b55fde2de20ca24909fcc8bca5de65141128ab6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321516Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#792298}
-
K. Moon authored
Adds a new Graphics interface to abstract away Pepper-specific calls to pp::Graphics2D. Also introduces a supporting Image class to allow callers to pass either a pp::ImageData or SkBitmap to Graphics. (The caller is responsible for passing the correct type of image.) The interface only has a Pepper backend currently. A future change will add an implementation backed by an SkSurface. Bug: 1099020 Change-Id: I609e13b4b1abff45814feba04ea1c2522b47444d Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310907Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: K. Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#792297}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/43f111af3540..6df0243a1173 2020-07-28 fmayer@google.com Merge "Relax contract of heapprofd_register_heap." 2020-07-28 treehugger-gerrit@google.com Merge "perfetto-ui: Fix search NaN" 2020-07-28 treehugger-gerrit@google.com Merge "Make TSAN happy about WaitableTestEvent." 2020-07-28 treehugger-gerrit@google.com Merge "Remove unnecessary TEST_SKIP." 2020-07-28 khokhlov@google.com Merge "trace_processor: Lower priority for thread names from metadata events" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I4d0a671d9cf108d3f8c5fdef890bae1abe0cd908 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322593Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792296}
-
Chris Hamilton authored
This adorns SharedWorkerScope with the SharedWorkerToken generated by the browser. BUG=1085129, 1096617 Change-Id: Ib335d7f509e8f9fd5b33e5deca6083f4932fa8ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317851 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#792295}
-
Scott Violet authored
onNavigationStarted() was mentioned twice. The second should be onNavigationRedirected. BUG=none TEST=comment only change Change-Id: I0a6b23a1877256ab09532d4adc8c105345a89a02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323708 Commit-Queue: Scott Violet <sky@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Auto-Submit: Scott Violet <sky@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#792294}
-
Mohamed Heikal authored
A special case rename was added previously because of a rollback of the protobuf runtime. The protobuf runtime has since been rolled forward and thus the special case in BuildConfigGenerator.groovy is no longer needed. Change-Id: Idb392d0fe1aca25e365ae4f53e14e71ba85cbddd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323588 Auto-Submit: Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#792293}
-
Maksim Sisov authored
Don't follow Ozone path if the OzonePlatform feature is disabled. ----- PS: Please note that this is a temp solution that will help to choose between ozone and non-ozone X11 build. The switch that will be used to choose the path is --enable-features=UseOzonePlatform. Once non-Ozone X11 path is removed (hopefully by Q1 2021 depending on how th finch trial goes), the wrapper will be removed. Please also note that it's impossible to build use_x11 && use_ozone without some hacks in PlatformCursor code. The changes to that are on their way to upstream. ---- Bug: 1085700 Change-Id: Ie9bb59c67d5b5aafadd142675e0b568928b5ca5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316198Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#792292}
-
Ian Kilpatrick authored
TBR: dgrogan@chromium.org Bug: 1110253 Change-Id: Ia4c6c8314ccf6c2228df3025c6740e8c28d9b286 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323584Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#792291}
-
Andreea Bacanu authored
Metrics added: - TabManager.TimeSinceTabClosedUntilRestored: records the time from when a tab was closed until the Reopen Closed Tab button was clicked or Ctrl+Shift+T/ Command+Shift+T was pressed. - TabManager.TimeSinceWindowClosedUntilRestored: records the time from when a window was closed until the Reopen Closed Window button was clicked or Ctrl+Shift+T/ Command+Shift+T was pressed. altimin: histograms.xml sky: session_restore_browsertest.cc, tab_restore_service_helper.cc BUG=1100946 Change-Id: Ic6d3196abd8907cda5be12cdc32ce83a82e97060 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294090 Commit-Queue: Andreea Bacanu <aebacanu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Sreeja Kamishetty <sreejakshetty@chromium.org> Reviewed-by:
Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#792290}
-
Alex Ilin authored
TabGridDialogTest#testRenderDialog_3Tabs_Landscape__NightModeEnabled is flaky both on CI bots and on CQ bots. TBR=yusufo@chromium.org Bug: 1110099 Change-Id: I8428cc3a585b3e7f2ff5515f699c071defd87298 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323291Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#792289}
-
Joshua Pawlicki authored
Bug: 1099779 Change-Id: I877767ccc0fc7fad10cd2da9120413fd5db65a6a Fixed: 1099779 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323781 Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#792288}
-