- 07 Jan, 2020 40 commits
-
-
Sammie Quon authored
Failing because new hotseat window targeter was eating events that the EasyResizeWindowTargeter was handling. Changed the hotseat window targeter to only be active when the hotseat is extended. Test: ash_unittests Fixed: 1037927 Change-Id: Iff20db682d55348cc3ac090f5af90b86db268d61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987114 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#728774}
-
Lachlan Ford authored
If the browser is running in sandboxed mode on win32, only OpenXR runtimes that support running in an appcontainer should be used. Runtimes declare this support through the XR_EXT_win32_appcontainer_compatible extension. Fixes: 1036527 Change-Id: Ia4d18542439712e1d169b0b54588ab9b47489ef5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979526 Commit-Queue: Lachlan Ford <laford@microsoft.com> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#728773}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f6a6ff85. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I49e919f6d0311c7471656e0f861fabc2e79e6390 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989047Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728772}
-
Hayato Ito authored
The test is flaky on other than ASAN and TSAN. TBR=tommycli@chromium.org,robliao@chromium.org Bug: 1030551 Change-Id: I8cf22b93f1c7f3bc4c7c21b3e3d0e484fe6d5458 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986544Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#728771}
-
Jack Lynch authored
This CL disables some tests that will be broken by [1] and fixed by [2]. [1] https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1891267 [2] https://chromium-review.googlesource.com/c/chromium/src/+/1636716 Bug: 963183 Change-Id: I2eba775c16c8be2918329a51e996d3fa9684b2fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894751 Commit-Queue: Jack Lynch <jalyn@microsoft.com> Reviewed-by:
Robert Paveza <Rob.Paveza@microsoft.com> Cr-Commit-Position: refs/heads/master@{#728770}
-
Brian Sheedy authored
Switches wayland_client_perftests to use PerfResultReporter instead of PrintResult and whitelists it for conversion to histograms before uploading to the perf dashboard. Bug: 923564 Change-Id: Ie90b89386aafe88fe1b3274eda193237a2d328b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988859 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#728769}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8ccbcf70c079..a8b0b9cbdf85 Created with: gclient setdep -r src-internal@a8b0b9cbdf85 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I3667803fefc0fcb22d19092c431b78a37f4e22ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989105Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728768}
-
chromium-autoroll authored
Roll airmont AFDO profile from 81-3987.18-1577702544-benchmark-81.0.4016.0-r1 to 81-3987.18-1578309018-benchmark-81.0.4016.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I6c6348e7ee5bb8f8c381acd93b21b623c6e7a9b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989226Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728767}
-
Dale Curtis authored
Crashes suggest that we're sometimes passing out an AudioBuffer which has an unknown sample format. This shouldn't be allowed. BUG=1032338 TEST=none, can't reproduce. R=tguilbert Change-Id: I2562e8c60a9666e91a2003c5272d600474720ae9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988891 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#728766}
-
Taylor Bergquist authored
Change-Id: I86d84f3e59c57fc7ff71e1d2de01489e70a5479f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987129 Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#728765}
-
Nate Fischer authored
No change to logic. This disables a flaky test across all API levels. TBR=qinmin@chromium.org Bug: 1039491 Test: None Change-Id: I556322058b88387492cb0e4af3e98c61b1b4fcc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989088Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#728764}
-
Bettina authored
chrome_password_protection_service.cc calls a stack that eventually needs site_engagement_details.mojom.h and the dependency wasn't specified in the BUILD file previously. Bug: 1038845 Fixes: 1038845 Change-Id: I746b55cd13f23e1935e934f9a4c1653fd2a45e78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987194Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Auto-Submit: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#728763}
-
Ahmed Mehfooz authored
Bug: 1035134 Change-Id: I219e533a62db489d23b9b873f38bc8f884fe533d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974601 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#728762}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I64a3e011fc59c538e44153b13d5241afdb499a3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988805Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#728761}
-
Julie Jeongeun Kim authored
This is a part of effort for using [RaisesException] when synchronously rejecting a promise. It uses [RaisesException] for //third_party/blink/renderer/modules/mediastream. Bug: 1001114 Change-Id: I3fde5022c2a992e5f04e4419fd9e960c5a42dbb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988126Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#728760}
-
Julie Jeongeun Kim authored
This is a part of effort for using [RaisesException] when synchronously rejecting a promise. It uses [RaisesException] for //third_party/blink/renderer/modules/scheduler. Bug: 1001114 Change-Id: Ic51051ce7b109e30a8995f8c5185abb6eef9d25f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980262Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#728759}
-
Hirokazu Honda authored
It is needed that a thread has made GL context current before FrameRendererThumbnail::CreateVideoFrame() is called. Otherwise, the gl functions called in CreateTexture() causes a segmentation fault. But the test code doesn't fulfill this if it runs with VaapiVDA. This fixes the issue by making GL context current in FrameRendererThumbnail::CreateVideoFrame(). Bug: 1037926 Test: VDA test on guado Change-Id: I41e9778886d205196038deac17c1a84cc0874635 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985738 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#728758}
-
Miriam Zimmerman authored
Bug: 997480 Change-Id: I6738a19078beb447e5e67e307ec700fc77665502 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973358 Auto-Submit: Miriam Zimmerman <mutexlox@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#728757}
-
Tsuyoshi Horo authored
When HtmlImportsRequestInitiatorLock is disabled, FrameLoader::document_loader_ is cleared by FrameLoader::DetachDocument() before FrameLoader::DetachDocument() calls Document::Shutdown() -> HTMLImportsController::Dispose() -> HTMLImportLoader::Dispose() -> Document::ClearImportsController() -> ResourceFetcher::ClearContext() -> DetachableResourceFetcherProperties::Detach() -> FrameResourceFetcherProperties::WebBundlePhysicalUrl() -> FrameOrImportedDocument::GetMasterDocumentLoader() -> FrameLoader::GetDocumentLoader() So frame_or_imported_document_->GetMasterDocumentLoader() returns invalid reference of DocumentLoader. This is causing crashes from Dec 20 when HtmlImportsRequestInitiatorLock was disabled in M80 using Field Trial Testing Configuration. To avoid this crash, this cl change FrameResourceFetcherProperties not to call ResourceFetcherProperties::WebBundlePhysicalUrl() from DetachableResourceFetcherProperties::Detach(). Bug: 1036049 Change-Id: If6a947ebec0dbbea0e39d5eb979eed8c8d39f018 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978340Reviewed-by:Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#728756}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/a57e2eca02d1..068dd89cab31 git log a57e2eca02d1..068dd89cab31 --date=short --first-parent --format='%ad %ae %s' 2020-01-06 bclayton@google.com SPIRV-Tools: Update Android.bp to fix build. Created with: gclient setdep -r src/third_party/swiftshader@068dd89cab31 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I5fd9ee3ead2d8c59b3a86cbf61142b777a1033c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988544Reviewed-by:
-
Stephen Martinis authored
Changes to only the *.pyl files don't matter. We should only run every test if they actually change the json files. Change-Id: Ie817c4a92d78e8a58304b7af260288044a99dd51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988853 Auto-Submit: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#728754}
-
Wenbin Zhang authored
Currently when the build failed on uploading perf data, it will not be reported. We should return failure when this happens. Bug: chromium:1035935 Change-Id: I1c01e30747266263bbd1ed8ea83754c21fc5846c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984724 Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Reviewed-by:
-
llin@chromium.org authored
Bug: b/146018217 Test: manual Change-Id: Iadbaa847c3aef7f78cbecf44d0d50e64aacca4c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970262Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Li Lin <llin@chromium.org> Cr-Commit-Position: refs/heads/master@{#728752}
-
Adrienne Walker authored
This is no longer needed and was only used for internal testing. Also, hook the force closed event up properly and don't route it through the schema event. Bug: 1015214 Change-Id: I378e49ac4beaac62d3a513801934555abf90e895 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989045Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#728751}
-
Gyuyoung Kim authored
This CL cleans up unnecessary mojo/public/cpp/bindings/binding.h includes in //ui/ozone. Bug: 955171 Change-Id: I55221d9c2b72d3223940292e96c4f4d16f7b832c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978479Reviewed-by:
Maksim Sisov <msisov@igalia.com> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#728750}
-
Robert Liao authored
This reverts commit a79e01b5. Reason for revert: This test fails on Mac10.13 bots First failure: https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20%28dbg%29/16594 [ RUN ] TabManagerTest.DiscardTabsWithOccludedWindow [81401:775:0106/112821.053347:INFO:content_main_runner_impl.cc(966)] Chrome is running in full browser mode. [81401:775:0106/112821.247127:ERROR:device.mm(28)] Failed to find MTLDevice. [81401:48159:0106/112821.651720:WARNING:notification_platform_bridge_mac.mm(542)] AlertNotificationService: XPC connection invalidated. [81417:775:0106/112823.114183:ERROR:device.mm(28)] Failed to find MTLDevice. [81417:775:0106/112823.119549:ERROR:vt_video_encode_accelerator_mac.cc(517)] VTCompressionSessionCreate failed: -12908 [81401:775:0106/112824.022443:WARNING:gaia_auth_fetcher.cc(989)] Could not reach Google Accounts servers: errno -11 [81429:775:0106/112824.262864:ERROR:runtime_enabled_features.cc(2100)] RuntimeEnabledFeature not recognized: PageLifecycle [81428:775:0106/112824.389850:ERROR:runtime_enabled_features.cc(2100)] RuntimeEnabledFeature not recognized: PageLifecycle [81401:775:0106/112824.920521:WARNING:gaia_auth_fetcher.cc(989)] Could not reach Google Accounts servers: errno -11 [81433:775:0106/112826.323872:ERROR:runtime_enabled_features.cc(2100)] RuntimeEnabledFeature not recognized: PageLifecycle [81401:775:0106/112827.522912:WARNING:gaia_auth_fetcher.cc(989)] Could not reach Google Accounts servers: errno -102 [81401:775:0106/112836.042665:WARNING:gaia_auth_fetcher.cc(989)] Could not reach Google Accounts servers: errno -102 ../../content/public/test/browser_test_base.cc:622: Failure Failed RunLoop::Run() timed out. Stack trace: 0 libbase.dylib 0x00000001390da89d base::debug::StackTrace::StackTrace(unsigned long) + 29 1 libbase.dylib 0x00000001390da878 base::debug::StackTrace::StackTrace() + 40 2 browser_tests 0x0000000104a1df56 StackTraceGetter::CurrentStackTrace(int, int) + 134 3 browser_tests 0x0000000104a2eb03 testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop(int) + 83 4 browser_tests 0x0000000104a2e53a testing::internal::AssertHelper::operator=(testing::Message const&) const + 154 5 browser_tests 0x0000000107c38bbe _ZZN4base25MakeExpectedNotRunClosureERKNS_8LocationENS_16BasicStringPieceINSt3__112basic_stringIcNS4_11char_traitsIcEENS4_9allocatorIcEEEEEEENK3$_0clES2_SB_ + 126 6 browser_tests 0x0000000107c38b16 _ZN4base8internal13FunctorTraitsIZNS_25MakeExpectedNotRunClosureERKNS_8LocationENS_16BasicStringPieceINSt3__112basic_stringIcNS6_11char_traitsIcEENS6_9allocatorIcEEEEEEE3$_0vE6InvokeIRKSE_JS4_RKSC_EEEvOT_DpOT0_ + 102 7 browser_tests 0x0000000107c38a37 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKZNS_25MakeExpectedNotRunClosureERKNS_8LocationENS_16BasicStringPieceINSt3__112basic_stringIcNS8_11char_traitsIcEENS8_9allocatorIcEEEEEEE3$_0JS6_RKSE_EEEvOT_DpOT0_ + 71 8 browser_tests 0x0000000107c389e3 _ZN4base8internal7InvokerINS0_9BindStateIZNS_25MakeExpectedNotRunClosureERKNS_8LocationENS_16BasicStringPieceINSt3__112basic_stringIcNS7_11char_traitsIcEENS7_9allocatorIcEEEEEEE3$_0JS3_SD_EEEFvvEE7RunImplIRKSF_RKNS7_5tupleIJS3_SD_EEEJLm0ELm1EEEEvOT_OT0_NS7_16integer_sequenceImJXspT1_EEEE + 99 9 browser_tests 0x0000000107c38972 _ZN4base8internal7InvokerINS0_9BindStateIZNS_25MakeExpectedNotRunClosureERKNS_8LocationENS_16BasicStringPieceINSt3__112basic_stringIcNS7_11char_traitsIcEENS7_9allocatorIcEEEEEEE3$_0JS3_SD_EEEFvvEE3RunEPNS0_13BindStateBaseE + 66 10 libbase.dylib 0x00000001390887a5 base::OnceCallback<void ()>::Run() && + 117 Original change's description: > Re-enable TabManagerTest.DiscardTabsWithMinimizedAndOccludedWindows. > > The crash stack on the bug is in non-TabManager code. Let's see if > the test passes when re-enabled. > > This CL also: > - Splits the test in 2 tests to avoid timing out (local tests show > that we can time out when having too many navigations in the same > test). > - On ChromeOS, allows discarding of the active tab in the last focused > browser window if that window is not visible. Previously, the active > tab in the last focused browser window was not discardable, even if > the window was not visible. > > Bug: 772839 > Change-Id: I18552a16361c8beb4d48409227b727a40cc40ec7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972570 > Commit-Queue: Chris Hamilton <chrisha@chromium.org> > Auto-Submit: François Doray <fdoray@chromium.org> > Reviewed-by: Chris Hamilton <chrisha@chromium.org> > Cr-Commit-Position: refs/heads/master@{#728572} TBR=chrisha@chromium.org,fdoray@chromium.org Change-Id: I0bf70f2be84485c7ffca7f4e2e015e5038eb0a9b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 772839 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986693Reviewed-by:
-
Austin Eng authored
Set dawn_swiftshader_dir so Dawn can be built using swiftshader in a Chromium checkout. Note: This does not affect Dawn unless dawn_use_swiftshader=true Bug: dawn:283, dawn:295 Change-Id: I84ff58a8598b3f34e78a9fa5376f7616f48d22a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986261 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#728748}
-
Antonio Gomes authored
Instead, code now uses the WTF counterpart helpers. BUG=78725 R=haraken@chromium.org Change-Id: Ib34512d50dcebb862b6022cfda70b31920e483ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988294Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#728747}
-
Adrian Taylor authored
Change-Id: I033216b6bcd459e087781bdadf46f72e8f6f670f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988227Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Andrew Whalley <awhalley@chromium.org> Cr-Commit-Position: refs/heads/master@{#728746}
-
Dana Fried authored
Need these for hover card previews. Bug: 1037337 Change-Id: I99e94993023697a030a35f34f52782f7b26cbb93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982269 Auto-Submit: Dana Fried <dfried@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#728745}
-
Matt Mueller authored
Bug: 973650 Change-Id: I10d86d2fa7a573f2f22abdb09878ceeca05a0411 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985033Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Auto-Submit: Matt Mueller <mattm@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#728744}
-
Tomasz Wiszkowski authored
This metric shows how frequently the native and java caches of Suggestions are out of sync when suggestion is selected. Lets take a second look at if there is anything we can do to reduce this further. Bug: 1036920 Change-Id: I42d8b359ee968808c907432246e8ab44aa2f35f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986334Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#728743}
-
Theodore Dubois authored
Bug: 1026733 Change-Id: I464c643052a1c49ab90ad4a80e1b95c38542d32a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927037Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#728742}
-
Kevin Babbitt authored
ExpandToEnclosingUnit for format units will call CreatePreviousFormatStartPosition on the starting position. That method will begin its search from the start of the node to which the position is currently anchored. But if that position happens to be at MaxTextOffset for its anchor, that should be treated as equivalent to offset 0 for the next text anchor. The result is that we would incorrectly expand the range backward if the node happened to be at a format boundary. The fix is to normalize the start position before doing any expansion. I also ensured that the unit test for ExpandToEnclosingUnit covers each of the cases enumerated in MSDN. Bug: 928948 Change-Id: I0eda71990b69800d5464560e1a08b8f5c387b907 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970587 Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#728741}
-
Kurt Horimoto authored
This CL updates BadgeMediator to be constructed with a Browser in preparation for a follow-up CL where the mediator will observe the OverlayPresenter for the Browser in order to update the InfobarBadgeTabHelper for banner presentations and dismissals. This CL also cleans up and updates the mediator: - Adds readwrite property for the active WebState, allowing easy access to the WebState as well as facilitating idempotent updates via |-updateForNewWebState:oldWebState:|. - Adds a readonly property for the active WebState's InfobarBadgeTabHelper. - Since a Browser's BrowserState is constant over the Browser's lifetime, we don't need to check whether the newly-activated WebState is incognito. Instead, the incognito badge item is just created once upon initialization. - Updates order of protocol implementations to match declaration order. - Updates test fixture to use params so that both the incognito and normal browsing behavior can be tested. Bug: 1030357 Change-Id: If7a5b4761ea4fd8e558120d1cfc14eb806c75290 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986860 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#728740}
-
danakj authored
Also gets some of chromecast/media/. Use OnceCallback where possible because the callback is only used once and RepeatingCallback and BindRepeating otherwise. R=servolk@chromium.org Tbr: dcheng@chromium.org Bug: 1007648, 1007647 Change-Id: I5a5a7c6f00fb1462a0004620f01b6d60a81c1abd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967930Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Auto-Submit: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#728739}
-
Leon Han authored
Adds "const" modifier to all members of blink::NDEFRecord. Making members "const" can express clearly that these information are not expected to be changed over time, once they're set by Ctors they are just fixed. BUG=520391 Change-Id: I6358415be91b2d9f36dfe66778677a8b0d9233b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981259Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#728738}
-
Hirokazu Honda authored
V4L2VEA prepends the latest SPS and PPS with IDR frame. V4L2VEA does so whenever there is an IDR frame. A single bitstream buffer returned by BitstreamBufferReady() may have two SPS and PPS, if one buffer returned by an encoder driver contains SPS, PPS and IDR frame. Bug: b:143672449 Test: android.hardware.camera2.cts.RecordingTest#testBasicRecording Change-Id: I559570df31de4684522f1b4b1db9a3277221f68e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986690 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#728737}
-
Hayato Ito authored
This CL is the part in a series of CLs, roughly described as follows: 1. Refactor SeriviceWorkerTimeoutTimer Unify normal events and pending tasks. 2. Rename SeriviceWorkerTimeoutTimer to ServiceWorkerEventQueue. 3. Further clean up ServiceWorkerEventQueue. 4. Support offline events in ServiceWorkerEventQueue 5. Support offline mode in ServiceWorkerGlobalScope (<= This CL.) - Mimic an internet disconnected environment in ServiceWorkerFetchContext. - Support dispatching offline-capability-check events in ServiceWorkerFetchDispatcher. 6. Provide a high layer API to check SW's offline capability on the top of ServiceWorkerFetchDispatcher (https://crrev.com/c/1900804/). The basic ideas are: - SW now has an offline-mode. If an offline mode is enabled, a fetch always fails, returning INTERNET_DISCONNECTED error, to mimic an offline environment. - A high layer API dispatches a *fake* fetch event, offline-capability-check fetch event, which is used to detect the offline capability of a SW. - SW becomes offline-mode while dispatching an offline-capability-check fetch event. - If a fetch event handler returns a 200 for an offline-capability-check fetch event, SW is considered as having an offline capability. The previous CLs implemented the basic functionality for *throttling* offline events and non-offline events so that they don't run at the same time in ServiceWorkerEventQueue. This CL implements other necessary parts such as: - Mimics an internet disconnected environment; offline-mode - Enter (or Exit) offline mode at the right timing - Support offline-capability-check fetch event dispatch in ServiceWorkerFetchDispatcher After this CL, we are adding a high layer API on the top of ServiceWorkerFetchDispatcher at http://crrev.com/c/1900804/. Note that NavigationPreloads are not handled yet in this CL. See crbug.com/1031950. Bug: 965802 Change-Id: Id47191ae30a9051683678159b581f2863c27702b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900803Reviewed-by:Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#728736}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ba37867fd234..35435063fca1 git log ba37867fd234..35435063fca1 --date=short --first-parent --format='%ad %ae %s' 2020-01-06 jbudorick@chromium.org devil: stop checking for /root in devices using system-as-root partitions. Created with: gclient setdep -r src/third_party/catapult@35435063fca1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:922145 Tbr: nuskos@google.com Change-Id: I82093c918cd1d7e7c97ba952e326ea8489618a27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988697Reviewed-by:
-
