GitLab

Following bot results are included.
11014 11018 11022 11038 11044 11048 11053 11059 11062

2 lines were removed and 4 lines were deflaked by consecutive
results since 10995.

TBR=eae@chromium.org, mstensho@chromium.org
NOTRY=true

Bug: 591099
Change-Id: Ic5ef6f5050c1310249066cd6e6bd12cabe0e4ea9
Reviewed-on: https://chromium-review.googlesource.com/c/1296729
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602365}

Work area is not always starts from the top of the display, e.g, docked
magnifier will put a view port window at the top area of the display.
This will cause that in portrait screen orientation, the height of the
work area is not always larger than the width of the work area. This cl
tried to fix this by updating the divider position on
|divider_closest_ratio_| instead on relying on the longer side of the
work area.
This cl also fixed the wrong bounds of the preview area, which was set
in its own view coordinate. So should special consider the case that
work area is not from the top of the display too.

Bug: 866680, 897900
Change-Id: I86a98aee52ecbd706385cda0a639e5182997914b
Reviewed-on: https://chromium-review.googlesource.com/c/1292833
Commit-Queue: Min Chen <minch@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602364}

Up until now headers were removed from |sources| and then
reinserted. Cleaner/easier is to never remove them from the start.

Change-Id: I8f7560ef96f409880647e2924c2f71317f519468
Reviewed-on: https://chromium-review.googlesource.com/c/1290969Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#602363}

Original developer and main maintainer.

Change-Id: Ia7eacd431f2d83c30ffb5231745b8fcfab8ebd21
Reviewed-on: https://chromium-review.googlesource.com/c/1297135Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#602362}

This CL adds a switch enum to chrome://flags to change the icon
displayed by the search button in the bottom toolbar.

Bug: 866013
Change-Id: I1892cb02f42bc6d1324e276b9022663e48b45b3b
Reviewed-on: https://chromium-review.googlesource.com/c/1297972
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602361}

This reverts commit cbcb1c3c.

Reason for revert: breaking win-asan https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/win-asan/1941

Original change's description:
> Roll src/third_party/perfetto 78f4835a7135..c365e36901fe (3 commits)
> 
> https://android.googlesource.com/platform/external/perfetto.git/+log/78f4835a7135..c365e36901fe
> 
> 
> git log 78f4835a7135..c365e36901fe --date=short --no-merges --format='%ad %ae %s'
> 2018-10-24 fmayer@google.com profiling: Add fuzzer for unwinding.
> 2018-10-24 treehugger-gerrit@google.com Merge "profiling: Fix register size calculation."
> 2018-10-24 treehugger-gerrit@google.com Merge "perfetto: Add ASAN container size annotations to PagedMemory"
> 
> 
> Created with:
>   gclient setdep -r src/third_party/perfetto@c365e36901fe
> 
> The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll
> 
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
> 
> If the roll is causing failures, please contact the current sheriff, who should
> be CC'd on the roll, and stop the roller if necessary.
> 
> 
> TBR=perfetto-bugs@google.com
> 
> Change-Id: I3b9ef13668609404211f3779a56f9be144b2c761
> Reviewed-on: https://chromium-review.googlesource.com/c/1297340
> Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/master@{#602327}

TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,perfetto-bugs@google.com

Change-Id: I2c09d46fef5dca92de7b1280418cc5a5d6be0f51
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/1298121Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602360}

In jumbo builds, many cc files compile in the same translation
unit which means that they also share the same anonymous namespace.
This makes it necessary for constants and global scope functions
to have names that are unique in the build target.

This particular error only happens in extreme jumbo (many files
compiled at once) and not the more modest jumbo configurations
(8-50 files compiled at once) I think.

Change-Id: I86d15bcfd5c55db9592cb9423943d2e46b8f2e5c
Reviewed-on: https://chromium-review.googlesource.com/c/1297361Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#602359}

ScrollCustomization currently places the API surface on Element rather
than Node, meaning a callback can only be set on Elements. This becomes
a problem as the Document node is not an Element but is the node that's
used to perform scrolling for the frame's viewport. This causes all
kinds of contortions in various places in scrolling code. One example
where this is causing an issue is https://crrev.com/c/1287176. See also
ScrollManager::RecomputeScrollChain.

This CL is a mechanical move of ScrollCustomization to use Node as the
primitive on which callbacks operate. This will allow us to simplify
scrolling code in several places; however, this patch is just a
mechanical movement of the code from Element to Node. Future patches
will actually modify the behavior to make use of the fact that we can
now use the document node.

Bug: 897288
Change-Id: I0cab17888d30f981b731848f5ba6e499f966efca
Reviewed-on: https://chromium-review.googlesource.com/c/1297576Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602358}

Switch a few Cache Storage-related code paths from generic
Bind/Callback to BindOnce/OnceCallback.

Bug: 714018
Change-Id: I245cb56090228865cb0f4957caf8f704568eac39
Reviewed-on: https://chromium-review.googlesource.com/c/1289433Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602357}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cbe27839a04c..cebaec875850


Created with:
  gclient setdep -r src-internal@cebaec875850

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Ie214ab101e3181983792c81e54e055bb2ceaf439
Reviewed-on: https://chromium-review.googlesource.com/c/1297348Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#602356}

Using wpt-import in Chromium fd794c0e.
With Chromium commits locally applied on WPT:
f79c6fe7 "Reimplementing getDatabaseNames() as databases() for indexeddb."
89bcea96 "[run_web_tests] Remove extra baselines after crrev.com/c/1277654"
36e64bc7 "Updating tests for Window onerror is not triggered bug fix."


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/26639

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
jfernandez@igalia.com:
  external/wpt/css/css-align

NOAUTOREVERT=true
TBR=kyleju

No-Export: true
Change-Id: Iea316aee8fbc659751689bc13df5bffdcb019ec9
Reviewed-on: https://chromium-review.googlesource.com/c/1298050
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602355}

With this change, if the user is logged into Chrome,
and unless authentication is disabled with
  --autofill-assistant-auth=false
the service will send out oauth credentials with the request.

This is one step towards making only authenticated calls.

Bug: 806868
Change-Id: I504a06af842869739ba44230d57f2a58259a480c
Reviewed-on: https://chromium-review.googlesource.com/c/1275890
Commit-Queue: Stephane Zermatten <szermatt@chromium.org>
Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602354}

When a ParkableString is parked, do it in a separate task on the requester
thread. This is required to introduce compression.

This asynchronous parking means that a string can be in 3 states: unparked,
parking in progress or parked.

This CL adds:
- Asynchronous parking.
- Tracking of parked strings in ParkableStringManager
- Actual string parking with DCHECK_IS_ON()

Bug: 877044
Change-Id: Iece0e1338872aa6c315c9417a1050107494b676c
Reviewed-on: https://chromium-review.googlesource.com/c/1293570
Commit-Queue: Benoit L <lizeb@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602353}

Also, reduce file size from 8MB to 4MB because that's what is reported
by the most recent metrics indicate.  And remove a block of obsolete
code doing an unnecessary disk access.

Bug: 896394
Change-Id: I8830fce2f467044550d5f01597ae5d1a998689f4
Reviewed-on: https://chromium-review.googlesource.com/c/1294293Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602352}

We introduced a bug in cl/1283474. The added item should have been to the end
of PageLoadTimingStatus, and corresponding change should have been made to
enums.xml. And, the added item was actually not necessary. This Cl remove the
introduced item.

Bug: 869924
Change-Id: Idedde9b86f82ea027cb7924369364f068559a82e
Reviewed-on: https://chromium-review.googlesource.com/c/1297743Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Commit-Queue: Liquan (Max) Gǔ <maxlg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602351}

This CL converts AboutChromeCollectionViewController to use TableView
instead of collection view.
It also updates the VersionItem to be displayed as a cell instead of as
an item. It means that the callback when the version is tapped cannot
happen in the VC. So the cell has a button copying the version to the
pasteboard when tapped.

Bug: 894791
Change-Id: I6cdae4b09235bb6f72e2dbffac88a5dd9f78e67a
Reviewed-on: https://chromium-review.googlesource.com/c/1291390
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602350}

These UMAs where taking almost 25% of CPU time in our perf test,
lets remove them for now.  We can reland later if we're more
cautious about how frequetly we sample.

Bug: 897751
Change-Id: Ib8cd6b572d818fe62d4b19ede0274916558a3099
Reviewed-on: https://chromium-review.googlesource.com/c/1293910Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602349}

Bug: 670615
Change-Id: Ic386bad40225688c259613fde7f8d81de00044b5
Reviewed-on: https://chromium-review.googlesource.com/c/1288678
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602348}

Refactor the method that sets the parameters for the resource
scheduler. This CL does not introduce any functionality
change.

Bug: 897371
Change-Id: I2018e8d5662a3481d7c32ee7342f82c976979836
Reviewed-on: https://chromium-review.googlesource.com/c/1297574Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602347}

Bug: 878390
Change-Id: Ibdaeafbc6d32970641a5a8562125eb15b0bfedf7
Reviewed-on: https://chromium-review.googlesource.com/c/1277659
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602346}

Bug: 878856
Change-Id: Id6f84e3f58557ddd91850b52729f5d0eeea8eff3
Reviewed-on: https://chromium-review.googlesource.com/c/1297073Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Greg Kerr <kerrnel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602345}

This CL uses ScopedBlockingCall to mark blocking calls in /chrome/browser/apps/platform_apps/.

This CL was created by replacing calls to AssertBlockingAllowed()
with instantiations of ScopedBlockingCall(MAY_BLOCK).
I kindly ask the reviewer to make sure of the following:
  - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
    If this is not the case, ScopedBlockingCall should be instantiated
    closer to the blocking call. See scoped_blocking_call.h for more
    info. Please let me know when/where the blocking call happens if this needs
    to be changed.
  - Parameter |blocking_type| matches expectation:
      MAY_BLOCK: The call might block (e.g. file I/O that might hit in memory cache).
      WILL_BLOCK: The call will definitely block (e.g. cache already checked and now pinging
        server synchronously).
    See BlockingType for more info. While I assumed MAY_BLOCK by default, that might
    not be the best fit if we know that this callsite is guaranteed to block.
  - The ScopedBlockingCall's scope covers the entirety of the blocking operation
    previously asserted against by the AssertBlockingAllowed().

This CL was uploaded by git cl split.

TBR=dominickn@chromium.org

Bug: 874080
Change-Id: Iceac744a259b8feaba56efc153c0eaed7392cf90
Reviewed-on: https://chromium-review.googlesource.com/c/1255601
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602344}

Test is flaky on Chrome OS.

TBR: sky@chromium.org
Bug: 898502
Change-Id: I2376c7fb562a2216e40de1c0f3909e862f722f9e
Reviewed-on: https://chromium-review.googlesource.com/c/1298051Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602343}

This CL adds a check needed to properly produce first input
events when the PerformanceObserver is only observing
'firstInput' but not 'event'.

Bug: 898484

Change-Id: I8331b0c174a51db65a9388d67054dfbf5a7ecfba
Reviewed-on: https://chromium-review.googlesource.com/c/1296689Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602342}

https://skia.googlesource.com/skia.git/+log/b11ab578ad63..dc82994e3a76


git log b11ab578ad63..dc82994e3a76 --date=short --no-merges --format='%ad %ae %s'
2018-10-24 bsalomon@google.com Revert "Reland "Reland "Revert "Use OpenGL sampler objects when available.""""
2018-10-24 mtklein@google.com we don't need two ways to disable lowp


Created with:
  gclient setdep -r src/third_party/skia@dc82994e3a76

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
TBR=brianosman@chromium.org

Change-Id: I3127eed2cdbd13a54dfdb6c0b81ef062accdfaa9
Reviewed-on: https://chromium-review.googlesource.com/c/1297345Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#602341}

WebLocalFrameImpl::VisiblePositionForViewportPoint() is unused, remove it.
Reduce usage of VisiblePosition also.

Bug: 657237
Change-Id: I9a6588c856a68ad88975771cab206e7e19a29fd7
Reviewed-on: https://chromium-review.googlesource.com/c/1297850
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602340}

The test was previously marked as timing out on Windows. However:
- It does occasionally pass.
- It doesn't actually time out on Windows Release.
- It does time out in Debug builds on other platforms though.

TBR=pdr@chromium.org

Bug: 666993, 898456
Change-Id: I5071af34d4fdb8bed911e864b28ce81eb954fff0
Reviewed-on: https://chromium-review.googlesource.com/c/1297146Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602339}

https://chromium.googlesource.com/catapult.git/+log/7b6a59fda6b6..00455e014868


git log 7b6a59fda6b6..00455e014868 --date=short --no-merges --format='%ad %ae %s'
2018-10-24 perezju@chromium.org [soundwave] Add "health" study for branch review reports


Created with:
  gclient setdep -r src/third_party/catapult@00455e014868

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:879526
TBR=sullivan@chromium.org

Change-Id: I79e49cf3fe0661bacacd96ff7b4632629cb2ea49
Reviewed-on: https://chromium-review.googlesource.com/c/1297346Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#602338}

Implementing unified consent rollback. Related with: crrev.com/c/1165226

Bug: 883089
Change-Id: Id54379e57d79bfd7666f48fba2174ffb18627dc5
Reviewed-on: https://chromium-review.googlesource.com/c/1297970Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602337}

The runtime flag GetUserMedia is no longer needed as
navigator.getUserMedia shipped in M53

BUG=607439

Change-Id: Id58babefdb6611e27021d0b2b1af2119d785bf8a
Reviewed-on: https://chromium-review.googlesource.com/c/1296594Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com>
Cr-Commit-Position: refs/heads/master@{#602336}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fbcd8762f2cc..cbe27839a04c


Created with:
  gclient setdep -r src-internal@cbe27839a04c

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Ie5ed34cf8fc22a49646752a0a524d01ab1bac13f
Reviewed-on: https://chromium-review.googlesource.com/c/1297342Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#602335}

Bug: 898157
Change-Id: I4c372530cc7a0b6098239a80eeae81e881888de2
Reviewed-on: https://chromium-review.googlesource.com/c/1296320Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602334}

https://webrtc.googlesource.com/src.git/+log/e068ad62628f..8e6749e0dd3f


git log e068ad62628f..8e6749e0dd3f --date=short --no-merges --format='%ad %ae %s'
2018-10-24 titovartem@google.com Improve fileutils_override implementation internal API.


Created with:
  gclient setdep -r src/third_party/webrtc@8e6749e0dd3f

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I6b31ae277952bceb1ed7eee1829f9d1304ee7a34
Reviewed-on: https://chromium-review.googlesource.com/c/1297341Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#602333}

There's no need for ThreadControllerWithMessagePumpImpl::DoWork
to call ScheduleWork.  Typically it's called in a for loop, or
something equivalent.

Redundant calls to ScheduleWork are not free and show up on
profiles of SequenceManagerPerfTest.

Bug: 897751
Change-Id: Iafebf0b574d991ea3b89dfc101aa7326cd35b3c1
Reviewed-on: https://chromium-review.googlesource.com/c/1297137Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602332}

Tiny refactor of the C source generating Python functions.
No bugfix / feature at all. But the result of calling
'updated_auto_generated_sources.sh' doesn't need to be
fixed by 'git cl format' anymore.

- Prevent trailing whitespace on commented lines produced
  by CSourceForComments().

- More consistent output from CSourceForIntegerHexArray()
  and CSourceForConstCharArray() by using a common
  CSourceForArrayData() function that takes a lambda to
  format individual values.

R=pasko@chromium.org, agrieve@chromium.org
BUG=NONE

Change-Id: Ifc9c5c175a3432acb5ce3d7918259c4ee294dd04
Reviewed-on: https://chromium-review.googlesource.com/c/1297423Reviewed-by: David Turner <digit@chromium.org>
Reviewed-by: Egor Pasko <pasko@chromium.org>
Commit-Queue: David Turner <digit@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602331}

While AsyncDNS resolver is perfectly capable of following a CNAME chain,
it doesn't return the owner name for an address record. This field is
important for callers of the resolver who expected the returned
AddressList to contain the correct canonical name.

This CL fixes the issue by plumbing the name into the AddressList.
I.e. assume we have the following RRs:

  www.foo.example.       1000    IN     CNAME   host.foo.example.
  host.foo.example.      1000    IN     A       10.10.10.10

The canonical name for www.foo.example is host.foo.example since that's
the owner name for the A record. Prior to this CL the AsyncDNS resolver
would return www.foo.example. After the CL it returns host.foo.example.

Bug: 883969
Change-Id: I8a44f68e2dbbb1726467fde0c65c1d4e9ee304d4
Reviewed-on: https://chromium-review.googlesource.com/c/1292435Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Asanka Herath <asanka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602330}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/07d0f9dff3d2..18fe6d59e5e8


git log 07d0f9dff3d2..18fe6d59e5e8 --date=short --no-merges --format='%ad %ae %s'
2018-10-24 stevenperron@google.com Fix dead branch elim infinite loop. (#2009)


Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@18fe6d59e5e8

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I4b114ccc5e6c40cce1c2bcc9fe40340fc9af68ab
Reviewed-on: https://chromium-review.googlesource.com/c/1297344Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#602329}

Using wpt-import in Chromium 7d89b5e7.
With Chromium commits locally applied on WPT:
f79c6fe7 "Reimplementing getDatabaseNames() as databases() for indexeddb."
89bcea96 "[run_web_tests] Remove extra baselines after crrev.com/c/1277654"
36e64bc7 "Updating tests for Window onerror is not triggered bug fix."


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/26638

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
bjonesbe@adobe.com:
  external/wpt/css/css-shapes

NOAUTOREVERT=true
TBR=kyleju

No-Export: true
Change-Id: Ibc02f5e4324d2346f72ebd4a8cd8be3e7a3e7eed
Reviewed-on: https://chromium-review.googlesource.com/c/1297725
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602328}

https://android.googlesource.com/platform/external/perfetto.git/+log/78f4835a7135..c365e36901fe


git log 78f4835a7135..c365e36901fe --date=short --no-merges --format='%ad %ae %s'
2018-10-24 fmayer@google.com profiling: Add fuzzer for unwinding.
2018-10-24 treehugger-gerrit@google.com Merge "profiling: Fix register size calculation."
2018-10-24 treehugger-gerrit@google.com Merge "perfetto: Add ASAN container size annotations to PagedMemory"


Created with:
  gclient setdep -r src/third_party/perfetto@c365e36901fe

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I3b9ef13668609404211f3779a56f9be144b2c761
Reviewed-on: https://chromium-review.googlesource.com/c/1297340Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#602327}

One of the hazards of using the ContextGL and RasterInterface from
RasterContextProvider is that the texture bindings could become
inconsistent between the 2. This CL makes RasterImplementationGLES2
check the bindings in GLES2Implementation, which should help reduce
inconsistencies.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I84394fe279cca0f02c6d41c9f5b5a3319772f33b
Bug: 897724
Reviewed-on: https://chromium-review.googlesource.com/c/1289513Reviewed-by: Victor Miura <vmiura@chromium.org>
Commit-Queue: Jonathan Backer <backer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602326}